1 files changed, 58 insertions, 56 deletions

diff --git a/drivers/message/i2o/exec-osm.c b/drivers/message/i2o/exec-osm.c
index 9c339a2505b0..9bb9859f6dfe 100644
--- a/drivers/message/i2o/exec-osm.c
+++ b/drivers/message/i2o/exec-osm.c
@@ -33,7 +33,7 @@
 #include <linux/workqueue.h>
 #include <linux/string.h>
 #include <linux/slab.h>
-#include <linux/sched.h>   /* wait_event_interruptible_timeout() needs this */
+#include <linux/sched.h>        /* wait_event_interruptible_timeout() needs this */
 #include <asm/param.h>          /* HZ */
 #include "core.h"
 
@@ -75,11 +75,9 @@ static struct i2o_exec_wait *i2o_exec_wait_alloc(void)
 {
         struct i2o_exec_wait *wait;
 
-        wait = kmalloc(sizeof(*wait), GFP_KERNEL);
+        wait = kzalloc(sizeof(*wait), GFP_KERNEL);
         if (!wait)
-                return ERR_PTR(-ENOMEM);
-
-        memset(wait, 0, sizeof(*wait));
+                return NULL;
 
         INIT_LIST_HEAD(&wait->list);
 
@@ -114,13 +112,12 @@ static void i2o_exec_wait_free(struct i2o_exec_wait *wait)
  *      Returns 0 on success, negative error code on timeout or positive error
  *      code from reply.
  */
-int i2o_msg_post_wait_mem(struct i2o_controller *c, u32 m, unsigned long
-                          timeout, struct i2o_dma *dma)
+int i2o_msg_post_wait_mem(struct i2o_controller *c, struct i2o_message *msg,
+                          unsigned long timeout, struct i2o_dma *dma)
 {
         DECLARE_WAIT_QUEUE_HEAD(wq);
         struct i2o_exec_wait *wait;
         static u32 tcntxt = 0x80000000;
-        struct i2o_message __iomem *msg = i2o_msg_in_to_virt(c, m);
         int rc = 0;
 
         wait = i2o_exec_wait_alloc();
@@ -138,15 +135,15 @@ int i2o_msg_post_wait_mem(struct i2o_controller *c, u32 m, unsigned long
          * We will only use transaction contexts >= 0x80000000 for POST WAIT,
          * so we could find a POST WAIT reply easier in the reply handler.
          */
-        writel(i2o_exec_driver.context, &msg->u.s.icntxt);
+        msg->u.s.icntxt = cpu_to_le32(i2o_exec_driver.context);
         wait->tcntxt = tcntxt++;
-        writel(wait->tcntxt, &msg->u.s.tcntxt);
+        msg->u.s.tcntxt = cpu_to_le32(wait->tcntxt);
 
         /*
          * Post the message to the controller. At some point later it will
          * return. If we time out before it returns then complete will be zero.
          */
-        i2o_msg_post(c, m);
+        i2o_msg_post(c, msg);
 
         if (!wait->complete) {
                 wait->wq = &wq;
@@ -266,13 +263,14 @@ static int i2o_msg_post_wait_complete(struct i2o_controller *c, u32 m,
  *
  *      Returns number of bytes printed into buffer.
  */
-static ssize_t i2o_exec_show_vendor_id(struct device *d, struct device_attribute *attr, char *buf)
+static ssize_t i2o_exec_show_vendor_id(struct device *d,
+                                       struct device_attribute *attr, char *buf)
 {
         struct i2o_device *dev = to_i2o_device(d);
         u16 id;
 
-        if (i2o_parm_field_get(dev, 0x0000, 0, &id, 2)) {
-                sprintf(buf, "0x%04x", id);
+        if (!i2o_parm_field_get(dev, 0x0000, 0, &id, 2)) {
+                sprintf(buf, "0x%04x", le16_to_cpu(id));
                 return strlen(buf) + 1;
         }
 
@@ -286,13 +284,15 @@ static ssize_t i2o_exec_show_vendor_id(struct device *d, struct device_attribute
  *
  *      Returns number of bytes printed into buffer.
  */
-static ssize_t i2o_exec_show_product_id(struct device *d, struct device_attribute *attr, char *buf)
+static ssize_t i2o_exec_show_product_id(struct device *d,
+                                        struct device_attribute *attr,
+                                        char *buf)
 {
         struct i2o_device *dev = to_i2o_device(d);
         u16 id;
 
-        if (i2o_parm_field_get(dev, 0x0000, 1, &id, 2)) {
-                sprintf(buf, "0x%04x", id);
+        if (!i2o_parm_field_get(dev, 0x0000, 1, &id, 2)) {
+                sprintf(buf, "0x%04x", le16_to_cpu(id));
                 return strlen(buf) + 1;
         }
 
@@ -362,7 +362,9 @@ static void i2o_exec_lct_modified(struct i2o_controller *c)
         if (i2o_device_parse_lct(c) != -EAGAIN)
                 change_ind = c->lct->change_ind + 1;
 
+#ifdef CONFIG_I2O_LCT_NOTIFY_ON_CHANGES
         i2o_exec_lct_notify(c, change_ind);
+#endif
 };
 
 /**
@@ -385,23 +387,22 @@ static int i2o_exec_reply(struct i2o_controller *c, u32 m,
         u32 context;
 
         if (le32_to_cpu(msg->u.head[0]) & MSG_FAIL) {
+                struct i2o_message __iomem *pmsg;
+                u32 pm;
+
                 /*
                  * If Fail bit is set we must take the transaction context of
                  * the preserved message to find the right request again.
                  */
-                struct i2o_message __iomem *pmsg;
-                u32 pm;
 
                 pm = le32_to_cpu(msg->body[3]);
-
                 pmsg = i2o_msg_in_to_virt(c, pm);
+                context = readl(&pmsg->u.s.tcntxt);
 
                 i2o_report_status(KERN_INFO, "i2o_core", msg);
 
-                context = readl(&pmsg->u.s.tcntxt);
-
                 /* Release the preserved msg */
-                i2o_msg_nop(c, pm);
+                i2o_msg_nop_mfa(c, pm);
         } else
                 context = le32_to_cpu(msg->u.s.tcntxt);
 
@@ -462,25 +463,26 @@ static void i2o_exec_event(struct i2o_event *evt)
  */
 int i2o_exec_lct_get(struct i2o_controller *c)
 {
-        struct i2o_message __iomem *msg;
-        u32 m;
+        struct i2o_message *msg;
         int i = 0;
         int rc = -EAGAIN;
 
         for (i = 1; i <= I2O_LCT_GET_TRIES; i++) {
-                m = i2o_msg_get_wait(c, &msg, I2O_TIMEOUT_MESSAGE_GET);
-                if (m == I2O_QUEUE_EMPTY)
-                        return -ETIMEDOUT;
-
-                writel(EIGHT_WORD_MSG_SIZE | SGL_OFFSET_6, &msg->u.head[0]);
-                writel(I2O_CMD_LCT_NOTIFY << 24 | HOST_TID << 12 | ADAPTER_TID,
-                       &msg->u.head[1]);
-                writel(0xffffffff, &msg->body[0]);
-                writel(0x00000000, &msg->body[1]);
-                writel(0xd0000000 | c->dlct.len, &msg->body[2]);
-                writel(c->dlct.phys, &msg->body[3]);
-
-                rc = i2o_msg_post_wait(c, m, I2O_TIMEOUT_LCT_GET);
+                msg = i2o_msg_get_wait(c, I2O_TIMEOUT_MESSAGE_GET);
+                if (IS_ERR(msg))
+                        return PTR_ERR(msg);
+
+                msg->u.head[0] =
+                    cpu_to_le32(EIGHT_WORD_MSG_SIZE | SGL_OFFSET_6);
+                msg->u.head[1] =
+                    cpu_to_le32(I2O_CMD_LCT_NOTIFY << 24 | HOST_TID << 12 |
+                                ADAPTER_TID);
+                msg->body[0] = cpu_to_le32(0xffffffff);
+                msg->body[1] = cpu_to_le32(0x00000000);
+                msg->body[2] = cpu_to_le32(0xd0000000 | c->dlct.len);
+                msg->body[3] = cpu_to_le32(c->dlct.phys);
+
+                rc = i2o_msg_post_wait(c, msg, I2O_TIMEOUT_LCT_GET);
                 if (rc < 0)
                         break;
 
@@ -506,29 +508,29 @@ static int i2o_exec_lct_notify(struct i2o_controller *c, u32 change_ind)
 {
         i2o_status_block *sb = c->status_block.virt;
         struct device *dev;
-        struct i2o_message __iomem *msg;
-        u32 m;
+        struct i2o_message *msg;
 
         dev = &c->pdev->dev;
 
-        if (i2o_dma_realloc(dev, &c->dlct, sb->expected_lct_size, GFP_KERNEL))
+        if (i2o_dma_realloc
+            (dev, &c->dlct, le32_to_cpu(sb->expected_lct_size), GFP_KERNEL))
                 return -ENOMEM;
 
-        m = i2o_msg_get_wait(c, &msg, I2O_TIMEOUT_MESSAGE_GET);
-        if (m == I2O_QUEUE_EMPTY)
-                return -ETIMEDOUT;
-
-        writel(EIGHT_WORD_MSG_SIZE | SGL_OFFSET_6, &msg->u.head[0]);
-        writel(I2O_CMD_LCT_NOTIFY << 24 | HOST_TID << 12 | ADAPTER_TID,
-               &msg->u.head[1]);
-        writel(i2o_exec_driver.context, &msg->u.s.icntxt);
-        writel(0, &msg->u.s.tcntxt);    /* FIXME */
-        writel(0xffffffff, &msg->body[0]);
-        writel(change_ind, &msg->body[1]);
-        writel(0xd0000000 | c->dlct.len, &msg->body[2]);
-        writel(c->dlct.phys, &msg->body[3]);
-
-        i2o_msg_post(c, m);
+        msg = i2o_msg_get_wait(c, I2O_TIMEOUT_MESSAGE_GET);
+        if (IS_ERR(msg))
+                return PTR_ERR(msg);
+
+        msg->u.head[0] = cpu_to_le32(EIGHT_WORD_MSG_SIZE | SGL_OFFSET_6);
+        msg->u.head[1] = cpu_to_le32(I2O_CMD_LCT_NOTIFY << 24 | HOST_TID << 12 |
+                                     ADAPTER_TID);
+        msg->u.s.icntxt = cpu_to_le32(i2o_exec_driver.context);
+        msg->u.s.tcntxt = cpu_to_le32(0x00000000);
+        msg->body[0] = cpu_to_le32(0xffffffff);
+        msg->body[1] = cpu_to_le32(change_ind);
+        msg->body[2] = cpu_to_le32(0xd0000000 | c->dlct.len);
+        msg->body[3] = cpu_to_le32(c->dlct.phys);
+
+        i2o_msg_post(c, msg);
 
         return 0;
 };