5 files changed, 39 insertions, 68 deletions

diff --git a/drivers/media/video/pvrusb2/Kconfig b/drivers/media/video/pvrusb2/Kconfig
index 158b3d0c6532..9620c67fae77 100644
--- a/drivers/media/video/pvrusb2/Kconfig
+++ b/drivers/media/video/pvrusb2/Kconfig
@@ -1,14 +1,15 @@
 config VIDEO_PVRUSB2
         tristate "Hauppauge WinTV-PVR USB2 support"
-        depends on VIDEO_V4L2 && I2C && EXPERIMENTAL
+        depends on VIDEO_V4L2 && I2C
         select FW_LOADER
-        select VIDEO_TUNER
+        select MEDIA_TUNER
         select VIDEO_TVEEPROM
         select VIDEO_CX2341X
         select VIDEO_SAA711X
         select VIDEO_CX25840
         select VIDEO_MSP3400
         select VIDEO_WM8775
+        select VIDEO_CS53L32A
         ---help---
           This is a video4linux driver for Conexant 23416 based
           usb2 personal video recorder devices.
@@ -16,32 +17,6 @@ config VIDEO_PVRUSB2
           To compile this driver as a module, choose M here: the
           module will be called pvrusb2
 
-config VIDEO_PVRUSB2_ONAIR_CREATOR
-        bool "pvrusb2 driver support for OnAir Creator model"
-        depends on VIDEO_PVRUSB2 && EXPERIMENTAL
-        select VIDEO_SAA711X
-        select VIDEO_CS53L32A
-        ---help---
-
-          This option enables support for the OnAir Creator USB tuner
-          device.  This is a hybrid device, however currently only
-          analog mode is supported.
-
-          If you are in doubt, say Y.
-
-config VIDEO_PVRUSB2_ONAIR_USB2
-        bool "pvrusb2 driver support for OnAir USB2 model"
-        depends on VIDEO_PVRUSB2 && EXPERIMENTAL
-        select VIDEO_SAA711X
-        select VIDEO_CS53L32A
-        ---help---
-
-          This option enables support for the OnAir USB2 tuner device
-          (also known as the Sasem tuner).  This is a hybrid device,
-          however currently only analog mode is supported.
-
-          If you are in doubt, say Y.
-
 config VIDEO_PVRUSB2_SYSFS
         bool "pvrusb2 sysfs support (EXPERIMENTAL)"
         default y
@@ -59,29 +34,23 @@ config VIDEO_PVRUSB2_SYSFS
           Note: This feature is experimental and subject to change.
 
 config VIDEO_PVRUSB2_DVB
-        bool "pvrusb2 DVB support (EXPERIMENTAL)"
-        default n
+        bool "pvrusb2 ATSC/DVB support (EXPERIMENTAL)"
+        default y
         depends on VIDEO_PVRUSB2 && DVB_CORE && EXPERIMENTAL
         select DVB_LGDT330X if !DVB_FE_CUSTOMISE
         select DVB_S5H1409 if !DVB_FE_CUSTOMISE
         select DVB_S5H1411 if !DVB_FE_CUSTOMISE
         select DVB_TDA10048 if !DVB_FE_CUSTOMIZE
-        select DVB_TDA18271 if !DVB_FE_CUSTOMIZE
-        select TUNER_SIMPLE if !DVB_FE_CUSTOMISE
-        select TUNER_TDA8290 if !DVB_FE_CUSTOMIZE
+        select MEDIA_TUNER_TDA18271 if !DVB_FE_CUSTOMIZE
+        select MEDIA_TUNER_SIMPLE if !DVB_FE_CUSTOMISE
+        select MEDIA_TUNER_TDA8290 if !DVB_FE_CUSTOMIZE
         ---help---
 
-          This option enables compilation of a DVB interface for the
-          pvrusb2 driver.  Currently this is very very experimental.
-          It is also limiting - the DVB interface can only access the
-          digital side of hybrid devices, and there are going to be
-          issues if you attempt to mess with the V4L side at the same
-          time.  Don't turn this on unless you know what you are
-          doing.
-
-          If you are in doubt, say N.
+          This option enables a DVB interface for the pvrusb2 driver.
+          If your device does not support digital television, this
+          feature will have no affect on the driver's operation.
 
-          Note: This feature is very experimental and might break
+          If you are in doubt, say Y.
 
 config VIDEO_PVRUSB2_DEBUGIFC
         bool "pvrusb2 debug interface"
diff --git a/drivers/media/video/pvrusb2/Makefile b/drivers/media/video/pvrusb2/Makefile
index 5b3083c89aa9..4fda2de69ab7 100644
--- a/drivers/media/video/pvrusb2/Makefile
+++ b/drivers/media/video/pvrusb2/Makefile
@@ -16,5 +16,6 @@ pvrusb2-objs	:= pvrusb2-i2c-core.o pvrusb2-i2c-cmd-v4l2.o \
 obj-$(CONFIG_VIDEO_PVRUSB2) += pvrusb2.o
 
 EXTRA_CFLAGS += -Idrivers/media/video
+EXTRA_CFLAGS += -Idrivers/media/common/tuners
 EXTRA_CFLAGS += -Idrivers/media/dvb/dvb-core
 EXTRA_CFLAGS += -Idrivers/media/dvb/frontends
diff --git a/drivers/media/video/pvrusb2/pvrusb2-debug.h b/drivers/media/video/pvrusb2/pvrusb2-debug.h
index 11537ddf8aa3..707d2d9635d7 100644
--- a/drivers/media/video/pvrusb2/pvrusb2-debug.h
+++ b/drivers/media/video/pvrusb2/pvrusb2-debug.h
@@ -54,6 +54,7 @@ extern int pvrusb2_debug;
 #define PVR2_TRACE_DATA_FLOW  (1 << 25) /* Track data flow */
 #define PVR2_TRACE_DEBUGIFC   (1 << 26) /* Debug interface actions */
 #define PVR2_TRACE_GPIO       (1 << 27) /* GPIO state bit changes */
+#define PVR2_TRACE_DVB_FEED   (1 << 28) /* DVB transport feed debug */
 
 
 #endif /* __PVRUSB2_HDW_INTERNAL_H */
diff --git a/drivers/media/video/pvrusb2/pvrusb2-devattr.c b/drivers/media/video/pvrusb2/pvrusb2-devattr.c
index 3a141d93e1a9..5bf6d8fda1f9 100644
--- a/drivers/media/video/pvrusb2/pvrusb2-devattr.c
+++ b/drivers/media/video/pvrusb2/pvrusb2-devattr.c
@@ -153,7 +153,6 @@ static const struct pvr2_device_desc pvr2_device_gotview_2d = {
 
 
 
-#ifdef CONFIG_VIDEO_PVRUSB2_ONAIR_CREATOR
 /*------------------------------------------------------------------------*/
 /* OnAir Creator */
 
@@ -212,11 +211,9 @@ static const struct pvr2_device_desc pvr2_device_onair_creator = {
                 .dvb_props = &pvr2_onair_creator_fe_props,
 #endif
 };
-#endif
 
 
 
-#ifdef CONFIG_VIDEO_PVRUSB2_ONAIR_USB2
 /*------------------------------------------------------------------------*/
 /* OnAir USB 2.0 */
 
@@ -274,7 +271,6 @@ static const struct pvr2_device_desc pvr2_device_onair_usb2 = {
                 .dvb_props = &pvr2_onair_usb2_fe_props,
 #endif
 };
-#endif
 
 
 
@@ -497,14 +493,10 @@ struct usb_device_id pvr2_device_table[] = {
           .driver_info = (kernel_ulong_t)&pvr2_device_gotview_2},
         { USB_DEVICE(0x1164, 0x0602),
           .driver_info = (kernel_ulong_t)&pvr2_device_gotview_2d},
-#ifdef CONFIG_VIDEO_PVRUSB2_ONAIR_CREATOR
         { USB_DEVICE(0x11ba, 0x1003),
           .driver_info = (kernel_ulong_t)&pvr2_device_onair_creator},
-#endif
-#ifdef CONFIG_VIDEO_PVRUSB2_ONAIR_USB2
         { USB_DEVICE(0x11ba, 0x1001),
           .driver_info = (kernel_ulong_t)&pvr2_device_onair_usb2},
-#endif
         { USB_DEVICE(0x2040, 0x7300),
           .driver_info = (kernel_ulong_t)&pvr2_device_73xxx},
         { USB_DEVICE(0x2040, 0x7500),
diff --git a/drivers/media/video/pvrusb2/pvrusb2-dvb.c b/drivers/media/video/pvrusb2/pvrusb2-dvb.c
index 6504c97e0bbc..6ec4bf81fc7f 100644
--- a/drivers/media/video/pvrusb2/pvrusb2-dvb.c
+++ b/drivers/media/video/pvrusb2/pvrusb2-dvb.c
@@ -21,6 +21,7 @@
 #include <linux/kthread.h>
 #include <linux/freezer.h>
 #include "dvbdev.h"
+#include "pvrusb2-debug.h"
 #include "pvrusb2-hdw-internal.h"
 #include "pvrusb2-hdw.h"
 #include "pvrusb2-io.h"
@@ -35,7 +36,7 @@ static int pvr2_dvb_feed_func(struct pvr2_dvb_adapter *adap)
         struct pvr2_buffer *bp;
         struct pvr2_stream *stream;
 
-        printk(KERN_DEBUG "dvb thread started\n");
+        pvr2_trace(PVR2_TRACE_DVB_FEED, "dvb feed thread started");
         set_freezable();
 
         stream = adap->channel.stream->stream;
@@ -82,7 +83,7 @@ static int pvr2_dvb_feed_func(struct pvr2_dvb_adapter *adap)
         /* If we get here and ret is < 0, then an error has occurred.
            Probably would be a good idea to communicate that to DVB core... */
 
-        printk(KERN_DEBUG "dvb thread stopped\n");
+        pvr2_trace(PVR2_TRACE_DVB_FEED, "dvb feed thread stopped");
 
         return 0;
 }
@@ -210,7 +211,8 @@ static int pvr2_dvb_ctrl_feed(struct dvb_demux_feed *dvbdmxfeed, int onoff)
         do {
                 if (onoff) {
                         if (!adap->feedcount) {
-                                printk(KERN_DEBUG "start feeding\n");
+                                pvr2_trace(PVR2_TRACE_DVB_FEED,
+                                           "start feeding demux");
                                 ret = pvr2_dvb_stream_start(adap);
                                 if (ret < 0) break;
                         }
@@ -218,7 +220,8 @@ static int pvr2_dvb_ctrl_feed(struct dvb_demux_feed *dvbdmxfeed, int onoff)
                 } else if (adap->feedcount > 0) {
                         (adap->feedcount)--;
                         if (!adap->feedcount) {
-                                printk(KERN_DEBUG "stop feeding\n");
+                                pvr2_trace(PVR2_TRACE_DVB_FEED,
+                                           "stop feeding demux");
                                 pvr2_dvb_stream_end(adap);
                         }
                 }
@@ -230,15 +233,13 @@ static int pvr2_dvb_ctrl_feed(struct dvb_demux_feed *dvbdmxfeed, int onoff)
 
 static int pvr2_dvb_start_feed(struct dvb_demux_feed *dvbdmxfeed)
 {
-        printk(KERN_DEBUG "start pid: 0x%04x, feedtype: %d\n",
-               dvbdmxfeed->pid, dvbdmxfeed->type);
+        pvr2_trace(PVR2_TRACE_DVB_FEED, "start pid: 0x%04x", dvbdmxfeed->pid);
         return pvr2_dvb_ctrl_feed(dvbdmxfeed, 1);
 }
 
 static int pvr2_dvb_stop_feed(struct dvb_demux_feed *dvbdmxfeed)
 {
-        printk(KERN_DEBUG "stop pid: 0x%04x, feedtype: %d\n",
-               dvbdmxfeed->pid, dvbdmxfeed->type);
+        pvr2_trace(PVR2_TRACE_DVB_FEED, "stop pid: 0x%04x", dvbdmxfeed->pid);
         return pvr2_dvb_ctrl_feed(dvbdmxfeed, 0);
 }
 
@@ -259,7 +260,8 @@ static int pvr2_dvb_adapter_init(struct pvr2_dvb_adapter *adap)
                                    &adap->channel.hdw->usb_dev->dev,
                                    adapter_nr);
         if (ret < 0) {
-                err("dvb_register_adapter failed: error %d", ret);
+                pvr2_trace(PVR2_TRACE_ERROR_LEGS,
+                           "dvb_register_adapter failed: error %d", ret);
                 goto err;
         }
         adap->dvb_adap.priv = adap;
@@ -276,7 +278,8 @@ static int pvr2_dvb_adapter_init(struct pvr2_dvb_adapter *adap)
 
         ret = dvb_dmx_init(&adap->demux);
         if (ret < 0) {
-                err("dvb_dmx_init failed: error %d", ret);
+                pvr2_trace(PVR2_TRACE_ERROR_LEGS,
+                           "dvb_dmx_init failed: error %d", ret);
                 goto err_dmx;
         }
 
@@ -286,7 +289,8 @@ static int pvr2_dvb_adapter_init(struct pvr2_dvb_adapter *adap)
 
         ret = dvb_dmxdev_init(&adap->dmxdev, &adap->dvb_adap);
         if (ret < 0) {
-                err("dvb_dmxdev_init failed: error %d", ret);
+                pvr2_trace(PVR2_TRACE_ERROR_LEGS,
+                           "dvb_dmxdev_init failed: error %d", ret);
                 goto err_dmx_dev;
         }
 
@@ -304,7 +308,7 @@ err:
 
 static int pvr2_dvb_adapter_exit(struct pvr2_dvb_adapter *adap)
 {
-        printk(KERN_DEBUG "unregistering DVB devices\n");
+        pvr2_trace(PVR2_TRACE_INFO, "unregistering DVB devices");
         dvb_net_release(&adap->dvb_net);
         adap->demux.dmx.close(&adap->demux.dmx);
         dvb_dmxdev_release(&adap->dmxdev);
@@ -320,7 +324,7 @@ static int pvr2_dvb_frontend_init(struct pvr2_dvb_adapter *adap)
         int ret = 0;
 
         if (dvb_props == NULL) {
-                err("fe_props not defined!");
+                pvr2_trace(PVR2_TRACE_ERROR_LEGS, "fe_props not defined!");
                 return -EINVAL;
         }
 
@@ -328,13 +332,15 @@ static int pvr2_dvb_frontend_init(struct pvr2_dvb_adapter *adap)
             &adap->channel,
             (1 << PVR2_CVAL_INPUT_DTV));
         if (ret) {
-                err("failed to grab control of dtv input (code=%d)",
+                pvr2_trace(PVR2_TRACE_ERROR_LEGS,
+                           "failed to grab control of dtv input (code=%d)",
                     ret);
                 return ret;
         }
 
         if (dvb_props->frontend_attach == NULL) {
-                err("frontend_attach not defined!");
+                pvr2_trace(PVR2_TRACE_ERROR_LEGS,
+                           "frontend_attach not defined!");
                 ret = -EINVAL;
                 goto done;
         }
@@ -342,7 +348,8 @@ static int pvr2_dvb_frontend_init(struct pvr2_dvb_adapter *adap)
         if ((dvb_props->frontend_attach(adap) == 0) && (adap->fe)) {
 
                 if (dvb_register_frontend(&adap->dvb_adap, adap->fe)) {
-                        err("frontend registration failed!");
+                        pvr2_trace(PVR2_TRACE_ERROR_LEGS,
+                                   "frontend registration failed!");
                         dvb_frontend_detach(adap->fe);
                         adap->fe = NULL;
                         ret = -ENODEV;
@@ -359,7 +366,8 @@ static int pvr2_dvb_frontend_init(struct pvr2_dvb_adapter *adap)
                 adap->fe->ops.ts_bus_ctrl = pvr2_dvb_bus_ctrl;
 
         } else {
-                err("no frontend was attached!");
+                pvr2_trace(PVR2_TRACE_ERROR_LEGS,
+                           "no frontend was attached!");
                 ret = -ENODEV;
                 return ret;
         }