aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/media/video/cx23885/cx23885-cards.c
diff options
context:
space:
mode:
Diffstat (limited to 'drivers/media/video/cx23885/cx23885-cards.c')
-rw-r--r--drivers/media/video/cx23885/cx23885-cards.c17
1 files changed, 6 insertions, 11 deletions
diff --git a/drivers/media/video/cx23885/cx23885-cards.c b/drivers/media/video/cx23885/cx23885-cards.c
index 294a7530caf7..d72b48ef940e 100644
--- a/drivers/media/video/cx23885/cx23885-cards.c
+++ b/drivers/media/video/cx23885/cx23885-cards.c
@@ -1012,7 +1012,6 @@ int cx23885_ir_init(struct cx23885_dev *dev)
1012 dev->sd_ir = cx23885_find_hw(dev, CX23885_HW_888_IR); 1012 dev->sd_ir = cx23885_find_hw(dev, CX23885_HW_888_IR);
1013 v4l2_subdev_call(dev->sd_cx25840, core, s_io_pin_config, 1013 v4l2_subdev_call(dev->sd_cx25840, core, s_io_pin_config,
1014 ir_rxtx_pin_cfg_count, ir_rxtx_pin_cfg); 1014 ir_rxtx_pin_cfg_count, ir_rxtx_pin_cfg);
1015 dev->pci_irqmask |= PCI_MSK_IR;
1016 /* 1015 /*
1017 * For these boards we need to invert the Tx output via the 1016 * For these boards we need to invert the Tx output via the
1018 * IR controller to have the LED off while idle 1017 * IR controller to have the LED off while idle
@@ -1033,7 +1032,6 @@ int cx23885_ir_init(struct cx23885_dev *dev)
1033 } 1032 }
1034 v4l2_subdev_call(dev->sd_cx25840, core, s_io_pin_config, 1033 v4l2_subdev_call(dev->sd_cx25840, core, s_io_pin_config,
1035 ir_rx_pin_cfg_count, ir_rx_pin_cfg); 1034 ir_rx_pin_cfg_count, ir_rx_pin_cfg);
1036 dev->pci_irqmask |= PCI_MSK_AV_CORE;
1037 break; 1035 break;
1038 case CX23885_BOARD_HAUPPAUGE_HVR1250: 1036 case CX23885_BOARD_HAUPPAUGE_HVR1250:
1039 dev->sd_ir = cx23885_find_hw(dev, CX23885_HW_AV_CORE); 1037 dev->sd_ir = cx23885_find_hw(dev, CX23885_HW_AV_CORE);
@@ -1043,7 +1041,6 @@ int cx23885_ir_init(struct cx23885_dev *dev)
1043 } 1041 }
1044 v4l2_subdev_call(dev->sd_cx25840, core, s_io_pin_config, 1042 v4l2_subdev_call(dev->sd_cx25840, core, s_io_pin_config,
1045 ir_rxtx_pin_cfg_count, ir_rxtx_pin_cfg); 1043 ir_rxtx_pin_cfg_count, ir_rxtx_pin_cfg);
1046 dev->pci_irqmask |= PCI_MSK_AV_CORE;
1047 break; 1044 break;
1048 case CX23885_BOARD_DVICO_FUSIONHDTV_DVB_T_DUAL_EXP: 1045 case CX23885_BOARD_DVICO_FUSIONHDTV_DVB_T_DUAL_EXP:
1049 request_module("ir-kbd-i2c"); 1046 request_module("ir-kbd-i2c");
@@ -1058,15 +1055,13 @@ void cx23885_ir_fini(struct cx23885_dev *dev)
1058 switch (dev->board) { 1055 switch (dev->board) {
1059 case CX23885_BOARD_HAUPPAUGE_HVR1850: 1056 case CX23885_BOARD_HAUPPAUGE_HVR1850:
1060 case CX23885_BOARD_HAUPPAUGE_HVR1290: 1057 case CX23885_BOARD_HAUPPAUGE_HVR1290:
1061 dev->pci_irqmask &= ~PCI_MSK_IR; 1058 cx23885_irq_remove(dev, PCI_MSK_IR);
1062 cx_clear(PCI_INT_MSK, PCI_MSK_IR);
1063 cx23888_ir_remove(dev); 1059 cx23888_ir_remove(dev);
1064 dev->sd_ir = NULL; 1060 dev->sd_ir = NULL;
1065 break; 1061 break;
1066 case CX23885_BOARD_TEVII_S470: 1062 case CX23885_BOARD_TEVII_S470:
1067 case CX23885_BOARD_HAUPPAUGE_HVR1250: 1063 case CX23885_BOARD_HAUPPAUGE_HVR1250:
1068 dev->pci_irqmask &= ~PCI_MSK_AV_CORE; 1064 cx23885_irq_remove(dev, PCI_MSK_AV_CORE);
1069 cx_clear(PCI_INT_MSK, PCI_MSK_AV_CORE);
1070 /* sd_ir is a duplicate pointer to the AV Core, just clear it */ 1065 /* sd_ir is a duplicate pointer to the AV Core, just clear it */
1071 dev->sd_ir = NULL; 1066 dev->sd_ir = NULL;
1072 break; 1067 break;
@@ -1078,13 +1073,13 @@ void cx23885_ir_pci_int_enable(struct cx23885_dev *dev)
1078 switch (dev->board) { 1073 switch (dev->board) {
1079 case CX23885_BOARD_HAUPPAUGE_HVR1850: 1074 case CX23885_BOARD_HAUPPAUGE_HVR1850:
1080 case CX23885_BOARD_HAUPPAUGE_HVR1290: 1075 case CX23885_BOARD_HAUPPAUGE_HVR1290:
1081 if (dev->sd_ir && (dev->pci_irqmask & PCI_MSK_IR)) 1076 if (dev->sd_ir)
1082 cx_set(PCI_INT_MSK, PCI_MSK_IR); 1077 cx23885_irq_add_enable(dev, PCI_MSK_IR);
1083 break; 1078 break;
1084 case CX23885_BOARD_TEVII_S470: 1079 case CX23885_BOARD_TEVII_S470:
1085 case CX23885_BOARD_HAUPPAUGE_HVR1250: 1080 case CX23885_BOARD_HAUPPAUGE_HVR1250:
1086 if (dev->sd_ir && (dev->pci_irqmask & PCI_MSK_AV_CORE)) 1081 if (dev->sd_ir)
1087 cx_set(PCI_INT_MSK, PCI_MSK_AV_CORE); 1082 cx23885_irq_add_enable(dev, PCI_MSK_AV_CORE);
1088 break; 1083 break;
1089 } 1084 }
1090} 1085}