7 files changed, 69 insertions, 44 deletions

diff --git a/drivers/isdn/gigaset/capi.c b/drivers/isdn/gigaset/capi.c
index 6643d6533ccb..0220c19351d9 100644
--- a/drivers/isdn/gigaset/capi.c
+++ b/drivers/isdn/gigaset/capi.c
@@ -1301,7 +1301,7 @@ static void do_connect_req(struct gigaset_capi_ctr *iif,
         }
 
         /* check parameter: CIP Value */
-        if (cmsg->CIPValue > ARRAY_SIZE(cip2bchlc) ||
+        if (cmsg->CIPValue >= ARRAY_SIZE(cip2bchlc) ||
             (cmsg->CIPValue > 0 && cip2bchlc[cmsg->CIPValue].bc == NULL)) {
                 dev_notice(cs->dev, "%s: unknown CIP value %d\n",
                            "CONNECT_REQ", cmsg->CIPValue);
@@ -2191,36 +2191,24 @@ static const struct file_operations gigaset_proc_fops = {
         .release        = single_release,
 };
 
-static struct capi_driver capi_driver_gigaset = {
-        .name           = "gigaset",
-        .revision       = "1.0",
-};
-
 /**
- * gigaset_isdn_register() - register to LL
+ * gigaset_isdn_regdev() - register device to LL
  * @cs:         device descriptor structure.
  * @isdnid:     device name.
  *
- * Called by main module to register the device with the LL.
- *
  * Return value: 1 for success, 0 for failure
  */
-int gigaset_isdn_register(struct cardstate *cs, const char *isdnid)
+int gigaset_isdn_regdev(struct cardstate *cs, const char *isdnid)
 {
         struct gigaset_capi_ctr *iif;
         int rc;
 
-        pr_info("Kernel CAPI interface\n");
-
         iif = kmalloc(sizeof(*iif), GFP_KERNEL);
         if (!iif) {
                 pr_err("%s: out of memory\n", __func__);
                 return 0;
         }
 
-        /* register driver with CAPI (ToDo: what for?) */
-        register_capi_driver(&capi_driver_gigaset);
-
         /* prepare controller structure */
         iif->ctr.owner         = THIS_MODULE;
         iif->ctr.driverdata    = cs;
@@ -2241,7 +2229,6 @@ int gigaset_isdn_register(struct cardstate *cs, const char *isdnid)
         rc = attach_capi_ctr(&iif->ctr);
         if (rc) {
                 pr_err("attach_capi_ctr failed (%d)\n", rc);
-                unregister_capi_driver(&capi_driver_gigaset);
                 kfree(iif);
                 return 0;
         }
@@ -2252,17 +2239,36 @@ int gigaset_isdn_register(struct cardstate *cs, const char *isdnid)
 }
 
 /**
- * gigaset_isdn_unregister() - unregister from LL
+ * gigaset_isdn_unregdev() - unregister device from LL
  * @cs:         device descriptor structure.
- *
- * Called by main module to unregister the device from the LL.
  */
-void gigaset_isdn_unregister(struct cardstate *cs)
+void gigaset_isdn_unregdev(struct cardstate *cs)
 {
         struct gigaset_capi_ctr *iif = cs->iif;
 
         detach_capi_ctr(&iif->ctr);
         kfree(iif);
         cs->iif = NULL;
+}
+
+static struct capi_driver capi_driver_gigaset = {
+        .name           = "gigaset",
+        .revision       = "1.0",
+};
+
+/**
+ * gigaset_isdn_regdrv() - register driver to LL
+ */
+void gigaset_isdn_regdrv(void)
+{
+        pr_info("Kernel CAPI interface\n");
+        register_capi_driver(&capi_driver_gigaset);
+}
+
+/**
+ * gigaset_isdn_unregdrv() - unregister driver from LL
+ */
+void gigaset_isdn_unregdrv(void)
+{
         unregister_capi_driver(&capi_driver_gigaset);
 }
diff --git a/drivers/isdn/gigaset/common.c b/drivers/isdn/gigaset/common.c
index 85de3399a2f2..bdc01cb9f0ab 100644
--- a/drivers/isdn/gigaset/common.c
+++ b/drivers/isdn/gigaset/common.c
@@ -507,7 +507,7 @@ void gigaset_freecs(struct cardstate *cs)
         case 2: /* error in initcshw */
                 /* Deregister from LL */
                 make_invalid(cs, VALID_ID);
-                gigaset_isdn_unregister(cs);
+                gigaset_isdn_unregdev(cs);
 
                 /* fall through */
         case 1: /* error when registering to LL */
@@ -769,7 +769,7 @@ struct cardstate *gigaset_initcs(struct gigaset_driver *drv, int channels,
         cs->cmdbytes = 0;
 
         gig_dbg(DEBUG_INIT, "setting up iif");
-        if (!gigaset_isdn_register(cs, modulename)) {
+        if (!gigaset_isdn_regdev(cs, modulename)) {
                 pr_err("error registering ISDN device\n");
                 goto error;
         }
@@ -1205,11 +1205,13 @@ static int __init gigaset_init_module(void)
                 gigaset_debuglevel = DEBUG_DEFAULT;
 
         pr_info(DRIVER_DESC DRIVER_DESC_DEBUG "\n");
+        gigaset_isdn_regdrv();
         return 0;
 }
 
 static void __exit gigaset_exit_module(void)
 {
+        gigaset_isdn_unregdrv();
 }
 
 module_init(gigaset_init_module);
diff --git a/drivers/isdn/gigaset/dummyll.c b/drivers/isdn/gigaset/dummyll.c
index 5b27c996af6d..bd0b1eaa7572 100644
--- a/drivers/isdn/gigaset/dummyll.c
+++ b/drivers/isdn/gigaset/dummyll.c
@@ -57,12 +57,20 @@ void gigaset_isdn_stop(struct cardstate *cs)
 {
 }
 
-int gigaset_isdn_register(struct cardstate *cs, const char *isdnid)
+int gigaset_isdn_regdev(struct cardstate *cs, const char *isdnid)
 {
-        pr_info("no ISDN subsystem interface\n");
         return 1;
 }
 
-void gigaset_isdn_unregister(struct cardstate *cs)
+void gigaset_isdn_unregdev(struct cardstate *cs)
+{
+}
+
+void gigaset_isdn_regdrv(void)
+{
+        pr_info("no ISDN subsystem interface\n");
+}
+
+void gigaset_isdn_unregdrv(void)
 {
 }
diff --git a/drivers/isdn/gigaset/ev-layer.c b/drivers/isdn/gigaset/ev-layer.c
index c8f89b78b233..206c380c5235 100644
--- a/drivers/isdn/gigaset/ev-layer.c
+++ b/drivers/isdn/gigaset/ev-layer.c
@@ -1258,14 +1258,10 @@ static void do_action(int action, struct cardstate *cs,
                  * note that bcs may be NULL if no B channel is free
                  */
                 at_state2->ConState = 700;
-                kfree(at_state2->str_var[STR_NMBR]);
-                at_state2->str_var[STR_NMBR] = NULL;
-                kfree(at_state2->str_var[STR_ZCPN]);
-                at_state2->str_var[STR_ZCPN] = NULL;
-                kfree(at_state2->str_var[STR_ZBC]);
-                at_state2->str_var[STR_ZBC] = NULL;
-                kfree(at_state2->str_var[STR_ZHLC]);
-                at_state2->str_var[STR_ZHLC] = NULL;
+                for (i = 0; i < STR_NUM; ++i) {
+                        kfree(at_state2->str_var[i]);
+                        at_state2->str_var[i] = NULL;
+                }
                 at_state2->int_var[VAR_ZCTP] = -1;
 
                 spin_lock_irqsave(&cs->lock, flags);
diff --git a/drivers/isdn/gigaset/gigaset.h b/drivers/isdn/gigaset/gigaset.h
index 1875ab80b335..cdd144ecdc5f 100644
--- a/drivers/isdn/gigaset/gigaset.h
+++ b/drivers/isdn/gigaset/gigaset.h
@@ -675,8 +675,10 @@ int gigaset_isowbuf_getbytes(struct isowbuf_t *iwb, int size);
  */
 
 /* Called from common.c for setting up/shutting down with the ISDN subsystem */
-int gigaset_isdn_register(struct cardstate *cs, const char *isdnid);
-void gigaset_isdn_unregister(struct cardstate *cs);
+void gigaset_isdn_regdrv(void);
+void gigaset_isdn_unregdrv(void);
+int gigaset_isdn_regdev(struct cardstate *cs, const char *isdnid);
+void gigaset_isdn_unregdev(struct cardstate *cs);
 
 /* Called from hardware module to indicate completion of an skb */
 void gigaset_skb_sent(struct bc_state *bcs, struct sk_buff *skb);
diff --git a/drivers/isdn/gigaset/i4l.c b/drivers/isdn/gigaset/i4l.c
index f0acb9dc9e33..c22e5ace8276 100644
--- a/drivers/isdn/gigaset/i4l.c
+++ b/drivers/isdn/gigaset/i4l.c
@@ -592,15 +592,13 @@ void gigaset_isdn_stop(struct cardstate *cs)
 }
 
 /**
- * gigaset_isdn_register() - register to LL
+ * gigaset_isdn_regdev() - register to LL
  * @cs:         device descriptor structure.
  * @isdnid:     device name.
  *
- * Called by main module to register the device with the LL.
- *
  * Return value: 1 for success, 0 for failure
  */
-int gigaset_isdn_register(struct cardstate *cs, const char *isdnid)
+int gigaset_isdn_regdev(struct cardstate *cs, const char *isdnid)
 {
         isdn_if *iif;
 
@@ -650,15 +648,29 @@ int gigaset_isdn_register(struct cardstate *cs, const char *isdnid)
 }
 
 /**
- * gigaset_isdn_unregister() - unregister from LL
+ * gigaset_isdn_unregdev() - unregister device from LL
  * @cs:         device descriptor structure.
- *
- * Called by main module to unregister the device from the LL.
  */
-void gigaset_isdn_unregister(struct cardstate *cs)
+void gigaset_isdn_unregdev(struct cardstate *cs)
 {
         gig_dbg(DEBUG_CMD, "sending UNLOAD");
         gigaset_i4l_cmd(cs, ISDN_STAT_UNLOAD);
         kfree(cs->iif);
         cs->iif = NULL;
 }
+
+/**
+ * gigaset_isdn_regdrv() - register driver to LL
+ */
+void gigaset_isdn_regdrv(void)
+{
+        /* nothing to do */
+}
+
+/**
+ * gigaset_isdn_unregdrv() - unregister driver from LL
+ */
+void gigaset_isdn_unregdrv(void)
+{
+        /* nothing to do */
+}
diff --git a/drivers/isdn/gigaset/interface.c b/drivers/isdn/gigaset/interface.c
index a1bcbc21ff71..f0dc6c9cc283 100644
--- a/drivers/isdn/gigaset/interface.c
+++ b/drivers/isdn/gigaset/interface.c
@@ -628,7 +628,6 @@ void gigaset_if_receive(struct cardstate *cs,
         if (tty == NULL)
                 gig_dbg(DEBUG_IF, "receive on closed device");
         else {
-                tty_buffer_request_room(tty, len);
                 tty_insert_flip_string(tty, buffer, len);
                 tty_flip_buffer_push(tty);
         }