8 files changed, 456 insertions, 68 deletions

diff --git a/drivers/input/joystick/Kconfig b/drivers/input/joystick/Kconfig
index 5b596165b571..56eb471b5576 100644
--- a/drivers/input/joystick/Kconfig
+++ b/drivers/input/joystick/Kconfig
@@ -255,6 +255,16 @@ config JOYSTICK_AMIGA
           To compile this driver as a module, choose M here: the
           module will be called amijoy.
 
+config JOYSTICK_AS5011
+        tristate "Austria Microsystem AS5011 joystick"
+        depends on I2C
+        help
+          Say Y here if you have an AS5011 digital joystick connected to your
+          system.
+
+          To compile this driver as a module, choose M here: the
+          module will be called as5011.
+
 config JOYSTICK_JOYDUMP
         tristate "Gameport data dumper"
         select GAMEPORT
diff --git a/drivers/input/joystick/Makefile b/drivers/input/joystick/Makefile
index f3a8cbe2abb6..92dc0de9dfed 100644
--- a/drivers/input/joystick/Makefile
+++ b/drivers/input/joystick/Makefile
@@ -7,6 +7,7 @@
 obj-$(CONFIG_JOYSTICK_A3D)              += a3d.o
 obj-$(CONFIG_JOYSTICK_ADI)              += adi.o
 obj-$(CONFIG_JOYSTICK_AMIGA)            += amijoy.o
+obj-$(CONFIG_JOYSTICK_AS5011)           += as5011.o
 obj-$(CONFIG_JOYSTICK_ANALOG)           += analog.o
 obj-$(CONFIG_JOYSTICK_COBRA)            += cobra.o
 obj-$(CONFIG_JOYSTICK_DB9)              += db9.o
diff --git a/drivers/input/joystick/a3d.c b/drivers/input/joystick/a3d.c
index d259b41354b8..1639ab2b94b7 100644
--- a/drivers/input/joystick/a3d.c
+++ b/drivers/input/joystick/a3d.c
@@ -3,7 +3,7 @@
  */
 
 /*
- * FP-Gaming Assasin 3D joystick driver for Linux
+ * FP-Gaming Assassin 3D joystick driver for Linux
  */
 
 /*
@@ -34,7 +34,7 @@
 #include <linux/input.h>
 #include <linux/jiffies.h>
 
-#define DRIVER_DESC     "FP-Gaming Assasin 3D joystick driver"
+#define DRIVER_DESC     "FP-Gaming Assassin 3D joystick driver"
 
 MODULE_AUTHOR("Vojtech Pavlik <vojtech@ucw.cz>");
 MODULE_DESCRIPTION(DRIVER_DESC);
diff --git a/drivers/input/joystick/as5011.c b/drivers/input/joystick/as5011.c
new file mode 100644
index 000000000000..f6732b57ca07
--- /dev/null
+++ b/drivers/input/joystick/as5011.c
@@ -0,0 +1,367 @@
+/*
+ * Copyright (c) 2010, 2011 Fabien Marteau <fabien.marteau@armadeus.com>
+ * Sponsored by ARMadeus Systems
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+ *
+ * Driver for Austria Microsystems joysticks AS5011
+ *
+ * TODO:
+ *      - Power on the chip when open() and power down when close()
+ *      - Manage power mode
+ */
+
+#include <linux/i2c.h>
+#include <linux/interrupt.h>
+#include <linux/input.h>
+#include <linux/gpio.h>
+#include <linux/delay.h>
+#include <linux/input/as5011.h>
+#include <linux/slab.h>
+
+#define DRIVER_DESC "Driver for Austria Microsystems AS5011 joystick"
+#define MODULE_DEVICE_ALIAS "as5011"
+
+MODULE_AUTHOR("Fabien Marteau <fabien.marteau@armadeus.com>");
+MODULE_DESCRIPTION(DRIVER_DESC);
+MODULE_LICENSE("GPL");
+
+/* registers */
+#define AS5011_CTRL1            0x76
+#define AS5011_CTRL2            0x75
+#define AS5011_XP               0x43
+#define AS5011_XN               0x44
+#define AS5011_YP               0x53
+#define AS5011_YN               0x54
+#define AS5011_X_REG            0x41
+#define AS5011_Y_REG            0x42
+#define AS5011_X_RES_INT        0x51
+#define AS5011_Y_RES_INT        0x52
+
+/* CTRL1 bits */
+#define AS5011_CTRL1_LP_PULSED          0x80
+#define AS5011_CTRL1_LP_ACTIVE          0x40
+#define AS5011_CTRL1_LP_CONTINUE        0x20
+#define AS5011_CTRL1_INT_WUP_EN         0x10
+#define AS5011_CTRL1_INT_ACT_EN         0x08
+#define AS5011_CTRL1_EXT_CLK_EN         0x04
+#define AS5011_CTRL1_SOFT_RST           0x02
+#define AS5011_CTRL1_DATA_VALID         0x01
+
+/* CTRL2 bits */
+#define AS5011_CTRL2_EXT_SAMPLE_EN      0x08
+#define AS5011_CTRL2_RC_BIAS_ON         0x04
+#define AS5011_CTRL2_INV_SPINNING       0x02
+
+#define AS5011_MAX_AXIS 80
+#define AS5011_MIN_AXIS (-80)
+#define AS5011_FUZZ     8
+#define AS5011_FLAT     40
+
+struct as5011_device {
+        struct input_dev *input_dev;
+        struct i2c_client *i2c_client;
+        unsigned int button_gpio;
+        unsigned int button_irq;
+        unsigned int axis_irq;
+};
+
+static int as5011_i2c_write(struct i2c_client *client,
+                            uint8_t aregaddr,
+                            uint8_t avalue)
+{
+        uint8_t data[2] = { aregaddr, avalue };
+        struct i2c_msg msg = {
+                client->addr, I2C_M_IGNORE_NAK, 2, (uint8_t *)data
+        };
+        int error;
+
+        error = i2c_transfer(client->adapter, &msg, 1);
+        return error < 0 ? error : 0;
+}
+
+static int as5011_i2c_read(struct i2c_client *client,
+                           uint8_t aregaddr, signed char *value)
+{
+        uint8_t data[2] = { aregaddr };
+        struct i2c_msg msg_set[2] = {
+                { client->addr, I2C_M_REV_DIR_ADDR, 1, (uint8_t *)data },
+                { client->addr, I2C_M_RD | I2C_M_NOSTART, 1, (uint8_t *)data }
+        };
+        int error;
+
+        error = i2c_transfer(client->adapter, msg_set, 2);
+        if (error < 0)
+                return error;
+
+        *value = data[0] & 0x80 ? -1 * (1 + ~data[0]) : data[0];
+        return 0;
+}
+
+static irqreturn_t as5011_button_interrupt(int irq, void *dev_id)
+{
+        struct as5011_device *as5011 = dev_id;
+        int val = gpio_get_value_cansleep(as5011->button_gpio);
+
+        input_report_key(as5011->input_dev, BTN_JOYSTICK, !val);
+        input_sync(as5011->input_dev);
+
+        return IRQ_HANDLED;
+}
+
+static irqreturn_t as5011_axis_interrupt(int irq, void *dev_id)
+{
+        struct as5011_device *as5011 = dev_id;
+        int error;
+        signed char x, y;
+
+        error = as5011_i2c_read(as5011->i2c_client, AS5011_X_RES_INT, &x);
+        if (error < 0)
+                goto out;
+
+        error = as5011_i2c_read(as5011->i2c_client, AS5011_Y_RES_INT, &y);
+        if (error < 0)
+                goto out;
+
+        input_report_abs(as5011->input_dev, ABS_X, x);
+        input_report_abs(as5011->input_dev, ABS_Y, y);
+        input_sync(as5011->input_dev);
+
+out:
+        return IRQ_HANDLED;
+}
+
+static int __devinit as5011_configure_chip(struct as5011_device *as5011,
+                                const struct as5011_platform_data *plat_dat)
+{
+        struct i2c_client *client = as5011->i2c_client;
+        int error;
+        signed char value;
+
+        /* chip soft reset */
+        error = as5011_i2c_write(client, AS5011_CTRL1,
+                                 AS5011_CTRL1_SOFT_RST);
+        if (error < 0) {
+                dev_err(&client->dev, "Soft reset failed\n");
+                return error;
+        }
+
+        mdelay(10);
+
+        error = as5011_i2c_write(client, AS5011_CTRL1,
+                                 AS5011_CTRL1_LP_PULSED |
+                                 AS5011_CTRL1_LP_ACTIVE |
+                                 AS5011_CTRL1_INT_ACT_EN);
+        if (error < 0) {
+                dev_err(&client->dev, "Power config failed\n");
+                return error;
+        }
+
+        error = as5011_i2c_write(client, AS5011_CTRL2,
+                                 AS5011_CTRL2_INV_SPINNING);
+        if (error < 0) {
+                dev_err(&client->dev, "Can't invert spinning\n");
+                return error;
+        }
+
+        /* write threshold */
+        error = as5011_i2c_write(client, AS5011_XP, plat_dat->xp);
+        if (error < 0) {
+                dev_err(&client->dev, "Can't write threshold\n");
+                return error;
+        }
+
+        error = as5011_i2c_write(client, AS5011_XN, plat_dat->xn);
+        if (error < 0) {
+                dev_err(&client->dev, "Can't write threshold\n");
+                return error;
+        }
+
+        error = as5011_i2c_write(client, AS5011_YP, plat_dat->yp);
+        if (error < 0) {
+                dev_err(&client->dev, "Can't write threshold\n");
+                return error;
+        }
+
+        error = as5011_i2c_write(client, AS5011_YN, plat_dat->yn);
+        if (error < 0) {
+                dev_err(&client->dev, "Can't write threshold\n");
+                return error;
+        }
+
+        /* to free irq gpio in chip */
+        error = as5011_i2c_read(client, AS5011_X_RES_INT, &value);
+        if (error < 0) {
+                dev_err(&client->dev, "Can't read i2c X resolution value\n");
+                return error;
+        }
+
+        return 0;
+}
+
+static int __devinit as5011_probe(struct i2c_client *client,
+                                const struct i2c_device_id *id)
+{
+        const struct as5011_platform_data *plat_data;
+        struct as5011_device *as5011;
+        struct input_dev *input_dev;
+        int irq;
+        int error;
+
+        plat_data = client->dev.platform_data;
+        if (!plat_data)
+                return -EINVAL;
+
+        if (!plat_data->axis_irq) {
+                dev_err(&client->dev, "No axis IRQ?\n");
+                return -EINVAL;
+        }
+
+        if (!i2c_check_functionality(client->adapter,
+                                     I2C_FUNC_PROTOCOL_MANGLING)) {
+                dev_err(&client->dev,
+                        "need i2c bus that supports protocol mangling\n");
+                return -ENODEV;
+        }
+
+        as5011 = kmalloc(sizeof(struct as5011_device), GFP_KERNEL);
+        input_dev = input_allocate_device();
+        if (!as5011 || !input_dev) {
+                dev_err(&client->dev,
+                        "Can't allocate memory for device structure\n");
+                error = -ENOMEM;
+                goto err_free_mem;
+        }
+
+        as5011->i2c_client = client;
+        as5011->input_dev = input_dev;
+        as5011->button_gpio = plat_data->button_gpio;
+        as5011->axis_irq = plat_data->axis_irq;
+
+        input_dev->name = "Austria Microsystem as5011 joystick";
+        input_dev->id.bustype = BUS_I2C;
+        input_dev->dev.parent = &client->dev;
+
+        __set_bit(EV_KEY, input_dev->evbit);
+        __set_bit(EV_ABS, input_dev->evbit);
+        __set_bit(BTN_JOYSTICK, input_dev->keybit);
+
+        input_set_abs_params(input_dev, ABS_X,
+                AS5011_MIN_AXIS, AS5011_MAX_AXIS, AS5011_FUZZ, AS5011_FLAT);
+        input_set_abs_params(as5011->input_dev, ABS_Y,
+                AS5011_MIN_AXIS, AS5011_MAX_AXIS, AS5011_FUZZ, AS5011_FLAT);
+
+        error = gpio_request(as5011->button_gpio, "AS5011 button");
+        if (error < 0) {
+                dev_err(&client->dev, "Failed to request button gpio\n");
+                goto err_free_mem;
+        }
+
+        irq = gpio_to_irq(as5011->button_gpio);
+        if (irq < 0) {
+                dev_err(&client->dev,
+                        "Failed to get irq number for button gpio\n");
+                goto err_free_button_gpio;
+        }
+
+        as5011->button_irq = irq;
+
+        error = request_threaded_irq(as5011->button_irq,
+                                     NULL, as5011_button_interrupt,
+                                     IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
+                                     "as5011_button", as5011);
+        if (error < 0) {
+                dev_err(&client->dev,
+                        "Can't allocate button irq %d\n", as5011->button_irq);
+                goto err_free_button_gpio;
+        }
+
+        error = as5011_configure_chip(as5011, plat_data);
+        if (error)
+                goto err_free_button_irq;
+
+        error = request_threaded_irq(as5011->axis_irq, NULL,
+                                     as5011_axis_interrupt,
+                                     plat_data->axis_irqflags,
+                                     "as5011_joystick", as5011);
+        if (error) {
+                dev_err(&client->dev,
+                        "Can't allocate axis irq %d\n", plat_data->axis_irq);
+                goto err_free_button_irq;
+        }
+
+        error = input_register_device(as5011->input_dev);
+        if (error) {
+                dev_err(&client->dev, "Failed to register input device\n");
+                goto err_free_axis_irq;
+        }
+
+        i2c_set_clientdata(client, as5011);
+
+        return 0;
+
+err_free_axis_irq:
+        free_irq(as5011->axis_irq, as5011);
+err_free_button_irq:
+        free_irq(as5011->button_irq, as5011);
+err_free_button_gpio:
+        gpio_free(as5011->button_gpio);
+err_free_mem:
+        input_free_device(input_dev);
+        kfree(as5011);
+
+        return error;
+}
+
+static int __devexit as5011_remove(struct i2c_client *client)
+{
+        struct as5011_device *as5011 = i2c_get_clientdata(client);
+
+        free_irq(as5011->axis_irq, as5011);
+        free_irq(as5011->button_irq, as5011);
+        gpio_free(as5011->button_gpio);
+
+        input_unregister_device(as5011->input_dev);
+        kfree(as5011);
+
+        return 0;
+}
+
+static const struct i2c_device_id as5011_id[] = {
+        { MODULE_DEVICE_ALIAS, 0 },
+        { }
+};
+MODULE_DEVICE_TABLE(i2c, as5011_id);
+
+static struct i2c_driver as5011_driver = {
+        .driver = {
+                .name = "as5011",
+        },
+        .probe          = as5011_probe,
+        .remove         = __devexit_p(as5011_remove),
+        .id_table       = as5011_id,
+};
+
+static int __init as5011_init(void)
+{
+        return i2c_add_driver(&as5011_driver);
+}
+module_init(as5011_init);
+
+static void __exit as5011_exit(void)
+{
+        i2c_del_driver(&as5011_driver);
+}
+module_exit(as5011_exit);
diff --git a/drivers/input/joystick/gamecon.c b/drivers/input/joystick/gamecon.c
index 0ffaf2c77a19..e68e49786483 100644
--- a/drivers/input/joystick/gamecon.c
+++ b/drivers/input/joystick/gamecon.c
@@ -521,9 +521,8 @@ static void gc_multi_process_packet(struct gc *gc)
  * PSX support
  *
  * See documentation at:
- *      http://www.dim.com/~mackys/psxmemcard/ps-eng2.txt
+ *      http://www.geocities.co.jp/Playtown/2004/psx/ps_eng.txt 
  *      http://www.gamesx.com/controldata/psxcont/psxcont.htm
- *      ftp://milano.usal.es/pablo/
  *
  */
 
diff --git a/drivers/input/joystick/iforce/Makefile b/drivers/input/joystick/iforce/Makefile
index 74daff49ab6e..bc5bda22f15e 100644
--- a/drivers/input/joystick/iforce/Makefile
+++ b/drivers/input/joystick/iforce/Makefile
@@ -4,17 +4,8 @@
 # By Johann Deneux <johann.deneux@gmail.com>
 #
 
-# Goal definition
-iforce-objs     := iforce-ff.o iforce-main.o iforce-packets.o
-
 obj-$(CONFIG_JOYSTICK_IFORCE)   += iforce.o
 
-ifeq ($(CONFIG_JOYSTICK_IFORCE_232),y)
-        iforce-objs += iforce-serio.o
-endif
-
-ifeq ($(CONFIG_JOYSTICK_IFORCE_USB),y)
-        iforce-objs += iforce-usb.o
-endif
-
-EXTRA_CFLAGS = -Werror-implicit-function-declaration
+iforce-y := iforce-ff.o iforce-main.o iforce-packets.o
+iforce-$(CONFIG_JOYSTICK_IFORCE_232)    += iforce-serio.o
+iforce-$(CONFIG_JOYSTICK_IFORCE_USB)    += iforce-usb.o
diff --git a/drivers/input/joystick/turbografx.c b/drivers/input/joystick/turbografx.c
index d53b9e900234..27b6a3ce18ca 100644
--- a/drivers/input/joystick/turbografx.c
+++ b/drivers/input/joystick/turbografx.c
@@ -245,6 +245,7 @@ static struct tgfx __init *tgfx_probe(int parport, int *n_buttons, int n_devs)
                 goto err_free_tgfx;
         }
 
+        parport_put_port(pp);
         return tgfx;
 
  err_free_dev:
diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
index f9fb7fa10af3..56abf3d0e911 100644
--- a/drivers/input/joystick/xpad.c
+++ b/drivers/input/joystick/xpad.c
@@ -543,21 +543,25 @@ exit:
 static int xpad_init_output(struct usb_interface *intf, struct usb_xpad *xpad)
 {
         struct usb_endpoint_descriptor *ep_irq_out;
-        int error = -ENOMEM;
+        int error;
 
         if (xpad->xtype != XTYPE_XBOX360 && xpad->xtype != XTYPE_XBOX)
                 return 0;
 
         xpad->odata = usb_alloc_coherent(xpad->udev, XPAD_PKT_LEN,
                                          GFP_KERNEL, &xpad->odata_dma);
-        if (!xpad->odata)
+        if (!xpad->odata) {
+                error = -ENOMEM;
                 goto fail1;
+        }
 
         mutex_init(&xpad->odata_mutex);
 
         xpad->irq_out = usb_alloc_urb(0, GFP_KERNEL);
-        if (!xpad->irq_out)
+        if (!xpad->irq_out) {
+                error = -ENOMEM;
                 goto fail2;
+        }
 
         ep_irq_out = &intf->cur_altsetting->endpoint[1].desc;
         usb_fill_int_urb(xpad->irq_out, xpad->udev,
@@ -728,7 +732,7 @@ static void xpad_led_disconnect(struct usb_xpad *xpad)
 
         if (xpad_led) {
                 led_classdev_unregister(&xpad_led->led_cdev);
-                kfree(xpad_led->name);
+                kfree(xpad_led);
         }
 }
 #else
@@ -756,8 +760,9 @@ static void xpad_close(struct input_dev *dev)
 {
         struct usb_xpad *xpad = input_get_drvdata(dev);
 
-        if(xpad->xtype != XTYPE_XBOX360W)
+        if (xpad->xtype != XTYPE_XBOX360W)
                 usb_kill_urb(xpad->irq_in);
+
         xpad_stop_output(xpad);
 }
 
@@ -789,8 +794,7 @@ static int xpad_probe(struct usb_interface *intf, const struct usb_device_id *id
         struct usb_xpad *xpad;
         struct input_dev *input_dev;
         struct usb_endpoint_descriptor *ep_irq_in;
-        int i;
-        int error = -ENOMEM;
+        int i, error;
 
         for (i = 0; xpad_device[i].idVendor; i++) {
                 if ((le16_to_cpu(udev->descriptor.idVendor) == xpad_device[i].idVendor) &&
@@ -800,17 +804,23 @@ static int xpad_probe(struct usb_interface *intf, const struct usb_device_id *id
 
         xpad = kzalloc(sizeof(struct usb_xpad), GFP_KERNEL);
         input_dev = input_allocate_device();
-        if (!xpad || !input_dev)
+        if (!xpad || !input_dev) {
+                error = -ENOMEM;
                 goto fail1;
+        }
 
         xpad->idata = usb_alloc_coherent(udev, XPAD_PKT_LEN,
                                          GFP_KERNEL, &xpad->idata_dma);
-        if (!xpad->idata)
+        if (!xpad->idata) {
+                error = -ENOMEM;
                 goto fail1;
+        }
 
         xpad->irq_in = usb_alloc_urb(0, GFP_KERNEL);
-        if (!xpad->irq_in)
+        if (!xpad->irq_in) {
+                error = -ENOMEM;
                 goto fail2;
+        }
 
         xpad->udev = udev;
         xpad->mapping = xpad_device[i].mapping;
@@ -887,15 +897,15 @@ static int xpad_probe(struct usb_interface *intf, const struct usb_device_id *id
 
         error = xpad_init_output(intf, xpad);
         if (error)
-                goto fail2;
+                goto fail3;
 
         error = xpad_init_ff(xpad);
         if (error)
-                goto fail3;
+                goto fail4;
 
         error = xpad_led_probe(xpad);
         if (error)
-                goto fail3;
+                goto fail5;
 
         ep_irq_in = &intf->cur_altsetting->endpoint[0].desc;
         usb_fill_int_urb(xpad->irq_in, udev,
@@ -907,34 +917,26 @@ static int xpad_probe(struct usb_interface *intf, const struct usb_device_id *id
 
         error = input_register_device(xpad->dev);
         if (error)
-                goto fail4;
+                goto fail6;
 
         usb_set_intfdata(intf, xpad);
 
-        /*
-         * Submit the int URB immediatly rather than waiting for open
-         * because we get status messages from the device whether
-         * or not any controllers are attached.  In fact, it's
-         * exactly the message that a controller has arrived that
-         * we're waiting for.
-         */
         if (xpad->xtype == XTYPE_XBOX360W) {
-                xpad->irq_in->dev = xpad->udev;
-                error = usb_submit_urb(xpad->irq_in, GFP_KERNEL);
-                if (error)
-                        goto fail4;
-
                 /*
                  * Setup the message to set the LEDs on the
                  * controller when it shows up
                  */
                 xpad->bulk_out = usb_alloc_urb(0, GFP_KERNEL);
-                if(!xpad->bulk_out)
-                        goto fail5;
+                if (!xpad->bulk_out) {
+                        error = -ENOMEM;
+                        goto fail7;
+                }
 
                 xpad->bdata = kzalloc(XPAD_PKT_LEN, GFP_KERNEL);
-                if(!xpad->bdata)
-                        goto fail6;
+                if (!xpad->bdata) {
+                        error = -ENOMEM;
+                        goto fail8;
+                }
 
                 xpad->bdata[2] = 0x08;
                 switch (intf->cur_altsetting->desc.bInterfaceNumber) {
@@ -955,14 +957,31 @@ static int xpad_probe(struct usb_interface *intf, const struct usb_device_id *id
                 usb_fill_bulk_urb(xpad->bulk_out, udev,
                                 usb_sndbulkpipe(udev, ep_irq_in->bEndpointAddress),
                                 xpad->bdata, XPAD_PKT_LEN, xpad_bulk_out, xpad);
+
+                /*
+                 * Submit the int URB immediately rather than waiting for open
+                 * because we get status messages from the device whether
+                 * or not any controllers are attached.  In fact, it's
+                 * exactly the message that a controller has arrived that
+                 * we're waiting for.
+                 */
+                xpad->irq_in->dev = xpad->udev;
+                error = usb_submit_urb(xpad->irq_in, GFP_KERNEL);
+                if (error)
+                        goto fail9;
         }
 
         return 0;
 
- fail6: usb_free_urb(xpad->bulk_out);
- fail5: usb_kill_urb(xpad->irq_in);
- fail4: usb_free_urb(xpad->irq_in);
- fail3: xpad_deinit_output(xpad);
+ fail9: kfree(xpad->bdata);
+ fail8: usb_free_urb(xpad->bulk_out);
+ fail7: input_unregister_device(input_dev);
+        input_dev = NULL;
+ fail6: xpad_led_disconnect(xpad);
+ fail5: if (input_dev)
+                input_ff_destroy(input_dev);
+ fail4: xpad_deinit_output(xpad);
+ fail3: usb_free_urb(xpad->irq_in);
  fail2: usb_free_coherent(udev, XPAD_PKT_LEN, xpad->idata, xpad->idata_dma);
  fail1: input_free_device(input_dev);
         kfree(xpad);
@@ -974,21 +993,24 @@ static void xpad_disconnect(struct usb_interface *intf)
 {
         struct usb_xpad *xpad = usb_get_intfdata (intf);
 
-        usb_set_intfdata(intf, NULL);
-        if (xpad) {
-                xpad_led_disconnect(xpad);
-                input_unregister_device(xpad->dev);
-                xpad_deinit_output(xpad);
-                if (xpad->xtype == XTYPE_XBOX360W) {
-                        usb_kill_urb(xpad->bulk_out);
-                        usb_free_urb(xpad->bulk_out);
-                        usb_kill_urb(xpad->irq_in);
-                }
-                usb_free_urb(xpad->irq_in);
-                usb_free_coherent(xpad->udev, XPAD_PKT_LEN,
-                                xpad->idata, xpad->idata_dma);
-                kfree(xpad);
+        xpad_led_disconnect(xpad);
+        input_unregister_device(xpad->dev);
+        xpad_deinit_output(xpad);
+
+        if (xpad->xtype == XTYPE_XBOX360W) {
+                usb_kill_urb(xpad->bulk_out);
+                usb_free_urb(xpad->bulk_out);
+                usb_kill_urb(xpad->irq_in);
         }
+
+        usb_free_urb(xpad->irq_in);
+        usb_free_coherent(xpad->udev, XPAD_PKT_LEN,
+                        xpad->idata, xpad->idata_dma);
+
+        kfree(xpad->bdata);
+        kfree(xpad);
+
+        usb_set_intfdata(intf, NULL);
 }
 
 static struct usb_driver xpad_driver = {
@@ -1000,10 +1022,7 @@ static struct usb_driver xpad_driver = {
 
 static int __init usb_xpad_init(void)
 {
-        int result = usb_register(&xpad_driver);
-        if (result == 0)
-                printk(KERN_INFO KBUILD_MODNAME ": " DRIVER_DESC "\n");
-        return result;
+        return usb_register(&xpad_driver);
 }
 
 static void __exit usb_xpad_exit(void)