1 files changed, 6 insertions, 8 deletions

diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c
index 653ac6bfc57a..6c923c7039a1 100644
--- a/drivers/infiniband/ulp/srpt/ib_srpt.c
+++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
@@ -1588,7 +1588,7 @@ static int srpt_build_tskmgmt_rsp(struct srpt_rdma_ch *ch,
         int resp_data_len;
         int resp_len;
 
-        resp_data_len = (rsp_code == SRP_TSK_MGMT_SUCCESS) ? 0 : 4;
+        resp_data_len = 4;
         resp_len = sizeof(*srp_rsp) + resp_data_len;
 
         srp_rsp = ioctx->ioctx.buf;
@@ -1600,11 +1600,9 @@ static int srpt_build_tskmgmt_rsp(struct srpt_rdma_ch *ch,
                                     + atomic_xchg(&ch->req_lim_delta, 0));
         srp_rsp->tag = tag;
 
-        if (rsp_code != SRP_TSK_MGMT_SUCCESS) {
-                srp_rsp->flags |= SRP_RSP_FLAG_RSPVALID;
-                srp_rsp->resp_data_len = cpu_to_be32(resp_data_len);
-                srp_rsp->data[3] = rsp_code;
-        }
+        srp_rsp->flags |= SRP_RSP_FLAG_RSPVALID;
+        srp_rsp->resp_data_len = cpu_to_be32(resp_data_len);
+        srp_rsp->data[3] = rsp_code;
 
         return resp_len;
 }
@@ -2358,6 +2356,8 @@ static void srpt_release_channel_work(struct work_struct *w)
         transport_deregister_session(se_sess);
         ch->sess = NULL;
 
+        ib_destroy_cm_id(ch->cm_id);
+
         srpt_destroy_ch_ib(ch);
 
         srpt_free_ioctx_ring((struct srpt_ioctx **)ch->ioctx_ring,
@@ -2368,8 +2368,6 @@ static void srpt_release_channel_work(struct work_struct *w)
         list_del(&ch->list);
         spin_unlock_irq(&sdev->spinlock);
 
-        ib_destroy_cm_id(ch->cm_id);
-
         if (ch->release_done)
                 complete(ch->release_done);