diff options
Diffstat (limited to 'drivers/ieee1394/eth1394.c')
-rw-r--r-- | drivers/ieee1394/eth1394.c | 14 |
1 files changed, 4 insertions, 10 deletions
diff --git a/drivers/ieee1394/eth1394.c b/drivers/ieee1394/eth1394.c index f5c586c2bba6..1ad8785e398b 100644 --- a/drivers/ieee1394/eth1394.c +++ b/drivers/ieee1394/eth1394.c | |||
@@ -169,7 +169,8 @@ static int ether1394_header_cache(const struct neighbour *neigh, | |||
169 | static void ether1394_header_cache_update(struct hh_cache *hh, | 169 | static void ether1394_header_cache_update(struct hh_cache *hh, |
170 | const struct net_device *dev, | 170 | const struct net_device *dev, |
171 | const unsigned char *haddr); | 171 | const unsigned char *haddr); |
172 | static int ether1394_tx(struct sk_buff *skb, struct net_device *dev); | 172 | static netdev_tx_t ether1394_tx(struct sk_buff *skb, |
173 | struct net_device *dev); | ||
173 | static void ether1394_iso(struct hpsb_iso *iso); | 174 | static void ether1394_iso(struct hpsb_iso *iso); |
174 | 175 | ||
175 | static struct ethtool_ops ethtool_ops; | 176 | static struct ethtool_ops ethtool_ops; |
@@ -1555,7 +1556,8 @@ static void ether1394_complete_cb(void *__ptask) | |||
1555 | } | 1556 | } |
1556 | 1557 | ||
1557 | /* Transmit a packet (called by kernel) */ | 1558 | /* Transmit a packet (called by kernel) */ |
1558 | static int ether1394_tx(struct sk_buff *skb, struct net_device *dev) | 1559 | static netdev_tx_t ether1394_tx(struct sk_buff *skb, |
1560 | struct net_device *dev) | ||
1559 | { | 1561 | { |
1560 | struct eth1394hdr hdr_buf; | 1562 | struct eth1394hdr hdr_buf; |
1561 | struct eth1394_priv *priv = netdev_priv(dev); | 1563 | struct eth1394_priv *priv = netdev_priv(dev); |
@@ -1694,14 +1696,6 @@ fail: | |||
1694 | dev->stats.tx_errors++; | 1696 | dev->stats.tx_errors++; |
1695 | spin_unlock_irqrestore(&priv->lock, flags); | 1697 | spin_unlock_irqrestore(&priv->lock, flags); |
1696 | 1698 | ||
1697 | /* | ||
1698 | * FIXME: According to a patch from 2003-02-26, "returning non-zero | ||
1699 | * causes serious problems" here, allegedly. Before that patch, | ||
1700 | * -ERRNO was returned which is not appropriate under Linux 2.6. | ||
1701 | * Perhaps more needs to be done? Stop the queue in serious | ||
1702 | * conditions and restart it elsewhere? | ||
1703 | */ | ||
1704 | /* return NETDEV_TX_BUSY; */ | ||
1705 | return NETDEV_TX_OK; | 1699 | return NETDEV_TX_OK; |
1706 | } | 1700 | } |
1707 | 1701 | ||