1 files changed, 33 insertions, 130 deletions

diff --git a/drivers/ide/pci/piix.c b/drivers/ide/pci/piix.c
index 061d300ab8be..8b219dd63024 100644
--- a/drivers/ide/pci/piix.c
+++ b/drivers/ide/pci/piix.c
@@ -106,68 +106,6 @@
 static int no_piix_dma;
 
 /**
- *      piix_ratemask           -       compute rate mask for PIIX IDE
- *      @drive: IDE drive to compute for
- *
- *      Returns the available modes for the PIIX IDE controller.
- */
- 
-static u8 piix_ratemask (ide_drive_t *drive)
-{
-        struct pci_dev *dev     = HWIF(drive)->pci_dev;
-        u8 mode;
-
-        switch(dev->device) {
-                case PCI_DEVICE_ID_INTEL_82801EB_1:
-                        mode = 3;
-                        break;
-                /* UDMA 100 capable */
-                case PCI_DEVICE_ID_INTEL_82801BA_8:
-                case PCI_DEVICE_ID_INTEL_82801BA_9:
-                case PCI_DEVICE_ID_INTEL_82801CA_10:
-                case PCI_DEVICE_ID_INTEL_82801CA_11:
-                case PCI_DEVICE_ID_INTEL_82801E_11:
-                case PCI_DEVICE_ID_INTEL_82801DB_1:
-                case PCI_DEVICE_ID_INTEL_82801DB_10:
-                case PCI_DEVICE_ID_INTEL_82801DB_11:
-                case PCI_DEVICE_ID_INTEL_82801EB_11:
-                case PCI_DEVICE_ID_INTEL_ESB_2:
-                case PCI_DEVICE_ID_INTEL_ICH6_19:
-                case PCI_DEVICE_ID_INTEL_ICH7_21:
-                case PCI_DEVICE_ID_INTEL_ESB2_18:
-                case PCI_DEVICE_ID_INTEL_ICH8_6:
-                        mode = 3;
-                        break;
-                /* UDMA 66 capable */
-                case PCI_DEVICE_ID_INTEL_82801AA_1:
-                case PCI_DEVICE_ID_INTEL_82372FB_1:
-                        mode = 2;
-                        break;
-                /* UDMA 33 capable */
-                case PCI_DEVICE_ID_INTEL_82371AB:
-                case PCI_DEVICE_ID_INTEL_82443MX_1:
-                case PCI_DEVICE_ID_INTEL_82451NX:
-                case PCI_DEVICE_ID_INTEL_82801AB_1:
-                        return 1;
-                /* Non UDMA capable (MWDMA2) */
-                case PCI_DEVICE_ID_INTEL_82371SB_1:
-                case PCI_DEVICE_ID_INTEL_82371FB_1:
-                case PCI_DEVICE_ID_INTEL_82371FB_0:
-                case PCI_DEVICE_ID_INTEL_82371MX:
-                default:
-                        return 0;
-        }
-        
-        /*
-         *      If we are UDMA66 capable fall back to UDMA33 
-         *      if the drive cannot see an 80pin cable.
-         */
-        if (!eighty_ninty_three(drive))
-                mode = min_t(u8, mode, 1);
-        return mode;
-}
-
-/**
  *      piix_dma_2_pio          -       return the PIO mode matching DMA
  *      @xfer_rate: transfer speed
  *
@@ -301,7 +239,7 @@ static int piix_tune_chipset (ide_drive_t *drive, u8 xferspeed)
         ide_hwif_t *hwif        = HWIF(drive);
         struct pci_dev *dev     = hwif->pci_dev;
         u8 maslave              = hwif->channel ? 0x42 : 0x40;
-        u8 speed                = ide_rate_filter(piix_ratemask(drive), xferspeed);
+        u8 speed                = ide_rate_filter(drive, xferspeed);
         int a_speed             = 3 << (drive->dn * 4);
         int u_flag              = 1 << drive->dn;
         int v_flag              = 0x01 << drive->dn;
@@ -366,30 +304,6 @@ static int piix_tune_chipset (ide_drive_t *drive, u8 xferspeed)
 }
 
 /**
- *      piix_config_drive_for_dma       -       configure drive for DMA
- *      @drive: IDE drive to configure
- *
- *      Set up a PIIX interface channel for the best available speed.
- *      We prefer UDMA if it is available and then MWDMA.  If DMA is
- *      not available we switch to PIO and return 0.
- */
- 
-static int piix_config_drive_for_dma (ide_drive_t *drive)
-{
-        u8 speed = ide_dma_speed(drive, piix_ratemask(drive));
-
-        /*
-         * If no DMA speed was available or the chipset has DMA bugs
-         * then disable DMA and use PIO
-         */
-        if (!speed)
-                return 0;
-
-        (void) piix_tune_chipset(drive, speed);
-        return ide_dma_enable(drive);
-}
-
-/**
  *      piix_config_drive_xfer_rate     -       set up an IDE device
  *      @drive: IDE drive to configure
  *
@@ -401,7 +315,7 @@ static int piix_config_drive_xfer_rate (ide_drive_t *drive)
 {
         drive->init_speed = 0;
 
-        if (ide_use_dma(drive) && piix_config_drive_for_dma(drive))
+        if (ide_tune_dma(drive))
                 return 0;
 
         if (ide_use_fast_pio(drive))
@@ -524,26 +438,14 @@ static void __devinit init_hwif_piix(ide_hwif_t *hwif)
                 hwif->ide_dma_clear_irq = &piix_dma_clear_irq;
 
         hwif->atapi_dma = 1;
-        hwif->ultra_mask = 0x3f;
+
+        hwif->ultra_mask = hwif->cds->udma_mask;
         hwif->mwdma_mask = 0x06;
         hwif->swdma_mask = 0x04;
 
-        switch(hwif->pci_dev->device) {
-                case PCI_DEVICE_ID_INTEL_82371FB_0:
-                case PCI_DEVICE_ID_INTEL_82371FB_1:
-                case PCI_DEVICE_ID_INTEL_82371SB_1:
-                        hwif->ultra_mask = 0x80;
-                        break;
-                case PCI_DEVICE_ID_INTEL_82371AB:
-                case PCI_DEVICE_ID_INTEL_82443MX_1:
-                case PCI_DEVICE_ID_INTEL_82451NX:
-                case PCI_DEVICE_ID_INTEL_82801AB_1:
-                        hwif->ultra_mask = 0x07;
-                        break;
-                default:
-                        if (!hwif->udma_four)
-                                hwif->udma_four = piix_cable_detect(hwif);
-                        break;
+        if (hwif->ultra_mask & 0x78) {
+                if (!hwif->udma_four)
+                        hwif->udma_four = piix_cable_detect(hwif);
         }
 
         if (no_piix_dma)
@@ -557,7 +459,7 @@ static void __devinit init_hwif_piix(ide_hwif_t *hwif)
         hwif->drives[0].autodma = hwif->autodma;
 }
 
-#define DECLARE_PIIX_DEV(name_str) \
+#define DECLARE_PIIX_DEV(name_str, udma) \
         {                                               \
                 .name           = name_str,             \
                 .init_chipset   = init_chipset_piix,    \
@@ -566,11 +468,12 @@ static void __devinit init_hwif_piix(ide_hwif_t *hwif)
                 .autodma        = AUTODMA,              \
                 .enablebits     = {{0x41,0x80,0x80}, {0x43,0x80,0x80}}, \
                 .bootable       = ON_BOARD,             \
+                .udma_mask      = udma,                 \
         }
 
 static ide_pci_device_t piix_pci_info[] __devinitdata = {
-        /*  0 */ DECLARE_PIIX_DEV("PIIXa"),
-        /*  1 */ DECLARE_PIIX_DEV("PIIXb"),
+        /*  0 */ DECLARE_PIIX_DEV("PIIXa", 0x00),       /* no udma */
+        /*  1 */ DECLARE_PIIX_DEV("PIIXb", 0x00),       /* no udma */
 
         /*  2 */
         {       /*
@@ -587,28 +490,28 @@ static ide_pci_device_t piix_pci_info[] __devinitdata = {
                 .flags          = IDEPCI_FLAG_ISA_PORTS
         },
 
-        /*  3 */ DECLARE_PIIX_DEV("PIIX3"),
-        /*  4 */ DECLARE_PIIX_DEV("PIIX4"),
-        /*  5 */ DECLARE_PIIX_DEV("ICH0"),
-        /*  6 */ DECLARE_PIIX_DEV("PIIX4"),
-        /*  7 */ DECLARE_PIIX_DEV("ICH"),
-        /*  8 */ DECLARE_PIIX_DEV("PIIX4"),
-        /*  9 */ DECLARE_PIIX_DEV("PIIX4"),
-        /* 10 */ DECLARE_PIIX_DEV("ICH2"),
-        /* 11 */ DECLARE_PIIX_DEV("ICH2M"),
-        /* 12 */ DECLARE_PIIX_DEV("ICH3M"),
-        /* 13 */ DECLARE_PIIX_DEV("ICH3"),
-        /* 14 */ DECLARE_PIIX_DEV("ICH4"),
-        /* 15 */ DECLARE_PIIX_DEV("ICH5"),
-        /* 16 */ DECLARE_PIIX_DEV("C-ICH"),
-        /* 17 */ DECLARE_PIIX_DEV("ICH4"),
-        /* 18 */ DECLARE_PIIX_DEV("ICH5-SATA"),
-        /* 19 */ DECLARE_PIIX_DEV("ICH5"),
-        /* 20 */ DECLARE_PIIX_DEV("ICH6"),
-        /* 21 */ DECLARE_PIIX_DEV("ICH7"),
-        /* 22 */ DECLARE_PIIX_DEV("ICH4"),
-        /* 23 */ DECLARE_PIIX_DEV("ESB2"),
-        /* 24 */ DECLARE_PIIX_DEV("ICH8M"),
+        /*  3 */ DECLARE_PIIX_DEV("PIIX3", 0x00),       /* no udma */
+        /*  4 */ DECLARE_PIIX_DEV("PIIX4", 0x07),       /* udma0-2 */
+        /*  5 */ DECLARE_PIIX_DEV("ICH0",  0x07),       /* udma0-2 */
+        /*  6 */ DECLARE_PIIX_DEV("PIIX4", 0x07),       /* udma0-2 */
+        /*  7 */ DECLARE_PIIX_DEV("ICH",   0x1f),       /* udma0-4 */
+        /*  8 */ DECLARE_PIIX_DEV("PIIX4", 0x1f),       /* udma0-4 */
+        /*  9 */ DECLARE_PIIX_DEV("PIIX4", 0x07),       /* udma0-2 */
+        /* 10 */ DECLARE_PIIX_DEV("ICH2",  0x3f),       /* udma0-5 */
+        /* 11 */ DECLARE_PIIX_DEV("ICH2M", 0x3f),       /* udma0-5 */
+        /* 12 */ DECLARE_PIIX_DEV("ICH3M", 0x3f),       /* udma0-5 */
+        /* 13 */ DECLARE_PIIX_DEV("ICH3",  0x3f),       /* udma0-5 */
+        /* 14 */ DECLARE_PIIX_DEV("ICH4",  0x3f),       /* udma0-5 */
+        /* 15 */ DECLARE_PIIX_DEV("ICH5",  0x3f),       /* udma0-5 */
+        /* 16 */ DECLARE_PIIX_DEV("C-ICH", 0x3f),       /* udma0-5 */
+        /* 17 */ DECLARE_PIIX_DEV("ICH4",  0x3f),       /* udma0-5 */
+        /* 18 */ DECLARE_PIIX_DEV("ICH5-SATA", 0x3f),   /* udma0-5 */
+        /* 19 */ DECLARE_PIIX_DEV("ICH5",  0x3f),       /* udma0-5 */
+        /* 20 */ DECLARE_PIIX_DEV("ICH6",  0x3f),       /* udma0-5 */
+        /* 21 */ DECLARE_PIIX_DEV("ICH7",  0x3f),       /* udma0-5 */
+        /* 22 */ DECLARE_PIIX_DEV("ICH4",  0x3f),       /* udma0-5 */
+        /* 23 */ DECLARE_PIIX_DEV("ESB2",  0x3f),       /* udma0-5 */
+        /* 24 */ DECLARE_PIIX_DEV("ICH8M", 0x3f),       /* udma0-5 */
 };
 
 /**