14 files changed, 404 insertions, 73 deletions

diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c
index ef40381f3909..6553fd238685 100644
--- a/drivers/gpu/drm/tegra/dc.c
+++ b/drivers/gpu/drm/tegra/dc.c
@@ -18,6 +18,8 @@
 struct tegra_dc_soc_info {
         bool supports_interlacing;
         bool supports_cursor;
+        bool supports_block_linear;
+        unsigned int pitch_align;
 };
 
 struct tegra_plane {
@@ -212,15 +214,44 @@ static int tegra_dc_setup_window(struct tegra_dc *dc, unsigned int index,
         tegra_dc_writel(dc, h_offset, DC_WINBUF_ADDR_H_OFFSET);
         tegra_dc_writel(dc, v_offset, DC_WINBUF_ADDR_V_OFFSET);
 
-        if (window->tiled) {
-                value = DC_WIN_BUFFER_ADDR_MODE_TILE_UV |
-                        DC_WIN_BUFFER_ADDR_MODE_TILE;
+        if (dc->soc->supports_block_linear) {
+                unsigned long height = window->tiling.value;
+
+                switch (window->tiling.mode) {
+                case TEGRA_BO_TILING_MODE_PITCH:
+                        value = DC_WINBUF_SURFACE_KIND_PITCH;
+                        break;
+
+                case TEGRA_BO_TILING_MODE_TILED:
+                        value = DC_WINBUF_SURFACE_KIND_TILED;
+                        break;
+
+                case TEGRA_BO_TILING_MODE_BLOCK:
+                        value = DC_WINBUF_SURFACE_KIND_BLOCK_HEIGHT(height) |
+                                DC_WINBUF_SURFACE_KIND_BLOCK;
+                        break;
+                }
+
+                tegra_dc_writel(dc, value, DC_WINBUF_SURFACE_KIND);
         } else {
-                value = DC_WIN_BUFFER_ADDR_MODE_LINEAR_UV |
-                        DC_WIN_BUFFER_ADDR_MODE_LINEAR;
-        }
+                switch (window->tiling.mode) {
+                case TEGRA_BO_TILING_MODE_PITCH:
+                        value = DC_WIN_BUFFER_ADDR_MODE_LINEAR_UV |
+                                DC_WIN_BUFFER_ADDR_MODE_LINEAR;
+                        break;
 
-        tegra_dc_writel(dc, value, DC_WIN_BUFFER_ADDR_MODE);
+                case TEGRA_BO_TILING_MODE_TILED:
+                        value = DC_WIN_BUFFER_ADDR_MODE_TILE_UV |
+                                DC_WIN_BUFFER_ADDR_MODE_TILE;
+                        break;
+
+                case TEGRA_BO_TILING_MODE_BLOCK:
+                        DRM_ERROR("hardware doesn't support block linear mode\n");
+                        return -EINVAL;
+                }
+
+                tegra_dc_writel(dc, value, DC_WIN_BUFFER_ADDR_MODE);
+        }
 
         value = WIN_ENABLE;
 
@@ -288,6 +319,7 @@ static int tegra_plane_update(struct drm_plane *plane, struct drm_crtc *crtc,
         struct tegra_dc *dc = to_tegra_dc(crtc);
         struct tegra_dc_window window;
         unsigned int i;
+        int err;
 
         memset(&window, 0, sizeof(window));
         window.src.x = src_x >> 16;
@@ -301,7 +333,10 @@ static int tegra_plane_update(struct drm_plane *plane, struct drm_crtc *crtc,
         window.format = tegra_dc_format(fb->pixel_format, &window.swap);
         window.bits_per_pixel = fb->bits_per_pixel;
         window.bottom_up = tegra_fb_is_bottom_up(fb);
-        window.tiled = tegra_fb_is_tiled(fb);
+
+        err = tegra_fb_get_tiling(fb, &window.tiling);
+        if (err < 0)
+                return err;
 
         for (i = 0; i < drm_format_num_planes(fb->pixel_format); i++) {
                 struct tegra_bo *bo = tegra_fb_get_plane(fb, i);
@@ -402,8 +437,14 @@ static int tegra_dc_set_base(struct tegra_dc *dc, int x, int y,
 {
         struct tegra_bo *bo = tegra_fb_get_plane(fb, 0);
         unsigned int h_offset = 0, v_offset = 0;
+        struct tegra_bo_tiling tiling;
         unsigned int format, swap;
         unsigned long value;
+        int err;
+
+        err = tegra_fb_get_tiling(fb, &tiling);
+        if (err < 0)
+                return err;
 
         tegra_dc_writel(dc, WINDOW_A_SELECT, DC_CMD_DISPLAY_WINDOW_HEADER);
 
@@ -417,15 +458,44 @@ static int tegra_dc_set_base(struct tegra_dc *dc, int x, int y,
         tegra_dc_writel(dc, format, DC_WIN_COLOR_DEPTH);
         tegra_dc_writel(dc, swap, DC_WIN_BYTE_SWAP);
 
-        if (tegra_fb_is_tiled(fb)) {
-                value = DC_WIN_BUFFER_ADDR_MODE_TILE_UV |
-                        DC_WIN_BUFFER_ADDR_MODE_TILE;
+        if (dc->soc->supports_block_linear) {
+                unsigned long height = tiling.value;
+
+                switch (tiling.mode) {
+                case TEGRA_BO_TILING_MODE_PITCH:
+                        value = DC_WINBUF_SURFACE_KIND_PITCH;
+                        break;
+
+                case TEGRA_BO_TILING_MODE_TILED:
+                        value = DC_WINBUF_SURFACE_KIND_TILED;
+                        break;
+
+                case TEGRA_BO_TILING_MODE_BLOCK:
+                        value = DC_WINBUF_SURFACE_KIND_BLOCK_HEIGHT(height) |
+                                DC_WINBUF_SURFACE_KIND_BLOCK;
+                        break;
+                }
+
+                tegra_dc_writel(dc, value, DC_WINBUF_SURFACE_KIND);
         } else {
-                value = DC_WIN_BUFFER_ADDR_MODE_LINEAR_UV |
-                        DC_WIN_BUFFER_ADDR_MODE_LINEAR;
-        }
+                switch (tiling.mode) {
+                case TEGRA_BO_TILING_MODE_PITCH:
+                        value = DC_WIN_BUFFER_ADDR_MODE_LINEAR_UV |
+                                DC_WIN_BUFFER_ADDR_MODE_LINEAR;
+                        break;
+
+                case TEGRA_BO_TILING_MODE_TILED:
+                        value = DC_WIN_BUFFER_ADDR_MODE_TILE_UV |
+                                DC_WIN_BUFFER_ADDR_MODE_TILE;
+                        break;
+
+                case TEGRA_BO_TILING_MODE_BLOCK:
+                        DRM_ERROR("hardware doesn't support block linear mode\n");
+                        return -EINVAL;
+                }
 
-        tegra_dc_writel(dc, value, DC_WIN_BUFFER_ADDR_MODE);
+                tegra_dc_writel(dc, value, DC_WIN_BUFFER_ADDR_MODE);
+        }
 
         /* make sure bottom-up buffers are properly displayed */
         if (tegra_fb_is_bottom_up(fb)) {
@@ -1214,12 +1284,20 @@ static int tegra_dc_init(struct host1x_client *client)
 {
         struct drm_device *drm = dev_get_drvdata(client->parent);
         struct tegra_dc *dc = host1x_client_to_dc(client);
+        struct tegra_drm *tegra = drm->dev_private;
         int err;
 
         drm_crtc_init(drm, &dc->base, &tegra_crtc_funcs);
         drm_mode_crtc_set_gamma_size(&dc->base, 256);
         drm_crtc_helper_add(&dc->base, &tegra_crtc_helper_funcs);
 
+        /*
+         * Keep track of the minimum pitch alignment across all display
+         * controllers.
+         */
+        if (dc->soc->pitch_align > tegra->pitch_align)
+                tegra->pitch_align = dc->soc->pitch_align;
+
         err = tegra_dc_rgb_init(drm, dc);
         if (err < 0 && err != -ENODEV) {
                 dev_err(dc->dev, "failed to initialize RGB output: %d\n", err);
@@ -1277,16 +1355,29 @@ static const struct host1x_client_ops dc_client_ops = {
 static const struct tegra_dc_soc_info tegra20_dc_soc_info = {
         .supports_interlacing = false,
         .supports_cursor = false,
+        .supports_block_linear = false,
+        .pitch_align = 8,
 };
 
 static const struct tegra_dc_soc_info tegra30_dc_soc_info = {
         .supports_interlacing = false,
         .supports_cursor = false,
+        .supports_block_linear = false,
+        .pitch_align = 8,
+};
+
+static const struct tegra_dc_soc_info tegra114_dc_soc_info = {
+        .supports_interlacing = false,
+        .supports_cursor = false,
+        .supports_block_linear = false,
+        .pitch_align = 64,
 };
 
 static const struct tegra_dc_soc_info tegra124_dc_soc_info = {
         .supports_interlacing = true,
         .supports_cursor = true,
+        .supports_block_linear = true,
+        .pitch_align = 64,
 };
 
 static const struct of_device_id tegra_dc_of_match[] = {
@@ -1303,6 +1394,7 @@ static const struct of_device_id tegra_dc_of_match[] = {
                 /* sentinel */
         }
 };
+MODULE_DEVICE_TABLE(of, tegra_dc_of_match);
 
 static int tegra_dc_parse_dt(struct tegra_dc *dc)
 {
@@ -1430,6 +1522,7 @@ static int tegra_dc_remove(struct platform_device *pdev)
                 return err;
         }
 
+        reset_control_assert(dc->rst);
         clk_disable_unprepare(dc->clk);
 
         return 0;
diff --git a/drivers/gpu/drm/tegra/dc.h b/drivers/gpu/drm/tegra/dc.h
index 78c5feff95d2..705c93b00794 100644
--- a/drivers/gpu/drm/tegra/dc.h
+++ b/drivers/gpu/drm/tegra/dc.h
@@ -428,6 +428,11 @@
 #define DC_WINBUF_ADDR_V_OFFSET_NS              0x809
 
 #define DC_WINBUF_UFLOW_STATUS                  0x80a
+#define DC_WINBUF_SURFACE_KIND                  0x80b
+#define DC_WINBUF_SURFACE_KIND_PITCH    (0 << 0)
+#define DC_WINBUF_SURFACE_KIND_TILED    (1 << 0)
+#define DC_WINBUF_SURFACE_KIND_BLOCK    (2 << 0)
+#define DC_WINBUF_SURFACE_KIND_BLOCK_HEIGHT(x) (((x) & 0x7) << 4)
 
 #define DC_WINBUF_AD_UFLOW_STATUS               0xbca
 #define DC_WINBUF_BD_UFLOW_STATUS               0xdca
diff --git a/drivers/gpu/drm/tegra/dpaux.c b/drivers/gpu/drm/tegra/dpaux.c
index 3f132e356e9c..708f783ead47 100644
--- a/drivers/gpu/drm/tegra/dpaux.c
+++ b/drivers/gpu/drm/tegra/dpaux.c
@@ -382,6 +382,7 @@ static const struct of_device_id tegra_dpaux_of_match[] = {
         { .compatible = "nvidia,tegra124-dpaux", },
         { },
 };
+MODULE_DEVICE_TABLE(of, tegra_dpaux_of_match);
 
 struct platform_driver tegra_dpaux_driver = {
         .driver = {
diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c
index 3396f9f6a9f7..59736bb810cd 100644
--- a/drivers/gpu/drm/tegra/drm.c
+++ b/drivers/gpu/drm/tegra/drm.c
@@ -40,6 +40,12 @@ static int tegra_drm_load(struct drm_device *drm, unsigned long flags)
 
         drm_mode_config_init(drm);
 
+        err = tegra_drm_fb_prepare(drm);
+        if (err < 0)
+                return err;
+
+        drm_kms_helper_poll_init(drm);
+
         err = host1x_device_init(device);
         if (err < 0)
                 return err;
@@ -59,8 +65,6 @@ static int tegra_drm_load(struct drm_device *drm, unsigned long flags)
         if (err < 0)
                 return err;
 
-        drm_kms_helper_poll_init(drm);
-
         return 0;
 }
 
@@ -128,6 +132,45 @@ host1x_bo_lookup(struct drm_device *drm, struct drm_file *file, u32 handle)
         return &bo->base;
 }
 
+static int host1x_reloc_copy_from_user(struct host1x_reloc *dest,
+                                       struct drm_tegra_reloc __user *src,
+                                       struct drm_device *drm,
+                                       struct drm_file *file)
+{
+        u32 cmdbuf, target;
+        int err;
+
+        err = get_user(cmdbuf, &src->cmdbuf.handle);
+        if (err < 0)
+                return err;
+
+        err = get_user(dest->cmdbuf.offset, &src->cmdbuf.offset);
+        if (err < 0)
+                return err;
+
+        err = get_user(target, &src->target.handle);
+        if (err < 0)
+                return err;
+
+        err = get_user(dest->target.offset, &src->cmdbuf.offset);
+        if (err < 0)
+                return err;
+
+        err = get_user(dest->shift, &src->shift);
+        if (err < 0)
+                return err;
+
+        dest->cmdbuf.bo = host1x_bo_lookup(drm, file, cmdbuf);
+        if (!dest->cmdbuf.bo)
+                return -ENOENT;
+
+        dest->target.bo = host1x_bo_lookup(drm, file, target);
+        if (!dest->target.bo)
+                return -ENOENT;
+
+        return 0;
+}
+
 int tegra_drm_submit(struct tegra_drm_context *context,
                      struct drm_tegra_submit *args, struct drm_device *drm,
                      struct drm_file *file)
@@ -180,26 +223,13 @@ int tegra_drm_submit(struct tegra_drm_context *context,
                 cmdbufs++;
         }
 
-        if (copy_from_user(job->relocarray, relocs,
-                           sizeof(*relocs) * num_relocs)) {
-                err = -EFAULT;
-                goto fail;
-        }
-
+        /* copy and resolve relocations from submit */
         while (num_relocs--) {
-                struct host1x_reloc *reloc = &job->relocarray[num_relocs];
-                struct host1x_bo *cmdbuf, *target;
-
-                cmdbuf = host1x_bo_lookup(drm, file, (u32)reloc->cmdbuf);
-                target = host1x_bo_lookup(drm, file, (u32)reloc->target);
-
-                reloc->cmdbuf = cmdbuf;
-                reloc->target = target;
-
-                if (!reloc->target || !reloc->cmdbuf) {
-                        err = -ENOENT;
+                err = host1x_reloc_copy_from_user(&job->relocarray[num_relocs],
+                                                  &relocs[num_relocs], drm,
+                                                  file);
+                if (err < 0)
                         goto fail;
-                }
         }
 
         if (copy_from_user(job->waitchk, waitchks,
@@ -451,11 +481,151 @@ static int tegra_get_syncpt_base(struct drm_device *drm, void *data,
 
         return 0;
 }
+
+static int tegra_gem_set_tiling(struct drm_device *drm, void *data,
+                                struct drm_file *file)
+{
+        struct drm_tegra_gem_set_tiling *args = data;
+        enum tegra_bo_tiling_mode mode;
+        struct drm_gem_object *gem;
+        unsigned long value = 0;
+        struct tegra_bo *bo;
+
+        switch (args->mode) {
+        case DRM_TEGRA_GEM_TILING_MODE_PITCH:
+                mode = TEGRA_BO_TILING_MODE_PITCH;
+
+                if (args->value != 0)
+                        return -EINVAL;
+
+                break;
+
+        case DRM_TEGRA_GEM_TILING_MODE_TILED:
+                mode = TEGRA_BO_TILING_MODE_TILED;
+
+                if (args->value != 0)
+                        return -EINVAL;
+
+                break;
+
+        case DRM_TEGRA_GEM_TILING_MODE_BLOCK:
+                mode = TEGRA_BO_TILING_MODE_BLOCK;
+
+                if (args->value > 5)
+                        return -EINVAL;
+
+                value = args->value;
+                break;
+
+        default:
+                return -EINVAL;
+        }
+
+        gem = drm_gem_object_lookup(drm, file, args->handle);
+        if (!gem)
+                return -ENOENT;
+
+        bo = to_tegra_bo(gem);
+
+        bo->tiling.mode = mode;
+        bo->tiling.value = value;
+
+        drm_gem_object_unreference(gem);
+
+        return 0;
+}
+
+static int tegra_gem_get_tiling(struct drm_device *drm, void *data,
+                                struct drm_file *file)
+{
+        struct drm_tegra_gem_get_tiling *args = data;
+        struct drm_gem_object *gem;
+        struct tegra_bo *bo;
+        int err = 0;
+
+        gem = drm_gem_object_lookup(drm, file, args->handle);
+        if (!gem)
+                return -ENOENT;
+
+        bo = to_tegra_bo(gem);
+
+        switch (bo->tiling.mode) {
+        case TEGRA_BO_TILING_MODE_PITCH:
+                args->mode = DRM_TEGRA_GEM_TILING_MODE_PITCH;
+                args->value = 0;
+                break;
+
+        case TEGRA_BO_TILING_MODE_TILED:
+                args->mode = DRM_TEGRA_GEM_TILING_MODE_TILED;
+                args->value = 0;
+                break;
+
+        case TEGRA_BO_TILING_MODE_BLOCK:
+                args->mode = DRM_TEGRA_GEM_TILING_MODE_BLOCK;
+                args->value = bo->tiling.value;
+                break;
+
+        default:
+                err = -EINVAL;
+                break;
+        }
+
+        drm_gem_object_unreference(gem);
+
+        return err;
+}
+
+static int tegra_gem_set_flags(struct drm_device *drm, void *data,
+                               struct drm_file *file)
+{
+        struct drm_tegra_gem_set_flags *args = data;
+        struct drm_gem_object *gem;
+        struct tegra_bo *bo;
+
+        if (args->flags & ~DRM_TEGRA_GEM_FLAGS)
+                return -EINVAL;
+
+        gem = drm_gem_object_lookup(drm, file, args->handle);
+        if (!gem)
+                return -ENOENT;
+
+        bo = to_tegra_bo(gem);
+        bo->flags = 0;
+
+        if (args->flags & DRM_TEGRA_GEM_BOTTOM_UP)
+                bo->flags |= TEGRA_BO_BOTTOM_UP;
+
+        drm_gem_object_unreference(gem);
+
+        return 0;
+}
+
+static int tegra_gem_get_flags(struct drm_device *drm, void *data,
+                               struct drm_file *file)
+{
+        struct drm_tegra_gem_get_flags *args = data;
+        struct drm_gem_object *gem;
+        struct tegra_bo *bo;
+
+        gem = drm_gem_object_lookup(drm, file, args->handle);
+        if (!gem)
+                return -ENOENT;
+
+        bo = to_tegra_bo(gem);
+        args->flags = 0;
+
+        if (bo->flags & TEGRA_BO_BOTTOM_UP)
+                args->flags |= DRM_TEGRA_GEM_BOTTOM_UP;
+
+        drm_gem_object_unreference(gem);
+
+        return 0;
+}
 #endif
 
 static const struct drm_ioctl_desc tegra_drm_ioctls[] = {
 #ifdef CONFIG_DRM_TEGRA_STAGING
-        DRM_IOCTL_DEF_DRV(TEGRA_GEM_CREATE, tegra_gem_create, DRM_UNLOCKED | DRM_AUTH),
+        DRM_IOCTL_DEF_DRV(TEGRA_GEM_CREATE, tegra_gem_create, DRM_UNLOCKED),
         DRM_IOCTL_DEF_DRV(TEGRA_GEM_MMAP, tegra_gem_mmap, DRM_UNLOCKED),
         DRM_IOCTL_DEF_DRV(TEGRA_SYNCPT_READ, tegra_syncpt_read, DRM_UNLOCKED),
         DRM_IOCTL_DEF_DRV(TEGRA_SYNCPT_INCR, tegra_syncpt_incr, DRM_UNLOCKED),
@@ -465,6 +635,10 @@ static const struct drm_ioctl_desc tegra_drm_ioctls[] = {
         DRM_IOCTL_DEF_DRV(TEGRA_GET_SYNCPT, tegra_get_syncpt, DRM_UNLOCKED),
         DRM_IOCTL_DEF_DRV(TEGRA_SUBMIT, tegra_submit, DRM_UNLOCKED),
         DRM_IOCTL_DEF_DRV(TEGRA_GET_SYNCPT_BASE, tegra_get_syncpt_base, DRM_UNLOCKED),
+        DRM_IOCTL_DEF_DRV(TEGRA_GEM_SET_TILING, tegra_gem_set_tiling, DRM_UNLOCKED),
+        DRM_IOCTL_DEF_DRV(TEGRA_GEM_GET_TILING, tegra_gem_get_tiling, DRM_UNLOCKED),
+        DRM_IOCTL_DEF_DRV(TEGRA_GEM_SET_FLAGS, tegra_gem_set_flags, DRM_UNLOCKED),
+        DRM_IOCTL_DEF_DRV(TEGRA_GEM_GET_FLAGS, tegra_gem_get_flags, DRM_UNLOCKED),
 #endif
 };
 
diff --git a/drivers/gpu/drm/tegra/drm.h b/drivers/gpu/drm/tegra/drm.h
index 6b8fe9d86ed4..e89c70fa82d5 100644
--- a/drivers/gpu/drm/tegra/drm.h
+++ b/drivers/gpu/drm/tegra/drm.h
@@ -19,6 +19,8 @@
 #include <drm/drm_fb_helper.h>
 #include <drm/drm_fixed.h>
 
+#include "gem.h"
+
 struct reset_control;
 
 struct tegra_fb {
@@ -43,6 +45,8 @@ struct tegra_drm {
 #ifdef CONFIG_DRM_TEGRA_FBDEV
         struct tegra_fbdev *fbdev;
 #endif
+
+        unsigned int pitch_align;
 };
 
 struct tegra_drm_client;
@@ -160,7 +164,8 @@ struct tegra_dc_window {
         unsigned int stride[2];
         unsigned long base[3];
         bool bottom_up;
-        bool tiled;
+
+        struct tegra_bo_tiling tiling;
 };
 
 /* from dc.c */
@@ -279,7 +284,9 @@ int tegra_dpaux_train(struct tegra_dpaux *dpaux, struct drm_dp_link *link,
 struct tegra_bo *tegra_fb_get_plane(struct drm_framebuffer *framebuffer,
                                     unsigned int index);
 bool tegra_fb_is_bottom_up(struct drm_framebuffer *framebuffer);
-bool tegra_fb_is_tiled(struct drm_framebuffer *framebuffer);
+int tegra_fb_get_tiling(struct drm_framebuffer *framebuffer,
+                        struct tegra_bo_tiling *tiling);
+int tegra_drm_fb_prepare(struct drm_device *drm);
 int tegra_drm_fb_init(struct drm_device *drm);
 void tegra_drm_fb_exit(struct drm_device *drm);
 #ifdef CONFIG_DRM_TEGRA_FBDEV
diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c
index bd56f2affa78..f7874458926a 100644
--- a/drivers/gpu/drm/tegra/dsi.c
+++ b/drivers/gpu/drm/tegra/dsi.c
@@ -474,7 +474,8 @@ static int tegra_output_dsi_enable(struct tegra_output *output)
         tegra_dsi_writel(dsi, value, DSI_HOST_CONTROL);
 
         value = tegra_dsi_readl(dsi, DSI_CONTROL);
-        value |= DSI_CONTROL_HS_CLK_CTRL;
+        if (dsi->flags & MIPI_DSI_CLOCK_NON_CONTINUOUS)
+                value |= DSI_CONTROL_HS_CLK_CTRL;
         value &= ~DSI_CONTROL_TX_TRIG(3);
         value &= ~DSI_CONTROL_DCS_ENABLE;
         value |= DSI_CONTROL_VIDEO_ENABLE;
@@ -982,6 +983,7 @@ static const struct of_device_id tegra_dsi_of_match[] = {
         { .compatible = "nvidia,tegra114-dsi", },
         { },
 };
+MODULE_DEVICE_TABLE(of, tegra_dsi_of_match);
 
 struct platform_driver tegra_dsi_driver = {
         .driver = {
diff --git a/drivers/gpu/drm/tegra/fb.c b/drivers/gpu/drm/tegra/fb.c
index 9798a7080322..3513d12d5aa1 100644
--- a/drivers/gpu/drm/tegra/fb.c
+++ b/drivers/gpu/drm/tegra/fb.c
@@ -46,14 +46,15 @@ bool tegra_fb_is_bottom_up(struct drm_framebuffer *framebuffer)
         return false;
 }
 
-bool tegra_fb_is_tiled(struct drm_framebuffer *framebuffer)
+int tegra_fb_get_tiling(struct drm_framebuffer *framebuffer,
+                        struct tegra_bo_tiling *tiling)
 {
         struct tegra_fb *fb = to_tegra_fb(framebuffer);
 
-        if (fb->planes[0]->flags & TEGRA_BO_TILED)
-                return true;
+        /* TODO: handle YUV formats? */
+        *tiling = fb->planes[0]->tiling;
 
-        return false;
+        return 0;
 }
 
 static void tegra_fb_destroy(struct drm_framebuffer *framebuffer)
@@ -193,6 +194,7 @@ static int tegra_fbdev_probe(struct drm_fb_helper *helper,
                              struct drm_fb_helper_surface_size *sizes)
 {
         struct tegra_fbdev *fbdev = to_tegra_fbdev(helper);
+        struct tegra_drm *tegra = helper->dev->dev_private;
         struct drm_device *drm = helper->dev;
         struct drm_mode_fb_cmd2 cmd = { 0 };
         unsigned int bytes_per_pixel;
@@ -207,7 +209,8 @@ static int tegra_fbdev_probe(struct drm_fb_helper *helper,
 
         cmd.width = sizes->surface_width;
         cmd.height = sizes->surface_height;
-        cmd.pitches[0] = sizes->surface_width * bytes_per_pixel;
+        cmd.pitches[0] = round_up(sizes->surface_width * bytes_per_pixel,
+                                  tegra->pitch_align);
         cmd.pixel_format = drm_mode_legacy_fb_format(sizes->surface_bpp,
                                                      sizes->surface_depth);
 
@@ -267,18 +270,13 @@ release:
         return err;
 }
 
-static struct drm_fb_helper_funcs tegra_fb_helper_funcs = {
+static const struct drm_fb_helper_funcs tegra_fb_helper_funcs = {
         .fb_probe = tegra_fbdev_probe,
 };
 
-static struct tegra_fbdev *tegra_fbdev_create(struct drm_device *drm,
-                                              unsigned int preferred_bpp,
-                                              unsigned int num_crtc,
-                                              unsigned int max_connectors)
+static struct tegra_fbdev *tegra_fbdev_create(struct drm_device *drm)
 {
-        struct drm_fb_helper *helper;
         struct tegra_fbdev *fbdev;
-        int err;
 
         fbdev = kzalloc(sizeof(*fbdev), GFP_KERNEL);
         if (!fbdev) {
@@ -286,13 +284,23 @@ static struct tegra_fbdev *tegra_fbdev_create(struct drm_device *drm,
                 return ERR_PTR(-ENOMEM);
         }
 
-        fbdev->base.funcs = &tegra_fb_helper_funcs;
-        helper = &fbdev->base;
+        drm_fb_helper_prepare(drm, &fbdev->base, &tegra_fb_helper_funcs);
+
+        return fbdev;
+}
+
+static int tegra_fbdev_init(struct tegra_fbdev *fbdev,
+                            unsigned int preferred_bpp,
+                            unsigned int num_crtc,
+                            unsigned int max_connectors)
+{
+        struct drm_device *drm = fbdev->base.dev;
+        int err;
 
         err = drm_fb_helper_init(drm, &fbdev->base, num_crtc, max_connectors);
         if (err < 0) {
                 dev_err(drm->dev, "failed to initialize DRM FB helper\n");
-                goto free;
+                return err;
         }
 
         err = drm_fb_helper_single_add_all_connectors(&fbdev->base);
@@ -301,21 +309,17 @@ static struct tegra_fbdev *tegra_fbdev_create(struct drm_device *drm,
                 goto fini;
         }
 
-        drm_helper_disable_unused_functions(drm);
-
         err = drm_fb_helper_initial_config(&fbdev->base, preferred_bpp);
         if (err < 0) {
                 dev_err(drm->dev, "failed to set initial configuration\n");
                 goto fini;
         }
 
-        return fbdev;
+        return 0;
 
 fini:
         drm_fb_helper_fini(&fbdev->base);
-free:
-        kfree(fbdev);
-        return ERR_PTR(err);
+        return err;
 }
 
 static void tegra_fbdev_free(struct tegra_fbdev *fbdev)
@@ -366,7 +370,7 @@ static const struct drm_mode_config_funcs tegra_drm_mode_funcs = {
 #endif
 };
 
-int tegra_drm_fb_init(struct drm_device *drm)
+int tegra_drm_fb_prepare(struct drm_device *drm)
 {
 #ifdef CONFIG_DRM_TEGRA_FBDEV
         struct tegra_drm *tegra = drm->dev_private;
@@ -381,8 +385,7 @@ int tegra_drm_fb_init(struct drm_device *drm)
         drm->mode_config.funcs = &tegra_drm_mode_funcs;
 
 #ifdef CONFIG_DRM_TEGRA_FBDEV
-        tegra->fbdev = tegra_fbdev_create(drm, 32, drm->mode_config.num_crtc,
-                                          drm->mode_config.num_connector);
+        tegra->fbdev = tegra_fbdev_create(drm);
         if (IS_ERR(tegra->fbdev))
                 return PTR_ERR(tegra->fbdev);
 #endif
@@ -390,6 +393,21 @@ int tegra_drm_fb_init(struct drm_device *drm)
         return 0;
 }
 
+int tegra_drm_fb_init(struct drm_device *drm)
+{
+#ifdef CONFIG_DRM_TEGRA_FBDEV
+        struct tegra_drm *tegra = drm->dev_private;
+        int err;
+
+        err = tegra_fbdev_init(tegra->fbdev, 32, drm->mode_config.num_crtc,
+                               drm->mode_config.num_connector);
+        if (err < 0)
+                return err;
+#endif
+
+        return 0;
+}
+
 void tegra_drm_fb_exit(struct drm_device *drm)
 {
 #ifdef CONFIG_DRM_TEGRA_FBDEV
diff --git a/drivers/gpu/drm/tegra/gem.c b/drivers/gpu/drm/tegra/gem.c
index 78cc8143760a..ce023fa3e8ae 100644
--- a/drivers/gpu/drm/tegra/gem.c
+++ b/drivers/gpu/drm/tegra/gem.c
@@ -16,6 +16,7 @@
 #include <linux/dma-buf.h>
 #include <drm/tegra_drm.h>
 
+#include "drm.h"
 #include "gem.h"
 
 static inline struct tegra_bo *host1x_to_tegra_bo(struct host1x_bo *bo)
@@ -126,7 +127,7 @@ struct tegra_bo *tegra_bo_create(struct drm_device *drm, unsigned int size,
                 goto err_mmap;
 
         if (flags & DRM_TEGRA_GEM_CREATE_TILED)
-                bo->flags |= TEGRA_BO_TILED;
+                bo->tiling.mode = TEGRA_BO_TILING_MODE_TILED;
 
         if (flags & DRM_TEGRA_GEM_CREATE_BOTTOM_UP)
                 bo->flags |= TEGRA_BO_BOTTOM_UP;
@@ -259,8 +260,10 @@ int tegra_bo_dumb_create(struct drm_file *file, struct drm_device *drm,
                          struct drm_mode_create_dumb *args)
 {
         int min_pitch = DIV_ROUND_UP(args->width * args->bpp, 8);
+        struct tegra_drm *tegra = drm->dev_private;
         struct tegra_bo *bo;
 
+        min_pitch = round_up(min_pitch, tegra->pitch_align);
         if (args->pitch < min_pitch)
                 args->pitch = min_pitch;
 
diff --git a/drivers/gpu/drm/tegra/gem.h b/drivers/gpu/drm/tegra/gem.h
index 2f3fe96c5154..43a25c853357 100644
--- a/drivers/gpu/drm/tegra/gem.h
+++ b/drivers/gpu/drm/tegra/gem.h
@@ -16,8 +16,18 @@
 #include <drm/drm.h>
 #include <drm/drmP.h>
 
-#define TEGRA_BO_TILED     (1 << 0)
-#define TEGRA_BO_BOTTOM_UP (1 << 1)
+#define TEGRA_BO_BOTTOM_UP (1 << 0)
+
+enum tegra_bo_tiling_mode {
+        TEGRA_BO_TILING_MODE_PITCH,
+        TEGRA_BO_TILING_MODE_TILED,
+        TEGRA_BO_TILING_MODE_BLOCK,
+};
+
+struct tegra_bo_tiling {
+        enum tegra_bo_tiling_mode mode;
+        unsigned long value;
+};
 
 struct tegra_bo {
         struct drm_gem_object gem;
@@ -26,6 +36,8 @@ struct tegra_bo {
         struct sg_table *sgt;
         dma_addr_t paddr;
         void *vaddr;
+
+        struct tegra_bo_tiling tiling;
 };
 
 static inline struct tegra_bo *to_tegra_bo(struct drm_gem_object *gem)
diff --git a/drivers/gpu/drm/tegra/gr2d.c b/drivers/gpu/drm/tegra/gr2d.c
index 7c53941f2a9e..02cd3e37a6ec 100644
--- a/drivers/gpu/drm/tegra/gr2d.c
+++ b/drivers/gpu/drm/tegra/gr2d.c
@@ -121,6 +121,7 @@ static const struct of_device_id gr2d_match[] = {
         { .compatible = "nvidia,tegra20-gr2d" },
         { },
 };
+MODULE_DEVICE_TABLE(of, gr2d_match);
 
 static const u32 gr2d_addr_regs[] = {
         GR2D_UA_BASE_ADDR,
diff --git a/drivers/gpu/drm/tegra/gr3d.c b/drivers/gpu/drm/tegra/gr3d.c
index 30f5ba9bd6d0..2bea2b2d204e 100644
--- a/drivers/gpu/drm/tegra/gr3d.c
+++ b/drivers/gpu/drm/tegra/gr3d.c
@@ -130,6 +130,7 @@ static const struct of_device_id tegra_gr3d_match[] = {
         { .compatible = "nvidia,tegra20-gr3d" },
         { }
 };
+MODULE_DEVICE_TABLE(of, tegra_gr3d_match);
 
 static const u32 gr3d_addr_regs[] = {
         GR3D_IDX_ATTRIBUTE( 0),
diff --git a/drivers/gpu/drm/tegra/hdmi.c b/drivers/gpu/drm/tegra/hdmi.c
index ba067bb767e3..ffe26547328d 100644
--- a/drivers/gpu/drm/tegra/hdmi.c
+++ b/drivers/gpu/drm/tegra/hdmi.c
@@ -1450,6 +1450,7 @@ static const struct of_device_id tegra_hdmi_of_match[] = {
         { .compatible = "nvidia,tegra20-hdmi", .data = &tegra20_hdmi_config },
         { },
 };
+MODULE_DEVICE_TABLE(of, tegra_hdmi_of_match);
 
 static int tegra_hdmi_probe(struct platform_device *pdev)
 {
diff --git a/drivers/gpu/drm/tegra/output.c b/drivers/gpu/drm/tegra/output.c
index a3e4f1eca6f7..0c67d7eebc94 100644
--- a/drivers/gpu/drm/tegra/output.c
+++ b/drivers/gpu/drm/tegra/output.c
@@ -105,7 +105,7 @@ static void drm_connector_clear(struct drm_connector *connector)
 
 static void tegra_connector_destroy(struct drm_connector *connector)
 {
-        drm_sysfs_connector_remove(connector);
+        drm_connector_unregister(connector);
         drm_connector_cleanup(connector);
         drm_connector_clear(connector);
 }
@@ -140,7 +140,9 @@ static void tegra_encoder_dpms(struct drm_encoder *encoder, int mode)
         if (mode != DRM_MODE_DPMS_ON) {
                 drm_panel_disable(panel);
                 tegra_output_disable(output);
+                drm_panel_unprepare(panel);
         } else {
+                drm_panel_prepare(panel);
                 tegra_output_enable(output);
                 drm_panel_enable(panel);
         }
@@ -318,7 +320,7 @@ int tegra_output_init(struct drm_device *drm, struct tegra_output *output)
         drm_encoder_helper_add(&output->encoder, &encoder_helper_funcs);
 
         drm_mode_connector_attach_encoder(&output->connector, &output->encoder);
-        drm_sysfs_connector_add(&output->connector);
+        drm_connector_register(&output->connector);
 
         output->encoder.possible_crtcs = 0x3;
 
diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c
index 27c979b50111..0410e467b828 100644
--- a/drivers/gpu/drm/tegra/sor.c
+++ b/drivers/gpu/drm/tegra/sor.c
@@ -516,7 +516,7 @@ static int tegra_output_sor_enable(struct tegra_output *output)
                 if (err < 0) {
                         dev_err(sor->dev, "failed to probe eDP link: %d\n",
                                 err);
-                        return err;
+                        goto unlock;
                 }
         }
 
@@ -525,7 +525,7 @@ static int tegra_output_sor_enable(struct tegra_output *output)
                 dev_err(sor->dev, "failed to set safe parent clock: %d\n", err);
 
         memset(&config, 0, sizeof(config));
-        config.bits_per_pixel = 24; /* XXX: don't hardcode? */
+        config.bits_per_pixel = output->connector.display_info.bpc * 3;
 
         err = tegra_sor_calc_config(sor, mode, &config, &link);
         if (err < 0)
@@ -815,12 +815,22 @@ static int tegra_output_sor_enable(struct tegra_output *output)
          * configure panel (24bpp, vsync-, hsync-, DP-A protocol, complete
          * raster, associate with display controller)
          */
-        value = SOR_STATE_ASY_VSYNCPOL |
-                SOR_STATE_ASY_HSYNCPOL |
-                SOR_STATE_ASY_PROTOCOL_DP_A |
+        value = SOR_STATE_ASY_PROTOCOL_DP_A |
                 SOR_STATE_ASY_CRC_MODE_COMPLETE |
                 SOR_STATE_ASY_OWNER(dc->pipe + 1);
 
+        if (mode->flags & DRM_MODE_FLAG_PHSYNC)
+                value &= ~SOR_STATE_ASY_HSYNCPOL;
+
+        if (mode->flags & DRM_MODE_FLAG_NHSYNC)
+                value |= SOR_STATE_ASY_HSYNCPOL;
+
+        if (mode->flags & DRM_MODE_FLAG_PVSYNC)
+                value &= ~SOR_STATE_ASY_VSYNCPOL;
+
+        if (mode->flags & DRM_MODE_FLAG_NVSYNC)
+                value |= SOR_STATE_ASY_VSYNCPOL;
+
         switch (config.bits_per_pixel) {
         case 24:
                 value |= SOR_STATE_ASY_PIXELDEPTH_BPP_24_444;
@@ -1455,6 +1465,7 @@ static const struct of_device_id tegra_sor_of_match[] = {
         { .compatible = "nvidia,tegra124-sor", },
         { },
 };
+MODULE_DEVICE_TABLE(of, tegra_sor_of_match);
 
 struct platform_driver tegra_sor_driver = {
         .driver = {