4 files changed, 114 insertions, 89 deletions

diff --git a/drivers/firewire/Kconfig b/drivers/firewire/Kconfig
index fb4d391810b6..76f26710fc16 100644
--- a/drivers/firewire/Kconfig
+++ b/drivers/firewire/Kconfig
@@ -1,28 +1,26 @@
-comment "An alternative FireWire stack is available with EXPERIMENTAL=y"
+comment "A new alternative FireWire stack is available with EXPERIMENTAL=y"
         depends on EXPERIMENTAL=n
 
+comment "Enable only one of the two stacks, unless you know what you are doing"
+        depends on EXPERIMENTAL
+
 config FIREWIRE
-        tristate "IEEE 1394 (FireWire) support - alternative stack, EXPERIMENTAL"
+        tristate "New FireWire stack, EXPERIMENTAL"
         depends on EXPERIMENTAL
         select CRC_ITU_T
         help
           This is the "Juju" FireWire stack, a new alternative implementation
           designed for robustness and simplicity.  You can build either this
-          stack, or the classic stack (the ieee1394 driver, ohci1394 etc.)
-          or both.  Please read http://wiki.linux1394.org/JujuMigration before
-          you enable the new stack.
+          stack, or the old stack (the ieee1394 driver, ohci1394 etc.) or both.
+          Please read http://wiki.linux1394.org/JujuMigration before you
+          enable the new stack.
 
           To compile this driver as a module, say M here: the module will be
           called firewire-core.  It functionally replaces ieee1394, raw1394,
           and video1394.
 
-          NOTE:
-
-          You should only build ONE of the stacks, unless you REALLY know what
-          you are doing.
-
 config FIREWIRE_OHCI
-        tristate "Support for OHCI FireWire host controllers"
+        tristate "OHCI-1394 controllers"
         depends on PCI && FIREWIRE
         help
           Enable this driver if you have a FireWire controller based
@@ -33,12 +31,12 @@ config FIREWIRE_OHCI
           called firewire-ohci.  It replaces ohci1394 of the classic IEEE 1394
           stack.
 
-          NOTE:
+          NOTE:
 
-          You should only build ohci1394 or firewire-ohci, but not both.
-          If you nevertheless want to install both, you should configure them
-          only as modules and blacklist the driver(s) which you don't want to
-          have auto-loaded.  Add either
+          You should only build either firewire-ohci or the old ohci1394 driver,
+          but not both.  If you nevertheless want to install both, you should
+          configure them only as modules and blacklist the driver(s) which you
+          don't want to have auto-loaded.  Add either
 
               blacklist firewire-ohci
           or
@@ -60,7 +58,7 @@ config FIREWIRE_OHCI_DEBUG
         default y
 
 config FIREWIRE_SBP2
-        tristate "Support for storage devices (SBP-2 protocol driver)"
+        tristate "Storage devices (SBP-2 protocol)"
         depends on FIREWIRE && SCSI
         help
           This option enables you to use SBP-2 devices connected to a
diff --git a/drivers/firewire/fw-cdev.c b/drivers/firewire/fw-cdev.c
index dda14015e873..c639915fc3cb 100644
--- a/drivers/firewire/fw-cdev.c
+++ b/drivers/firewire/fw-cdev.c
@@ -205,6 +205,7 @@ fw_device_op_read(struct file *file,
         return dequeue_event(client, buffer, count);
 }
 
+/* caller must hold card->lock so that node pointers can be dereferenced here */
 static void
 fill_bus_reset_event(struct fw_cdev_event_bus_reset *event,
                      struct client *client)
@@ -214,7 +215,6 @@ fill_bus_reset_event(struct fw_cdev_event_bus_reset *event,
         event->closure       = client->bus_reset_closure;
         event->type          = FW_CDEV_EVENT_BUS_RESET;
         event->generation    = client->device->generation;
-        smp_rmb();           /* node_id must not be older than generation */
         event->node_id       = client->device->node_id;
         event->local_node_id = card->local_node->node_id;
         event->bm_node_id    = 0; /* FIXME: We don't track the BM. */
@@ -274,6 +274,7 @@ static int ioctl_get_info(struct client *client, void *buffer)
 {
         struct fw_cdev_get_info *get_info = buffer;
         struct fw_cdev_event_bus_reset bus_reset;
+        struct fw_card *card = client->device->card;
         unsigned long ret = 0;
 
         client->version = get_info->version;
@@ -299,13 +300,17 @@ static int ioctl_get_info(struct client *client, void *buffer)
         client->bus_reset_closure = get_info->bus_reset_closure;
         if (get_info->bus_reset != 0) {
                 void __user *uptr = u64_to_uptr(get_info->bus_reset);
+                unsigned long flags;
 
+                spin_lock_irqsave(&card->lock, flags);
                 fill_bus_reset_event(&bus_reset, client);
+                spin_unlock_irqrestore(&card->lock, flags);
+
                 if (copy_to_user(uptr, &bus_reset, sizeof(bus_reset)))
                         return -EFAULT;
         }
 
-        get_info->card = client->device->card->index;
+        get_info->card = card->index;
 
         return 0;
 }
diff --git a/drivers/firewire/fw-ohci.c b/drivers/firewire/fw-ohci.c
index 4f02c55f13e1..0b66306af479 100644
--- a/drivers/firewire/fw-ohci.c
+++ b/drivers/firewire/fw-ohci.c
@@ -265,27 +265,25 @@ static void log_irqs(u32 evt)
             !(evt & OHCI1394_busReset))
                 return;
 
-        printk(KERN_DEBUG KBUILD_MODNAME ": IRQ "
-               "%08x%s%s%s%s%s%s%s%s%s%s%s%s%s\n",
-               evt,
-               evt & OHCI1394_selfIDComplete    ? " selfID"             : "",
-               evt & OHCI1394_RQPkt             ? " AR_req"             : "",
-               evt & OHCI1394_RSPkt             ? " AR_resp"            : "",
-               evt & OHCI1394_reqTxComplete     ? " AT_req"             : "",
-               evt & OHCI1394_respTxComplete    ? " AT_resp"            : "",
-               evt & OHCI1394_isochRx           ? " IR"                 : "",
-               evt & OHCI1394_isochTx           ? " IT"                 : "",
-               evt & OHCI1394_postedWriteErr    ? " postedWriteErr"     : "",
-               evt & OHCI1394_cycleTooLong      ? " cycleTooLong"       : "",
-               evt & OHCI1394_cycle64Seconds    ? " cycle64Seconds"     : "",
-               evt & OHCI1394_regAccessFail     ? " regAccessFail"      : "",
-               evt & OHCI1394_busReset          ? " busReset"           : "",
-               evt & ~(OHCI1394_selfIDComplete | OHCI1394_RQPkt |
-                       OHCI1394_RSPkt | OHCI1394_reqTxComplete |
-                       OHCI1394_respTxComplete | OHCI1394_isochRx |
-                       OHCI1394_isochTx | OHCI1394_postedWriteErr |
-                       OHCI1394_cycleTooLong | OHCI1394_cycle64Seconds |
-                       OHCI1394_regAccessFail | OHCI1394_busReset)
+        fw_notify("IRQ %08x%s%s%s%s%s%s%s%s%s%s%s%s%s\n", evt,
+            evt & OHCI1394_selfIDComplete       ? " selfID"             : "",
+            evt & OHCI1394_RQPkt                ? " AR_req"             : "",
+            evt & OHCI1394_RSPkt                ? " AR_resp"            : "",
+            evt & OHCI1394_reqTxComplete        ? " AT_req"             : "",
+            evt & OHCI1394_respTxComplete       ? " AT_resp"            : "",
+            evt & OHCI1394_isochRx              ? " IR"                 : "",
+            evt & OHCI1394_isochTx              ? " IT"                 : "",
+            evt & OHCI1394_postedWriteErr       ? " postedWriteErr"     : "",
+            evt & OHCI1394_cycleTooLong         ? " cycleTooLong"       : "",
+            evt & OHCI1394_cycle64Seconds       ? " cycle64Seconds"     : "",
+            evt & OHCI1394_regAccessFail        ? " regAccessFail"      : "",
+            evt & OHCI1394_busReset             ? " busReset"           : "",
+            evt & ~(OHCI1394_selfIDComplete | OHCI1394_RQPkt |
+                    OHCI1394_RSPkt | OHCI1394_reqTxComplete |
+                    OHCI1394_respTxComplete | OHCI1394_isochRx |
+                    OHCI1394_isochTx | OHCI1394_postedWriteErr |
+                    OHCI1394_cycleTooLong | OHCI1394_cycle64Seconds |
+                    OHCI1394_regAccessFail | OHCI1394_busReset)
                                                 ? " ?"                  : "");
 }
 
@@ -308,23 +306,22 @@ static void log_selfids(int node_id, int generation, int self_id_count, u32 *s)
         if (likely(!(param_debug & OHCI_PARAM_DEBUG_SELFIDS)))
                 return;
 
-        printk(KERN_DEBUG KBUILD_MODNAME ": %d selfIDs, generation %d, "
-               "local node ID %04x\n", self_id_count, generation, node_id);
+        fw_notify("%d selfIDs, generation %d, local node ID %04x\n",
+                  self_id_count, generation, node_id);
 
         for (; self_id_count--; ++s)
                 if ((*s & 1 << 23) == 0)
-                        printk(KERN_DEBUG "selfID 0: %08x, phy %d [%c%c%c] "
-                               "%s gc=%d %s %s%s%s\n",
-                               *s, *s >> 24 & 63, _p(s, 6), _p(s, 4), _p(s, 2),
-                               speed[*s >> 14 & 3], *s >> 16 & 63,
-                               power[*s >> 8 & 7], *s >> 22 & 1 ? "L" : "",
-                               *s >> 11 & 1 ? "c" : "", *s & 2 ? "i" : "");
+                        fw_notify("selfID 0: %08x, phy %d [%c%c%c] "
+                            "%s gc=%d %s %s%s%s\n",
+                            *s, *s >> 24 & 63, _p(s, 6), _p(s, 4), _p(s, 2),
+                            speed[*s >> 14 & 3], *s >> 16 & 63,
+                            power[*s >> 8 & 7], *s >> 22 & 1 ? "L" : "",
+                            *s >> 11 & 1 ? "c" : "", *s & 2 ? "i" : "");
                 else
-                        printk(KERN_DEBUG "selfID n: %08x, phy %d "
-                               "[%c%c%c%c%c%c%c%c]\n",
-                               *s, *s >> 24 & 63,
-                               _p(s, 16), _p(s, 14), _p(s, 12), _p(s, 10),
-                               _p(s,  8), _p(s,  6), _p(s,  4), _p(s,  2));
+                        fw_notify("selfID n: %08x, phy %d [%c%c%c%c%c%c%c%c]\n",
+                            *s, *s >> 24 & 63,
+                            _p(s, 16), _p(s, 14), _p(s, 12), _p(s, 10),
+                            _p(s,  8), _p(s,  6), _p(s,  4), _p(s,  2));
 }
 
 static const char *evts[] = {
@@ -373,15 +370,14 @@ static void log_ar_at_event(char dir, int speed, u32 *header, int evt)
                         evt = 0x1f;
 
         if (evt == OHCI1394_evt_bus_reset) {
-                printk(KERN_DEBUG "A%c evt_bus_reset, generation %d\n",
-                       dir, (header[2] >> 16) & 0xff);
+                fw_notify("A%c evt_bus_reset, generation %d\n",
+                    dir, (header[2] >> 16) & 0xff);
                 return;
         }
 
         if (header[0] == ~header[1]) {
-                printk(KERN_DEBUG "A%c %s, %s, %08x\n",
-                       dir, evts[evt], phys[header[0] >> 30 & 0x3],
-                       header[0]);
+                fw_notify("A%c %s, %s, %08x\n",
+                    dir, evts[evt], phys[header[0] >> 30 & 0x3], header[0]);
                 return;
         }
 
@@ -400,24 +396,23 @@ static void log_ar_at_event(char dir, int speed, u32 *header, int evt)
 
         switch (tcode) {
         case 0xe: case 0xa:
-                printk(KERN_DEBUG "A%c %s, %s\n",
-                       dir, evts[evt], tcodes[tcode]);
+                fw_notify("A%c %s, %s\n", dir, evts[evt], tcodes[tcode]);
                 break;
         case 0x0: case 0x1: case 0x4: case 0x5: case 0x9:
-                printk(KERN_DEBUG "A%c spd %x tl %02x, "
-                       "%04x -> %04x, %s, "
-                       "%s, %04x%08x%s\n",
-                       dir, speed, header[0] >> 10 & 0x3f,
-                       header[1] >> 16, header[0] >> 16, evts[evt],
-                       tcodes[tcode], header[1] & 0xffff, header[2], specific);
+                fw_notify("A%c spd %x tl %02x, "
+                    "%04x -> %04x, %s, "
+                    "%s, %04x%08x%s\n",
+                    dir, speed, header[0] >> 10 & 0x3f,
+                    header[1] >> 16, header[0] >> 16, evts[evt],
+                    tcodes[tcode], header[1] & 0xffff, header[2], specific);
                 break;
         default:
-                printk(KERN_DEBUG "A%c spd %x tl %02x, "
-                       "%04x -> %04x, %s, "
-                       "%s%s\n",
-                       dir, speed, header[0] >> 10 & 0x3f,
-                       header[1] >> 16, header[0] >> 16, evts[evt],
-                       tcodes[tcode], specific);
+                fw_notify("A%c spd %x tl %02x, "
+                    "%04x -> %04x, %s, "
+                    "%s%s\n",
+                    dir, speed, header[0] >> 10 & 0x3f,
+                    header[1] >> 16, header[0] >> 16, evts[evt],
+                    tcodes[tcode], specific);
         }
 }
 
@@ -548,6 +543,11 @@ static __le32 *handle_ar_packet(struct ar_context *ctx, __le32 *buffer)
                 p.header_length = 12;
                 p.payload_length = 0;
                 break;
+
+        default:
+                /* FIXME: Stop context, discard everything, and restart? */
+                p.header_length = 0;
+                p.payload_length = 0;
         }
 
         p.payload = (void *) buffer + p.header_length;
@@ -1468,6 +1468,9 @@ static int ohci_enable(struct fw_card *card, u32 *config_rom, size_t length)
         reg_write(ohci, OHCI1394_HCControlClear,
                   OHCI1394_HCControl_noByteSwapData);
 
+        reg_write(ohci, OHCI1394_SelfIDBuffer, ohci->self_id_bus);
+        reg_write(ohci, OHCI1394_LinkControlClear,
+                  OHCI1394_LinkControl_rcvPhyPkt);
         reg_write(ohci, OHCI1394_LinkControlSet,
                   OHCI1394_LinkControl_rcvSelfID |
                   OHCI1394_LinkControl_cycleTimerEnable |
@@ -1481,7 +1484,6 @@ static int ohci_enable(struct fw_card *card, u32 *config_rom, size_t length)
         ar_context_run(&ohci->ar_request_ctx);
         ar_context_run(&ohci->ar_response_ctx);
 
-        reg_write(ohci, OHCI1394_SelfIDBuffer, ohci->self_id_bus);
         reg_write(ohci, OHCI1394_PhyUpperBound, 0x00010000);
         reg_write(ohci, OHCI1394_IntEventClear, ~0);
         reg_write(ohci, OHCI1394_IntMaskClear, ~0);
diff --git a/drivers/firewire/fw-transaction.c b/drivers/firewire/fw-transaction.c
index ccf0e4cf108f..03ae8a77c479 100644
--- a/drivers/firewire/fw-transaction.c
+++ b/drivers/firewire/fw-transaction.c
@@ -20,6 +20,7 @@
 
 #include <linux/completion.h>
 #include <linux/kernel.h>
+#include <linux/kref.h>
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/interrupt.h>
@@ -297,37 +298,55 @@ EXPORT_SYMBOL(fw_send_request);
 struct fw_phy_packet {
         struct fw_packet packet;
         struct completion done;
+        struct kref kref;
 };
 
-static void
-transmit_phy_packet_callback(struct fw_packet *packet,
-                             struct fw_card *card, int status)
+static void phy_packet_release(struct kref *kref)
+{
+        struct fw_phy_packet *p =
+                        container_of(kref, struct fw_phy_packet, kref);
+        kfree(p);
+}
+
+static void transmit_phy_packet_callback(struct fw_packet *packet,
+                                         struct fw_card *card, int status)
 {
         struct fw_phy_packet *p =
                         container_of(packet, struct fw_phy_packet, packet);
 
         complete(&p->done);
+        kref_put(&p->kref, phy_packet_release);
 }
 
 void fw_send_phy_config(struct fw_card *card,
                         int node_id, int generation, int gap_count)
 {
-        struct fw_phy_packet p;
+        struct fw_phy_packet *p;
+        long timeout = DIV_ROUND_UP(HZ, 10);
         u32 data = PHY_IDENTIFIER(PHY_PACKET_CONFIG) |
                    PHY_CONFIG_ROOT_ID(node_id) |
                    PHY_CONFIG_GAP_COUNT(gap_count);
 
-        p.packet.header[0] = data;
-        p.packet.header[1] = ~data;
-        p.packet.header_length = 8;
-        p.packet.payload_length = 0;
-        p.packet.speed = SCODE_100;
-        p.packet.generation = generation;
-        p.packet.callback = transmit_phy_packet_callback;
-        init_completion(&p.done);
-
-        card->driver->send_request(card, &p.packet);
-        wait_for_completion(&p.done);
+        p = kmalloc(sizeof(*p), GFP_KERNEL);
+        if (p == NULL)
+                return;
+
+        p->packet.header[0] = data;
+        p->packet.header[1] = ~data;
+        p->packet.header_length = 8;
+        p->packet.payload_length = 0;
+        p->packet.speed = SCODE_100;
+        p->packet.generation = generation;
+        p->packet.callback = transmit_phy_packet_callback;
+        init_completion(&p->done);
+        kref_set(&p->kref, 2);
+
+        card->driver->send_request(card, &p->packet);
+        timeout = wait_for_completion_timeout(&p->done, timeout);
+        kref_put(&p->kref, phy_packet_release);
+
+        /* will leak p if the callback is never executed */
+        WARN_ON(timeout == 0);
 }
 
 void fw_flush_transactions(struct fw_card *card)
@@ -572,7 +591,8 @@ allocate_request(struct fw_packet *p)
                 break;
 
         default:
-                BUG();
+                fw_error("ERROR - corrupt request received - %08x %08x %08x\n",
+                         p->header[0], p->header[1], p->header[2]);
                 return NULL;
         }