90 files changed, 4674 insertions, 3212 deletions

diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
index 78d928f9d9f1..c40e487d9f5c 100644
--- a/drivers/char/Kconfig
+++ b/drivers/char/Kconfig
@@ -62,6 +62,23 @@ config HW_CONSOLE
         depends on VT && !S390 && !UML
         default y
 
+config VT_HW_CONSOLE_BINDING
+       bool "Support for binding and unbinding console drivers"
+       depends on HW_CONSOLE
+       default n
+       ---help---
+         The virtual terminal is the device that interacts with the physical
+         terminal through console drivers. On these systems, at least one
+         console driver is loaded. In other configurations, additional console
+         drivers may be enabled, such as the framebuffer console. If more than
+         1 console driver is enabled, setting this to 'y' will allow you to
+         select the console driver that will serve as the backend for the
+         virtual terminals.
+
+         See <file:Documentation/console/console.txt> for more
+         information. For framebuffer console users, please refer to
+         <file:Documentation/fb/fbcon.txt>.
+
 config SERIAL_NONSTANDARD
         bool "Non-standard serial port support"
         ---help---
@@ -670,20 +687,7 @@ config NWFLASH
 
           If you're not sure, say N.
 
-config HW_RANDOM
-        tristate "Intel/AMD/VIA HW Random Number Generator support"
-        depends on (X86 || IA64) && PCI
-        ---help---
-          This driver provides kernel-side support for the Random Number
-          Generator hardware found on Intel i8xx-based motherboards,
-          AMD 76x-based motherboards, and Via Nehemiah CPUs.
-
-          Provides a character driver, used to read() entropy data.
-
-          To compile this driver as a module, choose M here: the
-          module will be called hw_random.
-
-          If unsure, say N.
+source "drivers/char/hw_random/Kconfig"
 
 config NVRAM
         tristate "/dev/nvram support"
@@ -865,6 +869,7 @@ config SONYPI
 config TANBAC_TB0219
         tristate "TANBAC TB0219 base board support"
         depends TANBAC_TB022X
+        select GPIO_VR41XX
 
 menu "Ftape, the floppy tape device driver"
 
@@ -934,12 +939,36 @@ config MWAVE
 config SCx200_GPIO
         tristate "NatSemi SCx200 GPIO Support"
         depends on SCx200
+        select NSC_GPIO
         help
           Give userspace access to the GPIO pins on the National
           Semiconductor SCx200 processors.
 
           If compiled as a module, it will be called scx200_gpio.
 
+config PC8736x_GPIO
+        tristate "NatSemi PC8736x GPIO Support"
+        depends on X86
+        default SCx200_GPIO     # mostly N
+        select NSC_GPIO         # needed for support routines
+        help
+          Give userspace access to the GPIO pins on the National
+          Semiconductor PC-8736x (x=[03456]) SuperIO chip.  The chip
+          has multiple functional units, inc several managed by
+          hwmon/pc87360 driver.  Tested with PC-87366
+
+          If compiled as a module, it will be called pc8736x_gpio.
+
+config NSC_GPIO
+        tristate "NatSemi Base GPIO Support"
+        depends on X86_32
+        # selected by SCx200_GPIO and PC8736x_GPIO
+        # what about 2 selectors differing: m != y
+        help
+          Common support used (and needed) by scx200_gpio and
+          pc8736x_gpio drivers.  If those drivers are built as
+          modules, this one will be too, named nsc_gpio
+
 config CS5535_GPIO
         tristate "AMD CS5535/CS5536 GPIO (Geode Companion Device)"
         depends on X86_32
diff --git a/drivers/char/Makefile b/drivers/char/Makefile
index fb919bfb2824..6e0f4469d8bb 100644
--- a/drivers/char/Makefile
+++ b/drivers/char/Makefile
@@ -75,13 +75,15 @@ endif
 obj-$(CONFIG_TOSHIBA)           += toshiba.o
 obj-$(CONFIG_I8K)               += i8k.o
 obj-$(CONFIG_DS1620)            += ds1620.o
-obj-$(CONFIG_HW_RANDOM)         += hw_random.o
+obj-$(CONFIG_HW_RANDOM)         += hw_random/
 obj-$(CONFIG_FTAPE)             += ftape/
 obj-$(CONFIG_COBALT_LCD)        += lcd.o
 obj-$(CONFIG_PPDEV)             += ppdev.o
 obj-$(CONFIG_NWBUTTON)          += nwbutton.o
 obj-$(CONFIG_NWFLASH)           += nwflash.o
 obj-$(CONFIG_SCx200_GPIO)       += scx200_gpio.o
+obj-$(CONFIG_PC8736x_GPIO)      += pc8736x_gpio.o
+obj-$(CONFIG_NSC_GPIO)          += nsc_gpio.o
 obj-$(CONFIG_CS5535_GPIO)       += cs5535_gpio.o
 obj-$(CONFIG_GPIO_VR41XX)       += vr41xx_giu.o
 obj-$(CONFIG_TANBAC_TB0219)     += tb0219.o
diff --git a/drivers/char/agp/Kconfig b/drivers/char/agp/Kconfig
index 3dbbb9544ae8..22f8cf218cc6 100644
--- a/drivers/char/agp/Kconfig
+++ b/drivers/char/agp/Kconfig
@@ -1,8 +1,7 @@
 config AGP
-        tristate "/dev/agpgart (AGP Support)" if !GART_IOMMU
+        tristate "/dev/agpgart (AGP Support)"
         depends on ALPHA || IA64 || PPC || X86
         depends on PCI
-        default y if GART_IOMMU
         ---help---
           AGP (Accelerated Graphics Port) is a bus system mainly used to
           connect graphics cards to the rest of the system.
@@ -57,9 +56,9 @@ config AGP_AMD
           X on AMD Irongate, 761, and 762 chipsets.
 
 config AGP_AMD64
-        tristate "AMD Opteron/Athlon64 on-CPU GART support" if !GART_IOMMU
+        tristate "AMD Opteron/Athlon64 on-CPU GART support" if !IOMMU
         depends on AGP && X86
-        default y if GART_IOMMU
+        default y if IOMMU
         help
           This option gives you AGP support for the GLX component of
           X using the on-CPU northbridge of the AMD Athlon64/Opteron CPUs.
diff --git a/drivers/char/agp/amd-k7-agp.c b/drivers/char/agp/amd-k7-agp.c
index 1f776651ac64..51d0d562d01e 100644
--- a/drivers/char/agp/amd-k7-agp.c
+++ b/drivers/char/agp/amd-k7-agp.c
@@ -118,7 +118,7 @@ static int amd_create_gatt_pages(int nr_tables)
         return retval;
 }
 
-/* Since we don't need contigious memory we just try
+/* Since we don't need contiguous memory we just try
  * to get the gatt table once
  */
 
diff --git a/drivers/char/agp/amd64-agp.c b/drivers/char/agp/amd64-agp.c
index e449d949f7ea..f74eeeb8e377 100644
--- a/drivers/char/agp/amd64-agp.c
+++ b/drivers/char/agp/amd64-agp.c
@@ -15,11 +15,9 @@
 #include <linux/agp_backend.h>
 #include <linux/mmzone.h>
 #include <asm/page.h>           /* PAGE_SIZE */
+#include <asm/k8.h>
 #include "agp.h"
 
-/* Will need to be increased if AMD64 ever goes >8-way. */
-#define MAX_HAMMER_GARTS   8
-
 /* PTE bits. */
 #define GPTE_VALID      1
 #define GPTE_COHERENT   2
@@ -53,28 +51,12 @@
 #define ULI_X86_64_HTT_FEA_REG          0x50
 #define ULI_X86_64_ENU_SCR_REG          0x54
 
-static int nr_garts;
-static struct pci_dev * hammers[MAX_HAMMER_GARTS];
-
 static struct resource *aperture_resource;
 static int __initdata agp_try_unsupported = 1;
 
-#define for_each_nb() for(gart_iterator=0;gart_iterator<nr_garts;gart_iterator++)
-
-static void flush_amd64_tlb(struct pci_dev *dev)
-{
-        u32 tmp;
-
-        pci_read_config_dword (dev, AMD64_GARTCACHECTL, &tmp);
-        tmp |= INVGART;
-        pci_write_config_dword (dev, AMD64_GARTCACHECTL, tmp);
-}
-
 static void amd64_tlbflush(struct agp_memory *temp)
 {
-        int gart_iterator;
-        for_each_nb()
-                flush_amd64_tlb(hammers[gart_iterator]);
+        k8_flush_garts();
 }
 
 static int amd64_insert_memory(struct agp_memory *mem, off_t pg_start, int type)
@@ -153,7 +135,7 @@ static int amd64_fetch_size(void)
         u32 temp;
         struct aper_size_info_32 *values;
 
-        dev = hammers[0];
+        dev = k8_northbridges[0];
         if (dev==NULL)
                 return 0;
 
@@ -201,9 +183,6 @@ static u64 amd64_configure (struct pci_dev *hammer, u64 gatt_table)
         tmp &= ~(DISGARTCPU | DISGARTIO);
         pci_write_config_dword(hammer, AMD64_GARTAPERTURECTL, tmp);
 
-        /* keep CPU's coherent. */
-        flush_amd64_tlb (hammer);
-
         return aper_base;
 }
 
@@ -222,13 +201,14 @@ static struct aper_size_info_32 amd_8151_sizes[7] =
 static int amd_8151_configure(void)
 {
         unsigned long gatt_bus = virt_to_gart(agp_bridge->gatt_table_real);
-        int gart_iterator;
+        int i;
 
         /* Configure AGP regs in each x86-64 host bridge. */
-        for_each_nb() {
+        for (i = 0; i < num_k8_northbridges; i++) {
                 agp_bridge->gart_bus_addr =
-                                amd64_configure(hammers[gart_iterator],gatt_bus);
+                                amd64_configure(k8_northbridges[i], gatt_bus);
         }
+        k8_flush_garts();
         return 0;
 }
 
@@ -236,12 +216,13 @@ static int amd_8151_configure(void)
 static void amd64_cleanup(void)
 {
         u32 tmp;
-        int gart_iterator;
-        for_each_nb() {
+        int i;
+        for (i = 0; i < num_k8_northbridges; i++) {
+                struct pci_dev *dev = k8_northbridges[i];
                 /* disable gart translation */
-                pci_read_config_dword (hammers[gart_iterator], AMD64_GARTAPERTURECTL, &tmp);
+                pci_read_config_dword (dev, AMD64_GARTAPERTURECTL, &tmp);
                 tmp &= ~AMD64_GARTEN;
-                pci_write_config_dword (hammers[gart_iterator], AMD64_GARTAPERTURECTL, tmp);
+                pci_write_config_dword (dev, AMD64_GARTAPERTURECTL, tmp);
         }
 }
 
@@ -311,7 +292,7 @@ static int __devinit aperture_valid(u64 aper, u32 size)
 /*
  * W*s centric BIOS sometimes only set up the aperture in the AGP
  * bridge, not the northbridge. On AMD64 this is handled early
- * in aperture.c, but when GART_IOMMU is not enabled or we run
+ * in aperture.c, but when IOMMU is not enabled or we run
  * on a 32bit kernel this needs to be redone.
  * Unfortunately it is impossible to fix the aperture here because it's too late
  * to allocate that much memory. But at least error out cleanly instead of
@@ -361,17 +342,15 @@ static __devinit int fix_northbridge(struct pci_dev *nb, struct pci_dev *agp,
 
 static __devinit int cache_nbs (struct pci_dev *pdev, u32 cap_ptr)
 {
-        struct pci_dev *loop_dev = NULL;
-        int i = 0;
-
-        /* cache pci_devs of northbridges. */
-        while ((loop_dev = pci_get_device(PCI_VENDOR_ID_AMD, 0x1103, loop_dev))
-                        != NULL) {
-                if (i == MAX_HAMMER_GARTS) {
-                        printk(KERN_ERR PFX "Too many northbridges for AGP\n");
-                        return -1;
-                }
-                if (fix_northbridge(loop_dev, pdev, cap_ptr) < 0) {
+        int i;
+
+        if (cache_k8_northbridges() < 0)
+                return -ENODEV;
+
+        i = 0;
+        for (i = 0; i < num_k8_northbridges; i++) {
+                struct pci_dev *dev = k8_northbridges[i];
+                if (fix_northbridge(dev, pdev, cap_ptr) < 0) {
                         printk(KERN_ERR PFX "No usable aperture found.\n");
 #ifdef __x86_64__
                         /* should port this to i386 */
@@ -379,10 +358,8 @@ static __devinit int cache_nbs (struct pci_dev *pdev, u32 cap_ptr)
 #endif
                         return -1;
                 }
-                hammers[i++] = loop_dev;
         }
-                nr_garts = i;
-        return i == 0 ? -1 : 0;
+        return 0;
 }
 
 /* Handle AMD 8151 quirks */
@@ -450,7 +427,7 @@ static int __devinit uli_agp_init(struct pci_dev *pdev)
         }
 
         /* shadow x86-64 registers into ULi registers */
-        pci_read_config_dword (hammers[0], AMD64_GARTAPERTUREBASE, &httfea);
+        pci_read_config_dword (k8_northbridges[0], AMD64_GARTAPERTUREBASE, &httfea);
 
         /* if x86-64 aperture base is beyond 4G, exit here */
         if ((httfea & 0x7fff) >> (32 - 25))
@@ -513,7 +490,7 @@ static int __devinit nforce3_agp_init(struct pci_dev *pdev)
         pci_write_config_dword(dev1, NVIDIA_X86_64_1_APSIZE, tmp);
 
         /* shadow x86-64 registers into NVIDIA registers */
-        pci_read_config_dword (hammers[0], AMD64_GARTAPERTUREBASE, &apbase);
+        pci_read_config_dword (k8_northbridges[0], AMD64_GARTAPERTUREBASE, &apbase);
 
         /* if x86-64 aperture base is beyond 4G, exit here */
         if ( (apbase & 0x7fff) >> (32 - 25) ) {
@@ -754,10 +731,6 @@ static struct pci_driver agp_amd64_pci_driver = {
 int __init agp_amd64_init(void)
 {
         int err = 0;
-        static struct pci_device_id amd64nb[] = {
-                { PCI_DEVICE(PCI_VENDOR_ID_AMD, 0x1103) },
-                { },
-        };
 
         if (agp_off)
                 return -EINVAL;
@@ -774,7 +747,7 @@ int __init agp_amd64_init(void)
                 }
 
                 /* First check that we have at least one AMD64 NB */
-                if (!pci_dev_present(amd64nb))
+                if (!pci_dev_present(k8_nb_ids))
                         return -ENODEV;
 
                 /* Look for any AGP bridge */
@@ -802,7 +775,7 @@ static void __exit agp_amd64_cleanup(void)
 
 /* On AMD64 the PCI driver needs to initialize this driver early
    for the IOMMU, so it has to be called via a backdoor. */
-#ifndef CONFIG_GART_IOMMU
+#ifndef CONFIG_IOMMU
 module_init(agp_amd64_init);
 module_exit(agp_amd64_cleanup);
 #endif
diff --git a/drivers/char/agp/ati-agp.c b/drivers/char/agp/ati-agp.c
index d712078ed822..f244c6682738 100644
--- a/drivers/char/agp/ati-agp.c
+++ b/drivers/char/agp/ati-agp.c
@@ -263,7 +263,7 @@ static int agp_ati_resume(struct pci_dev *dev)
 #endif
 
 /*
- *Since we don't need contigious memory we just try
+ *Since we don't need contiguous memory we just try
  * to get the gatt table once
  */
 
diff --git a/drivers/char/agp/efficeon-agp.c b/drivers/char/agp/efficeon-agp.c
index 86a966b65236..b788b0a3bbf3 100644
--- a/drivers/char/agp/efficeon-agp.c
+++ b/drivers/char/agp/efficeon-agp.c
@@ -177,7 +177,7 @@ static int efficeon_free_gatt_table(struct agp_bridge_data *bridge)
 
 
 /*
- * Since we don't need contigious memory we just try
+ * Since we don't need contiguous memory we just try
  * to get the gatt table once
  */
 
diff --git a/drivers/char/agp/hp-agp.c b/drivers/char/agp/hp-agp.c
index 8c4c6ef748ec..907fb66ec4a9 100644
--- a/drivers/char/agp/hp-agp.c
+++ b/drivers/char/agp/hp-agp.c
@@ -497,7 +497,7 @@ zx1_gart_probe (acpi_handle obj, u32 depth, void *context, void **ret)
                         info = buffer.pointer;
                         info->hardware_id.value[sizeof(info->hardware_id)-1] = '\0';
                         match = (strcmp(info->hardware_id.value, "HWP0001") == 0);
-                        ACPI_MEM_FREE(info);
+                        kfree(info);
                         if (match) {
                                 status = hp_acpi_csr_space(handle, &sba_hpa, &length);
                                 if (ACPI_SUCCESS(status))
diff --git a/drivers/char/agp/sgi-agp.c b/drivers/char/agp/sgi-agp.c
index cfa7922cb431..d73be4c2db8a 100644
--- a/drivers/char/agp/sgi-agp.c
+++ b/drivers/char/agp/sgi-agp.c
@@ -329,9 +329,8 @@ static int __devinit agp_sgi_init(void)
 
 static void __devexit agp_sgi_cleanup(void)
 {
-        if (sgi_tioca_agp_bridges)
-                kfree(sgi_tioca_agp_bridges);
-        sgi_tioca_agp_bridges=NULL;
+        kfree(sgi_tioca_agp_bridges);
+        sgi_tioca_agp_bridges = NULL;
 }
 
 module_init(agp_sgi_init);
diff --git a/drivers/char/applicom.c b/drivers/char/applicom.c
index a370e7a0bad5..72fb60765c45 100644
--- a/drivers/char/applicom.c
+++ b/drivers/char/applicom.c
@@ -166,11 +166,7 @@ static int ac_register_board(unsigned long physloc, void __iomem *loc,
         return boardno + 1;
 }
 
-#ifdef MODULE
-
-#define applicom_init init_module
-
-void cleanup_module(void)
+static void __exit applicom_exit(void)
 {
         unsigned int i;
 
@@ -188,9 +184,7 @@ void cleanup_module(void)
         }
 }
 
-#endif                          /* MODULE */
-
-int __init applicom_init(void)
+static int __init applicom_init(void)
 {
         int i, numisa = 0;
         struct pci_dev *dev = NULL;
@@ -215,13 +209,16 @@ int __init applicom_init(void)
                 RamIO = ioremap(dev->resource[0].start, LEN_RAM_IO);
 
                 if (!RamIO) {
-                        printk(KERN_INFO "ac.o: Failed to ioremap PCI memory space at 0x%lx\n", dev->resource[0].start);
+                        printk(KERN_INFO "ac.o: Failed to ioremap PCI memory "
+                                "space at 0x%llx\n",
+                                (unsigned long long)dev->resource[0].start);
                         pci_disable_device(dev);
                         return -EIO;
                 }
 
-                printk(KERN_INFO "Applicom %s found at mem 0x%lx, irq %d\n",
-                       applicom_pci_devnames[dev->device-1], dev->resource[0].start, 
+                printk(KERN_INFO "Applicom %s found at mem 0x%llx, irq %d\n",
+                       applicom_pci_devnames[dev->device-1],
+                           (unsigned long long)dev->resource[0].start,
                        dev->irq);
 
                 boardno = ac_register_board(dev->resource[0].start, RamIO,0);
@@ -355,10 +352,9 @@ out:
         return ret;
 }
 
+module_init(applicom_init);
+module_exit(applicom_exit);
 
-#ifndef MODULE
-__initcall(applicom_init);
-#endif
 
 static ssize_t ac_write(struct file *file, const char __user *buf, size_t count, loff_t * ppos)
 {
@@ -851,28 +847,3 @@ static int ac_ioctl(struct inode *inode, struct file *file, unsigned int cmd, un
         return 0;
 }
 
-#ifndef MODULE
-static int __init applicom_setup(char *str)
-{
-        int ints[4];
-
-        (void) get_options(str, 4, ints);
-
-        if (ints[0] > 2) {
-                printk(KERN_WARNING "Too many arguments to 'applicom=', expected mem,irq only.\n");
-        }
-
-        if (ints[0] < 2) {
-                printk(KERN_INFO"applicom numargs: %d\n", ints[0]);
-                return 0;
-        }
-
-        mem = ints[1];
-        irq = ints[2];
-        return 1;
-}
-
-__setup("applicom=", applicom_setup);
-
-#endif                          /* MODULE */
-
diff --git a/drivers/char/cyclades.c b/drivers/char/cyclades.c
index cc7acf877dc0..122e7a72a4e1 100644
--- a/drivers/char/cyclades.c
+++ b/drivers/char/cyclades.c
@@ -2833,9 +2833,8 @@ cy_write(struct tty_struct * tty, const unsigned char *buf, int count)
         return 0;
     }
         
-    if (!tty || !info->xmit_buf || !tmp_buf){
-        return 0;
-    }
+    if (!info->xmit_buf || !tmp_buf)
+        return 0;
 
     CY_LOCK(info, flags);
     while (1) {
@@ -2884,7 +2883,7 @@ cy_put_char(struct tty_struct *tty, unsigned char ch)
     if (serial_paranoia_check(info, tty->name, "cy_put_char"))
         return;
 
-    if (!tty || !info->xmit_buf)
+    if (!info->xmit_buf)
         return;
 
     CY_LOCK(info, flags);
diff --git a/drivers/char/drm/drm_memory_debug.h b/drivers/char/drm/drm_memory_debug.h
index 6543b9a14c42..d117cc997192 100644
--- a/drivers/char/drm/drm_memory_debug.h
+++ b/drivers/char/drm/drm_memory_debug.h
@@ -43,7 +43,7 @@ typedef struct drm_mem_stats {
         unsigned long bytes_freed;
 } drm_mem_stats_t;
 
-static spinlock_t drm_mem_lock = SPIN_LOCK_UNLOCKED;
+static DEFINE_SPINLOCK(drm_mem_lock);
 static unsigned long drm_ram_available = 0;     /* In pages */
 static unsigned long drm_ram_used = 0;
 static drm_mem_stats_t drm_mem_stats[] =
diff --git a/drivers/char/drm/i915_dma.c b/drivers/char/drm/i915_dma.c
index 9f4b8ce4c05e..a94233bdbc0e 100644
--- a/drivers/char/drm/i915_dma.c
+++ b/drivers/char/drm/i915_dma.c
@@ -758,7 +758,9 @@ drm_ioctl_desc_t i915_ioctls[] = {
         [DRM_IOCTL_NR(DRM_I915_FREE)] = {i915_mem_free, DRM_AUTH},
         [DRM_IOCTL_NR(DRM_I915_INIT_HEAP)] = {i915_mem_init_heap, DRM_AUTH|DRM_MASTER|DRM_ROOT_ONLY},
         [DRM_IOCTL_NR(DRM_I915_CMDBUFFER)] = {i915_cmdbuffer, DRM_AUTH},
-        [DRM_IOCTL_NR(DRM_I915_DESTROY_HEAP)] = { i915_mem_destroy_heap, DRM_AUTH|DRM_MASTER|DRM_ROOT_ONLY }
+        [DRM_IOCTL_NR(DRM_I915_DESTROY_HEAP)] = { i915_mem_destroy_heap, DRM_AUTH|DRM_MASTER|DRM_ROOT_ONLY },
+        [DRM_IOCTL_NR(DRM_I915_SET_VBLANK_PIPE)] = { i915_vblank_pipe_set, DRM_AUTH|DRM_MASTER|DRM_ROOT_ONLY },
+        [DRM_IOCTL_NR(DRM_I915_GET_VBLANK_PIPE)] = { i915_vblank_pipe_get, DRM_AUTH },
 };
 
 int i915_max_ioctl = DRM_ARRAY_SIZE(i915_ioctls);
diff --git a/drivers/char/drm/i915_drm.h b/drivers/char/drm/i915_drm.h
index 4cb3da578330..5aa3e0e3bb45 100644
--- a/drivers/char/drm/i915_drm.h
+++ b/drivers/char/drm/i915_drm.h
@@ -124,6 +124,8 @@ typedef struct _drm_i915_sarea {
 #define DRM_I915_INIT_HEAP      0x0a
 #define DRM_I915_CMDBUFFER      0x0b
 #define DRM_I915_DESTROY_HEAP   0x0c
+#define DRM_I915_SET_VBLANK_PIPE        0x0d
+#define DRM_I915_GET_VBLANK_PIPE        0x0e
 
 #define DRM_IOCTL_I915_INIT             DRM_IOW( DRM_COMMAND_BASE + DRM_I915_INIT, drm_i915_init_t)
 #define DRM_IOCTL_I915_FLUSH            DRM_IO ( DRM_COMMAND_BASE + DRM_I915_FLUSH)
@@ -138,6 +140,8 @@ typedef struct _drm_i915_sarea {
 #define DRM_IOCTL_I915_INIT_HEAP        DRM_IOW( DRM_COMMAND_BASE + DRM_I915_INIT_HEAP, drm_i915_mem_init_heap_t)
 #define DRM_IOCTL_I915_CMDBUFFER        DRM_IOW( DRM_COMMAND_BASE + DRM_I915_CMDBUFFER, drm_i915_cmdbuffer_t)
 #define DRM_IOCTL_I915_DESTROY_HEAP     DRM_IOW( DRM_COMMAND_BASE + DRM_I915_DESTROY_HEAP, drm_i915_mem_destroy_heap_t)
+#define DRM_IOCTL_I915_SET_VBLANK_PIPE  DRM_IOW( DRM_COMMAND_BASE + DRM_I915_SET_VBLANK_PIPE, drm_i915_vblank_pipe_t)
+#define DRM_IOCTL_I915_GET_VBLANK_PIPE  DRM_IOR( DRM_COMMAND_BASE + DRM_I915_GET_VBLANK_PIPE, drm_i915_vblank_pipe_t)
 
 /* Allow drivers to submit batchbuffers directly to hardware, relying
  * on the security mechanisms provided by hardware.
@@ -224,4 +228,13 @@ typedef struct drm_i915_mem_destroy_heap {
         int region;
 } drm_i915_mem_destroy_heap_t;
 
+/* Allow X server to configure which pipes to monitor for vblank signals
+ */
+#define DRM_I915_VBLANK_PIPE_A  1
+#define DRM_I915_VBLANK_PIPE_B  2
+
+typedef struct drm_i915_vblank_pipe {
+        int pipe;
+} drm_i915_vblank_pipe_t;
+
 #endif                          /* _I915_DRM_H_ */
diff --git a/drivers/char/drm/i915_drv.h b/drivers/char/drm/i915_drv.h
index 7a65666899e4..2d565031c002 100644
--- a/drivers/char/drm/i915_drv.h
+++ b/drivers/char/drm/i915_drv.h
@@ -45,9 +45,10 @@
  * 1.2: Add Power Management
  * 1.3: Add vblank support
  * 1.4: Fix cmdbuffer path, add heap destroy
+ * 1.5: Add vblank pipe configuration
  */
 #define DRIVER_MAJOR            1
-#define DRIVER_MINOR            4
+#define DRIVER_MINOR            5
 #define DRIVER_PATCHLEVEL       0
 
 typedef struct _drm_i915_ring_buffer {
@@ -96,6 +97,7 @@ typedef struct drm_i915_private {
         int allow_batchbuffer;
         struct mem_block *agp_heap;
         unsigned int sr01, adpa, ppcr, dvob, dvoc, lvds;
+        int vblank_pipe;
 } drm_i915_private_t;
 
 extern drm_ioctl_desc_t i915_ioctls[];
@@ -119,6 +121,8 @@ extern irqreturn_t i915_driver_irq_handler(DRM_IRQ_ARGS);
 extern void i915_driver_irq_preinstall(drm_device_t * dev);
 extern void i915_driver_irq_postinstall(drm_device_t * dev);
 extern void i915_driver_irq_uninstall(drm_device_t * dev);
+extern int i915_vblank_pipe_set(DRM_IOCTL_ARGS);
+extern int i915_vblank_pipe_get(DRM_IOCTL_ARGS);
 
 /* i915_mem.c */
 extern int i915_mem_alloc(DRM_IOCTL_ARGS);
diff --git a/drivers/char/drm/i915_irq.c b/drivers/char/drm/i915_irq.c
index a752afd86ab8..cd96cfa430db 100644
--- a/drivers/char/drm/i915_irq.c
+++ b/drivers/char/drm/i915_irq.c
@@ -44,7 +44,8 @@ irqreturn_t i915_driver_irq_handler(DRM_IRQ_ARGS)
         u16 temp;
 
         temp = I915_READ16(I915REG_INT_IDENTITY_R);
-        temp &= (USER_INT_FLAG | VSYNC_PIPEA_FLAG);
+
+        temp &= (USER_INT_FLAG | VSYNC_PIPEA_FLAG | VSYNC_PIPEB_FLAG);
 
         DRM_DEBUG("%s flag=%08x\n", __FUNCTION__, temp);
 
@@ -58,7 +59,7 @@ irqreturn_t i915_driver_irq_handler(DRM_IRQ_ARGS)
         if (temp & USER_INT_FLAG)
                 DRM_WAKEUP(&dev_priv->irq_queue);
 
-        if (temp & VSYNC_PIPEA_FLAG) {
+        if (temp & (VSYNC_PIPEA_FLAG | VSYNC_PIPEB_FLAG)) {
                 atomic_inc(&dev->vbl_received);
                 DRM_WAKEUP(&dev->vbl_queue);
                 drm_vbl_send_signals(dev);
@@ -182,6 +183,68 @@ int i915_irq_wait(DRM_IOCTL_ARGS)
         return i915_wait_irq(dev, irqwait.irq_seq);
 }
 
+static int i915_enable_interrupt (drm_device_t *dev)
+{
+        drm_i915_private_t *dev_priv = (drm_i915_private_t *) dev->dev_private;
+        u16 flag;
+
+        flag = 0;
+        if (dev_priv->vblank_pipe & DRM_I915_VBLANK_PIPE_A)
+                flag |= VSYNC_PIPEA_FLAG;
+        if (dev_priv->vblank_pipe & DRM_I915_VBLANK_PIPE_B)
+                flag |= VSYNC_PIPEB_FLAG;
+        if (dev_priv->vblank_pipe & ~(DRM_I915_VBLANK_PIPE_A|DRM_I915_VBLANK_PIPE_B)) {
+                DRM_ERROR("%s called with invalid pipe 0x%x\n",
+                          __FUNCTION__, dev_priv->vblank_pipe);
+                return DRM_ERR(EINVAL);
+        }
+        I915_WRITE16(I915REG_INT_ENABLE_R, USER_INT_FLAG | flag);
+        return 0;
+}
+
+/* Set the vblank monitor pipe
+ */
+int i915_vblank_pipe_set(DRM_IOCTL_ARGS)
+{
+        DRM_DEVICE;
+        drm_i915_private_t *dev_priv = dev->dev_private;
+        drm_i915_vblank_pipe_t pipe;
+
+        if (!dev_priv) {
+                DRM_ERROR("%s called with no initialization\n", __FUNCTION__);
+                return DRM_ERR(EINVAL);
+        }
+
+        DRM_COPY_FROM_USER_IOCTL(pipe, (drm_i915_vblank_pipe_t __user *) data,
+                                 sizeof(pipe));
+
+        dev_priv->vblank_pipe = pipe.pipe;
+        return i915_enable_interrupt (dev);
+}
+
+int i915_vblank_pipe_get(DRM_IOCTL_ARGS)
+{
+        DRM_DEVICE;
+        drm_i915_private_t *dev_priv = dev->dev_private;
+        drm_i915_vblank_pipe_t pipe;
+        u16 flag;
+
+        if (!dev_priv) {
+                DRM_ERROR("%s called with no initialization\n", __FUNCTION__);
+                return DRM_ERR(EINVAL);
+        }
+
+        flag = I915_READ(I915REG_INT_ENABLE_R);
+        pipe.pipe = 0;
+        if (flag & VSYNC_PIPEA_FLAG)
+                pipe.pipe |= DRM_I915_VBLANK_PIPE_A;
+        if (flag & VSYNC_PIPEB_FLAG)
+                pipe.pipe |= DRM_I915_VBLANK_PIPE_B;
+        DRM_COPY_TO_USER_IOCTL((drm_i915_vblank_pipe_t __user *) data, pipe,
+                                 sizeof(pipe));
+        return 0;
+}
+
 /* drm_dma.h hooks
 */
 void i915_driver_irq_preinstall(drm_device_t * dev)
@@ -197,7 +260,7 @@ void i915_driver_irq_postinstall(drm_device_t * dev)
 {
         drm_i915_private_t *dev_priv = (drm_i915_private_t *) dev->dev_private;
 
-        I915_WRITE16(I915REG_INT_ENABLE_R, USER_INT_FLAG | VSYNC_PIPEA_FLAG);
+        i915_enable_interrupt(dev);
         DRM_INIT_WAITQUEUE(&dev_priv->irq_queue);
 }
 
diff --git a/drivers/char/drm/radeon_cp.c b/drivers/char/drm/radeon_cp.c
index 7f949c9c9691..5ad43ba7b5aa 100644
--- a/drivers/char/drm/radeon_cp.c
+++ b/drivers/char/drm/radeon_cp.c
@@ -39,7 +39,7 @@
 static int radeon_do_cleanup_cp(drm_device_t * dev);
 
 /* CP microcode (from ATI) */
-static u32 R200_cp_microcode[][2] = {
+static const u32 R200_cp_microcode[][2] = {
         {0x21007000, 0000000000},
         {0x20007000, 0000000000},
         {0x000000ab, 0x00000004},
@@ -298,7 +298,7 @@ static u32 R200_cp_microcode[][2] = {
         {0000000000, 0000000000},
 };
 
-static u32 radeon_cp_microcode[][2] = {
+static const u32 radeon_cp_microcode[][2] = {
         {0x21007000, 0000000000},
         {0x20007000, 0000000000},
         {0x000000b4, 0x00000004},
@@ -557,7 +557,7 @@ static u32 radeon_cp_microcode[][2] = {
         {0000000000, 0000000000},
 };
 
-static u32 R300_cp_microcode[][2] = {
+static const u32 R300_cp_microcode[][2] = {
         {0x4200e000, 0000000000},
         {0x4000e000, 0000000000},
         {0x000000af, 0x00000008},
diff --git a/drivers/char/drm/radeon_drm.h b/drivers/char/drm/radeon_drm.h
index c8e279e89c2e..8d6350dd5360 100644
--- a/drivers/char/drm/radeon_drm.h
+++ b/drivers/char/drm/radeon_drm.h
@@ -161,7 +161,8 @@
 #define R200_EMIT_PP_TXCTLALL_3                     91
 #define R200_EMIT_PP_TXCTLALL_4                     92
 #define R200_EMIT_PP_TXCTLALL_5                     93
-#define RADEON_MAX_STATE_PACKETS                    94
+#define R200_EMIT_VAP_PVS_CNTL                      94
+#define RADEON_MAX_STATE_PACKETS                    95
 
 /* Commands understood by cmd_buffer ioctl.  More can be added but
  * obviously these can't be removed or changed:
@@ -176,6 +177,7 @@
 #define RADEON_CMD_WAIT         8       /* emit hw wait commands -- note:
                                          *  doesn't make the cpu wait, just
                                          *  the graphics hardware */
+#define RADEON_CMD_VECLINEAR    9       /* another r200 stopgap */
 
 typedef union {
         int i;
@@ -192,6 +194,9 @@ typedef union {
                 unsigned char cmd_type, offset, stride, count;
         } vectors;
         struct {
+                unsigned char cmd_type, addr_lo, addr_hi, count;
+        } veclinear;
+        struct {
                 unsigned char cmd_type, buf_idx, pad0, pad1;
         } dma;
         struct {
diff --git a/drivers/char/drm/radeon_drv.h b/drivers/char/drm/radeon_drv.h
index 78345cee8f8e..e5a256f5429c 100644
--- a/drivers/char/drm/radeon_drv.h
+++ b/drivers/char/drm/radeon_drv.h
@@ -38,7 +38,7 @@
 
 #define DRIVER_NAME             "radeon"
 #define DRIVER_DESC             "ATI Radeon"
-#define DRIVER_DATE             "20060225"
+#define DRIVER_DATE             "20060524"
 
 /* Interface history:
  *
@@ -93,9 +93,11 @@
  * 1.22- Add support for texture cache flushes (R300_TX_CNTL)
  * 1.23- Add new radeon memory map work from benh
  * 1.24- Add general-purpose packet for manipulating scratch registers (r300)
+ * 1.25- Add support for r200 vertex programs (R200_EMIT_VAP_PVS_CNTL,
+ *       new packet type)
  */
 #define DRIVER_MAJOR            1
-#define DRIVER_MINOR            24
+#define DRIVER_MINOR            25
 #define DRIVER_PATCHLEVEL       0
 
 /*
@@ -884,6 +886,8 @@ extern int r300_do_cp_cmdbuf(drm_device_t * dev, DRMFILE filp,
 #define RADEON_PP_CUBIC_OFFSET_T1_0         0x1e00
 #define RADEON_PP_CUBIC_OFFSET_T2_0         0x1e14
 
+#define RADEON_SE_TCL_STATE_FLUSH           0x2284
+
 #define SE_VAP_CNTL__TCL_ENA_MASK                          0x00000001
 #define SE_VAP_CNTL__FORCE_W_TO_ONE_MASK                   0x00010000
 #define SE_VAP_CNTL__VF_MAX_VTX_NUM__SHIFT                 0x00000012
@@ -905,6 +909,8 @@ extern int r300_do_cp_cmdbuf(drm_device_t * dev, DRMFILE filp,
 #define R200_PP_AFS_0                     0x2f80
 #define R200_PP_AFS_1                     0x2f00        /* same as txcblend_0 */
 
+#define R200_VAP_PVS_CNTL_1               0x22D0
+
 /* Constants */
 #define RADEON_MAX_USEC_TIMEOUT         100000  /* 100 ms */
 
diff --git a/drivers/char/drm/radeon_state.c b/drivers/char/drm/radeon_state.c
index c5b8f774a599..5bb2234a9094 100644
--- a/drivers/char/drm/radeon_state.c
+++ b/drivers/char/drm/radeon_state.c
@@ -249,6 +249,7 @@ static __inline__ int radeon_check_and_fixup_packets(drm_radeon_private_t *
         case R200_EMIT_PP_TXCTLALL_3:
         case R200_EMIT_PP_TXCTLALL_4:
         case R200_EMIT_PP_TXCTLALL_5:
+        case R200_EMIT_VAP_PVS_CNTL:
                 /* These packets don't contain memory offsets */
                 break;
 
@@ -626,6 +627,7 @@ static struct {
         {R200_PP_TXFILTER_3, 8, "R200_PP_TXCTLALL_3"},
         {R200_PP_TXFILTER_4, 8, "R200_PP_TXCTLALL_4"},
         {R200_PP_TXFILTER_5, 8, "R200_PP_TXCTLALL_5"},
+        {R200_VAP_PVS_CNTL_1, 2, "R200_VAP_PVS_CNTL"},
 };
 
 /* ================================================================
@@ -2595,7 +2597,8 @@ static __inline__ int radeon_emit_vectors(drm_radeon_private_t *dev_priv,
         int stride = header.vectors.stride;
         RING_LOCALS;
 
-        BEGIN_RING(3 + sz);
+        BEGIN_RING(5 + sz);
+        OUT_RING_REG(RADEON_SE_TCL_STATE_FLUSH, 0);
         OUT_RING(CP_PACKET0(RADEON_SE_TCL_VECTOR_INDX_REG, 0));
         OUT_RING(start | (stride << RADEON_VEC_INDX_OCTWORD_STRIDE_SHIFT));
         OUT_RING(CP_PACKET0_TABLE(RADEON_SE_TCL_VECTOR_DATA_REG, (sz - 1)));
@@ -2607,6 +2610,32 @@ static __inline__ int radeon_emit_vectors(drm_radeon_private_t *dev_priv,
         return 0;
 }
 
+static __inline__ int radeon_emit_veclinear(drm_radeon_private_t *dev_priv,
+                                          drm_radeon_cmd_header_t header,
+                                          drm_radeon_kcmd_buffer_t *cmdbuf)
+{
+        int sz = header.veclinear.count * 4;
+        int start = header.veclinear.addr_lo | (header.veclinear.addr_hi << 8);
+        RING_LOCALS;
+
+        if (!sz)
+                return 0;
+        if (sz * 4 > cmdbuf->bufsz)
+                return DRM_ERR(EINVAL);
+
+        BEGIN_RING(5 + sz);
+        OUT_RING_REG(RADEON_SE_TCL_STATE_FLUSH, 0);
+        OUT_RING(CP_PACKET0(RADEON_SE_TCL_VECTOR_INDX_REG, 0));
+        OUT_RING(start | (1 << RADEON_VEC_INDX_OCTWORD_STRIDE_SHIFT));
+        OUT_RING(CP_PACKET0_TABLE(RADEON_SE_TCL_VECTOR_DATA_REG, (sz - 1)));
+        OUT_RING_TABLE(cmdbuf->buf, sz);
+        ADVANCE_RING();
+
+        cmdbuf->buf += sz * sizeof(int);
+        cmdbuf->bufsz -= sz * sizeof(int);
+        return 0;
+}
+
 static int radeon_emit_packet3(drm_device_t * dev,
                                drm_file_t * filp_priv,
                                drm_radeon_kcmd_buffer_t *cmdbuf)
@@ -2865,6 +2894,14 @@ static int radeon_cp_cmdbuf(DRM_IOCTL_ARGS)
                                 goto err;
                         }
                         break;
+                case RADEON_CMD_VECLINEAR:
+                        DRM_DEBUG("RADEON_CMD_VECLINEAR\n");
+                        if (radeon_emit_veclinear(dev_priv, header, &cmdbuf)) {
+                                DRM_ERROR("radeon_emit_veclinear failed\n");
+                                goto err;
+                        }
+                        break;
+
                 default:
                         DRM_ERROR("bad cmd_type %d at %p\n",
                                   header.header.cmd_type,
diff --git a/drivers/char/drm/via_dmablit.c b/drivers/char/drm/via_dmablit.c
index b7f17457b424..78a81a4a99c5 100644
--- a/drivers/char/drm/via_dmablit.c
+++ b/drivers/char/drm/via_dmablit.c
@@ -557,7 +557,7 @@ via_init_dmablit(drm_device_t *dev)
                 blitq->num_outstanding = 0;
                 blitq->is_active = 0;
                 blitq->aborting = 0;
-                blitq->blit_lock = SPIN_LOCK_UNLOCKED;
+                spin_lock_init(&blitq->blit_lock);
                 for (j=0; j<VIA_NUM_BLIT_SLOTS; ++j) {
                         DRM_INIT_WAITQUEUE(blitq->blit_queue + j);
                 }
diff --git a/drivers/char/epca.c b/drivers/char/epca.c
index 9cad8501d62c..dc0602ae8503 100644
--- a/drivers/char/epca.c
+++ b/drivers/char/epca.c
@@ -80,7 +80,7 @@ static int invalid_lilo_config;
 /* The ISA boards do window flipping into the same spaces so its only sane
    with a single lock. It's still pretty efficient */
 
-static spinlock_t epca_lock = SPIN_LOCK_UNLOCKED;
+static DEFINE_SPINLOCK(epca_lock);
 
 /* -----------------------------------------------------------------------
         MAXBOARDS is typically 12, but ISA and EISA cards are restricted to 
diff --git a/drivers/char/esp.c b/drivers/char/esp.c
index 09dc4b01232c..922174d527ae 100644
--- a/drivers/char/esp.c
+++ b/drivers/char/esp.c
@@ -1212,7 +1212,7 @@ static void rs_put_char(struct tty_struct *tty, unsigned char ch)
         if (serial_paranoia_check(info, tty->name, "rs_put_char"))
                 return;
 
-        if (!tty || !info->xmit_buf)
+        if (!info->xmit_buf)
                 return;
 
         spin_lock_irqsave(&info->lock, flags);
@@ -1256,7 +1256,7 @@ static int rs_write(struct tty_struct * tty,
         if (serial_paranoia_check(info, tty->name, "rs_write"))
                 return 0;
 
-        if (!tty || !info->xmit_buf)
+        if (!info->xmit_buf)
                 return 0;
             
         while (1) {
diff --git a/drivers/char/hangcheck-timer.c b/drivers/char/hangcheck-timer.c
index ac626418b329..d69f2ad9a67d 100644
--- a/drivers/char/hangcheck-timer.c
+++ b/drivers/char/hangcheck-timer.c
@@ -117,12 +117,12 @@ __setup("hcheck_reboot", hangcheck_parse_reboot);
 __setup("hcheck_dump_tasks", hangcheck_parse_dump_tasks);
 #endif /* not MODULE */
 
-#if defined(CONFIG_X86) || defined(CONFIG_S390)
+#if defined(CONFIG_X86_64) || defined(CONFIG_S390)
 # define HAVE_MONOTONIC
 # define TIMER_FREQ 1000000000ULL
 #elif defined(CONFIG_IA64)
 # define TIMER_FREQ ((unsigned long long)local_cpu_data->itc_freq)
-#elif defined(CONFIG_PPC64)
+#else
 # define TIMER_FREQ (HZ*loops_per_jiffy)
 #endif
 
diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
index ef140ebde117..07473cd84121 100644
--- a/drivers/char/hpet.c
+++ b/drivers/char/hpet.c
@@ -925,11 +925,8 @@ static acpi_status hpet_resources(struct acpi_resource *res, void *data)
         status = acpi_resource_to_address64(res, &addr);
 
         if (ACPI_SUCCESS(status)) {
-                unsigned long size;
-
-                size = addr.maximum - addr.minimum + 1;
                 hdp->hd_phys_address = addr.minimum;
-                hdp->hd_address = ioremap(addr.minimum, size);
+                hdp->hd_address = ioremap(addr.minimum, addr.address_length);
 
                 if (hpet_is_known(hdp)) {
                         printk(KERN_DEBUG "%s: 0x%lx is busy\n",
diff --git a/drivers/char/hvc_console.c b/drivers/char/hvc_console.c
index 2b6a56b2bf35..a5c6a9d7ff08 100644
--- a/drivers/char/hvc_console.c
+++ b/drivers/char/hvc_console.c
@@ -553,7 +553,6 @@ static int hvc_chars_in_buffer(struct tty_struct *tty)
 
 #define HVC_POLL_READ   0x00000001
 #define HVC_POLL_WRITE  0x00000002
-#define HVC_POLL_QUICK  0x00000004
 
 static int hvc_poll(struct hvc_struct *hp)
 {
@@ -568,6 +567,7 @@ static int hvc_poll(struct hvc_struct *hp)
         /* Push pending writes */
         if (hp->n_outbuf > 0)
                 hvc_push(hp);
+
         /* Reschedule us if still some write pending */
         if (hp->n_outbuf > 0)
                 poll_mask |= HVC_POLL_WRITE;
@@ -680,7 +680,7 @@ int khvcd(void *unused)
                         poll_mask |= HVC_POLL_READ;
                 if (hvc_kicked)
                         continue;
-                if (poll_mask & HVC_POLL_QUICK) {
+                if (poll_mask & HVC_POLL_WRITE) {
                         yield();
                         continue;
                 }
diff --git a/drivers/char/hvc_rtas.c b/drivers/char/hvc_rtas.c
index 83364ea63cba..57106e02fd2e 100644
--- a/drivers/char/hvc_rtas.c
+++ b/drivers/char/hvc_rtas.c
@@ -41,37 +41,28 @@
 #define hvc_rtas_cookie 0x67781e15
 struct hvc_struct *hvc_rtas_dev;
 
-#define RTASCONS_PUT_ATTEMPTS  16
-
 static int rtascons_put_char_token = RTAS_UNKNOWN_SERVICE;
 static int rtascons_get_char_token = RTAS_UNKNOWN_SERVICE;
-static int rtascons_put_delay = 100;
-module_param_named(put_delay, rtascons_put_delay, int, 0644);
 
-static inline int hvc_rtas_write_console(uint32_t vtermno, const char *buf, int count)
+static inline int hvc_rtas_write_console(uint32_t vtermno, const char *buf,
+                int count)
 {
-        int done;
+        int i;
 
-        /* if there is more than one character to be displayed, wait a bit */
-        for (done = 0; done < count; done++) {
-                int result;
-                result = rtas_call(rtascons_put_char_token, 1, 1, NULL, buf[done]);
-                if (result)
+        for (i = 0; i < count; i++) {
+                if (rtas_call(rtascons_put_char_token, 1, 1, NULL, buf[i]))
                         break;
         }
-        /* the calling routine expects to receive the number of bytes sent */
-        return done;
+
+        return i;
 }
 
 static int hvc_rtas_read_console(uint32_t vtermno, char *buf, int count)
 {
-        int i;
+        int i, c;
 
         for (i = 0; i < count; i++) {
-                int c, err;
-
-                err = rtas_call(rtascons_get_char_token, 0, 2, &c);
-                if (err)
+                if (rtas_call(rtascons_get_char_token, 0, 2, &c))
                         break;
 
                 buf[i] = c;
@@ -106,7 +97,9 @@ static int hvc_rtas_init(void)
         hp = hvc_alloc(hvc_rtas_cookie, NO_IRQ, &hvc_rtas_get_put_ops);
         if (IS_ERR(hp))
                 return PTR_ERR(hp);
+
         hvc_rtas_dev = hp;
+
         return 0;
 }
 module_init(hvc_rtas_init);
@@ -114,8 +107,8 @@ module_init(hvc_rtas_init);
 /* This will tear down the tty portion of the driver */
 static void __exit hvc_rtas_exit(void)
 {
-        /* Really the fun isn't over until the worker thread breaks down and the
-         * tty cleans up */
+        /* Really the fun isn't over until the worker thread breaks down and
+         * the tty cleans up */
         if (hvc_rtas_dev)
                 hvc_remove(hvc_rtas_dev);
 }
@@ -127,12 +120,14 @@ static int hvc_rtas_console_init(void)
         rtascons_put_char_token = rtas_token("put-term-char");
         if (rtascons_put_char_token == RTAS_UNKNOWN_SERVICE)
                 return -EIO;
+
         rtascons_get_char_token = rtas_token("get-term-char");
         if (rtascons_get_char_token == RTAS_UNKNOWN_SERVICE)
                 return -EIO;
 
-        hvc_instantiate(hvc_rtas_cookie, 0, &hvc_rtas_get_put_ops );
+        hvc_instantiate(hvc_rtas_cookie, 0, &hvc_rtas_get_put_ops);
         add_preferred_console("hvc", 0, NULL);
+
         return 0;
 }
 console_initcall(hvc_rtas_console_init);
diff --git a/drivers/char/hvcs.c b/drivers/char/hvcs.c
index 8d97b3911293..afa26b65dac3 100644
--- a/drivers/char/hvcs.c
+++ b/drivers/char/hvcs.c
@@ -1320,11 +1320,12 @@ static struct tty_operations hvcs_ops = {
 static int hvcs_alloc_index_list(int n)
 {
         int i;
+
         hvcs_index_list = kmalloc(n * sizeof(hvcs_index_count),GFP_KERNEL);
         if (!hvcs_index_list)
                 return -ENOMEM;
         hvcs_index_count = n;
-        for(i = 0; i < hvcs_index_count; i++)
+        for (i = 0; i < hvcs_index_count; i++)
                 hvcs_index_list[i] = -1;
         return 0;
 }
@@ -1332,11 +1333,9 @@ static int hvcs_alloc_index_list(int n)
 static void hvcs_free_index_list(void)
 {
         /* Paranoia check to be thorough. */
-        if (hvcs_index_list) {
-                kfree(hvcs_index_list);
-                hvcs_index_list = NULL;
-                hvcs_index_count = 0;
-        }
+        kfree(hvcs_index_list);
+        hvcs_index_list = NULL;
+        hvcs_index_count = 0;
 }
 
 static int __init hvcs_module_init(void)
diff --git a/drivers/char/hvsi.c b/drivers/char/hvsi.c
index a9522189fc9e..a0370ed752ce 100644
--- a/drivers/char/hvsi.c
+++ b/drivers/char/hvsi.c
@@ -1179,7 +1179,7 @@ static int __init hvsi_init(void)
         if (tty_register_driver(hvsi_driver))
                 panic("Couldn't register hvsi console driver\n");
 
-        printk(KERN_INFO "HVSI: registered %i devices\n", hvsi_count);
+        printk(KERN_DEBUG "HVSI: registered %i devices\n", hvsi_count);
 
         return 0;
 }
diff --git a/drivers/char/hw_random.c b/drivers/char/hw_random.c
deleted file mode 100644
index 29dc87e59020..000000000000
--- a/drivers/char/hw_random.c
+++ /dev/null
@@ -1,698 +0,0 @@
-/*
-        Added support for the AMD Geode LX RNG
-        (c) Copyright 2004-2005 Advanced Micro Devices, Inc.
-
-        derived from
-
-        Hardware driver for the Intel/AMD/VIA Random Number Generators (RNG)
-        (c) Copyright 2003 Red Hat Inc <jgarzik@redhat.com>
- 
-        derived from
- 
-        Hardware driver for the AMD 768 Random Number Generator (RNG)
-        (c) Copyright 2001 Red Hat Inc <alan@redhat.com>
-
-        derived from
- 
-        Hardware driver for Intel i810 Random Number Generator (RNG)
-        Copyright 2000,2001 Jeff Garzik <jgarzik@pobox.com>
-        Copyright 2000,2001 Philipp Rumpf <prumpf@mandrakesoft.com>
-
-        Please read Documentation/hw_random.txt for details on use.
-
-        ----------------------------------------------------------
-        This software may be used and distributed according to the terms
-        of the GNU General Public License, incorporated herein by reference.
-
- */
-
-
-#include <linux/module.h>
-#include <linux/kernel.h>
-#include <linux/fs.h>
-#include <linux/init.h>
-#include <linux/pci.h>
-#include <linux/interrupt.h>
-#include <linux/spinlock.h>
-#include <linux/random.h>
-#include <linux/miscdevice.h>
-#include <linux/smp_lock.h>
-#include <linux/mm.h>
-#include <linux/delay.h>
-
-#ifdef __i386__
-#include <asm/msr.h>
-#include <asm/cpufeature.h>
-#endif
-
-#include <asm/io.h>
-#include <asm/uaccess.h>
-
-
-/*
- * core module and version information
- */
-#define RNG_VERSION "1.0.0"
-#define RNG_MODULE_NAME "hw_random"
-#define RNG_DRIVER_NAME   RNG_MODULE_NAME " hardware driver " RNG_VERSION
-#define PFX RNG_MODULE_NAME ": "
-
-
-/*
- * debugging macros
- */
-
-/* pr_debug() collapses to a no-op if DEBUG is not defined */
-#define DPRINTK(fmt, args...) pr_debug(PFX "%s: " fmt, __FUNCTION__ , ## args)
-
-
-#undef RNG_NDEBUG        /* define to enable lightweight runtime checks */
-#ifdef RNG_NDEBUG
-#define assert(expr)                                                    \
-                if(!(expr)) {                                           \
-                printk(KERN_DEBUG PFX "Assertion failed! %s,%s,%s,"     \
-                "line=%d\n", #expr, __FILE__, __FUNCTION__, __LINE__);  \
-                }
-#else
-#define assert(expr)
-#endif
-
-#define RNG_MISCDEV_MINOR               183 /* official */
-
-static int rng_dev_open (struct inode *inode, struct file *filp);
-static ssize_t rng_dev_read (struct file *filp, char __user *buf, size_t size,
-                                loff_t * offp);
-
-static int __init intel_init (struct pci_dev *dev);
-static void intel_cleanup(void);
-static unsigned int intel_data_present (void);
-static u32 intel_data_read (void);
-
-static int __init amd_init (struct pci_dev *dev);
-static void amd_cleanup(void);
-static unsigned int amd_data_present (void);
-static u32 amd_data_read (void);
-
-#ifdef __i386__
-static int __init via_init(struct pci_dev *dev);
-static void via_cleanup(void);
-static unsigned int via_data_present (void);
-static u32 via_data_read (void);
-#endif
-
-static int __init geode_init(struct pci_dev *dev);
-static void geode_cleanup(void);
-static unsigned int geode_data_present (void);
-static u32 geode_data_read (void);
-
-struct rng_operations {
-        int (*init) (struct pci_dev *dev);
-        void (*cleanup) (void);
-        unsigned int (*data_present) (void);
-        u32 (*data_read) (void);
-        unsigned int n_bytes; /* number of bytes per ->data_read */
-};
-static struct rng_operations *rng_ops;
-
-static struct file_operations rng_chrdev_ops = {
-        .owner          = THIS_MODULE,
-        .open           = rng_dev_open,
-        .read           = rng_dev_read,
-};
-
-
-static struct miscdevice rng_miscdev = {
-        RNG_MISCDEV_MINOR,
-        RNG_MODULE_NAME,
-        &rng_chrdev_ops,
-};
-
-enum {
-        rng_hw_none,
-        rng_hw_intel,
-        rng_hw_amd,
-#ifdef __i386__
-        rng_hw_via,
-#endif
-        rng_hw_geode,
-};
-
-static struct rng_operations rng_vendor_ops[] = {
-        /* rng_hw_none */
-        { },
-
-        /* rng_hw_intel */
-        { intel_init, intel_cleanup, intel_data_present,
-          intel_data_read, 1 },
-
-        /* rng_hw_amd */
-        { amd_init, amd_cleanup, amd_data_present, amd_data_read, 4 },
-
-#ifdef __i386__
-        /* rng_hw_via */
-        { via_init, via_cleanup, via_data_present, via_data_read, 1 },
-#endif
-
-        /* rng_hw_geode */
-        { geode_init, geode_cleanup, geode_data_present, geode_data_read, 4 }
-};
-
-/*
- * Data for PCI driver interface
- *
- * This data only exists for exporting the supported
- * PCI ids via MODULE_DEVICE_TABLE.  We do not actually
- * register a pci_driver, because someone else might one day
- * want to register another driver on the same PCI id.
- */
-static struct pci_device_id rng_pci_tbl[] = {
-        { 0x1022, 0x7443, PCI_ANY_ID, PCI_ANY_ID, 0, 0, rng_hw_amd },
-        { 0x1022, 0x746b, PCI_ANY_ID, PCI_ANY_ID, 0, 0, rng_hw_amd },
-
-        { 0x8086, 0x2418, PCI_ANY_ID, PCI_ANY_ID, 0, 0, rng_hw_intel },
-        { 0x8086, 0x2428, PCI_ANY_ID, PCI_ANY_ID, 0, 0, rng_hw_intel },
-        { 0x8086, 0x2430, PCI_ANY_ID, PCI_ANY_ID, 0, 0, rng_hw_intel },
-        { 0x8086, 0x2448, PCI_ANY_ID, PCI_ANY_ID, 0, 0, rng_hw_intel },
-        { 0x8086, 0x244e, PCI_ANY_ID, PCI_ANY_ID, 0, 0, rng_hw_intel },
-        { 0x8086, 0x245e, PCI_ANY_ID, PCI_ANY_ID, 0, 0, rng_hw_intel },
-
-        { PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_LX_AES,
-          PCI_ANY_ID, PCI_ANY_ID, 0, 0, rng_hw_geode },
-
-        { 0, }, /* terminate list */
-};
-MODULE_DEVICE_TABLE (pci, rng_pci_tbl);
-
-
-/***********************************************************************
- *
- * Intel RNG operations
- *
- */
-
-/*
- * RNG registers (offsets from rng_mem)
- */
-#define INTEL_RNG_HW_STATUS                     0
-#define         INTEL_RNG_PRESENT               0x40
-#define         INTEL_RNG_ENABLED               0x01
-#define INTEL_RNG_STATUS                        1
-#define         INTEL_RNG_DATA_PRESENT          0x01
-#define INTEL_RNG_DATA                          2
-
-/*
- * Magic address at which Intel PCI bridges locate the RNG
- */
-#define INTEL_RNG_ADDR                          0xFFBC015F
-#define INTEL_RNG_ADDR_LEN                      3
-
-/* token to our ioremap'd RNG register area */
-static void __iomem *rng_mem;
-
-static inline u8 intel_hwstatus (void)
-{
-        assert (rng_mem != NULL);
-        return readb (rng_mem + INTEL_RNG_HW_STATUS);
-}
-
-static inline u8 intel_hwstatus_set (u8 hw_status)
-{
-        assert (rng_mem != NULL);
-        writeb (hw_status, rng_mem + INTEL_RNG_HW_STATUS);
-        return intel_hwstatus ();
-}
-
-static unsigned int intel_data_present(void)
-{
-        assert (rng_mem != NULL);
-
-        return (readb (rng_mem + INTEL_RNG_STATUS) & INTEL_RNG_DATA_PRESENT) ?
-                1 : 0;
-}
-
-static u32 intel_data_read(void)
-{
-        assert (rng_mem != NULL);
-
-        return readb (rng_mem + INTEL_RNG_DATA);
-}
-
-static int __init intel_init (struct pci_dev *dev)
-{
-        int rc;
-        u8 hw_status;
-
-        DPRINTK ("ENTER\n");
-
-        rng_mem = ioremap (INTEL_RNG_ADDR, INTEL_RNG_ADDR_LEN);
-        if (rng_mem == NULL) {
-                printk (KERN_ERR PFX "cannot ioremap RNG Memory\n");
-                rc = -EBUSY;
-                goto err_out;
-        }
-
-        /* Check for Intel 82802 */
-        hw_status = intel_hwstatus ();
-        if ((hw_status & INTEL_RNG_PRESENT) == 0) {
-                printk (KERN_ERR PFX "RNG not detected\n");
-                rc = -ENODEV;
-                goto err_out_free_map;
-        }
-
-        /* turn RNG h/w on, if it's off */
-        if ((hw_status & INTEL_RNG_ENABLED) == 0)
-                hw_status = intel_hwstatus_set (hw_status | INTEL_RNG_ENABLED);
-        if ((hw_status & INTEL_RNG_ENABLED) == 0) {
-                printk (KERN_ERR PFX "cannot enable RNG, aborting\n");
-                rc = -EIO;
-                goto err_out_free_map;
-        }
-
-        DPRINTK ("EXIT, returning 0\n");
-        return 0;
-
-err_out_free_map:
-        iounmap (rng_mem);
-        rng_mem = NULL;
-err_out:
-        DPRINTK ("EXIT, returning %d\n", rc);
-        return rc;
-}
-
-static void intel_cleanup(void)
-{
-        u8 hw_status;
-
-        hw_status = intel_hwstatus ();
-        if (hw_status & INTEL_RNG_ENABLED)
-                intel_hwstatus_set (hw_status & ~INTEL_RNG_ENABLED);
-        else
-                printk(KERN_WARNING PFX "unusual: RNG already disabled\n");
-        iounmap(rng_mem);
-        rng_mem = NULL;
-}
-
-/***********************************************************************
- *
- * AMD RNG operations
- *
- */
-
-static u32 pmbase;                      /* PMxx I/O base */
-static struct pci_dev *amd_dev;
-
-static unsigned int amd_data_present (void)
-{
-        return inl(pmbase + 0xF4) & 1;
-}
-
-
-static u32 amd_data_read (void)
-{
-        return inl(pmbase + 0xF0);
-}
-
-static int __init amd_init (struct pci_dev *dev)
-{
-        int rc;
-        u8 rnen;
-
-        DPRINTK ("ENTER\n");
-
-        pci_read_config_dword(dev, 0x58, &pmbase);
-
-        pmbase &= 0x0000FF00;
-
-        if (pmbase == 0)
-        {
-                printk (KERN_ERR PFX "power management base not set\n");
-                rc = -EIO;
-                goto err_out;
-        }
-
-        pci_read_config_byte(dev, 0x40, &rnen);
-        rnen |= (1 << 7);       /* RNG on */
-        pci_write_config_byte(dev, 0x40, rnen);
-
-        pci_read_config_byte(dev, 0x41, &rnen);
-        rnen |= (1 << 7);       /* PMIO enable */
-        pci_write_config_byte(dev, 0x41, rnen);
-
-        pr_info( PFX "AMD768 system management I/O registers at 0x%X.\n",
-                        pmbase);
-
-        amd_dev = dev;
-
-        DPRINTK ("EXIT, returning 0\n");
-        return 0;
-
-err_out:
-        DPRINTK ("EXIT, returning %d\n", rc);
-        return rc;
-}
-
-static void amd_cleanup(void)
-{
-        u8 rnen;
-
-        pci_read_config_byte(amd_dev, 0x40, &rnen);
-        rnen &= ~(1 << 7);      /* RNG off */
-        pci_write_config_byte(amd_dev, 0x40, rnen);
-
-        /* FIXME: twiddle pmio, also? */
-}
-
-#ifdef __i386__
-/***********************************************************************
- *
- * VIA RNG operations
- *
- */
-
-enum {
-        VIA_STRFILT_CNT_SHIFT   = 16,
-        VIA_STRFILT_FAIL        = (1 << 15),
-        VIA_STRFILT_ENABLE      = (1 << 14),
-        VIA_RAWBITS_ENABLE      = (1 << 13),
-        VIA_RNG_ENABLE          = (1 << 6),
-        VIA_XSTORE_CNT_MASK     = 0x0F,
-
-        VIA_RNG_CHUNK_8         = 0x00, /* 64 rand bits, 64 stored bits */
-        VIA_RNG_CHUNK_4         = 0x01, /* 32 rand bits, 32 stored bits */
-        VIA_RNG_CHUNK_4_MASK    = 0xFFFFFFFF,
-        VIA_RNG_CHUNK_2         = 0x02, /* 16 rand bits, 32 stored bits */
-        VIA_RNG_CHUNK_2_MASK    = 0xFFFF,
-        VIA_RNG_CHUNK_1         = 0x03, /* 8 rand bits, 32 stored bits */
-        VIA_RNG_CHUNK_1_MASK    = 0xFF,
-};
-
-static u32 via_rng_datum;
-
-/*
- * Investigate using the 'rep' prefix to obtain 32 bits of random data
- * in one insn.  The upside is potentially better performance.  The
- * downside is that the instruction becomes no longer atomic.  Due to
- * this, just like familiar issues with /dev/random itself, the worst
- * case of a 'rep xstore' could potentially pause a cpu for an
- * unreasonably long time.  In practice, this condition would likely
- * only occur when the hardware is failing.  (or so we hope :))
- *
- * Another possible performance boost may come from simply buffering
- * until we have 4 bytes, thus returning a u32 at a time,
- * instead of the current u8-at-a-time.
- */
-
-static inline u32 xstore(u32 *addr, u32 edx_in)
-{
-        u32 eax_out;
-
-        asm(".byte 0x0F,0xA7,0xC0 /* xstore %%edi (addr=%0) */"
-                :"=m"(*addr), "=a"(eax_out)
-                :"D"(addr), "d"(edx_in));
-
-        return eax_out;
-}
-
-static unsigned int via_data_present(void)
-{
-        u32 bytes_out;
-
-        /* We choose the recommended 1-byte-per-instruction RNG rate,
-         * for greater randomness at the expense of speed.  Larger
-         * values 2, 4, or 8 bytes-per-instruction yield greater
-         * speed at lesser randomness.
-         *
-         * If you change this to another VIA_CHUNK_n, you must also
-         * change the ->n_bytes values in rng_vendor_ops[] tables.
-         * VIA_CHUNK_8 requires further code changes.
-         *
-         * A copy of MSR_VIA_RNG is placed in eax_out when xstore
-         * completes.
-         */
-        via_rng_datum = 0; /* paranoia, not really necessary */
-        bytes_out = xstore(&via_rng_datum, VIA_RNG_CHUNK_1) & VIA_XSTORE_CNT_MASK;
-        if (bytes_out == 0)
-                return 0;
-
-        return 1;
-}
-
-static u32 via_data_read(void)
-{
-        return via_rng_datum;
-}
-
-static int __init via_init(struct pci_dev *dev)
-{
-        u32 lo, hi, old_lo;
-
-        /* Control the RNG via MSR.  Tread lightly and pay very close
-         * close attention to values written, as the reserved fields
-         * are documented to be "undefined and unpredictable"; but it
-         * does not say to write them as zero, so I make a guess that
-         * we restore the values we find in the register.
-         */
-        rdmsr(MSR_VIA_RNG, lo, hi);
-
-        old_lo = lo;
-        lo &= ~(0x7f << VIA_STRFILT_CNT_SHIFT);
-        lo &= ~VIA_XSTORE_CNT_MASK;
-        lo &= ~(VIA_STRFILT_ENABLE | VIA_STRFILT_FAIL | VIA_RAWBITS_ENABLE);
-        lo |= VIA_RNG_ENABLE;
-
-        if (lo != old_lo)
-                wrmsr(MSR_VIA_RNG, lo, hi);
-
-        /* perhaps-unnecessary sanity check; remove after testing if
-           unneeded */
-        rdmsr(MSR_VIA_RNG, lo, hi);
-        if ((lo & VIA_RNG_ENABLE) == 0) {
-                printk(KERN_ERR PFX "cannot enable VIA C3 RNG, aborting\n");
-                return -ENODEV;
-        }
-
-        return 0;
-}
-
-static void via_cleanup(void)
-{
-        /* do nothing */
-}
-#endif
-
-/***********************************************************************
- *
- * AMD Geode RNG operations
- *
- */
-
-static void __iomem *geode_rng_base = NULL;
-
-#define GEODE_RNG_DATA_REG   0x50
-#define GEODE_RNG_STATUS_REG 0x54
-
-static u32 geode_data_read(void)
-{
-        u32 val;
-
-        assert(geode_rng_base != NULL);
-        val = readl(geode_rng_base + GEODE_RNG_DATA_REG);
-        return val;
-}
-
-static unsigned int geode_data_present(void)
-{
-        u32 val;
-
-        assert(geode_rng_base != NULL);
-        val = readl(geode_rng_base + GEODE_RNG_STATUS_REG);
-        return val;
-}
-
-static void geode_cleanup(void)
-{
-        iounmap(geode_rng_base);
-        geode_rng_base = NULL;
-}
-
-static int geode_init(struct pci_dev *dev)
-{
-        unsigned long rng_base = pci_resource_start(dev, 0);
-
-        if (rng_base == 0)
-                return 1;
-
-        geode_rng_base = ioremap(rng_base, 0x58);
-
-        if (geode_rng_base == NULL) {
-                printk(KERN_ERR PFX "Cannot ioremap RNG memory\n");
-                return -EBUSY;
-        }
-
-        return 0;
-}
-
-/***********************************************************************
- *
- * /dev/hwrandom character device handling (major 10, minor 183)
- *
- */
-
-static int rng_dev_open (struct inode *inode, struct file *filp)
-{
-        /* enforce read-only access to this chrdev */
-        if ((filp->f_mode & FMODE_READ) == 0)
-                return -EINVAL;
-        if (filp->f_mode & FMODE_WRITE)
-                return -EINVAL;
-
-        return 0;
-}
-
-
-static ssize_t rng_dev_read (struct file *filp, char __user *buf, size_t size,
-                                loff_t * offp)
-{
-        static DEFINE_SPINLOCK(rng_lock);
-        unsigned int have_data;
-        u32 data = 0;
-        ssize_t ret = 0;
-
-        while (size) {
-                spin_lock(&rng_lock);
-
-                have_data = 0;
-                if (rng_ops->data_present()) {
-                        data = rng_ops->data_read();
-                        have_data = rng_ops->n_bytes;
-                }
-
-                spin_unlock (&rng_lock);
-
-                while (have_data && size) {
-                        if (put_user((u8)data, buf++)) {
-                                ret = ret ? : -EFAULT;
-                                break;
-                        }
-                        size--;
-                        ret++;
-                        have_data--;
-                        data>>=8;
-                }
-
-                if (filp->f_flags & O_NONBLOCK)
-                        return ret ? : -EAGAIN;
-
-                if(need_resched())
-                        schedule_timeout_interruptible(1);
-                else
-                        udelay(200);    /* FIXME: We could poll for 250uS ?? */
-
-                if (signal_pending (current))
-                        return ret ? : -ERESTARTSYS;
-        }
-        return ret;
-}
-
-
-
-/*
- * rng_init_one - look for and attempt to init a single RNG
- */
-static int __init rng_init_one (struct pci_dev *dev)
-{
-        int rc;
-
-        DPRINTK ("ENTER\n");
-
-        assert(rng_ops != NULL);
-
-        rc = rng_ops->init(dev);
-        if (rc)
-                goto err_out;
-
-        rc = misc_register (&rng_miscdev);
-        if (rc) {
-                printk (KERN_ERR PFX "misc device register failed\n");
-                goto err_out_cleanup_hw;
-        }
-
-        DPRINTK ("EXIT, returning 0\n");
-        return 0;
-
-err_out_cleanup_hw:
-        rng_ops->cleanup();
-err_out:
-        DPRINTK ("EXIT, returning %d\n", rc);
-        return rc;
-}
-
-
-
-MODULE_AUTHOR("The Linux Kernel team");
-MODULE_DESCRIPTION("H/W Random Number Generator (RNG) driver");
-MODULE_LICENSE("GPL");
-
-
-/*
- * rng_init - initialize RNG module
- */
-static int __init rng_init (void)
-{
-        int rc;
-        struct pci_dev *pdev = NULL;
-        const struct pci_device_id *ent;
-
-        DPRINTK ("ENTER\n");
-
-        /* Probe for Intel, AMD, Geode RNGs */
-        for_each_pci_dev(pdev) {
-                ent = pci_match_id(rng_pci_tbl, pdev);
-                if (ent) {
-                        rng_ops = &rng_vendor_ops[ent->driver_data];
-                        goto match;
-                }
-        }
-
-#ifdef __i386__
-        /* Probe for VIA RNG */
-        if (cpu_has_xstore) {
-                rng_ops = &rng_vendor_ops[rng_hw_via];
-                pdev = NULL;
-                goto match;
-        }
-#endif
-
-        DPRINTK ("EXIT, returning -ENODEV\n");
-        return -ENODEV;
-
-match:
-        rc = rng_init_one (pdev);
-        if (rc)
-                return rc;
-
-        pr_info( RNG_DRIVER_NAME " loaded\n");
-
-        DPRINTK ("EXIT, returning 0\n");
-        return 0;
-}
-
-
-/*
- * rng_init - shutdown RNG module
- */
-static void __exit rng_cleanup (void)
-{
-        DPRINTK ("ENTER\n");
-
-        misc_deregister (&rng_miscdev);
-
-        if (rng_ops->cleanup)
-                rng_ops->cleanup();
-
-        DPRINTK ("EXIT\n");
-}
-
-
-module_init (rng_init);
-module_exit (rng_cleanup);
diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
new file mode 100644
index 000000000000..9f7635f75178
--- /dev/null
+++ b/drivers/char/hw_random/Kconfig
@@ -0,0 +1,90 @@
+#
+# Hardware Random Number Generator (RNG) configuration
+#
+
+config HW_RANDOM
+        bool "Hardware Random Number Generator Core support"
+        default y
+        ---help---
+          Hardware Random Number Generator Core infrastructure.
+
+          If unsure, say Y.
+
+config HW_RANDOM_INTEL
+        tristate "Intel HW Random Number Generator support"
+        depends on HW_RANDOM && (X86 || IA64) && PCI
+        default y
+        ---help---
+          This driver provides kernel-side support for the Random Number
+          Generator hardware found on Intel i8xx-based motherboards.
+
+          To compile this driver as a module, choose M here: the
+          module will be called intel-rng.
+
+          If unsure, say Y.
+
+config HW_RANDOM_AMD
+        tristate "AMD HW Random Number Generator support"
+        depends on HW_RANDOM && X86 && PCI
+        default y
+        ---help---
+          This driver provides kernel-side support for the Random Number
+          Generator hardware found on AMD 76x-based motherboards.
+
+          To compile this driver as a module, choose M here: the
+          module will be called amd-rng.
+
+          If unsure, say Y.
+
+config HW_RANDOM_GEODE
+        tristate "AMD Geode HW Random Number Generator support"
+        depends on HW_RANDOM && X86 && PCI
+        default y
+        ---help---
+          This driver provides kernel-side support for the Random Number
+          Generator hardware found on the AMD Geode LX.
+
+          To compile this driver as a module, choose M here: the
+          module will be called geode-rng.
+
+          If unsure, say Y.
+
+config HW_RANDOM_VIA
+        tristate "VIA HW Random Number Generator support"
+        depends on HW_RANDOM && X86_32
+        default y
+        ---help---
+          This driver provides kernel-side support for the Random Number
+          Generator hardware found on VIA based motherboards.
+
+          To compile this driver as a module, choose M here: the
+          module will be called via-rng.
+
+          If unsure, say Y.
+
+config HW_RANDOM_IXP4XX
+        tristate "Intel IXP4xx NPU HW Random Number Generator support"
+        depends on HW_RANDOM && ARCH_IXP4XX
+        default y
+        ---help---
+          This driver provides kernel-side support for the Random
+          Number Generator hardware found on the Intel IXP4xx NPU.
+
+          To compile this driver as a module, choose M here: the
+          module will be called ixp4xx-rng.
+
+          If unsure, say Y.
+
+config HW_RANDOM_OMAP
+        tristate "OMAP Random Number Generator support"
+        depends on HW_RANDOM && (ARCH_OMAP16XX || ARCH_OMAP24XX)
+        default y
+        ---help---
+          This driver provides kernel-side support for the Random Number
+          Generator hardware found on OMAP16xx and OMAP24xx multimedia
+          processors.
+
+          To compile this driver as a module, choose M here: the
+          module will be called omap-rng.
+
+          If unsure, say Y.
diff --git a/drivers/char/hw_random/Makefile b/drivers/char/hw_random/Makefile
new file mode 100644
index 000000000000..e263ae96f940
--- /dev/null
+++ b/drivers/char/hw_random/Makefile
@@ -0,0 +1,11 @@
+#
+# Makefile for HW Random Number Generator (RNG) device drivers.
+#
+
+obj-$(CONFIG_HW_RANDOM) += core.o
+obj-$(CONFIG_HW_RANDOM_INTEL) += intel-rng.o
+obj-$(CONFIG_HW_RANDOM_AMD) += amd-rng.o
+obj-$(CONFIG_HW_RANDOM_GEODE) += geode-rng.o
+obj-$(CONFIG_HW_RANDOM_VIA) += via-rng.o
+obj-$(CONFIG_HW_RANDOM_IXP4XX) += ixp4xx-rng.o
+obj-$(CONFIG_HW_RANDOM_OMAP) += omap-rng.o
diff --git a/drivers/char/hw_random/amd-rng.c b/drivers/char/hw_random/amd-rng.c
new file mode 100644
index 000000000000..71e4e0f3fd54
--- /dev/null
+++ b/drivers/char/hw_random/amd-rng.c
@@ -0,0 +1,152 @@
+/*
+ * RNG driver for AMD RNGs
+ *
+ * Copyright 2005 (c) MontaVista Software, Inc.
+ *
+ * with the majority of the code coming from:
+ *
+ * Hardware driver for the Intel/AMD/VIA Random Number Generators (RNG)
+ * (c) Copyright 2003 Red Hat Inc <jgarzik@redhat.com>
+ *
+ * derived from
+ *
+ * Hardware driver for the AMD 768 Random Number Generator (RNG)
+ * (c) Copyright 2001 Red Hat Inc <alan@redhat.com>
+ *
+ * derived from
+ *
+ * Hardware driver for Intel i810 Random Number Generator (RNG)
+ * Copyright 2000,2001 Jeff Garzik <jgarzik@pobox.com>
+ * Copyright 2000,2001 Philipp Rumpf <prumpf@mandrakesoft.com>
+ *
+ * This file is licensed under  the terms of the GNU General Public
+ * License version 2. This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+#include <linux/module.h>
+#include <linux/kernel.h>
+#include <linux/pci.h>
+#include <linux/hw_random.h>
+#include <asm/io.h>
+
+
+#define PFX     KBUILD_MODNAME ": "
+
+
+/*
+ * Data for PCI driver interface
+ *
+ * This data only exists for exporting the supported
+ * PCI ids via MODULE_DEVICE_TABLE.  We do not actually
+ * register a pci_driver, because someone else might one day
+ * want to register another driver on the same PCI id.
+ */
+static const struct pci_device_id pci_tbl[] = {
+        { 0x1022, 0x7443, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0, },
+        { 0x1022, 0x746b, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0, },
+        { 0, }, /* terminate list */
+};
+MODULE_DEVICE_TABLE(pci, pci_tbl);
+
+static struct pci_dev *amd_pdev;
+
+
+static int amd_rng_data_present(struct hwrng *rng)
+{
+        u32 pmbase = (u32)rng->priv;
+
+        return !!(inl(pmbase + 0xF4) & 1);
+}
+
+static int amd_rng_data_read(struct hwrng *rng, u32 *data)
+{
+        u32 pmbase = (u32)rng->priv;
+
+        *data = inl(pmbase + 0xF0);
+
+        return 4;
+}
+
+static int amd_rng_init(struct hwrng *rng)
+{
+        u8 rnen;
+
+        pci_read_config_byte(amd_pdev, 0x40, &rnen);
+        rnen |= (1 << 7);       /* RNG on */
+        pci_write_config_byte(amd_pdev, 0x40, rnen);
+
+        pci_read_config_byte(amd_pdev, 0x41, &rnen);
+        rnen |= (1 << 7);       /* PMIO enable */
+        pci_write_config_byte(amd_pdev, 0x41, rnen);
+
+        return 0;
+}
+
+static void amd_rng_cleanup(struct hwrng *rng)
+{
+        u8 rnen;
+
+        pci_read_config_byte(amd_pdev, 0x40, &rnen);
+        rnen &= ~(1 << 7);      /* RNG off */
+        pci_write_config_byte(amd_pdev, 0x40, rnen);
+}
+
+
+static struct hwrng amd_rng = {
+        .name           = "amd",
+        .init           = amd_rng_init,
+        .cleanup        = amd_rng_cleanup,
+        .data_present   = amd_rng_data_present,
+        .data_read      = amd_rng_data_read,
+};
+
+
+static int __init mod_init(void)
+{
+        int err = -ENODEV;
+        struct pci_dev *pdev = NULL;
+        const struct pci_device_id *ent;
+        u32 pmbase;
+
+        for_each_pci_dev(pdev) {
+                ent = pci_match_id(pci_tbl, pdev);
+                if (ent)
+                        goto found;
+        }
+        /* Device not found. */
+        goto out;
+
+found:
+        err = pci_read_config_dword(pdev, 0x58, &pmbase);
+        if (err)
+                goto out;
+        err = -EIO;
+        pmbase &= 0x0000FF00;
+        if (pmbase == 0)
+                goto out;
+        amd_rng.priv = (unsigned long)pmbase;
+        amd_pdev = pdev;
+
+        printk(KERN_INFO "AMD768 RNG detected\n");
+        err = hwrng_register(&amd_rng);
+        if (err) {
+                printk(KERN_ERR PFX "RNG registering failed (%d)\n",
+                       err);
+                goto out;
+        }
+out:
+        return err;
+}
+
+static void __exit mod_exit(void)
+{
+        hwrng_unregister(&amd_rng);
+}
+
+subsys_initcall(mod_init);
+module_exit(mod_exit);
+
+MODULE_AUTHOR("The Linux Kernel team");
+MODULE_DESCRIPTION("H/W RNG driver for AMD chipsets");
+MODULE_LICENSE("GPL");
diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c
new file mode 100644
index 000000000000..88b026639f10
--- /dev/null
+++ b/drivers/char/hw_random/core.c
@@ -0,0 +1,354 @@
+/*
+        Added support for the AMD Geode LX RNG
+        (c) Copyright 2004-2005 Advanced Micro Devices, Inc.
+
+        derived from
+
+        Hardware driver for the Intel/AMD/VIA Random Number Generators (RNG)
+        (c) Copyright 2003 Red Hat Inc <jgarzik@redhat.com>
+
+        derived from
+
+        Hardware driver for the AMD 768 Random Number Generator (RNG)
+        (c) Copyright 2001 Red Hat Inc <alan@redhat.com>
+
+        derived from
+
+        Hardware driver for Intel i810 Random Number Generator (RNG)
+        Copyright 2000,2001 Jeff Garzik <jgarzik@pobox.com>
+        Copyright 2000,2001 Philipp Rumpf <prumpf@mandrakesoft.com>
+
+        Added generic RNG API
+        Copyright 2006 Michael Buesch <mbuesch@freenet.de>
+        Copyright 2005 (c) MontaVista Software, Inc.
+
+        Please read Documentation/hw_random.txt for details on use.
+
+        ----------------------------------------------------------
+        This software may be used and distributed according to the terms
+        of the GNU General Public License, incorporated herein by reference.
+
+ */
+
+
+#include <linux/device.h>
+#include <linux/hw_random.h>
+#include <linux/module.h>
+#include <linux/kernel.h>
+#include <linux/fs.h>
+#include <linux/init.h>
+#include <linux/miscdevice.h>
+#include <linux/delay.h>
+#include <asm/uaccess.h>
+
+
+#define RNG_MODULE_NAME         "hw_random"
+#define PFX                     RNG_MODULE_NAME ": "
+#define RNG_MISCDEV_MINOR       183 /* official */
+
+
+static struct hwrng *current_rng;
+static LIST_HEAD(rng_list);
+static DEFINE_MUTEX(rng_mutex);
+
+
+static inline int hwrng_init(struct hwrng *rng)
+{
+        if (!rng->init)
+                return 0;
+        return rng->init(rng);
+}
+
+static inline void hwrng_cleanup(struct hwrng *rng)
+{
+        if (rng && rng->cleanup)
+                rng->cleanup(rng);
+}
+
+static inline int hwrng_data_present(struct hwrng *rng)
+{
+        if (!rng->data_present)
+                return 1;
+        return rng->data_present(rng);
+}
+
+static inline int hwrng_data_read(struct hwrng *rng, u32 *data)
+{
+        return rng->data_read(rng, data);
+}
+
+
+static int rng_dev_open(struct inode *inode, struct file *filp)
+{
+        /* enforce read-only access to this chrdev */
+        if ((filp->f_mode & FMODE_READ) == 0)
+                return -EINVAL;
+        if (filp->f_mode & FMODE_WRITE)
+                return -EINVAL;
+        return 0;
+}
+
+static ssize_t rng_dev_read(struct file *filp, char __user *buf,
+                            size_t size, loff_t *offp)
+{
+        u32 data;
+        ssize_t ret = 0;
+        int i, err = 0;
+        int data_present;
+        int bytes_read;
+
+        while (size) {
+                err = -ERESTARTSYS;
+                if (mutex_lock_interruptible(&rng_mutex))
+                        goto out;
+                if (!current_rng) {
+                        mutex_unlock(&rng_mutex);
+                        err = -ENODEV;
+                        goto out;
+                }
+                if (filp->f_flags & O_NONBLOCK) {
+                        data_present = hwrng_data_present(current_rng);
+                } else {
+                        /* Some RNG require some time between data_reads to gather
+                         * new entropy. Poll it.
+                         */
+                        for (i = 0; i < 20; i++) {
+                                data_present = hwrng_data_present(current_rng);
+                                if (data_present)
+                                        break;
+                                udelay(10);
+                        }
+                }
+                bytes_read = 0;
+                if (data_present)
+                        bytes_read = hwrng_data_read(current_rng, &data);
+                mutex_unlock(&rng_mutex);
+
+                err = -EAGAIN;
+                if (!bytes_read && (filp->f_flags & O_NONBLOCK))
+                        goto out;
+
+                err = -EFAULT;
+                while (bytes_read && size) {
+                        if (put_user((u8)data, buf++))
+                                goto out;
+                        size--;
+                        ret++;
+                        bytes_read--;
+                        data >>= 8;
+                }
+
+                if (need_resched())
+                        schedule_timeout_interruptible(1);
+                err = -ERESTARTSYS;
+                if (signal_pending(current))
+                        goto out;
+        }
+out:
+        return ret ? : err;
+}
+
+
+static struct file_operations rng_chrdev_ops = {
+        .owner          = THIS_MODULE,
+        .open           = rng_dev_open,
+        .read           = rng_dev_read,
+};
+
+static struct miscdevice rng_miscdev = {
+        .minor          = RNG_MISCDEV_MINOR,
+        .name           = RNG_MODULE_NAME,
+        .fops           = &rng_chrdev_ops,
+};
+
+
+static ssize_t hwrng_attr_current_store(struct class_device *class,
+                                        const char *buf, size_t len)
+{
+        int err;
+        struct hwrng *rng;
+
+        err = mutex_lock_interruptible(&rng_mutex);
+        if (err)
+                return -ERESTARTSYS;
+        err = -ENODEV;
+        list_for_each_entry(rng, &rng_list, list) {
+                if (strcmp(rng->name, buf) == 0) {
+                        if (rng == current_rng) {
+                                err = 0;
+                                break;
+                        }
+                        err = hwrng_init(rng);
+                        if (err)
+                                break;
+                        hwrng_cleanup(current_rng);
+                        current_rng = rng;
+                        err = 0;
+                        break;
+                }
+        }
+        mutex_unlock(&rng_mutex);
+
+        return err ? : len;
+}
+
+static ssize_t hwrng_attr_current_show(struct class_device *class,
+                                       char *buf)
+{
+        int err;
+        ssize_t ret;
+        const char *name = "none";
+
+        err = mutex_lock_interruptible(&rng_mutex);
+        if (err)
+                return -ERESTARTSYS;
+        if (current_rng)
+                name = current_rng->name;
+        ret = snprintf(buf, PAGE_SIZE, "%s\n", name);
+        mutex_unlock(&rng_mutex);
+
+        return ret;
+}
+
+static ssize_t hwrng_attr_available_show(struct class_device *class,
+                                         char *buf)
+{
+        int err;
+        ssize_t ret = 0;
+        struct hwrng *rng;
+
+        err = mutex_lock_interruptible(&rng_mutex);
+        if (err)
+                return -ERESTARTSYS;
+        buf[0] = '\0';
+        list_for_each_entry(rng, &rng_list, list) {
+                strncat(buf, rng->name, PAGE_SIZE - ret - 1);
+                ret += strlen(rng->name);
+                strncat(buf, " ", PAGE_SIZE - ret - 1);
+                ret++;
+        }
+        strncat(buf, "\n", PAGE_SIZE - ret - 1);
+        ret++;
+        mutex_unlock(&rng_mutex);
+
+        return ret;
+}
+
+static CLASS_DEVICE_ATTR(rng_current, S_IRUGO | S_IWUSR,
+                         hwrng_attr_current_show,
+                         hwrng_attr_current_store);
+static CLASS_DEVICE_ATTR(rng_available, S_IRUGO,
+                         hwrng_attr_available_show,
+                         NULL);
+
+
+static void unregister_miscdev(void)
+{
+        class_device_remove_file(rng_miscdev.class,
+                                 &class_device_attr_rng_available);
+        class_device_remove_file(rng_miscdev.class,
+                                 &class_device_attr_rng_current);
+        misc_deregister(&rng_miscdev);
+}
+
+static int register_miscdev(void)
+{
+        int err;
+
+        err = misc_register(&rng_miscdev);
+        if (err)
+                goto out;
+        err = class_device_create_file(rng_miscdev.class,
+                                       &class_device_attr_rng_current);
+        if (err)
+                goto err_misc_dereg;
+        err = class_device_create_file(rng_miscdev.class,
+                                       &class_device_attr_rng_available);
+        if (err)
+                goto err_remove_current;
+out:
+        return err;
+
+err_remove_current:
+        class_device_remove_file(rng_miscdev.class,
+                                 &class_device_attr_rng_current);
+err_misc_dereg:
+        misc_deregister(&rng_miscdev);
+        goto out;
+}
+
+int hwrng_register(struct hwrng *rng)
+{
+        int must_register_misc;
+        int err = -EINVAL;
+        struct hwrng *old_rng, *tmp;
+
+        if (rng->name == NULL ||
+            rng->data_read == NULL)
+                goto out;
+
+        mutex_lock(&rng_mutex);
+
+        /* Must not register two RNGs with the same name. */
+        err = -EEXIST;
+        list_for_each_entry(tmp, &rng_list, list) {
+                if (strcmp(tmp->name, rng->name) == 0)
+                        goto out_unlock;
+        }
+
+        must_register_misc = (current_rng == NULL);
+        old_rng = current_rng;
+        if (!old_rng) {
+                err = hwrng_init(rng);
+                if (err)
+                        goto out_unlock;
+                current_rng = rng;
+        }
+        err = 0;
+        if (must_register_misc) {
+                err = register_miscdev();
+                if (err) {
+                        if (!old_rng) {
+                                hwrng_cleanup(rng);
+                                current_rng = NULL;
+                        }
+                        goto out_unlock;
+                }
+        }
+        INIT_LIST_HEAD(&rng->list);
+        list_add_tail(&rng->list, &rng_list);
+out_unlock:
+        mutex_unlock(&rng_mutex);
+out:
+        return err;
+}
+EXPORT_SYMBOL_GPL(hwrng_register);
+
+void hwrng_unregister(struct hwrng *rng)
+{
+        int err;
+
+        mutex_lock(&rng_mutex);
+
+        list_del(&rng->list);
+        if (current_rng == rng) {
+                hwrng_cleanup(rng);
+                if (list_empty(&rng_list)) {
+                        current_rng = NULL;
+                } else {
+                        current_rng = list_entry(rng_list.prev, struct hwrng, list);
+                        err = hwrng_init(current_rng);
+                        if (err)
+                                current_rng = NULL;
+                }
+        }
+        if (list_empty(&rng_list))
+                unregister_miscdev();
+
+        mutex_unlock(&rng_mutex);
+}
+EXPORT_SYMBOL_GPL(hwrng_unregister);
+
+
+MODULE_DESCRIPTION("H/W Random Number Generator (RNG) driver");
+MODULE_LICENSE("GPL");
diff --git a/drivers/char/hw_random/geode-rng.c b/drivers/char/hw_random/geode-rng.c
new file mode 100644
index 000000000000..be61f22ee7bb
--- /dev/null
+++ b/drivers/char/hw_random/geode-rng.c
@@ -0,0 +1,128 @@
+/*
+ * RNG driver for AMD Geode RNGs
+ *
+ * Copyright 2005 (c) MontaVista Software, Inc.
+ *
+ * with the majority of the code coming from:
+ *
+ * Hardware driver for the Intel/AMD/VIA Random Number Generators (RNG)
+ * (c) Copyright 2003 Red Hat Inc <jgarzik@redhat.com>
+ *
+ * derived from
+ *
+ * Hardware driver for the AMD 768 Random Number Generator (RNG)
+ * (c) Copyright 2001 Red Hat Inc <alan@redhat.com>
+ *
+ * derived from
+ *
+ * Hardware driver for Intel i810 Random Number Generator (RNG)
+ * Copyright 2000,2001 Jeff Garzik <jgarzik@pobox.com>
+ * Copyright 2000,2001 Philipp Rumpf <prumpf@mandrakesoft.com>
+ *
+ * This file is licensed under  the terms of the GNU General Public
+ * License version 2. This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+#include <linux/module.h>
+#include <linux/kernel.h>
+#include <linux/pci.h>
+#include <linux/hw_random.h>
+#include <asm/io.h>
+
+
+#define PFX     KBUILD_MODNAME ": "
+
+#define GEODE_RNG_DATA_REG   0x50
+#define GEODE_RNG_STATUS_REG 0x54
+
+/*
+ * Data for PCI driver interface
+ *
+ * This data only exists for exporting the supported
+ * PCI ids via MODULE_DEVICE_TABLE.  We do not actually
+ * register a pci_driver, because someone else might one day
+ * want to register another driver on the same PCI id.
+ */
+static const struct pci_device_id pci_tbl[] = {
+        { PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_LX_AES,
+          PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0, },
+        { 0, }, /* terminate list */
+};
+MODULE_DEVICE_TABLE(pci, pci_tbl);
+
+
+static int geode_rng_data_read(struct hwrng *rng, u32 *data)
+{
+        void __iomem *mem = (void __iomem *)rng->priv;
+
+        *data = readl(mem + GEODE_RNG_DATA_REG);
+
+        return 4;
+}
+
+static int geode_rng_data_present(struct hwrng *rng)
+{
+        void __iomem *mem = (void __iomem *)rng->priv;
+
+        return !!(readl(mem + GEODE_RNG_STATUS_REG));
+}
+
+
+static struct hwrng geode_rng = {
+        .name           = "geode",
+        .data_present   = geode_rng_data_present,
+        .data_read      = geode_rng_data_read,
+};
+
+
+static int __init mod_init(void)
+{
+        int err = -ENODEV;
+        struct pci_dev *pdev = NULL;
+        const struct pci_device_id *ent;
+        void __iomem *mem;
+        unsigned long rng_base;
+
+        for_each_pci_dev(pdev) {
+                ent = pci_match_id(pci_tbl, pdev);
+                if (ent)
+                        goto found;
+        }
+        /* Device not found. */
+        goto out;
+
+found:
+        rng_base = pci_resource_start(pdev, 0);
+        if (rng_base == 0)
+                goto out;
+        err = -ENOMEM;
+        mem = ioremap(rng_base, 0x58);
+        if (!mem)
+                goto out;
+        geode_rng.priv = (unsigned long)mem;
+
+        printk(KERN_INFO "AMD Geode RNG detected\n");
+        err = hwrng_register(&geode_rng);
+        if (err) {
+                printk(KERN_ERR PFX "RNG registering failed (%d)\n",
+                       err);
+                goto out;
+        }
+out:
+        return err;
+}
+
+static void __exit mod_exit(void)
+{
+        void __iomem *mem = (void __iomem *)geode_rng.priv;
+
+        hwrng_unregister(&geode_rng);
+        iounmap(mem);
+}
+
+subsys_initcall(mod_init);
+module_exit(mod_exit);
+
+MODULE_DESCRIPTION("H/W RNG driver for AMD Geode LX CPUs");
+MODULE_LICENSE("GPL");
diff --git a/drivers/char/hw_random/intel-rng.c b/drivers/char/hw_random/intel-rng.c
new file mode 100644
index 000000000000..6594bd5645f4
--- /dev/null
+++ b/drivers/char/hw_random/intel-rng.c
@@ -0,0 +1,189 @@
+/*
+ * RNG driver for Intel RNGs
+ *
+ * Copyright 2005 (c) MontaVista Software, Inc.
+ *
+ * with the majority of the code coming from:
+ *
+ * Hardware driver for the Intel/AMD/VIA Random Number Generators (RNG)
+ * (c) Copyright 2003 Red Hat Inc <jgarzik@redhat.com>
+ *
+ * derived from
+ *
+ * Hardware driver for the AMD 768 Random Number Generator (RNG)
+ * (c) Copyright 2001 Red Hat Inc <alan@redhat.com>
+ *
+ * derived from
+ *
+ * Hardware driver for Intel i810 Random Number Generator (RNG)
+ * Copyright 2000,2001 Jeff Garzik <jgarzik@pobox.com>
+ * Copyright 2000,2001 Philipp Rumpf <prumpf@mandrakesoft.com>
+ *
+ * This file is licensed under  the terms of the GNU General Public
+ * License version 2. This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+#include <linux/module.h>
+#include <linux/kernel.h>
+#include <linux/pci.h>
+#include <linux/hw_random.h>
+#include <asm/io.h>
+
+
+#define PFX     KBUILD_MODNAME ": "
+
+/*
+ * RNG registers
+ */
+#define INTEL_RNG_HW_STATUS                     0
+#define         INTEL_RNG_PRESENT               0x40
+#define         INTEL_RNG_ENABLED               0x01
+#define INTEL_RNG_STATUS                        1
+#define         INTEL_RNG_DATA_PRESENT          0x01
+#define INTEL_RNG_DATA                          2
+
+/*
+ * Magic address at which Intel PCI bridges locate the RNG
+ */
+#define INTEL_RNG_ADDR                          0xFFBC015F
+#define INTEL_RNG_ADDR_LEN                      3
+
+/*
+ * Data for PCI driver interface
+ *
+ * This data only exists for exporting the supported
+ * PCI ids via MODULE_DEVICE_TABLE.  We do not actually
+ * register a pci_driver, because someone else might one day
+ * want to register another driver on the same PCI id.
+ */
+static const struct pci_device_id pci_tbl[] = {
+        { 0x8086, 0x2418, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0, },
+        { 0x8086, 0x2428, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0, },
+        { 0x8086, 0x2430, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0, },
+        { 0x8086, 0x2448, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0, },
+        { 0x8086, 0x244e, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0, },
+        { 0x8086, 0x245e, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0, },
+        { 0, }, /* terminate list */
+};
+MODULE_DEVICE_TABLE(pci, pci_tbl);
+
+
+static inline u8 hwstatus_get(void __iomem *mem)
+{
+        return readb(mem + INTEL_RNG_HW_STATUS);
+}
+
+static inline u8 hwstatus_set(void __iomem *mem,
+                              u8 hw_status)
+{
+        writeb(hw_status, mem + INTEL_RNG_HW_STATUS);
+        return hwstatus_get(mem);
+}
+
+static int intel_rng_data_present(struct hwrng *rng)
+{
+        void __iomem *mem = (void __iomem *)rng->priv;
+
+        return !!(readb(mem + INTEL_RNG_STATUS) & INTEL_RNG_DATA_PRESENT);
+}
+
+static int intel_rng_data_read(struct hwrng *rng, u32 *data)
+{
+        void __iomem *mem = (void __iomem *)rng->priv;
+
+        *data = readb(mem + INTEL_RNG_DATA);
+
+        return 1;
+}
+
+static int intel_rng_init(struct hwrng *rng)
+{
+        void __iomem *mem = (void __iomem *)rng->priv;
+        u8 hw_status;
+        int err = -EIO;
+
+        hw_status = hwstatus_get(mem);
+        /* turn RNG h/w on, if it's off */
+        if ((hw_status & INTEL_RNG_ENABLED) == 0)
+                hw_status = hwstatus_set(mem, hw_status | INTEL_RNG_ENABLED);
+        if ((hw_status & INTEL_RNG_ENABLED) == 0) {
+                printk(KERN_ERR PFX "cannot enable RNG, aborting\n");
+                goto out;
+        }
+        err = 0;
+out:
+        return err;
+}
+
+static void intel_rng_cleanup(struct hwrng *rng)
+{
+        void __iomem *mem = (void __iomem *)rng->priv;
+        u8 hw_status;
+
+        hw_status = hwstatus_get(mem);
+        if (hw_status & INTEL_RNG_ENABLED)
+                hwstatus_set(mem, hw_status & ~INTEL_RNG_ENABLED);
+        else
+                printk(KERN_WARNING PFX "unusual: RNG already disabled\n");
+}
+
+
+static struct hwrng intel_rng = {
+        .name           = "intel",
+        .init           = intel_rng_init,
+        .cleanup        = intel_rng_cleanup,
+        .data_present   = intel_rng_data_present,
+        .data_read      = intel_rng_data_read,
+};
+
+
+static int __init mod_init(void)
+{
+        int err = -ENODEV;
+        void __iomem *mem;
+        u8 hw_status;
+
+        if (!pci_dev_present(pci_tbl))
+                goto out; /* Device not found. */
+
+        err = -ENOMEM;
+        mem = ioremap(INTEL_RNG_ADDR, INTEL_RNG_ADDR_LEN);
+        if (!mem)
+                goto out;
+        intel_rng.priv = (unsigned long)mem;
+
+        /* Check for Intel 82802 */
+        err = -ENODEV;
+        hw_status = hwstatus_get(mem);
+        if ((hw_status & INTEL_RNG_PRESENT) == 0)
+                goto err_unmap;
+
+        printk(KERN_INFO "Intel 82802 RNG detected\n");
+        err = hwrng_register(&intel_rng);
+        if (err) {
+                printk(KERN_ERR PFX "RNG registering failed (%d)\n",
+                       err);
+                goto out;
+        }
+out:
+        return err;
+
+err_unmap:
+        iounmap(mem);
+        goto out;
+}
+
+static void __exit mod_exit(void)
+{
+        void __iomem *mem = (void __iomem *)intel_rng.priv;
+
+        hwrng_unregister(&intel_rng);
+        iounmap(mem);
+}
+
+subsys_initcall(mod_init);
+module_exit(mod_exit);
+
+MODULE_DESCRIPTION("H/W RNG driver for Intel chipsets");
+MODULE_LICENSE("GPL");
diff --git a/drivers/char/hw_random/ixp4xx-rng.c b/drivers/char/hw_random/ixp4xx-rng.c
new file mode 100644
index 000000000000..ef71022423c9
--- /dev/null
+++ b/drivers/char/hw_random/ixp4xx-rng.c
@@ -0,0 +1,73 @@
+/*
+ * drivers/char/rng/ixp4xx-rng.c
+ *
+ * RNG driver for Intel IXP4xx family of NPUs
+ *
+ * Author: Deepak Saxena <dsaxena@plexity.net>
+ *
+ * Copyright 2005 (c) MontaVista Software, Inc.
+ *
+ * Fixes by Michael Buesch
+ *
+ * This file is licensed under  the terms of the GNU General Public
+ * License version 2. This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+#include <linux/kernel.h>
+#include <linux/config.h>
+#include <linux/types.h>
+#include <linux/module.h>
+#include <linux/moduleparam.h>
+#include <linux/init.h>
+#include <linux/bitops.h>
+#include <linux/hw_random.h>
+
+#include <asm/io.h>
+#include <asm/hardware.h>
+
+
+static int ixp4xx_rng_data_read(struct hwrng *rng, u32 *buffer)
+{
+        void __iomem * rng_base = (void __iomem *)rng->priv;
+
+        *buffer = __raw_readl(rng_base);
+
+        return 4;
+}
+
+static struct hwrng ixp4xx_rng_ops = {
+        .name           = "ixp4xx",
+        .data_read      = ixp4xx_rng_data_read,
+};
+
+static int __init ixp4xx_rng_init(void)
+{
+        void __iomem * rng_base;
+        int err;
+
+        rng_base = ioremap(0x70002100, 4);
+        if (!rng_base)
+                return -ENOMEM;
+        ixp4xx_rng_ops.priv = (unsigned long)rng_base;
+        err = hwrng_register(&ixp4xx_rng_ops);
+        if (err)
+                iounmap(rng_base);
+
+        return err;
+}
+
+static void __exit ixp4xx_rng_exit(void)
+{
+        void __iomem * rng_base = (void __iomem *)ixp4xx_rng_ops.priv;
+
+        hwrng_unregister(&ixp4xx_rng_ops);
+        iounmap(rng_base);
+}
+
+subsys_initcall(ixp4xx_rng_init);
+module_exit(ixp4xx_rng_exit);
+
+MODULE_AUTHOR("Deepak Saxena <dsaxena@plexity.net>");
+MODULE_DESCRIPTION("H/W Random Number Generator (RNG) driver for IXP4xx");
+MODULE_LICENSE("GPL");
diff --git a/drivers/char/hw_random/omap-rng.c b/drivers/char/hw_random/omap-rng.c
new file mode 100644
index 000000000000..819516b35a79
--- /dev/null
+++ b/drivers/char/hw_random/omap-rng.c
@@ -0,0 +1,208 @@
+/*
+ * driver/char/hw_random/omap-rng.c
+ *
+ * RNG driver for TI OMAP CPU family
+ *
+ * Author: Deepak Saxena <dsaxena@plexity.net>
+ *
+ * Copyright 2005 (c) MontaVista Software, Inc.
+ *
+ * Mostly based on original driver:
+ *
+ * Copyright (C) 2005 Nokia Corporation
+ * Author: Juha Yrj��<juha.yrjola@nokia.com>
+ *
+ * This file is licensed under  the terms of the GNU General Public
+ * License version 2. This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ *
+ * TODO:
+ *
+ * - Make status updated be interrupt driven so we don't poll
+ *
+ */
+
+#include <linux/module.h>
+#include <linux/init.h>
+#include <linux/random.h>
+#include <linux/err.h>
+#include <linux/device.h>
+#include <linux/hw_random.h>
+
+#include <asm/io.h>
+#include <asm/hardware/clock.h>
+
+#define RNG_OUT_REG             0x00            /* Output register */
+#define RNG_STAT_REG            0x04            /* Status register
+                                                        [0] = STAT_BUSY */
+#define RNG_ALARM_REG           0x24            /* Alarm register
+                                                        [7:0] = ALARM_COUNTER */
+#define RNG_CONFIG_REG          0x28            /* Configuration register
+                                                        [11:6] = RESET_COUNT
+                                                        [5:3]  = RING2_DELAY
+                                                        [2:0]  = RING1_DELAY */
+#define RNG_REV_REG             0x3c            /* Revision register
+                                                        [7:0] = REV_NB */
+#define RNG_MASK_REG            0x40            /* Mask and reset register
+                                                        [2] = IT_EN
+                                                        [1] = SOFTRESET
+                                                        [0] = AUTOIDLE */
+#define RNG_SYSSTATUS           0x44            /* System status
+                                                        [0] = RESETDONE */
+
+static void __iomem *rng_base;
+static struct clk *rng_ick;
+static struct device *rng_dev;
+
+static u32 omap_rng_read_reg(int reg)
+{
+        return __raw_readl(rng_base + reg);
+}
+
+static void omap_rng_write_reg(int reg, u32 val)
+{
+        __raw_writel(val, rng_base + reg);
+}
+
+/* REVISIT: Does the status bit really work on 16xx? */
+static int omap_rng_data_present(struct hwrng *rng)
+{
+        return omap_rng_read_reg(RNG_STAT_REG) ? 0 : 1;
+}
+
+static int omap_rng_data_read(struct hwrng *rng, u32 *data)
+{
+        *data = omap_rng_read_reg(RNG_OUT_REG);
+
+        return 4;
+}
+
+static struct hwrng omap_rng_ops = {
+        .name           = "omap",
+        .data_present   = omap_rng_data_present,
+        .data_read      = omap_rng_data_read,
+};
+
+static int __init omap_rng_probe(struct device *dev)
+{
+        struct platform_device *pdev = to_platform_device(dev);
+        struct resource *res, *mem;
+        int ret;
+
+        /*
+         * A bit ugly, and it will never actually happen but there can
+         * be only one RNG and this catches any bork
+         */
+        BUG_ON(rng_dev);
+
+        if (cpu_is_omap24xx()) {
+                rng_ick = clk_get(NULL, "rng_ick");
+                if (IS_ERR(rng_ick)) {
+                        dev_err(dev, "Could not get rng_ick\n");
+                        ret = PTR_ERR(rng_ick);
+                        return ret;
+                }
+                else {
+                        clk_use(rng_ick);
+                }
+        }
+
+        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+
+        if (!res)
+                return -ENOENT;
+
+        mem = request_mem_region(res->start, res->end - res->start + 1,
+                                 pdev->name);
+        if (mem == NULL)
+                return -EBUSY;
+
+        dev_set_drvdata(dev, mem);
+        rng_base = (u32 __iomem *)io_p2v(res->start);
+
+        ret = hwrng_register(&omap_rng_ops);
+        if (ret) {
+                release_resource(mem);
+                rng_base = NULL;
+                return ret;
+        }
+
+        dev_info(dev, "OMAP Random Number Generator ver. %02x\n",
+                omap_rng_read_reg(RNG_REV_REG));
+        omap_rng_write_reg(RNG_MASK_REG, 0x1);
+
+        rng_dev = dev;
+
+        return 0;
+}
+
+static int __exit omap_rng_remove(struct device *dev)
+{
+        struct resource *mem = dev_get_drvdata(dev);
+
+        hwrng_unregister(&omap_rng_ops);
+
+        omap_rng_write_reg(RNG_MASK_REG, 0x0);
+
+        if (cpu_is_omap24xx()) {
+                clk_unuse(rng_ick);
+                clk_put(rng_ick);
+        }
+
+        release_resource(mem);
+        rng_base = NULL;
+
+        return 0;
+}
+
+#ifdef CONFIG_PM
+
+static int omap_rng_suspend(struct device *dev, pm_message_t message, u32 level)
+{
+        omap_rng_write_reg(RNG_MASK_REG, 0x0);
+
+        return 0;
+}
+
+static int omap_rng_resume(struct device *dev, pm_message_t message, u32 level)
+{
+        omap_rng_write_reg(RNG_MASK_REG, 0x1);
+
+        return 1;
+}
+
+#else
+
+#define omap_rng_suspend        NULL
+#define omap_rng_resume         NULL
+
+#endif
+
+
+static struct device_driver omap_rng_driver = {
+        .name           = "omap_rng",
+        .bus            = &platform_bus_type,
+        .probe          = omap_rng_probe,
+        .remove         = __exit_p(omap_rng_remove),
+        .suspend        = omap_rng_suspend,
+        .resume         = omap_rng_resume
+};
+
+static int __init omap_rng_init(void)
+{
+        if (!cpu_is_omap16xx() && !cpu_is_omap24xx())
+                return -ENODEV;
+
+        return driver_register(&omap_rng_driver);
+}
+
+static void __exit omap_rng_exit(void)
+{
+        driver_unregister(&omap_rng_driver);
+}
+
+module_init(omap_rng_init);
+module_exit(omap_rng_exit);
+
+MODULE_AUTHOR("Deepak Saxena (and others)");
+MODULE_LICENSE("GPL");
diff --git a/drivers/char/hw_random/via-rng.c b/drivers/char/hw_random/via-rng.c
new file mode 100644
index 000000000000..0e786b617bb8
--- /dev/null
+++ b/drivers/char/hw_random/via-rng.c
@@ -0,0 +1,183 @@
+/*
+ * RNG driver for VIA RNGs
+ *
+ * Copyright 2005 (c) MontaVista Software, Inc.
+ *
+ * with the majority of the code coming from:
+ *
+ * Hardware driver for the Intel/AMD/VIA Random Number Generators (RNG)
+ * (c) Copyright 2003 Red Hat Inc <jgarzik@redhat.com>
+ *
+ * derived from
+ *
+ * Hardware driver for the AMD 768 Random Number Generator (RNG)
+ * (c) Copyright 2001 Red Hat Inc <alan@redhat.com>
+ *
+ * derived from
+ *
+ * Hardware driver for Intel i810 Random Number Generator (RNG)
+ * Copyright 2000,2001 Jeff Garzik <jgarzik@pobox.com>
+ * Copyright 2000,2001 Philipp Rumpf <prumpf@mandrakesoft.com>
+ *
+ * This file is licensed under  the terms of the GNU General Public
+ * License version 2. This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+#include <linux/module.h>
+#include <linux/kernel.h>
+#include <linux/pci.h>
+#include <linux/hw_random.h>
+#include <asm/io.h>
+#include <asm/msr.h>
+#include <asm/cpufeature.h>
+
+
+#define PFX     KBUILD_MODNAME ": "
+
+
+enum {
+        VIA_STRFILT_CNT_SHIFT   = 16,
+        VIA_STRFILT_FAIL        = (1 << 15),
+        VIA_STRFILT_ENABLE      = (1 << 14),
+        VIA_RAWBITS_ENABLE      = (1 << 13),
+        VIA_RNG_ENABLE          = (1 << 6),
+        VIA_XSTORE_CNT_MASK     = 0x0F,
+
+        VIA_RNG_CHUNK_8         = 0x00, /* 64 rand bits, 64 stored bits */
+        VIA_RNG_CHUNK_4         = 0x01, /* 32 rand bits, 32 stored bits */
+        VIA_RNG_CHUNK_4_MASK    = 0xFFFFFFFF,
+        VIA_RNG_CHUNK_2         = 0x02, /* 16 rand bits, 32 stored bits */
+        VIA_RNG_CHUNK_2_MASK    = 0xFFFF,
+        VIA_RNG_CHUNK_1         = 0x03, /* 8 rand bits, 32 stored bits */
+        VIA_RNG_CHUNK_1_MASK    = 0xFF,
+};
+
+/*
+ * Investigate using the 'rep' prefix to obtain 32 bits of random data
+ * in one insn.  The upside is potentially better performance.  The
+ * downside is that the instruction becomes no longer atomic.  Due to
+ * this, just like familiar issues with /dev/random itself, the worst
+ * case of a 'rep xstore' could potentially pause a cpu for an
+ * unreasonably long time.  In practice, this condition would likely
+ * only occur when the hardware is failing.  (or so we hope :))
+ *
+ * Another possible performance boost may come from simply buffering
+ * until we have 4 bytes, thus returning a u32 at a time,
+ * instead of the current u8-at-a-time.
+ */
+
+static inline u32 xstore(u32 *addr, u32 edx_in)
+{
+        u32 eax_out;
+
+        asm(".byte 0x0F,0xA7,0xC0 /* xstore %%edi (addr=%0) */"
+                :"=m"(*addr), "=a"(eax_out)
+                :"D"(addr), "d"(edx_in));
+
+        return eax_out;
+}
+
+static int via_rng_data_present(struct hwrng *rng)
+{
+        u32 bytes_out;
+        u32 *via_rng_datum = (u32 *)(&rng->priv);
+
+        /* We choose the recommended 1-byte-per-instruction RNG rate,
+         * for greater randomness at the expense of speed.  Larger
+         * values 2, 4, or 8 bytes-per-instruction yield greater
+         * speed at lesser randomness.
+         *
+         * If you change this to another VIA_CHUNK_n, you must also
+         * change the ->n_bytes values in rng_vendor_ops[] tables.
+         * VIA_CHUNK_8 requires further code changes.
+         *
+         * A copy of MSR_VIA_RNG is placed in eax_out when xstore
+         * completes.
+         */
+
+        *via_rng_datum = 0; /* paranoia, not really necessary */
+        bytes_out = xstore(via_rng_datum, VIA_RNG_CHUNK_1);
+        bytes_out &= VIA_XSTORE_CNT_MASK;
+        if (bytes_out == 0)
+                return 0;
+        return 1;
+}
+
+static int via_rng_data_read(struct hwrng *rng, u32 *data)
+{
+        u32 via_rng_datum = (u32)rng->priv;
+
+        *data = via_rng_datum;
+
+        return 1;
+}
+
+static int via_rng_init(struct hwrng *rng)
+{
+        u32 lo, hi, old_lo;
+
+        /* Control the RNG via MSR.  Tread lightly and pay very close
+         * close attention to values written, as the reserved fields
+         * are documented to be "undefined and unpredictable"; but it
+         * does not say to write them as zero, so I make a guess that
+         * we restore the values we find in the register.
+         */
+        rdmsr(MSR_VIA_RNG, lo, hi);
+
+        old_lo = lo;
+        lo &= ~(0x7f << VIA_STRFILT_CNT_SHIFT);
+        lo &= ~VIA_XSTORE_CNT_MASK;
+        lo &= ~(VIA_STRFILT_ENABLE | VIA_STRFILT_FAIL | VIA_RAWBITS_ENABLE);
+        lo |= VIA_RNG_ENABLE;
+
+        if (lo != old_lo)
+                wrmsr(MSR_VIA_RNG, lo, hi);
+
+        /* perhaps-unnecessary sanity check; remove after testing if
+           unneeded */
+        rdmsr(MSR_VIA_RNG, lo, hi);
+        if ((lo & VIA_RNG_ENABLE) == 0) {
+                printk(KERN_ERR PFX "cannot enable VIA C3 RNG, aborting\n");
+                return -ENODEV;
+        }
+
+        return 0;
+}
+
+
+static struct hwrng via_rng = {
+        .name           = "via",
+        .init           = via_rng_init,
+        .data_present   = via_rng_data_present,
+        .data_read      = via_rng_data_read,
+};
+
+
+static int __init mod_init(void)
+{
+        int err;
+
+        if (!cpu_has_xstore)
+                return -ENODEV;
+        printk(KERN_INFO "VIA RNG detected\n");
+        err = hwrng_register(&via_rng);
+        if (err) {
+                printk(KERN_ERR PFX "RNG registering failed (%d)\n",
+                       err);
+                goto out;
+        }
+out:
+        return err;
+}
+
+static void __exit mod_exit(void)
+{
+        hwrng_unregister(&via_rng);
+}
+
+subsys_initcall(mod_init);
+module_exit(mod_exit);
+
+MODULE_DESCRIPTION("H/W RNG driver for VIA chipsets");
+MODULE_LICENSE("GPL");
diff --git a/drivers/char/ip2/ip2main.c b/drivers/char/ip2/ip2main.c
index 03db1cb3fa95..9ab33c3d359f 100644
--- a/drivers/char/ip2/ip2main.c
+++ b/drivers/char/ip2/ip2main.c
@@ -305,7 +305,7 @@ static struct class *ip2_class;
 
 // Some functions to keep track of what irq's we have
 
-static int __init
+static int
 is_valid_irq(int irq)
 {
         int *i = Valid_Irqs;
@@ -316,14 +316,14 @@ is_valid_irq(int irq)
         return (*i);
 }
 
-static void __init
+static void
 mark_requested_irq( char irq )
 {
         rirqs[iindx++] = irq;
 }
 
 #ifdef MODULE
-static int __init
+static int
 clear_requested_irq( char irq )
 {
         int i;
@@ -337,7 +337,7 @@ clear_requested_irq( char irq )
 }
 #endif
 
-static int __init
+static int
 have_requested_irq( char irq )
 {
         // array init to zeros so 0 irq will not be requested as a side effect
@@ -818,7 +818,7 @@ EXPORT_SYMBOL(ip2_loadmain);
 /* the board, the channel structures are initialized, and the board details   */
 /* are reported on the console.                                               */
 /******************************************************************************/
-static void __init
+static void
 ip2_init_board( int boardnum )
 {
         int i;
@@ -961,7 +961,7 @@ err_initialize:
 /* EISA motherboard, or no valid board ID is selected it returns 0. Otherwise */
 /* it returns the base address of the controller.                             */
 /******************************************************************************/
-static unsigned short __init
+static unsigned short
 find_eisa_board( int start_slot )
 {
         int i, j;
diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
index 9f2f8fdec69a..ad26f4b997c5 100644
--- a/drivers/char/ipmi/ipmi_msghandler.c
+++ b/drivers/char/ipmi/ipmi_msghandler.c
@@ -57,8 +57,7 @@ static int ipmi_init_msghandler(void);
 static int initialized = 0;
 
 #ifdef CONFIG_PROC_FS
-struct proc_dir_entry *proc_ipmi_root = NULL;
-EXPORT_SYMBOL(proc_ipmi_root);
+static struct proc_dir_entry *proc_ipmi_root = NULL;
 #endif /* CONFIG_PROC_FS */
 
 #define MAX_EVENTS_IN_QUEUE     25
@@ -936,11 +935,8 @@ int ipmi_set_gets_events(ipmi_user_t user, int val)
 
         if (val) {
                 /* Deliver any queued events. */
-                list_for_each_entry_safe(msg, msg2, &intf->waiting_events,
-                                         link) {
-                        list_del(&msg->link);
-                        list_add_tail(&msg->link, &msgs);
-                }
+                list_for_each_entry_safe(msg, msg2, &intf->waiting_events, link)
+                        list_move_tail(&msg->link, &msgs);
                 intf->waiting_events_count = 0;
         }
 
@@ -3677,7 +3673,7 @@ static void send_panic_events(char *str)
 }
 #endif /* CONFIG_IPMI_PANIC_EVENT */
 
-static int has_paniced = 0;
+static int has_panicked = 0;
 
 static int panic_event(struct notifier_block *this,
                        unsigned long         event,
@@ -3686,9 +3682,9 @@ static int panic_event(struct notifier_block *this,
         int        i;
         ipmi_smi_t intf;
 
-        if (has_paniced)
+        if (has_panicked)
                 return NOTIFY_DONE;
-        has_paniced = 1;
+        has_panicked = 1;
 
         /* For every registered interface, set it to run to completion. */
         for (i = 0; i < MAX_IPMI_INTERFACES; i++) {
@@ -3742,11 +3738,8 @@ static int ipmi_init_msghandler(void)
         proc_ipmi_root->owner = THIS_MODULE;
 #endif /* CONFIG_PROC_FS */
 
-        init_timer(&ipmi_timer);
-        ipmi_timer.data = 0;
-        ipmi_timer.function = ipmi_timeout;
-        ipmi_timer.expires = jiffies + IPMI_TIMEOUT_JIFFIES;
-        add_timer(&ipmi_timer);
+        setup_timer(&ipmi_timer, ipmi_timeout, 0);
+        mod_timer(&ipmi_timer, jiffies + IPMI_TIMEOUT_JIFFIES);
 
         atomic_notifier_chain_register(&panic_notifier_list, &panic_block);
 
diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index 02a7dd7a8a55..bd4f2248b758 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -55,23 +55,6 @@
 #include <linux/mutex.h>
 #include <linux/kthread.h>
 #include <asm/irq.h>
-#ifdef CONFIG_HIGH_RES_TIMERS
-#include <linux/hrtime.h>
-# if defined(schedule_next_int)
-/* Old high-res timer code, do translations. */
-#  define get_arch_cycles(a) quick_update_jiffies_sub(a)
-#  define arch_cycles_per_jiffy cycles_per_jiffies
-# endif
-static inline void add_usec_to_timer(struct timer_list *t, long v)
-{
-        t->arch_cycle_expires += nsec_to_arch_cycle(v * 1000);
-        while (t->arch_cycle_expires >= arch_cycles_per_jiffy)
-        {
-                t->expires++;
-                t->arch_cycle_expires -= arch_cycles_per_jiffy;
-        }
-}
-#endif
 #include <linux/interrupt.h>
 #include <linux/rcupdate.h>
 #include <linux/ipmi_smi.h>
@@ -243,8 +226,6 @@ static int register_xaction_notifier(struct notifier_block * nb)
         return atomic_notifier_chain_register(&xaction_notifier_list, nb);
 }
 
-static void si_restart_short_timer(struct smi_info *smi_info);
-
 static void deliver_recv_msg(struct smi_info *smi_info,
                              struct ipmi_smi_msg *msg)
 {
@@ -768,7 +749,6 @@ static void sender(void                *send_info,
             && (smi_info->curr_msg == NULL))
         {
                 start_next_msg(smi_info);
-                si_restart_short_timer(smi_info);
         }
         spin_unlock_irqrestore(&(smi_info->si_lock), flags);
 }
@@ -809,7 +789,7 @@ static int ipmi_thread(void *data)
                         /* do nothing */
                 }
                 else if (smi_result == SI_SM_CALL_WITH_DELAY)
-                        udelay(1);
+                        schedule();
                 else
                         schedule_timeout_interruptible(1);
         }
@@ -833,37 +813,6 @@ static void request_events(void *send_info)
 
 static int initialized = 0;
 
-/* Must be called with interrupts off and with the si_lock held. */
-static void si_restart_short_timer(struct smi_info *smi_info)
-{
-#if defined(CONFIG_HIGH_RES_TIMERS)
-        unsigned long flags;
-        unsigned long jiffies_now;
-        unsigned long seq;
-
-        if (del_timer(&(smi_info->si_timer))) {
-                /* If we don't delete the timer, then it will go off
-                   immediately, anyway.  So we only process if we
-                   actually delete the timer. */
-
-                do {
-                        seq = read_seqbegin_irqsave(&xtime_lock, flags);
-                        jiffies_now = jiffies;
-                        smi_info->si_timer.expires = jiffies_now;
-                        smi_info->si_timer.arch_cycle_expires
-                                = get_arch_cycles(jiffies_now);
-                } while (read_seqretry_irqrestore(&xtime_lock, seq, flags));
-
-                add_usec_to_timer(&smi_info->si_timer, SI_SHORT_TIMEOUT_USEC);
-
-                add_timer(&(smi_info->si_timer));
-                spin_lock_irqsave(&smi_info->count_lock, flags);
-                smi_info->timeout_restarts++;
-                spin_unlock_irqrestore(&smi_info->count_lock, flags);
-        }
-#endif
-}
-
 static void smi_timeout(unsigned long data)
 {
         struct smi_info   *smi_info = (struct smi_info *) data;
@@ -904,31 +853,15 @@ static void smi_timeout(unsigned long data)
         /* If the state machine asks for a short delay, then shorten
            the timer timeout. */
         if (smi_result == SI_SM_CALL_WITH_DELAY) {
-#if defined(CONFIG_HIGH_RES_TIMERS)
-                unsigned long seq;
-#endif
                 spin_lock_irqsave(&smi_info->count_lock, flags);
                 smi_info->short_timeouts++;
                 spin_unlock_irqrestore(&smi_info->count_lock, flags);
-#if defined(CONFIG_HIGH_RES_TIMERS)
-                do {
-                        seq = read_seqbegin_irqsave(&xtime_lock, flags);
-                        smi_info->si_timer.expires = jiffies;
-                        smi_info->si_timer.arch_cycle_expires
-                                = get_arch_cycles(smi_info->si_timer.expires);
-                } while (read_seqretry_irqrestore(&xtime_lock, seq, flags));
-                add_usec_to_timer(&smi_info->si_timer, SI_SHORT_TIMEOUT_USEC);
-#else
                 smi_info->si_timer.expires = jiffies + 1;
-#endif
         } else {
                 spin_lock_irqsave(&smi_info->count_lock, flags);
                 smi_info->long_timeouts++;
                 spin_unlock_irqrestore(&smi_info->count_lock, flags);
                 smi_info->si_timer.expires = jiffies + SI_TIMEOUT_JIFFIES;
-#if defined(CONFIG_HIGH_RES_TIMERS)
-                smi_info->si_timer.arch_cycle_expires = 0;
-#endif
         }
 
  do_add_timer:
diff --git a/drivers/char/ipmi/ipmi_watchdog.c b/drivers/char/ipmi/ipmi_watchdog.c
index 2d11ddd99e55..1a0a19c53605 100644
--- a/drivers/char/ipmi/ipmi_watchdog.c
+++ b/drivers/char/ipmi/ipmi_watchdog.c
@@ -212,24 +212,16 @@ static int set_param_str(const char *val, struct kernel_param *kp)
 {
         action_fn  fn = (action_fn) kp->arg;
         int        rv = 0;
-        const char *end;
-        char       valcp[16];
-        int        len;
-
-        /* Truncate leading and trailing spaces. */
-        while (isspace(*val))
-                val++;
-        end = val + strlen(val) - 1;
-        while ((end >= val) && isspace(*end))
-                end--;
-        len = end - val + 1;
-        if (len > sizeof(valcp) - 1)
-                return -EINVAL;
-        memcpy(valcp, val, len);
-        valcp[len] = '\0';
+        char       *dup, *s;
+
+        dup = kstrdup(val, GFP_KERNEL);
+        if (!dup)
+                return -ENOMEM;
+
+        s = strstrip(dup);
 
         down_read(&register_sem);
-        rv = fn(valcp, NULL);
+        rv = fn(s, NULL);
         if (rv)
                 goto out_unlock;
 
@@ -239,6 +231,7 @@ static int set_param_str(const char *val, struct kernel_param *kp)
 
  out_unlock:
         up_read(&register_sem);
+        kfree(dup);
         return rv;
 }
 
@@ -956,9 +949,10 @@ static int wdog_reboot_handler(struct notifier_block *this,
                         /* Disable the WDT if we are shutting down. */
                         ipmi_watchdog_state = WDOG_TIMEOUT_NONE;
                         panic_halt_ipmi_set_timeout();
-                } else {
+                } else if (ipmi_watchdog_state != WDOG_TIMEOUT_NONE) {
                         /* Set a long timer to let the reboot happens, but
-                           reboot if it hangs. */
+                           reboot if it hangs, but only if the watchdog
+                           timer was already running. */
                         timeout = 120;
                         pretimeout = 0;
                         ipmi_watchdog_state = WDOG_TIMEOUT_RESET;
@@ -980,16 +974,17 @@ static int wdog_panic_handler(struct notifier_block *this,
 {
         static int panic_event_handled = 0;
 
-        /* On a panic, if we have a panic timeout, make sure that the thing
-           reboots, even if it hangs during that panic. */
-        if (watchdog_user && !panic_event_handled) {
-                /* Make sure the panic doesn't hang, and make sure we
-                   do this only once. */
+        /* On a panic, if we have a panic timeout, make sure to extend
+           the watchdog timer to a reasonable value to complete the
+           panic, if the watchdog timer is running.  Plus the
+           pretimeout is meaningless at panic time. */
+        if (watchdog_user && !panic_event_handled &&
+            ipmi_watchdog_state != WDOG_TIMEOUT_NONE) {
+                /* Make sure we do this only once. */
                 panic_event_handled = 1;
             
                 timeout = 255;
                 pretimeout = 0;
-                ipmi_watchdog_state = WDOG_TIMEOUT_RESET;
                 panic_halt_ipmi_set_timeout();
         }
 
diff --git a/drivers/char/isicom.c b/drivers/char/isicom.c
index e9ebabaf8cb0..efaaa1937ab6 100644
--- a/drivers/char/isicom.c
+++ b/drivers/char/isicom.c
@@ -1145,7 +1145,7 @@ static int isicom_write(struct tty_struct *tty,	const unsigned char *buf,
         if (isicom_paranoia_check(port, tty->name, "isicom_write"))
                 return 0;
 
-        if (!tty || !port->xmit_buf)
+        if (!port->xmit_buf)
                 return 0;
 
         spin_lock_irqsave(&card->card_lock, flags);
@@ -1180,7 +1180,7 @@ static void isicom_put_char(struct tty_struct *tty, unsigned char ch)
         if (isicom_paranoia_check(port, tty->name, "isicom_put_char"))
                 return;
 
-        if (!tty || !port->xmit_buf)
+        if (!port->xmit_buf)
                 return;
 
         spin_lock_irqsave(&card->card_lock, flags);
diff --git a/drivers/char/istallion.c b/drivers/char/istallion.c
index ef20c1fc9c4c..216c79256de3 100644
--- a/drivers/char/istallion.c
+++ b/drivers/char/istallion.c
@@ -42,13 +42,12 @@
 #include <linux/devfs_fs_kernel.h>
 #include <linux/device.h>
 #include <linux/wait.h>
+#include <linux/eisa.h>
 
 #include <asm/io.h>
 #include <asm/uaccess.h>
 
-#ifdef CONFIG_PCI
 #include <linux/pci.h>
-#endif
 
 /*****************************************************************************/
 
@@ -137,6 +136,10 @@ static stlconf_t	stli_brdconf[] = {
 
 static int      stli_nrbrds = ARRAY_SIZE(stli_brdconf);
 
+/* stli_lock must NOT be taken holding brd_lock */
+static spinlock_t stli_lock;    /* TTY logic lock */
+static spinlock_t brd_lock;     /* Board logic lock */
+
 /*
  *      There is some experimental EISA board detection code in this driver.
  *      By default it is disabled, but for those that want to try it out,
@@ -173,14 +176,6 @@ static char	*stli_serialname = "ttyE";
 
 static struct tty_driver        *stli_serial;
 
-/*
- *      We will need to allocate a temporary write buffer for chars that
- *      come direct from user space. The problem is that a copy from user
- *      space might cause a page fault (typically on a system that is
- *      swapping!). All ports will share one buffer - since if the system
- *      is already swapping a shared buffer won't make things any worse.
- */
-static char                     *stli_tmpwritebuf;
 
 #define STLI_TXBUFSIZE          4096
 
@@ -419,7 +414,7 @@ static int	stli_eisamempsize = ARRAY_SIZE(stli_eisamemprobeaddrs);
 #endif
 
 static struct pci_device_id istallion_pci_tbl[] = {
-        { PCI_VENDOR_ID_STALLION, PCI_DEVICE_ID_ECRA, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
+        { PCI_DEVICE(PCI_VENDOR_ID_STALLION, PCI_DEVICE_ID_ECRA), },
         { 0 }
 };
 MODULE_DEVICE_TABLE(pci, istallion_pci_tbl);
@@ -682,7 +677,7 @@ static int	stli_startbrd(stlibrd_t *brdp);
 static ssize_t  stli_memread(struct file *fp, char __user *buf, size_t count, loff_t *offp);
 static ssize_t  stli_memwrite(struct file *fp, const char __user *buf, size_t count, loff_t *offp);
 static int      stli_memioctl(struct inode *ip, struct file *fp, unsigned int cmd, unsigned long arg);
-static void     stli_brdpoll(stlibrd_t *brdp, volatile cdkhdr_t *hdrp);
+static void     stli_brdpoll(stlibrd_t *brdp, cdkhdr_t __iomem *hdrp);
 static void     stli_poll(unsigned long arg);
 static int      stli_hostcmd(stlibrd_t *brdp, stliport_t *portp);
 static int      stli_initopen(stlibrd_t *brdp, stliport_t *portp);
@@ -693,7 +688,8 @@ static void	stli_dohangup(void *arg);
 static int      stli_setport(stliport_t *portp);
 static int      stli_cmdwait(stlibrd_t *brdp, stliport_t *portp, unsigned long cmd, void *arg, int size, int copyback);
 static void     stli_sendcmd(stlibrd_t *brdp, stliport_t *portp, unsigned long cmd, void *arg, int size, int copyback);
-static void     stli_dodelaycmd(stliport_t *portp, volatile cdkctrl_t *cp);
+static void     __stli_sendcmd(stlibrd_t *brdp, stliport_t *portp, unsigned long cmd, void *arg, int size, int copyback);
+static void     stli_dodelaycmd(stliport_t *portp, cdkctrl_t __iomem *cp);
 static void     stli_mkasyport(stliport_t *portp, asyport_t *pp, struct termios *tiosp);
 static void     stli_mkasysigs(asysigs_t *sp, int dtr, int rts);
 static long     stli_mktiocm(unsigned long sigvalue);
@@ -799,18 +795,8 @@ static struct class *istallion_class;
 
 static int __init istallion_module_init(void)
 {
-        unsigned long   flags;
-
-#ifdef DEBUG
-        printk("init_module()\n");
-#endif
-
-        save_flags(flags);
-        cli();
         stli_init();
-        restore_flags(flags);
-
-        return(0);
+        return 0;
 }
 
 /*****************************************************************************/
@@ -819,33 +805,24 @@ static void __exit istallion_module_exit(void)
 {
         stlibrd_t       *brdp;
         stliport_t      *portp;
-        unsigned long   flags;
         int             i, j;
 
-#ifdef DEBUG
-        printk("cleanup_module()\n");
-#endif
-
         printk(KERN_INFO "Unloading %s: version %s\n", stli_drvtitle,
                 stli_drvversion);
 
-        save_flags(flags);
-        cli();
-
-/*
- *      Free up all allocated resources used by the ports. This includes
- *      memory and interrupts.
- */
+        /*
+         *      Free up all allocated resources used by the ports. This includes
+         *      memory and interrupts.
+         */
         if (stli_timeron) {
                 stli_timeron = 0;
-                del_timer(&stli_timerlist);
+                del_timer_sync(&stli_timerlist);
         }
 
         i = tty_unregister_driver(stli_serial);
         if (i) {
                 printk("STALLION: failed to un-register tty driver, "
                         "errno=%d\n", -i);
-                restore_flags(flags);
                 return;
         }
         put_tty_driver(stli_serial);
@@ -859,16 +836,15 @@ static void __exit istallion_module_exit(void)
                 printk("STALLION: failed to un-register serial memory device, "
                         "errno=%d\n", -i);
 
-        kfree(stli_tmpwritebuf);
         kfree(stli_txcookbuf);
 
         for (i = 0; (i < stli_nrbrds); i++) {
-                if ((brdp = stli_brds[i]) == (stlibrd_t *) NULL)
+                if ((brdp = stli_brds[i]) == NULL)
                         continue;
                 for (j = 0; (j < STL_MAXPORTS); j++) {
                         portp = brdp->ports[j];
-                        if (portp != (stliport_t *) NULL) {
-                                if (portp->tty != (struct tty_struct *) NULL)
+                        if (portp != NULL) {
+                                if (portp->tty != NULL)
                                         tty_hangup(portp->tty);
                                 kfree(portp);
                         }
@@ -878,10 +854,8 @@ static void __exit istallion_module_exit(void)
                 if (brdp->iosize > 0)
                         release_region(brdp->iobase, brdp->iosize);
                 kfree(brdp);
-                stli_brds[i] = (stlibrd_t *) NULL;
+                stli_brds[i] = NULL;
         }
-
-        restore_flags(flags);
 }
 
 module_init(istallion_module_init);
@@ -895,19 +869,15 @@ module_exit(istallion_module_exit);
 
 static void stli_argbrds(void)
 {
-        stlconf_t       conf;
-        stlibrd_t       *brdp;
-        int             i;
-
-#ifdef DEBUG
-        printk("stli_argbrds()\n");
-#endif
+        stlconf_t conf;
+        stlibrd_t *brdp;
+        int i;
 
         for (i = stli_nrbrds; i < ARRAY_SIZE(stli_brdsp); i++) {
                 memset(&conf, 0, sizeof(conf));
                 if (stli_parsebrd(&conf, stli_brdsp[i]) == 0)
                         continue;
-                if ((brdp = stli_allocbrd()) == (stlibrd_t *) NULL)
+                if ((brdp = stli_allocbrd()) == NULL)
                         continue;
                 stli_nrbrds = i + 1;
                 brdp->brdnr = i;
@@ -926,9 +896,9 @@ static void stli_argbrds(void)
 
 static unsigned long stli_atol(char *str)
 {
-        unsigned long   val;
-        int             base, c;
-        char            *sp;
+        unsigned long val;
+        int base, c;
+        char *sp;
 
         val = 0;
         sp = str;
@@ -962,15 +932,11 @@ static unsigned long stli_atol(char *str)
 
 static int stli_parsebrd(stlconf_t *confp, char **argp)
 {
-        char    *sp;
-        int     i;
-
-#ifdef DEBUG
-        printk("stli_parsebrd(confp=%x,argp=%x)\n", (int) confp, (int) argp);
-#endif
+        char *sp;
+        int i;
 
-        if ((argp[0] == (char *) NULL) || (*argp[0] == 0))
-                return(0);
+        if (argp[0] == NULL || *argp[0] == 0)
+                return 0;
 
         for (sp = argp[0], i = 0; ((*sp != 0) && (i < 25)); sp++, i++)
                 *sp = TOLOWER(*sp);
@@ -985,9 +951,9 @@ static int stli_parsebrd(stlconf_t *confp, char **argp)
         }
 
         confp->brdtype = stli_brdstr[i].type;
-        if ((argp[1] != (char *) NULL) && (*argp[1] != 0))
+        if (argp[1] != NULL && *argp[1] != 0)
                 confp->ioaddr1 = stli_atol(argp[1]);
-        if ((argp[2] != (char *) NULL) && (*argp[2] != 0))
+        if (argp[2] !=  NULL && *argp[2] != 0)
                 confp->memaddr = stli_atol(argp[2]);
         return(1);
 }
@@ -998,34 +964,29 @@ static int stli_parsebrd(stlconf_t *confp, char **argp)
 
 static int stli_open(struct tty_struct *tty, struct file *filp)
 {
-        stlibrd_t       *brdp;
-        stliport_t      *portp;
-        unsigned int    minordev;
-        int             brdnr, portnr, rc;
-
-#ifdef DEBUG
-        printk("stli_open(tty=%x,filp=%x): device=%s\n", (int) tty,
-                (int) filp, tty->name);
-#endif
+        stlibrd_t *brdp;
+        stliport_t *portp;
+        unsigned int minordev;
+        int brdnr, portnr, rc;
 
         minordev = tty->index;
         brdnr = MINOR2BRD(minordev);
         if (brdnr >= stli_nrbrds)
-                return(-ENODEV);
+                return -ENODEV;
         brdp = stli_brds[brdnr];
-        if (brdp == (stlibrd_t *) NULL)
-                return(-ENODEV);
+        if (brdp == NULL)
+                return -ENODEV;
         if ((brdp->state & BST_STARTED) == 0)
-                return(-ENODEV);
+                return -ENODEV;
         portnr = MINOR2PORT(minordev);
         if ((portnr < 0) || (portnr > brdp->nrports))
-                return(-ENODEV);
+                return -ENODEV;
 
         portp = brdp->ports[portnr];
-        if (portp == (stliport_t *) NULL)
-                return(-ENODEV);
+        if (portp == NULL)
+                return -ENODEV;
         if (portp->devnr < 1)
-                return(-ENODEV);
+                return -ENODEV;
 
 
 /*
@@ -1037,8 +998,8 @@ static int stli_open(struct tty_struct *tty, struct file *filp)
         if (portp->flags & ASYNC_CLOSING) {
                 interruptible_sleep_on(&portp->close_wait);
                 if (portp->flags & ASYNC_HUP_NOTIFY)
-                        return(-EAGAIN);
-                return(-ERESTARTSYS);
+                        return -EAGAIN;
+                return -ERESTARTSYS;
         }
 
 /*
@@ -1054,7 +1015,7 @@ static int stli_open(struct tty_struct *tty, struct file *filp)
         wait_event_interruptible(portp->raw_wait,
                         !test_bit(ST_INITIALIZING, &portp->state));
         if (signal_pending(current))
-                return(-ERESTARTSYS);
+                return -ERESTARTSYS;
 
         if ((portp->flags & ASYNC_INITIALIZED) == 0) {
                 set_bit(ST_INITIALIZING, &portp->state);
@@ -1065,7 +1026,7 @@ static int stli_open(struct tty_struct *tty, struct file *filp)
                 clear_bit(ST_INITIALIZING, &portp->state);
                 wake_up_interruptible(&portp->raw_wait);
                 if (rc < 0)
-                        return(rc);
+                        return rc;
         }
 
 /*
@@ -1077,8 +1038,8 @@ static int stli_open(struct tty_struct *tty, struct file *filp)
         if (portp->flags & ASYNC_CLOSING) {
                 interruptible_sleep_on(&portp->close_wait);
                 if (portp->flags & ASYNC_HUP_NOTIFY)
-                        return(-EAGAIN);
-                return(-ERESTARTSYS);
+                        return -EAGAIN;
+                return -ERESTARTSYS;
         }
 
 /*
@@ -1088,38 +1049,33 @@ static int stli_open(struct tty_struct *tty, struct file *filp)
  */
         if (!(filp->f_flags & O_NONBLOCK)) {
                 if ((rc = stli_waitcarrier(brdp, portp, filp)) != 0)
-                        return(rc);
+                        return rc;
         }
         portp->flags |= ASYNC_NORMAL_ACTIVE;
-        return(0);
+        return 0;
 }
 
 /*****************************************************************************/
 
 static void stli_close(struct tty_struct *tty, struct file *filp)
 {
-        stlibrd_t       *brdp;
-        stliport_t      *portp;
-        unsigned long   flags;
-
-#ifdef DEBUG
-        printk("stli_close(tty=%x,filp=%x)\n", (int) tty, (int) filp);
-#endif
+        stlibrd_t *brdp;
+        stliport_t *portp;
+        unsigned long flags;
 
         portp = tty->driver_data;
-        if (portp == (stliport_t *) NULL)
+        if (portp == NULL)
                 return;
 
-        save_flags(flags);
-        cli();
+        spin_lock_irqsave(&stli_lock, flags);
         if (tty_hung_up_p(filp)) {
-                restore_flags(flags);
+                spin_unlock_irqrestore(&stli_lock, flags);
                 return;
         }
         if ((tty->count == 1) && (portp->refcount != 1))
                 portp->refcount = 1;
         if (portp->refcount-- > 1) {
-                restore_flags(flags);
+                spin_unlock_irqrestore(&stli_lock, flags);
                 return;
         }
 
@@ -1134,6 +1090,8 @@ static void stli_close(struct tty_struct *tty, struct file *filp)
         if (tty == stli_txcooktty)
                 stli_flushchars(tty);
         tty->closing = 1;
+        spin_unlock_irqrestore(&stli_lock, flags);
+
         if (portp->closing_wait != ASYNC_CLOSING_WAIT_NONE)
                 tty_wait_until_sent(tty, portp->closing_wait);
 
@@ -1157,7 +1115,7 @@ static void stli_close(struct tty_struct *tty, struct file *filp)
         stli_flushbuffer(tty);
 
         tty->closing = 0;
-        portp->tty = (struct tty_struct *) NULL;
+        portp->tty = NULL;
 
         if (portp->openwaitcnt) {
                 if (portp->close_delay)
@@ -1167,7 +1125,6 @@ static void stli_close(struct tty_struct *tty, struct file *filp)
 
         portp->flags &= ~(ASYNC_NORMAL_ACTIVE|ASYNC_CLOSING);
         wake_up_interruptible(&portp->close_wait);
-        restore_flags(flags);
 }
 
 /*****************************************************************************/
@@ -1182,45 +1139,41 @@ static void stli_close(struct tty_struct *tty, struct file *filp)
 
 static int stli_initopen(stlibrd_t *brdp, stliport_t *portp)
 {
-        struct tty_struct       *tty;
-        asynotify_t             nt;
-        asyport_t               aport;
-        int                     rc;
-
-#ifdef DEBUG
-        printk("stli_initopen(brdp=%x,portp=%x)\n", (int) brdp, (int) portp);
-#endif
+        struct tty_struct *tty;
+        asynotify_t nt;
+        asyport_t aport;
+        int rc;
 
         if ((rc = stli_rawopen(brdp, portp, 0, 1)) < 0)
-                return(rc);
+                return rc;
 
         memset(&nt, 0, sizeof(asynotify_t));
         nt.data = (DT_TXLOW | DT_TXEMPTY | DT_RXBUSY | DT_RXBREAK);
         nt.signal = SG_DCD;
         if ((rc = stli_cmdwait(brdp, portp, A_SETNOTIFY, &nt,
             sizeof(asynotify_t), 0)) < 0)
-                return(rc);
+                return rc;
 
         tty = portp->tty;
-        if (tty == (struct tty_struct *) NULL)
-                return(-ENODEV);
+        if (tty == NULL)
+                return -ENODEV;
         stli_mkasyport(portp, &aport, tty->termios);
         if ((rc = stli_cmdwait(brdp, portp, A_SETPORT, &aport,
             sizeof(asyport_t), 0)) < 0)
-                return(rc);
+                return rc;
 
         set_bit(ST_GETSIGS, &portp->state);
         if ((rc = stli_cmdwait(brdp, portp, A_GETSIGNALS, &portp->asig,
             sizeof(asysigs_t), 1)) < 0)
-                return(rc);
+                return rc;
         if (test_and_clear_bit(ST_GETSIGS, &portp->state))
                 portp->sigs = stli_mktiocm(portp->asig.sigvalue);
         stli_mkasysigs(&portp->asig, 1, 1);
         if ((rc = stli_cmdwait(brdp, portp, A_SETSIGNALS, &portp->asig,
             sizeof(asysigs_t), 0)) < 0)
-                return(rc);
+                return rc;
 
-        return(0);
+        return 0;
 }
 
 /*****************************************************************************/
@@ -1234,22 +1187,15 @@ static int stli_initopen(stlibrd_t *brdp, stliport_t *portp)
 
 static int stli_rawopen(stlibrd_t *brdp, stliport_t *portp, unsigned long arg, int wait)
 {
-        volatile cdkhdr_t       *hdrp;
-        volatile cdkctrl_t      *cp;
-        volatile unsigned char  *bits;
-        unsigned long           flags;
-        int                     rc;
-
-#ifdef DEBUG
-        printk("stli_rawopen(brdp=%x,portp=%x,arg=%x,wait=%d)\n",
-                (int) brdp, (int) portp, (int) arg, wait);
-#endif
+        cdkhdr_t __iomem *hdrp;
+        cdkctrl_t __iomem *cp;
+        unsigned char __iomem *bits;
+        unsigned long flags;
+        int rc;
 
 /*
  *      Send a message to the slave to open this port.
  */
-        save_flags(flags);
-        cli();
 
 /*
  *      Slave is already closing this port. This can happen if a hangup
@@ -1260,7 +1206,6 @@ static int stli_rawopen(stlibrd_t *brdp, stliport_t *portp, unsigned long arg, i
         wait_event_interruptible(portp->raw_wait,
                         !test_bit(ST_CLOSING, &portp->state));
         if (signal_pending(current)) {
-                restore_flags(flags);
                 return -ERESTARTSYS;
         }
 
@@ -1269,19 +1214,20 @@ static int stli_rawopen(stlibrd_t *brdp, stliport_t *portp, unsigned long arg, i
  *      memory. Once the message is in set the service bits to say that
  *      this port wants service.
  */
+        spin_lock_irqsave(&brd_lock, flags);
         EBRDENABLE(brdp);
-        cp = &((volatile cdkasy_t *) EBRDGETMEMPTR(brdp, portp->addr))->ctrl;
-        cp->openarg = arg;
-        cp->open = 1;
-        hdrp = (volatile cdkhdr_t *) EBRDGETMEMPTR(brdp, CDK_CDKADDR);
-        bits = ((volatile unsigned char *) hdrp) + brdp->slaveoffset +
+        cp = &((cdkasy_t __iomem *) EBRDGETMEMPTR(brdp, portp->addr))->ctrl;
+        writel(arg, &cp->openarg);
+        writeb(1, &cp->open);
+        hdrp = (cdkhdr_t __iomem *) EBRDGETMEMPTR(brdp, CDK_CDKADDR);
+        bits = ((unsigned char __iomem *) hdrp) + brdp->slaveoffset +
                 portp->portidx;
-        *bits |= portp->portbit;
+        writeb(readb(bits) | portp->portbit, bits);
         EBRDDISABLE(brdp);
 
         if (wait == 0) {
-                restore_flags(flags);
-                return(0);
+                spin_unlock_irqrestore(&brd_lock, flags);
+                return 0;
         }
 
 /*
@@ -1290,15 +1236,16 @@ static int stli_rawopen(stlibrd_t *brdp, stliport_t *portp, unsigned long arg, i
  */
         rc = 0;
         set_bit(ST_OPENING, &portp->state);
+        spin_unlock_irqrestore(&brd_lock, flags);
+
         wait_event_interruptible(portp->raw_wait,
                         !test_bit(ST_OPENING, &portp->state));
         if (signal_pending(current))
                 rc = -ERESTARTSYS;
-        restore_flags(flags);
 
         if ((rc == 0) && (portp->rc != 0))
                 rc = -EIO;
-        return(rc);
+        return rc;
 }
 
 /*****************************************************************************/
@@ -1311,19 +1258,11 @@ static int stli_rawopen(stlibrd_t *brdp, stliport_t *portp, unsigned long arg, i
 
 static int stli_rawclose(stlibrd_t *brdp, stliport_t *portp, unsigned long arg, int wait)
 {
-        volatile cdkhdr_t       *hdrp;
-        volatile cdkctrl_t      *cp;
-        volatile unsigned char  *bits;
-        unsigned long           flags;
-        int                     rc;
-
-#ifdef DEBUG
-        printk("stli_rawclose(brdp=%x,portp=%x,arg=%x,wait=%d)\n",
-                (int) brdp, (int) portp, (int) arg, wait);
-#endif
-
-        save_flags(flags);
-        cli();
+        cdkhdr_t __iomem *hdrp;
+        cdkctrl_t __iomem *cp;
+        unsigned char __iomem *bits;
+        unsigned long flags;
+        int rc;
 
 /*
  *      Slave is already closing this port. This can happen if a hangup
@@ -1333,7 +1272,6 @@ static int stli_rawclose(stlibrd_t *brdp, stliport_t *portp, unsigned long arg,
                 wait_event_interruptible(portp->raw_wait,
                                 !test_bit(ST_CLOSING, &portp->state));
                 if (signal_pending(current)) {
-                        restore_flags(flags);
                         return -ERESTARTSYS;
                 }
         }
@@ -1341,21 +1279,22 @@ static int stli_rawclose(stlibrd_t *brdp, stliport_t *portp, unsigned long arg,
 /*
  *      Write the close command into shared memory.
  */
+        spin_lock_irqsave(&brd_lock, flags);
         EBRDENABLE(brdp);
-        cp = &((volatile cdkasy_t *) EBRDGETMEMPTR(brdp, portp->addr))->ctrl;
-        cp->closearg = arg;
-        cp->close = 1;
-        hdrp = (volatile cdkhdr_t *) EBRDGETMEMPTR(brdp, CDK_CDKADDR);
-        bits = ((volatile unsigned char *) hdrp) + brdp->slaveoffset +
+        cp = &((cdkasy_t __iomem *) EBRDGETMEMPTR(brdp, portp->addr))->ctrl;
+        writel(arg, &cp->closearg);
+        writeb(1, &cp->close);
+        hdrp = (cdkhdr_t __iomem *) EBRDGETMEMPTR(brdp, CDK_CDKADDR);
+        bits = ((unsigned char __iomem *) hdrp) + brdp->slaveoffset +
                 portp->portidx;
-        *bits |= portp->portbit;
+        writeb(readb(bits) |portp->portbit, bits);
         EBRDDISABLE(brdp);
 
         set_bit(ST_CLOSING, &portp->state);
-        if (wait == 0) {
-                restore_flags(flags);
-                return(0);
-        }
+        spin_unlock_irqrestore(&brd_lock, flags);
+
+        if (wait == 0)
+                return 0;
 
 /*
  *      Slave is in action, so now we must wait for the open acknowledgment
@@ -1366,11 +1305,10 @@ static int stli_rawclose(stlibrd_t *brdp, stliport_t *portp, unsigned long arg,
                         !test_bit(ST_CLOSING, &portp->state));
         if (signal_pending(current))
                 rc = -ERESTARTSYS;
-        restore_flags(flags);
 
         if ((rc == 0) && (portp->rc != 0))
                 rc = -EIO;
-        return(rc);
+        return rc;
 }
 
 /*****************************************************************************/
@@ -1384,36 +1322,21 @@ static int stli_rawclose(stlibrd_t *brdp, stliport_t *portp, unsigned long arg,
 
 static int stli_cmdwait(stlibrd_t *brdp, stliport_t *portp, unsigned long cmd, void *arg, int size, int copyback)
 {
-        unsigned long   flags;
-
-#ifdef DEBUG
-        printk("stli_cmdwait(brdp=%x,portp=%x,cmd=%x,arg=%x,size=%d,"
-                "copyback=%d)\n", (int) brdp, (int) portp, (int) cmd,
-                (int) arg, size, copyback);
-#endif
-
-        save_flags(flags);
-        cli();
         wait_event_interruptible(portp->raw_wait,
                         !test_bit(ST_CMDING, &portp->state));
-        if (signal_pending(current)) {
-                restore_flags(flags);
+        if (signal_pending(current))
                 return -ERESTARTSYS;
-        }
 
         stli_sendcmd(brdp, portp, cmd, arg, size, copyback);
 
         wait_event_interruptible(portp->raw_wait,
                         !test_bit(ST_CMDING, &portp->state));
-        if (signal_pending(current)) {
-                restore_flags(flags);
+        if (signal_pending(current))
                 return -ERESTARTSYS;
-        }
-        restore_flags(flags);
 
         if (portp->rc != 0)
-                return(-EIO);
-        return(0);
+                return -EIO;
+        return 0;
 }
 
 /*****************************************************************************/
@@ -1425,22 +1348,18 @@ static int stli_cmdwait(stlibrd_t *brdp, stliport_t *portp, unsigned long cmd, v
 
 static int stli_setport(stliport_t *portp)
 {
-        stlibrd_t       *brdp;
-        asyport_t       aport;
-
-#ifdef DEBUG
-        printk("stli_setport(portp=%x)\n", (int) portp);
-#endif
+        stlibrd_t *brdp;
+        asyport_t aport;
 
-        if (portp == (stliport_t *) NULL)
-                return(-ENODEV);
-        if (portp->tty == (struct tty_struct *) NULL)
-                return(-ENODEV);
-        if ((portp->brdnr < 0) && (portp->brdnr >= stli_nrbrds))
-                return(-ENODEV);
+        if (portp == NULL)
+                return -ENODEV;
+        if (portp->tty == NULL)
+                return -ENODEV;
+        if (portp->brdnr < 0 && portp->brdnr >= stli_nrbrds)
+                return -ENODEV;
         brdp = stli_brds[portp->brdnr];
-        if (brdp == (stlibrd_t *) NULL)
-                return(-ENODEV);
+        if (brdp == NULL)
+                return -ENODEV;
 
         stli_mkasyport(portp, &aport, portp->tty->termios);
         return(stli_cmdwait(brdp, portp, A_SETPORT, &aport, sizeof(asyport_t), 0));
@@ -1455,13 +1374,8 @@ static int stli_setport(stliport_t *portp)
 
 static int stli_waitcarrier(stlibrd_t *brdp, stliport_t *portp, struct file *filp)
 {
-        unsigned long   flags;
-        int             rc, doclocal;
-
-#ifdef DEBUG
-        printk("stli_waitcarrier(brdp=%x,portp=%x,filp=%x)\n",
-                (int) brdp, (int) portp, (int) filp);
-#endif
+        unsigned long flags;
+        int rc, doclocal;
 
         rc = 0;
         doclocal = 0;
@@ -1469,11 +1383,11 @@ static int stli_waitcarrier(stlibrd_t *brdp, stliport_t *portp, struct file *fil
         if (portp->tty->termios->c_cflag & CLOCAL)
                 doclocal++;
 
-        save_flags(flags);
-        cli();
+        spin_lock_irqsave(&stli_lock, flags);
         portp->openwaitcnt++;
         if (! tty_hung_up_p(filp))
                 portp->refcount--;
+        spin_unlock_irqrestore(&stli_lock, flags);
 
         for (;;) {
                 stli_mkasysigs(&portp->asig, 1, 1);
@@ -1499,12 +1413,13 @@ static int stli_waitcarrier(stlibrd_t *brdp, stliport_t *portp, struct file *fil
                 interruptible_sleep_on(&portp->open_wait);
         }
 
+        spin_lock_irqsave(&stli_lock, flags);
         if (! tty_hung_up_p(filp))
                 portp->refcount++;
         portp->openwaitcnt--;
-        restore_flags(flags);
+        spin_unlock_irqrestore(&stli_lock, flags);
 
-        return(rc);
+        return rc;
 }
 
 /*****************************************************************************/
@@ -1517,46 +1432,38 @@ static int stli_waitcarrier(stlibrd_t *brdp, stliport_t *portp, struct file *fil
 
 static int stli_write(struct tty_struct *tty, const unsigned char *buf, int count)
 {
-        volatile cdkasy_t       *ap;
-        volatile cdkhdr_t       *hdrp;
-        volatile unsigned char  *bits;
-        unsigned char           *shbuf, *chbuf;
-        stliport_t              *portp;
-        stlibrd_t               *brdp;
-        unsigned int            len, stlen, head, tail, size;
-        unsigned long           flags;
-
-#ifdef DEBUG
-        printk("stli_write(tty=%x,buf=%x,count=%d)\n",
-                (int) tty, (int) buf, count);
-#endif
+        cdkasy_t __iomem *ap;
+        cdkhdr_t __iomem *hdrp;
+        unsigned char __iomem *bits;
+        unsigned char __iomem *shbuf;
+        unsigned char *chbuf;
+        stliport_t *portp;
+        stlibrd_t *brdp;
+        unsigned int len, stlen, head, tail, size;
+        unsigned long flags;
 
-        if ((tty == (struct tty_struct *) NULL) ||
-            (stli_tmpwritebuf == (char *) NULL))
-                return(0);
         if (tty == stli_txcooktty)
                 stli_flushchars(tty);
         portp = tty->driver_data;
-        if (portp == (stliport_t *) NULL)
-                return(0);
+        if (portp == NULL)
+                return 0;
         if ((portp->brdnr < 0) || (portp->brdnr >= stli_nrbrds))
-                return(0);
+                return 0;
         brdp = stli_brds[portp->brdnr];
-        if (brdp == (stlibrd_t *) NULL)
-                return(0);
+        if (brdp == NULL)
+                return 0;
         chbuf = (unsigned char *) buf;
 
 /*
  *      All data is now local, shove as much as possible into shared memory.
  */
-        save_flags(flags);
-        cli();
+        spin_lock_irqsave(&brd_lock, flags);
         EBRDENABLE(brdp);
-        ap = (volatile cdkasy_t *) EBRDGETMEMPTR(brdp, portp->addr);
-        head = (unsigned int) ap->txq.head;
-        tail = (unsigned int) ap->txq.tail;
-        if (tail != ((unsigned int) ap->txq.tail))
-                tail = (unsigned int) ap->txq.tail;
+        ap = (cdkasy_t __iomem *) EBRDGETMEMPTR(brdp, portp->addr);
+        head = (unsigned int) readw(&ap->txq.head);
+        tail = (unsigned int) readw(&ap->txq.tail);
+        if (tail != ((unsigned int) readw(&ap->txq.tail)))
+                tail = (unsigned int) readw(&ap->txq.tail);
         size = portp->txsize;
         if (head >= tail) {
                 len = size - (head - tail) - 1;
@@ -1568,11 +1475,11 @@ static int stli_write(struct tty_struct *tty, const unsigned char *buf, int coun
 
         len = MIN(len, count);
         count = 0;
-        shbuf = (char *) EBRDGETMEMPTR(brdp, portp->txoffset);
+        shbuf = (char __iomem *) EBRDGETMEMPTR(brdp, portp->txoffset);
 
         while (len > 0) {
                 stlen = MIN(len, stlen);
-                memcpy((shbuf + head), chbuf, stlen);
+                memcpy_toio(shbuf + head, chbuf, stlen);
                 chbuf += stlen;
                 len -= stlen;
                 count += stlen;
@@ -1583,20 +1490,19 @@ static int stli_write(struct tty_struct *tty, const unsigned char *buf, int coun
                 }
         }
 
-        ap = (volatile cdkasy_t *) EBRDGETMEMPTR(brdp, portp->addr);
-        ap->txq.head = head;
+        ap = (cdkasy_t __iomem *) EBRDGETMEMPTR(brdp, portp->addr);
+        writew(head, &ap->txq.head);
         if (test_bit(ST_TXBUSY, &portp->state)) {
-                if (ap->changed.data & DT_TXEMPTY)
-                        ap->changed.data &= ~DT_TXEMPTY;
+                if (readl(&ap->changed.data) & DT_TXEMPTY)
+                        writel(readl(&ap->changed.data) & ~DT_TXEMPTY, &ap->changed.data);
         }
-        hdrp = (volatile cdkhdr_t *) EBRDGETMEMPTR(brdp, CDK_CDKADDR);
-        bits = ((volatile unsigned char *) hdrp) + brdp->slaveoffset +
+        hdrp = (cdkhdr_t __iomem *) EBRDGETMEMPTR(brdp, CDK_CDKADDR);
+        bits = ((unsigned char __iomem *) hdrp) + brdp->slaveoffset +
                 portp->portidx;
-        *bits |= portp->portbit;
+        writeb(readb(bits) | portp->portbit, bits);
         set_bit(ST_TXBUSY, &portp->state);
         EBRDDISABLE(brdp);
-
-        restore_flags(flags);
+        spin_unlock_irqrestore(&brd_lock, flags);
 
         return(count);
 }
@@ -1613,14 +1519,8 @@ static int stli_write(struct tty_struct *tty, const unsigned char *buf, int coun
 
 static void stli_putchar(struct tty_struct *tty, unsigned char ch)
 {
-#ifdef DEBUG
-        printk("stli_putchar(tty=%x,ch=%x)\n", (int) tty, (int) ch);
-#endif
-
-        if (tty == (struct tty_struct *) NULL)
-                return;
         if (tty != stli_txcooktty) {
-                if (stli_txcooktty != (struct tty_struct *) NULL)
+                if (stli_txcooktty != NULL)
                         stli_flushchars(stli_txcooktty);
                 stli_txcooktty = tty;
         }
@@ -1640,29 +1540,26 @@ static void stli_putchar(struct tty_struct *tty, unsigned char ch)
 
 static void stli_flushchars(struct tty_struct *tty)
 {
-        volatile cdkhdr_t       *hdrp;
-        volatile unsigned char  *bits;
-        volatile cdkasy_t       *ap;
-        struct tty_struct       *cooktty;
-        stliport_t              *portp;
-        stlibrd_t               *brdp;
-        unsigned int            len, stlen, head, tail, size, count, cooksize;
-        unsigned char           *buf, *shbuf;
-        unsigned long           flags;
-
-#ifdef DEBUG
-        printk("stli_flushchars(tty=%x)\n", (int) tty);
-#endif
+        cdkhdr_t __iomem *hdrp;
+        unsigned char __iomem *bits;
+        cdkasy_t __iomem *ap;
+        struct tty_struct *cooktty;
+        stliport_t *portp;
+        stlibrd_t *brdp;
+        unsigned int len, stlen, head, tail, size, count, cooksize;
+        unsigned char *buf;
+        unsigned char __iomem *shbuf;
+        unsigned long flags;
 
         cooksize = stli_txcooksize;
         cooktty = stli_txcooktty;
         stli_txcooksize = 0;
         stli_txcookrealsize = 0;
-        stli_txcooktty = (struct tty_struct *) NULL;
+        stli_txcooktty = NULL;
 
-        if (tty == (struct tty_struct *) NULL)
+        if (tty == NULL)
                 return;
-        if (cooktty == (struct tty_struct *) NULL)
+        if (cooktty == NULL)
                 return;
         if (tty != cooktty)
                 tty = cooktty;
@@ -1670,23 +1567,22 @@ static void stli_flushchars(struct tty_struct *tty)
                 return;
 
         portp = tty->driver_data;
-        if (portp == (stliport_t *) NULL)
+        if (portp == NULL)
                 return;
         if ((portp->brdnr < 0) || (portp->brdnr >= stli_nrbrds))
                 return;
         brdp = stli_brds[portp->brdnr];
-        if (brdp == (stlibrd_t *) NULL)
+        if (brdp == NULL)
                 return;
 
-        save_flags(flags);
-        cli();
+        spin_lock_irqsave(&brd_lock, flags);
         EBRDENABLE(brdp);
 
-        ap = (volatile cdkasy_t *) EBRDGETMEMPTR(brdp, portp->addr);
-        head = (unsigned int) ap->txq.head;
-        tail = (unsigned int) ap->txq.tail;
-        if (tail != ((unsigned int) ap->txq.tail))
-                tail = (unsigned int) ap->txq.tail;
+        ap = (cdkasy_t __iomem *) EBRDGETMEMPTR(brdp, portp->addr);
+        head = (unsigned int) readw(&ap->txq.head);
+        tail = (unsigned int) readw(&ap->txq.tail);
+        if (tail != ((unsigned int) readw(&ap->txq.tail)))
+                tail = (unsigned int) readw(&ap->txq.tail);
         size = portp->txsize;
         if (head >= tail) {
                 len = size - (head - tail) - 1;
@@ -1703,7 +1599,7 @@ static void stli_flushchars(struct tty_struct *tty)
 
         while (len > 0) {
                 stlen = MIN(len, stlen);
-                memcpy((shbuf + head), buf, stlen);
+                memcpy_toio(shbuf + head, buf, stlen);
                 buf += stlen;
                 len -= stlen;
                 count += stlen;
@@ -1714,73 +1610,66 @@ static void stli_flushchars(struct tty_struct *tty)
                 }
         }
 
-        ap = (volatile cdkasy_t *) EBRDGETMEMPTR(brdp, portp->addr);
-        ap->txq.head = head;
+        ap = (cdkasy_t __iomem *) EBRDGETMEMPTR(brdp, portp->addr);
+        writew(head, &ap->txq.head);
 
         if (test_bit(ST_TXBUSY, &portp->state)) {
-                if (ap->changed.data & DT_TXEMPTY)
-                        ap->changed.data &= ~DT_TXEMPTY;
+                if (readl(&ap->changed.data) & DT_TXEMPTY)
+                        writel(readl(&ap->changed.data) & ~DT_TXEMPTY, &ap->changed.data);
         }
-        hdrp = (volatile cdkhdr_t *) EBRDGETMEMPTR(brdp, CDK_CDKADDR);
-        bits = ((volatile unsigned char *) hdrp) + brdp->slaveoffset +
+        hdrp = (cdkhdr_t __iomem *) EBRDGETMEMPTR(brdp, CDK_CDKADDR);
+        bits = ((unsigned char __iomem *) hdrp) + brdp->slaveoffset +
                 portp->portidx;
-        *bits |= portp->portbit;
+        writeb(readb(bits) | portp->portbit, bits);
         set_bit(ST_TXBUSY, &portp->state);
 
         EBRDDISABLE(brdp);
-        restore_flags(flags);
+        spin_unlock_irqrestore(&brd_lock, flags);
 }
 
 /*****************************************************************************/
 
 static int stli_writeroom(struct tty_struct *tty)
 {
-        volatile cdkasyrq_t     *rp;
-        stliport_t              *portp;
-        stlibrd_t               *brdp;
-        unsigned int            head, tail, len;
-        unsigned long           flags;
-
-#ifdef DEBUG
-        printk("stli_writeroom(tty=%x)\n", (int) tty);
-#endif
+        cdkasyrq_t __iomem *rp;
+        stliport_t *portp;
+        stlibrd_t *brdp;
+        unsigned int head, tail, len;
+        unsigned long flags;
 
-        if (tty == (struct tty_struct *) NULL)
-                return(0);
         if (tty == stli_txcooktty) {
                 if (stli_txcookrealsize != 0) {
                         len = stli_txcookrealsize - stli_txcooksize;
-                        return(len);
+                        return len;
                 }
         }
 
         portp = tty->driver_data;
-        if (portp == (stliport_t *) NULL)
-                return(0);
+        if (portp == NULL)
+                return 0;
         if ((portp->brdnr < 0) || (portp->brdnr >= stli_nrbrds))
-                return(0);
+                return 0;
         brdp = stli_brds[portp->brdnr];
-        if (brdp == (stlibrd_t *) NULL)
-                return(0);
+        if (brdp == NULL)
+                return 0;
 
-        save_flags(flags);
-        cli();
+        spin_lock_irqsave(&brd_lock, flags);
         EBRDENABLE(brdp);
-        rp = &((volatile cdkasy_t *) EBRDGETMEMPTR(brdp, portp->addr))->txq;
-        head = (unsigned int) rp->head;
-        tail = (unsigned int) rp->tail;
-        if (tail != ((unsigned int) rp->tail))
-                tail = (unsigned int) rp->tail;
+        rp = &((cdkasy_t __iomem *) EBRDGETMEMPTR(brdp, portp->addr))->txq;
+        head = (unsigned int) readw(&rp->head);
+        tail = (unsigned int) readw(&rp->tail);
+        if (tail != ((unsigned int) readw(&rp->tail)))
+                tail = (unsigned int) readw(&rp->tail);
         len = (head >= tail) ? (portp->txsize - (head - tail)) : (tail - head);
         len--;
         EBRDDISABLE(brdp);
-        restore_flags(flags);
+        spin_unlock_irqrestore(&brd_lock, flags);
 
         if (tty == stli_txcooktty) {
                 stli_txcookrealsize = len;
                 len -= stli_txcooksize;
         }
-        return(len);
+        return len;
 }
 
 /*****************************************************************************/
@@ -1795,44 +1684,37 @@ static int stli_writeroom(struct tty_struct *tty)
 
 static int stli_charsinbuffer(struct tty_struct *tty)
 {
-        volatile cdkasyrq_t     *rp;
-        stliport_t              *portp;
-        stlibrd_t               *brdp;
-        unsigned int            head, tail, len;
-        unsigned long           flags;
-
-#ifdef DEBUG
-        printk("stli_charsinbuffer(tty=%x)\n", (int) tty);
-#endif
+        cdkasyrq_t __iomem *rp;
+        stliport_t *portp;
+        stlibrd_t *brdp;
+        unsigned int head, tail, len;
+        unsigned long flags;
 
-        if (tty == (struct tty_struct *) NULL)
-                return(0);
         if (tty == stli_txcooktty)
                 stli_flushchars(tty);
         portp = tty->driver_data;
-        if (portp == (stliport_t *) NULL)
-                return(0);
+        if (portp == NULL)
+                return 0;
         if ((portp->brdnr < 0) || (portp->brdnr >= stli_nrbrds))
-                return(0);
+                return 0;
         brdp = stli_brds[portp->brdnr];
-        if (brdp == (stlibrd_t *) NULL)
-                return(0);
+        if (brdp == NULL)
+                return 0;
 
-        save_flags(flags);
-        cli();
+        spin_lock_irqsave(&brd_lock, flags);
         EBRDENABLE(brdp);
-        rp = &((volatile cdkasy_t *) EBRDGETMEMPTR(brdp, portp->addr))->txq;
-        head = (unsigned int) rp->head;
-        tail = (unsigned int) rp->tail;
-        if (tail != ((unsigned int) rp->tail))
-                tail = (unsigned int) rp->tail;
+        rp = &((cdkasy_t __iomem *) EBRDGETMEMPTR(brdp, portp->addr))->txq;
+        head = (unsigned int) readw(&rp->head);
+        tail = (unsigned int) readw(&rp->tail);
+        if (tail != ((unsigned int) readw(&rp->tail)))
+                tail = (unsigned int) readw(&rp->tail);
         len = (head >= tail) ? (head - tail) : (portp->txsize - (tail - head));
         if ((len == 0) && test_bit(ST_TXBUSY, &portp->state))
                 len = 1;
         EBRDDISABLE(brdp);
-        restore_flags(flags);
+        spin_unlock_irqrestore(&brd_lock, flags);
 
-        return(len);
+        return len;
 }
 
 /*****************************************************************************/
@@ -1843,12 +1725,8 @@ static int stli_charsinbuffer(struct tty_struct *tty)
 
 static int stli_getserial(stliport_t *portp, struct serial_struct __user *sp)
 {
-        struct serial_struct    sio;
-        stlibrd_t               *brdp;
-
-#ifdef DEBUG
-        printk("stli_getserial(portp=%x,sp=%x)\n", (int) portp, (int) sp);
-#endif
+        struct serial_struct sio;
+        stlibrd_t *brdp;
 
         memset(&sio, 0, sizeof(struct serial_struct));
         sio.type = PORT_UNKNOWN;
@@ -1863,7 +1741,7 @@ static int stli_getserial(stliport_t *portp, struct serial_struct __user *sp)
         sio.hub6 = 0;
 
         brdp = stli_brds[portp->brdnr];
-        if (brdp != (stlibrd_t *) NULL)
+        if (brdp != NULL)
                 sio.port = brdp->iobase;
                 
         return copy_to_user(sp, &sio, sizeof(struct serial_struct)) ?
@@ -1880,12 +1758,8 @@ static int stli_getserial(stliport_t *portp, struct serial_struct __user *sp)
 
 static int stli_setserial(stliport_t *portp, struct serial_struct __user *sp)
 {
-        struct serial_struct    sio;
-        int                     rc;
-
-#ifdef DEBUG
-        printk("stli_setserial(portp=%p,sp=%p)\n", portp, sp);
-#endif
+        struct serial_struct sio;
+        int rc;
 
         if (copy_from_user(&sio, sp, sizeof(struct serial_struct)))
                 return -EFAULT;
@@ -1894,7 +1768,7 @@ static int stli_setserial(stliport_t *portp, struct serial_struct __user *sp)
                     (sio.close_delay != portp->close_delay) ||
                     ((sio.flags & ~ASYNC_USR_MASK) !=
                     (portp->flags & ~ASYNC_USR_MASK)))
-                        return(-EPERM);
+                        return -EPERM;
         } 
 
         portp->flags = (portp->flags & ~ASYNC_USR_MASK) |
@@ -1905,8 +1779,8 @@ static int stli_setserial(stliport_t *portp, struct serial_struct __user *sp)
         portp->custom_divisor = sio.custom_divisor;
 
         if ((rc = stli_setport(portp)) < 0)
-                return(rc);
-        return(0);
+                return rc;
+        return 0;
 }
 
 /*****************************************************************************/
@@ -1917,19 +1791,19 @@ static int stli_tiocmget(struct tty_struct *tty, struct file *file)
         stlibrd_t *brdp;
         int rc;
 
-        if (portp == (stliport_t *) NULL)
-                return(-ENODEV);
-        if ((portp->brdnr < 0) || (portp->brdnr >= stli_nrbrds))
-                return(0);
+        if (portp == NULL)
+                return -ENODEV;
+        if (portp->brdnr < 0 || portp->brdnr >= stli_nrbrds)
+                return 0;
         brdp = stli_brds[portp->brdnr];
-        if (brdp == (stlibrd_t *) NULL)
-                return(0);
+        if (brdp == NULL)
+                return 0;
         if (tty->flags & (1 << TTY_IO_ERROR))
-                return(-EIO);
+                return -EIO;
 
         if ((rc = stli_cmdwait(brdp, portp, A_GETSIGNALS,
                                &portp->asig, sizeof(asysigs_t), 1)) < 0)
-                return(rc);
+                return rc;
 
         return stli_mktiocm(portp->asig.sigvalue);
 }
@@ -1941,15 +1815,15 @@ static int stli_tiocmset(struct tty_struct *tty, struct file *file,
         stlibrd_t *brdp;
         int rts = -1, dtr = -1;
 
-        if (portp == (stliport_t *) NULL)
-                return(-ENODEV);
-        if ((portp->brdnr < 0) || (portp->brdnr >= stli_nrbrds))
-                return(0);
+        if (portp == NULL)
+                return -ENODEV;
+        if (portp->brdnr < 0 || portp->brdnr >= stli_nrbrds)
+                return 0;
         brdp = stli_brds[portp->brdnr];
-        if (brdp == (stlibrd_t *) NULL)
-                return(0);
+        if (brdp == NULL)
+                return 0;
         if (tty->flags & (1 << TTY_IO_ERROR))
-                return(-EIO);
+                return -EIO;
 
         if (set & TIOCM_RTS)
                 rts = 1;
@@ -1968,32 +1842,25 @@ static int stli_tiocmset(struct tty_struct *tty, struct file *file,
 
 static int stli_ioctl(struct tty_struct *tty, struct file *file, unsigned int cmd, unsigned long arg)
 {
-        stliport_t      *portp;
-        stlibrd_t       *brdp;
-        unsigned int    ival;
-        int             rc;
+        stliport_t *portp;
+        stlibrd_t *brdp;
+        unsigned int ival;
+        int rc;
         void __user *argp = (void __user *)arg;
 
-#ifdef DEBUG
-        printk("stli_ioctl(tty=%x,file=%x,cmd=%x,arg=%x)\n",
-                (int) tty, (int) file, cmd, (int) arg);
-#endif
-
-        if (tty == (struct tty_struct *) NULL)
-                return(-ENODEV);
         portp = tty->driver_data;
-        if (portp == (stliport_t *) NULL)
-                return(-ENODEV);
-        if ((portp->brdnr < 0) || (portp->brdnr >= stli_nrbrds))
-                return(0);
+        if (portp == NULL)
+                return -ENODEV;
+        if (portp->brdnr < 0 || portp->brdnr >= stli_nrbrds)
+                return 0;
         brdp = stli_brds[portp->brdnr];
-        if (brdp == (stlibrd_t *) NULL)
-                return(0);
+        if (brdp == NULL)
+                return 0;
 
         if ((cmd != TIOCGSERIAL) && (cmd != TIOCSSERIAL) &&
             (cmd != COM_GETPORTSTATS) && (cmd != COM_CLRPORTSTATS)) {
                 if (tty->flags & (1 << TTY_IO_ERROR))
-                        return(-EIO);
+                        return -EIO;
         }
 
         rc = 0;
@@ -2040,7 +1907,7 @@ static int stli_ioctl(struct tty_struct *tty, struct file *file, unsigned int cm
                 break;
         }
 
-        return(rc);
+        return rc;
 }
 
 /*****************************************************************************/
@@ -2052,24 +1919,20 @@ static int stli_ioctl(struct tty_struct *tty, struct file *file, unsigned int cm
 
 static void stli_settermios(struct tty_struct *tty, struct termios *old)
 {
-        stliport_t      *portp;
-        stlibrd_t       *brdp;
-        struct termios  *tiosp;
-        asyport_t       aport;
-
-#ifdef DEBUG
-        printk("stli_settermios(tty=%x,old=%x)\n", (int) tty, (int) old);
-#endif
+        stliport_t *portp;
+        stlibrd_t *brdp;
+        struct termios *tiosp;
+        asyport_t aport;
 
-        if (tty == (struct tty_struct *) NULL)
+        if (tty == NULL)
                 return;
         portp = tty->driver_data;
-        if (portp == (stliport_t *) NULL)
+        if (portp == NULL)
                 return;
-        if ((portp->brdnr < 0) || (portp->brdnr >= stli_nrbrds))
+        if (portp->brdnr < 0 || portp->brdnr >= stli_nrbrds)
                 return;
         brdp = stli_brds[portp->brdnr];
-        if (brdp == (stlibrd_t *) NULL)
+        if (brdp == NULL)
                 return;
 
         tiosp = tty->termios;
@@ -2102,18 +1965,9 @@ static void stli_settermios(struct tty_struct *tty, struct termios *old)
 
 static void stli_throttle(struct tty_struct *tty)
 {
-        stliport_t      *portp;
-
-#ifdef DEBUG
-        printk("stli_throttle(tty=%x)\n", (int) tty);
-#endif
-
-        if (tty == (struct tty_struct *) NULL)
+        stliport_t      *portp = tty->driver_data;
+        if (portp == NULL)
                 return;
-        portp = tty->driver_data;
-        if (portp == (stliport_t *) NULL)
-                return;
-
         set_bit(ST_RXSTOP, &portp->state);
 }
 
@@ -2127,88 +1981,30 @@ static void stli_throttle(struct tty_struct *tty)
 
 static void stli_unthrottle(struct tty_struct *tty)
 {
-        stliport_t      *portp;
-
-#ifdef DEBUG
-        printk("stli_unthrottle(tty=%x)\n", (int) tty);
-#endif
-
-        if (tty == (struct tty_struct *) NULL)
-                return;
-        portp = tty->driver_data;
-        if (portp == (stliport_t *) NULL)
+        stliport_t      *portp = tty->driver_data;
+        if (portp == NULL)
                 return;
-
         clear_bit(ST_RXSTOP, &portp->state);
 }
 
 /*****************************************************************************/
 
 /*
- *      Stop the transmitter. Basically to do this we will just turn TX
- *      interrupts off.
+ *      Stop the transmitter.
  */
 
 static void stli_stop(struct tty_struct *tty)
 {
-        stlibrd_t       *brdp;
-        stliport_t      *portp;
-        asyctrl_t       actrl;
-
-#ifdef DEBUG
-        printk("stli_stop(tty=%x)\n", (int) tty);
-#endif
-
-        if (tty == (struct tty_struct *) NULL)
-                return;
-        portp = tty->driver_data;
-        if (portp == (stliport_t *) NULL)
-                return;
-        if ((portp->brdnr < 0) || (portp->brdnr >= stli_nrbrds))
-                return;
-        brdp = stli_brds[portp->brdnr];
-        if (brdp == (stlibrd_t *) NULL)
-                return;
-
-        memset(&actrl, 0, sizeof(asyctrl_t));
-        actrl.txctrl = CT_STOPFLOW;
-#if 0
-        stli_cmdwait(brdp, portp, A_PORTCTRL, &actrl, sizeof(asyctrl_t), 0);
-#endif
 }
 
 /*****************************************************************************/
 
 /*
- *      Start the transmitter again. Just turn TX interrupts back on.
+ *      Start the transmitter again.
  */
 
 static void stli_start(struct tty_struct *tty)
 {
-        stliport_t      *portp;
-        stlibrd_t       *brdp;
-        asyctrl_t       actrl;
-
-#ifdef DEBUG
-        printk("stli_start(tty=%x)\n", (int) tty);
-#endif
-
-        if (tty == (struct tty_struct *) NULL)
-                return;
-        portp = tty->driver_data;
-        if (portp == (stliport_t *) NULL)
-                return;
-        if ((portp->brdnr < 0) || (portp->brdnr >= stli_nrbrds))
-                return;
-        brdp = stli_brds[portp->brdnr];
-        if (brdp == (stlibrd_t *) NULL)
-                return;
-
-        memset(&actrl, 0, sizeof(asyctrl_t));
-        actrl.txctrl = CT_STARTFLOW;
-#if 0
-        stli_cmdwait(brdp, portp, A_PORTCTRL, &actrl, sizeof(asyctrl_t), 0);
-#endif
 }
 
 /*****************************************************************************/
@@ -2224,22 +2020,9 @@ static void stli_start(struct tty_struct *tty)
 
 static void stli_dohangup(void *arg)
 {
-        stliport_t      *portp;
-
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_dohangup(portp=%x)\n", (int) arg);
-#endif
-
-        /*
-         * FIXME: There's a module removal race here: tty_hangup
-         * calls schedule_work which will call into this
-         * driver later.
-         */
-        portp = (stliport_t *) arg;
-        if (portp != (stliport_t *) NULL) {
-                if (portp->tty != (struct tty_struct *) NULL) {
-                        tty_hangup(portp->tty);
-                }
+        stliport_t *portp = (stliport_t *) arg;
+        if (portp->tty != NULL) {
+                tty_hangup(portp->tty);
         }
 }
 
@@ -2254,31 +2037,25 @@ static void stli_dohangup(void *arg)
 
 static void stli_hangup(struct tty_struct *tty)
 {
-        stliport_t      *portp;
-        stlibrd_t       *brdp;
-        unsigned long   flags;
-
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_hangup(tty=%x)\n", (int) tty);
-#endif
+        stliport_t *portp;
+        stlibrd_t *brdp;
+        unsigned long flags;
 
-        if (tty == (struct tty_struct *) NULL)
-                return;
         portp = tty->driver_data;
-        if (portp == (stliport_t *) NULL)
+        if (portp == NULL)
                 return;
-        if ((portp->brdnr < 0) || (portp->brdnr >= stli_nrbrds))
+        if (portp->brdnr < 0 || portp->brdnr >= stli_nrbrds)
                 return;
         brdp = stli_brds[portp->brdnr];
-        if (brdp == (stlibrd_t *) NULL)
+        if (brdp == NULL)
                 return;
 
         portp->flags &= ~ASYNC_INITIALIZED;
 
-        save_flags(flags);
-        cli();
-        if (! test_bit(ST_CLOSING, &portp->state))
+        if (!test_bit(ST_CLOSING, &portp->state))
                 stli_rawclose(brdp, portp, 0, 0);
+
+        spin_lock_irqsave(&stli_lock, flags);
         if (tty->termios->c_cflag & HUPCL) {
                 stli_mkasysigs(&portp->asig, 0, 0);
                 if (test_bit(ST_CMDING, &portp->state)) {
@@ -2290,14 +2067,15 @@ static void stli_hangup(struct tty_struct *tty)
                                 &portp->asig, sizeof(asysigs_t), 0);
                 }
         }
-        restore_flags(flags);
 
         clear_bit(ST_TXBUSY, &portp->state);
         clear_bit(ST_RXSTOP, &portp->state);
         set_bit(TTY_IO_ERROR, &tty->flags);
-        portp->tty = (struct tty_struct *) NULL;
+        portp->tty = NULL;
         portp->flags &= ~ASYNC_NORMAL_ACTIVE;
         portp->refcount = 0;
+        spin_unlock_irqrestore(&stli_lock, flags);
+
         wake_up_interruptible(&portp->open_wait);
 }
 
@@ -2312,29 +2090,22 @@ static void stli_hangup(struct tty_struct *tty)
 
 static void stli_flushbuffer(struct tty_struct *tty)
 {
-        stliport_t      *portp;
-        stlibrd_t       *brdp;
-        unsigned long   ftype, flags;
-
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_flushbuffer(tty=%x)\n", (int) tty);
-#endif
+        stliport_t *portp;
+        stlibrd_t *brdp;
+        unsigned long ftype, flags;
 
-        if (tty == (struct tty_struct *) NULL)
-                return;
         portp = tty->driver_data;
-        if (portp == (stliport_t *) NULL)
+        if (portp == NULL)
                 return;
-        if ((portp->brdnr < 0) || (portp->brdnr >= stli_nrbrds))
+        if (portp->brdnr < 0 || portp->brdnr >= stli_nrbrds)
                 return;
         brdp = stli_brds[portp->brdnr];
-        if (brdp == (stlibrd_t *) NULL)
+        if (brdp == NULL)
                 return;
 
-        save_flags(flags);
-        cli();
+        spin_lock_irqsave(&brd_lock, flags);
         if (tty == stli_txcooktty) {
-                stli_txcooktty = (struct tty_struct *) NULL;
+                stli_txcooktty = NULL;
                 stli_txcooksize = 0;
                 stli_txcookrealsize = 0;
         }
@@ -2346,15 +2117,10 @@ static void stli_flushbuffer(struct tty_struct *tty)
                         ftype |= FLUSHRX;
                         clear_bit(ST_DOFLUSHRX, &portp->state);
                 }
-                stli_sendcmd(brdp, portp, A_FLUSH, &ftype,
-                        sizeof(unsigned long), 0);
+                __stli_sendcmd(brdp, portp, A_FLUSH, &ftype, sizeof(u32), 0);
         }
-        restore_flags(flags);
-
-        wake_up_interruptible(&tty->write_wait);
-        if ((tty->flags & (1 << TTY_DO_WRITE_WAKEUP)) &&
-            tty->ldisc.write_wakeup)
-                (tty->ldisc.write_wakeup)(tty);
+        spin_unlock_irqrestore(&brd_lock, flags);
+        tty_wakeup(tty);
 }
 
 /*****************************************************************************/
@@ -2364,55 +2130,31 @@ static void stli_breakctl(struct tty_struct *tty, int state)
         stlibrd_t       *brdp;
         stliport_t      *portp;
         long            arg;
-        /* long savestate, savetime; */
 
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_breakctl(tty=%x,state=%d)\n", (int) tty, state);
-#endif
-
-        if (tty == (struct tty_struct *) NULL)
-                return;
         portp = tty->driver_data;
-        if (portp == (stliport_t *) NULL)
+        if (portp == NULL)
                 return;
-        if ((portp->brdnr < 0) || (portp->brdnr >= stli_nrbrds))
+        if (portp->brdnr < 0 || portp->brdnr >= stli_nrbrds)
                 return;
         brdp = stli_brds[portp->brdnr];
-        if (brdp == (stlibrd_t *) NULL)
+        if (brdp == NULL)
                 return;
 
-/*
- *      Due to a bug in the tty send_break() code we need to preserve
- *      the current process state and timeout...
-        savetime = current->timeout;
-        savestate = current->state;
- */
-
         arg = (state == -1) ? BREAKON : BREAKOFF;
         stli_cmdwait(brdp, portp, A_BREAK, &arg, sizeof(long), 0);
-
-/*
- *
-        current->timeout = savetime;
-        current->state = savestate;
- */
 }
 
 /*****************************************************************************/
 
 static void stli_waituntilsent(struct tty_struct *tty, int timeout)
 {
-        stliport_t      *portp;
-        unsigned long   tend;
+        stliport_t *portp;
+        unsigned long tend;
 
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_waituntilsent(tty=%x,timeout=%x)\n", (int) tty, timeout);
-#endif
-
-        if (tty == (struct tty_struct *) NULL)
+        if (tty == NULL)
                 return;
         portp = tty->driver_data;
-        if (portp == (stliport_t *) NULL)
+        if (portp == NULL)
                 return;
 
         if (timeout == 0)
@@ -2436,19 +2178,13 @@ static void stli_sendxchar(struct tty_struct *tty, char ch)
         stliport_t      *portp;
         asyctrl_t       actrl;
 
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_sendxchar(tty=%x,ch=%x)\n", (int) tty, ch);
-#endif
-
-        if (tty == (struct tty_struct *) NULL)
-                return;
         portp = tty->driver_data;
-        if (portp == (stliport_t *) NULL)
+        if (portp == NULL)
                 return;
-        if ((portp->brdnr < 0) || (portp->brdnr >= stli_nrbrds))
+        if (portp->brdnr < 0 || portp->brdnr >= stli_nrbrds)
                 return;
         brdp = stli_brds[portp->brdnr];
-        if (brdp == (stlibrd_t *) NULL)
+        if (brdp == NULL)
                 return;
 
         memset(&actrl, 0, sizeof(asyctrl_t));
@@ -2460,7 +2196,6 @@ static void stli_sendxchar(struct tty_struct *tty, char ch)
                 actrl.txctrl = CT_SENDCHR;
                 actrl.tximdch = ch;
         }
-
         stli_cmdwait(brdp, portp, A_PORTCTRL, &actrl, sizeof(asyctrl_t), 0);
 }
 
@@ -2476,17 +2211,17 @@ static void stli_sendxchar(struct tty_struct *tty, char ch)
 
 static int stli_portinfo(stlibrd_t *brdp, stliport_t *portp, int portnr, char *pos)
 {
-        char    *sp, *uart;
-        int     rc, cnt;
+        char *sp, *uart;
+        int rc, cnt;
 
         rc = stli_portcmdstats(portp);
 
         uart = "UNKNOWN";
         if (brdp->state & BST_STARTED) {
                 switch (stli_comstats.hwid) {
-                case 0:         uart = "2681"; break;
-                case 1:         uart = "SC26198"; break;
-                default:        uart = "CD1400"; break;
+                case 0: uart = "2681"; break;
+                case 1: uart = "SC26198"; break;
+                default:uart = "CD1400"; break;
                 }
         }
 
@@ -2537,17 +2272,11 @@ static int stli_portinfo(stlibrd_t *brdp, stliport_t *portp, int portnr, char *p
 
 static int stli_readproc(char *page, char **start, off_t off, int count, int *eof, void *data)
 {
-        stlibrd_t       *brdp;
-        stliport_t      *portp;
-        int             brdnr, portnr, totalport;
-        int             curoff, maxoff;
-        char            *pos;
-
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_readproc(page=%x,start=%x,off=%x,count=%d,eof=%x,"
-                "data=%x\n", (int) page, (int) start, (int) off, count,
-                (int) eof, (int) data);
-#endif
+        stlibrd_t *brdp;
+        stliport_t *portp;
+        int brdnr, portnr, totalport;
+        int curoff, maxoff;
+        char *pos;
 
         pos = page;
         totalport = 0;
@@ -2568,7 +2297,7 @@ static int stli_readproc(char *page, char **start, off_t off, int count, int *eo
  */
         for (brdnr = 0; (brdnr < stli_nrbrds); brdnr++) {
                 brdp = stli_brds[brdnr];
-                if (brdp == (stlibrd_t *) NULL)
+                if (brdp == NULL)
                         continue;
                 if (brdp->state == 0)
                         continue;
@@ -2583,7 +2312,7 @@ static int stli_readproc(char *page, char **start, off_t off, int count, int *eo
                 for (portnr = 0; (portnr < brdp->nrports); portnr++,
                     totalport++) {
                         portp = brdp->ports[portnr];
-                        if (portp == (stliport_t *) NULL)
+                        if (portp == NULL)
                                 continue;
                         if (off >= (curoff += MAXLINE))
                                 continue;
@@ -2610,49 +2339,54 @@ stli_readdone:
  *      a poll routine that does not have user context. Therefore you cannot
  *      copy back directly into user space, or to the kernel stack of a
  *      process. This routine does not sleep, so can be called from anywhere.
+ *
+ *      The caller must hold the brd_lock (see also stli_sendcmd the usual
+ *      entry point)
  */
 
-static void stli_sendcmd(stlibrd_t *brdp, stliport_t *portp, unsigned long cmd, void *arg, int size, int copyback)
+static void __stli_sendcmd(stlibrd_t *brdp, stliport_t *portp, unsigned long cmd, void *arg, int size, int copyback)
 {
-        volatile cdkhdr_t       *hdrp;
-        volatile cdkctrl_t      *cp;
-        volatile unsigned char  *bits;
-        unsigned long           flags;
+        cdkhdr_t __iomem *hdrp;
+        cdkctrl_t __iomem *cp;
+        unsigned char __iomem *bits;
+        unsigned long flags;
 
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_sendcmd(brdp=%x,portp=%x,cmd=%x,arg=%x,size=%d,"
-                "copyback=%d)\n", (int) brdp, (int) portp, (int) cmd,
-                (int) arg, size, copyback);
-#endif
-
-        save_flags(flags);
-        cli();
+        spin_lock_irqsave(&brd_lock, flags);
 
         if (test_bit(ST_CMDING, &portp->state)) {
                 printk(KERN_ERR "STALLION: command already busy, cmd=%x!\n",
                                 (int) cmd);
-                restore_flags(flags);
+                spin_unlock_irqrestore(&brd_lock, flags);
                 return;
         }
 
         EBRDENABLE(brdp);
-        cp = &((volatile cdkasy_t *) EBRDGETMEMPTR(brdp, portp->addr))->ctrl;
+        cp = &((cdkasy_t __iomem *) EBRDGETMEMPTR(brdp, portp->addr))->ctrl;
         if (size > 0) {
-                memcpy((void *) &(cp->args[0]), arg, size);
+                memcpy_toio((void __iomem *) &(cp->args[0]), arg, size);
                 if (copyback) {
                         portp->argp = arg;
                         portp->argsize = size;
                 }
         }
-        cp->status = 0;
-        cp->cmd = cmd;
-        hdrp = (volatile cdkhdr_t *) EBRDGETMEMPTR(brdp, CDK_CDKADDR);
-        bits = ((volatile unsigned char *) hdrp) + brdp->slaveoffset +
+        writel(0, &cp->status);
+        writel(cmd, &cp->cmd);
+        hdrp = (cdkhdr_t __iomem *) EBRDGETMEMPTR(brdp, CDK_CDKADDR);
+        bits = ((unsigned char __iomem *) hdrp) + brdp->slaveoffset +
                 portp->portidx;
-        *bits |= portp->portbit;
+        writeb(readb(bits) | portp->portbit, bits);
         set_bit(ST_CMDING, &portp->state);
         EBRDDISABLE(brdp);
-        restore_flags(flags);
+        spin_unlock_irqrestore(&brd_lock, flags);
+}
+
+static void stli_sendcmd(stlibrd_t *brdp, stliport_t *portp, unsigned long cmd, void *arg, int size, int copyback)
+{
+        unsigned long           flags;
+
+        spin_lock_irqsave(&brd_lock, flags);
+        __stli_sendcmd(brdp, portp, cmd, arg, size, copyback);
+        spin_unlock_irqrestore(&brd_lock, flags);
 }
 
 /*****************************************************************************/
@@ -2667,28 +2401,23 @@ static void stli_sendcmd(stlibrd_t *brdp, stliport_t *portp, unsigned long cmd,
 
 static void stli_read(stlibrd_t *brdp, stliport_t *portp)
 {
-        volatile cdkasyrq_t     *rp;
-        volatile char           *shbuf;
+        cdkasyrq_t __iomem *rp;
+        char __iomem *shbuf;
         struct tty_struct       *tty;
-        unsigned int            head, tail, size;
-        unsigned int            len, stlen;
-
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_read(brdp=%x,portp=%d)\n",
-                        (int) brdp, (int) portp);
-#endif
+        unsigned int head, tail, size;
+        unsigned int len, stlen;
 
         if (test_bit(ST_RXSTOP, &portp->state))
                 return;
         tty = portp->tty;
-        if (tty == (struct tty_struct *) NULL)
+        if (tty == NULL)
                 return;
 
-        rp = &((volatile cdkasy_t *) EBRDGETMEMPTR(brdp, portp->addr))->rxq;
-        head = (unsigned int) rp->head;
-        if (head != ((unsigned int) rp->head))
-                head = (unsigned int) rp->head;
-        tail = (unsigned int) rp->tail;
+        rp = &((cdkasy_t __iomem *) EBRDGETMEMPTR(brdp, portp->addr))->rxq;
+        head = (unsigned int) readw(&rp->head);
+        if (head != ((unsigned int) readw(&rp->head)))
+                head = (unsigned int) readw(&rp->head);
+        tail = (unsigned int) readw(&rp->tail);
         size = portp->rxsize;
         if (head >= tail) {
                 len = head - tail;
@@ -2699,12 +2428,15 @@ static void stli_read(stlibrd_t *brdp, stliport_t *portp)
         }
 
         len = tty_buffer_request_room(tty, len);
-        /* FIXME : iomap ? */
-        shbuf = (volatile char *) EBRDGETMEMPTR(brdp, portp->rxoffset);
+
+        shbuf = (char __iomem *) EBRDGETMEMPTR(brdp, portp->rxoffset);
 
         while (len > 0) {
+                unsigned char *cptr;
+
                 stlen = MIN(len, stlen);
-                tty_insert_flip_string(tty, (char *)(shbuf + tail), stlen);
+                tty_prepare_flip_string(tty, &cptr, stlen);
+                memcpy_fromio(cptr, shbuf + tail, stlen);
                 len -= stlen;
                 tail += stlen;
                 if (tail >= size) {
@@ -2712,8 +2444,8 @@ static void stli_read(stlibrd_t *brdp, stliport_t *portp)
                         stlen = head;
                 }
         }
-        rp = &((volatile cdkasy_t *) EBRDGETMEMPTR(brdp, portp->addr))->rxq;
-        rp->tail = tail;
+        rp = &((cdkasy_t __iomem *) EBRDGETMEMPTR(brdp, portp->addr))->rxq;
+        writew(tail, &rp->tail);
 
         if (head != tail)
                 set_bit(ST_RXING, &portp->state);
@@ -2729,9 +2461,9 @@ static void stli_read(stlibrd_t *brdp, stliport_t *portp)
  *      difficult to deal with them here.
  */
 
-static void stli_dodelaycmd(stliport_t *portp, volatile cdkctrl_t *cp)
+static void stli_dodelaycmd(stliport_t *portp, cdkctrl_t __iomem *cp)
 {
-        int     cmd;
+        int cmd;
 
         if (test_bit(ST_DOSIGS, &portp->state)) {
                 if (test_bit(ST_DOFLUSHTX, &portp->state) &&
@@ -2746,10 +2478,10 @@ static void stli_dodelaycmd(stliport_t *portp, volatile cdkctrl_t *cp)
                 clear_bit(ST_DOFLUSHTX, &portp->state);
                 clear_bit(ST_DOFLUSHRX, &portp->state);
                 clear_bit(ST_DOSIGS, &portp->state);
-                memcpy((void *) &(cp->args[0]), (void *) &portp->asig,
+                memcpy_toio((void __iomem *) &(cp->args[0]), (void *) &portp->asig,
                         sizeof(asysigs_t));
-                cp->status = 0;
-                cp->cmd = cmd;
+                writel(0, &cp->status);
+                writel(cmd, &cp->cmd);
                 set_bit(ST_CMDING, &portp->state);
         } else if (test_bit(ST_DOFLUSHTX, &portp->state) ||
             test_bit(ST_DOFLUSHRX, &portp->state)) {
@@ -2757,9 +2489,9 @@ static void stli_dodelaycmd(stliport_t *portp, volatile cdkctrl_t *cp)
                 cmd |= ((test_bit(ST_DOFLUSHRX, &portp->state)) ? FLUSHRX : 0);
                 clear_bit(ST_DOFLUSHTX, &portp->state);
                 clear_bit(ST_DOFLUSHRX, &portp->state);
-                memcpy((void *) &(cp->args[0]), (void *) &cmd, sizeof(int));
-                cp->status = 0;
-                cp->cmd = A_FLUSH;
+                memcpy_toio((void __iomem *) &(cp->args[0]), (void *) &cmd, sizeof(int));
+                writel(0, &cp->status);
+                writel(A_FLUSH, &cp->cmd);
                 set_bit(ST_CMDING, &portp->state);
         }
 }
@@ -2779,30 +2511,25 @@ static void stli_dodelaycmd(stliport_t *portp, volatile cdkctrl_t *cp)
 
 static int stli_hostcmd(stlibrd_t *brdp, stliport_t *portp)
 {
-        volatile cdkasy_t       *ap;
-        volatile cdkctrl_t      *cp;
-        struct tty_struct       *tty;
-        asynotify_t             nt;
-        unsigned long           oldsigs;
-        int                     rc, donerx;
-
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_hostcmd(brdp=%x,channr=%d)\n",
-                        (int) brdp, channr);
-#endif
-
-        ap = (volatile cdkasy_t *) EBRDGETMEMPTR(brdp, portp->addr);
+        cdkasy_t __iomem *ap;
+        cdkctrl_t __iomem *cp;
+        struct tty_struct *tty;
+        asynotify_t nt;
+        unsigned long oldsigs;
+        int rc, donerx;
+
+        ap = (cdkasy_t __iomem *) EBRDGETMEMPTR(brdp, portp->addr);
         cp = &ap->ctrl;
 
 /*
  *      Check if we are waiting for an open completion message.
  */
         if (test_bit(ST_OPENING, &portp->state)) {
-                rc = (int) cp->openarg;
-                if ((cp->open == 0) && (rc != 0)) {
+                rc = readl(&cp->openarg);
+                if (readb(&cp->open) == 0 && rc != 0) {
                         if (rc > 0)
                                 rc--;
-                        cp->openarg = 0;
+                        writel(0, &cp->openarg);
                         portp->rc = rc;
                         clear_bit(ST_OPENING, &portp->state);
                         wake_up_interruptible(&portp->raw_wait);
@@ -2813,11 +2540,11 @@ static int stli_hostcmd(stlibrd_t *brdp, stliport_t *portp)
  *      Check if we are waiting for a close completion message.
  */
         if (test_bit(ST_CLOSING, &portp->state)) {
-                rc = (int) cp->closearg;
-                if ((cp->close == 0) && (rc != 0)) {
+                rc = (int) readl(&cp->closearg);
+                if (readb(&cp->close) == 0 && rc != 0) {
                         if (rc > 0)
                                 rc--;
-                        cp->closearg = 0;
+                        writel(0, &cp->closearg);
                         portp->rc = rc;
                         clear_bit(ST_CLOSING, &portp->state);
                         wake_up_interruptible(&portp->raw_wait);
@@ -2829,16 +2556,16 @@ static int stli_hostcmd(stlibrd_t *brdp, stliport_t *portp)
  *      need to copy out the command results associated with this command.
  */
         if (test_bit(ST_CMDING, &portp->state)) {
-                rc = cp->status;
-                if ((cp->cmd == 0) && (rc != 0)) {
+                rc = readl(&cp->status);
+                if (readl(&cp->cmd) == 0 && rc != 0) {
                         if (rc > 0)
                                 rc--;
-                        if (portp->argp != (void *) NULL) {
-                                memcpy(portp->argp, (void *) &(cp->args[0]),
+                        if (portp->argp != NULL) {
+                                memcpy_fromio(portp->argp, (void __iomem *) &(cp->args[0]),
                                         portp->argsize);
-                                portp->argp = (void *) NULL;
+                                portp->argp = NULL;
                         }
-                        cp->status = 0;
+                        writel(0, &cp->status);
                         portp->rc = rc;
                         clear_bit(ST_CMDING, &portp->state);
                         stli_dodelaycmd(portp, cp);
@@ -2877,18 +2604,15 @@ static int stli_hostcmd(stlibrd_t *brdp, stliport_t *portp)
                 if (nt.data & DT_TXEMPTY)
                         clear_bit(ST_TXBUSY, &portp->state);
                 if (nt.data & (DT_TXEMPTY | DT_TXLOW)) {
-                        if (tty != (struct tty_struct *) NULL) {
-                                if ((tty->flags & (1 << TTY_DO_WRITE_WAKEUP)) &&
-                                    tty->ldisc.write_wakeup) {
-                                        (tty->ldisc.write_wakeup)(tty);
-                                        EBRDENABLE(brdp);
-                                }
+                        if (tty != NULL) {
+                                tty_wakeup(tty);
+                                EBRDENABLE(brdp);
                                 wake_up_interruptible(&tty->write_wait);
                         }
                 }
 
                 if ((nt.data & DT_RXBREAK) && (portp->rxmarkmsk & BRKINT)) {
-                        if (tty != (struct tty_struct *) NULL) {
+                        if (tty != NULL) {
                                 tty_insert_flip_char(tty, 0, TTY_BREAK);
                                 if (portp->flags & ASYNC_SAK) {
                                         do_SAK(tty);
@@ -2932,14 +2656,14 @@ static int stli_hostcmd(stlibrd_t *brdp, stliport_t *portp)
  *      at the cdk header structure.
  */
 
-static void stli_brdpoll(stlibrd_t *brdp, volatile cdkhdr_t *hdrp)
+static void stli_brdpoll(stlibrd_t *brdp, cdkhdr_t __iomem *hdrp)
 {
-        stliport_t      *portp;
-        unsigned char   hostbits[(STL_MAXCHANS / 8) + 1];
-        unsigned char   slavebits[(STL_MAXCHANS / 8) + 1];
-        unsigned char   *slavep;
-        int             bitpos, bitat, bitsize;
-        int             channr, nrdevs, slavebitchange;
+        stliport_t *portp;
+        unsigned char hostbits[(STL_MAXCHANS / 8) + 1];
+        unsigned char slavebits[(STL_MAXCHANS / 8) + 1];
+        unsigned char __iomem *slavep;
+        int bitpos, bitat, bitsize;
+        int channr, nrdevs, slavebitchange;
 
         bitsize = brdp->bitsize;
         nrdevs = brdp->nrdevs;
@@ -2951,7 +2675,7 @@ static void stli_brdpoll(stlibrd_t *brdp, volatile cdkhdr_t *hdrp)
  *      8 service bits at a time in the inner loop, so we can bypass
  *      the lot if none of them want service.
  */
-        memcpy(&hostbits[0], (((unsigned char *) hdrp) + brdp->hostoffset),
+        memcpy_fromio(&hostbits[0], (((unsigned char __iomem *) hdrp) + brdp->hostoffset),
                 bitsize);
 
         memset(&slavebits[0], 0, bitsize);
@@ -2978,11 +2702,11 @@ static void stli_brdpoll(stlibrd_t *brdp, volatile cdkhdr_t *hdrp)
  *      service may initiate more slave requests.
  */
         if (slavebitchange) {
-                hdrp = (volatile cdkhdr_t *) EBRDGETMEMPTR(brdp, CDK_CDKADDR);
-                slavep = ((unsigned char *) hdrp) + brdp->slaveoffset;
+                hdrp = (cdkhdr_t __iomem *) EBRDGETMEMPTR(brdp, CDK_CDKADDR);
+                slavep = ((unsigned char __iomem *) hdrp) + brdp->slaveoffset;
                 for (bitpos = 0; (bitpos < bitsize); bitpos++) {
-                        if (slavebits[bitpos])
-                                slavep[bitpos] &= ~slavebits[bitpos];
+                        if (readb(slavebits + bitpos))
+                                writeb(readb(slavep + bitpos) & ~slavebits[bitpos], slavebits + bitpos);
                 }
         }
 }
@@ -3000,9 +2724,9 @@ static void stli_brdpoll(stlibrd_t *brdp, volatile cdkhdr_t *hdrp)
 
 static void stli_poll(unsigned long arg)
 {
-        volatile cdkhdr_t       *hdrp;
-        stlibrd_t               *brdp;
-        int                     brdnr;
+        cdkhdr_t __iomem *hdrp;
+        stlibrd_t *brdp;
+        int brdnr;
 
         stli_timerlist.expires = STLI_TIMEOUT;
         add_timer(&stli_timerlist);
@@ -3012,16 +2736,18 @@ static void stli_poll(unsigned long arg)
  */
         for (brdnr = 0; (brdnr < stli_nrbrds); brdnr++) {
                 brdp = stli_brds[brdnr];
-                if (brdp == (stlibrd_t *) NULL)
+                if (brdp == NULL)
                         continue;
                 if ((brdp->state & BST_STARTED) == 0)
                         continue;
 
+                spin_lock(&brd_lock);
                 EBRDENABLE(brdp);
-                hdrp = (volatile cdkhdr_t *) EBRDGETMEMPTR(brdp, CDK_CDKADDR);
-                if (hdrp->hostreq)
+                hdrp = (cdkhdr_t __iomem *) EBRDGETMEMPTR(brdp, CDK_CDKADDR);
+                if (readb(&hdrp->hostreq))
                         stli_brdpoll(brdp, hdrp);
                 EBRDDISABLE(brdp);
+                spin_unlock(&brd_lock);
         }
 }
 
@@ -3034,11 +2760,6 @@ static void stli_poll(unsigned long arg)
 
 static void stli_mkasyport(stliport_t *portp, asyport_t *pp, struct termios *tiosp)
 {
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_mkasyport(portp=%x,pp=%x,tiosp=%d)\n",
-                (int) portp, (int) pp, (int) tiosp);
-#endif
-
         memset(pp, 0, sizeof(asyport_t));
 
 /*
@@ -3157,11 +2878,6 @@ static void stli_mkasyport(stliport_t *portp, asyport_t *pp, struct termios *tio
 
 static void stli_mkasysigs(asysigs_t *sp, int dtr, int rts)
 {
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_mkasysigs(sp=%x,dtr=%d,rts=%d)\n",
-                        (int) sp, dtr, rts);
-#endif
-
         memset(sp, 0, sizeof(asysigs_t));
         if (dtr >= 0) {
                 sp->signal |= SG_DTR;
@@ -3182,13 +2898,7 @@ static void stli_mkasysigs(asysigs_t *sp, int dtr, int rts)
 
 static long stli_mktiocm(unsigned long sigvalue)
 {
-        long    tiocm;
-
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_mktiocm(sigvalue=%x)\n", (int) sigvalue);
-#endif
-
-        tiocm = 0;
+        long    tiocm = 0;
         tiocm |= ((sigvalue & SG_DCD) ? TIOCM_CD : 0);
         tiocm |= ((sigvalue & SG_CTS) ? TIOCM_CTS : 0);
         tiocm |= ((sigvalue & SG_RI) ? TIOCM_RI : 0);
@@ -3210,10 +2920,6 @@ static int stli_initports(stlibrd_t *brdp)
         stliport_t      *portp;
         int             i, panelnr, panelport;
 
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_initports(brdp=%x)\n", (int) brdp);
-#endif
-
         for (i = 0, panelnr = 0, panelport = 0; (i < brdp->nrports); i++) {
                 portp = kzalloc(sizeof(stliport_t), GFP_KERNEL);
                 if (!portp) {
@@ -3240,7 +2946,7 @@ static int stli_initports(stlibrd_t *brdp)
                 brdp->ports[i] = portp;
         }
 
-        return(0);
+        return 0;
 }
 
 /*****************************************************************************/
@@ -3253,10 +2959,6 @@ static void stli_ecpinit(stlibrd_t *brdp)
 {
         unsigned long   memconf;
 
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_ecpinit(brdp=%d)\n", (int) brdp);
-#endif
-
         outb(ECP_ATSTOP, (brdp->iobase + ECP_ATCONFR));
         udelay(10);
         outb(ECP_ATDISABLE, (brdp->iobase + ECP_ATCONFR));
@@ -3270,9 +2972,6 @@ static void stli_ecpinit(stlibrd_t *brdp)
 
 static void stli_ecpenable(stlibrd_t *brdp)
 {       
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_ecpenable(brdp=%x)\n", (int) brdp);
-#endif
         outb(ECP_ATENABLE, (brdp->iobase + ECP_ATCONFR));
 }
 
@@ -3280,9 +2979,6 @@ static void stli_ecpenable(stlibrd_t *brdp)
 
 static void stli_ecpdisable(stlibrd_t *brdp)
 {       
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_ecpdisable(brdp=%x)\n", (int) brdp);
-#endif
         outb(ECP_ATDISABLE, (brdp->iobase + ECP_ATCONFR));
 }
 
@@ -3290,13 +2986,8 @@ static void stli_ecpdisable(stlibrd_t *brdp)
 
 static char *stli_ecpgetmemptr(stlibrd_t *brdp, unsigned long offset, int line)
 {       
-        void            *ptr;
-        unsigned char   val;
-
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_ecpgetmemptr(brdp=%x,offset=%x)\n", (int) brdp,
-                (int) offset);
-#endif
+        void *ptr;
+        unsigned char val;
 
         if (offset > brdp->memsize) {
                 printk(KERN_ERR "STALLION: shared memory pointer=%x out of "
@@ -3316,10 +3007,6 @@ static char *stli_ecpgetmemptr(stlibrd_t *brdp, unsigned long offset, int line)
 
 static void stli_ecpreset(stlibrd_t *brdp)
 {       
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_ecpreset(brdp=%x)\n", (int) brdp);
-#endif
-
         outb(ECP_ATSTOP, (brdp->iobase + ECP_ATCONFR));
         udelay(10);
         outb(ECP_ATDISABLE, (brdp->iobase + ECP_ATCONFR));
@@ -3330,9 +3017,6 @@ static void stli_ecpreset(stlibrd_t *brdp)
 
 static void stli_ecpintr(stlibrd_t *brdp)
 {       
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_ecpintr(brdp=%x)\n", (int) brdp);
-#endif
         outb(0x1, brdp->iobase);
 }
 
@@ -3346,10 +3030,6 @@ static void stli_ecpeiinit(stlibrd_t *brdp)
 {
         unsigned long   memconf;
 
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_ecpeiinit(brdp=%x)\n", (int) brdp);
-#endif
-
         outb(0x1, (brdp->iobase + ECP_EIBRDENAB));
         outb(ECP_EISTOP, (brdp->iobase + ECP_EICONFR));
         udelay(10);
@@ -3383,11 +3063,6 @@ static char *stli_ecpeigetmemptr(stlibrd_t *brdp, unsigned long offset, int line
         void            *ptr;
         unsigned char   val;
 
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_ecpeigetmemptr(brdp=%x,offset=%x,line=%d)\n",
-                (int) brdp, (int) offset, line);
-#endif
-
         if (offset > brdp->memsize) {
                 printk(KERN_ERR "STALLION: shared memory pointer=%x out of "
                                 "range at line=%d(%d), brd=%d\n",
@@ -3437,8 +3112,8 @@ static void stli_ecpmcdisable(stlibrd_t *brdp)
 
 static char *stli_ecpmcgetmemptr(stlibrd_t *brdp, unsigned long offset, int line)
 {       
-        void            *ptr;
-        unsigned char   val;
+        void *ptr;
+        unsigned char val;
 
         if (offset > brdp->memsize) {
                 printk(KERN_ERR "STALLION: shared memory pointer=%x out of "
@@ -3472,10 +3147,6 @@ static void stli_ecpmcreset(stlibrd_t *brdp)
 
 static void stli_ecppciinit(stlibrd_t *brdp)
 {
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_ecppciinit(brdp=%x)\n", (int) brdp);
-#endif
-
         outb(ECP_PCISTOP, (brdp->iobase + ECP_PCICONFR));
         udelay(10);
         outb(0, (brdp->iobase + ECP_PCICONFR));
@@ -3489,11 +3160,6 @@ static char *stli_ecppcigetmemptr(stlibrd_t *brdp, unsigned long offset, int lin
         void            *ptr;
         unsigned char   val;
 
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_ecppcigetmemptr(brdp=%x,offset=%x,line=%d)\n",
-                (int) brdp, (int) offset, line);
-#endif
-
         if (offset > brdp->memsize) {
                 printk(KERN_ERR "STALLION: shared memory pointer=%x out of "
                                 "range at line=%d(%d), board=%d\n",
@@ -3528,10 +3194,6 @@ static void stli_onbinit(stlibrd_t *brdp)
 {
         unsigned long   memconf;
 
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_onbinit(brdp=%d)\n", (int) brdp);
-#endif
-
         outb(ONB_ATSTOP, (brdp->iobase + ONB_ATCONFR));
         udelay(10);
         outb(ONB_ATDISABLE, (brdp->iobase + ONB_ATCONFR));
@@ -3547,9 +3209,6 @@ static void stli_onbinit(stlibrd_t *brdp)
 
 static void stli_onbenable(stlibrd_t *brdp)
 {       
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_onbenable(brdp=%x)\n", (int) brdp);
-#endif
         outb((brdp->enabval | ONB_ATENABLE), (brdp->iobase + ONB_ATCONFR));
 }
 
@@ -3557,9 +3216,6 @@ static void stli_onbenable(stlibrd_t *brdp)
 
 static void stli_onbdisable(stlibrd_t *brdp)
 {       
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_onbdisable(brdp=%x)\n", (int) brdp);
-#endif
         outb((brdp->enabval | ONB_ATDISABLE), (brdp->iobase + ONB_ATCONFR));
 }
 
@@ -3569,11 +3225,6 @@ static char *stli_onbgetmemptr(stlibrd_t *brdp, unsigned long offset, int line)
 {       
         void    *ptr;
 
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_onbgetmemptr(brdp=%x,offset=%x)\n", (int) brdp,
-                (int) offset);
-#endif
-
         if (offset > brdp->memsize) {
                 printk(KERN_ERR "STALLION: shared memory pointer=%x out of "
                                 "range at line=%d(%d), brd=%d\n",
@@ -3589,11 +3240,6 @@ static char *stli_onbgetmemptr(stlibrd_t *brdp, unsigned long offset, int line)
 
 static void stli_onbreset(stlibrd_t *brdp)
 {       
-
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_onbreset(brdp=%x)\n", (int) brdp);
-#endif
-
         outb(ONB_ATSTOP, (brdp->iobase + ONB_ATCONFR));
         udelay(10);
         outb(ONB_ATDISABLE, (brdp->iobase + ONB_ATCONFR));
@@ -3610,10 +3256,6 @@ static void stli_onbeinit(stlibrd_t *brdp)
 {
         unsigned long   memconf;
 
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_onbeinit(brdp=%d)\n", (int) brdp);
-#endif
-
         outb(0x1, (brdp->iobase + ONB_EIBRDENAB));
         outb(ONB_EISTOP, (brdp->iobase + ONB_EICONFR));
         udelay(10);
@@ -3632,9 +3274,6 @@ static void stli_onbeinit(stlibrd_t *brdp)
 
 static void stli_onbeenable(stlibrd_t *brdp)
 {       
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_onbeenable(brdp=%x)\n", (int) brdp);
-#endif
         outb(ONB_EIENABLE, (brdp->iobase + ONB_EICONFR));
 }
 
@@ -3642,9 +3281,6 @@ static void stli_onbeenable(stlibrd_t *brdp)
 
 static void stli_onbedisable(stlibrd_t *brdp)
 {       
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_onbedisable(brdp=%x)\n", (int) brdp);
-#endif
         outb(ONB_EIDISABLE, (brdp->iobase + ONB_EICONFR));
 }
 
@@ -3652,13 +3288,8 @@ static void stli_onbedisable(stlibrd_t *brdp)
 
 static char *stli_onbegetmemptr(stlibrd_t *brdp, unsigned long offset, int line)
 {       
-        void            *ptr;
-        unsigned char   val;
-
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_onbegetmemptr(brdp=%x,offset=%x,line=%d)\n",
-                (int) brdp, (int) offset, line);
-#endif
+        void *ptr;
+        unsigned char val;
 
         if (offset > brdp->memsize) {
                 printk(KERN_ERR "STALLION: shared memory pointer=%x out of "
@@ -3681,11 +3312,6 @@ static char *stli_onbegetmemptr(stlibrd_t *brdp, unsigned long offset, int line)
 
 static void stli_onbereset(stlibrd_t *brdp)
 {       
-
-#ifdef DEBUG
-        printk(KERN_ERR "stli_onbereset(brdp=%x)\n", (int) brdp);
-#endif
-
         outb(ONB_EISTOP, (brdp->iobase + ONB_EICONFR));
         udelay(10);
         outb(ONB_EIDISABLE, (brdp->iobase + ONB_EICONFR));
@@ -3700,11 +3326,6 @@ static void stli_onbereset(stlibrd_t *brdp)
 
 static void stli_bbyinit(stlibrd_t *brdp)
 {
-
-#ifdef DEBUG
-        printk(KERN_ERR "stli_bbyinit(brdp=%d)\n", (int) brdp);
-#endif
-
         outb(BBY_ATSTOP, (brdp->iobase + BBY_ATCONFR));
         udelay(10);
         outb(0, (brdp->iobase + BBY_ATCONFR));
@@ -3717,24 +3338,13 @@ static void stli_bbyinit(stlibrd_t *brdp)
 
 static char *stli_bbygetmemptr(stlibrd_t *brdp, unsigned long offset, int line)
 {       
-        void            *ptr;
-        unsigned char   val;
+        void *ptr;
+        unsigned char val;
 
-#ifdef DEBUG
-        printk(KERN_ERR "stli_bbygetmemptr(brdp=%x,offset=%x)\n", (int) brdp,
-                (int) offset);
-#endif
+        BUG_ON(offset > brdp->memsize);
 
-        if (offset > brdp->memsize) {
-                printk(KERN_ERR "STALLION: shared memory pointer=%x out of "
-                                "range at line=%d(%d), brd=%d\n",
-                                (int) offset, line, __LINE__, brdp->brdnr);
-                ptr = NULL;
-                val = 0;
-        } else {
-                ptr = brdp->membase + (offset % BBY_PAGESIZE);
-                val = (unsigned char) (offset / BBY_PAGESIZE);
-        }
+        ptr = brdp->membase + (offset % BBY_PAGESIZE);
+        val = (unsigned char) (offset / BBY_PAGESIZE);
         outb(val, (brdp->iobase + BBY_ATCONFR));
         return(ptr);
 }
@@ -3743,11 +3353,6 @@ static char *stli_bbygetmemptr(stlibrd_t *brdp, unsigned long offset, int line)
 
 static void stli_bbyreset(stlibrd_t *brdp)
 {       
-
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_bbyreset(brdp=%x)\n", (int) brdp);
-#endif
-
         outb(BBY_ATSTOP, (brdp->iobase + BBY_ATCONFR));
         udelay(10);
         outb(0, (brdp->iobase + BBY_ATCONFR));
@@ -3762,11 +3367,6 @@ static void stli_bbyreset(stlibrd_t *brdp)
 
 static void stli_stalinit(stlibrd_t *brdp)
 {
-
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_stalinit(brdp=%d)\n", (int) brdp);
-#endif
-
         outb(0x1, brdp->iobase);
         mdelay(1000);
 }
@@ -3775,36 +3375,18 @@ static void stli_stalinit(stlibrd_t *brdp)
 
 static char *stli_stalgetmemptr(stlibrd_t *brdp, unsigned long offset, int line)
 {       
-        void    *ptr;
-
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_stalgetmemptr(brdp=%x,offset=%x)\n", (int) brdp,
-                (int) offset);
-#endif
-
-        if (offset > brdp->memsize) {
-                printk(KERN_ERR "STALLION: shared memory pointer=%x out of "
-                                "range at line=%d(%d), brd=%d\n",
-                                (int) offset, line, __LINE__, brdp->brdnr);
-                ptr = NULL;
-        } else {
-                ptr = brdp->membase + (offset % STAL_PAGESIZE);
-        }
-        return(ptr);
+        BUG_ON(offset > brdp->memsize);
+        return brdp->membase + (offset % STAL_PAGESIZE);
 }
 
 /*****************************************************************************/
 
 static void stli_stalreset(stlibrd_t *brdp)
 {       
-        volatile unsigned long  *vecp;
-
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_stalreset(brdp=%x)\n", (int) brdp);
-#endif
+        u32 __iomem *vecp;
 
-        vecp = (volatile unsigned long *) (brdp->membase + 0x30);
-        *vecp = 0xffff0000;
+        vecp = (u32 __iomem *) (brdp->membase + 0x30);
+        writel(0xffff0000, vecp);
         outb(0, brdp->iobase);
         mdelay(1000);
 }
@@ -3818,15 +3400,11 @@ static void stli_stalreset(stlibrd_t *brdp)
 
 static int stli_initecp(stlibrd_t *brdp)
 {
-        cdkecpsig_t     sig;
-        cdkecpsig_t     *sigsp;
-        unsigned int    status, nxtid;
-        char            *name;
-        int             panelnr, nrports;
-
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_initecp(brdp=%x)\n", (int) brdp);
-#endif
+        cdkecpsig_t sig;
+        cdkecpsig_t __iomem *sigsp;
+        unsigned int status, nxtid;
+        char *name;
+        int panelnr, nrports;
 
         if (!request_region(brdp->iobase, brdp->iosize, "istallion"))
                 return -EIO;
@@ -3834,7 +3412,7 @@ static int stli_initecp(stlibrd_t *brdp)
         if ((brdp->iobase == 0) || (brdp->memaddr == 0))
         {
                 release_region(brdp->iobase, brdp->iosize);
-                return(-ENODEV);
+                return -ENODEV;
         }
 
         brdp->iosize = ECP_IOSIZE;
@@ -3903,7 +3481,7 @@ static int stli_initecp(stlibrd_t *brdp)
 
         default:
                 release_region(brdp->iobase, brdp->iosize);
-                return(-EINVAL);
+                return -EINVAL;
         }
 
 /*
@@ -3915,10 +3493,10 @@ static int stli_initecp(stlibrd_t *brdp)
         EBRDINIT(brdp);
 
         brdp->membase = ioremap(brdp->memaddr, brdp->memsize);
-        if (brdp->membase == (void *) NULL)
+        if (brdp->membase == NULL)
         {
                 release_region(brdp->iobase, brdp->iosize);
-                return(-ENOMEM);
+                return -ENOMEM;
         }
 
 /*
@@ -3927,23 +3505,14 @@ static int stli_initecp(stlibrd_t *brdp)
  *      this is, and what it is connected to it.
  */
         EBRDENABLE(brdp);
-        sigsp = (cdkecpsig_t *) EBRDGETMEMPTR(brdp, CDK_SIGADDR);
+        sigsp = (cdkecpsig_t __iomem *) EBRDGETMEMPTR(brdp, CDK_SIGADDR);
         memcpy(&sig, sigsp, sizeof(cdkecpsig_t));
         EBRDDISABLE(brdp);
 
-#if 0
-        printk("%s(%d): sig-> magic=%x rom=%x panel=%x,%x,%x,%x,%x,%x,%x,%x\n",
-                __FILE__, __LINE__, (int) sig.magic, sig.romver, sig.panelid[0],
-                (int) sig.panelid[1], (int) sig.panelid[2],
-                (int) sig.panelid[3], (int) sig.panelid[4],
-                (int) sig.panelid[5], (int) sig.panelid[6],
-                (int) sig.panelid[7]);
-#endif
-
-        if (sig.magic != ECP_MAGIC)
+        if (sig.magic != cpu_to_le32(ECP_MAGIC))
         {
                 release_region(brdp->iobase, brdp->iosize);
-                return(-ENODEV);
+                return -ENODEV;
         }
 
 /*
@@ -3967,7 +3536,7 @@ static int stli_initecp(stlibrd_t *brdp)
 
 
         brdp->state |= BST_FOUND;
-        return(0);
+        return 0;
 }
 
 /*****************************************************************************/
@@ -3979,20 +3548,16 @@ static int stli_initecp(stlibrd_t *brdp)
 
 static int stli_initonb(stlibrd_t *brdp)
 {
-        cdkonbsig_t     sig;
-        cdkonbsig_t     *sigsp;
-        char            *name;
-        int             i;
-
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_initonb(brdp=%x)\n", (int) brdp);
-#endif
+        cdkonbsig_t sig;
+        cdkonbsig_t __iomem *sigsp;
+        char *name;
+        int i;
 
 /*
  *      Do a basic sanity check on the IO and memory addresses.
  */
-        if ((brdp->iobase == 0) || (brdp->memaddr == 0))
-                return(-ENODEV);
+        if (brdp->iobase == 0 || brdp->memaddr == 0)
+                return -ENODEV;
 
         brdp->iosize = ONB_IOSIZE;
         
@@ -4010,7 +3575,6 @@ static int stli_initonb(stlibrd_t *brdp)
         case BRD_ONBOARD2:
         case BRD_ONBOARD2_32:
         case BRD_ONBOARDRS:
-                brdp->membase = (void *) brdp->memaddr;
                 brdp->memsize = ONB_MEMSIZE;
                 brdp->pagesize = ONB_ATPAGESIZE;
                 brdp->init = stli_onbinit;
@@ -4028,7 +3592,6 @@ static int stli_initonb(stlibrd_t *brdp)
                 break;
 
         case BRD_ONBOARDE:
-                brdp->membase = (void *) brdp->memaddr;
                 brdp->memsize = ONB_EIMEMSIZE;
                 brdp->pagesize = ONB_EIPAGESIZE;
                 brdp->init = stli_onbeinit;
@@ -4044,7 +3607,6 @@ static int stli_initonb(stlibrd_t *brdp)
         case BRD_BRUMBY4:
         case BRD_BRUMBY8:
         case BRD_BRUMBY16:
-                brdp->membase = (void *) brdp->memaddr;
                 brdp->memsize = BBY_MEMSIZE;
                 brdp->pagesize = BBY_PAGESIZE;
                 brdp->init = stli_bbyinit;
@@ -4058,7 +3620,6 @@ static int stli_initonb(stlibrd_t *brdp)
                 break;
 
         case BRD_STALLION:
-                brdp->membase = (void *) brdp->memaddr;
                 brdp->memsize = STAL_MEMSIZE;
                 brdp->pagesize = STAL_PAGESIZE;
                 brdp->init = stli_stalinit;
@@ -4073,7 +3634,7 @@ static int stli_initonb(stlibrd_t *brdp)
 
         default:
                 release_region(brdp->iobase, brdp->iosize);
-                return(-EINVAL);
+                return -EINVAL;
         }
 
 /*
@@ -4085,10 +3646,10 @@ static int stli_initonb(stlibrd_t *brdp)
         EBRDINIT(brdp);
 
         brdp->membase = ioremap(brdp->memaddr, brdp->memsize);
-        if (brdp->membase == (void *) NULL)
+        if (brdp->membase == NULL)
         {
                 release_region(brdp->iobase, brdp->iosize);
-                return(-ENOMEM);
+                return -ENOMEM;
         }
 
 /*
@@ -4097,21 +3658,17 @@ static int stli_initonb(stlibrd_t *brdp)
  *      this is, and how many ports.
  */
         EBRDENABLE(brdp);
-        sigsp = (cdkonbsig_t *) EBRDGETMEMPTR(brdp, CDK_SIGADDR);
-        memcpy(&sig, sigsp, sizeof(cdkonbsig_t));
+        sigsp = (cdkonbsig_t __iomem *) EBRDGETMEMPTR(brdp, CDK_SIGADDR);
+        memcpy_fromio(&sig, sigsp, sizeof(cdkonbsig_t));
         EBRDDISABLE(brdp);
 
-#if 0
-        printk("%s(%d): sig-> magic=%x:%x:%x:%x romver=%x amask=%x:%x:%x\n",
-                __FILE__, __LINE__, sig.magic0, sig.magic1, sig.magic2,
-                sig.magic3, sig.romver, sig.amask0, sig.amask1, sig.amask2);
-#endif
-
-        if ((sig.magic0 != ONB_MAGIC0) || (sig.magic1 != ONB_MAGIC1) ||
-            (sig.magic2 != ONB_MAGIC2) || (sig.magic3 != ONB_MAGIC3))
+        if (sig.magic0 != cpu_to_le16(ONB_MAGIC0) ||
+            sig.magic1 != cpu_to_le16(ONB_MAGIC1) ||
+            sig.magic2 != cpu_to_le16(ONB_MAGIC2) ||
+            sig.magic3 != cpu_to_le16(ONB_MAGIC3))
         {
                 release_region(brdp->iobase, brdp->iosize);
-                return(-ENODEV);
+                return -ENODEV;
         }
 
 /*
@@ -4132,7 +3689,7 @@ static int stli_initonb(stlibrd_t *brdp)
 
 
         brdp->state |= BST_FOUND;
-        return(0);
+        return 0;
 }
 
 /*****************************************************************************/
@@ -4145,31 +3702,25 @@ static int stli_initonb(stlibrd_t *brdp)
 
 static int stli_startbrd(stlibrd_t *brdp)
 {
-        volatile cdkhdr_t       *hdrp;
-        volatile cdkmem_t       *memp;
-        volatile cdkasy_t       *ap;
-        unsigned long           flags;
-        stliport_t              *portp;
-        int                     portnr, nrdevs, i, rc;
-
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_startbrd(brdp=%x)\n", (int) brdp);
-#endif
-
-        rc = 0;
-
-        save_flags(flags);
-        cli();
+        cdkhdr_t __iomem *hdrp;
+        cdkmem_t __iomem *memp;
+        cdkasy_t __iomem *ap;
+        unsigned long flags;
+        stliport_t *portp;
+        int portnr, nrdevs, i, rc = 0;
+        u32 memoff;
+
+        spin_lock_irqsave(&brd_lock, flags);
         EBRDENABLE(brdp);
-        hdrp = (volatile cdkhdr_t *) EBRDGETMEMPTR(brdp, CDK_CDKADDR);
+        hdrp = (cdkhdr_t __iomem *) EBRDGETMEMPTR(brdp, CDK_CDKADDR);
         nrdevs = hdrp->nrdevs;
 
 #if 0
         printk("%s(%d): CDK version %d.%d.%d --> "
                 "nrdevs=%d memp=%x hostp=%x slavep=%x\n",
-                 __FILE__, __LINE__, hdrp->ver_release, hdrp->ver_modification,
-                 hdrp->ver_fix, nrdevs, (int) hdrp->memp, (int) hdrp->hostp,
-                 (int) hdrp->slavep);
+                 __FILE__, __LINE__, readb(&hdrp->ver_release), readb(&hdrp->ver_modification),
+                 readb(&hdrp->ver_fix), nrdevs, (int) readl(&hdrp->memp), readl(&hdrp->hostp),
+                 readl(&hdrp->slavep));
 #endif
 
         if (nrdevs < (brdp->nrports + 1)) {
@@ -4181,14 +3732,14 @@ static int stli_startbrd(stlibrd_t *brdp)
         brdp->hostoffset = hdrp->hostp - CDK_CDKADDR;
         brdp->slaveoffset = hdrp->slavep - CDK_CDKADDR;
         brdp->bitsize = (nrdevs + 7) / 8;
-        memp = (volatile cdkmem_t *) hdrp->memp;
-        if (((unsigned long) memp) > brdp->memsize) {
+        memoff = readl(&hdrp->memp);
+        if (memoff > brdp->memsize) {
                 printk(KERN_ERR "STALLION: corrupted shared memory region?\n");
                 rc = -EIO;
                 goto stli_donestartup;
         }
-        memp = (volatile cdkmem_t *) EBRDGETMEMPTR(brdp, (unsigned long) memp);
-        if (memp->dtype != TYP_ASYNCTRL) {
+        memp = (cdkmem_t __iomem *) EBRDGETMEMPTR(brdp, memoff);
+        if (readw(&memp->dtype) != TYP_ASYNCTRL) {
                 printk(KERN_ERR "STALLION: no slave control device found\n");
                 goto stli_donestartup;
         }
@@ -4200,19 +3751,19 @@ static int stli_startbrd(stlibrd_t *brdp)
  *      change pages while reading memory map.
  */
         for (i = 1, portnr = 0; (i < nrdevs); i++, portnr++, memp++) {
-                if (memp->dtype != TYP_ASYNC)
+                if (readw(&memp->dtype) != TYP_ASYNC)
                         break;
                 portp = brdp->ports[portnr];
-                if (portp == (stliport_t *) NULL)
+                if (portp == NULL)
                         break;
                 portp->devnr = i;
-                portp->addr = memp->offset;
+                portp->addr = readl(&memp->offset);
                 portp->reqbit = (unsigned char) (0x1 << (i * 8 / nrdevs));
                 portp->portidx = (unsigned char) (i / 8);
                 portp->portbit = (unsigned char) (0x1 << (i % 8));
         }
 
-        hdrp->slavereq = 0xff;
+        writeb(0xff, &hdrp->slavereq);
 
 /*
  *      For each port setup a local copy of the RX and TX buffer offsets
@@ -4221,22 +3772,22 @@ static int stli_startbrd(stlibrd_t *brdp)
  */
         for (i = 1, portnr = 0; (i < nrdevs); i++, portnr++) {
                 portp = brdp->ports[portnr];
-                if (portp == (stliport_t *) NULL)
+                if (portp == NULL)
                         break;
                 if (portp->addr == 0)
                         break;
-                ap = (volatile cdkasy_t *) EBRDGETMEMPTR(brdp, portp->addr);
-                if (ap != (volatile cdkasy_t *) NULL) {
-                        portp->rxsize = ap->rxq.size;
-                        portp->txsize = ap->txq.size;
-                        portp->rxoffset = ap->rxq.offset;
-                        portp->txoffset = ap->txq.offset;
+                ap = (cdkasy_t __iomem *) EBRDGETMEMPTR(brdp, portp->addr);
+                if (ap != NULL) {
+                        portp->rxsize = readw(&ap->rxq.size);
+                        portp->txsize = readw(&ap->txq.size);
+                        portp->rxoffset = readl(&ap->rxq.offset);
+                        portp->txoffset = readl(&ap->txq.offset);
                 }
         }
 
 stli_donestartup:
         EBRDDISABLE(brdp);
-        restore_flags(flags);
+        spin_unlock_irqrestore(&brd_lock, flags);
 
         if (rc == 0)
                 brdp->state |= BST_STARTED;
@@ -4247,7 +3798,7 @@ stli_donestartup:
                 add_timer(&stli_timerlist);
         }
 
-        return(rc);
+        return rc;
 }
 
 /*****************************************************************************/
@@ -4258,10 +3809,6 @@ stli_donestartup:
 
 static int __init stli_brdinit(stlibrd_t *brdp)
 {
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_brdinit(brdp=%x)\n", (int) brdp);
-#endif
-
         stli_brds[brdp->brdnr] = brdp;
 
         switch (brdp->brdtype) {
@@ -4289,11 +3836,11 @@ static int __init stli_brdinit(stlibrd_t *brdp)
         case BRD_ECHPCI:
                 printk(KERN_ERR "STALLION: %s board type not supported in "
                                 "this driver\n", stli_brdnames[brdp->brdtype]);
-                return(ENODEV);
+                return -ENODEV;
         default:
                 printk(KERN_ERR "STALLION: board=%d is unknown board "
                                 "type=%d\n", brdp->brdnr, brdp->brdtype);
-                return(ENODEV);
+                return -ENODEV;
         }
 
         if ((brdp->state & BST_FOUND) == 0) {
@@ -4301,7 +3848,7 @@ static int __init stli_brdinit(stlibrd_t *brdp)
                                 "io=%x mem=%x\n",
                         stli_brdnames[brdp->brdtype], brdp->brdnr,
                         brdp->iobase, (int) brdp->memaddr);
-                return(ENODEV);
+                return -ENODEV;
         }
 
         stli_initports(brdp);
@@ -4309,7 +3856,7 @@ static int __init stli_brdinit(stlibrd_t *brdp)
                 "nrpanels=%d nrports=%d\n", stli_brdnames[brdp->brdtype],
                 brdp->brdnr, brdp->iobase, (int) brdp->memaddr,
                 brdp->nrpanels, brdp->nrports);
-        return(0);
+        return 0;
 }
 
 /*****************************************************************************/
@@ -4321,14 +3868,10 @@ static int __init stli_brdinit(stlibrd_t *brdp)
 
 static int stli_eisamemprobe(stlibrd_t *brdp)
 {
-        cdkecpsig_t     ecpsig, *ecpsigp;
-        cdkonbsig_t     onbsig, *onbsigp;
+        cdkecpsig_t     ecpsig, __iomem *ecpsigp;
+        cdkonbsig_t     onbsig, __iomem *onbsigp;
         int             i, foundit;
 
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_eisamemprobe(brdp=%x)\n", (int) brdp);
-#endif
-
 /*
  *      First up we reset the board, to get it into a known state. There
  *      is only 2 board types here we need to worry about. Don;t use the
@@ -4352,7 +3895,7 @@ static int stli_eisamemprobe(stlibrd_t *brdp)
                 mdelay(1);
                 stli_onbeenable(brdp);
         } else {
-                return(-ENODEV);
+                return -ENODEV;
         }
 
         foundit = 0;
@@ -4364,25 +3907,24 @@ static int stli_eisamemprobe(stlibrd_t *brdp)
  */
         for (i = 0; (i < stli_eisamempsize); i++) {
                 brdp->memaddr = stli_eisamemprobeaddrs[i];
-                brdp->membase = (void *) brdp->memaddr;
                 brdp->membase = ioremap(brdp->memaddr, brdp->memsize);
-                if (brdp->membase == (void *) NULL)
+                if (brdp->membase == NULL)
                         continue;
 
                 if (brdp->brdtype == BRD_ECPE) {
-                        ecpsigp = (cdkecpsig_t *) stli_ecpeigetmemptr(brdp,
+                        ecpsigp = (cdkecpsig_t __iomem *) stli_ecpeigetmemptr(brdp,
                                 CDK_SIGADDR, __LINE__);
-                        memcpy(&ecpsig, ecpsigp, sizeof(cdkecpsig_t));
-                        if (ecpsig.magic == ECP_MAGIC)
+                        memcpy_fromio(&ecpsig, ecpsigp, sizeof(cdkecpsig_t));
+                        if (ecpsig.magic == cpu_to_le32(ECP_MAGIC))
                                 foundit = 1;
                 } else {
-                        onbsigp = (cdkonbsig_t *) stli_onbegetmemptr(brdp,
+                        onbsigp = (cdkonbsig_t __iomem *) stli_onbegetmemptr(brdp,
                                 CDK_SIGADDR, __LINE__);
-                        memcpy(&onbsig, onbsigp, sizeof(cdkonbsig_t));
-                        if ((onbsig.magic0 == ONB_MAGIC0) &&
-                            (onbsig.magic1 == ONB_MAGIC1) &&
-                            (onbsig.magic2 == ONB_MAGIC2) &&
-                            (onbsig.magic3 == ONB_MAGIC3))
+                        memcpy_fromio(&onbsig, onbsigp, sizeof(cdkonbsig_t));
+                        if ((onbsig.magic0 == cpu_to_le16(ONB_MAGIC0)) &&
+                            (onbsig.magic1 == cpu_to_le16(ONB_MAGIC1)) &&
+                            (onbsig.magic2 == cpu_to_le16(ONB_MAGIC2)) &&
+                            (onbsig.magic3 == cpu_to_le16(ONB_MAGIC3)))
                                 foundit = 1;
                 }
 
@@ -4406,9 +3948,9 @@ static int stli_eisamemprobe(stlibrd_t *brdp)
                 printk(KERN_ERR "STALLION: failed to probe shared memory "
                                 "region for %s in EISA slot=%d\n",
                         stli_brdnames[brdp->brdtype], (brdp->iobase >> 12));
-                return(-ENODEV);
+                return -ENODEV;
         }
-        return(0);
+        return 0;
 }
 
 static int stli_getbrdnr(void)
@@ -4439,22 +3981,16 @@ static int stli_getbrdnr(void)
 
 static int stli_findeisabrds(void)
 {
-        stlibrd_t       *brdp;
-        unsigned int    iobase, eid;
-        int             i;
-
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_findeisabrds()\n");
-#endif
+        stlibrd_t *brdp;
+        unsigned int iobase, eid;
+        int i;
 
 /*
- *      Firstly check if this is an EISA system. Do this by probing for
- *      the system board EISA ID. If this is not an EISA system then
+ *      Firstly check if this is an EISA system.  If this is not an EISA system then
  *      don't bother going any further!
  */
-        outb(0xff, 0xc80);
-        if (inb(0xc80) == 0xff)
-                return(0);
+        if (EISA_bus)
+                return 0;
 
 /*
  *      Looks like an EISA system, so go searching for EISA boards.
@@ -4472,7 +4008,7 @@ static int stli_findeisabrds(void)
  */
                 for (i = 0; (i < STL_MAXBRDS); i++) {
                         brdp = stli_brds[i];
-                        if (brdp == (stlibrd_t *) NULL)
+                        if (brdp == NULL)
                                 continue;
                         if (brdp->iobase == iobase)
                                 break;
@@ -4484,10 +4020,10 @@ static int stli_findeisabrds(void)
  *              We have found a Stallion board and it is not configured already.
  *              Allocate a board structure and initialize it.
  */
-                if ((brdp = stli_allocbrd()) == (stlibrd_t *) NULL)
-                        return(-ENOMEM);
+                if ((brdp = stli_allocbrd()) == NULL)
+                        return -ENOMEM;
                 if ((brdp->brdnr = stli_getbrdnr()) < 0)
-                        return(-ENOMEM);
+                        return -ENOMEM;
                 eid = inb(iobase + 0xc82);
                 if (eid == ECP_EISAID)
                         brdp->brdtype = BRD_ECPE;
@@ -4502,7 +4038,7 @@ static int stli_findeisabrds(void)
                 stli_brdinit(brdp);
         }
 
-        return(0);
+        return 0;
 }
 
 /*****************************************************************************/
@@ -4523,32 +4059,18 @@ static int stli_findeisabrds(void)
 
 static int stli_initpcibrd(int brdtype, struct pci_dev *devp)
 {
-        stlibrd_t       *brdp;
-
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_initpcibrd(brdtype=%d,busnr=%x,devnr=%x)\n",
-                brdtype, dev->bus->number, dev->devfn);
-#endif
+        stlibrd_t *brdp;
 
         if (pci_enable_device(devp))
-                return(-EIO);
-        if ((brdp = stli_allocbrd()) == (stlibrd_t *) NULL)
-                return(-ENOMEM);
+                return -EIO;
+        if ((brdp = stli_allocbrd()) == NULL)
+                return -ENOMEM;
         if ((brdp->brdnr = stli_getbrdnr()) < 0) {
                 printk(KERN_INFO "STALLION: too many boards found, "
                         "maximum supported %d\n", STL_MAXBRDS);
-                return(0);
+                return 0;
         }
         brdp->brdtype = brdtype;
-
-#ifdef DEBUG
-        printk(KERN_DEBUG "%s(%d): BAR[]=%lx,%lx,%lx,%lx\n", __FILE__, __LINE__,
-                pci_resource_start(devp, 0),
-                pci_resource_start(devp, 1),
-                pci_resource_start(devp, 2),
-                pci_resource_start(devp, 3));
-#endif
-
 /*
  *      We have all resources from the board, so lets setup the actual
  *      board structure now.
@@ -4557,7 +4079,7 @@ static int stli_initpcibrd(int brdtype, struct pci_dev *devp)
         brdp->memaddr = pci_resource_start(devp, 2);
         stli_brdinit(brdp);
 
-        return(0);
+        return 0;
 }
 
 /*****************************************************************************/
@@ -4569,20 +4091,12 @@ static int stli_initpcibrd(int brdtype, struct pci_dev *devp)
 
 static int stli_findpcibrds(void)
 {
-        struct pci_dev  *dev = NULL;
-        int             rc;
-
-#ifdef DEBUG
-        printk("stli_findpcibrds()\n");
-#endif
+        struct pci_dev *dev = NULL;
 
-        while ((dev = pci_find_device(PCI_VENDOR_ID_STALLION,
-            PCI_DEVICE_ID_ECRA, dev))) {
-                if ((rc = stli_initpcibrd(BRD_ECPPCI, dev)))
-                        return(rc);
+        while ((dev = pci_get_device(PCI_VENDOR_ID_STALLION, PCI_DEVICE_ID_ECRA, dev))) {
+                stli_initpcibrd(BRD_ECPPCI, dev);
         }
-
-        return(0);
+        return 0;
 }
 
 #endif
@@ -4595,17 +4109,16 @@ static int stli_findpcibrds(void)
 
 static stlibrd_t *stli_allocbrd(void)
 {
-        stlibrd_t       *brdp;
+        stlibrd_t *brdp;
 
         brdp = kzalloc(sizeof(stlibrd_t), GFP_KERNEL);
         if (!brdp) {
                 printk(KERN_ERR "STALLION: failed to allocate memory "
-                                "(size=%d)\n", sizeof(stlibrd_t));
+                                "(size=%Zd)\n", sizeof(stlibrd_t));
                 return NULL;
         }
-
         brdp->magic = STLI_BOARDMAGIC;
-        return(brdp);
+        return brdp;
 }
 
 /*****************************************************************************/
@@ -4617,13 +4130,9 @@ static stlibrd_t *stli_allocbrd(void)
 
 static int stli_initbrds(void)
 {
-        stlibrd_t       *brdp, *nxtbrdp;
-        stlconf_t       *confp;
-        int             i, j;
-
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_initbrds()\n");
-#endif
+        stlibrd_t *brdp, *nxtbrdp;
+        stlconf_t *confp;
+        int i, j;
 
         if (stli_nrbrds > STL_MAXBRDS) {
                 printk(KERN_INFO "STALLION: too many boards in configuration "
@@ -4638,11 +4147,9 @@ static int stli_initbrds(void)
  */
         for (i = 0; (i < stli_nrbrds); i++) {
                 confp = &stli_brdconf[i];
-#ifdef MODULE
                 stli_parsebrd(confp, stli_brdsp[i]);
-#endif
-                if ((brdp = stli_allocbrd()) == (stlibrd_t *) NULL)
-                        return(-ENOMEM);
+                if ((brdp = stli_allocbrd()) == NULL)
+                        return -ENOMEM;
                 brdp->brdnr = i;
                 brdp->brdtype = confp->brdtype;
                 brdp->iobase = confp->ioaddr1;
@@ -4654,9 +4161,7 @@ static int stli_initbrds(void)
  *      Static configuration table done, so now use dynamic methods to
  *      see if any more boards should be configured.
  */
-#ifdef MODULE
         stli_argbrds();
-#endif
         if (STLI_EISAPROBE)
                 stli_findeisabrds();
 #ifdef CONFIG_PCI
@@ -4672,11 +4177,11 @@ static int stli_initbrds(void)
         if (stli_nrbrds > 1) {
                 for (i = 0; (i < stli_nrbrds); i++) {
                         brdp = stli_brds[i];
-                        if (brdp == (stlibrd_t *) NULL)
+                        if (brdp == NULL)
                                 continue;
                         for (j = i + 1; (j < stli_nrbrds); j++) {
                                 nxtbrdp = stli_brds[j];
-                                if (nxtbrdp == (stlibrd_t *) NULL)
+                                if (nxtbrdp == NULL)
                                         continue;
                                 if ((brdp->membase >= nxtbrdp->membase) &&
                                     (brdp->membase <= (nxtbrdp->membase +
@@ -4691,7 +4196,7 @@ static int stli_initbrds(void)
         if (stli_shared == 0) {
                 for (i = 0; (i < stli_nrbrds); i++) {
                         brdp = stli_brds[i];
-                        if (brdp == (stlibrd_t *) NULL)
+                        if (brdp == NULL)
                                 continue;
                         if (brdp->state & BST_FOUND) {
                                 EBRDENABLE(brdp);
@@ -4701,7 +4206,7 @@ static int stli_initbrds(void)
                 }
         }
 
-        return(0);
+        return 0;
 }
 
 /*****************************************************************************/
@@ -4714,48 +4219,55 @@ static int stli_initbrds(void)
 
 static ssize_t stli_memread(struct file *fp, char __user *buf, size_t count, loff_t *offp)
 {
-        unsigned long   flags;
-        void            *memptr;
-        stlibrd_t       *brdp;
-        int             brdnr, size, n;
-
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_memread(fp=%x,buf=%x,count=%x,offp=%x)\n",
-                        (int) fp, (int) buf, count, (int) offp);
-#endif
+        unsigned long flags;
+        void *memptr;
+        stlibrd_t *brdp;
+        int brdnr, size, n;
+        void *p;
+        loff_t off = *offp;
 
         brdnr = iminor(fp->f_dentry->d_inode);
         if (brdnr >= stli_nrbrds)
-                return(-ENODEV);
+                return -ENODEV;
         brdp = stli_brds[brdnr];
-        if (brdp == (stlibrd_t *) NULL)
-                return(-ENODEV);
+        if (brdp == NULL)
+                return -ENODEV;
         if (brdp->state == 0)
-                return(-ENODEV);
-        if (fp->f_pos >= brdp->memsize)
-                return(0);
+                return -ENODEV;
+        if (off >= brdp->memsize || off + count < off)
+                return 0;
 
-        size = MIN(count, (brdp->memsize - fp->f_pos));
+        size = MIN(count, (brdp->memsize - off));
+
+        /*
+         *      Copy the data a page at a time
+         */
+
+        p = (void *)__get_free_page(GFP_KERNEL);
+        if(p == NULL)
+                return -ENOMEM;
 
-        save_flags(flags);
-        cli();
-        EBRDENABLE(brdp);
         while (size > 0) {
-                memptr = (void *) EBRDGETMEMPTR(brdp, fp->f_pos);
-                n = MIN(size, (brdp->pagesize - (((unsigned long) fp->f_pos) % brdp->pagesize)));
-                if (copy_to_user(buf, memptr, n)) {
+                spin_lock_irqsave(&brd_lock, flags);
+                EBRDENABLE(brdp);
+                memptr = (void *) EBRDGETMEMPTR(brdp, off);
+                n = MIN(size, (brdp->pagesize - (((unsigned long) off) % brdp->pagesize)));
+                n = MIN(n, PAGE_SIZE);
+                memcpy_fromio(p, memptr, n);
+                EBRDDISABLE(brdp);
+                spin_unlock_irqrestore(&brd_lock, flags);
+                if (copy_to_user(buf, p, n)) {
                         count = -EFAULT;
                         goto out;
                 }
-                fp->f_pos += n;
+                off += n;
                 buf += n;
                 size -= n;
         }
 out:
-        EBRDDISABLE(brdp);
-        restore_flags(flags);
-
-        return(count);
+        *offp = off;
+        free_page((unsigned long)p);
+        return count;
 }
 
 /*****************************************************************************/
@@ -4764,54 +4276,65 @@ out:
  *      Code to handle an "staliomem" write operation. This device is the 
  *      contents of the board shared memory. It is used for down loading
  *      the slave image (and debugging :-)
+ *
+ *      FIXME: copy under lock
  */
 
 static ssize_t stli_memwrite(struct file *fp, const char __user *buf, size_t count, loff_t *offp)
 {
-        unsigned long   flags;
-        void            *memptr;
-        stlibrd_t       *brdp;
-        char            __user *chbuf;
-        int             brdnr, size, n;
-
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_memwrite(fp=%x,buf=%x,count=%x,offp=%x)\n",
-                        (int) fp, (int) buf, count, (int) offp);
-#endif
+        unsigned long flags;
+        void *memptr;
+        stlibrd_t *brdp;
+        char __user *chbuf;
+        int brdnr, size, n;
+        void *p;
+        loff_t off = *offp;
 
         brdnr = iminor(fp->f_dentry->d_inode);
+
         if (brdnr >= stli_nrbrds)
-                return(-ENODEV);
+                return -ENODEV;
         brdp = stli_brds[brdnr];
-        if (brdp == (stlibrd_t *) NULL)
-                return(-ENODEV);
+        if (brdp == NULL)
+                return -ENODEV;
         if (brdp->state == 0)
-                return(-ENODEV);
-        if (fp->f_pos >= brdp->memsize)
-                return(0);
+                return -ENODEV;
+        if (off >= brdp->memsize || off + count < off)
+                return 0;
 
         chbuf = (char __user *) buf;
-        size = MIN(count, (brdp->memsize - fp->f_pos));
+        size = MIN(count, (brdp->memsize - off));
+
+        /*
+         *      Copy the data a page at a time
+         */
+
+        p = (void *)__get_free_page(GFP_KERNEL);
+        if(p == NULL)
+                return -ENOMEM;
 
-        save_flags(flags);
-        cli();
-        EBRDENABLE(brdp);
         while (size > 0) {
-                memptr = (void *) EBRDGETMEMPTR(brdp, fp->f_pos);
-                n = MIN(size, (brdp->pagesize - (((unsigned long) fp->f_pos) % brdp->pagesize)));
-                if (copy_from_user(memptr, chbuf, n)) {
-                        count = -EFAULT;
+                n = MIN(size, (brdp->pagesize - (((unsigned long) off) % brdp->pagesize)));
+                n = MIN(n, PAGE_SIZE);
+                if (copy_from_user(p, chbuf, n)) {
+                        if (count == 0)
+                                count = -EFAULT;
                         goto out;
                 }
-                fp->f_pos += n;
+                spin_lock_irqsave(&brd_lock, flags);
+                EBRDENABLE(brdp);
+                memptr = (void *) EBRDGETMEMPTR(brdp, off);
+                memcpy_toio(memptr, p, n);
+                EBRDDISABLE(brdp);
+                spin_unlock_irqrestore(&brd_lock, flags);
+                off += n;
                 chbuf += n;
                 size -= n;
         }
 out:
-        EBRDDISABLE(brdp);
-        restore_flags(flags);
-
-        return(count);
+        free_page((unsigned long) p);
+        *offp = off;
+        return count;
 }
 
 /*****************************************************************************/
@@ -4822,16 +4345,16 @@ out:
 
 static int stli_getbrdstats(combrd_t __user *bp)
 {
-        stlibrd_t       *brdp;
-        int             i;
+        stlibrd_t *brdp;
+        int i;
 
         if (copy_from_user(&stli_brdstats, bp, sizeof(combrd_t)))
                 return -EFAULT;
         if (stli_brdstats.brd >= STL_MAXBRDS)
-                return(-ENODEV);
+                return -ENODEV;
         brdp = stli_brds[stli_brdstats.brd];
-        if (brdp == (stlibrd_t *) NULL)
-                return(-ENODEV);
+        if (brdp == NULL)
+                return -ENODEV;
 
         memset(&stli_brdstats, 0, sizeof(combrd_t));
         stli_brdstats.brd = brdp->brdnr;
@@ -4850,7 +4373,7 @@ static int stli_getbrdstats(combrd_t __user *bp)
 
         if (copy_to_user(bp, &stli_brdstats, sizeof(combrd_t)))
                 return -EFAULT;
-        return(0);
+        return 0;
 }
 
 /*****************************************************************************/
@@ -4861,19 +4384,19 @@ static int stli_getbrdstats(combrd_t __user *bp)
 
 static stliport_t *stli_getport(int brdnr, int panelnr, int portnr)
 {
-        stlibrd_t       *brdp;
-        int             i;
+        stlibrd_t *brdp;
+        int i;
 
-        if ((brdnr < 0) || (brdnr >= STL_MAXBRDS))
-                return((stliport_t *) NULL);
+        if (brdnr < 0 || brdnr >= STL_MAXBRDS)
+                return NULL;
         brdp = stli_brds[brdnr];
-        if (brdp == (stlibrd_t *) NULL)
-                return((stliport_t *) NULL);
+        if (brdp == NULL)
+                return NULL;
         for (i = 0; (i < panelnr); i++)
                 portnr += brdp->panels[i];
         if ((portnr < 0) || (portnr >= brdp->nrports))
-                return((stliport_t *) NULL);
-        return(brdp->ports[portnr]);
+                return NULL;
+        return brdp->ports[portnr];
 }
 
 /*****************************************************************************/
@@ -4892,16 +4415,16 @@ static int stli_portcmdstats(stliport_t *portp)
 
         memset(&stli_comstats, 0, sizeof(comstats_t));
 
-        if (portp == (stliport_t *) NULL)
-                return(-ENODEV);
+        if (portp == NULL)
+                return -ENODEV;
         brdp = stli_brds[portp->brdnr];
-        if (brdp == (stlibrd_t *) NULL)
-                return(-ENODEV);
+        if (brdp == NULL)
+                return -ENODEV;
 
         if (brdp->state & BST_STARTED) {
                 if ((rc = stli_cmdwait(brdp, portp, A_GETSTATS,
                     &stli_cdkstats, sizeof(asystats_t), 1)) < 0)
-                        return(rc);
+                        return rc;
         } else {
                 memset(&stli_cdkstats, 0, sizeof(asystats_t));
         }
@@ -4912,13 +4435,12 @@ static int stli_portcmdstats(stliport_t *portp)
         stli_comstats.state = portp->state;
         stli_comstats.flags = portp->flags;
 
-        save_flags(flags);
-        cli();
-        if (portp->tty != (struct tty_struct *) NULL) {
+        spin_lock_irqsave(&brd_lock, flags);
+        if (portp->tty != NULL) {
                 if (portp->tty->driver_data == portp) {
                         stli_comstats.ttystate = portp->tty->flags;
-                        stli_comstats.rxbuffered = -1 /*portp->tty->flip.count*/;
-                        if (portp->tty->termios != (struct termios *) NULL) {
+                        stli_comstats.rxbuffered = -1;
+                        if (portp->tty->termios != NULL) {
                                 stli_comstats.cflags = portp->tty->termios->c_cflag;
                                 stli_comstats.iflags = portp->tty->termios->c_iflag;
                                 stli_comstats.oflags = portp->tty->termios->c_oflag;
@@ -4926,7 +4448,7 @@ static int stli_portcmdstats(stliport_t *portp)
                         }
                 }
         }
-        restore_flags(flags);
+        spin_unlock_irqrestore(&brd_lock, flags);
 
         stli_comstats.txtotal = stli_cdkstats.txchars;
         stli_comstats.rxtotal = stli_cdkstats.rxchars + stli_cdkstats.ringover;
@@ -4948,7 +4470,7 @@ static int stli_portcmdstats(stliport_t *portp)
         stli_comstats.hwid = stli_cdkstats.hwid;
         stli_comstats.signals = stli_mktiocm(stli_cdkstats.signals);
 
-        return(0);
+        return 0;
 }
 
 /*****************************************************************************/
@@ -4961,8 +4483,8 @@ static int stli_portcmdstats(stliport_t *portp)
 
 static int stli_getportstats(stliport_t *portp, comstats_t __user *cp)
 {
-        stlibrd_t       *brdp;
-        int             rc;
+        stlibrd_t *brdp;
+        int rc;
 
         if (!portp) {
                 if (copy_from_user(&stli_comstats, cp, sizeof(comstats_t)))
@@ -4992,8 +4514,8 @@ static int stli_getportstats(stliport_t *portp, comstats_t __user *cp)
 
 static int stli_clrportstats(stliport_t *portp, comstats_t __user *cp)
 {
-        stlibrd_t       *brdp;
-        int             rc;
+        stlibrd_t *brdp;
+        int rc;
 
         if (!portp) {
                 if (copy_from_user(&stli_comstats, cp, sizeof(comstats_t)))
@@ -5031,7 +4553,7 @@ static int stli_clrportstats(stliport_t *portp, comstats_t __user *cp)
 
 static int stli_getportstruct(stliport_t __user *arg)
 {
-        stliport_t      *portp;
+        stliport_t *portp;
 
         if (copy_from_user(&stli_dummyport, arg, sizeof(stliport_t)))
                 return -EFAULT;
@@ -5052,7 +4574,7 @@ static int stli_getportstruct(stliport_t __user *arg)
 
 static int stli_getbrdstruct(stlibrd_t __user *arg)
 {
-        stlibrd_t       *brdp;
+        stlibrd_t *brdp;
 
         if (copy_from_user(&stli_dummybrd, arg, sizeof(stlibrd_t)))
                 return -EFAULT;
@@ -5076,15 +4598,10 @@ static int stli_getbrdstruct(stlibrd_t __user *arg)
 
 static int stli_memioctl(struct inode *ip, struct file *fp, unsigned int cmd, unsigned long arg)
 {
-        stlibrd_t       *brdp;
-        int             brdnr, rc, done;
+        stlibrd_t *brdp;
+        int brdnr, rc, done;
         void __user *argp = (void __user *)arg;
 
-#ifdef DEBUG
-        printk(KERN_DEBUG "stli_memioctl(ip=%x,fp=%x,cmd=%x,arg=%x)\n",
-                        (int) ip, (int) fp, cmd, (int) arg);
-#endif
-
 /*
  *      First up handle the board independent ioctls.
  */
@@ -5115,7 +4632,7 @@ static int stli_memioctl(struct inode *ip, struct file *fp, unsigned int cmd, un
         }
 
         if (done)
-                return(rc);
+                return rc;
 
 /*
  *      Now handle the board specific ioctls. These all depend on the
@@ -5123,12 +4640,12 @@ static int stli_memioctl(struct inode *ip, struct file *fp, unsigned int cmd, un
  */
         brdnr = iminor(ip);
         if (brdnr >= STL_MAXBRDS)
-                return(-ENODEV);
+                return -ENODEV;
         brdp = stli_brds[brdnr];
         if (!brdp)
-                return(-ENODEV);
+                return -ENODEV;
         if (brdp->state == 0)
-                return(-ENODEV);
+                return -ENODEV;
 
         switch (cmd) {
         case STL_BINTR:
@@ -5152,8 +4669,7 @@ static int stli_memioctl(struct inode *ip, struct file *fp, unsigned int cmd, un
                 rc = -ENOIOCTLCMD;
                 break;
         }
-
-        return(rc);
+        return rc;
 }
 
 static struct tty_operations stli_ops = {
@@ -5187,6 +4703,9 @@ int __init stli_init(void)
         int i;
         printk(KERN_INFO "%s: version %s\n", stli_drvtitle, stli_drvversion);
 
+        spin_lock_init(&stli_lock);
+        spin_lock_init(&brd_lock);
+
         stli_initbrds();
 
         stli_serial = alloc_tty_driver(STL_MAXBRDS * STL_MAXPORTS);
@@ -5196,10 +4715,6 @@ int __init stli_init(void)
 /*
  *      Allocate a temporary write buffer.
  */
-        stli_tmpwritebuf = kmalloc(STLI_TXBUFSIZE, GFP_KERNEL);
-        if (!stli_tmpwritebuf)
-                printk(KERN_ERR "STALLION: failed to allocate memory "
-                                "(size=%d)\n", STLI_TXBUFSIZE);
         stli_txcookbuf = kmalloc(STLI_TXBUFSIZE, GFP_KERNEL);
         if (!stli_txcookbuf)
                 printk(KERN_ERR "STALLION: failed to allocate memory "
@@ -5243,7 +4758,7 @@ int __init stli_init(void)
                 printk(KERN_ERR "STALLION: failed to register serial driver\n");
                 return -EBUSY;
         }
-        return(0);
+        return 0;
 }
 
 /*****************************************************************************/
diff --git a/drivers/char/keyboard.c b/drivers/char/keyboard.c
index 5755b7e5f187..4bb3d2272604 100644
--- a/drivers/char/keyboard.c
+++ b/drivers/char/keyboard.c
@@ -39,6 +39,7 @@
 #include <linux/vt_kern.h>
 #include <linux/sysrq.h>
 #include <linux/input.h>
+#include <linux/reboot.h>
 
 static void kbd_disconnect(struct input_handle *handle);
 extern void ctrl_alt_del(void);
@@ -150,6 +151,7 @@ unsigned char kbd_sysrq_xlate[KEY_MAX + 1] =
         "230\177\000\000\213\214\000\000\000\000\000\000\000\000\000\000" /* 0x50 - 0x5f */
         "\r\000/";                                      /* 0x60 - 0x6f */
 static int sysrq_down;
+static int sysrq_alt_use;
 #endif
 static int sysrq_alt;
 
@@ -672,7 +674,7 @@ static void k_dead2(struct vc_data *vc, unsigned char value, char up_flag, struc
  */
 static void k_dead(struct vc_data *vc, unsigned char value, char up_flag, struct pt_regs *regs)
 {
-        static unsigned char ret_diacr[NR_DEAD] = {'`', '\'', '^', '~', '"', ',' };
+        static const unsigned char ret_diacr[NR_DEAD] = {'`', '\'', '^', '~', '"', ',' };
         value = ret_diacr[value];
         k_deadunicode(vc, value, up_flag, regs);
 }
@@ -709,8 +711,8 @@ static void k_cur(struct vc_data *vc, unsigned char value, char up_flag, struct
 
 static void k_pad(struct vc_data *vc, unsigned char value, char up_flag, struct pt_regs *regs)
 {
-        static const char *pad_chars = "0123456789+-*/\015,.?()#";
-        static const char *app_map = "pqrstuvwxylSRQMnnmPQS";
+        static const char pad_chars[] = "0123456789+-*/\015,.?()#";
+        static const char app_map[] = "pqrstuvwxylSRQMnnmPQS";
 
         if (up_flag)
                 return;         /* no action, if this is a key release */
@@ -1035,7 +1037,7 @@ static void kbd_refresh_leds(struct input_handle *handle)
 #define HW_RAW(dev) (test_bit(EV_MSC, dev->evbit) && test_bit(MSC_RAW, dev->mscbit) &&\
                         ((dev)->id.bustype == BUS_I8042) && ((dev)->id.vendor == 0x0001) && ((dev)->id.product == 0x0001))
 
-static unsigned short x86_keycodes[256] =
+static const unsigned short x86_keycodes[256] =
         { 0,  1,  2,  3,  4,  5,  6,  7,  8,  9, 10, 11, 12, 13, 14, 15,
          16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31,
          32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47,
@@ -1073,11 +1075,13 @@ static int emulate_raw(struct vc_data *vc, unsigned int keycode,
                         put_queue(vc, 0x1d | up_flag);
                         put_queue(vc, 0x45 | up_flag);
                         return 0;
-                case KEY_HANGUEL:
-                        if (!up_flag) put_queue(vc, 0xf1);
+                case KEY_HANGEUL:
+                        if (!up_flag)
+                                put_queue(vc, 0xf2);
                         return 0;
                 case KEY_HANJA:
-                        if (!up_flag) put_queue(vc, 0xf2);
+                        if (!up_flag)
+                                put_queue(vc, 0xf1);
                         return 0;
         }
 
@@ -1142,7 +1146,7 @@ static void kbd_keycode(unsigned int keycode, int down,
         kbd = kbd_table + fg_console;
 
         if (keycode == KEY_LEFTALT || keycode == KEY_RIGHTALT)
-                sysrq_alt = down;
+                sysrq_alt = down ? keycode : 0;
 #ifdef CONFIG_SPARC
         if (keycode == KEY_STOP)
                 sparc_l1_a_state = down;
@@ -1162,9 +1166,14 @@ static void kbd_keycode(unsigned int keycode, int down,
 
 #ifdef CONFIG_MAGIC_SYSRQ              /* Handle the SysRq Hack */
         if (keycode == KEY_SYSRQ && (sysrq_down || (down == 1 && sysrq_alt))) {
-                sysrq_down = down;
+                if (!sysrq_down) {
+                        sysrq_down = down;
+                        sysrq_alt_use = sysrq_alt;
+                }
                 return;
         }
+        if (sysrq_down && !down && keycode == sysrq_alt_use)
+                sysrq_down = 0;
         if (sysrq_down && down && !rep) {
                 handle_sysrq(kbd_sysrq_xlate[keycode], regs, tty);
                 return;
diff --git a/drivers/char/mmtimer.c b/drivers/char/mmtimer.c
index 1b05fa688996..d65b3109318a 100644
--- a/drivers/char/mmtimer.c
+++ b/drivers/char/mmtimer.c
@@ -329,7 +329,6 @@ static int mmtimer_mmap(struct file *file, struct vm_area_struct *vma)
         if (PAGE_SIZE > (1 << 16))
                 return -ENOSYS;
 
-        vma->vm_flags |= (VM_IO | VM_SHM | VM_LOCKED );
         vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
 
         mmtimer_addr = __pa(RTC_COUNTER_ADDR);
diff --git a/drivers/char/moxa.c b/drivers/char/moxa.c
index f43c2e04eadd..01247cccb89f 100644
--- a/drivers/char/moxa.c
+++ b/drivers/char/moxa.c
@@ -301,7 +301,7 @@ static struct tty_operations moxa_ops = {
         .tiocmset = moxa_tiocmset,
 };
 
-static spinlock_t moxa_lock = SPIN_LOCK_UNLOCKED;
+static DEFINE_SPINLOCK(moxa_lock);
 
 #ifdef CONFIG_PCI
 static int moxa_get_PCI_conf(struct pci_dev *p, int board_type, moxa_board_conf * board)
diff --git a/drivers/char/mxser.c b/drivers/char/mxser.c
index 0fb2fb9fb024..72cfd09091e0 100644
--- a/drivers/char/mxser.c
+++ b/drivers/char/mxser.c
@@ -9,7 +9,7 @@
  *      This program is free software; you can redistribute it and/or modify
  *      it under the terms of the GNU General Public License as published by
  *      the Free Software Foundation; either version 2 of the License, or
-*      (at your option) any later version.
+ *      (at your option) any later version.
  *
  *      This program is distributed in the hope that it will be useful,
  *      but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ -71,8 +71,8 @@
 #define MXSERMAJOR       174
 #define MXSERCUMAJOR     175
 
-#define MXSER_EVENT_TXLOW        1
-#define MXSER_EVENT_HANGUP       2
+#define MXSER_EVENT_TXLOW       1
+#define MXSER_EVENT_HANGUP      2
 
 #define MXSER_BOARDS            4       /* Max. boards */
 #define MXSER_PORTS             32      /* Max. ports */
@@ -92,7 +92,8 @@
 #define UART_MCR_AFE            0x20
 #define UART_LSR_SPECIAL        0x1E
 
-#define RELEVANT_IFLAG(iflag)   (iflag & (IGNBRK|BRKINT|IGNPAR|PARMRK|INPCK|IXON|IXOFF))
+#define RELEVANT_IFLAG(iflag)   (iflag & (IGNBRK|BRKINT|IGNPAR|PARMRK|INPCK|\
+                                          IXON|IXOFF))
 
 #define IRQ_T(info) ((info->flags & ASYNC_SHARE_IRQ) ? SA_SHIRQ : SA_INTERRUPT)
 
@@ -152,27 +153,27 @@ static char *mxser_brdname[] = {
 };
 
 static int mxser_numports[] = {
-        8,                      // C168-ISA
-        4,                      // C104-ISA
-        4,                      // CI104J
-        8,                      // C168-PCI
-        4,                      // C104-PCI
-        2,                      // C102-ISA
-        2,                      // CI132
-        4,                      // CI134
-        2,                      // CP132
-        4,                      // CP114
-        4,                      // CT114
-        2,                      // CP102
-        4,                      // CP104U
-        8,                      // CP168U
-        2,                      // CP132U
-        4,                      // CP134U
-        4,                      // CP104JU
-        8,                      // RC7000
-        8,                      // CP118U 
-        2,                      // CP102UL 
-        2,                      // CP102U
+        8,                      /* C168-ISA */
+        4,                      /* C104-ISA */
+        4,                      /* CI104J */
+        8,                      /* C168-PCI */
+        4,                      /* C104-PCI */
+        2,                      /* C102-ISA */
+        2,                      /* CI132 */
+        4,                      /* CI134 */
+        2,                      /* CP132 */
+        4,                      /* CP114 */
+        4,                      /* CT114 */
+        2,                      /* CP102 */
+        4,                      /* CP104U */
+        8,                      /* CP168U */
+        2,                      /* CP132U */
+        4,                      /* CP134U */
+        4,                      /* CP104JU */
+        8,                      /* RC7000 */
+        8,                      /* CP118U */
+        2,                      /* CP102UL */
+        2,                      /* CP102U */
 };
 
 #define UART_TYPE_NUM   2
@@ -182,7 +183,7 @@ static const unsigned int Gmoxa_uart_id[UART_TYPE_NUM] = {
         MOXA_MUST_MU860_HWID
 };
 
-// This is only for PCI
+/* This is only for PCI */
 #define UART_INFO_NUM   3
 struct mxpciuart_info {
         int type;
@@ -231,7 +232,7 @@ MODULE_DEVICE_TABLE(pci, mxser_pcibrds);
 typedef struct _moxa_pci_info {
         unsigned short busNum;
         unsigned short devNum;
-        struct pci_dev *pdev;   // add by Victor Yu. 06-23-2003
+        struct pci_dev *pdev;   /* add by Victor Yu. 06-23-2003 */
 } moxa_pci_info;
 
 static int ioaddr[MXSER_BOARDS] = { 0, 0, 0, 0 };
@@ -280,6 +281,7 @@ struct mxser_mon_ext {
         int fifo[32];
         int iftype[32];
 };
+
 struct mxser_hwconf {
         int board_type;
         int ports;
@@ -290,9 +292,9 @@ struct mxser_hwconf {
         int ioaddr[MXSER_PORTS_PER_BOARD];
         int baud_base[MXSER_PORTS_PER_BOARD];
         moxa_pci_info pciInfo;
-        int IsMoxaMustChipFlag; // add by Victor Yu. 08-30-2002
-        int MaxCanSetBaudRate[MXSER_PORTS_PER_BOARD];   // add by Victor Yu. 09-04-2002
-        int opmode_ioaddr[MXSER_PORTS_PER_BOARD];       // add by Victor Yu. 01-05-2004
+        int IsMoxaMustChipFlag; /* add by Victor Yu. 08-30-2002 */
+        int MaxCanSetBaudRate[MXSER_PORTS_PER_BOARD];   /* add by Victor Yu. 09-04-2002 */
+        int opmode_ioaddr[MXSER_PORTS_PER_BOARD];       /* add by Victor Yu. 01-05-2004 */
 };
 
 struct mxser_struct {
@@ -334,9 +336,9 @@ struct mxser_struct {
         wait_queue_head_t delta_msr_wait;
         struct async_icount icount;     /* kernel counters for the 4 input interrupts */
         int timeout;
-        int IsMoxaMustChipFlag; // add by Victor Yu. 08-30-2002
-        int MaxCanSetBaudRate;  // add by Victor Yu. 09-04-2002
-        int opmode_ioaddr;      // add by Victor Yu. 01-05-2004
+        int IsMoxaMustChipFlag; /* add by Victor Yu. 08-30-2002 */
+        int MaxCanSetBaudRate;  /* add by Victor Yu. 09-04-2002 */
+        int opmode_ioaddr;      /* add by Victor Yu. 01-05-2004 */
         unsigned char stop_rx;
         unsigned char ldisc_stop_rx;
         long realbaud;
@@ -345,7 +347,6 @@ struct mxser_struct {
         spinlock_t slock;
 };
 
-
 struct mxser_mstatus {
         tcflag_t cflag;
         int cts;
@@ -358,7 +359,7 @@ static struct mxser_mstatus GMStatus[MXSER_PORTS];
 
 static int mxserBoardCAP[MXSER_BOARDS] = {
         0, 0, 0, 0
-            /*  0x180, 0x280, 0x200, 0x320   */
+        /*  0x180, 0x280, 0x200, 0x320 */
 };
 
 static struct tty_driver *mxvar_sdriver;
@@ -386,7 +387,7 @@ static struct mxser_hwconf mxsercfg[MXSER_BOARDS];
 static void mxser_getcfg(int board, struct mxser_hwconf *hwconf);
 static int mxser_init(void);
 
-//static void   mxser_poll(unsigned long);
+/* static void   mxser_poll(unsigned long); */
 static int mxser_get_ISA_conf(int, struct mxser_hwconf *);
 static int mxser_get_PCI_conf(int, int, int, struct mxser_hwconf *);
 static void mxser_do_softint(void *);
@@ -440,18 +441,18 @@ static int CheckIsMoxaMust(int io)
         SET_MOXA_MUST_XON1_VALUE(io, 0x11);
         if ((hwid = inb(io + UART_MCR)) != 0) {
                 outb(oldmcr, io + UART_MCR);
-                return (MOXA_OTHER_UART);
+                return MOXA_OTHER_UART;
         }
 
         GET_MOXA_MUST_HARDWARE_ID(io, &hwid);
         for (i = 0; i < UART_TYPE_NUM; i++) {
                 if (hwid == Gmoxa_uart_id[i])
-                        return (int) hwid;
+                        return (int)hwid;
         }
         return MOXA_OTHER_UART;
 }
 
-// above is modified by Victor Yu. 08-15-2002
+/* above is modified by Victor Yu. 08-15-2002 */
 
 static struct tty_operations mxser_ops = {
         .open = mxser_open,
@@ -504,7 +505,6 @@ static void __exit mxser_module_exit(void)
         else
                 printk(KERN_ERR "Couldn't unregister MOXA Smartio/Industio family serial driver\n");
 
-
         for (i = 0; i < MXSER_BOARDS; i++) {
                 struct pci_dev *pdev;
 
@@ -513,7 +513,7 @@ static void __exit mxser_module_exit(void)
                 else {
                         pdev = mxsercfg[i].pciInfo.pdev;
                         free_irq(mxsercfg[i].irq, &mxvar_table[i * MXSER_PORTS_PER_BOARD]);
-                        if (pdev != NULL) {     //PCI
+                        if (pdev != NULL) {     /* PCI */
                                 release_region(pci_resource_start(pdev, 2), pci_resource_len(pdev, 2));
                                 release_region(pci_resource_start(pdev, 3), pci_resource_len(pdev, 3));
                         } else {
@@ -524,7 +524,6 @@ static void __exit mxser_module_exit(void)
         }
         if (verbose)
                 printk(KERN_DEBUG "Done.\n");
-
 }
 
 static void process_txrx_fifo(struct mxser_struct *info)
@@ -558,8 +557,10 @@ static int mxser_initbrd(int board, struct mxser_hwconf *hwconf)
         n = board * MXSER_PORTS_PER_BOARD;
         info = &mxvar_table[n];
         /*if (verbose) */  {
-                printk(KERN_DEBUG "        ttyM%d - ttyM%d ", n, n + hwconf->ports - 1);
-                printk(" max. baud rate = %d bps.\n", hwconf->MaxCanSetBaudRate[0]);
+                printk(KERN_DEBUG "        ttyM%d - ttyM%d ",
+                        n, n + hwconf->ports - 1);
+                printk(" max. baud rate = %d bps.\n",
+                        hwconf->MaxCanSetBaudRate[0]);
         }
 
         for (i = 0; i < hwconf->ports; i++, n++, info++) {
@@ -568,12 +569,12 @@ static int mxser_initbrd(int board, struct mxser_hwconf *hwconf)
                 info->irq = hwconf->irq;
                 info->vector = hwconf->vector;
                 info->vectormask = hwconf->vector_mask;
-                info->opmode_ioaddr = hwconf->opmode_ioaddr[i]; // add by Victor Yu. 01-05-2004
+                info->opmode_ioaddr = hwconf->opmode_ioaddr[i]; /* add by Victor Yu. 01-05-2004 */
                 info->stop_rx = 0;
                 info->ldisc_stop_rx = 0;
 
                 info->IsMoxaMustChipFlag = hwconf->IsMoxaMustChipFlag;
-                //Enhance mode enabled here
+                /* Enhance mode enabled here */
                 if (info->IsMoxaMustChipFlag != MOXA_OTHER_UART) {
                         ENABLE_MOXA_MUST_ENCHANCE_MODE(info->base);
                 }
@@ -606,22 +607,25 @@ static int mxser_initbrd(int board, struct mxser_hwconf *hwconf)
 
         /* before set INT ISR, disable all int */
         for (i = 0; i < hwconf->ports; i++) {
-                outb(inb(hwconf->ioaddr[i] + UART_IER) & 0xf0, hwconf->ioaddr[i] + UART_IER);
+                outb(inb(hwconf->ioaddr[i] + UART_IER) & 0xf0,
+                        hwconf->ioaddr[i] + UART_IER);
         }
 
         n = board * MXSER_PORTS_PER_BOARD;
         info = &mxvar_table[n];
 
-        retval = request_irq(hwconf->irq, mxser_interrupt, IRQ_T(info), "mxser", info);
+        retval = request_irq(hwconf->irq, mxser_interrupt, IRQ_T(info),
+                                "mxser", info);
         if (retval) {
-                printk(KERN_ERR "Board %d: %s", board, mxser_brdname[hwconf->board_type - 1]);
-                printk("  Request irq fail,IRQ (%d) may be conflit with another device.\n", info->irq);
+                printk(KERN_ERR "Board %d: %s",
+                        board, mxser_brdname[hwconf->board_type - 1]);
+                printk("  Request irq failed, IRQ (%d) may conflict with"
+                        " another device.\n", info->irq);
                 return retval;
         }
         return 0;
 }
 
-
 static void mxser_getcfg(int board, struct mxser_hwconf *hwconf)
 {
         mxsercfg[board] = *hwconf;
@@ -631,26 +635,27 @@ static void mxser_getcfg(int board, struct mxser_hwconf *hwconf)
 static int mxser_get_PCI_conf(int busnum, int devnum, int board_type, struct mxser_hwconf *hwconf)
 {
         int i, j;
-//      unsigned int    val;
+        /* unsigned int val; */
         unsigned int ioaddress;
         struct pci_dev *pdev = hwconf->pciInfo.pdev;
 
-        //io address
+        /* io address */
         hwconf->board_type = board_type;
         hwconf->ports = mxser_numports[board_type - 1];
         ioaddress = pci_resource_start(pdev, 2);
-        request_region(pci_resource_start(pdev, 2), pci_resource_len(pdev, 2), "mxser(IO)");
+        request_region(pci_resource_start(pdev, 2), pci_resource_len(pdev, 2),
+                        "mxser(IO)");
 
-        for (i = 0; i < hwconf->ports; i++) {
+        for (i = 0; i < hwconf->ports; i++)
                 hwconf->ioaddr[i] = ioaddress + 8 * i;
-        }
 
-        //vector
+        /* vector */
         ioaddress = pci_resource_start(pdev, 3);
-        request_region(pci_resource_start(pdev, 3), pci_resource_len(pdev, 3), "mxser(vector)");
+        request_region(pci_resource_start(pdev, 3), pci_resource_len(pdev, 3),
+                        "mxser(vector)");
         hwconf->vector = ioaddress;
 
-        //irq
+        /* irq */
         hwconf->irq = hwconf->pciInfo.pdev->irq;
 
         hwconf->IsMoxaMustChipFlag = CheckIsMoxaMust(hwconf->ioaddr[0]);
@@ -663,7 +668,7 @@ static int mxser_get_PCI_conf(int busnum, int devnum, int board_type, struct mxs
                         if (Gpci_uart_info[j].type == hwconf->IsMoxaMustChipFlag) {
                                 hwconf->MaxCanSetBaudRate[i] = Gpci_uart_info[j].max_baud;
 
-                                //exception....CP-102
+                                /* exception....CP-102 */
                                 if (board_type == MXSER_BOARD_CP102)
                                         hwconf->MaxCanSetBaudRate[i] = 921600;
                                 break;
@@ -678,15 +683,15 @@ static int mxser_get_PCI_conf(int busnum, int devnum, int board_type, struct mxs
                         else
                                 hwconf->opmode_ioaddr[i] = ioaddress + 0x0c;
                 }
-                outb(0, ioaddress + 4); // default set to RS232 mode
-                outb(0, ioaddress + 0x0c);      //default set to RS232 mode
+                outb(0, ioaddress + 4); /* default set to RS232 mode */
+                outb(0, ioaddress + 0x0c);      /* default set to RS232 mode */
         }
 
         for (i = 0; i < hwconf->ports; i++) {
                 hwconf->vector_mask |= (1 << i);
                 hwconf->baud_base[i] = 921600;
         }
-        return (0);
+        return 0;
 }
 #endif
 
@@ -707,7 +712,8 @@ static int mxser_init(void)
                 mxsercfg[i].board_type = -1;
         }
 
-        printk(KERN_INFO "MOXA Smartio/Industio family driver version %s\n", MXSER_VERSION);
+        printk(KERN_INFO "MOXA Smartio/Industio family driver version %s\n",
+                MXSER_VERSION);
 
         /* Initialize the tty_driver structure */
         memset(mxvar_sdriver, 0, sizeof(struct tty_driver));
@@ -719,7 +725,7 @@ static int mxser_init(void)
         mxvar_sdriver->type = TTY_DRIVER_TYPE_SERIAL;
         mxvar_sdriver->subtype = SERIAL_TYPE_NORMAL;
         mxvar_sdriver->init_termios = tty_std_termios;
-        mxvar_sdriver->init_termios.c_cflag = B9600 | CS8 | CREAD | HUPCL | CLOCAL;
+        mxvar_sdriver->init_termios.c_cflag = B9600|CS8|CREAD|HUPCL|CLOCAL;
         mxvar_sdriver->flags = TTY_DRIVER_REAL_RAW;
         tty_set_operations(mxvar_sdriver, &mxser_ops);
         mxvar_sdriver->ttys = mxvar_tty;
@@ -739,23 +745,29 @@ static int mxser_init(void)
         /* Start finding ISA boards here */
         for (b = 0; b < MXSER_BOARDS && m < MXSER_BOARDS; b++) {
                 int cap;
+
                 if (!(cap = mxserBoardCAP[b]))
                         continue;
 
                 retval = mxser_get_ISA_conf(cap, &hwconf);
 
                 if (retval != 0)
-                        printk(KERN_INFO "Found MOXA %s board (CAP=0x%x)\n", mxser_brdname[hwconf.board_type - 1], ioaddr[b]);
+                        printk(KERN_INFO "Found MOXA %s board (CAP=0x%x)\n",
+                                mxser_brdname[hwconf.board_type - 1], ioaddr[b]);
 
                 if (retval <= 0) {
                         if (retval == MXSER_ERR_IRQ)
-                                printk(KERN_ERR "Invalid interrupt number,board not configured\n");
+                                printk(KERN_ERR "Invalid interrupt number, "
+                                        "board not configured\n");
                         else if (retval == MXSER_ERR_IRQ_CONFLIT)
-                                printk(KERN_ERR "Invalid interrupt number,board not configured\n");
+                                printk(KERN_ERR "Invalid interrupt number, "
+                                        "board not configured\n");
                         else if (retval == MXSER_ERR_VECTOR)
-                                printk(KERN_ERR "Invalid interrupt vector,board not configured\n");
+                                printk(KERN_ERR "Invalid interrupt vector, "
+                                        "board not configured\n");
                         else if (retval == MXSER_ERR_IOADDR)
-                                printk(KERN_ERR "Invalid I/O address,board not configured\n");
+                                printk(KERN_ERR "Invalid I/O address, "
+                                        "board not configured\n");
 
                         continue;
                 }
@@ -765,35 +777,43 @@ static int mxser_init(void)
                 hwconf.pciInfo.pdev = NULL;
 
                 mxser_getcfg(m, &hwconf);
-                //init mxsercfg first, or mxsercfg data is not correct on ISR.
-                //mxser_initbrd will hook ISR.
+                /*
+                 * init mxsercfg first,
+                 * or mxsercfg data is not correct on ISR.
+                 */
+                /* mxser_initbrd will hook ISR. */
                 if (mxser_initbrd(m, &hwconf) < 0)
                         continue;
 
-
                 m++;
         }
 
         /* Start finding ISA boards from module arg */
         for (b = 0; b < MXSER_BOARDS && m < MXSER_BOARDS; b++) {
                 int cap;
+
                 if (!(cap = ioaddr[b]))
                         continue;
 
                 retval = mxser_get_ISA_conf(cap, &hwconf);
 
                 if (retval != 0)
-                        printk(KERN_INFO "Found MOXA %s board (CAP=0x%x)\n", mxser_brdname[hwconf.board_type - 1], ioaddr[b]);
+                        printk(KERN_INFO "Found MOXA %s board (CAP=0x%x)\n",
+                                mxser_brdname[hwconf.board_type - 1], ioaddr[b]);
 
                 if (retval <= 0) {
                         if (retval == MXSER_ERR_IRQ)
-                                printk(KERN_ERR "Invalid interrupt number,board not configured\n");
+                                printk(KERN_ERR "Invalid interrupt number, "
+                                        "board not configured\n");
                         else if (retval == MXSER_ERR_IRQ_CONFLIT)
-                                printk(KERN_ERR "Invalid interrupt number,board not configured\n");
+                                printk(KERN_ERR "Invalid interrupt number, "
+                                        "board not configured\n");
                         else if (retval == MXSER_ERR_VECTOR)
-                                printk(KERN_ERR "Invalid interrupt vector,board not configured\n");
+                                printk(KERN_ERR "Invalid interrupt vector, "
+                                        "board not configured\n");
                         else if (retval == MXSER_ERR_IOADDR)
-                                printk(KERN_ERR "Invalid I/O address,board not configured\n");
+                                printk(KERN_ERR "Invalid I/O address, "
+                                        "board not configured\n");
 
                         continue;
                 }
@@ -803,8 +823,11 @@ static int mxser_init(void)
                 hwconf.pciInfo.pdev = NULL;
 
                 mxser_getcfg(m, &hwconf);
-                //init mxsercfg first, or mxsercfg data is not correct on ISR.
-                //mxser_initbrd will hook ISR.
+                /*
+                 * init mxsercfg first,
+                 * or mxsercfg data is not correct on ISR.
+                 */
+                /* mxser_initbrd will hook ISR. */
                 if (mxser_initbrd(m, &hwconf) < 0)
                         continue;
 
@@ -817,7 +840,8 @@ static int mxser_init(void)
         index = 0;
         b = 0;
         while (b < n) {
-                pdev = pci_find_device(mxser_pcibrds[b].vendor, mxser_pcibrds[b].device, pdev);
+                pdev = pci_find_device(mxser_pcibrds[b].vendor,
+                                mxser_pcibrds[b].device, pdev);
                         if (pdev == NULL) {
                         b++;
                         continue;
@@ -825,30 +849,48 @@ static int mxser_init(void)
                 hwconf.pciInfo.busNum = busnum = pdev->bus->number;
                 hwconf.pciInfo.devNum = devnum = PCI_SLOT(pdev->devfn) << 3;
                 hwconf.pciInfo.pdev = pdev;
-                printk(KERN_INFO "Found MOXA %s board(BusNo=%d,DevNo=%d)\n", mxser_brdname[(int) (mxser_pcibrds[b].driver_data) - 1], busnum, devnum >> 3);
+                printk(KERN_INFO "Found MOXA %s board(BusNo=%d,DevNo=%d)\n",
+                        mxser_brdname[(int) (mxser_pcibrds[b].driver_data) - 1],
+                        busnum, devnum >> 3);
                 index++;
-                if (m >= MXSER_BOARDS) {
-                        printk(KERN_ERR "Too many Smartio/Industio family boards find (maximum %d),board not configured\n", MXSER_BOARDS);
-                } else {
+                if (m >= MXSER_BOARDS)
+                        printk(KERN_ERR
+                                "Too many Smartio/Industio family boards find "
+                                "(maximum %d), board not configured\n",
+                                MXSER_BOARDS);
+                else {
                         if (pci_enable_device(pdev)) {
-                                printk(KERN_ERR "Moxa SmartI/O PCI enable fail !\n");
+                                printk(KERN_ERR "Moxa SmartI/O PCI enable "
+                                        "fail !\n");
                                 continue;
                         }
-                        retval = mxser_get_PCI_conf(busnum, devnum, (int) mxser_pcibrds[b].driver_data, &hwconf);
+                        retval = mxser_get_PCI_conf(busnum, devnum,
+                                        (int)mxser_pcibrds[b].driver_data,
+                                        &hwconf);
                         if (retval < 0) {
                                 if (retval == MXSER_ERR_IRQ)
-                                        printk(KERN_ERR "Invalid interrupt number,board not configured\n");
+                                        printk(KERN_ERR
+                                                "Invalid interrupt number, "
+                                                "board not configured\n");
                                 else if (retval == MXSER_ERR_IRQ_CONFLIT)
-                                        printk(KERN_ERR "Invalid interrupt number,board not configured\n");
+                                        printk(KERN_ERR
+                                                "Invalid interrupt number, "
+                                                "board not configured\n");
                                 else if (retval == MXSER_ERR_VECTOR)
-                                        printk(KERN_ERR "Invalid interrupt vector,board not configured\n");
+                                        printk(KERN_ERR
+                                                "Invalid interrupt vector, "
+                                                "board not configured\n");
                                 else if (retval == MXSER_ERR_IOADDR)
-                                        printk(KERN_ERR "Invalid I/O address,board not configured\n");
+                                        printk(KERN_ERR
+                                                "Invalid I/O address, "
+                                                "board not configured\n");
                                 continue;
                         }
                         mxser_getcfg(m, &hwconf);
-                        //init mxsercfg first, or mxsercfg data is not correct on ISR.
-                        //mxser_initbrd will hook ISR.
+                        /* init mxsercfg first,
+                         * or mxsercfg data is not correct on ISR.
+                         */
+                        /* mxser_initbrd will hook ISR. */
                         if (mxser_initbrd(m, &hwconf) < 0)
                                 continue;
                         m++;
@@ -858,7 +900,8 @@ static int mxser_init(void)
 
         retval = tty_register_driver(mxvar_sdriver);
         if (retval) {
-                printk(KERN_ERR "Couldn't install MOXA Smartio/Industio family driver !\n");
+                printk(KERN_ERR "Couldn't install MOXA Smartio/Industio family"
+                                " driver !\n");
                 put_tty_driver(mxvar_sdriver);
 
                 for (i = 0; i < MXSER_BOARDS; i++) {
@@ -866,7 +909,7 @@ static int mxser_init(void)
                                 continue;
                         else {
                                 free_irq(mxsercfg[i].irq, &mxvar_table[i * MXSER_PORTS_PER_BOARD]);
-                                //todo: release io, vector
+                                /* todo: release io, vector */
                         }
                 }
                 return retval;
@@ -877,7 +920,7 @@ static int mxser_init(void)
 
 static void mxser_do_softint(void *private_)
 {
-        struct mxser_struct *info = (struct mxser_struct *) private_;
+        struct mxser_struct *info = private_;
         struct tty_struct *tty;
 
         tty = info->tty;
@@ -926,7 +969,7 @@ static int mxser_open(struct tty_struct *tty, struct file *filp)
                 return -ENODEV;
         info = mxvar_table + line;
         if (!info->base)
-                return (-ENODEV);
+                return -ENODEV;
 
         tty->driver_data = info;
         info->tty = tty;
@@ -935,11 +978,11 @@ static int mxser_open(struct tty_struct *tty, struct file *filp)
          */
         retval = mxser_startup(info);
         if (retval)
-                return (retval);
+                return retval;
 
         retval = mxser_block_til_ready(tty, filp, info);
         if (retval)
-                return (retval);
+                return retval;
 
         info->count++;
 
@@ -953,13 +996,13 @@ static int mxser_open(struct tty_struct *tty, struct file *filp)
 
         info->session = current->signal->session;
         info->pgrp = process_group(current);
-        clear_bit(TTY_DONT_FLIP, &tty->flags);
 
-        //status = mxser_get_msr(info->base, 0, info->port);
-        //mxser_check_modem_status(info, status);
+        /*
+        status = mxser_get_msr(info->base, 0, info->port);
+        mxser_check_modem_status(info, status);
+        */
 
-/* unmark here for very high baud rate (ex. 921600 bps) used
-*/
+/* unmark here for very high baud rate (ex. 921600 bps) used */
         tty->low_latency = 1;
         return 0;
 }
@@ -972,7 +1015,7 @@ static int mxser_open(struct tty_struct *tty, struct file *filp)
  */
 static void mxser_close(struct tty_struct *tty, struct file *filp)
 {
-        struct mxser_struct *info = (struct mxser_struct *) tty->driver_data;
+        struct mxser_struct *info = tty->driver_data;
 
         unsigned long timeout;
         unsigned long flags;
@@ -997,11 +1040,13 @@ static void mxser_close(struct tty_struct *tty, struct file *filp)
                  * one, we've got real problems, since it means the
                  * serial port won't be shutdown.
                  */
-                printk(KERN_ERR "mxser_close: bad serial port count; tty->count is 1, " "info->count is %d\n", info->count);
+                printk(KERN_ERR "mxser_close: bad serial port count; "
+                        "tty->count is 1, info->count is %d\n", info->count);
                 info->count = 1;
         }
         if (--info->count < 0) {
-                printk(KERN_ERR "mxser_close: bad serial port count for ttys%d: %d\n", info->port, info->count);
+                printk(KERN_ERR "mxser_close: bad serial port count for "
+                        "ttys%d: %d\n", info->port, info->count);
                 info->count = 0;
         }
         if (info->count) {
@@ -1056,7 +1101,7 @@ static void mxser_close(struct tty_struct *tty, struct file *filp)
                 
         ld = tty_ldisc_ref(tty);
         if (ld) {
-                if(ld->flush_buffer)
+                if (ld->flush_buffer)
                         ld->flush_buffer(tty);
                 tty_ldisc_deref(ld);
         }
@@ -1078,31 +1123,34 @@ static void mxser_close(struct tty_struct *tty, struct file *filp)
 static int mxser_write(struct tty_struct *tty, const unsigned char *buf, int count)
 {
         int c, total = 0;
-        struct mxser_struct *info = (struct mxser_struct *) tty->driver_data;
+        struct mxser_struct *info = tty->driver_data;
         unsigned long flags;
 
-        if (!tty || !info->xmit_buf)
-                return (0);
+        if (!info->xmit_buf)
+                return 0;
 
         while (1) {
-                c = min_t(int, count, min(SERIAL_XMIT_SIZE - info->xmit_cnt - 1, SERIAL_XMIT_SIZE - info->xmit_head));
+                c = min_t(int, count, min(SERIAL_XMIT_SIZE - info->xmit_cnt - 1,
+                                          SERIAL_XMIT_SIZE - info->xmit_head));
                 if (c <= 0)
                         break;
 
                 memcpy(info->xmit_buf + info->xmit_head, buf, c);
                 spin_lock_irqsave(&info->slock, flags);
-                info->xmit_head = (info->xmit_head + c) & (SERIAL_XMIT_SIZE - 1);
+                info->xmit_head = (info->xmit_head + c) &
+                                  (SERIAL_XMIT_SIZE - 1);
                 info->xmit_cnt += c;
                 spin_unlock_irqrestore(&info->slock, flags);
 
                 buf += c;
                 count -= c;
                 total += c;
-
         }
 
         if (info->xmit_cnt && !tty->stopped && !(info->IER & UART_IER_THRI)) {
-                if (!tty->hw_stopped || (info->type == PORT_16550A) || (info->IsMoxaMustChipFlag)) {
+                if (!tty->hw_stopped ||
+                                (info->type == PORT_16550A) ||
+                                (info->IsMoxaMustChipFlag)) {
                         spin_lock_irqsave(&info->slock, flags);
                         info->IER |= UART_IER_THRI;
                         outb(info->IER, info->base + UART_IER);
@@ -1114,10 +1162,10 @@ static int mxser_write(struct tty_struct *tty, const unsigned char *buf, int cou
 
 static void mxser_put_char(struct tty_struct *tty, unsigned char ch)
 {
-        struct mxser_struct *info = (struct mxser_struct *) tty->driver_data;
+        struct mxser_struct *info = tty->driver_data;
         unsigned long flags;
 
-        if (!tty || !info->xmit_buf)
+        if (!info->xmit_buf)
                 return;
 
         if (info->xmit_cnt >= SERIAL_XMIT_SIZE - 1)
@@ -1129,7 +1177,9 @@ static void mxser_put_char(struct tty_struct *tty, unsigned char ch)
         info->xmit_cnt++;
         spin_unlock_irqrestore(&info->slock, flags);
         if (!tty->stopped && !(info->IER & UART_IER_THRI)) {
-                if (!tty->hw_stopped || (info->type == PORT_16550A) || info->IsMoxaMustChipFlag) {
+                if (!tty->hw_stopped ||
+                                (info->type == PORT_16550A) ||
+                                info->IsMoxaMustChipFlag) {
                         spin_lock_irqsave(&info->slock, flags);
                         info->IER |= UART_IER_THRI;
                         outb(info->IER, info->base + UART_IER);
@@ -1141,10 +1191,16 @@ static void mxser_put_char(struct tty_struct *tty, unsigned char ch)
 
 static void mxser_flush_chars(struct tty_struct *tty)
 {
-        struct mxser_struct *info = (struct mxser_struct *) tty->driver_data;
+        struct mxser_struct *info = tty->driver_data;
         unsigned long flags;
 
-        if (info->xmit_cnt <= 0 || tty->stopped || !info->xmit_buf || (tty->hw_stopped && (info->type != PORT_16550A) && (!info->IsMoxaMustChipFlag)))
+        if (info->xmit_cnt <= 0 ||
+                        tty->stopped ||
+                        !info->xmit_buf ||
+                        (tty->hw_stopped &&
+                         (info->type != PORT_16550A) &&
+                         (!info->IsMoxaMustChipFlag)
+                        ))
                 return;
 
         spin_lock_irqsave(&info->slock, flags);
@@ -1157,24 +1213,24 @@ static void mxser_flush_chars(struct tty_struct *tty)
 
 static int mxser_write_room(struct tty_struct *tty)
 {
-        struct mxser_struct *info = (struct mxser_struct *) tty->driver_data;
+        struct mxser_struct *info = tty->driver_data;
         int ret;
 
         ret = SERIAL_XMIT_SIZE - info->xmit_cnt - 1;
         if (ret < 0)
                 ret = 0;
-        return (ret);
+        return ret;
 }
 
 static int mxser_chars_in_buffer(struct tty_struct *tty)
 {
-        struct mxser_struct *info = (struct mxser_struct *) tty->driver_data;
+        struct mxser_struct *info = tty->driver_data;
         return info->xmit_cnt;
 }
 
 static void mxser_flush_buffer(struct tty_struct *tty)
 {
-        struct mxser_struct *info = (struct mxser_struct *) tty->driver_data;
+        struct mxser_struct *info = tty->driver_data;
         char fcr;
         unsigned long flags;
 
@@ -1184,7 +1240,8 @@ static void mxser_flush_buffer(struct tty_struct *tty)
 
         /* below added by shinhay */
         fcr = inb(info->base + UART_FCR);
-        outb((fcr | UART_FCR_CLEAR_RCVR | UART_FCR_CLEAR_XMIT), info->base + UART_FCR);
+        outb((fcr | UART_FCR_CLEAR_RCVR | UART_FCR_CLEAR_XMIT),
+                info->base + UART_FCR);
         outb(fcr, info->base + UART_FCR);
 
         spin_unlock_irqrestore(&info->slock, flags);
@@ -1197,7 +1254,7 @@ static void mxser_flush_buffer(struct tty_struct *tty)
 
 static int mxser_ioctl(struct tty_struct *tty, struct file *file, unsigned int cmd, unsigned long arg)
 {
-        struct mxser_struct *info = (struct mxser_struct *) tty->driver_data;
+        struct mxser_struct *info = tty->driver_data;
         int retval;
         struct async_icount cprev, cnow;        /* kernel counter temps */
         struct serial_icounter_struct __user *p_cuser;
@@ -1206,9 +1263,9 @@ static int mxser_ioctl(struct tty_struct *tty, struct file *file, unsigned int c
         void __user *argp = (void __user *)arg;
 
         if (tty->index == MXSER_PORTS)
-                return (mxser_ioctl_special(cmd, argp));
+                return mxser_ioctl_special(cmd, argp);
 
-        // following add by Victor Yu. 01-05-2004
+        /* following add by Victor Yu. 01-05-2004 */
         if (cmd == MOXA_SET_OP_MODE || cmd == MOXA_GET_OP_MODE) {
                 int opmode, p;
                 static unsigned char ModeMask[] = { 0xfc, 0xf3, 0xcf, 0x3f };
@@ -1219,7 +1276,10 @@ static int mxser_ioctl(struct tty_struct *tty, struct file *file, unsigned int c
                 if (cmd == MOXA_SET_OP_MODE) {
                         if (get_user(opmode, (int __user *) argp))
                                 return -EFAULT;
-                        if (opmode != RS232_MODE && opmode != RS485_2WIRE_MODE && opmode != RS422_MODE && opmode != RS485_4WIRE_MODE)
+                        if (opmode != RS232_MODE &&
+                                        opmode != RS485_2WIRE_MODE &&
+                                        opmode != RS422_MODE &&
+                                        opmode != RS485_4WIRE_MODE)
                                 return -EFAULT;
                         mask = ModeMask[p];
                         shiftbit = p * 2;
@@ -1236,36 +1296,36 @@ static int mxser_ioctl(struct tty_struct *tty, struct file *file, unsigned int c
                 }
                 return 0;
         }
-        // above add by Victor Yu. 01-05-2004
+        /* above add by Victor Yu. 01-05-2004 */
 
         if ((cmd != TIOCGSERIAL) && (cmd != TIOCMIWAIT) && (cmd != TIOCGICOUNT)) {
                 if (tty->flags & (1 << TTY_IO_ERROR))
-                        return (-EIO);
+                        return -EIO;
         }
         switch (cmd) {
         case TCSBRK:            /* SVID version: non-zero arg --> no break */
                 retval = tty_check_change(tty);
                 if (retval)
-                        return (retval);
+                        return retval;
                 tty_wait_until_sent(tty, 0);
                 if (!arg)
                         mxser_send_break(info, HZ / 4); /* 1/4 second */
-                return (0);
+                return 0;
         case TCSBRKP:           /* support for POSIX tcsendbreak() */
                 retval = tty_check_change(tty);
                 if (retval)
-                        return (retval);
+                        return retval;
                 tty_wait_until_sent(tty, 0);
                 mxser_send_break(info, arg ? arg * (HZ / 10) : HZ / 4);
-                return (0);
+                return 0;
         case TIOCGSOFTCAR:
-                return put_user(C_CLOCAL(tty) ? 1 : 0, (unsigned long __user *) argp);
+                return put_user(C_CLOCAL(tty) ? 1 : 0, (unsigned long __user *)argp);
         case TIOCSSOFTCAR:
                 if (get_user(templ, (unsigned long __user *) argp))
                         return -EFAULT;
                 arg = templ;
                 tty->termios->c_cflag = ((tty->termios->c_cflag & ~CLOCAL) | (arg ? CLOCAL : 0));
-                return (0);
+                return 0;
         case TIOCGSERIAL:
                 return mxser_get_serial_info(info, argp);
         case TIOCSSERIAL:
@@ -1278,7 +1338,7 @@ static int mxser_ioctl(struct tty_struct *tty, struct file *file, unsigned int c
                  *   (use |'ed TIOCM_RNG/DSR/CD/CTS for masking)
                  * Caller should use TIOCGICOUNT to see which one it was
                  */
-        case TIOCMIWAIT:{
+        case TIOCMIWAIT: {
                         DECLARE_WAITQUEUE(wait, current);
                         int ret;
                         spin_lock_irqsave(&info->slock, flags);
@@ -1292,7 +1352,14 @@ static int mxser_ioctl(struct tty_struct *tty, struct file *file, unsigned int c
                                 spin_unlock_irqrestore(&info->slock, flags);
 
                                 set_current_state(TASK_INTERRUPTIBLE);
-                                if (((arg & TIOCM_RNG) && (cnow.rng != cprev.rng)) || ((arg & TIOCM_DSR) && (cnow.dsr != cprev.dsr)) || ((arg & TIOCM_CD) && (cnow.dcd != cprev.dcd)) || ((arg & TIOCM_CTS) && (cnow.cts != cprev.cts))) {
+                                if (((arg & TIOCM_RNG) &&
+                                                (cnow.rng != cprev.rng)) ||
+                                                ((arg & TIOCM_DSR) &&
+                                                (cnow.dsr != cprev.dsr)) ||
+                                                ((arg & TIOCM_CD) &&
+                                                (cnow.dcd != cprev.dcd)) ||
+                                                ((arg & TIOCM_CTS) &&
+                                                (cnow.cts != cprev.cts))) {
                                         ret = 0;
                                         break;
                                 }
@@ -1338,21 +1405,18 @@ static int mxser_ioctl(struct tty_struct *tty, struct file *file, unsigned int c
                 put_user(cnow.dsr, &p_cuser->dsr);
                 put_user(cnow.rng, &p_cuser->rng);
                 put_user(cnow.dcd, &p_cuser->dcd);
-
-/* */
                 return 0;
         case MOXA_HighSpeedOn:
-                return put_user(info->baud_base != 115200 ? 1 : 0, (int __user *) argp);
-
-        case MOXA_SDS_RSTICOUNTER:{
+                return put_user(info->baud_base != 115200 ? 1 : 0, (int __user *)argp);
+        case MOXA_SDS_RSTICOUNTER: {
                         info->mon_data.rxcnt = 0;
                         info->mon_data.txcnt = 0;
                         return 0;
                 }
-// (above) added by James.
+/* (above) added by James. */
         case MOXA_ASPP_SETBAUD:{
                         long baud;
-                        if (get_user(baud, (long __user *) argp))
+                        if (get_user(baud, (long __user *)argp))
                                 return -EFAULT;
                         mxser_set_baud(info, baud);
                         return 0;
@@ -1377,9 +1441,10 @@ static int mxser_ioctl(struct tty_struct *tty, struct file *file, unsigned int c
 
                         return 0;
                 }
-        case MOXA_ASPP_MON:{
+        case MOXA_ASPP_MON: {
                         int mcr, status;
-//      info->mon_data.ser_param = tty->termios->c_cflag;
+
+                        /* info->mon_data.ser_param = tty->termios->c_cflag; */
 
                         status = mxser_get_msr(info->base, 1, info->port, info);
                         mxser_check_modem_status(info, status);
@@ -1400,25 +1465,25 @@ static int mxser_ioctl(struct tty_struct *tty, struct file *file, unsigned int c
                         else
                                 info->mon_data.hold_reason &= ~NPPI_NOTIFY_CTSHOLD;
 
-
-                        if (copy_to_user(argp, &info->mon_data, sizeof(struct mxser_mon)))
+                        if (copy_to_user(argp, &info->mon_data,
+                                        sizeof(struct mxser_mon)))
                                 return -EFAULT;
 
                         return 0;
-
                 }
 
-        case MOXA_ASPP_LSTATUS:{
-                        if (copy_to_user(argp, &info->err_shadow, sizeof(unsigned char)))
+        case MOXA_ASPP_LSTATUS: {
+                        if (copy_to_user(argp, &info->err_shadow,
+                                        sizeof(unsigned char)))
                                 return -EFAULT;
 
                         info->err_shadow = 0;
                         return 0;
-
                 }
-        case MOXA_SET_BAUD_METHOD:{
+        case MOXA_SET_BAUD_METHOD: {
                         int method;
-                        if (get_user(method, (int __user *) argp))
+
+                        if (get_user(method, (int __user *)argp))
                                 return -EFAULT;
                         mxser_set_baud_method[info->port] = method;
                         if (copy_to_user(argp, &method, sizeof(int)))
@@ -1442,7 +1507,8 @@ static int mxser_ioctl_special(unsigned int cmd, void __user *argp)
 
         switch (cmd) {
         case MOXA_GET_CONF:
-                if (copy_to_user(argp, mxsercfg, sizeof(struct mxser_hwconf) * 4))
+                if (copy_to_user(argp, mxsercfg,
+                                sizeof(struct mxser_hwconf) * 4))
                         return -EFAULT;
                 return 0;
         case MOXA_GET_MAJOR:
@@ -1461,11 +1527,11 @@ static int mxser_ioctl_special(unsigned int cmd, void __user *argp)
                         if (mxvar_table[i].base)
                                 result |= (1 << i);
                 }
-                return put_user(result, (unsigned long __user *) argp);
+                return put_user(result, (unsigned long __user *)argp);
         case MOXA_GETDATACOUNT:
                 if (copy_to_user(argp, &mxvar_log, sizeof(mxvar_log)))
                         return -EFAULT;
-                return (0);
+                return 0;
         case MOXA_GETMSTATUS:
                 for (i = 0; i < MXSER_PORTS; i++) {
                         GMStatus[i].ri = 0;
@@ -1498,22 +1564,26 @@ static int mxser_ioctl_special(unsigned int cmd, void __user *argp)
                         else
                                 GMStatus[i].cts = 0;
                 }
-                if (copy_to_user(argp, GMStatus, sizeof(struct mxser_mstatus) * MXSER_PORTS))
+                if (copy_to_user(argp, GMStatus,
+                                sizeof(struct mxser_mstatus) * MXSER_PORTS))
                         return -EFAULT;
                 return 0;
-        case MOXA_ASPP_MON_EXT:{
+        case MOXA_ASPP_MON_EXT: {
                         int status;
                         int opmode, p;
                         int shiftbit;
                         unsigned cflag, iflag;
 
                         for (i = 0; i < MXSER_PORTS; i++) {
-
                                 if (!mxvar_table[i].base)
                                         continue;
 
-                                status = mxser_get_msr(mxvar_table[i].base, 0, i, &(mxvar_table[i]));
-//                      mxser_check_modem_status(&mxvar_table[i], status);
+                                status = mxser_get_msr(mxvar_table[i].base, 0,
+                                                        i, &(mxvar_table[i]));
+                                /*
+                                mxser_check_modem_status(&mxvar_table[i],
+                                                                status);
+                                */
                                 if (status & UART_MSR_TERI)
                                         mxvar_table[i].icount.rng++;
                                 if (status & UART_MSR_DDSR)
@@ -1578,75 +1648,76 @@ static int mxser_ioctl_special(unsigned int cmd, void __user *argp)
         return 0;
 }
 
-
 static void mxser_stoprx(struct tty_struct *tty)
 {
-        struct mxser_struct *info = (struct mxser_struct *) tty->driver_data;
-        //unsigned long flags;
-
+        struct mxser_struct *info = tty->driver_data;
+        /* unsigned long flags; */
 
         info->ldisc_stop_rx = 1;
         if (I_IXOFF(tty)) {
-
-                //MX_LOCK(&info->slock);
-                // following add by Victor Yu. 09-02-2002
+                /* MX_LOCK(&info->slock); */
+                /* following add by Victor Yu. 09-02-2002 */
                 if (info->IsMoxaMustChipFlag) {
                         info->IER &= ~MOXA_MUST_RECV_ISR;
                         outb(info->IER, info->base + UART_IER);
                 } else {
-                        // above add by Victor Yu. 09-02-2002
-
+                        /* above add by Victor Yu. 09-02-2002 */
                         info->x_char = STOP_CHAR(tty);
-                        //      outb(info->IER, 0); // mask by Victor Yu. 09-02-2002
+                        /* mask by Victor Yu. 09-02-2002 */
+                        /* outb(info->IER, 0); */
                         outb(0, info->base + UART_IER);
                         info->IER |= UART_IER_THRI;
-                        outb(info->IER, info->base + UART_IER); /* force Tx interrupt */
-                }               // add by Victor Yu. 09-02-2002
-                //MX_UNLOCK(&info->slock);
+                        /* force Tx interrupt */
+                        outb(info->IER, info->base + UART_IER);
+                }               /* add by Victor Yu. 09-02-2002 */
+                /* MX_UNLOCK(&info->slock); */
         }
 
         if (info->tty->termios->c_cflag & CRTSCTS) {
-                //MX_LOCK(&info->slock);
+                /* MX_LOCK(&info->slock); */
                 info->MCR &= ~UART_MCR_RTS;
                 outb(info->MCR, info->base + UART_MCR);
-                //MX_UNLOCK(&info->slock);
+                /* MX_UNLOCK(&info->slock); */
         }
 }
 
 static void mxser_startrx(struct tty_struct *tty)
 {
-        struct mxser_struct *info = (struct mxser_struct *) tty->driver_data;
-        //unsigned long flags;
+        struct mxser_struct *info = tty->driver_data;
+        /* unsigned long flags; */
 
         info->ldisc_stop_rx = 0;
         if (I_IXOFF(tty)) {
                 if (info->x_char)
                         info->x_char = 0;
                 else {
-                        //MX_LOCK(&info->slock);
+                        /* MX_LOCK(&info->slock); */
 
-                        // following add by Victor Yu. 09-02-2002
+                        /* following add by Victor Yu. 09-02-2002 */
                         if (info->IsMoxaMustChipFlag) {
                                 info->IER |= MOXA_MUST_RECV_ISR;
                                 outb(info->IER, info->base + UART_IER);
                         } else {
-                                // above add by Victor Yu. 09-02-2002
+                                /* above add by Victor Yu. 09-02-2002 */
 
                                 info->x_char = START_CHAR(tty);
-                                //          outb(info->IER, 0); // mask by Victor Yu. 09-02-2002
-                                outb(0, info->base + UART_IER); // add by Victor Yu. 09-02-2002
-                                info->IER |= UART_IER_THRI;     /* force Tx interrupt */
+                                /* mask by Victor Yu. 09-02-2002 */
+                                /* outb(info->IER, 0); */
+                                /* add by Victor Yu. 09-02-2002 */
+                                outb(0, info->base + UART_IER);
+                                /* force Tx interrupt */
+                                info->IER |= UART_IER_THRI;
                                 outb(info->IER, info->base + UART_IER);
-                        }       // add by Victor Yu. 09-02-2002
-                        //MX_UNLOCK(&info->slock);
+                        }       /* add by Victor Yu. 09-02-2002 */
+                        /* MX_UNLOCK(&info->slock); */
                 }
         }
 
         if (info->tty->termios->c_cflag & CRTSCTS) {
-                //MX_LOCK(&info->slock);
+                /* MX_LOCK(&info->slock); */
                 info->MCR |= UART_MCR_RTS;
                 outb(info->MCR, info->base + UART_MCR);
-                //MX_UNLOCK(&info->slock);
+                /* MX_UNLOCK(&info->slock); */
         }
 }
 
@@ -1656,48 +1727,53 @@ static void mxser_startrx(struct tty_struct *tty)
  */
 static void mxser_throttle(struct tty_struct *tty)
 {
-        //struct mxser_struct *info = (struct mxser_struct *)tty->driver_data;
-        //unsigned long flags;
-        //MX_LOCK(&info->slock);
+        /* struct mxser_struct *info = tty->driver_data; */
+        /* unsigned long flags; */
+
+        /* MX_LOCK(&info->slock); */
         mxser_stoprx(tty);
-        //MX_UNLOCK(&info->slock);
+        /* MX_UNLOCK(&info->slock); */
 }
 
 static void mxser_unthrottle(struct tty_struct *tty)
 {
-        //struct mxser_struct *info = (struct mxser_struct *)tty->driver_data;
-        //unsigned long flags;
-        //MX_LOCK(&info->slock);
+        /* struct mxser_struct *info = tty->driver_data; */
+        /* unsigned long flags; */
+
+        /* MX_LOCK(&info->slock); */
         mxser_startrx(tty);
-        //MX_UNLOCK(&info->slock);
+        /* MX_UNLOCK(&info->slock); */
 }
 
 static void mxser_set_termios(struct tty_struct *tty, struct termios *old_termios)
 {
-        struct mxser_struct *info = (struct mxser_struct *) tty->driver_data;
+        struct mxser_struct *info = tty->driver_data;
         unsigned long flags;
 
-        if ((tty->termios->c_cflag != old_termios->c_cflag) || (RELEVANT_IFLAG(tty->termios->c_iflag) != RELEVANT_IFLAG(old_termios->c_iflag))) {
+        if ((tty->termios->c_cflag != old_termios->c_cflag) ||
+                        (RELEVANT_IFLAG(tty->termios->c_iflag) != RELEVANT_IFLAG(old_termios->c_iflag))) {
 
                 mxser_change_speed(info, old_termios);
 
-                if ((old_termios->c_cflag & CRTSCTS) && !(tty->termios->c_cflag & CRTSCTS)) {
+                if ((old_termios->c_cflag & CRTSCTS) &&
+                                !(tty->termios->c_cflag & CRTSCTS)) {
                         tty->hw_stopped = 0;
                         mxser_start(tty);
                 }
         }
 
 /* Handle sw stopped */
-        if ((old_termios->c_iflag & IXON) && !(tty->termios->c_iflag & IXON)) {
+        if ((old_termios->c_iflag & IXON) &&
+                        !(tty->termios->c_iflag & IXON)) {
                 tty->stopped = 0;
 
-                // following add by Victor Yu. 09-02-2002
+                /* following add by Victor Yu. 09-02-2002 */
                 if (info->IsMoxaMustChipFlag) {
                         spin_lock_irqsave(&info->slock, flags);
                         DISABLE_MOXA_MUST_RX_SOFTWARE_FLOW_CONTROL(info->base);
                         spin_unlock_irqrestore(&info->slock, flags);
                 }
-                // above add by Victor Yu. 09-02-2002
+                /* above add by Victor Yu. 09-02-2002 */
 
                 mxser_start(tty);
         }
@@ -1711,7 +1787,7 @@ static void mxser_set_termios(struct tty_struct *tty, struct termios *old_termio
  */
 static void mxser_stop(struct tty_struct *tty)
 {
-        struct mxser_struct *info = (struct mxser_struct *) tty->driver_data;
+        struct mxser_struct *info = tty->driver_data;
         unsigned long flags;
 
         spin_lock_irqsave(&info->slock, flags);
@@ -1724,7 +1800,7 @@ static void mxser_stop(struct tty_struct *tty)
 
 static void mxser_start(struct tty_struct *tty)
 {
-        struct mxser_struct *info = (struct mxser_struct *) tty->driver_data;
+        struct mxser_struct *info = tty->driver_data;
         unsigned long flags;
 
         spin_lock_irqsave(&info->slock, flags);
@@ -1740,7 +1816,7 @@ static void mxser_start(struct tty_struct *tty)
  */
 static void mxser_wait_until_sent(struct tty_struct *tty, int timeout)
 {
-        struct mxser_struct *info = (struct mxser_struct *) tty->driver_data;
+        struct mxser_struct *info = tty->driver_data;
         unsigned long orig_jiffies, char_time;
         int lsr;
 
@@ -1777,7 +1853,8 @@ static void mxser_wait_until_sent(struct tty_struct *tty, int timeout)
         if (!timeout || timeout > 2 * info->timeout)
                 timeout = 2 * info->timeout;
 #ifdef SERIAL_DEBUG_RS_WAIT_UNTIL_SENT
-        printk(KERN_DEBUG "In rs_wait_until_sent(%d) check=%lu...", timeout, char_time);
+        printk(KERN_DEBUG "In rs_wait_until_sent(%d) check=%lu...",
+                timeout, char_time);
         printk("jiff=%lu...", jiffies);
 #endif
         while (!((lsr = inb(info->base + UART_LSR)) & UART_LSR_TEMT)) {
@@ -1803,7 +1880,7 @@ static void mxser_wait_until_sent(struct tty_struct *tty, int timeout)
  */
 void mxser_hangup(struct tty_struct *tty)
 {
-        struct mxser_struct *info = (struct mxser_struct *) tty->driver_data;
+        struct mxser_struct *info = tty->driver_data;
 
         mxser_flush_buffer(tty);
         mxser_shutdown(info);
@@ -1815,24 +1892,26 @@ void mxser_hangup(struct tty_struct *tty)
 }
 
 
-// added by James 03-12-2004.
+/* added by James 03-12-2004. */
 /*
  * mxser_rs_break() --- routine which turns the break handling on or off
  */
 static void mxser_rs_break(struct tty_struct *tty, int break_state)
 {
-        struct mxser_struct *info = (struct mxser_struct *) tty->driver_data;
+        struct mxser_struct *info = tty->driver_data;
         unsigned long flags;
 
         spin_lock_irqsave(&info->slock, flags);
         if (break_state == -1)
-                outb(inb(info->base + UART_LCR) | UART_LCR_SBC, info->base + UART_LCR);
+                outb(inb(info->base + UART_LCR) | UART_LCR_SBC,
+                        info->base + UART_LCR);
         else
-                outb(inb(info->base + UART_LCR) & ~UART_LCR_SBC, info->base + UART_LCR);
+                outb(inb(info->base + UART_LCR) & ~UART_LCR_SBC,
+                        info->base + UART_LCR);
         spin_unlock_irqrestore(&info->slock, flags);
 }
 
-// (above) added by James.
+/* (above) added by James. */
 
 
 /*
@@ -1848,7 +1927,7 @@ static irqreturn_t mxser_interrupt(int irq, void *dev_id, struct pt_regs *regs)
         int handled = IRQ_NONE;
 
         port = NULL;
-        //spin_lock(&gm_lock);
+        /* spin_lock(&gm_lock); */
 
         for (i = 0; i < MXSER_BOARDS; i++) {
                 if (dev_id == &(mxvar_table[i * MXSER_PORTS_PER_BOARD])) {
@@ -1857,29 +1936,25 @@ static irqreturn_t mxser_interrupt(int irq, void *dev_id, struct pt_regs *regs)
                 }
         }
 
-        if (i == MXSER_BOARDS) {
+        if (i == MXSER_BOARDS)
                 goto irq_stop;
-        }
-        if (port == 0) {
+        if (port == 0)
                 goto irq_stop;
-        }
         max = mxser_numports[mxsercfg[i].board_type - 1];
         while (1) {
                 irqbits = inb(port->vector) & port->vectormask;
-                if (irqbits == port->vectormask) {
+                if (irqbits == port->vectormask)
                         break;
-                }
 
                 handled = IRQ_HANDLED;
                 for (i = 0, bits = 1; i < max; i++, irqbits |= bits, bits <<= 1) {
-                        if (irqbits == port->vectormask) {
+                        if (irqbits == port->vectormask)
                                 break;
-                        }
                         if (bits & irqbits)
                                 continue;
                         info = port + i;
 
-                        // following add by Victor Yu. 09-13-2002
+                        /* following add by Victor Yu. 09-13-2002 */
                         iir = inb(info->base + UART_IIR);
                         if (iir & UART_IIR_NO_INT)
                                 continue;
@@ -1890,9 +1965,9 @@ static irqreturn_t mxser_interrupt(int irq, void *dev_id, struct pt_regs *regs)
                                 inb(info->base + UART_MSR);
                                 continue;
                         }
-                        // above add by Victor Yu. 09-13-2002
+                        /* above add by Victor Yu. 09-13-2002 */
                         /*
-                           if ( info->tty->flip.count < TTY_FLIPBUF_SIZE/4 ){
+                           if (info->tty->flip.count < TTY_FLIPBUF_SIZE / 4) {
                            info->IER |= MOXA_MUST_RECV_ISR;
                            outb(info->IER, info->base + UART_IER);
                            }
@@ -1908,18 +1983,15 @@ static irqreturn_t mxser_interrupt(int irq, void *dev_id, struct pt_regs *regs)
                            status = inb(info->base + UART_LSR) & info->read_status_mask;
                          */
 
-                        // following add by Victor Yu. 09-02-2002
+                        /* following add by Victor Yu. 09-02-2002 */
                         status = inb(info->base + UART_LSR);
 
-                        if (status & UART_LSR_PE) {
+                        if (status & UART_LSR_PE)
                                 info->err_shadow |= NPPI_NOTIFY_PARITY;
-                        }
-                        if (status & UART_LSR_FE) {
+                        if (status & UART_LSR_FE)
                                 info->err_shadow |= NPPI_NOTIFY_FRAMING;
-                        }
-                        if (status & UART_LSR_OE) {
+                        if (status & UART_LSR_OE)
                                 info->err_shadow |= NPPI_NOTIFY_HW_OVERRUN;
-                        }
                         if (status & UART_LSR_BI)
                                 info->err_shadow |= NPPI_NOTIFY_BREAK;
 
@@ -1930,11 +2002,14 @@ static irqreturn_t mxser_interrupt(int irq, void *dev_id, struct pt_regs *regs)
                                    continue;
                                    }
                                  */
-                                if (iir == MOXA_MUST_IIR_GDA || iir == MOXA_MUST_IIR_RDA || iir == MOXA_MUST_IIR_RTO || iir == MOXA_MUST_IIR_LSR)
+                                if (iir == MOXA_MUST_IIR_GDA ||
+                                                iir == MOXA_MUST_IIR_RDA ||
+                                                iir == MOXA_MUST_IIR_RTO ||
+                                                iir == MOXA_MUST_IIR_LSR)
                                         mxser_receive_chars(info, &status);
 
                         } else {
-                                // above add by Victor Yu. 09-02-2002
+                                /* above add by Victor Yu. 09-02-2002 */
 
                                 status &= info->read_status_mask;
                                 if (status & UART_LSR_DR)
@@ -1944,13 +2019,13 @@ static irqreturn_t mxser_interrupt(int irq, void *dev_id, struct pt_regs *regs)
                         if (msr & UART_MSR_ANY_DELTA) {
                                 mxser_check_modem_status(info, msr);
                         }
-                        // following add by Victor Yu. 09-13-2002
+                        /* following add by Victor Yu. 09-13-2002 */
                         if (info->IsMoxaMustChipFlag) {
                                 if ((iir == 0x02) && (status & UART_LSR_THRE)) {
                                         mxser_transmit_chars(info);
                                 }
                         } else {
-                                // above add by Victor Yu. 09-13-2002
+                                /* above add by Victor Yu. 09-13-2002 */
 
                                 if (status & UART_LSR_THRE) {
 /* 8-2-99 by William
@@ -1966,7 +2041,7 @@ static irqreturn_t mxser_interrupt(int irq, void *dev_id, struct pt_regs *regs)
         }
 
       irq_stop:
-        //spin_unlock(&gm_lock);
+        /* spin_unlock(&gm_lock); */
         return handled;
 }
 
@@ -1984,56 +2059,58 @@ static void mxser_receive_chars(struct mxser_struct *info, int *status)
 
         recv_room = tty->receive_room;
         if ((recv_room == 0) && (!info->ldisc_stop_rx)) {
-                //mxser_throttle(tty);
+                /* mxser_throttle(tty); */
                 mxser_stoprx(tty);
-                //return;
+                /* return; */
         }
 
-        // following add by Victor Yu. 09-02-2002
+        /* following add by Victor Yu. 09-02-2002 */
         if (info->IsMoxaMustChipFlag != MOXA_OTHER_UART) {
 
                 if (*status & UART_LSR_SPECIAL) {
                         goto intr_old;
                 }
-                // following add by Victor Yu. 02-11-2004
-                if (info->IsMoxaMustChipFlag == MOXA_MUST_MU860_HWID && (*status & MOXA_MUST_LSR_RERR))
+                /* following add by Victor Yu. 02-11-2004 */
+                if (info->IsMoxaMustChipFlag == MOXA_MUST_MU860_HWID &&
+                                (*status & MOXA_MUST_LSR_RERR))
                         goto intr_old;
-                // above add by Victor Yu. 02-14-2004
+                /* above add by Victor Yu. 02-14-2004 */
                 if (*status & MOXA_MUST_LSR_RERR)
                         goto intr_old;
 
                 gdl = inb(info->base + MOXA_MUST_GDL_REGISTER);
 
-                if (info->IsMoxaMustChipFlag == MOXA_MUST_MU150_HWID)   // add by Victor Yu. 02-11-2004
+                /* add by Victor Yu. 02-11-2004 */
+                if (info->IsMoxaMustChipFlag == MOXA_MUST_MU150_HWID)
                         gdl &= MOXA_MUST_GDL_MASK;
                 if (gdl >= recv_room) {
                         if (!info->ldisc_stop_rx) {
-                                //mxser_throttle(tty);
+                                /* mxser_throttle(tty); */
                                 mxser_stoprx(tty);
                         }
-                        //return;
+                        /* return; */
                 }
                 while (gdl--) {
                         ch = inb(info->base + UART_RX);
                         tty_insert_flip_char(tty, ch, 0);
                         cnt++;
                         /*
-                           if((cnt>=HI_WATER) && (info->stop_rx==0)){
+                           if ((cnt >= HI_WATER) && (info->stop_rx == 0)) {
                            mxser_stoprx(tty);
-                           info->stop_rx=1;
+                           info->stop_rx = 1;
                            break;
                            } */
                 }
                 goto end_intr;
         }
-intr_old:
-        // above add by Victor Yu. 09-02-2002
+ intr_old:
+        /* above add by Victor Yu. 09-02-2002 */
 
         do {
                 if (max-- < 0)
                         break;
                 /*
-                   if((cnt>=HI_WATER) && (info->stop_rx==0)){
+                   if ((cnt >= HI_WATER) && (info->stop_rx == 0)) {
                    mxser_stoprx(tty);
                    info->stop_rx=1;
                    break;
@@ -2041,11 +2118,11 @@ intr_old:
                  */
 
                 ch = inb(info->base + UART_RX);
-                // following add by Victor Yu. 09-02-2002
+                /* following add by Victor Yu. 09-02-2002 */
                 if (info->IsMoxaMustChipFlag && (*status & UART_LSR_OE) /*&& !(*status&UART_LSR_DR) */ )
                         outb(0x23, info->base + UART_FCR);
                 *status &= info->read_status_mask;
-                // above add by Victor Yu. 09-02-2002
+                /* above add by Victor Yu. 09-02-2002 */
                 if (*status & info->ignore_status_mask) {
                         if (++ignored > 100)
                                 break;
@@ -2080,7 +2157,7 @@ intr_old:
                         cnt++;
                         if (cnt >= recv_room) {
                                 if (!info->ldisc_stop_rx) {
-                                        //mxser_throttle(tty);
+                                        /* mxser_throttle(tty); */
                                         mxser_stoprx(tty);
                                 }
                                 break;
@@ -2088,21 +2165,20 @@ intr_old:
 
                 }
 
-                // following add by Victor Yu. 09-02-2002
+                /* following add by Victor Yu. 09-02-2002 */
                 if (info->IsMoxaMustChipFlag)
                         break;
-                // above add by Victor Yu. 09-02-2002
+                /* above add by Victor Yu. 09-02-2002 */
 
                 /* mask by Victor Yu. 09-02-2002
                  *status = inb(info->base + UART_LSR) & info->read_status_mask;
                  */
-                // following add by Victor Yu. 09-02-2002
+                /* following add by Victor Yu. 09-02-2002 */
                 *status = inb(info->base + UART_LSR);
-                // above add by Victor Yu. 09-02-2002
+                /* above add by Victor Yu. 09-02-2002 */
         } while (*status & UART_LSR_DR);
 
-end_intr:               // add by Victor Yu. 09-02-2002
-
+end_intr:               /* add by Victor Yu. 09-02-2002 */
         mxvar_log.rxcnt[info->port] += cnt;
         info->mon_data.rxcnt += cnt;
         info->mon_data.up_rxcnt += cnt;
@@ -2137,7 +2213,10 @@ static void mxser_transmit_chars(struct mxser_struct *info)
                 return;
         }
 
-        if ((info->xmit_cnt <= 0) || info->tty->stopped || (info->tty->hw_stopped && (info->type != PORT_16550A) && (!info->IsMoxaMustChipFlag))) {
+        if ((info->xmit_cnt <= 0) || info->tty->stopped ||
+                        (info->tty->hw_stopped &&
+                        (info->type != PORT_16550A) &&
+                        (!info->IsMoxaMustChipFlag))) {
                 info->IER &= ~UART_IER_THRI;
                 outb(info->IER, info->base + UART_IER);
                 spin_unlock_irqrestore(&info->slock, flags);
@@ -2147,17 +2226,18 @@ static void mxser_transmit_chars(struct mxser_struct *info)
         cnt = info->xmit_cnt;
         count = info->xmit_fifo_size;
         do {
-                outb(info->xmit_buf[info->xmit_tail++], info->base + UART_TX);
+                outb(info->xmit_buf[info->xmit_tail++],
+                        info->base + UART_TX);
                 info->xmit_tail = info->xmit_tail & (SERIAL_XMIT_SIZE - 1);
                 if (--info->xmit_cnt <= 0)
                         break;
         } while (--count > 0);
         mxvar_log.txcnt[info->port] += (cnt - info->xmit_cnt);
 
-// added by James 03-12-2004.
+/* added by James 03-12-2004. */
         info->mon_data.txcnt += (cnt - info->xmit_cnt);
         info->mon_data.up_txcnt += (cnt - info->xmit_cnt);
-// (above) added by James.
+/* (above) added by James. */
 
 /* added by casper 1/11/2000 */
         info->icount.tx += (cnt - info->xmit_cnt);
@@ -2188,7 +2268,6 @@ static void mxser_check_modem_status(struct mxser_struct *info, int status)
         info->mon_data.modem_status = status;
         wake_up_interruptible(&info->delta_msr_wait);
 
-
         if ((info->flags & ASYNC_CHECK_CD) && (status & UART_MSR_DDCD)) {
                 if (status & UART_MSR_DCD)
                         wake_up_interruptible(&info->open_wait);
@@ -2200,7 +2279,8 @@ static void mxser_check_modem_status(struct mxser_struct *info, int status)
                         if (status & UART_MSR_CTS) {
                                 info->tty->hw_stopped = 0;
 
-                                if ((info->type != PORT_16550A) && (!info->IsMoxaMustChipFlag)) {
+                                if ((info->type != PORT_16550A) &&
+                                                (!info->IsMoxaMustChipFlag)) {
                                         info->IER |= UART_IER_THRI;
                                         outb(info->IER, info->base + UART_IER);
                                 }
@@ -2209,7 +2289,8 @@ static void mxser_check_modem_status(struct mxser_struct *info, int status)
                 } else {
                         if (!(status & UART_MSR_CTS)) {
                                 info->tty->hw_stopped = 1;
-                                if ((info->type != PORT_16550A) && (!info->IsMoxaMustChipFlag)) {
+                                if ((info->type != PORT_16550A) &&
+                                                (!info->IsMoxaMustChipFlag)) {
                                         info->IER &= ~UART_IER_THRI;
                                         outb(info->IER, info->base + UART_IER);
                                 }
@@ -2231,7 +2312,7 @@ static int mxser_block_til_ready(struct tty_struct *tty, struct file *filp, stru
          */
         if ((filp->f_flags & O_NONBLOCK) || (tty->flags & (1 << TTY_IO_ERROR))) {
                 info->flags |= ASYNC_NORMAL_ACTIVE;
-                return (0);
+                return 0;
         }
 
         if (tty->termios->c_cflag & CLOCAL)
@@ -2254,7 +2335,8 @@ static int mxser_block_til_ready(struct tty_struct *tty, struct file *filp, stru
         info->blocked_open++;
         while (1) {
                 spin_lock_irqsave(&info->slock, flags);
-                outb(inb(info->base + UART_MCR) | UART_MCR_DTR | UART_MCR_RTS, info->base + UART_MCR);
+                outb(inb(info->base + UART_MCR) |
+                        UART_MCR_DTR | UART_MCR_RTS, info->base + UART_MCR);
                 spin_unlock_irqrestore(&info->slock, flags);
                 set_current_state(TASK_INTERRUPTIBLE);
                 if (tty_hung_up_p(filp) || !(info->flags & ASYNC_INITIALIZED)) {
@@ -2264,7 +2346,9 @@ static int mxser_block_til_ready(struct tty_struct *tty, struct file *filp, stru
                                 retval = -ERESTARTSYS;
                         break;
                 }
-                if (!(info->flags & ASYNC_CLOSING) && (do_clocal || (inb(info->base + UART_MSR) & UART_MSR_DCD)))
+                if (!(info->flags & ASYNC_CLOSING) &&
+                                (do_clocal ||
+                                (inb(info->base + UART_MSR) & UART_MSR_DCD)))
                         break;
                 if (signal_pending(current)) {
                         retval = -ERESTARTSYS;
@@ -2278,27 +2362,26 @@ static int mxser_block_til_ready(struct tty_struct *tty, struct file *filp, stru
                 info->count++;
         info->blocked_open--;
         if (retval)
-                return (retval);
+                return retval;
         info->flags |= ASYNC_NORMAL_ACTIVE;
-        return (0);
+        return 0;
 }
 
 static int mxser_startup(struct mxser_struct *info)
 {
-
         unsigned long page;
         unsigned long flags;
 
         page = __get_free_page(GFP_KERNEL);
         if (!page)
-                return (-ENOMEM);
+                return -ENOMEM;
 
         spin_lock_irqsave(&info->slock, flags);
 
         if (info->flags & ASYNC_INITIALIZED) {
                 free_page(page);
                 spin_unlock_irqrestore(&info->slock, flags);
-                return (0);
+                return 0;
         }
 
         if (!info->base || !info->type) {
@@ -2306,7 +2389,7 @@ static int mxser_startup(struct mxser_struct *info)
                         set_bit(TTY_IO_ERROR, &info->tty->flags);
                 free_page(page);
                 spin_unlock_irqrestore(&info->slock, flags);
-                return (0);
+                return 0;
         }
         if (info->xmit_buf)
                 free_page(page);
@@ -2318,9 +2401,12 @@ static int mxser_startup(struct mxser_struct *info)
          * (they will be reenabled in mxser_change_speed())
          */
         if (info->IsMoxaMustChipFlag)
-                outb((UART_FCR_CLEAR_RCVR | UART_FCR_CLEAR_XMIT | MOXA_MUST_FCR_GDA_MODE_ENABLE), info->base + UART_FCR);
+                outb((UART_FCR_CLEAR_RCVR |
+                        UART_FCR_CLEAR_XMIT |
+                        MOXA_MUST_FCR_GDA_MODE_ENABLE), info->base + UART_FCR);
         else
-                outb((UART_FCR_CLEAR_RCVR | UART_FCR_CLEAR_XMIT), info->base + UART_FCR);
+                outb((UART_FCR_CLEAR_RCVR | UART_FCR_CLEAR_XMIT),
+                        info->base + UART_FCR);
 
         /*
          * At this point there's no way the LSR could still be 0xFF;
@@ -2332,9 +2418,9 @@ static int mxser_startup(struct mxser_struct *info)
                 if (capable(CAP_SYS_ADMIN)) {
                         if (info->tty)
                                 set_bit(TTY_IO_ERROR, &info->tty->flags);
-                        return (0);
+                        return 0;
                 } else
-                        return (-ENODEV);
+                        return -ENODEV;
         }
 
         /*
@@ -2356,12 +2442,12 @@ static int mxser_startup(struct mxser_struct *info)
          * Finally, enable interrupts
          */
         info->IER = UART_IER_MSI | UART_IER_RLSI | UART_IER_RDI;
-//      info->IER = UART_IER_RLSI | UART_IER_RDI;
+        /* info->IER = UART_IER_RLSI | UART_IER_RDI; */
 
-        // following add by Victor Yu. 08-30-2002
+        /* following add by Victor Yu. 08-30-2002 */
         if (info->IsMoxaMustChipFlag)
                 info->IER |= MOXA_MUST_IER_EGDAI;
-        // above add by Victor Yu. 08-30-2002
+        /* above add by Victor Yu. 08-30-2002 */
         outb(info->IER, info->base + UART_IER); /* enable interrupts */
 
         /*
@@ -2383,7 +2469,7 @@ static int mxser_startup(struct mxser_struct *info)
         mxser_change_speed(info, NULL);
 
         info->flags |= ASYNC_INITIALIZED;
-        return (0);
+        return 0;
 }
 
 /*
@@ -2421,12 +2507,15 @@ static void mxser_shutdown(struct mxser_struct *info)
         outb(info->MCR, info->base + UART_MCR);
 
         /* clear Rx/Tx FIFO's */
-        // following add by Victor Yu. 08-30-2002
+        /* following add by Victor Yu. 08-30-2002 */
         if (info->IsMoxaMustChipFlag)
-                outb((UART_FCR_CLEAR_RCVR | UART_FCR_CLEAR_XMIT | MOXA_MUST_FCR_GDA_MODE_ENABLE), info->base + UART_FCR);
+                outb((UART_FCR_CLEAR_RCVR |
+                        UART_FCR_CLEAR_XMIT |
+                        MOXA_MUST_FCR_GDA_MODE_ENABLE), info->base + UART_FCR);
         else
-                // above add by Victor Yu. 08-30-2002
-                outb((UART_FCR_CLEAR_RCVR | UART_FCR_CLEAR_XMIT), info->base + UART_FCR);
+                /* above add by Victor Yu. 08-30-2002 */
+                outb((UART_FCR_CLEAR_RCVR | UART_FCR_CLEAR_XMIT),
+                        info->base + UART_FCR);
 
         /* read data port to reset things */
         (void) inb(info->base + UART_RX);
@@ -2436,11 +2525,10 @@ static void mxser_shutdown(struct mxser_struct *info)
 
         info->flags &= ~ASYNC_INITIALIZED;
 
-        // following add by Victor Yu. 09-23-2002
-        if (info->IsMoxaMustChipFlag) {
+        /* following add by Victor Yu. 09-23-2002 */
+        if (info->IsMoxaMustChipFlag)
                 SET_MOXA_MUST_NO_SOFTWARE_FLOW_CONTROL(info->base);
-        }
-        // above add by Victor Yu. 09-23-2002
+        /* above add by Victor Yu. 09-23-2002 */
 
         spin_unlock_irqrestore(&info->slock, flags);
 }
@@ -2457,14 +2545,12 @@ static int mxser_change_speed(struct mxser_struct *info, struct termios *old_ter
         long baud;
         unsigned long flags;
 
-
         if (!info->tty || !info->tty->termios)
                 return ret;
         cflag = info->tty->termios->c_cflag;
         if (!(info->base))
                 return ret;
 
-
 #ifndef B921600
 #define B921600 (B460800 +1)
 #endif
@@ -2559,9 +2645,8 @@ static int mxser_change_speed(struct mxser_struct *info, struct termios *old_ter
                 cval |= 0x04;
         if (cflag & PARENB)
                 cval |= UART_LCR_PARITY;
-        if (!(cflag & PARODD)) {
+        if (!(cflag & PARODD))
                 cval |= UART_LCR_EPAR;
-        }
         if (cflag & CMSPAR)
                 cval |= UART_LCR_SPAR;
 
@@ -2574,13 +2659,12 @@ static int mxser_change_speed(struct mxser_struct *info, struct termios *old_ter
                         fcr = 0;
         } else {
                 fcr = UART_FCR_ENABLE_FIFO;
-                // following add by Victor Yu. 08-30-2002
+                /* following add by Victor Yu. 08-30-2002 */
                 if (info->IsMoxaMustChipFlag) {
                         fcr |= MOXA_MUST_FCR_GDA_MODE_ENABLE;
                         SET_MOXA_MUST_FIFO_VALUE(info);
                 } else {
-                        // above add by Victor Yu. 08-30-2002
-
+                        /* above add by Victor Yu. 08-30-2002 */
                         switch (info->rx_trigger) {
                         case 1:
                                 fcr |= UART_FCR_TRIGGER_1;
@@ -2606,22 +2690,24 @@ static int mxser_change_speed(struct mxser_struct *info, struct termios *old_ter
                 info->IER |= UART_IER_MSI;
                 if ((info->type == PORT_16550A) || (info->IsMoxaMustChipFlag)) {
                         info->MCR |= UART_MCR_AFE;
-                        //status = mxser_get_msr(info->base, 0, info->port);
-/*      save_flags(flags);
+                        /* status = mxser_get_msr(info->base, 0, info->port); */
+/*
+        save_flags(flags);
         cli();
         status = inb(baseaddr + UART_MSR);
-        restore_flags(flags);*/
-                        //mxser_check_modem_status(info, status);
+        restore_flags(flags);
+*/
+                        /* mxser_check_modem_status(info, status); */
                 } else {
-                        //status = mxser_get_msr(info->base, 0, info->port);
-
-                        //MX_LOCK(&info->slock);
+                        /* status = mxser_get_msr(info->base, 0, info->port); */
+                        /* MX_LOCK(&info->slock); */
                         status = inb(info->base + UART_MSR);
-                        //MX_UNLOCK(&info->slock);
+                        /* MX_UNLOCK(&info->slock); */
                         if (info->tty->hw_stopped) {
                                 if (status & UART_MSR_CTS) {
                                         info->tty->hw_stopped = 0;
-                                        if ((info->type != PORT_16550A) && (!info->IsMoxaMustChipFlag)) {
+                                        if ((info->type != PORT_16550A) &&
+                                                        (!info->IsMoxaMustChipFlag)) {
                                                 info->IER |= UART_IER_THRI;
                                                 outb(info->IER, info->base + UART_IER);
                                         }
@@ -2630,7 +2716,8 @@ static int mxser_change_speed(struct mxser_struct *info, struct termios *old_ter
                         } else {
                                 if (!(status & UART_MSR_CTS)) {
                                         info->tty->hw_stopped = 1;
-                                        if ((info->type != PORT_16550A) && (!info->IsMoxaMustChipFlag)) {
+                                        if ((info->type != PORT_16550A) &&
+                                                        (!info->IsMoxaMustChipFlag)) {
                                                 info->IER &= ~UART_IER_THRI;
                                                 outb(info->IER, info->base + UART_IER);
                                         }
@@ -2668,11 +2755,17 @@ static int mxser_change_speed(struct mxser_struct *info, struct termios *old_ter
                  * overruns too.  (For real raw support).
                  */
                 if (I_IGNPAR(info->tty)) {
-                        info->ignore_status_mask |= UART_LSR_OE | UART_LSR_PE | UART_LSR_FE;
-                        info->read_status_mask |= UART_LSR_OE | UART_LSR_PE | UART_LSR_FE;
+                        info->ignore_status_mask |=
+                                                UART_LSR_OE |
+                                                UART_LSR_PE |
+                                                UART_LSR_FE;
+                        info->read_status_mask |=
+                                                UART_LSR_OE |
+                                                UART_LSR_PE |
+                                                UART_LSR_FE;
                 }
         }
-        // following add by Victor Yu. 09-02-2002
+        /* following add by Victor Yu. 09-02-2002 */
         if (info->IsMoxaMustChipFlag) {
                 spin_lock_irqsave(&info->slock, flags);
                 SET_MOXA_MUST_XON1_VALUE(info->base, START_CHAR(info->tty));
@@ -2698,7 +2791,7 @@ static int mxser_change_speed(struct mxser_struct *info, struct termios *old_ter
                  */
                 spin_unlock_irqrestore(&info->slock, flags);
         }
-        // above add by Victor Yu. 09-02-2002
+        /* above add by Victor Yu. 09-02-2002 */
 
 
         outb(fcr, info->base + UART_FCR);       /* set fcr */
@@ -2729,10 +2822,8 @@ static int mxser_set_baud(struct mxser_struct *info, long newspd)
                 quot = (2 * info->baud_base / 269);
         } else if (newspd) {
                 quot = info->baud_base / newspd;
-
                 if (quot == 0)
                         quot = 1;
-
         } else {
                 quot = 0;
         }
@@ -2765,8 +2856,6 @@ static int mxser_set_baud(struct mxser_struct *info, long newspd)
         return ret;
 }
 
-
-
 /*
  * ------------------------------------------------------------
  * friends of mxser_ioctl()
@@ -2777,7 +2866,7 @@ static int mxser_get_serial_info(struct mxser_struct *info, struct serial_struct
         struct serial_struct tmp;
 
         if (!retinfo)
-                return (-EFAULT);
+                return -EFAULT;
         memset(&tmp, 0, sizeof(tmp));
         tmp.type = info->type;
         tmp.line = info->port;
@@ -2791,7 +2880,7 @@ static int mxser_get_serial_info(struct mxser_struct *info, struct serial_struct
         tmp.hub6 = 0;
         if (copy_to_user(retinfo, &tmp, sizeof(*retinfo)))
                 return -EFAULT;
-        return (0);
+        return 0;
 }
 
 static int mxser_set_serial_info(struct mxser_struct *info, struct serial_struct __user *new_info)
@@ -2801,29 +2890,37 @@ static int mxser_set_serial_info(struct mxser_struct *info, struct serial_struct
         int retval = 0;
 
         if (!new_info || !info->base)
-                return (-EFAULT);
+                return -EFAULT;
         if (copy_from_user(&new_serial, new_info, sizeof(new_serial)))
                 return -EFAULT;
 
-        if ((new_serial.irq != info->irq) || (new_serial.port != info->base) || (new_serial.custom_divisor != info->custom_divisor) || (new_serial.baud_base != info->baud_base))
-                return (-EPERM);
+        if ((new_serial.irq != info->irq) ||
+                        (new_serial.port != info->base) ||
+                        (new_serial.custom_divisor != info->custom_divisor) ||
+                        (new_serial.baud_base != info->baud_base))
+                return -EPERM;
 
         flags = info->flags & ASYNC_SPD_MASK;
 
         if (!capable(CAP_SYS_ADMIN)) {
-                if ((new_serial.baud_base != info->baud_base) || (new_serial.close_delay != info->close_delay) || ((new_serial.flags & ~ASYNC_USR_MASK) != (info->flags & ~ASYNC_USR_MASK)))
-                        return (-EPERM);
-                info->flags = ((info->flags & ~ASYNC_USR_MASK) | (new_serial.flags & ASYNC_USR_MASK));
+                if ((new_serial.baud_base != info->baud_base) ||
+                                (new_serial.close_delay != info->close_delay) ||
+                                ((new_serial.flags & ~ASYNC_USR_MASK) != (info->flags & ~ASYNC_USR_MASK)))
+                        return -EPERM;
+                info->flags = ((info->flags & ~ASYNC_USR_MASK) |
+                                (new_serial.flags & ASYNC_USR_MASK));
         } else {
                 /*
                  * OK, past this point, all the error checking has been done.
                  * At this point, we start making changes.....
                  */
-                info->flags = ((info->flags & ~ASYNC_FLAGS) | (new_serial.flags & ASYNC_FLAGS));
+                info->flags = ((info->flags & ~ASYNC_FLAGS) |
+                                (new_serial.flags & ASYNC_FLAGS));
                 info->close_delay = new_serial.close_delay * HZ / 100;
                 info->closing_wait = new_serial.closing_wait * HZ / 100;
-                info->tty->low_latency = (info->flags & ASYNC_LOW_LATENCY) ? 1 : 0;
-                info->tty->low_latency = 0;     //(info->flags & ASYNC_LOW_LATENCY) ? 1 : 0;
+                info->tty->low_latency =
+                                (info->flags & ASYNC_LOW_LATENCY) ? 1 : 0;
+                info->tty->low_latency = 0;     /* (info->flags & ASYNC_LOW_LATENCY) ? 1 : 0; */
         }
 
         /* added by casper, 3/17/2000, for mouse */
@@ -2831,7 +2928,6 @@ static int mxser_set_serial_info(struct mxser_struct *info, struct serial_struct
 
         process_txrx_fifo(info);
 
-        /* */
         if (info->flags & ASYNC_INITIALIZED) {
                 if (flags != (info->flags & ASYNC_SPD_MASK)) {
                         mxser_change_speed(info, NULL);
@@ -2839,7 +2935,7 @@ static int mxser_set_serial_info(struct mxser_struct *info, struct serial_struct
         } else {
                 retval = mxser_startup(info);
         }
-        return (retval);
+        return retval;
 }
 
 /*
@@ -2876,25 +2972,27 @@ static void mxser_send_break(struct mxser_struct *info, int duration)
                 return;
         set_current_state(TASK_INTERRUPTIBLE);
         spin_lock_irqsave(&info->slock, flags);
-        outb(inb(info->base + UART_LCR) | UART_LCR_SBC, info->base + UART_LCR);
+        outb(inb(info->base + UART_LCR) | UART_LCR_SBC,
+                info->base + UART_LCR);
         spin_unlock_irqrestore(&info->slock, flags);
         schedule_timeout(duration);
         spin_lock_irqsave(&info->slock, flags);
-        outb(inb(info->base + UART_LCR) & ~UART_LCR_SBC, info->base + UART_LCR);
+        outb(inb(info->base + UART_LCR) & ~UART_LCR_SBC,
+                info->base + UART_LCR);
         spin_unlock_irqrestore(&info->slock, flags);
 }
 
 static int mxser_tiocmget(struct tty_struct *tty, struct file *file)
 {
-        struct mxser_struct *info = (struct mxser_struct *) tty->driver_data;
+        struct mxser_struct *info = tty->driver_data;
         unsigned char control, status;
         unsigned long flags;
 
 
         if (tty->index == MXSER_PORTS)
-                return (-ENOIOCTLCMD);
+                return -ENOIOCTLCMD;
         if (tty->flags & (1 << TTY_IO_ERROR))
-                return (-EIO);
+                return -EIO;
 
         control = info->MCR;
 
@@ -2904,12 +3002,16 @@ static int mxser_tiocmget(struct tty_struct *tty, struct file *file)
                 mxser_check_modem_status(info, status);
         spin_unlock_irqrestore(&info->slock, flags);
         return ((control & UART_MCR_RTS) ? TIOCM_RTS : 0) |
-            ((control & UART_MCR_DTR) ? TIOCM_DTR : 0) | ((status & UART_MSR_DCD) ? TIOCM_CAR : 0) | ((status & UART_MSR_RI) ? TIOCM_RNG : 0) | ((status & UART_MSR_DSR) ? TIOCM_DSR : 0) | ((status & UART_MSR_CTS) ? TIOCM_CTS : 0);
+                    ((control & UART_MCR_DTR) ? TIOCM_DTR : 0) |
+                    ((status & UART_MSR_DCD) ? TIOCM_CAR : 0) |
+                    ((status & UART_MSR_RI) ? TIOCM_RNG : 0) |
+                    ((status & UART_MSR_DSR) ? TIOCM_DSR : 0) |
+                    ((status & UART_MSR_CTS) ? TIOCM_CTS : 0);
 }
 
 static int mxser_tiocmset(struct tty_struct *tty, struct file *file, unsigned int set, unsigned int clear)
 {
-        struct mxser_struct *info = (struct mxser_struct *) tty->driver_data;
+        struct mxser_struct *info = tty->driver_data;
         unsigned long flags;
 
 
@@ -2968,38 +3070,36 @@ static int mxser_get_ISA_conf(int cap, struct mxser_hwconf *hwconf)
                 hwconf->board_type = MXSER_BOARD_CI104J;
                 hwconf->ports = 4;
         } else
-                return (0);
+                return 0;
 
         irq = 0;
         if (hwconf->ports == 2) {
                 irq = regs[9] & 0xF000;
                 irq = irq | (irq >> 4);
                 if (irq != (regs[9] & 0xFF00))
-                        return (MXSER_ERR_IRQ_CONFLIT);
+                        return MXSER_ERR_IRQ_CONFLIT;
         } else if (hwconf->ports == 4) {
                 irq = regs[9] & 0xF000;
                 irq = irq | (irq >> 4);
                 irq = irq | (irq >> 8);
                 if (irq != regs[9])
-                        return (MXSER_ERR_IRQ_CONFLIT);
+                        return MXSER_ERR_IRQ_CONFLIT;
         } else if (hwconf->ports == 8) {
                 irq = regs[9] & 0xF000;
                 irq = irq | (irq >> 4);
                 irq = irq | (irq >> 8);
                 if ((irq != regs[9]) || (irq != regs[10]))
-                        return (MXSER_ERR_IRQ_CONFLIT);
+                        return MXSER_ERR_IRQ_CONFLIT;
         }
 
-        if (!irq) {
-                return (MXSER_ERR_IRQ);
-        }
-        hwconf->irq = ((int) (irq & 0xF000) >> 12);
+        if (!irq)
+                return MXSER_ERR_IRQ;
+        hwconf->irq = ((int)(irq & 0xF000) >> 12);
         for (i = 0; i < 8; i++)
                 hwconf->ioaddr[i] = (int) regs[i + 1] & 0xFFF8;
-        if ((regs[12] & 0x80) == 0) {
-                return (MXSER_ERR_VECTOR);
-        }
-        hwconf->vector = (int) regs[11];        /* interrupt vector */
+        if ((regs[12] & 0x80) == 0)
+                return MXSER_ERR_VECTOR;
+        hwconf->vector = (int)regs[11]; /* interrupt vector */
         if (id == 1)
                 hwconf->vector_mask = 0x00FF;
         else
@@ -3007,10 +3107,10 @@ static int mxser_get_ISA_conf(int cap, struct mxser_hwconf *hwconf)
         for (i = 7, bits = 0x0100; i >= 0; i--, bits <<= 1) {
                 if (regs[12] & bits) {
                         hwconf->baud_base[i] = 921600;
-                        hwconf->MaxCanSetBaudRate[i] = 921600;  // add by Victor Yu. 09-04-2002
+                        hwconf->MaxCanSetBaudRate[i] = 921600;  /* add by Victor Yu. 09-04-2002 */
                 } else {
                         hwconf->baud_base[i] = 115200;
-                        hwconf->MaxCanSetBaudRate[i] = 115200;  // add by Victor Yu. 09-04-2002
+                        hwconf->MaxCanSetBaudRate[i] = 115200;  /* add by Victor Yu. 09-04-2002 */
                 }
         }
         scratch2 = inb(cap + UART_LCR) & (~UART_LCR_DLAB);
@@ -3030,7 +3130,7 @@ static int mxser_get_ISA_conf(int cap, struct mxser_hwconf *hwconf)
                 hwconf->ports = 4;
         request_region(hwconf->ioaddr[0], 8 * hwconf->ports, "mxser(IO)");
         request_region(hwconf->vector, 1, "mxser(vector)");
-        return (hwconf->ports);
+        return hwconf->ports;
 }
 
 #define CHIP_SK         0x01    /* Serial Data Clock  in Eprom */
@@ -3053,7 +3153,7 @@ static int mxser_read_register(int port, unsigned short *regs)
 
         id = mxser_program_mode(port);
         if (id < 0)
-                return (id);
+                return id;
         for (i = 0; i < 14; i++) {
                 k = (i & 0x3F) | 0x180;
                 for (j = 0x100; j > 0; j >>= 1) {
@@ -3066,7 +3166,7 @@ static int mxser_read_register(int port, unsigned short *regs)
                                 outb(CHIP_CS | CHIP_SK, port);  /* A? bit of read */
                         }
                 }
-                (void) inb(port);
+                (void)inb(port);
                 value = 0;
                 for (k = 0, j = 0x8000; k < 16; k++, j >>= 1) {
                         outb(CHIP_CS, port);
@@ -3078,28 +3178,33 @@ static int mxser_read_register(int port, unsigned short *regs)
                 outb(0, port);
         }
         mxser_normal_mode(port);
-        return (id);
+        return id;
 }
 
 static int mxser_program_mode(int port)
 {
         int id, i, j, n;
-        //unsigned long flags;
+        /* unsigned long flags; */
 
         spin_lock(&gm_lock);
         outb(0, port);
         outb(0, port);
         outb(0, port);
-        (void) inb(port);
-        (void) inb(port);
+        (void)inb(port);
+        (void)inb(port);
         outb(0, port);
-        (void) inb(port);
-        //restore_flags(flags);
+        (void)inb(port);
+        /* restore_flags(flags); */
         spin_unlock(&gm_lock);
 
         id = inb(port + 1) & 0x1F;
-        if ((id != C168_ASIC_ID) && (id != C104_ASIC_ID) && (id != C102_ASIC_ID) && (id != CI132_ASIC_ID) && (id != CI134_ASIC_ID) && (id != CI104J_ASIC_ID))
-                return (-1);
+        if ((id != C168_ASIC_ID) &&
+                        (id != C104_ASIC_ID) &&
+                        (id != C102_ASIC_ID) &&
+                        (id != CI132_ASIC_ID) &&
+                        (id != CI134_ASIC_ID) &&
+                        (id != CI104J_ASIC_ID))
+                return -1;
         for (i = 0, j = 0; i < 4; i++) {
                 n = inb(port + 2);
                 if (n == 'M') {
@@ -3112,7 +3217,7 @@ static int mxser_program_mode(int port)
         }
         if (j != 2)
                 id = -2;
-        return (id);
+        return id;
 }
 
 static void mxser_normal_mode(int port)
@@ -3130,7 +3235,7 @@ static void mxser_normal_mode(int port)
                 if ((n & 0x61) == 0x60)
                         break;
                 if ((n & 1) == 1)
-                        (void) inb(port);
+                        (void)inb(port);
         }
         outb(0x00, port + 4);
 }
diff --git a/drivers/char/n_r3964.c b/drivers/char/n_r3964.c
index c48de09d68f0..203dc2b661d5 100644
--- a/drivers/char/n_r3964.c
+++ b/drivers/char/n_r3964.c
@@ -951,7 +951,8 @@ static void add_msg(struct r3964_client_info *pClient, int msg_id, int arg,
    {
 queue_the_message:
 
-      pMsg = kmalloc(sizeof(struct r3964_message), GFP_KERNEL);
+      pMsg = kmalloc(sizeof(struct r3964_message),
+                     error_code?GFP_ATOMIC:GFP_KERNEL);
       TRACE_M("add_msg - kmalloc %p",pMsg);
       if(pMsg==NULL) {
          return;
diff --git a/drivers/char/n_tty.c b/drivers/char/n_tty.c
index b9371d5bf790..603b9ade5eb0 100644
--- a/drivers/char/n_tty.c
+++ b/drivers/char/n_tty.c
@@ -1132,7 +1132,7 @@ static inline int input_available_p(struct tty_struct *tty, int amt)
  *      buffer, and once to drain the space from the (physical) beginning of
  *      the buffer to head pointer.
  *
- *      Called under the tty->atomic_read_lock sem and with TTY_DONT_FLIP set
+ *      Called under the tty->atomic_read_lock sem
  *
  */
  
@@ -1271,7 +1271,6 @@ do_it_again:
         }
 
         add_wait_queue(&tty->read_wait, &wait);
-        set_bit(TTY_DONT_FLIP, &tty->flags);
         while (nr) {
                 /* First test for status change. */
                 if (tty->packet && tty->link->ctrl_status) {
@@ -1315,9 +1314,7 @@ do_it_again:
                                 break;
                         }
                         n_tty_set_room(tty);
-                        clear_bit(TTY_DONT_FLIP, &tty->flags);
                         timeout = schedule_timeout(timeout);
-                        set_bit(TTY_DONT_FLIP, &tty->flags);
                         continue;
                 }
                 __set_current_state(TASK_RUNNING);
@@ -1394,7 +1391,6 @@ do_it_again:
                 if (time)
                         timeout = time;
         }
-        clear_bit(TTY_DONT_FLIP, &tty->flags);
         mutex_unlock(&tty->atomic_read_lock);
         remove_wait_queue(&tty->read_wait, &wait);
 
diff --git a/drivers/char/nsc_gpio.c b/drivers/char/nsc_gpio.c
new file mode 100644
index 000000000000..5b91e4e25641
--- /dev/null
+++ b/drivers/char/nsc_gpio.c
@@ -0,0 +1,142 @@
+/* linux/drivers/char/nsc_gpio.c
+
+   National Semiconductor common GPIO device-file/VFS methods.
+   Allows a user space process to control the GPIO pins.
+
+   Copyright (c) 2001,2002 Christer Weinigel <wingel@nano-system.com>
+   Copyright (c) 2005      Jim Cromie <jim.cromie@gmail.com>
+*/
+
+#include <linux/config.h>
+#include <linux/fs.h>
+#include <linux/module.h>
+#include <linux/errno.h>
+#include <linux/kernel.h>
+#include <linux/init.h>
+#include <linux/nsc_gpio.h>
+#include <linux/platform_device.h>
+#include <asm/uaccess.h>
+#include <asm/io.h>
+
+#define NAME "nsc_gpio"
+
+void nsc_gpio_dump(struct nsc_gpio_ops *amp, unsigned index)
+{
+        /* retrieve current config w/o changing it */
+        u32 config = amp->gpio_config(index, ~0, 0);
+
+        /* user requested via 'v' command, so its INFO */
+        dev_info(amp->dev, "io%02u: 0x%04x %s %s %s %s %s %s %s\tio:%d/%d\n",
+                 index, config,
+                 (config & 1) ? "OE" : "TS",      /* output-enabled/tristate */
+                 (config & 2) ? "PP" : "OD",      /* push pull / open drain */
+                 (config & 4) ? "PUE" : "PUD",    /* pull up enabled/disabled */
+                 (config & 8) ? "LOCKED" : "",    /* locked / unlocked */
+                 (config & 16) ? "LEVEL" : "EDGE",/* level/edge input */
+                 (config & 32) ? "HI" : "LO",     /* trigger on rise/fall edge */
+                 (config & 64) ? "DEBOUNCE" : "", /* debounce */
+
+                 amp->gpio_get(index), amp->gpio_current(index));
+}
+
+ssize_t nsc_gpio_write(struct file *file, const char __user *data,
+                       size_t len, loff_t *ppos)
+{
+        unsigned m = iminor(file->f_dentry->d_inode);
+        struct nsc_gpio_ops *amp = file->private_data;
+        struct device *dev = amp->dev;
+        size_t i;
+        int err = 0;
+
+        for (i = 0; i < len; ++i) {
+                char c;
+                if (get_user(c, data + i))
+                        return -EFAULT;
+                switch (c) {
+                case '0':
+                        amp->gpio_set(m, 0);
+                        break;
+                case '1':
+                        amp->gpio_set(m, 1);
+                        break;
+                case 'O':
+                        dev_dbg(dev, "GPIO%d output enabled\n", m);
+                        amp->gpio_config(m, ~1, 1);
+                        break;
+                case 'o':
+                        dev_dbg(dev, "GPIO%d output disabled\n", m);
+                        amp->gpio_config(m, ~1, 0);
+                        break;
+                case 'T':
+                        dev_dbg(dev, "GPIO%d output is push pull\n",
+                               m);
+                        amp->gpio_config(m, ~2, 2);
+                        break;
+                case 't':
+                        dev_dbg(dev, "GPIO%d output is open drain\n",
+                               m);
+                        amp->gpio_config(m, ~2, 0);
+                        break;
+                case 'P':
+                        dev_dbg(dev, "GPIO%d pull up enabled\n", m);
+                        amp->gpio_config(m, ~4, 4);
+                        break;
+                case 'p':
+                        dev_dbg(dev, "GPIO%d pull up disabled\n", m);
+                        amp->gpio_config(m, ~4, 0);
+                        break;
+                case 'v':
+                        /* View Current pin settings */
+                        amp->gpio_dump(amp, m);
+                        break;
+                case '\n':
+                        /* end of settings string, do nothing */
+                        break;
+                default:
+                        dev_err(dev, "io%2d bad setting: chr<0x%2x>\n",
+                                m, (int)c);
+                        err++;
+                }
+        }
+        if (err)
+                return -EINVAL; /* full string handled, report error */
+
+        return len;
+}
+
+ssize_t nsc_gpio_read(struct file *file, char __user * buf,
+                      size_t len, loff_t * ppos)
+{
+        unsigned m = iminor(file->f_dentry->d_inode);
+        int value;
+        struct nsc_gpio_ops *amp = file->private_data;
+
+        value = amp->gpio_get(m);
+        if (put_user(value ? '1' : '0', buf))
+                return -EFAULT;
+
+        return 1;
+}
+
+/* common file-ops routines for both scx200_gpio and pc87360_gpio */
+EXPORT_SYMBOL(nsc_gpio_write);
+EXPORT_SYMBOL(nsc_gpio_read);
+EXPORT_SYMBOL(nsc_gpio_dump);
+
+static int __init nsc_gpio_init(void)
+{
+        printk(KERN_DEBUG NAME " initializing\n");
+        return 0;
+}
+
+static void __exit nsc_gpio_cleanup(void)
+{
+        printk(KERN_DEBUG NAME " cleanup\n");
+}
+
+module_init(nsc_gpio_init);
+module_exit(nsc_gpio_cleanup);
+
+MODULE_AUTHOR("Jim Cromie <jim.cromie@gmail.com>");
+MODULE_DESCRIPTION("NatSemi GPIO Common Methods");
+MODULE_LICENSE("GPL");
diff --git a/drivers/char/pc8736x_gpio.c b/drivers/char/pc8736x_gpio.c
new file mode 100644
index 000000000000..1c706ccfdbb3
--- /dev/null
+++ b/drivers/char/pc8736x_gpio.c
@@ -0,0 +1,340 @@
+/* linux/drivers/char/pc8736x_gpio.c
+
+   National Semiconductor PC8736x GPIO driver.  Allows a user space
+   process to play with the GPIO pins.
+
+   Copyright (c) 2005 Jim Cromie <jim.cromie@gmail.com>
+
+   adapted from linux/drivers/char/scx200_gpio.c
+   Copyright (c) 2001,2002 Christer Weinigel <wingel@nano-system.com>,
+*/
+
+#include <linux/config.h>
+#include <linux/fs.h>
+#include <linux/module.h>
+#include <linux/errno.h>
+#include <linux/kernel.h>
+#include <linux/init.h>
+#include <linux/io.h>
+#include <linux/ioport.h>
+#include <linux/mutex.h>
+#include <linux/nsc_gpio.h>
+#include <linux/platform_device.h>
+#include <asm/uaccess.h>
+
+#define DEVNAME "pc8736x_gpio"
+
+MODULE_AUTHOR("Jim Cromie <jim.cromie@gmail.com>");
+MODULE_DESCRIPTION("NatSemi PC-8736x GPIO Pin Driver");
+MODULE_LICENSE("GPL");
+
+static int major;               /* default to dynamic major */
+module_param(major, int, 0);
+MODULE_PARM_DESC(major, "Major device number");
+
+static DEFINE_MUTEX(pc8736x_gpio_config_lock);
+static unsigned pc8736x_gpio_base;
+static u8 pc8736x_gpio_shadow[4];
+
+#define SIO_BASE1       0x2E    /* 1st command-reg to check */
+#define SIO_BASE2       0x4E    /* alt command-reg to check */
+#define SIO_BASE_OFFSET 0x20
+
+#define SIO_SID         0x20    /* SuperI/O ID Register */
+#define SIO_SID_VALUE   0xe9    /* Expected value in SuperI/O ID Register */
+
+#define SIO_CF1         0x21    /* chip config, bit0 is chip enable */
+
+#define PC8736X_GPIO_SIZE       16
+
+#define SIO_UNIT_SEL    0x7     /* unit select reg */
+#define SIO_UNIT_ACT    0x30    /* unit enable */
+#define SIO_GPIO_UNIT   0x7     /* unit number of GPIO */
+#define SIO_VLM_UNIT    0x0D
+#define SIO_TMS_UNIT    0x0E
+
+/* config-space addrs to read/write each unit's runtime addr */
+#define SIO_BASE_HADDR          0x60
+#define SIO_BASE_LADDR          0x61
+
+/* GPIO config-space pin-control addresses */
+#define SIO_GPIO_PIN_SELECT     0xF0
+#define SIO_GPIO_PIN_CONFIG     0xF1
+#define SIO_GPIO_PIN_EVENT      0xF2
+
+static unsigned char superio_cmd = 0;
+static unsigned char selected_device = 0xFF;    /* bogus start val */
+
+/* GPIO port runtime access, functionality */
+static int port_offset[] = { 0, 4, 8, 10 };     /* non-uniform offsets ! */
+/* static int event_capable[] = { 1, 1, 0, 0 };   ports 2,3 are hobbled */
+
+#define PORT_OUT        0
+#define PORT_IN         1
+#define PORT_EVT_EN     2
+#define PORT_EVT_STST   3
+
+static struct platform_device *pdev;  /* use in dev_*() */
+
+static inline void superio_outb(int addr, int val)
+{
+        outb_p(addr, superio_cmd);
+        outb_p(val, superio_cmd + 1);
+}
+
+static inline int superio_inb(int addr)
+{
+        outb_p(addr, superio_cmd);
+        return inb_p(superio_cmd + 1);
+}
+
+static int pc8736x_superio_present(void)
+{
+        /* try the 2 possible values, read a hardware reg to verify */
+        superio_cmd = SIO_BASE1;
+        if (superio_inb(SIO_SID) == SIO_SID_VALUE)
+                return superio_cmd;
+
+        superio_cmd = SIO_BASE2;
+        if (superio_inb(SIO_SID) == SIO_SID_VALUE)
+                return superio_cmd;
+
+        return 0;
+}
+
+static void device_select(unsigned devldn)
+{
+        superio_outb(SIO_UNIT_SEL, devldn);
+        selected_device = devldn;
+}
+
+static void select_pin(unsigned iminor)
+{
+        /* select GPIO port/pin from device minor number */
+        device_select(SIO_GPIO_UNIT);
+        superio_outb(SIO_GPIO_PIN_SELECT,
+                     ((iminor << 1) & 0xF0) | (iminor & 0x7));
+}
+
+static inline u32 pc8736x_gpio_configure_fn(unsigned index, u32 mask, u32 bits,
+                                            u32 func_slct)
+{
+        u32 config, new_config;
+
+        mutex_lock(&pc8736x_gpio_config_lock);
+
+        device_select(SIO_GPIO_UNIT);
+        select_pin(index);
+
+        /* read current config value */
+        config = superio_inb(func_slct);
+
+        /* set new config */
+        new_config = (config & mask) | bits;
+        superio_outb(func_slct, new_config);
+
+        mutex_unlock(&pc8736x_gpio_config_lock);
+
+        return config;
+}
+
+static u32 pc8736x_gpio_configure(unsigned index, u32 mask, u32 bits)
+{
+        return pc8736x_gpio_configure_fn(index, mask, bits,
+                                         SIO_GPIO_PIN_CONFIG);
+}
+
+static int pc8736x_gpio_get(unsigned minor)
+{
+        int port, bit, val;
+
+        port = minor >> 3;
+        bit = minor & 7;
+        val = inb_p(pc8736x_gpio_base + port_offset[port] + PORT_IN);
+        val >>= bit;
+        val &= 1;
+
+        dev_dbg(&pdev->dev, "_gpio_get(%d from %x bit %d) == val %d\n",
+                minor, pc8736x_gpio_base + port_offset[port] + PORT_IN, bit,
+                val);
+
+        return val;
+}
+
+static void pc8736x_gpio_set(unsigned minor, int val)
+{
+        int port, bit, curval;
+
+        minor &= 0x1f;
+        port = minor >> 3;
+        bit = minor & 7;
+        curval = inb_p(pc8736x_gpio_base + port_offset[port] + PORT_OUT);
+
+        dev_dbg(&pdev->dev, "addr:%x cur:%x bit-pos:%d cur-bit:%x + new:%d -> bit-new:%d\n",
+                pc8736x_gpio_base + port_offset[port] + PORT_OUT,
+                curval, bit, (curval & ~(1 << bit)), val, (val << bit));
+
+        val = (curval & ~(1 << bit)) | (val << bit);
+
+        dev_dbg(&pdev->dev, "gpio_set(minor:%d port:%d bit:%d)"
+                " %2x -> %2x\n", minor, port, bit, curval, val);
+
+        outb_p(val, pc8736x_gpio_base + port_offset[port] + PORT_OUT);
+
+        curval = inb_p(pc8736x_gpio_base + port_offset[port] + PORT_OUT);
+        val = inb_p(pc8736x_gpio_base + port_offset[port] + PORT_IN);
+
+        dev_dbg(&pdev->dev, "wrote %x, read: %x\n", curval, val);
+        pc8736x_gpio_shadow[port] = val;
+}
+
+static void pc8736x_gpio_set_high(unsigned index)
+{
+        pc8736x_gpio_set(index, 1);
+}
+
+static void pc8736x_gpio_set_low(unsigned index)
+{
+        pc8736x_gpio_set(index, 0);
+}
+
+static int pc8736x_gpio_current(unsigned minor)
+{
+        int port, bit;
+        minor &= 0x1f;
+        port = minor >> 3;
+        bit = minor & 7;
+        return ((pc8736x_gpio_shadow[port] >> bit) & 0x01);
+}
+
+static void pc8736x_gpio_change(unsigned index)
+{
+        pc8736x_gpio_set(index, !pc8736x_gpio_current(index));
+}
+
+static struct nsc_gpio_ops pc8736x_access = {
+        .owner          = THIS_MODULE,
+        .gpio_config    = pc8736x_gpio_configure,
+        .gpio_dump      = nsc_gpio_dump,
+        .gpio_get       = pc8736x_gpio_get,
+        .gpio_set       = pc8736x_gpio_set,
+        .gpio_set_high  = pc8736x_gpio_set_high,
+        .gpio_set_low   = pc8736x_gpio_set_low,
+        .gpio_change    = pc8736x_gpio_change,
+        .gpio_current   = pc8736x_gpio_current
+};
+
+static int pc8736x_gpio_open(struct inode *inode, struct file *file)
+{
+        unsigned m = iminor(inode);
+        file->private_data = &pc8736x_access;
+
+        dev_dbg(&pdev->dev, "open %d\n", m);
+
+        if (m > 63)
+                return -EINVAL;
+        return nonseekable_open(inode, file);
+}
+
+static struct file_operations pc8736x_gpio_fops = {
+        .owner  = THIS_MODULE,
+        .open   = pc8736x_gpio_open,
+        .write  = nsc_gpio_write,
+        .read   = nsc_gpio_read,
+};
+
+static void __init pc8736x_init_shadow(void)
+{
+        int port;
+
+        /* read the current values driven on the GPIO signals */
+        for (port = 0; port < 4; ++port)
+                pc8736x_gpio_shadow[port]
+                    = inb_p(pc8736x_gpio_base + port_offset[port]
+                            + PORT_OUT);
+
+}
+
+static int __init pc8736x_gpio_init(void)
+{
+        int rc = 0;
+
+        pdev = platform_device_alloc(DEVNAME, 0);
+        if (!pdev)
+                return -ENOMEM;
+
+        rc = platform_device_add(pdev);
+        if (rc) {
+                rc = -ENODEV;
+                goto undo_platform_dev_alloc;
+        }
+        dev_info(&pdev->dev, "NatSemi pc8736x GPIO Driver Initializing\n");
+
+        if (!pc8736x_superio_present()) {
+                rc = -ENODEV;
+                dev_err(&pdev->dev, "no device found\n");
+                goto undo_platform_dev_add;
+        }
+        pc8736x_access.dev = &pdev->dev;
+
+        /* Verify that chip and it's GPIO unit are both enabled.
+           My BIOS does this, so I take minimum action here
+         */
+        rc = superio_inb(SIO_CF1);
+        if (!(rc & 0x01)) {
+                rc = -ENODEV;
+                dev_err(&pdev->dev, "device not enabled\n");
+                goto undo_platform_dev_add;
+        }
+        device_select(SIO_GPIO_UNIT);
+        if (!superio_inb(SIO_UNIT_ACT)) {
+                rc = -ENODEV;
+                dev_err(&pdev->dev, "GPIO unit not enabled\n");
+                goto undo_platform_dev_add;
+        }
+
+        /* read the GPIO unit base addr that chip responds to */
+        pc8736x_gpio_base = (superio_inb(SIO_BASE_HADDR) << 8
+                             | superio_inb(SIO_BASE_LADDR));
+
+        if (!request_region(pc8736x_gpio_base, 16, DEVNAME)) {
+                rc = -ENODEV;
+                dev_err(&pdev->dev, "GPIO ioport %x busy\n",
+                        pc8736x_gpio_base);
+                goto undo_platform_dev_add;
+        }
+        dev_info(&pdev->dev, "GPIO ioport %x reserved\n", pc8736x_gpio_base);
+
+        rc = register_chrdev(major, DEVNAME, &pc8736x_gpio_fops);
+        if (rc < 0) {
+                dev_err(&pdev->dev, "register-chrdev failed: %d\n", rc);
+                goto undo_platform_dev_add;
+        }
+        if (!major) {
+                major = rc;
+                dev_dbg(&pdev->dev, "got dynamic major %d\n", major);
+        }
+
+        pc8736x_init_shadow();
+        return 0;
+
+undo_platform_dev_add:
+        platform_device_put(pdev);
+undo_platform_dev_alloc:
+        kfree(pdev);
+        return rc;
+}
+
+static void __exit pc8736x_gpio_cleanup(void)
+{
+        dev_dbg(&pdev->dev, " cleanup\n");
+
+        release_region(pc8736x_gpio_base, 16);
+
+        unregister_chrdev(major, DEVNAME);
+}
+
+EXPORT_SYMBOL(pc8736x_access);
+
+module_init(pc8736x_gpio_init);
+module_exit(pc8736x_gpio_cleanup);
diff --git a/drivers/char/pcmcia/synclink_cs.c b/drivers/char/pcmcia/synclink_cs.c
index 07213454c458..17bc8abd5df5 100644
--- a/drivers/char/pcmcia/synclink_cs.c
+++ b/drivers/char/pcmcia/synclink_cs.c
@@ -844,7 +844,7 @@ static int bh_action(MGSLPC_INFO *info)
         return rc;
 }
 
-void bh_handler(void* Context)
+static void bh_handler(void* Context)
 {
         MGSLPC_INFO *info = (MGSLPC_INFO*)Context;
         int action;
@@ -888,7 +888,7 @@ void bh_handler(void* Context)
                         __FILE__,__LINE__,info->device_name);
 }
 
-void bh_transmit(MGSLPC_INFO *info)
+static void bh_transmit(MGSLPC_INFO *info)
 {
         struct tty_struct *tty = info->tty;
         if (debug_level >= DEBUG_LEVEL_BH)
@@ -900,7 +900,7 @@ void bh_transmit(MGSLPC_INFO *info)
         }
 }
 
-void bh_status(MGSLPC_INFO *info)
+static void bh_status(MGSLPC_INFO *info)
 {
         info->ri_chkcount = 0;
         info->dsr_chkcount = 0;
@@ -1582,7 +1582,7 @@ static void mgslpc_put_char(struct tty_struct *tty, unsigned char ch)
         if (mgslpc_paranoia_check(info, tty->name, "mgslpc_put_char"))
                 return;
 
-        if (!tty || !info->tx_buf)
+        if (!info->tx_buf)
                 return;
 
         spin_lock_irqsave(&info->lock,flags);
@@ -1649,7 +1649,7 @@ static int mgslpc_write(struct tty_struct * tty,
                         __FILE__,__LINE__,info->device_name,count);
         
         if (mgslpc_paranoia_check(info, tty->name, "mgslpc_write") ||
-            !tty || !info->tx_buf)
+                !info->tx_buf)
                 goto cleanup;
 
         if (info->params.mode == MGSL_MODE_HDLC) {
@@ -2305,7 +2305,7 @@ static int mgslpc_ioctl(struct tty_struct *tty, struct file * file,
         return ioctl_common(info, cmd, arg);
 }
 
-int ioctl_common(MGSLPC_INFO *info, unsigned int cmd, unsigned long arg)
+static int ioctl_common(MGSLPC_INFO *info, unsigned int cmd, unsigned long arg)
 {
         int error;
         struct mgsl_icount cnow;        /* kernel counter temps */
@@ -2877,7 +2877,7 @@ done:
         return ((count < begin+len-off) ? count : begin+len-off);
 }
 
-int rx_alloc_buffers(MGSLPC_INFO *info)
+static int rx_alloc_buffers(MGSLPC_INFO *info)
 {
         /* each buffer has header and data */
         info->rx_buf_size = sizeof(RXBUF) + info->max_frame_size;
@@ -2900,13 +2900,13 @@ int rx_alloc_buffers(MGSLPC_INFO *info)
         return 0;
 }
 
-void rx_free_buffers(MGSLPC_INFO *info)
+static void rx_free_buffers(MGSLPC_INFO *info)
 {
         kfree(info->rx_buf);
         info->rx_buf = NULL;
 }
 
-int claim_resources(MGSLPC_INFO *info)
+static int claim_resources(MGSLPC_INFO *info)
 {
         if (rx_alloc_buffers(info) < 0 ) {
                 printk( "Cant allocate rx buffer %s\n", info->device_name);
@@ -2916,7 +2916,7 @@ int claim_resources(MGSLPC_INFO *info)
         return 0;
 }
 
-void release_resources(MGSLPC_INFO *info)
+static void release_resources(MGSLPC_INFO *info)
 {
         if (debug_level >= DEBUG_LEVEL_INFO)
                 printk("release_resources(%s)\n", info->device_name);
@@ -2928,7 +2928,7 @@ void release_resources(MGSLPC_INFO *info)
  *      
  * Arguments:           info    pointer to device instance data
  */
-void mgslpc_add_device(MGSLPC_INFO *info)
+static void mgslpc_add_device(MGSLPC_INFO *info)
 {
         info->next_device = NULL;
         info->line = mgslpc_device_count;
@@ -2964,7 +2964,7 @@ void mgslpc_add_device(MGSLPC_INFO *info)
 #endif
 }
 
-void mgslpc_remove_device(MGSLPC_INFO *remove_info)
+static void mgslpc_remove_device(MGSLPC_INFO *remove_info)
 {
         MGSLPC_INFO *info = mgslpc_device_list;
         MGSLPC_INFO *last = NULL;
@@ -3257,7 +3257,7 @@ static void loopback_enable(MGSLPC_INFO *info)
         write_reg(info, CHA + MODE, val);
 }
 
-void hdlc_mode(MGSLPC_INFO *info)
+static void hdlc_mode(MGSLPC_INFO *info)
 {
         unsigned char val;
         unsigned char clkmode, clksubmode;
@@ -3497,7 +3497,7 @@ void hdlc_mode(MGSLPC_INFO *info)
         rx_stop(info);
 }
 
-void rx_stop(MGSLPC_INFO *info)
+static void rx_stop(MGSLPC_INFO *info)
 {
         if (debug_level >= DEBUG_LEVEL_ISR)
                 printk("%s(%d):rx_stop(%s)\n",
@@ -3510,7 +3510,7 @@ void rx_stop(MGSLPC_INFO *info)
         info->rx_overflow = 0;
 }
 
-void rx_start(MGSLPC_INFO *info)
+static void rx_start(MGSLPC_INFO *info)
 {
         if (debug_level >= DEBUG_LEVEL_ISR)
                 printk("%s(%d):rx_start(%s)\n",
@@ -3526,7 +3526,7 @@ void rx_start(MGSLPC_INFO *info)
         info->rx_enabled = 1;
 }
 
-void tx_start(MGSLPC_INFO *info)
+static void tx_start(MGSLPC_INFO *info)
 {
         if (debug_level >= DEBUG_LEVEL_ISR)
                 printk("%s(%d):tx_start(%s)\n",
@@ -3564,7 +3564,7 @@ void tx_start(MGSLPC_INFO *info)
                 info->tx_enabled = 1;
 }
 
-void tx_stop(MGSLPC_INFO *info)
+static void tx_stop(MGSLPC_INFO *info)
 {
         if (debug_level >= DEBUG_LEVEL_ISR)
                 printk("%s(%d):tx_stop(%s)\n",
@@ -3578,7 +3578,7 @@ void tx_stop(MGSLPC_INFO *info)
 
 /* Reset the adapter to a known state and prepare it for further use.
  */
-void reset_device(MGSLPC_INFO *info)
+static void reset_device(MGSLPC_INFO *info)
 {
         /* power up both channels (set BIT7) */ 
         write_reg(info, CHA + CCR0, 0x80);
@@ -3628,7 +3628,7 @@ void reset_device(MGSLPC_INFO *info)
         write_reg(info, IPC, 0x05);
 }
 
-void async_mode(MGSLPC_INFO *info)
+static void async_mode(MGSLPC_INFO *info)
 {
         unsigned char val;
 
@@ -3799,7 +3799,7 @@ void async_mode(MGSLPC_INFO *info)
 
 /* Set the HDLC idle mode for the transmitter.
  */
-void tx_set_idle(MGSLPC_INFO *info)
+static void tx_set_idle(MGSLPC_INFO *info)
 {
         /* Note: ESCC2 only supports flags and one idle modes */ 
         if (info->idle_mode == HDLC_TXIDLE_FLAGS)
@@ -3810,7 +3810,7 @@ void tx_set_idle(MGSLPC_INFO *info)
 
 /* get state of the V24 status (input) signals.
  */
-void get_signals(MGSLPC_INFO *info)
+static void get_signals(MGSLPC_INFO *info)
 {
         unsigned char status = 0;
         
@@ -3832,7 +3832,7 @@ void get_signals(MGSLPC_INFO *info)
 /* Set the state of DTR and RTS based on contents of
  * serial_signals member of device extension.
  */
-void set_signals(MGSLPC_INFO *info)
+static void set_signals(MGSLPC_INFO *info)
 {
         unsigned char val;
 
@@ -3856,7 +3856,7 @@ void set_signals(MGSLPC_INFO *info)
                 set_reg_bits(info, CHA + PVR, PVR_DTR);
 }
 
-void rx_reset_buffers(MGSLPC_INFO *info)
+static void rx_reset_buffers(MGSLPC_INFO *info)
 {
         RXBUF *buf;
         int i;
@@ -3875,7 +3875,7 @@ void rx_reset_buffers(MGSLPC_INFO *info)
  *
  * Returns 1 if frame returned, otherwise 0
  */
-int rx_get_frame(MGSLPC_INFO *info)
+static int rx_get_frame(MGSLPC_INFO *info)
 {
         unsigned short status;
         RXBUF *buf;
@@ -3961,7 +3961,7 @@ int rx_get_frame(MGSLPC_INFO *info)
         return 1;
 }
 
-BOOLEAN register_test(MGSLPC_INFO *info)
+static BOOLEAN register_test(MGSLPC_INFO *info)
 {
         static unsigned char patterns[] = 
             { 0x00, 0xff, 0xaa, 0x55, 0x69, 0x96, 0x0f };
@@ -3987,7 +3987,7 @@ BOOLEAN register_test(MGSLPC_INFO *info)
         return rc;
 }
 
-BOOLEAN irq_test(MGSLPC_INFO *info)
+static BOOLEAN irq_test(MGSLPC_INFO *info)
 {
         unsigned long end_time;
         unsigned long flags;
@@ -4022,7 +4022,7 @@ BOOLEAN irq_test(MGSLPC_INFO *info)
         return info->irq_occurred ? TRUE : FALSE;
 }
 
-int adapter_test(MGSLPC_INFO *info)
+static int adapter_test(MGSLPC_INFO *info)
 {
         if (!register_test(info)) {
                 info->init_error = DiagStatus_AddressFailure;
@@ -4044,7 +4044,7 @@ int adapter_test(MGSLPC_INFO *info)
         return 0;
 }
 
-void trace_block(MGSLPC_INFO *info,const char* data, int count, int xmit)
+static void trace_block(MGSLPC_INFO *info,const char* data, int count, int xmit)
 {
         int i;
         int linecount;
@@ -4079,7 +4079,7 @@ void trace_block(MGSLPC_INFO *info,const char* data, int count, int xmit)
 /* HDLC frame time out
  * update stats and do tx completion processing
  */
-void tx_timeout(unsigned long context)
+static void tx_timeout(unsigned long context)
 {
         MGSLPC_INFO *info = (MGSLPC_INFO*)context;
         unsigned long flags;
diff --git a/drivers/char/pty.c b/drivers/char/pty.c
index 9b5a2c0e7008..0c17f61549b4 100644
--- a/drivers/char/pty.c
+++ b/drivers/char/pty.c
@@ -101,7 +101,7 @@ static void pty_unthrottle(struct tty_struct * tty)
  *
  * FIXME: Our pty_write method is called with our ldisc lock held but
  * not our partners. We can't just take the other one blindly without
- * risking deadlocks.  There is also the small matter of TTY_DONT_FLIP
+ * risking deadlocks.
  */
 static int pty_write(struct tty_struct * tty, const unsigned char *buf, int count)
 {
diff --git a/drivers/char/rio/daemon.h b/drivers/char/rio/daemon.h
index 5818a8aa46e0..6e63f8b2c479 100644
--- a/drivers/char/rio/daemon.h
+++ b/drivers/char/rio/daemon.h
@@ -51,7 +51,7 @@ struct Error {
 };
 
 struct DownLoad {
-        char *DataP;
+        char __user *DataP;
         unsigned int Count;
         unsigned int ProductCode;
 };
@@ -83,18 +83,18 @@ struct PortSetup {
 struct LpbReq {
         unsigned int Host;
         unsigned int Link;
-        struct LPB *LpbP;
+        struct LPB __user *LpbP;
 };
 
 struct RupReq {
         unsigned int HostNum;
         unsigned int RupNum;
-        struct RUP *RupP;
+        struct RUP __user *RupP;
 };
 
 struct PortReq {
         unsigned int SysPort;
-        struct Port *PortP;
+        struct Port __user *PortP;
 };
 
 struct StreamInfo {
@@ -105,12 +105,12 @@ struct StreamInfo {
 
 struct HostReq {
         unsigned int HostNum;
-        struct Host *HostP;
+        struct Host __user *HostP;
 };
 
 struct HostDpRam {
         unsigned int HostNum;
-        struct DpRam *DpRamP;
+        struct DpRam __user *DpRamP;
 };
 
 struct DebugCtrl {
diff --git a/drivers/char/rio/func.h b/drivers/char/rio/func.h
index e64fe9912394..6b039186856d 100644
--- a/drivers/char/rio/func.h
+++ b/drivers/char/rio/func.h
@@ -46,7 +46,7 @@ int RIOBootCodeRTA(struct rio_info *, struct DownLoad *);
 int RIOBootCodeHOST(struct rio_info *, struct DownLoad *);
 int RIOBootCodeUNKNOWN(struct rio_info *, struct DownLoad *);
 void msec_timeout(struct Host *);
-int RIOBootRup(struct rio_info *, unsigned int, struct Host *, struct PKT *);
+int RIOBootRup(struct rio_info *, unsigned int, struct Host *, struct PKT __iomem *);
 int RIOBootOk(struct rio_info *, struct Host *, unsigned long);
 int RIORtaBound(struct rio_info *, unsigned int);
 void rio_fill_host_slot(int, int, unsigned int, struct Host *);
@@ -55,8 +55,8 @@ void rio_fill_host_slot(int, int, unsigned int, struct Host *);
 int RIOFoadRta(struct Host *, struct Map *);
 int RIOZombieRta(struct Host *, struct Map *);
 int RIOCommandRta(struct rio_info *, unsigned long, int (*func) (struct Host *, struct Map *));
-int RIOIdentifyRta(struct rio_info *, void *);
-int RIOKillNeighbour(struct rio_info *, void *);
+int RIOIdentifyRta(struct rio_info *, void __user *);
+int RIOKillNeighbour(struct rio_info *, void __user *);
 int RIOSuspendBootRta(struct Host *, int, int);
 int RIOFoadWakeup(struct rio_info *);
 struct CmdBlk *RIOGetCmdBlk(void);
@@ -68,7 +68,8 @@ int RIORFlushEnable(unsigned long, struct CmdBlk *);
 int RIOUnUse(unsigned long, struct CmdBlk *);
 
 /* rioctrl.c */
-int riocontrol(struct rio_info *, dev_t, int, caddr_t, int);
+int riocontrol(struct rio_info *, dev_t, int, unsigned long, int);
+
 int RIOPreemptiveCmd(struct rio_info *, struct Port *, unsigned char);
 
 /* rioinit.c */
@@ -77,13 +78,13 @@ void RIOInitHosts(struct rio_info *, struct RioHostInfo *);
 void RIOISAinit(struct rio_info *, int);
 int RIODoAT(struct rio_info *, int, int);
 caddr_t RIOCheckForATCard(int);
-int RIOAssignAT(struct rio_info *, int, caddr_t, int);
-int RIOBoardTest(unsigned long, caddr_t, unsigned char, int);
+int RIOAssignAT(struct rio_info *, int, void __iomem *, int);
+int RIOBoardTest(unsigned long, void __iomem *, unsigned char, int);
 void RIOAllocDataStructs(struct rio_info *);
 void RIOSetupDataStructs(struct rio_info *);
 int RIODefaultName(struct rio_info *, struct Host *, unsigned int);
 struct rioVersion *RIOVersid(void);
-void RIOHostReset(unsigned int, struct DpRam *, unsigned int);
+void RIOHostReset(unsigned int, struct DpRam __iomem *, unsigned int);
 
 /* riointr.c */
 void RIOTxEnable(char *);
@@ -95,14 +96,14 @@ int RIOParam(struct Port *, int, int, int);
 int RIODelay(struct Port *PortP, int);
 int RIODelay_ni(struct Port *PortP, int);
 void ms_timeout(struct Port *);
-int can_add_transmit(struct PKT **, struct Port *);
+int can_add_transmit(struct PKT __iomem **, struct Port *);
 void add_transmit(struct Port *);
-void put_free_end(struct Host *, struct PKT *);
-int can_remove_receive(struct PKT **, struct Port *);
+void put_free_end(struct Host *, struct PKT __iomem *);
+int can_remove_receive(struct PKT __iomem **, struct Port *);
 void remove_receive(struct Port *);
 
 /* rioroute.c */
-int RIORouteRup(struct rio_info *, unsigned int, struct Host *, struct PKT *);
+int RIORouteRup(struct rio_info *, unsigned int, struct Host *, struct PKT __iomem *);
 void RIOFixPhbs(struct rio_info *, struct Host *, unsigned int);
 unsigned int GetUnitType(unsigned int);
 int RIOSetChange(struct rio_info *);
@@ -139,7 +140,7 @@ int rio_isr_thread(char *);
 struct rio_info *rio_info_store(int cmd, struct rio_info *p);
 #endif
 
-extern void rio_copy_to_card(void *to, void *from, int len);
+extern void rio_copy_to_card(void *from, void __iomem *to, int len);
 extern int rio_minor(struct tty_struct *tty);
 extern int rio_ismodem(struct tty_struct *tty);
 
diff --git a/drivers/char/rio/host.h b/drivers/char/rio/host.h
index 179cdbea712b..ee2ddea7a63a 100644
--- a/drivers/char/rio/host.h
+++ b/drivers/char/rio/host.h
@@ -48,8 +48,8 @@ struct Host {
         unsigned char Ivec;             /* POLLED or ivec number */
         unsigned char Mode;             /* Control stuff */
         unsigned char Slot;             /* Slot */
-        caddr_t Caddr;                  /* KV address of DPRAM */
-        struct DpRam *CardP;            /* KV address of DPRAM, with overlay */
+        void  __iomem *Caddr;           /* KV address of DPRAM */
+        struct DpRam __iomem *CardP;    /* KV address of DPRAM, with overlay */
         unsigned long PaddrP;           /* Phys. address of DPRAM */
         char Name[MAX_NAME_LEN];        /* The name of the host */
         unsigned int UniqueNum;         /* host unique number */
@@ -57,7 +57,7 @@ struct Host {
         unsigned int WorkToBeDone;      /* set to true each interrupt */
         unsigned int InIntr;            /* Being serviced? */
         unsigned int IntSrvDone;        /* host's interrupt has been serviced */
-        void (*Copy) (void *, void *, int);     /* copy func */
+        void (*Copy) (void *, void __iomem *, int);     /* copy func */
         struct timer_list timer;
         /*
          **               I M P O R T A N T !
@@ -83,11 +83,11 @@ struct Host {
 
         struct Top Topology[LINKS_PER_UNIT];    /* one per link */
         struct Map Mapping[MAX_RUP];            /* Mappings for host */
-        struct PHB *PhbP;                       /* Pointer to the PHB array */
-        unsigned short *PhbNumP;                /* Ptr to Number of PHB's */
-        struct LPB *LinkStrP;                   /* Link Structure Array */
-        struct RUP *RupP;                       /* Sixteen real rups here */
-        struct PARM_MAP *ParmMapP;              /* points to the parmmap */
+        struct PHB __iomem *PhbP;               /* Pointer to the PHB array */
+        unsigned short __iomem *PhbNumP;        /* Ptr to Number of PHB's */
+        struct LPB __iomem *LinkStrP;           /* Link Structure Array */
+        struct RUP __iomem *RupP;               /* Sixteen real rups here */
+        struct PARM_MAP __iomem *ParmMapP;      /* points to the parmmap */
         unsigned int ExtraUnits[MAX_EXTRA_UNITS];       /* unknown things */
         unsigned int NumExtraBooted;            /* how many of the above */
         /*
diff --git a/drivers/char/rio/port.h b/drivers/char/rio/port.h
index 9b5fa3eb0402..49cf6d15ee54 100644
--- a/drivers/char/rio/port.h
+++ b/drivers/char/rio/port.h
@@ -40,7 +40,7 @@ struct Port {
         struct gs_port gs;
         int PortNum;                    /* RIO port no., 0-511 */
         struct Host *HostP;
-        caddr_t Caddr;
+        void __iomem *Caddr;
         unsigned short HostPort;        /* Port number on host card */
         unsigned char RupNum;           /* Number of RUP for port */
         unsigned char ID2;              /* Second ID of RTA for port */
@@ -92,13 +92,13 @@ struct Port {
 #define RIO_RTSFLOW     0x0400          /* RIO's own RTSFLOW flag */
 
 
-        struct PHB *PhbP;               /* pointer to PHB for port */
-        u16 *TxAdd;                     /* Add packets here */
-        u16 *TxStart;                   /* Start of add array */
-        u16 *TxEnd;                     /* End of add array */
-        u16 *RxRemove;                  /* Remove packets here */
-        u16 *RxStart;                   /* Start of remove array */
-        u16 *RxEnd;                     /* End of remove array */
+        struct PHB __iomem *PhbP;       /* pointer to PHB for port */
+        u16 __iomem *TxAdd;             /* Add packets here */
+        u16 __iomem *TxStart;           /* Start of add array */
+        u16 __iomem *TxEnd;             /* End of add array */
+        u16 __iomem *RxRemove;          /* Remove packets here */
+        u16 __iomem *RxStart;           /* Start of remove array */
+        u16 __iomem *RxEnd;             /* End of remove array */
         unsigned int RtaUniqueNum;      /* Unique number of RTA */
         unsigned short PortState;       /* status of port */
         unsigned short ModemState;      /* status of modem lines */
diff --git a/drivers/char/rio/rio.h b/drivers/char/rio/rio.h
index b4c91871ba28..1bf36223a4e8 100644
--- a/drivers/char/rio/rio.h
+++ b/drivers/char/rio/rio.h
@@ -129,8 +129,8 @@
 **      RIO_OBJ takes hostp->Caddr and a UNIX pointer to an object and
 **      returns the offset into the DP RAM area.
 */
-#define RIO_PTR(C,O) (((unsigned char *)(C))+(0xFFFF&(O)))
-#define RIO_OFF(C,O) ((long)(O)-(long)(C))
+#define RIO_PTR(C,O) (((unsigned char __iomem *)(C))+(0xFFFF&(O)))
+#define RIO_OFF(C,O) ((unsigned char __iomem *)(O)-(unsigned char __iomem *)(C))
 
 /*
 **      How to convert from various different device number formats:
diff --git a/drivers/char/rio/rio_linux.c b/drivers/char/rio/rio_linux.c
index 78dd856534ce..aa43436d5d1b 100644
--- a/drivers/char/rio/rio_linux.c
+++ b/drivers/char/rio/rio_linux.c
@@ -333,9 +333,9 @@ int RIODelay_ni(struct Port *PortP, int njiffies)
         return !RIO_FAIL;
 }
 
-void rio_copy_to_card(void *to, void *from, int len)
+void rio_copy_to_card(void *from, void __iomem *to, int len)
 {
-        rio_memcpy_toio(NULL, to, from, len);
+        rio_copy_toio(to, from, len);
 }
 
 int rio_minor(struct tty_struct *tty)
@@ -573,7 +573,7 @@ static int rio_fw_ioctl(struct inode *inode, struct file *filp, unsigned int cmd
         func_enter();
 
         /* The "dev" argument isn't used. */
-        rc = riocontrol(p, 0, cmd, (void *) arg, capable(CAP_SYS_ADMIN));
+        rc = riocontrol(p, 0, cmd, arg, capable(CAP_SYS_ADMIN));
 
         func_exit();
         return rc;
@@ -583,6 +583,7 @@ extern int RIOShortCommand(struct rio_info *p, struct Port *PortP, int command,
 
 static int rio_ioctl(struct tty_struct *tty, struct file *filp, unsigned int cmd, unsigned long arg)
 {
+        void __user *argp = (void __user *)arg;
         int rc;
         struct Port *PortP;
         int ival;
@@ -594,14 +595,14 @@ static int rio_ioctl(struct tty_struct *tty, struct file *filp, unsigned int cmd
         rc = 0;
         switch (cmd) {
         case TIOCSSOFTCAR:
-                if ((rc = get_user(ival, (unsigned int *) arg)) == 0) {
+                if ((rc = get_user(ival, (unsigned __user *) argp)) == 0) {
                         tty->termios->c_cflag = (tty->termios->c_cflag & ~CLOCAL) | (ival ? CLOCAL : 0);
                 }
                 break;
         case TIOCGSERIAL:
                 rc = -EFAULT;
-                if (access_ok(VERIFY_WRITE, (void *) arg, sizeof(struct serial_struct)))
-                        rc = gs_getserial(&PortP->gs, (struct serial_struct *) arg);
+                if (access_ok(VERIFY_WRITE, argp, sizeof(struct serial_struct)))
+                        rc = gs_getserial(&PortP->gs, argp);
                 break;
         case TCSBRK:
                 if (PortP->State & RIO_DELETED) {
@@ -631,8 +632,8 @@ static int rio_ioctl(struct tty_struct *tty, struct file *filp, unsigned int cmd
                 break;
         case TIOCSSERIAL:
                 rc = -EFAULT;
-                if (access_ok(VERIFY_READ, (void *) arg, sizeof(struct serial_struct)))
-                        rc = gs_setserial(&PortP->gs, (struct serial_struct *) arg);
+                if (access_ok(VERIFY_READ, argp, sizeof(struct serial_struct)))
+                        rc = gs_setserial(&PortP->gs, argp);
                 break;
         default:
                 rc = -ENOIOCTLCMD;
@@ -919,7 +920,7 @@ static void __exit rio_release_drivers(void)
 static void fix_rio_pci(struct pci_dev *pdev)
 {
         unsigned long hwbase;
-        unsigned char *rebase;
+        unsigned char __iomem *rebase;
         unsigned int t;
 
 #define CNTRL_REG_OFFSET        0x50
@@ -999,7 +1000,7 @@ static int __init rio_init(void)
                 if (((1 << hp->Ivec) & rio_irqmask) == 0)
                         hp->Ivec = 0;
                 hp->Caddr = ioremap(p->RIOHosts[p->RIONumHosts].PaddrP, RIO_WINDOW_LEN);
-                hp->CardP = (struct DpRam *) hp->Caddr;
+                hp->CardP = (struct DpRam __iomem *) hp->Caddr;
                 hp->Type = RIO_PCI;
                 hp->Copy = rio_copy_to_card;
                 hp->Mode = RIO_PCI_BOOT_FROM_RAM;
@@ -1021,7 +1022,7 @@ static int __init rio_init(void)
                         p->RIONumHosts++;
                         found++;
                 } else {
-                        iounmap((char *) (p->RIOHosts[p->RIONumHosts].Caddr));
+                        iounmap(p->RIOHosts[p->RIONumHosts].Caddr);
                 }
         }
 
@@ -1047,7 +1048,7 @@ static int __init rio_init(void)
                         hp->Ivec = 0;
                 hp->Ivec |= 0x8000;     /* Mark as non-sharable */
                 hp->Caddr = ioremap(p->RIOHosts[p->RIONumHosts].PaddrP, RIO_WINDOW_LEN);
-                hp->CardP = (struct DpRam *) hp->Caddr;
+                hp->CardP = (struct DpRam __iomem *) hp->Caddr;
                 hp->Type = RIO_PCI;
                 hp->Copy = rio_copy_to_card;
                 hp->Mode = RIO_PCI_BOOT_FROM_RAM;
@@ -1070,7 +1071,7 @@ static int __init rio_init(void)
                         p->RIONumHosts++;
                         found++;
                 } else {
-                        iounmap((char *) (p->RIOHosts[p->RIONumHosts].Caddr));
+                        iounmap(p->RIOHosts[p->RIONumHosts].Caddr);
                 }
 #else
                 printk(KERN_ERR "Found an older RIO PCI card, but the driver is not " "compiled to support it.\n");
@@ -1085,7 +1086,7 @@ static int __init rio_init(void)
                 /* There was something about the IRQs of these cards. 'Forget what.--REW */
                 hp->Ivec = 0;
                 hp->Caddr = ioremap(p->RIOHosts[p->RIONumHosts].PaddrP, RIO_WINDOW_LEN);
-                hp->CardP = (struct DpRam *) hp->Caddr;
+                hp->CardP = (struct DpRam __iomem *) hp->Caddr;
                 hp->Type = RIO_AT;
                 hp->Copy = rio_copy_to_card;    /* AT card PCI???? - PVDL
                                          * -- YES! this is now a normal copy. Only the
@@ -1111,7 +1112,7 @@ static int __init rio_init(void)
                         }
 
                         if (!okboard)
-                                iounmap((char *) (hp->Caddr));
+                                iounmap(hp->Caddr);
                 }
         }
 
diff --git a/drivers/char/rio/rio_linux.h b/drivers/char/rio/rio_linux.h
index 4ce77fb1fae5..55b9c97e8477 100644
--- a/drivers/char/rio/rio_linux.h
+++ b/drivers/char/rio/rio_linux.h
@@ -131,9 +131,9 @@ struct vpd_prom {
 
 
 #ifdef CONFIG_RIO_OLDPCI
-static inline void *rio_memcpy_toio(void *dummy, void *dest, void *source, int n)
+static inline void __iomem *rio_memcpy_toio(void __iomem *dummy, void __iomem *dest, void *source, int n)
 {
-        char *dst = dest;
+        char __iomem *dst = dest;
         char *src = source;
 
         while (n--) {
@@ -144,11 +144,22 @@ static inline void *rio_memcpy_toio(void *dummy, void *dest, void *source, int n
         return dest;
 }
 
+static inline void __iomem *rio_copy_toio(void __iomem *dest, void *source, int n)
+{
+        char __iomem *dst = dest;
+        char *src = source;
+
+        while (n--)
+                writeb(*src++, dst++);
 
-static inline void *rio_memcpy_fromio(void *dest, void *source, int n)
+        return dest;
+}
+
+
+static inline void *rio_memcpy_fromio(void *dest, void __iomem *source, int n)
 {
         char *dst = dest;
-        char *src = source;
+        char __iomem *src = source;
 
         while (n--)
                 *dst++ = readb(src++);
@@ -158,6 +169,7 @@ static inline void *rio_memcpy_fromio(void *dest, void *source, int n)
 
 #else
 #define rio_memcpy_toio(dummy,dest,source,n)   memcpy_toio(dest, source, n)
+#define rio_copy_toio                          memcpy_toio
 #define rio_memcpy_fromio                      memcpy_fromio
 #endif
 
diff --git a/drivers/char/rio/rioboot.c b/drivers/char/rio/rioboot.c
index 290143addd34..eca2b95343e2 100644
--- a/drivers/char/rio/rioboot.c
+++ b/drivers/char/rio/rioboot.c
@@ -71,7 +71,7 @@
 #include "cmdblk.h"
 #include "route.h"
 
-static int RIOBootComplete(struct rio_info *p, struct Host *HostP, unsigned int Rup, struct PktCmd *PktCmdP);
+static int RIOBootComplete(struct rio_info *p, struct Host *HostP, unsigned int Rup, struct PktCmd __iomem *PktCmdP);
 
 static const unsigned char RIOAtVec2Ctrl[] = {
         /* 0 */ INTERRUPT_DISABLE,
@@ -204,13 +204,13 @@ void rio_start_card_running(struct Host *HostP)
 int RIOBootCodeHOST(struct rio_info *p, struct DownLoad *rbp)
 {
         struct Host *HostP;
-        u8 *Cad;
-        PARM_MAP *ParmMapP;
+        u8 __iomem *Cad;
+        PARM_MAP __iomem *ParmMapP;
         int RupN;
         int PortN;
         unsigned int host;
-        u8 *StartP;
-        u8 *DestP;
+        u8 __iomem *StartP;
+        u8 __iomem *DestP;
         int wait_count;
         u16 OldParmMap;
         u16 offset;             /* It is very important that this is a u16 */
@@ -262,7 +262,7 @@ int RIOBootCodeHOST(struct rio_info *p, struct DownLoad *rbp)
                  ** Ensure that the host really is stopped.
                  ** Disable it's external bus & twang its reset line.
                  */
-                RIOHostReset(HostP->Type, (struct DpRam *) HostP->CardP, HostP->Slot);
+                RIOHostReset(HostP->Type, HostP->CardP, HostP->Slot);
 
                 /*
                  ** Copy the data directly from user space to the SRAM.
@@ -280,7 +280,7 @@ int RIOBootCodeHOST(struct rio_info *p, struct DownLoad *rbp)
                         func_exit();
                         return -ENOMEM;
                 }
-                if (copy_from_user(rbp->DataP, DownCode, rbp->Count)) {
+                if (copy_from_user(DownCode, rbp->DataP, rbp->Count)) {
                         kfree(DownCode);
                         p->RIOError.Error = COPYIN_FAILED;
                         func_exit();
@@ -366,7 +366,7 @@ int RIOBootCodeHOST(struct rio_info *p, struct DownLoad *rbp)
                  ** a short branch to 0x7FF8, where a long branch is coded.
                  */
 
-                DestP = (u8 *) &Cad[0x7FF8];    /* <<<---- READ THE ABOVE COMMENTS */
+                DestP = &Cad[0x7FF8];   /* <<<---- READ THE ABOVE COMMENTS */
 
 #define NFIX(N) (0x60 | (N))    /* .O  = (~(.O + N))<<4 */
 #define PFIX(N) (0x20 | (N))    /* .O  =   (.O + N)<<4  */
@@ -438,7 +438,7 @@ int RIOBootCodeHOST(struct rio_info *p, struct DownLoad *rbp)
                         rio_dprintk(RIO_DEBUG_BOOT, "RIO Mesg Run Fail\n");
                         HostP->Flags &= ~RUN_STATE;
                         HostP->Flags |= RC_STUFFED;
-                        RIOHostReset( HostP->Type, (struct DpRam *)HostP->CardP, HostP->Slot );
+                        RIOHostReset( HostP->Type, HostP->CardP, HostP->Slot );
                         continue;
                 }
 
@@ -453,9 +453,9 @@ int RIOBootCodeHOST(struct rio_info *p, struct DownLoad *rbp)
                 /*
                  ** Grab a 32 bit pointer to the parmmap structure
                  */
-                ParmMapP = (PARM_MAP *) RIO_PTR(Cad, readw(&HostP->__ParmMapR));
+                ParmMapP = (PARM_MAP __iomem *) RIO_PTR(Cad, readw(&HostP->__ParmMapR));
                 rio_dprintk(RIO_DEBUG_BOOT, "ParmMapP : %p\n", ParmMapP);
-                ParmMapP = (PARM_MAP *) ((unsigned long) Cad + readw(&HostP->__ParmMapR));
+                ParmMapP = (PARM_MAP __iomem *)(Cad + readw(&HostP->__ParmMapR));
                 rio_dprintk(RIO_DEBUG_BOOT, "ParmMapP : %p\n", ParmMapP);
 
                 /*
@@ -468,7 +468,7 @@ int RIOBootCodeHOST(struct rio_info *p, struct DownLoad *rbp)
                         rio_dprintk(RIO_DEBUG_BOOT, "Links = 0x%x\n", readw(&ParmMapP->links));
                         HostP->Flags &= ~RUN_STATE;
                         HostP->Flags |= RC_STUFFED;
-                        RIOHostReset( HostP->Type, (struct DpRam *)HostP->CardP, HostP->Slot );
+                        RIOHostReset( HostP->Type, HostP->CardP, HostP->Slot );
                         continue;
                 }
 
@@ -491,7 +491,7 @@ int RIOBootCodeHOST(struct rio_info *p, struct DownLoad *rbp)
                         rio_dprintk(RIO_DEBUG_BOOT, "Timedout waiting for init_done\n");
                         HostP->Flags &= ~RUN_STATE;
                         HostP->Flags |= RC_STUFFED;
-                        RIOHostReset( HostP->Type, (struct DpRam *)HostP->CardP, HostP->Slot );
+                        RIOHostReset( HostP->Type, HostP->CardP, HostP->Slot );
                         continue;
                 }
 
@@ -512,10 +512,10 @@ int RIOBootCodeHOST(struct rio_info *p, struct DownLoad *rbp)
                  ** 32 bit pointers for the driver in ioremap space.
                  */
                 HostP->ParmMapP = ParmMapP;
-                HostP->PhbP = (struct PHB *) RIO_PTR(Cad, readw(&ParmMapP->phb_ptr));
-                HostP->RupP = (struct RUP *) RIO_PTR(Cad, readw(&ParmMapP->rups));
-                HostP->PhbNumP = (unsigned short *) RIO_PTR(Cad, readw(&ParmMapP->phb_num_ptr));
-                HostP->LinkStrP = (struct LPB *) RIO_PTR(Cad, readw(&ParmMapP->link_str_ptr));
+                HostP->PhbP = (struct PHB __iomem *) RIO_PTR(Cad, readw(&ParmMapP->phb_ptr));
+                HostP->RupP = (struct RUP __iomem *) RIO_PTR(Cad, readw(&ParmMapP->rups));
+                HostP->PhbNumP = (unsigned short __iomem *) RIO_PTR(Cad, readw(&ParmMapP->phb_num_ptr));
+                HostP->LinkStrP = (struct LPB __iomem *) RIO_PTR(Cad, readw(&ParmMapP->link_str_ptr));
 
                 /*
                  ** point the UnixRups at the real Rups
@@ -540,7 +540,7 @@ int RIOBootCodeHOST(struct rio_info *p, struct DownLoad *rbp)
                 for (PortN = p->RIOFirstPortsMapped; PortN < p->RIOLastPortsMapped + PORTS_PER_RTA; PortN++) {
                         if (p->RIOPortp[PortN]->HostP == HostP) {
                                 struct Port *PortP = p->RIOPortp[PortN];
-                                struct PHB *PhbP;
+                                struct PHB __iomem *PhbP;
                                 /* int oldspl; */
 
                                 if (!PortP->Mapped)
@@ -551,12 +551,12 @@ int RIOBootCodeHOST(struct rio_info *p, struct DownLoad *rbp)
 
                                 PortP->PhbP = PhbP;
 
-                                PortP->TxAdd = (u16 *) RIO_PTR(Cad, readw(&PhbP->tx_add));
-                                PortP->TxStart = (u16 *) RIO_PTR(Cad, readw(&PhbP->tx_start));
-                                PortP->TxEnd = (u16 *) RIO_PTR(Cad, readw(&PhbP->tx_end));
-                                PortP->RxRemove = (u16 *) RIO_PTR(Cad, readw(&PhbP->rx_remove));
-                                PortP->RxStart = (u16 *) RIO_PTR(Cad, readw(&PhbP->rx_start));
-                                PortP->RxEnd = (u16 *) RIO_PTR(Cad, readw(&PhbP->rx_end));
+                                PortP->TxAdd = (u16 __iomem *) RIO_PTR(Cad, readw(&PhbP->tx_add));
+                                PortP->TxStart = (u16 __iomem *) RIO_PTR(Cad, readw(&PhbP->tx_start));
+                                PortP->TxEnd = (u16 __iomem *) RIO_PTR(Cad, readw(&PhbP->tx_end));
+                                PortP->RxRemove = (u16 __iomem *) RIO_PTR(Cad, readw(&PhbP->rx_remove));
+                                PortP->RxStart = (u16 __iomem *) RIO_PTR(Cad, readw(&PhbP->rx_start));
+                                PortP->RxEnd = (u16 __iomem *) RIO_PTR(Cad, readw(&PhbP->rx_end));
 
                                 rio_spin_unlock_irqrestore(&PortP->portSem, flags);
                                 /*
@@ -601,9 +601,9 @@ int RIOBootCodeHOST(struct rio_info *p, struct DownLoad *rbp)
  *      return 1. If we havent, then return 0.
  */
 
-int RIOBootRup(struct rio_info *p, unsigned int Rup, struct Host *HostP, struct PKT *PacketP)
+int RIOBootRup(struct rio_info *p, unsigned int Rup, struct Host *HostP, struct PKT __iomem *PacketP)
 {
-        struct PktCmd *PktCmdP = (struct PktCmd *) PacketP->data;
+        struct PktCmd __iomem *PktCmdP = (struct PktCmd __iomem *) PacketP->data;
         struct PktCmd_M *PktReplyP;
         struct CmdBlk *CmdBlkP;
         unsigned int sequence;
@@ -722,7 +722,7 @@ int RIOBootRup(struct rio_info *p, unsigned int Rup, struct Host *HostP, struct
  *      RtaUniq is the booted RTA.
  */
 
-static int RIOBootComplete(struct rio_info *p, struct Host *HostP, unsigned int Rup, struct PktCmd *PktCmdP)
+static int RIOBootComplete(struct rio_info *p, struct Host *HostP, unsigned int Rup, struct PktCmd __iomem *PktCmdP)
 {
         struct Map *MapP = NULL;
         struct Map *MapP2 = NULL;
diff --git a/drivers/char/rio/riocmd.c b/drivers/char/rio/riocmd.c
index e6d2b14b5e65..4df6ab2206a1 100644
--- a/drivers/char/rio/riocmd.c
+++ b/drivers/char/rio/riocmd.c
@@ -180,7 +180,7 @@ int RIOCommandRta(struct rio_info *p, unsigned long RtaUnique, int (*func) (stru
 }
 
 
-int RIOIdentifyRta(struct rio_info *p, void * arg)
+int RIOIdentifyRta(struct rio_info *p, void __user * arg)
 {
         unsigned int Host;
 
@@ -245,7 +245,7 @@ int RIOIdentifyRta(struct rio_info *p, void * arg)
 }
 
 
-int RIOKillNeighbour(struct rio_info *p, void * arg)
+int RIOKillNeighbour(struct rio_info *p, void __user * arg)
 {
         uint Host;
         uint ID;
@@ -370,9 +370,9 @@ int RIOFoadWakeup(struct rio_info *p)
 /*
 ** Incoming command on the COMMAND_RUP to be processed.
 */
-static int RIOCommandRup(struct rio_info *p, uint Rup, struct Host *HostP, struct PKT * PacketP)
+static int RIOCommandRup(struct rio_info *p, uint Rup, struct Host *HostP, struct PKT __iomem *PacketP)
 {
-        struct PktCmd *PktCmdP = (struct PktCmd *) PacketP->data;
+        struct PktCmd __iomem *PktCmdP = (struct PktCmd __iomem *)PacketP->data;
         struct Port *PortP;
         struct UnixRup *UnixRupP;
         unsigned short SysPort;
@@ -407,12 +407,12 @@ static int RIOCommandRup(struct rio_info *p, uint Rup, struct Host *HostP, struc
                 } else
                         rio_dprintk(RIO_DEBUG_CMD, "CONTROL information: This is the RUP for link ``%c'' of host ``%s''\n", ('A' + Rup - MAX_RUP), HostP->Name);
 
-                rio_dprintk(RIO_DEBUG_CMD, "PACKET information: Destination 0x%x:0x%x\n", PacketP->dest_unit, PacketP->dest_port);
-                rio_dprintk(RIO_DEBUG_CMD, "PACKET information: Source    0x%x:0x%x\n", PacketP->src_unit, PacketP->src_port);
-                rio_dprintk(RIO_DEBUG_CMD, "PACKET information: Length    0x%x (%d)\n", PacketP->len, PacketP->len);
-                rio_dprintk(RIO_DEBUG_CMD, "PACKET information: Control  0x%x (%d)\n", PacketP->control, PacketP->control);
-                rio_dprintk(RIO_DEBUG_CMD, "PACKET information: Check      0x%x (%d)\n", PacketP->csum, PacketP->csum);
-                rio_dprintk(RIO_DEBUG_CMD, "COMMAND information: Host Port Number 0x%x, " "Command Code 0x%x\n", PktCmdP->PhbNum, PktCmdP->Command);
+                rio_dprintk(RIO_DEBUG_CMD, "PACKET information: Destination 0x%x:0x%x\n", readb(&PacketP->dest_unit), readb(&PacketP->dest_port));
+                rio_dprintk(RIO_DEBUG_CMD, "PACKET information: Source    0x%x:0x%x\n", readb(&PacketP->src_unit), readb(&PacketP->src_port));
+                rio_dprintk(RIO_DEBUG_CMD, "PACKET information: Length    0x%x (%d)\n", readb(&PacketP->len), readb(&PacketP->len));
+                rio_dprintk(RIO_DEBUG_CMD, "PACKET information: Control  0x%x (%d)\n", readb(&PacketP->control), readb(&PacketP->control));
+                rio_dprintk(RIO_DEBUG_CMD, "PACKET information: Check      0x%x (%d)\n", readw(&PacketP->csum), readw(&PacketP->csum));
+                rio_dprintk(RIO_DEBUG_CMD, "COMMAND information: Host Port Number 0x%x, " "Command Code 0x%x\n", readb(&PktCmdP->PhbNum), readb(&PktCmdP->Command));
                 return 1;
         }
         PortP = p->RIOPortp[SysPort];
@@ -601,7 +601,7 @@ int RIOQueueCmdBlk(struct Host *HostP, uint Rup, struct CmdBlk *CmdBlkP)
                 /*
                  ** Whammy! blat that pack!
                  */
-                HostP->Copy((caddr_t) & CmdBlkP->Packet, RIO_PTR(HostP->Caddr, UnixRupP->RupP->txpkt), sizeof(struct PKT));
+                HostP->Copy(&CmdBlkP->Packet, RIO_PTR(HostP->Caddr, readw(&UnixRupP->RupP->txpkt)), sizeof(struct PKT));
 
                 /*
                  ** place command packet on the pending position.
@@ -655,7 +655,7 @@ void RIOPollHostCommands(struct rio_info *p, struct Host *HostP)
 {
         struct CmdBlk *CmdBlkP;
         struct UnixRup *UnixRupP;
-        struct PKT *PacketP;
+        struct PKT __iomem *PacketP;
         unsigned short Rup;
         unsigned long flags;
 
@@ -676,7 +676,7 @@ void RIOPollHostCommands(struct rio_info *p, struct Host *HostP)
                 if (readw(&UnixRupP->RupP->rxcontrol) != RX_RUP_INACTIVE) {
                         int FreeMe;
 
-                        PacketP = (struct PKT *) RIO_PTR(HostP->Caddr, readw(&UnixRupP->RupP->rxpkt));
+                        PacketP = (struct PKT __iomem *) RIO_PTR(HostP->Caddr, readw(&UnixRupP->RupP->rxpkt));
 
                         switch (readb(&PacketP->dest_port)) {
                         case BOOT_RUP:
@@ -694,9 +694,9 @@ void RIOPollHostCommands(struct rio_info *p, struct Host *HostP)
                                  */
                                 rio_spin_unlock_irqrestore(&UnixRupP->RupLock, flags);
                                 FreeMe = RIOCommandRup(p, Rup, HostP, PacketP);
-                                if (PacketP->data[5] == MEMDUMP) {
-                                        rio_dprintk(RIO_DEBUG_CMD, "Memdump from 0x%x complete\n", *(unsigned short *) & (PacketP->data[6]));
-                                        HostP->Copy((caddr_t) & (PacketP->data[8]), (caddr_t) p->RIOMemDump, 32);
+                                if (readb(&PacketP->data[5]) == MEMDUMP) {
+                                        rio_dprintk(RIO_DEBUG_CMD, "Memdump from 0x%x complete\n", readw(&(PacketP->data[6])));
+                                        rio_memcpy_fromio(p->RIOMemDump, &(PacketP->data[8]), 32);
                                 }
                                 rio_spin_lock_irqsave(&UnixRupP->RupLock, flags);
                                 break;
@@ -782,7 +782,7 @@ void RIOPollHostCommands(struct rio_info *p, struct Host *HostP)
                                 /*
                                  ** Whammy! blat that pack!
                                  */
-                                HostP->Copy((caddr_t) & CmdBlkP->Packet, RIO_PTR(HostP->Caddr, UnixRupP->RupP->txpkt), sizeof(struct PKT));
+                                HostP->Copy(&CmdBlkP->Packet, RIO_PTR(HostP->Caddr, readw(&UnixRupP->RupP->txpkt)), sizeof(struct PKT));
 
                                 /*
                                  ** remove the command from the rup command queue...
@@ -824,7 +824,7 @@ int RIOWFlushMark(unsigned long iPortP, struct CmdBlk *CmdBlkP)
 int RIORFlushEnable(unsigned long iPortP, struct CmdBlk *CmdBlkP)
 {
         struct Port *PortP = (struct Port *) iPortP;
-        struct PKT *PacketP;
+        struct PKT __iomem *PacketP;
         unsigned long flags;
 
         rio_spin_lock_irqsave(&PortP->portSem, flags);
diff --git a/drivers/char/rio/rioctrl.c b/drivers/char/rio/rioctrl.c
index 75b2557c37ec..052e8120a471 100644
--- a/drivers/char/rio/rioctrl.c
+++ b/drivers/char/rio/rioctrl.c
@@ -80,7 +80,7 @@ static char *_rioctrl_c_sccs_ = "@(#)rioctrl.c	1.3";
 static struct LpbReq LpbReq;
 static struct RupReq RupReq;
 static struct PortReq PortReq;
-static struct HostReq HostReq;
+static struct HostReq HostReq;  /* oh really?  global?  and no locking? */
 static struct HostDpRam HostDpRam;
 static struct DebugCtrl DebugCtrl;
 static struct Map MapEnt;
@@ -126,12 +126,19 @@ static int
 
 #define drv_makedev(maj, min) ((((uint) maj & 0xff) << 8) | ((uint) min & 0xff))
 
-int riocontrol(p, dev, cmd, arg, su)
-struct rio_info *p;
-dev_t dev;
-int cmd;
-caddr_t arg;
-int su;
+static int copy_from_io(void __user *to, void __iomem *from, size_t size)
+{
+        void *buf = kmalloc(size, GFP_KERNEL);
+        int res = -ENOMEM;
+        if (buf) {
+                rio_memcpy_fromio(buf, from, size);
+                res = copy_to_user(to, buf, size);
+                kfree(buf);
+        }
+        return res;
+}
+
+int riocontrol(struct rio_info *p, dev_t dev, int cmd, unsigned long arg, int su)
 {
         uint Host;              /* leave me unsigned! */
         uint port;              /* and me! */
@@ -139,9 +146,10 @@ int su;
         ushort loop;
         int Entry;
         struct Port *PortP;
-        struct PKT *PacketP;
+        struct PKT __iomem *PacketP;
         int retval = 0;
         unsigned long flags;
+        void __user *argp = (void __user *)arg;
 
         func_enter();
 
@@ -149,7 +157,7 @@ int su;
         Host = 0;
         PortP = NULL;
 
-        rio_dprintk(RIO_DEBUG_CTRL, "control ioctl cmd: 0x%x arg: %p\n", cmd, arg);
+        rio_dprintk(RIO_DEBUG_CTRL, "control ioctl cmd: 0x%x arg: %p\n", cmd, argp);
 
         switch (cmd) {
                 /*
@@ -160,11 +168,11 @@ int su;
                  ** otherwise just the specified host card will be changed.
                  */
         case RIO_SET_TIMER:
-                rio_dprintk(RIO_DEBUG_CTRL, "RIO_SET_TIMER to %ldms\n", (unsigned long)arg);
+                rio_dprintk(RIO_DEBUG_CTRL, "RIO_SET_TIMER to %ldms\n", arg);
                 {
                         int host, value;
-                        host = ((unsigned long) arg >> 16) & 0x0000FFFF;
-                        value = (unsigned long) arg & 0x0000ffff;
+                        host = (arg >> 16) & 0x0000FFFF;
+                        value = arg & 0x0000ffff;
                         if (host == -1) {
                                 for (host = 0; host < p->RIONumHosts; host++) {
                                         if (p->RIOHosts[host].Flags == RC_RUNNING) {
@@ -183,26 +191,26 @@ int su;
 
         case RIO_FOAD_RTA:
                 rio_dprintk(RIO_DEBUG_CTRL, "RIO_FOAD_RTA\n");
-                return RIOCommandRta(p, (unsigned long)arg, RIOFoadRta);
+                return RIOCommandRta(p, arg, RIOFoadRta);
 
         case RIO_ZOMBIE_RTA:
                 rio_dprintk(RIO_DEBUG_CTRL, "RIO_ZOMBIE_RTA\n");
-                return RIOCommandRta(p, (unsigned long)arg, RIOZombieRta);
+                return RIOCommandRta(p, arg, RIOZombieRta);
 
         case RIO_IDENTIFY_RTA:
                 rio_dprintk(RIO_DEBUG_CTRL, "RIO_IDENTIFY_RTA\n");
-                return RIOIdentifyRta(p, arg);
+                return RIOIdentifyRta(p, argp);
 
         case RIO_KILL_NEIGHBOUR:
                 rio_dprintk(RIO_DEBUG_CTRL, "RIO_KILL_NEIGHBOUR\n");
-                return RIOKillNeighbour(p, arg);
+                return RIOKillNeighbour(p, argp);
 
         case SPECIAL_RUP_CMD:
                 {
                         struct CmdBlk *CmdBlkP;
 
                         rio_dprintk(RIO_DEBUG_CTRL, "SPECIAL_RUP_CMD\n");
-                        if (copy_from_user(&SpecialRupCmd, arg, sizeof(SpecialRupCmd))) {
+                        if (copy_from_user(&SpecialRupCmd, argp, sizeof(SpecialRupCmd))) {
                                 rio_dprintk(RIO_DEBUG_CTRL, "SPECIAL_RUP_CMD copy failed\n");
                                 p->RIOError.Error = COPYIN_FAILED;
                                 return -EFAULT;
@@ -239,7 +247,7 @@ int su;
                 if ((retval = RIOApel(p)) != 0)
                         return retval;
 
-                if (copy_to_user(arg, p->RIOConnectTable, TOTAL_MAP_ENTRIES * sizeof(struct Map))) {
+                if (copy_to_user(argp, p->RIOConnectTable, TOTAL_MAP_ENTRIES * sizeof(struct Map))) {
                         rio_dprintk(RIO_DEBUG_CTRL, "RIO_GET_TABLE copy failed\n");
                         p->RIOError.Error = COPYOUT_FAILED;
                         return -EFAULT;
@@ -284,7 +292,7 @@ int su;
                         p->RIOError.Error = NOT_SUPER_USER;
                         return -EPERM;
                 }
-                if (copy_from_user(&p->RIOConnectTable[0], arg, TOTAL_MAP_ENTRIES * sizeof(struct Map))) {
+                if (copy_from_user(&p->RIOConnectTable[0], argp, TOTAL_MAP_ENTRIES * sizeof(struct Map))) {
                         rio_dprintk(RIO_DEBUG_CTRL, "RIO_PUT_TABLE copy failed\n");
                         p->RIOError.Error = COPYIN_FAILED;
                         return -EFAULT;
@@ -330,7 +338,7 @@ int su;
                         p->RIOError.Error = NOT_SUPER_USER;
                         return -EPERM;
                 }
-                if (copy_to_user(arg, p->RIOBindTab, (sizeof(ulong) * MAX_RTA_BINDINGS))) {
+                if (copy_to_user(argp, p->RIOBindTab, (sizeof(ulong) * MAX_RTA_BINDINGS))) {
                         rio_dprintk(RIO_DEBUG_CTRL, "RIO_GET_BINDINGS copy failed\n");
                         p->RIOError.Error = COPYOUT_FAILED;
                         return -EFAULT;
@@ -349,7 +357,7 @@ int su;
                         p->RIOError.Error = NOT_SUPER_USER;
                         return -EPERM;
                 }
-                if (copy_from_user(&p->RIOBindTab[0], arg, (sizeof(ulong) * MAX_RTA_BINDINGS))) {
+                if (copy_from_user(&p->RIOBindTab[0], argp, (sizeof(ulong) * MAX_RTA_BINDINGS))) {
                         rio_dprintk(RIO_DEBUG_CTRL, "RIO_PUT_BINDINGS copy failed\n");
                         p->RIOError.Error = COPYIN_FAILED;
                         return -EFAULT;
@@ -373,12 +381,12 @@ int su;
                         for (Entry = 0; Entry < MAX_RTA_BINDINGS; Entry++) {
                                 if ((EmptySlot == -1) && (p->RIOBindTab[Entry] == 0L))
                                         EmptySlot = Entry;
-                                else if (p->RIOBindTab[Entry] == (long)arg) {
+                                else if (p->RIOBindTab[Entry] == arg) {
                                         /*
                                          ** Already exists - delete
                                          */
                                         p->RIOBindTab[Entry] = 0L;
-                                        rio_dprintk(RIO_DEBUG_CTRL, "Removing Rta %ld from p->RIOBindTab\n", (unsigned long)arg);
+                                        rio_dprintk(RIO_DEBUG_CTRL, "Removing Rta %ld from p->RIOBindTab\n", arg);
                                         return 0;
                                 }
                         }
@@ -386,10 +394,10 @@ int su;
                          ** Dosen't exist - add
                          */
                         if (EmptySlot != -1) {
-                                p->RIOBindTab[EmptySlot] = (unsigned long)arg;
-                                rio_dprintk(RIO_DEBUG_CTRL, "Adding Rta %lx to p->RIOBindTab\n", (unsigned long) arg);
+                                p->RIOBindTab[EmptySlot] = arg;
+                                rio_dprintk(RIO_DEBUG_CTRL, "Adding Rta %lx to p->RIOBindTab\n", arg);
                         } else {
-                                rio_dprintk(RIO_DEBUG_CTRL, "p->RIOBindTab full! - Rta %lx not added\n", (unsigned long) arg);
+                                rio_dprintk(RIO_DEBUG_CTRL, "p->RIOBindTab full! - Rta %lx not added\n", arg);
                                 return -ENOMEM;
                         }
                         return 0;
@@ -397,7 +405,7 @@ int su;
 
         case RIO_RESUME:
                 rio_dprintk(RIO_DEBUG_CTRL, "RIO_RESUME\n");
-                port = (unsigned long) arg;
+                port = arg;
                 if ((port < 0) || (port > 511)) {
                         rio_dprintk(RIO_DEBUG_CTRL, "RIO_RESUME: Bad port number %d\n", port);
                         p->RIOError.Error = PORT_NUMBER_OUT_OF_RANGE;
@@ -433,7 +441,7 @@ int su;
                         p->RIOError.Error = NOT_SUPER_USER;
                         return -EPERM;
                 }
-                if (copy_from_user(&MapEnt, arg, sizeof(MapEnt))) {
+                if (copy_from_user(&MapEnt, argp, sizeof(MapEnt))) {
                         rio_dprintk(RIO_DEBUG_CTRL, "Copy from user space failed\n");
                         p->RIOError.Error = COPYIN_FAILED;
                         return -EFAULT;
@@ -447,7 +455,7 @@ int su;
                         p->RIOError.Error = NOT_SUPER_USER;
                         return -EPERM;
                 }
-                if (copy_from_user(&MapEnt, arg, sizeof(MapEnt))) {
+                if (copy_from_user(&MapEnt, argp, sizeof(MapEnt))) {
                         rio_dprintk(RIO_DEBUG_CTRL, "Copy from user space failed\n");
                         p->RIOError.Error = COPYIN_FAILED;
                         return -EFAULT;
@@ -461,7 +469,7 @@ int su;
                         p->RIOError.Error = NOT_SUPER_USER;
                         return -EPERM;
                 }
-                if (copy_from_user(&MapEnt, arg, sizeof(MapEnt))) {
+                if (copy_from_user(&MapEnt, argp, sizeof(MapEnt))) {
                         rio_dprintk(RIO_DEBUG_CTRL, "Copy from data space failed\n");
                         p->RIOError.Error = COPYIN_FAILED;
                         return -EFAULT;
@@ -469,14 +477,14 @@ int su;
                 return RIODeleteRta(p, &MapEnt);
 
         case RIO_QUICK_CHECK:
-                if (copy_to_user(arg, &p->RIORtaDisCons, sizeof(unsigned int))) {
+                if (copy_to_user(argp, &p->RIORtaDisCons, sizeof(unsigned int))) {
                         p->RIOError.Error = COPYOUT_FAILED;
                         return -EFAULT;
                 }
                 return 0;
 
         case RIO_LAST_ERROR:
-                if (copy_to_user(arg, &p->RIOError, sizeof(struct Error)))
+                if (copy_to_user(argp, &p->RIOError, sizeof(struct Error)))
                         return -EFAULT;
                 return 0;
 
@@ -485,7 +493,7 @@ int su;
                 return -EINVAL;
 
         case RIO_GET_MODTYPE:
-                if (copy_from_user(&port, arg, sizeof(unsigned int))) {
+                if (copy_from_user(&port, argp, sizeof(unsigned int))) {
                         p->RIOError.Error = COPYIN_FAILED;
                         return -EFAULT;
                 }
@@ -505,7 +513,7 @@ int su;
                  ** Return module type of port
                  */
                 port = PortP->HostP->UnixRups[PortP->RupNum].ModTypes;
-                if (copy_to_user(arg, &port, sizeof(unsigned int))) {
+                if (copy_to_user(argp, &port, sizeof(unsigned int))) {
                         p->RIOError.Error = COPYOUT_FAILED;
                         return -EFAULT;
                 }
@@ -521,7 +529,7 @@ int su;
 
         case RIO_SETUP_PORTS:
                 rio_dprintk(RIO_DEBUG_CTRL, "Setup ports\n");
-                if (copy_from_user(&PortSetup, arg, sizeof(PortSetup))) {
+                if (copy_from_user(&PortSetup, argp, sizeof(PortSetup))) {
                         p->RIOError.Error = COPYIN_FAILED;
                         rio_dprintk(RIO_DEBUG_CTRL, "EFAULT");
                         return -EFAULT;
@@ -551,7 +559,7 @@ int su;
 
         case RIO_GET_PORT_SETUP:
                 rio_dprintk(RIO_DEBUG_CTRL, "Get port setup\n");
-                if (copy_from_user(&PortSetup, arg, sizeof(PortSetup))) {
+                if (copy_from_user(&PortSetup, argp, sizeof(PortSetup))) {
                         p->RIOError.Error = COPYIN_FAILED;
                         return -EFAULT;
                 }
@@ -572,7 +580,7 @@ int su;
                 PortSetup.XpOn[MAX_XP_CTRL_LEN - 1] = '\0';
                 PortSetup.XpOff[MAX_XP_CTRL_LEN - 1] = '\0';
 
-                if (copy_to_user(arg, &PortSetup, sizeof(PortSetup))) {
+                if (copy_to_user(argp, &PortSetup, sizeof(PortSetup))) {
                         p->RIOError.Error = COPYOUT_FAILED;
                         return -EFAULT;
                 }
@@ -580,7 +588,7 @@ int su;
 
         case RIO_GET_PORT_PARAMS:
                 rio_dprintk(RIO_DEBUG_CTRL, "Get port params\n");
-                if (copy_from_user(&PortParams, arg, sizeof(struct PortParams))) {
+                if (copy_from_user(&PortParams, argp, sizeof(struct PortParams))) {
                         p->RIOError.Error = COPYIN_FAILED;
                         return -EFAULT;
                 }
@@ -593,7 +601,7 @@ int su;
                 PortParams.State = PortP->State;
                 rio_dprintk(RIO_DEBUG_CTRL, "Port %d\n", PortParams.Port);
 
-                if (copy_to_user(arg, &PortParams, sizeof(struct PortParams))) {
+                if (copy_to_user(argp, &PortParams, sizeof(struct PortParams))) {
                         p->RIOError.Error = COPYOUT_FAILED;
                         return -EFAULT;
                 }
@@ -601,7 +609,7 @@ int su;
 
         case RIO_GET_PORT_TTY:
                 rio_dprintk(RIO_DEBUG_CTRL, "Get port tty\n");
-                if (copy_from_user(&PortTty, arg, sizeof(struct PortTty))) {
+                if (copy_from_user(&PortTty, argp, sizeof(struct PortTty))) {
                         p->RIOError.Error = COPYIN_FAILED;
                         return -EFAULT;
                 }
@@ -612,14 +620,14 @@ int su;
 
                 rio_dprintk(RIO_DEBUG_CTRL, "Port %d\n", PortTty.port);
                 PortP = (p->RIOPortp[PortTty.port]);
-                if (copy_to_user(arg, &PortTty, sizeof(struct PortTty))) {
+                if (copy_to_user(argp, &PortTty, sizeof(struct PortTty))) {
                         p->RIOError.Error = COPYOUT_FAILED;
                         return -EFAULT;
                 }
                 return retval;
 
         case RIO_SET_PORT_TTY:
-                if (copy_from_user(&PortTty, arg, sizeof(struct PortTty))) {
+                if (copy_from_user(&PortTty, argp, sizeof(struct PortTty))) {
                         p->RIOError.Error = COPYIN_FAILED;
                         return -EFAULT;
                 }
@@ -634,7 +642,7 @@ int su;
 
         case RIO_SET_PORT_PARAMS:
                 rio_dprintk(RIO_DEBUG_CTRL, "Set port params\n");
-                if (copy_from_user(&PortParams, arg, sizeof(PortParams))) {
+                if (copy_from_user(&PortParams, argp, sizeof(PortParams))) {
                         p->RIOError.Error = COPYIN_FAILED;
                         return -EFAULT;
                 }
@@ -650,7 +658,7 @@ int su;
 
         case RIO_GET_PORT_STATS:
                 rio_dprintk(RIO_DEBUG_CTRL, "RIO_GET_PORT_STATS\n");
-                if (copy_from_user(&portStats, arg, sizeof(struct portStats))) {
+                if (copy_from_user(&portStats, argp, sizeof(struct portStats))) {
                         p->RIOError.Error = COPYIN_FAILED;
                         return -EFAULT;
                 }
@@ -665,14 +673,14 @@ int su;
                 portStats.opens = PortP->opens;
                 portStats.closes = PortP->closes;
                 portStats.ioctls = PortP->ioctls;
-                if (copy_to_user(arg, &portStats, sizeof(struct portStats))) {
+                if (copy_to_user(argp, &portStats, sizeof(struct portStats))) {
                         p->RIOError.Error = COPYOUT_FAILED;
                         return -EFAULT;
                 }
                 return retval;
 
         case RIO_RESET_PORT_STATS:
-                port = (unsigned long) arg;
+                port = arg;
                 rio_dprintk(RIO_DEBUG_CTRL, "RIO_RESET_PORT_STATS\n");
                 if (port >= RIO_PORTS) {
                         p->RIOError.Error = PORT_NUMBER_OUT_OF_RANGE;
@@ -690,7 +698,7 @@ int su;
 
         case RIO_GATHER_PORT_STATS:
                 rio_dprintk(RIO_DEBUG_CTRL, "RIO_GATHER_PORT_STATS\n");
-                if (copy_from_user(&portStats, arg, sizeof(struct portStats))) {
+                if (copy_from_user(&portStats, argp, sizeof(struct portStats))) {
                         p->RIOError.Error = COPYIN_FAILED;
                         return -EFAULT;
                 }
@@ -706,7 +714,7 @@ int su;
 
         case RIO_READ_CONFIG:
                 rio_dprintk(RIO_DEBUG_CTRL, "RIO_READ_CONFIG\n");
-                if (copy_to_user(arg, &p->RIOConf, sizeof(struct Conf))) {
+                if (copy_to_user(argp, &p->RIOConf, sizeof(struct Conf))) {
                         p->RIOError.Error = COPYOUT_FAILED;
                         return -EFAULT;
                 }
@@ -718,7 +726,7 @@ int su;
                         p->RIOError.Error = NOT_SUPER_USER;
                         return -EPERM;
                 }
-                if (copy_from_user(&p->RIOConf, arg, sizeof(struct Conf))) {
+                if (copy_from_user(&p->RIOConf, argp, sizeof(struct Conf))) {
                         p->RIOError.Error = COPYIN_FAILED;
                         return -EFAULT;
                 }
@@ -746,7 +754,7 @@ int su;
         case RIO_SETDEBUG:
         case RIO_GETDEBUG:
                 rio_dprintk(RIO_DEBUG_CTRL, "RIO_SETDEBUG/RIO_GETDEBUG\n");
-                if (copy_from_user(&DebugCtrl, arg, sizeof(DebugCtrl))) {
+                if (copy_from_user(&DebugCtrl, argp, sizeof(DebugCtrl))) {
                         p->RIOError.Error = COPYIN_FAILED;
                         return -EFAULT;
                 }
@@ -763,7 +771,7 @@ int su;
                                 rio_dprintk(RIO_DEBUG_CTRL, "Get global debug 0x%x wait 0x%x\n", p->rio_debug, p->RIODebugWait);
                                 DebugCtrl.Debug = p->rio_debug;
                                 DebugCtrl.Wait = p->RIODebugWait;
-                                if (copy_to_user(arg, &DebugCtrl, sizeof(DebugCtrl))) {
+                                if (copy_to_user(argp, &DebugCtrl, sizeof(DebugCtrl))) {
                                         rio_dprintk(RIO_DEBUG_CTRL, "RIO_SET/GET DEBUG: bad port number %d\n", DebugCtrl.SysPort);
                                         p->RIOError.Error = COPYOUT_FAILED;
                                         return -EFAULT;
@@ -785,7 +793,7 @@ int su;
                 } else {
                         rio_dprintk(RIO_DEBUG_CTRL, "RIO_GETDEBUG 0x%x\n", p->RIOPortp[DebugCtrl.SysPort]->Debug);
                         DebugCtrl.Debug = p->RIOPortp[DebugCtrl.SysPort]->Debug;
-                        if (copy_to_user(arg, &DebugCtrl, sizeof(DebugCtrl))) {
+                        if (copy_to_user(argp, &DebugCtrl, sizeof(DebugCtrl))) {
                                 rio_dprintk(RIO_DEBUG_CTRL, "RIO_GETDEBUG: Bad copy to user space\n");
                                 p->RIOError.Error = COPYOUT_FAILED;
                                 return -EFAULT;
@@ -800,7 +808,7 @@ int su;
                  ** textual null terminated string.
                  */
                 rio_dprintk(RIO_DEBUG_CTRL, "RIO_VERSID\n");
-                if (copy_to_user(arg, RIOVersid(), sizeof(struct rioVersion))) {
+                if (copy_to_user(argp, RIOVersid(), sizeof(struct rioVersion))) {
                         rio_dprintk(RIO_DEBUG_CTRL, "RIO_VERSID: Bad copy to user space (host=%d)\n", Host);
                         p->RIOError.Error = COPYOUT_FAILED;
                         return -EFAULT;
@@ -813,7 +821,7 @@ int su;
                  ** at init time.
                  */
                 rio_dprintk(RIO_DEBUG_CTRL, "RIO_NUM_HOSTS\n");
-                if (copy_to_user(arg, &p->RIONumHosts, sizeof(p->RIONumHosts))) {
+                if (copy_to_user(argp, &p->RIONumHosts, sizeof(p->RIONumHosts))) {
                         rio_dprintk(RIO_DEBUG_CTRL, "RIO_NUM_HOSTS: Bad copy to user space\n");
                         p->RIOError.Error = COPYOUT_FAILED;
                         return -EFAULT;
@@ -824,7 +832,7 @@ int su;
                 /*
                  ** Kill host. This may not be in the final version...
                  */
-                rio_dprintk(RIO_DEBUG_CTRL, "RIO_HOST_FOAD %ld\n", (unsigned long) arg);
+                rio_dprintk(RIO_DEBUG_CTRL, "RIO_HOST_FOAD %ld\n", arg);
                 if (!su) {
                         rio_dprintk(RIO_DEBUG_CTRL, "RIO_HOST_FOAD: Not super user\n");
                         p->RIOError.Error = NOT_SUPER_USER;
@@ -858,7 +866,7 @@ int su;
                         p->RIOError.Error = NOT_SUPER_USER;
                         return -EPERM;
                 }
-                if (copy_from_user(&DownLoad, arg, sizeof(DownLoad))) {
+                if (copy_from_user(&DownLoad, argp, sizeof(DownLoad))) {
                         rio_dprintk(RIO_DEBUG_CTRL, "RIO_DOWNLOAD: Copy in from user space failed\n");
                         p->RIOError.Error = COPYIN_FAILED;
                         return -EFAULT;
@@ -888,7 +896,7 @@ int su;
                 {
                         unsigned int host;
 
-                        if (copy_from_user(&host, arg, sizeof(host))) {
+                        if (copy_from_user(&host, argp, sizeof(host))) {
                                 rio_dprintk(RIO_DEBUG_CTRL, "RIO_HOST_REQ: Copy in from user space failed\n");
                                 p->RIOError.Error = COPYIN_FAILED;
                                 return -EFAULT;
@@ -897,7 +905,7 @@ int su;
                          ** Fetch the parmmap
                          */
                         rio_dprintk(RIO_DEBUG_CTRL, "RIO_PARMS\n");
-                        if (copy_to_user(arg, p->RIOHosts[host].ParmMapP, sizeof(PARM_MAP))) {
+                        if (copy_from_io(argp, p->RIOHosts[host].ParmMapP, sizeof(PARM_MAP))) {
                                 p->RIOError.Error = COPYOUT_FAILED;
                                 rio_dprintk(RIO_DEBUG_CTRL, "RIO_PARMS: Copy out to user space failed\n");
                                 return -EFAULT;
@@ -907,7 +915,7 @@ int su;
 
         case RIO_HOST_REQ:
                 rio_dprintk(RIO_DEBUG_CTRL, "RIO_HOST_REQ\n");
-                if (copy_from_user(&HostReq, arg, sizeof(HostReq))) {
+                if (copy_from_user(&HostReq, argp, sizeof(HostReq))) {
                         rio_dprintk(RIO_DEBUG_CTRL, "RIO_HOST_REQ: Copy in from user space failed\n");
                         p->RIOError.Error = COPYIN_FAILED;
                         return -EFAULT;
@@ -928,7 +936,7 @@ int su;
 
         case RIO_HOST_DPRAM:
                 rio_dprintk(RIO_DEBUG_CTRL, "Request for DPRAM\n");
-                if (copy_from_user(&HostDpRam, arg, sizeof(HostDpRam))) {
+                if (copy_from_user(&HostDpRam, argp, sizeof(HostDpRam))) {
                         rio_dprintk(RIO_DEBUG_CTRL, "RIO_HOST_DPRAM: Copy in from user space failed\n");
                         p->RIOError.Error = COPYIN_FAILED;
                         return -EFAULT;
@@ -945,13 +953,13 @@ int su;
                         /* It's hardware like this that really gets on my tits. */
                         static unsigned char copy[sizeof(struct DpRam)];
                         for (off = 0; off < sizeof(struct DpRam); off++)
-                                copy[off] = readb(&p->RIOHosts[HostDpRam.HostNum].Caddr[off]);
+                                copy[off] = readb(p->RIOHosts[HostDpRam.HostNum].Caddr + off);
                         if (copy_to_user(HostDpRam.DpRamP, copy, sizeof(struct DpRam))) {
                                 p->RIOError.Error = COPYOUT_FAILED;
                                 rio_dprintk(RIO_DEBUG_CTRL, "RIO_HOST_DPRAM: Bad copy to user space\n");
                                 return -EFAULT;
                         }
-                } else if (copy_to_user(HostDpRam.DpRamP, p->RIOHosts[HostDpRam.HostNum].Caddr, sizeof(struct DpRam))) {
+                } else if (copy_from_io(HostDpRam.DpRamP, p->RIOHosts[HostDpRam.HostNum].Caddr, sizeof(struct DpRam))) {
                         p->RIOError.Error = COPYOUT_FAILED;
                         rio_dprintk(RIO_DEBUG_CTRL, "RIO_HOST_DPRAM: Bad copy to user space\n");
                         return -EFAULT;
@@ -960,13 +968,13 @@ int su;
 
         case RIO_SET_BUSY:
                 rio_dprintk(RIO_DEBUG_CTRL, "RIO_SET_BUSY\n");
-                if ((unsigned long) arg > 511) {
-                        rio_dprintk(RIO_DEBUG_CTRL, "RIO_SET_BUSY: Bad port number %ld\n", (unsigned long) arg);
+                if (arg > 511) {
+                        rio_dprintk(RIO_DEBUG_CTRL, "RIO_SET_BUSY: Bad port number %ld\n", arg);
                         p->RIOError.Error = PORT_NUMBER_OUT_OF_RANGE;
                         return -EINVAL;
                 }
                 rio_spin_lock_irqsave(&PortP->portSem, flags);
-                p->RIOPortp[(unsigned long) arg]->State |= RIO_BUSY;
+                p->RIOPortp[arg]->State |= RIO_BUSY;
                 rio_spin_unlock_irqrestore(&PortP->portSem, flags);
                 return retval;
 
@@ -976,7 +984,7 @@ int su;
                  ** (probably for debug reasons)
                  */
                 rio_dprintk(RIO_DEBUG_CTRL, "RIO_HOST_PORT\n");
-                if (copy_from_user(&PortReq, arg, sizeof(PortReq))) {
+                if (copy_from_user(&PortReq, argp, sizeof(PortReq))) {
                         rio_dprintk(RIO_DEBUG_CTRL, "RIO_HOST_PORT: Copy in from user space failed\n");
                         p->RIOError.Error = COPYIN_FAILED;
                         return -EFAULT;
@@ -1001,7 +1009,7 @@ int su;
                  ** (probably for debug reasons)
                  */
                 rio_dprintk(RIO_DEBUG_CTRL, "RIO_HOST_RUP\n");
-                if (copy_from_user(&RupReq, arg, sizeof(RupReq))) {
+                if (copy_from_user(&RupReq, argp, sizeof(RupReq))) {
                         rio_dprintk(RIO_DEBUG_CTRL, "RIO_HOST_RUP: Copy in from user space failed\n");
                         p->RIOError.Error = COPYIN_FAILED;
                         return -EFAULT;
@@ -1025,7 +1033,7 @@ int su;
                 }
                 rio_dprintk(RIO_DEBUG_CTRL, "Request for rup %d from host %d\n", RupReq.RupNum, RupReq.HostNum);
 
-                if (copy_to_user(HostP->UnixRups[RupReq.RupNum].RupP, RupReq.RupP, sizeof(struct RUP))) {
+                if (copy_from_io(RupReq.RupP, HostP->UnixRups[RupReq.RupNum].RupP, sizeof(struct RUP))) {
                         p->RIOError.Error = COPYOUT_FAILED;
                         rio_dprintk(RIO_DEBUG_CTRL, "RIO_HOST_RUP: Bad copy to user space\n");
                         return -EFAULT;
@@ -1038,7 +1046,7 @@ int su;
                  ** (probably for debug reasons)
                  */
                 rio_dprintk(RIO_DEBUG_CTRL, "RIO_HOST_LPB\n");
-                if (copy_from_user(&LpbReq, arg, sizeof(LpbReq))) {
+                if (copy_from_user(&LpbReq, argp, sizeof(LpbReq))) {
                         rio_dprintk(RIO_DEBUG_CTRL, "RIO_HOST_LPB: Bad copy from user space\n");
                         p->RIOError.Error = COPYIN_FAILED;
                         return -EFAULT;
@@ -1062,7 +1070,7 @@ int su;
                 }
                 rio_dprintk(RIO_DEBUG_CTRL, "Request for lpb %d from host %d\n", LpbReq.Link, LpbReq.Host);
 
-                if (copy_to_user(LpbReq.LpbP, &HostP->LinkStrP[LpbReq.Link], sizeof(struct LPB))) {
+                if (copy_from_io(LpbReq.LpbP, &HostP->LinkStrP[LpbReq.Link], sizeof(struct LPB))) {
                         rio_dprintk(RIO_DEBUG_CTRL, "RIO_HOST_LPB: Bad copy to user space\n");
                         p->RIOError.Error = COPYOUT_FAILED;
                         return -EFAULT;
@@ -1136,7 +1144,7 @@ int su;
         case RIO_MAP_B110_TO_110:
         case RIO_MAP_B110_TO_115200:
                 rio_dprintk(RIO_DEBUG_CTRL, "Baud rate mapping\n");
-                port = (unsigned long) arg;
+                port = arg;
                 if (port < 0 || port > 511) {
                         rio_dprintk(RIO_DEBUG_CTRL, "Baud rate mapping: Bad port number %d\n", port);
                         p->RIOError.Error = PORT_NUMBER_OUT_OF_RANGE;
@@ -1166,7 +1174,7 @@ int su;
 
         case RIO_SEND_PACKET:
                 rio_dprintk(RIO_DEBUG_CTRL, "RIO_SEND_PACKET\n");
-                if (copy_from_user(&SendPack, arg, sizeof(SendPack))) {
+                if (copy_from_user(&SendPack, argp, sizeof(SendPack))) {
                         rio_dprintk(RIO_DEBUG_CTRL, "RIO_SEND_PACKET: Bad copy from user space\n");
                         p->RIOError.Error = COPYIN_FAILED;
                         return -EFAULT;
@@ -1210,7 +1218,7 @@ int su;
                 return su ? 0 : -EPERM;
 
         case RIO_WHAT_MESG:
-                if (copy_to_user(arg, &p->RIONoMessage, sizeof(p->RIONoMessage))) {
+                if (copy_to_user(argp, &p->RIONoMessage, sizeof(p->RIONoMessage))) {
                         rio_dprintk(RIO_DEBUG_CTRL, "RIO_WHAT_MESG: Bad copy to user space\n");
                         p->RIOError.Error = COPYOUT_FAILED;
                         return -EFAULT;
@@ -1218,7 +1226,7 @@ int su;
                 return 0;
 
         case RIO_MEM_DUMP:
-                if (copy_from_user(&SubCmd, arg, sizeof(struct SubCmdStruct))) {
+                if (copy_from_user(&SubCmd, argp, sizeof(struct SubCmdStruct))) {
                         p->RIOError.Error = COPYIN_FAILED;
                         return -EFAULT;
                 }
@@ -1248,7 +1256,7 @@ int su;
                         PortP->State |= RIO_BUSY;
 
                 rio_spin_unlock_irqrestore(&PortP->portSem, flags);
-                if (copy_to_user(arg, p->RIOMemDump, MEMDUMP_SIZE)) {
+                if (copy_to_user(argp, p->RIOMemDump, MEMDUMP_SIZE)) {
                         rio_dprintk(RIO_DEBUG_CTRL, "RIO_MEM_DUMP copy failed\n");
                         p->RIOError.Error = COPYOUT_FAILED;
                         return -EFAULT;
@@ -1256,30 +1264,30 @@ int su;
                 return 0;
 
         case RIO_TICK:
-                if ((unsigned long) arg >= p->RIONumHosts)
+                if (arg >= p->RIONumHosts)
                         return -EINVAL;
-                rio_dprintk(RIO_DEBUG_CTRL, "Set interrupt for host %ld\n", (unsigned long) arg);
-                writeb(0xFF, &p->RIOHosts[(unsigned long) arg].SetInt);
+                rio_dprintk(RIO_DEBUG_CTRL, "Set interrupt for host %ld\n", arg);
+                writeb(0xFF, &p->RIOHosts[arg].SetInt);
                 return 0;
 
         case RIO_TOCK:
-                if ((unsigned long) arg >= p->RIONumHosts)
+                if (arg >= p->RIONumHosts)
                         return -EINVAL;
-                rio_dprintk(RIO_DEBUG_CTRL, "Clear interrupt for host %ld\n", (unsigned long) arg);
-                writeb(0xFF, &p->RIOHosts[(unsigned long) arg].ResetInt);
+                rio_dprintk(RIO_DEBUG_CTRL, "Clear interrupt for host %ld\n", arg);
+                writeb(0xFF, &p->RIOHosts[arg].ResetInt);
                 return 0;
 
         case RIO_READ_CHECK:
                 /* Check reads for pkts with data[0] the same */
                 p->RIOReadCheck = !p->RIOReadCheck;
-                if (copy_to_user(arg, &p->RIOReadCheck, sizeof(unsigned int))) {
+                if (copy_to_user(argp, &p->RIOReadCheck, sizeof(unsigned int))) {
                         p->RIOError.Error = COPYOUT_FAILED;
                         return -EFAULT;
                 }
                 return 0;
 
         case RIO_READ_REGISTER:
-                if (copy_from_user(&SubCmd, arg, sizeof(struct SubCmdStruct))) {
+                if (copy_from_user(&SubCmd, argp, sizeof(struct SubCmdStruct))) {
                         p->RIOError.Error = COPYIN_FAILED;
                         return -EFAULT;
                 }
@@ -1314,7 +1322,7 @@ int su;
                         PortP->State |= RIO_BUSY;
 
                 rio_spin_unlock_irqrestore(&PortP->portSem, flags);
-                if (copy_to_user(arg, &p->CdRegister, sizeof(unsigned int))) {
+                if (copy_to_user(argp, &p->CdRegister, sizeof(unsigned int))) {
                         rio_dprintk(RIO_DEBUG_CTRL, "RIO_READ_REGISTER copy failed\n");
                         p->RIOError.Error = COPYOUT_FAILED;
                         return -EFAULT;
@@ -1327,10 +1335,10 @@ int su;
                  */
         case RIO_MAKE_DEV:
                 {
-                        unsigned int port = (unsigned long) arg & RIO_MODEM_MASK;
+                        unsigned int port = arg & RIO_MODEM_MASK;
                         unsigned int ret;
 
-                        switch ((unsigned long) arg & RIO_DEV_MASK) {
+                        switch (arg & RIO_DEV_MASK) {
                         case RIO_DEV_DIRECT:
                                 ret = drv_makedev(MAJOR(dev), port);
                                 rio_dprintk(RIO_DEBUG_CTRL, "Makedev direct 0x%x is 0x%x\n", port, ret);
@@ -1358,7 +1366,7 @@ int su;
                         int mino;
                         unsigned long ret;
 
-                        dv = (dev_t) ((unsigned long) arg);
+                        dv = (dev_t) (arg);
                         mino = RIO_UNMODEM(dv);
 
                         if (RIO_ISMODEM(dv)) {
diff --git a/drivers/char/rio/rioinit.c b/drivers/char/rio/rioinit.c
index 24d2992154cc..12e34bc3f7ce 100644
--- a/drivers/char/rio/rioinit.c
+++ b/drivers/char/rio/rioinit.c
@@ -79,7 +79,7 @@ static char *_rioinit_c_sccs_ = "@(#)rioinit.c	1.3";
 
 int RIOPCIinit(struct rio_info *p, int Mode);
 
-static int RIOScrub(int, u8 *, int);
+static int RIOScrub(int, u8 __iomem *, int);
 
 
 /**
@@ -92,10 +92,10 @@ static int RIOScrub(int, u8 *, int);
 ** bits > 0 indicates 16 bit operation.
 */
 
-int RIOAssignAT(struct rio_info *p, int Base, caddr_t   virtAddr, int mode)
+int RIOAssignAT(struct rio_info *p, int Base, void __iomem *virtAddr, int mode)
 {
         int             bits;
-        struct DpRam *cardp = (struct DpRam *)virtAddr;
+        struct DpRam __iomem *cardp = (struct DpRam __iomem *)virtAddr;
 
         if ((Base < ONE_MEG) || (mode & BYTE_ACCESS_MODE))
                 bits = BYTE_OPERATION;
@@ -107,7 +107,7 @@ int RIOAssignAT(struct rio_info *p, int	Base, caddr_t	virtAddr, int mode)
         ** transient stuff.
         */
         p->RIOHosts[p->RIONumHosts].Caddr       = virtAddr;
-        p->RIOHosts[p->RIONumHosts].CardP       = (struct DpRam *)virtAddr;
+        p->RIOHosts[p->RIONumHosts].CardP       = virtAddr;
 
         /*
         ** Revision 01 AT host cards don't support WORD operations,
@@ -151,10 +151,10 @@ static	u8	val[] = {
 ** RAM test a board. 
 ** Nothing too complicated, just enough to check it out.
 */
-int RIOBoardTest(unsigned long paddr, caddr_t   caddr, unsigned char type, int slot)
+int RIOBoardTest(unsigned long paddr, void __iomem *caddr, unsigned char type, int slot)
 {
-        struct DpRam *DpRam = (struct DpRam *)caddr;
-        char *ram[4];
+        struct DpRam __iomem *DpRam = caddr;
+        void __iomem *ram[4];
         int  size[4];
         int  op, bank;
         int  nbanks;
@@ -179,12 +179,12 @@ int RIOBoardTest(unsigned long paddr, caddr_t	caddr, unsigned char type, int slo
         size[2] = DP_SRAM3_SIZE;
         size[3] = DP_SCRATCH_SIZE;
 
-        ram[0] = (char *)&DpRam->DpSram1[0];
-        ram[1] = (char *)&DpRam->DpSram2[0];
-        ram[2] = (char *)&DpRam->DpSram3[0];
+        ram[0] = DpRam->DpSram1;
+        ram[1] = DpRam->DpSram2;
+        ram[2] = DpRam->DpSram3;
         nbanks = (type == RIO_PCI) ? 3 : 4;
         if (nbanks == 4)
-                ram[3] = (char *)&DpRam->DpScratch[0];
+                ram[3] = DpRam->DpScratch;
 
 
         if (nbanks == 3) {
@@ -202,7 +202,7 @@ int RIOBoardTest(unsigned long paddr, caddr_t	caddr, unsigned char type, int slo
         */
         for (op=0; op<TEST_END; op++) {
                 for (bank=0; bank<nbanks; bank++) {
-                        if (RIOScrub(op, (u8 *)ram[bank], size[bank]) == RIO_FAIL) {
+                        if (RIOScrub(op, ram[bank], size[bank]) == RIO_FAIL) {
                                 rio_dprintk (RIO_DEBUG_INIT, "RIO-init: RIOScrub band %d, op %d failed\n", 
                                                         bank, op);
                                 return RIO_FAIL;
@@ -227,7 +227,7 @@ int RIOBoardTest(unsigned long paddr, caddr_t	caddr, unsigned char type, int slo
 ** to check that the data from the previous phase was retained.
 */
 
-static int RIOScrub(int op, u8 *ram, int size)
+static int RIOScrub(int op, u8 __iomem *ram, int size)
 {
         int off;
         unsigned char   oldbyte;
@@ -393,7 +393,7 @@ struct rioVersion *RIOVersid(void)
     return &stVersion;
 }
 
-void RIOHostReset(unsigned int Type, struct DpRam *DpRamP, unsigned int Slot)
+void RIOHostReset(unsigned int Type, struct DpRam __iomem *DpRamP, unsigned int Slot)
 {
         /*
         ** Reset the Tpu
diff --git a/drivers/char/rio/riointr.c b/drivers/char/rio/riointr.c
index 97f0fa550652..0bd09040a5c0 100644
--- a/drivers/char/rio/riointr.c
+++ b/drivers/char/rio/riointr.c
@@ -102,7 +102,7 @@ void RIOTxEnable(char *en)
         struct rio_info *p;
         struct tty_struct *tty;
         int c;
-        struct PKT *PacketP;
+        struct PKT __iomem *PacketP;
         unsigned long flags;
 
         PortP = (struct Port *) en;
@@ -144,7 +144,7 @@ void RIOTxEnable(char *en)
                 if (c == 0)
                         break;
 
-                rio_memcpy_toio(PortP->HostP->Caddr, (caddr_t) PacketP->data, PortP->gs.xmit_buf + PortP->gs.xmit_tail, c);
+                rio_memcpy_toio(PortP->HostP->Caddr, PacketP->data, PortP->gs.xmit_buf + PortP->gs.xmit_tail, c);
                 /*    udelay (1); */
 
                 writeb(c, &(PacketP->len));
@@ -219,7 +219,7 @@ void RIOServiceHost(struct rio_info *p, struct Host *HostP, int From)
                 for (port = p->RIOFirstPortsBooted; port < p->RIOLastPortsBooted + PORTS_PER_RTA; port++) {
                         struct Port *PortP = p->RIOPortp[port];
                         struct tty_struct *ttyP;
-                        struct PKT *PacketP;
+                        struct PKT __iomem *PacketP;
 
                         /*
                          ** not mapped in - most of the RIOPortp[] information
@@ -298,7 +298,7 @@ void RIOServiceHost(struct rio_info *p, struct Host *HostP, int From)
                 for (port = p->RIOFirstPortsBooted; port < p->RIOLastPortsBooted + PORTS_PER_RTA; port++) {
                         struct Port *PortP = p->RIOPortp[port];
                         struct tty_struct *ttyP;
-                        struct PKT *PacketP;
+                        struct PKT __iomem *PacketP;
 
                         /*
                          ** not mapped in - most of the RIOPortp[] information
@@ -427,13 +427,13 @@ void RIOServiceHost(struct rio_info *p, struct Host *HostP, int From)
 
                                 while (PortP->WflushFlag && can_add_transmit(&PacketP, PortP) && (PortP->InUse == NOT_INUSE)) {
                                         int p;
-                                        struct PktCmd *PktCmdP;
+                                        struct PktCmd __iomem *PktCmdP;
 
                                         rio_dprintk(RIO_DEBUG_INTR, "Add WFLUSH marker to data queue\n");
                                         /*
                                          ** make it look just like a WFLUSH command
                                          */
-                                        PktCmdP = (struct PktCmd *) &PacketP->data[0];
+                                        PktCmdP = (struct PktCmd __iomem *) &PacketP->data[0];
 
                                         writeb(WFLUSH, &PktCmdP->Command);
 
@@ -525,9 +525,9 @@ static void RIOReceive(struct rio_info *p, struct Port *PortP)
 {
         struct tty_struct *TtyP;
         unsigned short transCount;
-        struct PKT *PacketP;
+        struct PKT __iomem *PacketP;
         register unsigned int DataCnt;
-        unsigned char *ptr;
+        unsigned char __iomem *ptr;
         unsigned char *buf;
         int copied = 0;
 
@@ -546,7 +546,7 @@ static void RIOReceive(struct rio_info *p, struct Port *PortP)
          ** run out of space it will be set to the offset of the
          ** next byte to copy from the packet data area. The packet
          ** length field is decremented by the number of bytes that
-         ** we succesfully removed from the packet. When this reaches
+         ** we successfully removed from the packet. When this reaches
          ** zero, we reset the offset pointer to be zero, and free
          ** the packet from the front of the queue.
          */
@@ -585,19 +585,19 @@ static void RIOReceive(struct rio_info *p, struct Port *PortP)
                         /*
                          ** check that it is not a command!
                          */
-                        if (PacketP->len & PKT_CMD_BIT) {
+                        if (readb(&PacketP->len) & PKT_CMD_BIT) {
                                 rio_dprintk(RIO_DEBUG_INTR, "RIO: unexpected command packet received on PHB\n");
                                 /*      rio_dprint(RIO_DEBUG_INTR, (" sysport   = %d\n", p->RIOPortp->PortNum)); */
-                                rio_dprintk(RIO_DEBUG_INTR, " dest_unit = %d\n", PacketP->dest_unit);
-                                rio_dprintk(RIO_DEBUG_INTR, " dest_port = %d\n", PacketP->dest_port);
-                                rio_dprintk(RIO_DEBUG_INTR, " src_unit  = %d\n", PacketP->src_unit);
-                                rio_dprintk(RIO_DEBUG_INTR, " src_port  = %d\n", PacketP->src_port);
-                                rio_dprintk(RIO_DEBUG_INTR, " len          = %d\n", PacketP->len);
-                                rio_dprintk(RIO_DEBUG_INTR, " control   = %d\n", PacketP->control);
-                                rio_dprintk(RIO_DEBUG_INTR, " csum         = %d\n", PacketP->csum);
+                                rio_dprintk(RIO_DEBUG_INTR, " dest_unit = %d\n", readb(&PacketP->dest_unit));
+                                rio_dprintk(RIO_DEBUG_INTR, " dest_port = %d\n", readb(&PacketP->dest_port));
+                                rio_dprintk(RIO_DEBUG_INTR, " src_unit  = %d\n", readb(&PacketP->src_unit));
+                                rio_dprintk(RIO_DEBUG_INTR, " src_port  = %d\n", readb(&PacketP->src_port));
+                                rio_dprintk(RIO_DEBUG_INTR, " len          = %d\n", readb(&PacketP->len));
+                                rio_dprintk(RIO_DEBUG_INTR, " control   = %d\n", readb(&PacketP->control));
+                                rio_dprintk(RIO_DEBUG_INTR, " csum         = %d\n", readw(&PacketP->csum));
                                 rio_dprintk(RIO_DEBUG_INTR, "    data bytes: ");
                                 for (DataCnt = 0; DataCnt < PKT_MAX_DATA_LEN; DataCnt++)
-                                        rio_dprintk(RIO_DEBUG_INTR, "%d\n", PacketP->data[DataCnt]);
+                                        rio_dprintk(RIO_DEBUG_INTR, "%d\n", readb(&PacketP->data[DataCnt]));
                                 remove_receive(PortP);
                                 put_free_end(PortP->HostP, PacketP);
                                 continue;       /* with next packet */
@@ -618,24 +618,24 @@ static void RIOReceive(struct rio_info *p, struct Port *PortP)
                          ** and available space.
                          */
 
-                        transCount = tty_buffer_request_room(TtyP, PacketP->len & PKT_LEN_MASK);
+                        transCount = tty_buffer_request_room(TtyP, readb(&PacketP->len) & PKT_LEN_MASK);
                         rio_dprintk(RIO_DEBUG_REC, "port %d: Copy %d bytes\n", PortP->PortNum, transCount);
                         /*
                          ** To use the following 'kkprintfs' for debugging - change the '#undef'
                          ** to '#define', (this is the only place ___DEBUG_IT___ occurs in the
                          ** driver).
                          */
-                        ptr = (unsigned char *) PacketP->data + PortP->RxDataStart;
+                        ptr = (unsigned char __iomem *) PacketP->data + PortP->RxDataStart;
 
                         tty_prepare_flip_string(TtyP, &buf, transCount);
                         rio_memcpy_fromio(buf, ptr, transCount);
                         PortP->RxDataStart += transCount;
-                        PacketP->len -= transCount;
+                        writeb(readb(&PacketP->len)-transCount, &PacketP->len);
                         copied += transCount;
 
 
 
-                        if (PacketP->len == 0) {
+                        if (readb(&PacketP->len) == 0) {
                                 /*
                                  ** If we have emptied the packet, then we can
                                  ** free it, and reset the start pointer for
diff --git a/drivers/char/rio/rioparam.c b/drivers/char/rio/rioparam.c
index d2e8092cdb29..1066d9760704 100644
--- a/drivers/char/rio/rioparam.c
+++ b/drivers/char/rio/rioparam.c
@@ -154,8 +154,8 @@ int RIOParam(struct Port *PortP, int cmd, int Modem, int SleepFlag)
 {
         struct tty_struct *TtyP;
         int retval;
-        struct phb_param *phb_param_ptr;
-        struct PKT *PacketP;
+        struct phb_param __iomem *phb_param_ptr;
+        struct PKT __iomem *PacketP;
         int res;
         u8 Cor1 = 0, Cor2 = 0, Cor4 = 0, Cor5 = 0;
         u8 TxXon = 0, TxXoff = 0, RxXon = 0, RxXoff = 0;
@@ -235,7 +235,7 @@ int RIOParam(struct Port *PortP, int cmd, int Modem, int SleepFlag)
         rio_dprintk(RIO_DEBUG_PARAM, "can_add_transmit() returns %x\n", res);
         rio_dprintk(RIO_DEBUG_PARAM, "Packet is %p\n", PacketP);
 
-        phb_param_ptr = (struct phb_param *) PacketP->data;
+        phb_param_ptr = (struct phb_param __iomem *) PacketP->data;
 
 
         switch (TtyP->termios->c_cflag & CSIZE) {
@@ -580,11 +580,11 @@ int RIOParam(struct Port *PortP, int cmd, int Modem, int SleepFlag)
 ** We can add another packet to a transmit queue if the packet pointer pointed
 ** to by the TxAdd pointer has PKT_IN_USE clear in its address.
 */
-int can_add_transmit(struct PKT **PktP, struct Port *PortP)
+int can_add_transmit(struct PKT __iomem **PktP, struct Port *PortP)
 {
-        struct PKT *tp;
+        struct PKT __iomem *tp;
 
-        *PktP = tp = (struct PKT *) RIO_PTR(PortP->Caddr, readw(PortP->TxAdd));
+        *PktP = tp = (struct PKT __iomem *) RIO_PTR(PortP->Caddr, readw(PortP->TxAdd));
 
         return !((unsigned long) tp & PKT_IN_USE);
 }
@@ -608,9 +608,9 @@ void add_transmit(struct Port *PortP)
  * Put a packet onto the end of the
  * free list
  ****************************************/
-void put_free_end(struct Host *HostP, struct PKT *PktP)
+void put_free_end(struct Host *HostP, struct PKT __iomem *PktP)
 {
-        struct rio_free_list *tmp_pointer;
+        struct rio_free_list __iomem *tmp_pointer;
         unsigned short old_end, new_end;
         unsigned long flags;
 
@@ -625,15 +625,15 @@ void put_free_end(struct Host *HostP, struct PKT *PktP)
 
         if ((old_end = readw(&HostP->ParmMapP->free_list_end)) != TPNULL) {
                 new_end = RIO_OFF(HostP->Caddr, PktP);
-                tmp_pointer = (struct rio_free_list *) RIO_PTR(HostP->Caddr, old_end);
+                tmp_pointer = (struct rio_free_list __iomem *) RIO_PTR(HostP->Caddr, old_end);
                 writew(new_end, &tmp_pointer->next);
-                writew(old_end, &((struct rio_free_list *) PktP)->prev);
-                writew(TPNULL, &((struct rio_free_list *) PktP)->next);
+                writew(old_end, &((struct rio_free_list __iomem *) PktP)->prev);
+                writew(TPNULL, &((struct rio_free_list __iomem *) PktP)->next);
                 writew(new_end, &HostP->ParmMapP->free_list_end);
         } else {                /* First packet on the free list this should never happen! */
                 rio_dprintk(RIO_DEBUG_PFE, "put_free_end(): This should never happen\n");
                 writew(RIO_OFF(HostP->Caddr, PktP), &HostP->ParmMapP->free_list_end);
-                tmp_pointer = (struct rio_free_list *) PktP;
+                tmp_pointer = (struct rio_free_list __iomem *) PktP;
                 writew(TPNULL, &tmp_pointer->prev);
                 writew(TPNULL, &tmp_pointer->next);
         }
@@ -647,10 +647,10 @@ void put_free_end(struct Host *HostP, struct PKT *PktP)
 ** relevant packet, [having cleared the PKT_IN_USE bit]. If PKT_IN_USE is clear,
 ** then can_remove_receive() returns 0.
 */
-int can_remove_receive(struct PKT **PktP, struct Port *PortP)
+int can_remove_receive(struct PKT __iomem **PktP, struct Port *PortP)
 {
         if (readw(PortP->RxRemove) & PKT_IN_USE) {
-                *PktP = (struct PKT *) RIO_PTR(PortP->Caddr, readw(PortP->RxRemove) & ~PKT_IN_USE);
+                *PktP = (struct PKT __iomem *) RIO_PTR(PortP->Caddr, readw(PortP->RxRemove) & ~PKT_IN_USE);
                 return 1;
         }
         return 0;
diff --git a/drivers/char/rio/rioroute.c b/drivers/char/rio/rioroute.c
index 357085337942..a99f3d9d7d65 100644
--- a/drivers/char/rio/rioroute.c
+++ b/drivers/char/rio/rioroute.c
@@ -86,9 +86,9 @@ static void RIOConCon(struct rio_info *, struct Host *, unsigned int, unsigned i
 ** Incoming on the ROUTE_RUP
 ** I wrote this while I was tired. Forgive me.
 */
-int RIORouteRup(struct rio_info *p, unsigned int Rup, struct Host *HostP, struct PKT * PacketP)
+int RIORouteRup(struct rio_info *p, unsigned int Rup, struct Host *HostP, struct PKT __iomem * PacketP)
 {
-        struct PktCmd *PktCmdP = (struct PktCmd *) PacketP->data;
+        struct PktCmd __iomem *PktCmdP = (struct PktCmd __iomem *) PacketP->data;
         struct PktCmd_M *PktReplyP;
         struct CmdBlk *CmdBlkP;
         struct Port *PortP;
@@ -307,7 +307,7 @@ int RIORouteRup(struct rio_info *p, unsigned int Rup, struct Host *HostP, struct
         if (!RIOBootOk(p, HostP, RtaUniq)) {
                 rio_dprintk(RIO_DEBUG_ROUTE, "RTA %x tried to get an ID, but does not belong - FOAD it!\n", RtaUniq);
                 PktReplyP->Command = ROUTE_FOAD;
-                HostP->Copy("RT_FOAD", PktReplyP->CommandText, 7);
+                memcpy(PktReplyP->CommandText, "RT_FOAD", 7);
                 RIOQueueCmdBlk(HostP, Rup, CmdBlkP);
                 return 1;
         }
@@ -341,7 +341,7 @@ int RIORouteRup(struct rio_info *p, unsigned int Rup, struct Host *HostP, struct
                                         HostP->Mapping[ThisUnit].Flags |= MSG_DONE;
                                 }
                                 PktReplyP->Command = ROUTE_FOAD;
-                                HostP->Copy("RT_FOAD", PktReplyP->CommandText, 7);
+                                memcpy(PktReplyP->CommandText, "RT_FOAD", 7);
                                 RIOQueueCmdBlk(HostP, Rup, CmdBlkP);
                                 return 1;
                         }
@@ -367,7 +367,7 @@ int RIORouteRup(struct rio_info *p, unsigned int Rup, struct Host *HostP, struct
                                 PktReplyP->IDNum2 = ROUTE_NO_ID;
                                 rio_dprintk(RIO_DEBUG_ROUTE, "RTA '%s' has been allocated ID %d\n", HostP->Mapping[ThisUnit].Name, PktReplyP->IDNum);
                         }
-                        HostP->Copy("RT_ALLOCAT", PktReplyP->CommandText, 10);
+                        memcpy(PktReplyP->CommandText, "RT_ALLOCAT", 10);
 
                         RIOQueueCmdBlk(HostP, Rup, CmdBlkP);
 
@@ -469,7 +469,7 @@ int RIORouteRup(struct rio_info *p, unsigned int Rup, struct Host *HostP, struct
                 }
 
                 PktReplyP->Command = ROUTE_FOAD;
-                HostP->Copy("RT_FOAD", PktReplyP->CommandText, 7);
+                memcpy(PktReplyP->CommandText, "RT_FOAD", 7);
         } else {
                 /*
                  ** we did boot it (as an extra), and there may now be a table
@@ -489,7 +489,7 @@ int RIORouteRup(struct rio_info *p, unsigned int Rup, struct Host *HostP, struct
                         }
                 }
                 PktReplyP->Command = ROUTE_USED;
-                HostP->Copy("RT_USED", PktReplyP->CommandText, 7);
+                memcpy(PktReplyP->CommandText, "RT_USED", 7);
         }
         RIOQueueCmdBlk(HostP, Rup, CmdBlkP);
         return 1;
@@ -517,8 +517,8 @@ void RIOFixPhbs(struct rio_info *p, struct Host *HostP, unsigned int unit)
 
                 for (port = 0; port < PORTS_PER_RTA; port++, PortN++) {
                         unsigned short dest_port = port + 8;
-                        u16 *TxPktP;
-                        struct PKT *Pkt;
+                        u16 __iomem *TxPktP;
+                        struct PKT __iomem *Pkt;
 
                         PortP = p->RIOPortp[PortN];
 
@@ -555,12 +555,12 @@ void RIOFixPhbs(struct rio_info *p, struct Host *HostP, unsigned int unit)
                                  ** card. This needs to be translated into a 32 bit pointer
                                  ** so it can be accessed from the driver.
                                  */
-                                Pkt = (struct PKT *) RIO_PTR(HostP->Caddr, readw(TxPktP));
+                                Pkt = (struct PKT __iomem *) RIO_PTR(HostP->Caddr, readw(TxPktP));
 
                                 /*
                                  ** If the packet is used, reset it.
                                  */
-                                Pkt = (struct PKT *) ((unsigned long) Pkt & ~PKT_IN_USE);
+                                Pkt = (struct PKT __iomem *) ((unsigned long) Pkt & ~PKT_IN_USE);
                                 writeb(dest_unit, &Pkt->dest_unit);
                                 writeb(dest_port, &Pkt->dest_port);
                         }
diff --git a/drivers/char/rio/riotable.c b/drivers/char/rio/riotable.c
index d3abe0d37d64..7e988357326e 100644
--- a/drivers/char/rio/riotable.c
+++ b/drivers/char/rio/riotable.c
@@ -534,8 +534,8 @@ int RIODeleteRta(struct rio_info *p, struct Map *MapP)
                                                 if (PortP->SecondBlock) {
                                                         u16 dest_unit = HostMapP->ID;
                                                         u16 dest_port = port - SysPort;
-                                                        u16 *TxPktP;
-                                                        struct PKT *Pkt;
+                                                        u16 __iomem *TxPktP;
+                                                        struct PKT __iomem *Pkt;
 
                                                         for (TxPktP = PortP->TxStart; TxPktP <= PortP->TxEnd; TxPktP++) {
                                                                 /*
@@ -545,12 +545,12 @@ int RIODeleteRta(struct rio_info *p, struct Map *MapP)
                                                                  ** a 32 bit pointer so it can be
                                                                  ** accessed from the driver.
                                                                  */
-                                                                Pkt = (struct PKT *) RIO_PTR(HostP->Caddr, readw(&*TxPktP));
-                                                                rio_dprintk(RIO_DEBUG_TABLE, "Tx packet (%x) destination: Old %x:%x New %x:%x\n", *TxPktP, Pkt->dest_unit, Pkt->dest_port, dest_unit, dest_port);
+                                                                Pkt = (struct PKT __iomem *) RIO_PTR(HostP->Caddr, readw(&*TxPktP));
+                                                                rio_dprintk(RIO_DEBUG_TABLE, "Tx packet (%x) destination: Old %x:%x New %x:%x\n", readw(TxPktP), readb(&Pkt->dest_unit), readb(&Pkt->dest_port), dest_unit, dest_port);
                                                                 writew(dest_unit, &Pkt->dest_unit);
                                                                 writew(dest_port, &Pkt->dest_port);
                                                         }
-                                                        rio_dprintk(RIO_DEBUG_TABLE, "Port %d phb destination: Old %x:%x New %x:%x\n", port, PortP->PhbP->destination & 0xff, (PortP->PhbP->destination >> 8) & 0xff, dest_unit, dest_port);
+                                                        rio_dprintk(RIO_DEBUG_TABLE, "Port %d phb destination: Old %x:%x New %x:%x\n", port, readb(&PortP->PhbP->destination) & 0xff, (readb(&PortP->PhbP->destination) >> 8) & 0xff, dest_unit, dest_port);
                                                         writew(dest_unit + (dest_port << 8), &PortP->PhbP->destination);
                                                 }
                                                 rio_spin_unlock_irqrestore(&PortP->portSem, sem_flags);
@@ -781,13 +781,13 @@ int RIOReMapPorts(struct rio_info *p, struct Host *HostP, struct Map *HostMapP)
                  ** unless the host has been booted
                  */
                 if ((HostP->Flags & RUN_STATE) == RC_RUNNING) {
-                        struct PHB *PhbP = PortP->PhbP = &HostP->PhbP[HostPort];
-                        PortP->TxAdd = (u16 *) RIO_PTR(HostP->Caddr, readw(&PhbP->tx_add));
-                        PortP->TxStart = (u16 *) RIO_PTR(HostP->Caddr, readw(&PhbP->tx_start));
-                        PortP->TxEnd = (u16 *) RIO_PTR(HostP->Caddr, readw(&PhbP->tx_end));
-                        PortP->RxRemove = (u16 *) RIO_PTR(HostP->Caddr, readw(&PhbP->rx_remove));
-                        PortP->RxStart = (u16 *) RIO_PTR(HostP->Caddr, readw(&PhbP->rx_start));
-                        PortP->RxEnd = (u16 *) RIO_PTR(HostP->Caddr, readw(&PhbP->rx_end));
+                        struct PHB __iomem *PhbP = PortP->PhbP = &HostP->PhbP[HostPort];
+                        PortP->TxAdd = (u16 __iomem *) RIO_PTR(HostP->Caddr, readw(&PhbP->tx_add));
+                        PortP->TxStart = (u16 __iomem *) RIO_PTR(HostP->Caddr, readw(&PhbP->tx_start));
+                        PortP->TxEnd = (u16 __iomem *) RIO_PTR(HostP->Caddr, readw(&PhbP->tx_end));
+                        PortP->RxRemove = (u16 __iomem *) RIO_PTR(HostP->Caddr, readw(&PhbP->rx_remove));
+                        PortP->RxStart = (u16 __iomem *) RIO_PTR(HostP->Caddr, readw(&PhbP->rx_start));
+                        PortP->RxEnd = (u16 __iomem *) RIO_PTR(HostP->Caddr, readw(&PhbP->rx_end));
                 } else
                         PortP->PhbP = NULL;
 
diff --git a/drivers/char/rio/riotty.c b/drivers/char/rio/riotty.c
index 204267613c9c..a4f0b1e3e7fa 100644
--- a/drivers/char/rio/riotty.c
+++ b/drivers/char/rio/riotty.c
@@ -576,7 +576,7 @@ static void RIOClearUp(struct Port *PortP)
 */
 int RIOShortCommand(struct rio_info *p, struct Port *PortP, int command, int len, int arg)
 {
-        struct PKT *PacketP;
+        struct PKT __iomem *PacketP;
         int retries = 20;       /* at 10 per second -> 2 seconds */
         unsigned long flags;
 
diff --git a/drivers/char/rio/unixrup.h b/drivers/char/rio/unixrup.h
index 4306e01dbf01..46bd532f7746 100644
--- a/drivers/char/rio/unixrup.h
+++ b/drivers/char/rio/unixrup.h
@@ -44,7 +44,7 @@ static char *_unixrup_h_sccs_ = "@(#)unixrup.h	1.2";
 struct UnixRup {
         struct CmdBlk *CmdsWaitingP;    /* Commands waiting to be done */
         struct CmdBlk *CmdPendingP;     /* The command currently being sent */
-        struct RUP *RupP;       /* the Rup to send it to */
+        struct RUP __iomem *RupP;       /* the Rup to send it to */
         unsigned int Id;                /* Id number */
         unsigned int BaseSysPort;       /* SysPort of first tty on this RTA */
         unsigned int ModTypes;          /* Modules on this RTA */
diff --git a/drivers/char/rocket.c b/drivers/char/rocket.c
index 7edc6a4dbdc4..0708c5164c83 100644
--- a/drivers/char/rocket.c
+++ b/drivers/char/rocket.c
@@ -324,35 +324,15 @@ static void rp_do_receive(struct r_port *info,
                           CHANNEL_t * cp, unsigned int ChanStatus)
 {
         unsigned int CharNStat;
-        int ToRecv, wRecv, space = 0, count;
-        unsigned char *cbuf, *chead;
-        char *fbuf, *fhead;
-        struct tty_ldisc *ld;
-
-        ld = tty_ldisc_ref(tty);
+        int ToRecv, wRecv, space;
+        unsigned char *cbuf;
 
         ToRecv = sGetRxCnt(cp);
-        space = tty->receive_room;
-        if (space > 2 * TTY_FLIPBUF_SIZE)
-                space = 2 * TTY_FLIPBUF_SIZE;
-        count = 0;
 #ifdef ROCKET_DEBUG_INTR
-        printk(KERN_INFO "rp_do_receive(%d, %d)...", ToRecv, space);
+        printk(KERN_INFO "rp_do_receive(%d)...", ToRecv);
 #endif
-
-        /*
-         * determine how many we can actually read in.  If we can't
-         * read any in then we have a software overrun condition.
-         */
-        if (ToRecv > space)
-                ToRecv = space;
-
-        ToRecv = tty_prepare_flip_string_flags(tty, &chead, &fhead, ToRecv);
-        if (ToRecv <= 0)
-                goto done;
-
-        cbuf = chead;
-        fbuf = fhead;
+        if (ToRecv == 0)
+                return;
 
         /*
          * if status indicates there are errored characters in the
@@ -380,6 +360,8 @@ static void rp_do_receive(struct r_port *info,
                        info->read_status_mask);
 #endif
                 while (ToRecv) {
+                        char flag;
+
                         CharNStat = sInW(sGetTxRxDataIO(cp));
 #ifdef ROCKET_DEBUG_RECEIVE
                         printk(KERN_INFO "%x...", CharNStat);
@@ -392,17 +374,16 @@ static void rp_do_receive(struct r_port *info,
                         }
                         CharNStat &= info->read_status_mask;
                         if (CharNStat & STMBREAKH)
-                                *fbuf++ = TTY_BREAK;
+                                flag = TTY_BREAK;
                         else if (CharNStat & STMPARITYH)
-                                *fbuf++ = TTY_PARITY;
+                                flag = TTY_PARITY;
                         else if (CharNStat & STMFRAMEH)
-                                *fbuf++ = TTY_FRAME;
+                                flag = TTY_FRAME;
                         else if (CharNStat & STMRCVROVRH)
-                                *fbuf++ = TTY_OVERRUN;
+                                flag = TTY_OVERRUN;
                         else
-                                *fbuf++ = TTY_NORMAL;
-                        *cbuf++ = CharNStat & 0xff;
-                        count++;
+                                flag = TTY_NORMAL;
+                        tty_insert_flip_char(tty, CharNStat & 0xff, flag);
                         ToRecv--;
                 }
 
@@ -422,20 +403,23 @@ static void rp_do_receive(struct r_port *info,
                  * characters at time by doing repeated word IO
                  * transfer.
                  */
+                space = tty_prepare_flip_string(tty, &cbuf, ToRecv);
+                if (space < ToRecv) {
+#ifdef ROCKET_DEBUG_RECEIVE
+                        printk(KERN_INFO "rp_do_receive:insufficient space ToRecv=%d space=%d\n", ToRecv, space);
+#endif
+                        if (space <= 0)
+                                return;
+                        ToRecv = space;
+                }
                 wRecv = ToRecv >> 1;
                 if (wRecv)
                         sInStrW(sGetTxRxDataIO(cp), (unsigned short *) cbuf, wRecv);
                 if (ToRecv & 1)
                         cbuf[ToRecv - 1] = sInB(sGetTxRxDataIO(cp));
-                memset(fbuf, TTY_NORMAL, ToRecv);
-                cbuf += ToRecv;
-                fbuf += ToRecv;
-                count += ToRecv;
         }
         /*  Push the data up to the tty layer */
-        ld->receive_buf(tty, chead, fhead, count);
-done:
-        tty_ldisc_deref(ld);
+        tty_flip_buffer_push(tty);
 }
 
 /*
diff --git a/drivers/char/rtc.c b/drivers/char/rtc.c
index 7cac6d05d723..0897b0c8d528 100644
--- a/drivers/char/rtc.c
+++ b/drivers/char/rtc.c
@@ -928,7 +928,7 @@ static int __init rtc_init(void)
 #ifdef __sparc__
         for_each_ebus(ebus) {
                 for_each_ebusdev(edev, ebus) {
-                        if(strcmp(edev->prom_name, "rtc") == 0) {
+                        if(strcmp(edev->prom_node->name, "rtc") == 0) {
                                 rtc_port = edev->resource[0].start;
                                 rtc_irq = edev->irqs[0];
                                 goto found;
@@ -938,7 +938,7 @@ static int __init rtc_init(void)
 #ifdef __sparc_v9__
         for_each_isa(isa_br) {
                 for_each_isadev(isa_dev, isa_br) {
-                        if (strcmp(isa_dev->prom_name, "rtc") == 0) {
+                        if (strcmp(isa_dev->prom_node->name, "rtc") == 0) {
                                 rtc_port = isa_dev->resource.start;
                                 rtc_irq = isa_dev->irq;
                                 goto found;
@@ -960,10 +960,6 @@ found:
          * PCI Slot 2 INTA# (and some INTx# in Slot 1).
          */
         if (request_irq(rtc_irq, rtc_interrupt, SA_SHIRQ, "rtc", (void *)&rtc_port)) {
-                /*
-                 * Standard way for sparc to print irq's is to use
-                 * __irq_itoa(). I think for EBus it's ok to use %d.
-                 */
                 printk(KERN_ERR "rtc: cannot register IRQ %d\n", rtc_irq);
                 return -EIO;
         }
diff --git a/drivers/char/scx200_gpio.c b/drivers/char/scx200_gpio.c
index 664a6e97eb1a..5a280a330401 100644
--- a/drivers/char/scx200_gpio.c
+++ b/drivers/char/scx200_gpio.c
@@ -1,4 +1,4 @@
-/* linux/drivers/char/scx200_gpio.c 
+/* linux/drivers/char/scx200_gpio.c
 
    National Semiconductor SCx200 GPIO driver.  Allows a user space
    process to play with the GPIO pins.
@@ -6,17 +6,26 @@
    Copyright (c) 2001,2002 Christer Weinigel <wingel@nano-system.com> */
 
 #include <linux/config.h>
+#include <linux/device.h>
 #include <linux/fs.h>
 #include <linux/module.h>
 #include <linux/errno.h>
 #include <linux/kernel.h>
 #include <linux/init.h>
+#include <linux/platform_device.h>
 #include <asm/uaccess.h>
 #include <asm/io.h>
 
+#include <linux/types.h>
+#include <linux/cdev.h>
+
 #include <linux/scx200_gpio.h>
+#include <linux/nsc_gpio.h>
 
 #define NAME "scx200_gpio"
+#define DEVNAME NAME
+
+static struct platform_device *pdev;
 
 MODULE_AUTHOR("Christer Weinigel <wingel@nano-system.com>");
 MODULE_DESCRIPTION("NatSemi SCx200 GPIO Pin Driver");
@@ -26,70 +35,23 @@ static int major = 0;		/* default to dynamic major */
 module_param(major, int, 0);
 MODULE_PARM_DESC(major, "Major device number");
 
-static ssize_t scx200_gpio_write(struct file *file, const char __user *data, 
-                                 size_t len, loff_t *ppos)
-{
-        unsigned m = iminor(file->f_dentry->d_inode);
-        size_t i;
-
-        for (i = 0; i < len; ++i) {
-                char c;
-                if (get_user(c, data+i))
-                        return -EFAULT;
-                switch (c)
-                {
-                case '0': 
-                        scx200_gpio_set(m, 0); 
-                        break;
-                case '1': 
-                        scx200_gpio_set(m, 1); 
-                        break;
-                case 'O':
-                        printk(KERN_INFO NAME ": GPIO%d output enabled\n", m);
-                        scx200_gpio_configure(m, ~1, 1);
-                        break;
-                case 'o':
-                        printk(KERN_INFO NAME ": GPIO%d output disabled\n", m);
-                        scx200_gpio_configure(m, ~1, 0);
-                        break;
-                case 'T':
-                        printk(KERN_INFO NAME ": GPIO%d output is push pull\n", m);
-                        scx200_gpio_configure(m, ~2, 2);
-                        break;
-                case 't':
-                        printk(KERN_INFO NAME ": GPIO%d output is open drain\n", m);
-                        scx200_gpio_configure(m, ~2, 0);
-                        break;
-                case 'P':
-                        printk(KERN_INFO NAME ": GPIO%d pull up enabled\n", m);
-                        scx200_gpio_configure(m, ~4, 4);
-                        break;
-                case 'p':
-                        printk(KERN_INFO NAME ": GPIO%d pull up disabled\n", m);
-                        scx200_gpio_configure(m, ~4, 0);
-                        break;
-                }
-        }
-
-        return len;
-}
-
-static ssize_t scx200_gpio_read(struct file *file, char __user *buf,
-                                size_t len, loff_t *ppos)
-{
-        unsigned m = iminor(file->f_dentry->d_inode);
-        int value;
-
-        value = scx200_gpio_get(m);
-        if (put_user(value ? '1' : '0', buf))
-                return -EFAULT;
-        
-        return 1;
-}
+struct nsc_gpio_ops scx200_access = {
+        .owner          = THIS_MODULE,
+        .gpio_config    = scx200_gpio_configure,
+        .gpio_dump      = nsc_gpio_dump,
+        .gpio_get       = scx200_gpio_get,
+        .gpio_set       = scx200_gpio_set,
+        .gpio_set_high  = scx200_gpio_set_high,
+        .gpio_set_low   = scx200_gpio_set_low,
+        .gpio_change    = scx200_gpio_change,
+        .gpio_current   = scx200_gpio_current
+};
 
 static int scx200_gpio_open(struct inode *inode, struct file *file)
 {
         unsigned m = iminor(inode);
+        file->private_data = &scx200_access;
+
         if (m > 63)
                 return -EINVAL;
         return nonseekable_open(inode, file);
@@ -103,47 +65,81 @@ static int scx200_gpio_release(struct inode *inode, struct file *file)
 
 static struct file_operations scx200_gpio_fops = {
         .owner   = THIS_MODULE,
-        .write   = scx200_gpio_write,
-        .read    = scx200_gpio_read,
+        .write   = nsc_gpio_write,
+        .read    = nsc_gpio_read,
         .open    = scx200_gpio_open,
         .release = scx200_gpio_release,
 };
 
+struct cdev *scx200_devices;
+static int num_pins = 32;
+
 static int __init scx200_gpio_init(void)
 {
-        int r;
-
-        printk(KERN_DEBUG NAME ": NatSemi SCx200 GPIO Driver\n");
+        int rc, i;
+        dev_t dev = MKDEV(major, 0);
 
         if (!scx200_gpio_present()) {
-                printk(KERN_ERR NAME ": no SCx200 gpio pins available\n");
+                printk(KERN_ERR NAME ": no SCx200 gpio present\n");
                 return -ENODEV;
         }
 
-        r = register_chrdev(major, NAME, &scx200_gpio_fops);
-        if (r < 0) {
-                printk(KERN_ERR NAME ": unable to register character device\n");
-                return r;
+        /* support dev_dbg() with pdev->dev */
+        pdev = platform_device_alloc(DEVNAME, 0);
+        if (!pdev)
+                return -ENOMEM;
+
+        rc = platform_device_add(pdev);
+        if (rc)
+                goto undo_malloc;
+
+        /* nsc_gpio uses dev_dbg(), so needs this */
+        scx200_access.dev = &pdev->dev;
+
+        if (major)
+                rc = register_chrdev_region(dev, num_pins, "scx200_gpio");
+        else {
+                rc = alloc_chrdev_region(&dev, 0, num_pins, "scx200_gpio");
+                major = MAJOR(dev);
         }
-        if (!major) {
-                major = r;
-                printk(KERN_DEBUG NAME ": got dynamic major %d\n", major);
+        if (rc < 0) {
+                dev_err(&pdev->dev, "SCx200 chrdev_region err: %d\n", rc);
+                goto undo_platform_device_add;
+        }
+        scx200_devices = kzalloc(num_pins * sizeof(struct cdev), GFP_KERNEL);
+        if (!scx200_devices) {
+                rc = -ENOMEM;
+                goto undo_chrdev_region;
+        }
+        for (i = 0; i < num_pins; i++) {
+                struct cdev *cdev = &scx200_devices[i];
+                cdev_init(cdev, &scx200_gpio_fops);
+                cdev->owner = THIS_MODULE;
+                rc = cdev_add(cdev, MKDEV(major, i), 1);
+                /* tolerate 'minor' errors */
+                if (rc)
+                        dev_err(&pdev->dev, "Error %d on minor %d", rc, i);
         }
 
-        return 0;
+        return 0; /* succeed */
+
+undo_chrdev_region:
+        unregister_chrdev_region(dev, num_pins);
+undo_platform_device_add:
+        platform_device_put(pdev);
+undo_malloc:
+        kfree(pdev);
+        return rc;
 }
 
 static void __exit scx200_gpio_cleanup(void)
 {
-        unregister_chrdev(major, NAME);
+        kfree(scx200_devices);
+        unregister_chrdev_region(MKDEV(major, 0), num_pins);
+        platform_device_put(pdev);
+        platform_device_unregister(pdev);
+        /* kfree(pdev); */
 }
 
 module_init(scx200_gpio_init);
 module_exit(scx200_gpio_cleanup);
-
-/*
-    Local variables:
-        compile-command: "make -k -C ../.. SUBDIRS=drivers/char modules"
-        c-basic-offset: 8
-    End:
-*/
diff --git a/drivers/char/sonypi.c b/drivers/char/sonypi.c
index a90f5d97df35..43dfd8689dce 100644
--- a/drivers/char/sonypi.c
+++ b/drivers/char/sonypi.c
@@ -512,7 +512,7 @@ static struct sonypi_device {
 
 #ifdef CONFIG_ACPI
 static struct acpi_device *sonypi_acpi_device;
-static int acpi_enabled;
+static int acpi_driver_registered;
 #endif
 
 static int sonypi_ec_write(u8 addr, u8 value)
@@ -869,7 +869,7 @@ found:
                 sonypi_report_input_event(event);
 
 #ifdef CONFIG_ACPI
-        if (acpi_enabled)
+        if (sonypi_acpi_device)
                 acpi_bus_generate_event(sonypi_acpi_device, 1, event);
 #endif
 
@@ -1551,8 +1551,8 @@ static int __init sonypi_init(void)
                 goto err_free_device;
 
 #ifdef CONFIG_ACPI
-        if (acpi_bus_register_driver(&sonypi_acpi_driver) > 0)
-                acpi_enabled = 1;
+        if (acpi_bus_register_driver(&sonypi_acpi_driver) >= 0)
+                acpi_driver_registered = 1;
 #endif
 
         return 0;
@@ -1567,7 +1567,7 @@ static int __init sonypi_init(void)
 static void __exit sonypi_exit(void)
 {
 #ifdef CONFIG_ACPI
-        if (acpi_enabled)
+        if (acpi_driver_registered)
                 acpi_bus_unregister_driver(&sonypi_acpi_driver);
 #endif
         platform_device_unregister(sonypi_platform_device);
diff --git a/drivers/char/specialix.c b/drivers/char/specialix.c
index 5343e9fc6ab7..d2d6b01dcd05 100644
--- a/drivers/char/specialix.c
+++ b/drivers/char/specialix.c
@@ -1683,7 +1683,7 @@ static int sx_write(struct tty_struct * tty,
 
         bp = port_Board(port);
 
-        if (!tty || !port->xmit_buf || !tmp_buf) {
+        if (!port->xmit_buf || !tmp_buf) {
                 func_exit();
                 return 0;
         }
@@ -1733,7 +1733,7 @@ static void sx_put_char(struct tty_struct * tty, unsigned char ch)
                 return;
         }
         dprintk (SX_DEBUG_TX, "check tty: %p %p\n", tty, port->xmit_buf);
-        if (!tty || !port->xmit_buf) {
+        if (!port->xmit_buf) {
                 func_exit();
                 return;
         }
@@ -2477,7 +2477,7 @@ static int __init specialix_init(void)
 #endif
 
         for (i = 0; i < SX_NBOARD; i++)
-                sx_board[i].lock = SPIN_LOCK_UNLOCKED;
+                spin_lock_init(&sx_board[i].lock);
 
         if (sx_init_drivers()) {
                 func_exit();
diff --git a/drivers/char/stallion.c b/drivers/char/stallion.c
index a9c5a7230f89..00b4a2187164 100644
--- a/drivers/char/stallion.c
+++ b/drivers/char/stallion.c
@@ -141,15 +141,6 @@ static char	*stl_drvversion = "5.6.0";
 static struct tty_driver        *stl_serial;
 
 /*
- *      We will need to allocate a temporary write buffer for chars that
- *      come direct from user space. The problem is that a copy from user
- *      space might cause a page fault (typically on a system that is
- *      swapping!). All ports will share one buffer - since if the system
- *      is already swapping a shared buffer won't make things any worse.
- */
-static char                     *stl_tmpwritebuf;
-
-/*
  *      Define a local default termios struct. All ports will be created
  *      with this termios initially. Basically all it defines is a raw port
  *      at 9600, 8 data bits, 1 stop bit.
@@ -363,6 +354,14 @@ static unsigned char	stl_vecmap[] = {
 };
 
 /*
+ *      Lock ordering is that you may not take stallion_lock holding
+ *      brd_lock.
+ */
+
+static spinlock_t brd_lock;             /* Guard the board mapping */
+static spinlock_t stallion_lock;        /* Guard the tty driver */
+
+/*
  *      Set up enable and disable macros for the ECH boards. They require
  *      the secondary io address space to be activated and deactivated.
  *      This way all ECH boards can share their secondary io region.
@@ -725,17 +724,7 @@ static struct class *stallion_class;
 
 static int __init stallion_module_init(void)
 {
-        unsigned long   flags;
-
-#ifdef DEBUG
-        printk("init_module()\n");
-#endif
-
-        save_flags(flags);
-        cli();
         stl_init();
-        restore_flags(flags);
-
         return 0;
 }
 
@@ -746,7 +735,6 @@ static void __exit stallion_module_exit(void)
         stlbrd_t        *brdp;
         stlpanel_t      *panelp;
         stlport_t       *portp;
-        unsigned long   flags;
         int             i, j, k;
 
 #ifdef DEBUG
@@ -756,9 +744,6 @@ static void __exit stallion_module_exit(void)
         printk(KERN_INFO "Unloading %s: version %s\n", stl_drvtitle,
                 stl_drvversion);
 
-        save_flags(flags);
-        cli();
-
 /*
  *      Free up all allocated resources used by the ports. This includes
  *      memory and interrupts. As part of this process we will also do
@@ -770,7 +755,6 @@ static void __exit stallion_module_exit(void)
         if (i) {
                 printk("STALLION: failed to un-register tty driver, "
                         "errno=%d\n", -i);
-                restore_flags(flags);
                 return;
         }
         for (i = 0; i < 4; i++) {
@@ -783,8 +767,6 @@ static void __exit stallion_module_exit(void)
                         "errno=%d\n", -i);
         class_destroy(stallion_class);
 
-        kfree(stl_tmpwritebuf);
-
         for (i = 0; (i < stl_nrbrds); i++) {
                 if ((brdp = stl_brds[i]) == (stlbrd_t *) NULL)
                         continue;
@@ -814,8 +796,6 @@ static void __exit stallion_module_exit(void)
                 kfree(brdp);
                 stl_brds[i] = (stlbrd_t *) NULL;
         }
-
-        restore_flags(flags);
 }
 
 module_init(stallion_module_init);
@@ -948,7 +928,7 @@ static stlbrd_t *stl_allocbrd(void)
 
         brdp = kzalloc(sizeof(stlbrd_t), GFP_KERNEL);
         if (!brdp) {
-                printk("STALLION: failed to allocate memory (size=%d)\n",
+                printk("STALLION: failed to allocate memory (size=%Zd)\n",
                         sizeof(stlbrd_t));
                 return NULL;
         }
@@ -1066,16 +1046,17 @@ static int stl_waitcarrier(stlport_t *portp, struct file *filp)
         rc = 0;
         doclocal = 0;
 
+        spin_lock_irqsave(&stallion_lock, flags);
+
         if (portp->tty->termios->c_cflag & CLOCAL)
                 doclocal++;
 
-        save_flags(flags);
-        cli();
         portp->openwaitcnt++;
         if (! tty_hung_up_p(filp))
                 portp->refcount--;
 
         for (;;) {
+                /* Takes brd_lock internally */
                 stl_setsignals(portp, 1, 1);
                 if (tty_hung_up_p(filp) ||
                     ((portp->flags & ASYNC_INITIALIZED) == 0)) {
@@ -1093,13 +1074,14 @@ static int stl_waitcarrier(stlport_t *portp, struct file *filp)
                         rc = -ERESTARTSYS;
                         break;
                 }
+                /* FIXME */
                 interruptible_sleep_on(&portp->open_wait);
         }
 
         if (! tty_hung_up_p(filp))
                 portp->refcount++;
         portp->openwaitcnt--;
-        restore_flags(flags);
+        spin_unlock_irqrestore(&stallion_lock, flags);
 
         return rc;
 }
@@ -1119,16 +1101,15 @@ static void stl_close(struct tty_struct *tty, struct file *filp)
         if (portp == (stlport_t *) NULL)
                 return;
 
-        save_flags(flags);
-        cli();
+        spin_lock_irqsave(&stallion_lock, flags);
         if (tty_hung_up_p(filp)) {
-                restore_flags(flags);
+                spin_unlock_irqrestore(&stallion_lock, flags);
                 return;
         }
         if ((tty->count == 1) && (portp->refcount != 1))
                 portp->refcount = 1;
         if (portp->refcount-- > 1) {
-                restore_flags(flags);
+                spin_unlock_irqrestore(&stallion_lock, flags);
                 return;
         }
 
@@ -1142,11 +1123,18 @@ static void stl_close(struct tty_struct *tty, struct file *filp)
  *      (The sc26198 has no "end-of-data" interrupt only empty FIFO)
  */
         tty->closing = 1;
+
+        spin_unlock_irqrestore(&stallion_lock, flags);
+
         if (portp->closing_wait != ASYNC_CLOSING_WAIT_NONE)
                 tty_wait_until_sent(tty, portp->closing_wait);
         stl_waituntilsent(tty, (HZ / 2));
 
+
+        spin_lock_irqsave(&stallion_lock, flags);
         portp->flags &= ~ASYNC_INITIALIZED;
+        spin_unlock_irqrestore(&stallion_lock, flags);
+
         stl_disableintrs(portp);
         if (tty->termios->c_cflag & HUPCL)
                 stl_setsignals(portp, 0, 0);
@@ -1173,7 +1161,6 @@ static void stl_close(struct tty_struct *tty, struct file *filp)
 
         portp->flags &= ~(ASYNC_NORMAL_ACTIVE|ASYNC_CLOSING);
         wake_up_interruptible(&portp->close_wait);
-        restore_flags(flags);
 }
 
 /*****************************************************************************/
@@ -1195,9 +1182,6 @@ static int stl_write(struct tty_struct *tty, const unsigned char *buf, int count
                 (int) tty, (int) buf, count);
 #endif
 
-        if ((tty == (struct tty_struct *) NULL) ||
-            (stl_tmpwritebuf == (char *) NULL))
-                return 0;
         portp = tty->driver_data;
         if (portp == (stlport_t *) NULL)
                 return 0;
@@ -1302,11 +1286,6 @@ static void stl_flushchars(struct tty_struct *tty)
         if (portp->tx.buf == (char *) NULL)
                 return;
 
-#if 0
-        if (tty->stopped || tty->hw_stopped ||
-            (portp->tx.head == portp->tx.tail))
-                return;
-#endif
         stl_startrxtx(portp, -1, 1);
 }
 
@@ -1977,12 +1956,14 @@ static int stl_eiointr(stlbrd_t *brdp)
         unsigned int    iobase;
         int             handled = 0;
 
+        spin_lock(&brd_lock);
         panelp = brdp->panels[0];
         iobase = panelp->iobase;
         while (inb(brdp->iostatus) & EIO_INTRPEND) {
                 handled = 1;
                 (* panelp->isr)(panelp, iobase);
         }
+        spin_unlock(&brd_lock);
         return handled;
 }
 
@@ -2168,7 +2149,7 @@ static int __init stl_initports(stlbrd_t *brdp, stlpanel_t *panelp)
                 portp = kzalloc(sizeof(stlport_t), GFP_KERNEL);
                 if (!portp) {
                         printk("STALLION: failed to allocate memory "
-                                "(size=%d)\n", sizeof(stlport_t));
+                                "(size=%Zd)\n", sizeof(stlport_t));
                         break;
                 }
 
@@ -2304,7 +2285,7 @@ static inline int stl_initeio(stlbrd_t *brdp)
         panelp = kzalloc(sizeof(stlpanel_t), GFP_KERNEL);
         if (!panelp) {
                 printk(KERN_WARNING "STALLION: failed to allocate memory "
-                        "(size=%d)\n", sizeof(stlpanel_t));
+                        "(size=%Zd)\n", sizeof(stlpanel_t));
                 return -ENOMEM;
         }
 
@@ -2478,7 +2459,7 @@ static inline int stl_initech(stlbrd_t *brdp)
                 panelp = kzalloc(sizeof(stlpanel_t), GFP_KERNEL);
                 if (!panelp) {
                         printk("STALLION: failed to allocate memory "
-                                "(size=%d)\n", sizeof(stlpanel_t));
+                                "(size=%Zd)\n", sizeof(stlpanel_t));
                         break;
                 }
                 panelp->magic = STL_PANELMAGIC;
@@ -2879,8 +2860,7 @@ static int stl_getportstats(stlport_t *portp, comstats_t __user *cp)
         portp->stats.lflags = 0;
         portp->stats.rxbuffered = 0;
 
-        save_flags(flags);
-        cli();
+        spin_lock_irqsave(&stallion_lock, flags);
         if (portp->tty != (struct tty_struct *) NULL) {
                 if (portp->tty->driver_data == portp) {
                         portp->stats.ttystate = portp->tty->flags;
@@ -2894,7 +2874,7 @@ static int stl_getportstats(stlport_t *portp, comstats_t __user *cp)
                         }
                 }
         }
-        restore_flags(flags);
+        spin_unlock_irqrestore(&stallion_lock, flags);
 
         head = portp->tx.head;
         tail = portp->tx.tail;
@@ -3049,6 +3029,9 @@ static int __init stl_init(void)
         int i;
         printk(KERN_INFO "%s: version %s\n", stl_drvtitle, stl_drvversion);
 
+        spin_lock_init(&stallion_lock);
+        spin_lock_init(&brd_lock);
+
         stl_initbrds();
 
         stl_serial = alloc_tty_driver(STL_MAXBRDS * STL_MAXPORTS);
@@ -3056,14 +3039,6 @@ static int __init stl_init(void)
                 return -1;
 
 /*
- *      Allocate a temporary write buffer.
- */
-        stl_tmpwritebuf = kmalloc(STL_TXBUFSIZE, GFP_KERNEL);
-        if (!stl_tmpwritebuf)
-                printk("STALLION: failed to allocate memory (size=%d)\n",
-                        STL_TXBUFSIZE);
-
-/*
  *      Set up a character driver for per board stuff. This is mainly used
  *      to do stats ioctls on the ports.
  */
@@ -3147,11 +3122,13 @@ static int stl_cd1400panelinit(stlbrd_t *brdp, stlpanel_t *panelp)
         unsigned int    gfrcr;
         int             chipmask, i, j;
         int             nrchips, uartaddr, ioaddr;
+        unsigned long   flags;
 
 #ifdef DEBUG
         printk("stl_panelinit(brdp=%x,panelp=%x)\n", (int) brdp, (int) panelp);
 #endif
 
+        spin_lock_irqsave(&brd_lock, flags);
         BRDENABLE(panelp->brdnr, panelp->pagenr);
 
 /*
@@ -3189,6 +3166,7 @@ static int stl_cd1400panelinit(stlbrd_t *brdp, stlpanel_t *panelp)
         }
 
         BRDDISABLE(panelp->brdnr);
+        spin_unlock_irqrestore(&brd_lock, flags);
         return chipmask;
 }
 
@@ -3200,6 +3178,7 @@ static int stl_cd1400panelinit(stlbrd_t *brdp, stlpanel_t *panelp)
 
 static void stl_cd1400portinit(stlbrd_t *brdp, stlpanel_t *panelp, stlport_t *portp)
 {
+        unsigned long flags;
 #ifdef DEBUG
         printk("stl_cd1400portinit(brdp=%x,panelp=%x,portp=%x)\n",
                 (int) brdp, (int) panelp, (int) portp);
@@ -3209,6 +3188,7 @@ static void stl_cd1400portinit(stlbrd_t *brdp, stlpanel_t *panelp, stlport_t *po
             (portp == (stlport_t *) NULL))
                 return;
 
+        spin_lock_irqsave(&brd_lock, flags);
         portp->ioaddr = panelp->iobase + (((brdp->brdtype == BRD_ECHPCI) ||
                 (portp->portnr < 8)) ? 0 : EREG_BANKSIZE);
         portp->uartaddr = (portp->portnr & 0x04) << 5;
@@ -3219,6 +3199,7 @@ static void stl_cd1400portinit(stlbrd_t *brdp, stlpanel_t *panelp, stlport_t *po
         stl_cd1400setreg(portp, LIVR, (portp->portnr << 3));
         portp->hwid = stl_cd1400getreg(portp, GFRCR);
         BRDDISABLE(portp->brdnr);
+        spin_unlock_irqrestore(&brd_lock, flags);
 }
 
 /*****************************************************************************/
@@ -3428,8 +3409,7 @@ static void stl_cd1400setport(stlport_t *portp, struct termios *tiosp)
                 tiosp->c_cc[VSTART], tiosp->c_cc[VSTOP]);
 #endif
 
-        save_flags(flags);
-        cli();
+        spin_lock_irqsave(&brd_lock, flags);
         BRDENABLE(portp->brdnr, portp->pagenr);
         stl_cd1400setreg(portp, CAR, (portp->portnr & 0x3));
         srer = stl_cd1400getreg(portp, SRER);
@@ -3466,7 +3446,7 @@ static void stl_cd1400setport(stlport_t *portp, struct termios *tiosp)
                 portp->sigs &= ~TIOCM_CD;
         stl_cd1400setreg(portp, SRER, ((srer & ~sreroff) | sreron));
         BRDDISABLE(portp->brdnr);
-        restore_flags(flags);
+        spin_unlock_irqrestore(&brd_lock, flags);
 }
 
 /*****************************************************************************/
@@ -3492,8 +3472,7 @@ static void stl_cd1400setsignals(stlport_t *portp, int dtr, int rts)
         if (rts > 0)
                 msvr2 = MSVR2_RTS;
 
-        save_flags(flags);
-        cli();
+        spin_lock_irqsave(&brd_lock, flags);
         BRDENABLE(portp->brdnr, portp->pagenr);
         stl_cd1400setreg(portp, CAR, (portp->portnr & 0x03));
         if (rts >= 0)
@@ -3501,7 +3480,7 @@ static void stl_cd1400setsignals(stlport_t *portp, int dtr, int rts)
         if (dtr >= 0)
                 stl_cd1400setreg(portp, MSVR1, msvr1);
         BRDDISABLE(portp->brdnr);
-        restore_flags(flags);
+        spin_unlock_irqrestore(&brd_lock, flags);
 }
 
 /*****************************************************************************/
@@ -3520,14 +3499,13 @@ static int stl_cd1400getsignals(stlport_t *portp)
         printk("stl_cd1400getsignals(portp=%x)\n", (int) portp);
 #endif
 
-        save_flags(flags);
-        cli();
+        spin_lock_irqsave(&brd_lock, flags);
         BRDENABLE(portp->brdnr, portp->pagenr);
         stl_cd1400setreg(portp, CAR, (portp->portnr & 0x03));
         msvr1 = stl_cd1400getreg(portp, MSVR1);
         msvr2 = stl_cd1400getreg(portp, MSVR2);
         BRDDISABLE(portp->brdnr);
-        restore_flags(flags);
+        spin_unlock_irqrestore(&brd_lock, flags);
 
         sigs = 0;
         sigs |= (msvr1 & MSVR1_DCD) ? TIOCM_CD : 0;
@@ -3569,15 +3547,14 @@ static void stl_cd1400enablerxtx(stlport_t *portp, int rx, int tx)
         else if (rx > 0)
                 ccr |= CCR_RXENABLE;
 
-        save_flags(flags);
-        cli();
+        spin_lock_irqsave(&brd_lock, flags);
         BRDENABLE(portp->brdnr, portp->pagenr);
         stl_cd1400setreg(portp, CAR, (portp->portnr & 0x03));
         stl_cd1400ccrwait(portp);
         stl_cd1400setreg(portp, CCR, ccr);
         stl_cd1400ccrwait(portp);
         BRDDISABLE(portp->brdnr);
-        restore_flags(flags);
+        spin_unlock_irqrestore(&brd_lock, flags);
 }
 
 /*****************************************************************************/
@@ -3609,8 +3586,7 @@ static void stl_cd1400startrxtx(stlport_t *portp, int rx, int tx)
         else if (rx > 0)
                 sreron |= SRER_RXDATA;
 
-        save_flags(flags);
-        cli();
+        spin_lock_irqsave(&brd_lock, flags);
         BRDENABLE(portp->brdnr, portp->pagenr);
         stl_cd1400setreg(portp, CAR, (portp->portnr & 0x03));
         stl_cd1400setreg(portp, SRER,
@@ -3618,7 +3594,7 @@ static void stl_cd1400startrxtx(stlport_t *portp, int rx, int tx)
         BRDDISABLE(portp->brdnr);
         if (tx > 0)
                 set_bit(ASYI_TXBUSY, &portp->istate);
-        restore_flags(flags);
+        spin_unlock_irqrestore(&brd_lock, flags);
 }
 
 /*****************************************************************************/
@@ -3634,13 +3610,12 @@ static void stl_cd1400disableintrs(stlport_t *portp)
 #ifdef DEBUG
         printk("stl_cd1400disableintrs(portp=%x)\n", (int) portp);
 #endif
-        save_flags(flags);
-        cli();
+        spin_lock_irqsave(&brd_lock, flags);
         BRDENABLE(portp->brdnr, portp->pagenr);
         stl_cd1400setreg(portp, CAR, (portp->portnr & 0x03));
         stl_cd1400setreg(portp, SRER, 0);
         BRDDISABLE(portp->brdnr);
-        restore_flags(flags);
+        spin_unlock_irqrestore(&brd_lock, flags);
 }
 
 /*****************************************************************************/
@@ -3653,8 +3628,7 @@ static void stl_cd1400sendbreak(stlport_t *portp, int len)
         printk("stl_cd1400sendbreak(portp=%x,len=%d)\n", (int) portp, len);
 #endif
 
-        save_flags(flags);
-        cli();
+        spin_lock_irqsave(&brd_lock, flags);
         BRDENABLE(portp->brdnr, portp->pagenr);
         stl_cd1400setreg(portp, CAR, (portp->portnr & 0x03));
         stl_cd1400setreg(portp, SRER,
@@ -3664,7 +3638,7 @@ static void stl_cd1400sendbreak(stlport_t *portp, int len)
         portp->brklen = len;
         if (len == 1)
                 portp->stats.txbreaks++;
-        restore_flags(flags);
+        spin_unlock_irqrestore(&brd_lock, flags);
 }
 
 /*****************************************************************************/
@@ -3688,8 +3662,7 @@ static void stl_cd1400flowctrl(stlport_t *portp, int state)
         if (tty == (struct tty_struct *) NULL)
                 return;
 
-        save_flags(flags);
-        cli();
+        spin_lock_irqsave(&brd_lock, flags);
         BRDENABLE(portp->brdnr, portp->pagenr);
         stl_cd1400setreg(portp, CAR, (portp->portnr & 0x03));
 
@@ -3729,7 +3702,7 @@ static void stl_cd1400flowctrl(stlport_t *portp, int state)
         }
 
         BRDDISABLE(portp->brdnr);
-        restore_flags(flags);
+        spin_unlock_irqrestore(&brd_lock, flags);
 }
 
 /*****************************************************************************/
@@ -3753,8 +3726,7 @@ static void stl_cd1400sendflow(stlport_t *portp, int state)
         if (tty == (struct tty_struct *) NULL)
                 return;
 
-        save_flags(flags);
-        cli();
+        spin_lock_irqsave(&brd_lock, flags);
         BRDENABLE(portp->brdnr, portp->pagenr);
         stl_cd1400setreg(portp, CAR, (portp->portnr & 0x03));
         if (state) {
@@ -3769,7 +3741,7 @@ static void stl_cd1400sendflow(stlport_t *portp, int state)
                 stl_cd1400ccrwait(portp);
         }
         BRDDISABLE(portp->brdnr);
-        restore_flags(flags);
+        spin_unlock_irqrestore(&brd_lock, flags);
 }
 
 /*****************************************************************************/
@@ -3785,8 +3757,7 @@ static void stl_cd1400flush(stlport_t *portp)
         if (portp == (stlport_t *) NULL)
                 return;
 
-        save_flags(flags);
-        cli();
+        spin_lock_irqsave(&brd_lock, flags);
         BRDENABLE(portp->brdnr, portp->pagenr);
         stl_cd1400setreg(portp, CAR, (portp->portnr & 0x03));
         stl_cd1400ccrwait(portp);
@@ -3794,7 +3765,7 @@ static void stl_cd1400flush(stlport_t *portp)
         stl_cd1400ccrwait(portp);
         portp->tx.tail = portp->tx.head;
         BRDDISABLE(portp->brdnr);
-        restore_flags(flags);
+        spin_unlock_irqrestore(&brd_lock, flags);
 }
 
 /*****************************************************************************/
@@ -3833,6 +3804,7 @@ static void stl_cd1400eiointr(stlpanel_t *panelp, unsigned int iobase)
                 (int) panelp, iobase);
 #endif
 
+        spin_lock(&brd_lock);
         outb(SVRR, iobase);
         svrtype = inb(iobase + EREG_DATA);
         if (panelp->nrports > 4) {
@@ -3846,6 +3818,8 @@ static void stl_cd1400eiointr(stlpanel_t *panelp, unsigned int iobase)
                 stl_cd1400txisr(panelp, iobase);
         else if (svrtype & SVRR_MDM)
                 stl_cd1400mdmisr(panelp, iobase);
+
+        spin_unlock(&brd_lock);
 }
 
 /*****************************************************************************/
@@ -4433,8 +4407,7 @@ static void stl_sc26198setport(stlport_t *portp, struct termios *tiosp)
                 tiosp->c_cc[VSTART], tiosp->c_cc[VSTOP]);
 #endif
 
-        save_flags(flags);
-        cli();
+        spin_lock_irqsave(&brd_lock, flags);
         BRDENABLE(portp->brdnr, portp->pagenr);
         stl_sc26198setreg(portp, IMR, 0);
         stl_sc26198updatereg(portp, MR0, mr0);
@@ -4461,7 +4434,7 @@ static void stl_sc26198setport(stlport_t *portp, struct termios *tiosp)
         portp->imr = (portp->imr & ~imroff) | imron;
         stl_sc26198setreg(portp, IMR, portp->imr);
         BRDDISABLE(portp->brdnr);
-        restore_flags(flags);
+        spin_unlock_irqrestore(&brd_lock, flags);
 }
 
 /*****************************************************************************/
@@ -4491,13 +4464,12 @@ static void stl_sc26198setsignals(stlport_t *portp, int dtr, int rts)
         else if (rts > 0)
                 iopioron |= IPR_RTS;
 
-        save_flags(flags);
-        cli();
+        spin_lock_irqsave(&brd_lock, flags);
         BRDENABLE(portp->brdnr, portp->pagenr);
         stl_sc26198setreg(portp, IOPIOR,
                 ((stl_sc26198getreg(portp, IOPIOR) & ~iopioroff) | iopioron));
         BRDDISABLE(portp->brdnr);
-        restore_flags(flags);
+        spin_unlock_irqrestore(&brd_lock, flags);
 }
 
 /*****************************************************************************/
@@ -4516,12 +4488,11 @@ static int stl_sc26198getsignals(stlport_t *portp)
         printk("stl_sc26198getsignals(portp=%x)\n", (int) portp);
 #endif
 
-        save_flags(flags);
-        cli();
+        spin_lock_irqsave(&brd_lock, flags);
         BRDENABLE(portp->brdnr, portp->pagenr);
         ipr = stl_sc26198getreg(portp, IPR);
         BRDDISABLE(portp->brdnr);
-        restore_flags(flags);
+        spin_unlock_irqrestore(&brd_lock, flags);
 
         sigs = 0;
         sigs |= (ipr & IPR_DCD) ? 0 : TIOCM_CD;
@@ -4558,13 +4529,12 @@ static void stl_sc26198enablerxtx(stlport_t *portp, int rx, int tx)
         else if (rx > 0)
                 ccr |= CR_RXENABLE;
 
-        save_flags(flags);
-        cli();
+        spin_lock_irqsave(&brd_lock, flags);
         BRDENABLE(portp->brdnr, portp->pagenr);
         stl_sc26198setreg(portp, SCCR, ccr);
         BRDDISABLE(portp->brdnr);
         portp->crenable = ccr;
-        restore_flags(flags);
+        spin_unlock_irqrestore(&brd_lock, flags);
 }
 
 /*****************************************************************************/
@@ -4593,15 +4563,14 @@ static void stl_sc26198startrxtx(stlport_t *portp, int rx, int tx)
         else if (rx > 0)
                 imr |= IR_RXRDY | IR_RXBREAK | IR_RXWATCHDOG;
 
-        save_flags(flags);
-        cli();
+        spin_lock_irqsave(&brd_lock, flags);
         BRDENABLE(portp->brdnr, portp->pagenr);
         stl_sc26198setreg(portp, IMR, imr);
         BRDDISABLE(portp->brdnr);
         portp->imr = imr;
         if (tx > 0)
                 set_bit(ASYI_TXBUSY, &portp->istate);
-        restore_flags(flags);
+        spin_unlock_irqrestore(&brd_lock, flags);
 }
 
 /*****************************************************************************/
@@ -4618,13 +4587,12 @@ static void stl_sc26198disableintrs(stlport_t *portp)
         printk("stl_sc26198disableintrs(portp=%x)\n", (int) portp);
 #endif
 
-        save_flags(flags);
-        cli();
+        spin_lock_irqsave(&brd_lock, flags);
         BRDENABLE(portp->brdnr, portp->pagenr);
         portp->imr = 0;
         stl_sc26198setreg(portp, IMR, 0);
         BRDDISABLE(portp->brdnr);
-        restore_flags(flags);
+        spin_unlock_irqrestore(&brd_lock, flags);
 }
 
 /*****************************************************************************/
@@ -4637,8 +4605,7 @@ static void stl_sc26198sendbreak(stlport_t *portp, int len)
         printk("stl_sc26198sendbreak(portp=%x,len=%d)\n", (int) portp, len);
 #endif
 
-        save_flags(flags);
-        cli();
+        spin_lock_irqsave(&brd_lock, flags);
         BRDENABLE(portp->brdnr, portp->pagenr);
         if (len == 1) {
                 stl_sc26198setreg(portp, SCCR, CR_TXSTARTBREAK);
@@ -4647,7 +4614,7 @@ static void stl_sc26198sendbreak(stlport_t *portp, int len)
                 stl_sc26198setreg(portp, SCCR, CR_TXSTOPBREAK);
         }
         BRDDISABLE(portp->brdnr);
-        restore_flags(flags);
+        spin_unlock_irqrestore(&brd_lock, flags);
 }
 
 /*****************************************************************************/
@@ -4672,8 +4639,7 @@ static void stl_sc26198flowctrl(stlport_t *portp, int state)
         if (tty == (struct tty_struct *) NULL)
                 return;
 
-        save_flags(flags);
-        cli();
+        spin_lock_irqsave(&brd_lock, flags);
         BRDENABLE(portp->brdnr, portp->pagenr);
 
         if (state) {
@@ -4719,7 +4685,7 @@ static void stl_sc26198flowctrl(stlport_t *portp, int state)
         }
 
         BRDDISABLE(portp->brdnr);
-        restore_flags(flags);
+        spin_unlock_irqrestore(&brd_lock, flags);
 }
 
 /*****************************************************************************/
@@ -4744,8 +4710,7 @@ static void stl_sc26198sendflow(stlport_t *portp, int state)
         if (tty == (struct tty_struct *) NULL)
                 return;
 
-        save_flags(flags);
-        cli();
+        spin_lock_irqsave(&brd_lock, flags);
         BRDENABLE(portp->brdnr, portp->pagenr);
         if (state) {
                 mr0 = stl_sc26198getreg(portp, MR0);
@@ -4765,7 +4730,7 @@ static void stl_sc26198sendflow(stlport_t *portp, int state)
                 stl_sc26198setreg(portp, MR0, mr0);
         }
         BRDDISABLE(portp->brdnr);
-        restore_flags(flags);
+        spin_unlock_irqrestore(&brd_lock, flags);
 }
 
 /*****************************************************************************/
@@ -4781,14 +4746,13 @@ static void stl_sc26198flush(stlport_t *portp)
         if (portp == (stlport_t *) NULL)
                 return;
 
-        save_flags(flags);
-        cli();
+        spin_lock_irqsave(&brd_lock, flags);
         BRDENABLE(portp->brdnr, portp->pagenr);
         stl_sc26198setreg(portp, SCCR, CR_TXRESET);
         stl_sc26198setreg(portp, SCCR, portp->crenable);
         BRDDISABLE(portp->brdnr);
         portp->tx.tail = portp->tx.head;
-        restore_flags(flags);
+        spin_unlock_irqrestore(&brd_lock, flags);
 }
 
 /*****************************************************************************/
@@ -4815,12 +4779,11 @@ static int stl_sc26198datastate(stlport_t *portp)
         if (test_bit(ASYI_TXBUSY, &portp->istate))
                 return 1;
 
-        save_flags(flags);
-        cli();
+        spin_lock_irqsave(&brd_lock, flags);
         BRDENABLE(portp->brdnr, portp->pagenr);
         sr = stl_sc26198getreg(portp, SR);
         BRDDISABLE(portp->brdnr);
-        restore_flags(flags);
+        spin_unlock_irqrestore(&brd_lock, flags);
 
         return (sr & SR_TXEMPTY) ? 0 : 1;
 }
@@ -4878,6 +4841,8 @@ static void stl_sc26198intr(stlpanel_t *panelp, unsigned int iobase)
         stlport_t       *portp;
         unsigned int    iack;
 
+        spin_lock(&brd_lock);
+
 /* 
  *      Work around bug in sc26198 chip... Cannot have A6 address
  *      line of UART high, else iack will be returned as 0.
@@ -4893,6 +4858,8 @@ static void stl_sc26198intr(stlpanel_t *panelp, unsigned int iobase)
                 stl_sc26198txisr(portp);
         else
                 stl_sc26198otherisr(portp, iack);
+
+        spin_unlock(&brd_lock);
 }
 
 /*****************************************************************************/
diff --git a/drivers/char/sx.c b/drivers/char/sx.c
index 3b4747230270..76b9107f7f81 100644
--- a/drivers/char/sx.c
+++ b/drivers/char/sx.c
@@ -2320,7 +2320,7 @@ static int sx_init_portstructs (int nboards, int nports)
 #ifdef NEW_WRITE_LOCKING
                         port->gs.port_write_mutex = MUTEX;
 #endif
-                        port->gs.driver_lock = SPIN_LOCK_UNLOCKED;
+                        spin_lock_init(&port->gs.driver_lock);
                         /*
                          * Initializing wait queue
                          */
diff --git a/drivers/char/synclink_gt.c b/drivers/char/synclink_gt.c
index b4d1f4eea435..4e35d4181224 100644
--- a/drivers/char/synclink_gt.c
+++ b/drivers/char/synclink_gt.c
@@ -101,6 +101,7 @@ MODULE_LICENSE("GPL");
 
 static struct pci_device_id pci_table[] = {
         {PCI_VENDOR_ID_MICROGATE, SYNCLINK_GT_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID,},
+        {PCI_VENDOR_ID_MICROGATE, SYNCLINK_GT2_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID,},
         {PCI_VENDOR_ID_MICROGATE, SYNCLINK_GT4_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID,},
         {PCI_VENDOR_ID_MICROGATE, SYNCLINK_AC_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID,},
         {0,}, /* terminate list */
@@ -870,7 +871,7 @@ static int write(struct tty_struct *tty,
                 goto cleanup;
         DBGINFO(("%s write count=%d\n", info->device_name, count));
 
-        if (!tty || !info->tx_buf)
+        if (!info->tx_buf)
                 goto cleanup;
 
         if (count > info->max_frame_size) {
@@ -924,7 +925,7 @@ static void put_char(struct tty_struct *tty, unsigned char ch)
         if (sanity_check(info, tty->name, "put_char"))
                 return;
         DBGINFO(("%s put_char(%d)\n", info->device_name, ch));
-        if (!tty || !info->tx_buf)
+        if (!info->tx_buf)
                 return;
         spin_lock_irqsave(&info->lock,flags);
         if (!info->tx_active && (info->tx_count < info->max_frame_size))
@@ -2515,7 +2516,8 @@ static int set_txidle(struct slgt_info *info, int idle_mode)
         DBGINFO(("%s set_txidle(%d)\n", info->device_name, idle_mode));
         spin_lock_irqsave(&info->lock,flags);
         info->idle_mode = idle_mode;
-        tx_set_idle(info);
+        if (info->params.mode != MGSL_MODE_ASYNC)
+                tx_set_idle(info);
         spin_unlock_irqrestore(&info->lock,flags);
         return 0;
 }
@@ -3076,7 +3078,7 @@ static int block_til_ready(struct tty_struct *tty, struct file *filp,
 
 static int alloc_tmp_rbuf(struct slgt_info *info)
 {
-        info->tmp_rbuf = kmalloc(info->max_frame_size, GFP_KERNEL);
+        info->tmp_rbuf = kmalloc(info->max_frame_size + 5, GFP_KERNEL);
         if (info->tmp_rbuf == NULL)
                 return -ENOMEM;
         return 0;
@@ -3276,6 +3278,9 @@ static void add_device(struct slgt_info *info)
         case SYNCLINK_GT_DEVICE_ID:
                 devstr = "GT";
                 break;
+        case SYNCLINK_GT2_DEVICE_ID:
+                devstr = "GT2";
+                break;
         case SYNCLINK_GT4_DEVICE_ID:
                 devstr = "GT4";
                 break;
@@ -3353,7 +3358,9 @@ static void device_init(int adapter_num, struct pci_dev *pdev)
         int i;
         int port_count = 1;
 
-        if (pdev->device == SYNCLINK_GT4_DEVICE_ID)
+        if (pdev->device == SYNCLINK_GT2_DEVICE_ID)
+                port_count = 2;
+        else if (pdev->device == SYNCLINK_GT4_DEVICE_ID)
                 port_count = 4;
 
         /* allocate device instances for all ports */
@@ -3940,8 +3947,6 @@ static void async_mode(struct slgt_info *info)
 
         msc_set_vcr(info);
 
-        tx_set_idle(info);
-
         /* SCR (serial control)
          *
          * 15  1=tx req on FIFO half empty
@@ -4012,7 +4017,7 @@ static void hdlc_mode(struct slgt_info *info)
         case HDLC_ENCODING_DIFF_BIPHASE_LEVEL: val |= BIT12 + BIT11 + BIT10; break;
         }
 
-        switch (info->params.crc_type)
+        switch (info->params.crc_type & HDLC_CRC_MASK)
         {
         case HDLC_CRC_16_CCITT: val |= BIT9; break;
         case HDLC_CRC_32_CCITT: val |= BIT9 + BIT8; break;
@@ -4073,7 +4078,7 @@ static void hdlc_mode(struct slgt_info *info)
         case HDLC_ENCODING_DIFF_BIPHASE_LEVEL: val |= BIT12 + BIT11 + BIT10; break;
         }
 
-        switch (info->params.crc_type)
+        switch (info->params.crc_type & HDLC_CRC_MASK)
         {
         case HDLC_CRC_16_CCITT: val |= BIT9; break;
         case HDLC_CRC_32_CCITT: val |= BIT9 + BIT8; break;
@@ -4175,17 +4180,38 @@ static void hdlc_mode(struct slgt_info *info)
  */
 static void tx_set_idle(struct slgt_info *info)
 {
-        unsigned char val = 0xff;
+        unsigned char val;
+        unsigned short tcr;
 
-        switch(info->idle_mode)
-        {
-        case HDLC_TXIDLE_FLAGS:          val = 0x7e; break;
-        case HDLC_TXIDLE_ALT_ZEROS_ONES: val = 0xaa; break;
-        case HDLC_TXIDLE_ZEROS:          val = 0x00; break;
-        case HDLC_TXIDLE_ONES:           val = 0xff; break;
-        case HDLC_TXIDLE_ALT_MARK_SPACE: val = 0xaa; break;
-        case HDLC_TXIDLE_SPACE:          val = 0x00; break;
-        case HDLC_TXIDLE_MARK:           val = 0xff; break;
+        /* if preamble enabled (tcr[6] == 1) then tx idle size = 8 bits
+         * else tcr[5:4] = tx idle size: 00 = 8 bits, 01 = 16 bits
+         */
+        tcr = rd_reg16(info, TCR);
+        if (info->idle_mode & HDLC_TXIDLE_CUSTOM_16) {
+                /* disable preamble, set idle size to 16 bits */
+                tcr = (tcr & ~(BIT6 + BIT5)) | BIT4;
+                /* MSB of 16 bit idle specified in tx preamble register (TPR) */
+                wr_reg8(info, TPR, (unsigned char)((info->idle_mode >> 8) & 0xff));
+        } else if (!(tcr & BIT6)) {
+                /* preamble is disabled, set idle size to 8 bits */
+                tcr &= ~(BIT5 + BIT4);
+        }
+        wr_reg16(info, TCR, tcr);
+
+        if (info->idle_mode & (HDLC_TXIDLE_CUSTOM_8 | HDLC_TXIDLE_CUSTOM_16)) {
+                /* LSB of custom tx idle specified in tx idle register */
+                val = (unsigned char)(info->idle_mode & 0xff);
+        } else {
+                /* standard 8 bit idle patterns */
+                switch(info->idle_mode)
+                {
+                case HDLC_TXIDLE_FLAGS:          val = 0x7e; break;
+                case HDLC_TXIDLE_ALT_ZEROS_ONES:
+                case HDLC_TXIDLE_ALT_MARK_SPACE: val = 0xaa; break;
+                case HDLC_TXIDLE_ZEROS:
+                case HDLC_TXIDLE_SPACE:          val = 0x00; break;
+                default:                         val = 0xff;
+                }
         }
 
         wr_reg8(info, TIR, val);
@@ -4313,6 +4339,12 @@ static int rx_get_frame(struct slgt_info *info)
         unsigned long flags;
         struct tty_struct *tty = info->tty;
         unsigned char addr_field = 0xff;
+        unsigned int crc_size = 0;
+
+        switch (info->params.crc_type & HDLC_CRC_MASK) {
+        case HDLC_CRC_16_CCITT: crc_size = 2; break;
+        case HDLC_CRC_32_CCITT: crc_size = 4; break;
+        }
 
 check_again:
 
@@ -4357,7 +4389,7 @@ check_again:
         status = desc_status(info->rbufs[end]);
 
         /* ignore CRC bit if not using CRC (bit is undefined) */
-        if (info->params.crc_type == HDLC_CRC_NONE)
+        if ((info->params.crc_type & HDLC_CRC_MASK) == HDLC_CRC_NONE)
                 status &= ~BIT1;
 
         if (framesize == 0 ||
@@ -4366,34 +4398,34 @@ check_again:
                 goto check_again;
         }
 
-        if (framesize < 2 || status & (BIT1+BIT0)) {
-                if (framesize < 2 || (status & BIT0))
-                        info->icount.rxshort++;
-                else
-                        info->icount.rxcrc++;
+        if (framesize < (2 + crc_size) || status & BIT0) {
+                info->icount.rxshort++;
                 framesize = 0;
+        } else if (status & BIT1) {
+                info->icount.rxcrc++;
+                if (!(info->params.crc_type & HDLC_CRC_RETURN_EX))
+                        framesize = 0;
+        }
 
 #ifdef CONFIG_HDLC
-                {
-                        struct net_device_stats *stats = hdlc_stats(info->netdev);
-                        stats->rx_errors++;
-                        stats->rx_frame_errors++;
-                }
-#endif
-        } else {
-                /* adjust frame size for CRC, if any */
-                if (info->params.crc_type == HDLC_CRC_16_CCITT)
-                        framesize -= 2;
-                else if (info->params.crc_type == HDLC_CRC_32_CCITT)
-                        framesize -= 4;
+        if (framesize == 0) {
+                struct net_device_stats *stats = hdlc_stats(info->netdev);
+                stats->rx_errors++;
+                stats->rx_frame_errors++;
         }
+#endif
 
         DBGBH(("%s rx frame status=%04X size=%d\n",
                 info->device_name, status, framesize));
         DBGDATA(info, info->rbufs[start].buf, min_t(int, framesize, DMABUFSIZE), "rx");
 
         if (framesize) {
-                if (framesize > info->max_frame_size)
+                if (!(info->params.crc_type & HDLC_CRC_RETURN_EX)) {
+                        framesize -= crc_size;
+                        crc_size = 0;
+                }
+
+                if (framesize > info->max_frame_size + crc_size)
                         info->icount.rxlong++;
                 else {
                         /* copy dma buffer(s) to contiguous temp buffer */
@@ -4413,6 +4445,11 @@ check_again:
                                         i = 0;
                         }
 
+                        if (info->params.crc_type & HDLC_CRC_RETURN_EX) {
+                                *p = (status & BIT1) ? RX_CRC_ERROR : RX_OK;
+                                framesize++;
+                        }
+
 #ifdef CONFIG_HDLC
                         if (info->netcount)
                                 hdlcdev_rx(info,info->tmp_rbuf, framesize);
@@ -4671,13 +4708,13 @@ static int loopback_test(struct slgt_info *info)
 static int adapter_test(struct slgt_info *info)
 {
         DBGINFO(("testing %s\n", info->device_name));
-        if ((info->init_error = register_test(info)) < 0) {
+        if (register_test(info) < 0) {
                 printk("register test failure %s addr=%08X\n",
                         info->device_name, info->phys_reg_addr);
-        } else if ((info->init_error = irq_test(info)) < 0) {
+        } else if (irq_test(info) < 0) {
                 printk("IRQ test failure %s IRQ=%d\n",
                         info->device_name, info->irq_level);
-        } else if ((info->init_error = loopback_test(info)) < 0) {
+        } else if (loopback_test(info) < 0) {
                 printk("loopback test failure %s\n", info->device_name);
         }
         return info->init_error;
diff --git a/drivers/char/synclinkmp.c b/drivers/char/synclinkmp.c
index 858740131115..21bf15ad9980 100644
--- a/drivers/char/synclinkmp.c
+++ b/drivers/char/synclinkmp.c
@@ -988,7 +988,7 @@ static int write(struct tty_struct *tty,
         if (sanity_check(info, tty->name, "write"))
                 goto cleanup;
 
-        if (!tty || !info->tx_buf)
+        if (!info->tx_buf)
                 goto cleanup;
 
         if (info->params.mode == MGSL_MODE_HDLC) {
@@ -1067,7 +1067,7 @@ static void put_char(struct tty_struct *tty, unsigned char ch)
         if (sanity_check(info, tty->name, "put_char"))
                 return;
 
-        if (!tty || !info->tx_buf)
+        if (!info->tx_buf)
                 return;
 
         spin_lock_irqsave(&info->lock,flags);
diff --git a/drivers/char/tlclk.c b/drivers/char/tlclk.c
index f58ad7f68267..ef68d152d3e4 100644
--- a/drivers/char/tlclk.c
+++ b/drivers/char/tlclk.c
@@ -343,7 +343,7 @@ static ssize_t store_received_ref_clk3b(struct device *d,
 
         val = (unsigned char)tmp;
         spin_lock_irqsave(&event_lock, flags);
-        SET_PORT_BITS(TLCLK_REG1, 0xef, val << 1);
+        SET_PORT_BITS(TLCLK_REG1, 0xdf, val << 1);
         spin_unlock_irqrestore(&event_lock, flags);
 
         return strnlen(buf, count);
diff --git a/drivers/char/tty_io.c b/drivers/char/tty_io.c
index a88b94a82b14..8d19f7281f0b 100644
--- a/drivers/char/tty_io.c
+++ b/drivers/char/tty_io.c
@@ -267,7 +267,6 @@ static struct tty_buffer *tty_buffer_alloc(size_t size)
         p->used = 0;
         p->size = size;
         p->next = NULL;
-        p->active = 0;
         p->commit = 0;
         p->read = 0;
         p->char_buf_ptr = (char *)(p->data);
@@ -327,10 +326,9 @@ int tty_buffer_request_room(struct tty_struct *tty, size_t size)
         /* OPTIMISATION: We could keep a per tty "zero" sized buffer to
            remove this conditional if its worth it. This would be invisible
            to the callers */
-        if ((b = tty->buf.tail) != NULL) {
+        if ((b = tty->buf.tail) != NULL)
                 left = b->size - b->used;
-                b->active = 1;
-        } else
+        else
                 left = 0;
 
         if (left < size) {
@@ -338,12 +336,10 @@ int tty_buffer_request_room(struct tty_struct *tty, size_t size)
                 if ((n = tty_buffer_find(tty, size)) != NULL) {
                         if (b != NULL) {
                                 b->next = n;
-                                b->active = 0;
                                 b->commit = b->used;
                         } else
                                 tty->buf.head = n;
                         tty->buf.tail = n;
-                        n->active = 1;
                 } else
                         size = left;
         }
@@ -404,10 +400,8 @@ void tty_schedule_flip(struct tty_struct *tty)
 {
         unsigned long flags;
         spin_lock_irqsave(&tty->buf.lock, flags);
-        if (tty->buf.tail != NULL) {
-                tty->buf.tail->active = 0;
+        if (tty->buf.tail != NULL)
                 tty->buf.tail->commit = tty->buf.tail->used;
-        }
         spin_unlock_irqrestore(&tty->buf.lock, flags);
         schedule_delayed_work(&tty->buf.work, 1);
 }
@@ -784,11 +778,8 @@ restart:
         }
 
         clear_bit(TTY_LDISC, &tty->flags);
-        clear_bit(TTY_DONT_FLIP, &tty->flags);
-        if (o_tty) {
+        if (o_tty)
                 clear_bit(TTY_LDISC, &o_tty->flags);
-                clear_bit(TTY_DONT_FLIP, &o_tty->flags);
-        }
         spin_unlock_irqrestore(&tty_ldisc_lock, flags);
 
         /*
@@ -1955,7 +1946,6 @@ static void release_dev(struct file * filp)
          * race with the set_ldisc code path.
          */
         clear_bit(TTY_LDISC, &tty->flags);
-        clear_bit(TTY_DONT_FLIP, &tty->flags);
         cancel_delayed_work(&tty->buf.work);
 
         /*
@@ -2621,10 +2611,9 @@ int tty_ioctl(struct inode * inode, struct file * file,
                         tty->driver->break_ctl(tty, 0);
                         return 0;
                 case TCSBRK:   /* SVID version: non-zero arg --> no break */
-                        /*
-                         * XXX is the above comment correct, or the
-                         * code below correct?  Is this ioctl used at
-                         * all by anyone?
+                        /* non-zero arg means wait for all output data
+                         * to be sent (performed above) but don't send break.
+                         * This is used by the tcdrain() termios function.
                          */
                         if (!arg)
                                 return send_break(tty, 250);
@@ -2776,8 +2765,7 @@ static void flush_to_ldisc(void *private_)
         struct tty_struct *tty = (struct tty_struct *) private_;
         unsigned long   flags;
         struct tty_ldisc *disc;
-        struct tty_buffer *tbuf;
-        int count;
+        struct tty_buffer *tbuf, *head;
         char *char_buf;
         unsigned char *flag_buf;
 
@@ -2785,32 +2773,37 @@ static void flush_to_ldisc(void *private_)
         if (disc == NULL)       /*  !TTY_LDISC */
                 return;
 
-        if (test_bit(TTY_DONT_FLIP, &tty->flags)) {
-                /*
-                 * Do it after the next timer tick:
-                 */
-                schedule_delayed_work(&tty->buf.work, 1);
-                goto out;
-        }
         spin_lock_irqsave(&tty->buf.lock, flags);
-        while((tbuf = tty->buf.head) != NULL) {
-                while ((count = tbuf->commit - tbuf->read) != 0) {
-                        char_buf = tbuf->char_buf_ptr + tbuf->read;
-                        flag_buf = tbuf->flag_buf_ptr + tbuf->read;
-                        tbuf->read += count;
+        head = tty->buf.head;
+        if (head != NULL) {
+                tty->buf.head = NULL;
+                for (;;) {
+                        int count = head->commit - head->read;
+                        if (!count) {
+                                if (head->next == NULL)
+                                        break;
+                                tbuf = head;
+                                head = head->next;
+                                tty_buffer_free(tty, tbuf);
+                                continue;
+                        }
+                        if (!tty->receive_room) {
+                                schedule_delayed_work(&tty->buf.work, 1);
+                                break;
+                        }
+                        if (count > tty->receive_room)
+                                count = tty->receive_room;
+                        char_buf = head->char_buf_ptr + head->read;
+                        flag_buf = head->flag_buf_ptr + head->read;
+                        head->read += count;
                         spin_unlock_irqrestore(&tty->buf.lock, flags);
                         disc->receive_buf(tty, char_buf, flag_buf, count);
                         spin_lock_irqsave(&tty->buf.lock, flags);
                 }
-                if (tbuf->active)
-                        break;
-                tty->buf.head = tbuf->next;
-                if (tty->buf.head == NULL)
-                        tty->buf.tail = NULL;
-                tty_buffer_free(tty, tbuf);
+                tty->buf.head = head;
         }
         spin_unlock_irqrestore(&tty->buf.lock, flags);
-out:
+
         tty_ldisc_deref(disc);
 }
 
@@ -2903,10 +2896,8 @@ void tty_flip_buffer_push(struct tty_struct *tty)
 {
         unsigned long flags;
         spin_lock_irqsave(&tty->buf.lock, flags);
-        if (tty->buf.tail != NULL) {
-                tty->buf.tail->active = 0;
+        if (tty->buf.tail != NULL)
                 tty->buf.tail->commit = tty->buf.tail->used;
-        }
         spin_unlock_irqrestore(&tty->buf.lock, flags);
 
         if (tty->low_latency)
@@ -2961,12 +2952,14 @@ static struct class *tty_class;
  *      This field is optional, if there is no known struct device for this
  *      tty device it can be set to NULL safely.
  *
+ * Returns a pointer to the class device (or ERR_PTR(-EFOO) on error).
+ *
  * This call is required to be made to register an individual tty device if
  * the tty driver's flags have the TTY_DRIVER_NO_DEVFS bit set.  If that
  * bit is not set, this function should not be called.
  */
-void tty_register_device(struct tty_driver *driver, unsigned index,
-                         struct device *device)
+struct class_device *tty_register_device(struct tty_driver *driver,
+                                         unsigned index, struct device *device)
 {
         char name[64];
         dev_t dev = MKDEV(driver->major, driver->minor_start) + index;
@@ -2974,7 +2967,7 @@ void tty_register_device(struct tty_driver *driver, unsigned index,
         if (index >= driver->num) {
                 printk(KERN_ERR "Attempt to register invalid tty line number "
                        " (%d).\n", index);
-                return;
+                return ERR_PTR(-EINVAL);
         }
 
         devfs_mk_cdev(dev, S_IFCHR | S_IRUSR | S_IWUSR,
@@ -2984,7 +2977,8 @@ void tty_register_device(struct tty_driver *driver, unsigned index,
                 pty_line_name(driver, index, name);
         else
                 tty_line_name(driver, index, name);
-        class_device_create(tty_class, NULL, dev, device, "%s", name);
+
+        return class_device_create(tty_class, NULL, dev, device, "%s", name);
 }
 
 /**
diff --git a/drivers/char/viotape.c b/drivers/char/viotape.c
index 60aabdb4a046..11c7e9de5958 100644
--- a/drivers/char/viotape.c
+++ b/drivers/char/viotape.c
@@ -989,7 +989,7 @@ static int viotape_remove(struct vio_dev *vdev)
  * support.
  */
 static struct vio_device_id viotape_device_table[] __devinitdata = {
-        { "viotape", "" },
+        { "byte", "IBM,iSeries-viotape" },
         { "", "" }
 };
 MODULE_DEVICE_TABLE(vio, viotape_device_table);
diff --git a/drivers/char/vr41xx_giu.c b/drivers/char/vr41xx_giu.c
index 05e6e814d86f..073da48c092e 100644
--- a/drivers/char/vr41xx_giu.c
+++ b/drivers/char/vr41xx_giu.c
@@ -689,9 +689,9 @@ static int __devinit giu_probe(struct platform_device *dev)
 
         for (i = GIU_IRQ_BASE; i <= GIU_IRQ_LAST; i++) {
                 if (i < GIU_IRQ(GIUINT_HIGH_OFFSET))
-                        irq_desc[i].handler = &giuint_low_irq_type;
+                        irq_desc[i].chip = &giuint_low_irq_type;
                 else
-                        irq_desc[i].handler = &giuint_high_irq_type;
+                        irq_desc[i].chip = &giuint_high_irq_type;
         }
 
         return cascade_irq(GIUINT_IRQ, giu_get_irq);
diff --git a/drivers/char/vt.c b/drivers/char/vt.c
index 6c94879e0b99..714d95ff2f1e 100644
--- a/drivers/char/vt.c
+++ b/drivers/char/vt.c
@@ -98,7 +98,22 @@
 #include <asm/system.h>
 #include <asm/uaccess.h>
 
+#define MAX_NR_CON_DRIVER 16
 
+#define CON_DRIVER_FLAG_MODULE 1
+#define CON_DRIVER_FLAG_INIT 2
+
+struct con_driver {
+        const struct consw *con;
+        const char *desc;
+        struct class_device *class_dev;
+        int node;
+        int first;
+        int last;
+        int flag;
+};
+
+static struct con_driver registered_con_driver[MAX_NR_CON_DRIVER];
 const struct consw *conswitchp;
 
 /* A bitmap for codes <32. A bit of 1 indicates that the code
@@ -2557,7 +2572,7 @@ static int __init con_init(void)
 {
         const char *display_desc = NULL;
         struct vc_data *vc;
-        unsigned int currcons = 0;
+        unsigned int currcons = 0, i;
 
         acquire_console_sem();
 
@@ -2569,6 +2584,22 @@ static int __init con_init(void)
                 return 0;
         }
 
+        for (i = 0; i < MAX_NR_CON_DRIVER; i++) {
+                struct con_driver *con_driver = &registered_con_driver[i];
+
+                if (con_driver->con == NULL) {
+                        con_driver->con = conswitchp;
+                        con_driver->desc = display_desc;
+                        con_driver->flag = CON_DRIVER_FLAG_INIT;
+                        con_driver->first = 0;
+                        con_driver->last = MAX_NR_CONSOLES - 1;
+                        break;
+                }
+        }
+
+        for (i = 0; i < MAX_NR_CONSOLES; i++)
+                con_driver_map[i] = conswitchp;
+
         init_timer(&console_timer);
         console_timer.function = blank_screen_t;
         if (blankinterval) {
@@ -2656,38 +2687,53 @@ int __init vty_init(void)
 }
 
 #ifndef VT_SINGLE_DRIVER
+#include <linux/device.h>
 
-/*
- *      If we support more console drivers, this function is used
- *      when a driver wants to take over some existing consoles
- *      and become default driver for newly opened ones.
- */
+static struct class *vtconsole_class;
 
-int take_over_console(const struct consw *csw, int first, int last, int deflt)
+static int bind_con_driver(const struct consw *csw, int first, int last,
+                           int deflt)
 {
-        int i, j = -1;
-        const char *desc;
-        struct module *owner;
+        struct module *owner = csw->owner;
+        const char *desc = NULL;
+        struct con_driver *con_driver;
+        int i, j = -1, k = -1, retval = -ENODEV;
 
-        owner = csw->owner;
         if (!try_module_get(owner))
                 return -ENODEV;
 
         acquire_console_sem();
 
-        desc = csw->con_startup();
-        if (!desc) {
-                release_console_sem();
-                module_put(owner);
-                return -ENODEV;
+        /* check if driver is registered */
+        for (i = 0; i < MAX_NR_CON_DRIVER; i++) {
+                con_driver = &registered_con_driver[i];
+
+                if (con_driver->con == csw) {
+                        desc = con_driver->desc;
+                        retval = 0;
+                        break;
+                }
+        }
+
+        if (retval)
+                goto err;
+
+        if (!(con_driver->flag & CON_DRIVER_FLAG_INIT)) {
+                csw->con_startup();
+                con_driver->flag |= CON_DRIVER_FLAG_INIT;
         }
+
         if (deflt) {
                 if (conswitchp)
                         module_put(conswitchp->owner);
+
                 __module_get(owner);
                 conswitchp = csw;
         }
 
+        first = max(first, con_driver->first);
+        last = min(last, con_driver->last);
+
         for (i = first; i <= last; i++) {
                 int old_was_color;
                 struct vc_data *vc = vc_cons[i].d;
@@ -2701,15 +2747,17 @@ int take_over_console(const struct consw *csw, int first, int last, int deflt)
                         continue;
 
                 j = i;
-                if (CON_IS_VISIBLE(vc))
+
+                if (CON_IS_VISIBLE(vc)) {
+                        k = i;
                         save_screen(vc);
+                }
+
                 old_was_color = vc->vc_can_do_color;
                 vc->vc_sw->con_deinit(vc);
                 vc->vc_origin = (unsigned long)vc->vc_screenbuf;
-                vc->vc_visible_origin = vc->vc_origin;
-                vc->vc_scr_end = vc->vc_origin + vc->vc_screenbuf_size;
-                vc->vc_pos = vc->vc_origin + vc->vc_size_row * vc->vc_y + 2 * vc->vc_x;
                 visual_init(vc, i, 0);
+                set_origin(vc);
                 update_attr(vc);
 
                 /* If the console changed between mono <-> color, then
@@ -2718,36 +2766,506 @@ int take_over_console(const struct consw *csw, int first, int last, int deflt)
                  */
                 if (old_was_color != vc->vc_can_do_color)
                         clear_buffer_attributes(vc);
-
-                if (CON_IS_VISIBLE(vc))
-                        update_screen(vc);
         }
+
         printk("Console: switching ");
         if (!deflt)
                 printk("consoles %d-%d ", first+1, last+1);
-        if (j >= 0)
+        if (j >= 0) {
+                struct vc_data *vc = vc_cons[j].d;
+
                 printk("to %s %s %dx%d\n",
-                       vc_cons[j].d->vc_can_do_color ? "colour" : "mono",
-                       desc, vc_cons[j].d->vc_cols, vc_cons[j].d->vc_rows);
-        else
+                       vc->vc_can_do_color ? "colour" : "mono",
+                       desc, vc->vc_cols, vc->vc_rows);
+
+                if (k >= 0) {
+                        vc = vc_cons[k].d;
+                        update_screen(vc);
+                }
+        } else
                 printk("to %s\n", desc);
 
+        retval = 0;
+err:
         release_console_sem();
+        module_put(owner);
+        return retval;
+};
+
+#ifdef CONFIG_VT_HW_CONSOLE_BINDING
+static int con_is_graphics(const struct consw *csw, int first, int last)
+{
+        int i, retval = 0;
+
+        for (i = first; i <= last; i++) {
+                struct vc_data *vc = vc_cons[i].d;
+
+                if (vc && vc->vc_mode == KD_GRAPHICS) {
+                        retval = 1;
+                        break;
+                }
+        }
+
+        return retval;
+}
+
+static int unbind_con_driver(const struct consw *csw, int first, int last,
+                             int deflt)
+{
+        struct module *owner = csw->owner;
+        const struct consw *defcsw = NULL;
+        struct con_driver *con_driver = NULL, *con_back = NULL;
+        int i, retval = -ENODEV;
+
+        if (!try_module_get(owner))
+                return -ENODEV;
+
+        acquire_console_sem();
+
+        /* check if driver is registered and if it is unbindable */
+        for (i = 0; i < MAX_NR_CON_DRIVER; i++) {
+                con_driver = &registered_con_driver[i];
+
+                if (con_driver->con == csw &&
+                    con_driver->flag & CON_DRIVER_FLAG_MODULE) {
+                        retval = 0;
+                        break;
+                }
+        }
+
+        if (retval) {
+                release_console_sem();
+                goto err;
+        }
+
+        retval = -ENODEV;
+
+        /* check if backup driver exists */
+        for (i = 0; i < MAX_NR_CON_DRIVER; i++) {
+                con_back = &registered_con_driver[i];
+
+                if (con_back->con &&
+                    !(con_back->flag & CON_DRIVER_FLAG_MODULE)) {
+                        defcsw = con_back->con;
+                        retval = 0;
+                        break;
+                }
+        }
+
+        if (retval) {
+                release_console_sem();
+                goto err;
+        }
+
+        if (!con_is_bound(csw)) {
+                release_console_sem();
+                goto err;
+        }
+
+        first = max(first, con_driver->first);
+        last = min(last, con_driver->last);
+
+        for (i = first; i <= last; i++) {
+                if (con_driver_map[i] == csw) {
+                        module_put(csw->owner);
+                        con_driver_map[i] = NULL;
+                }
+        }
+
+        if (!con_is_bound(defcsw)) {
+                const struct consw *defconsw = conswitchp;
+
+                defcsw->con_startup();
+                con_back->flag |= CON_DRIVER_FLAG_INIT;
+                /*
+                 * vgacon may change the default driver to point
+                 * to dummycon, we restore it here...
+                 */
+                conswitchp = defconsw;
+        }
+
+        if (!con_is_bound(csw))
+                con_driver->flag &= ~CON_DRIVER_FLAG_INIT;
 
+        release_console_sem();
+        /* ignore return value, binding should not fail */
+        bind_con_driver(defcsw, first, last, deflt);
+err:
         module_put(owner);
+        return retval;
+
+}
+
+static int vt_bind(struct con_driver *con)
+{
+        const struct consw *defcsw = NULL, *csw = NULL;
+        int i, more = 1, first = -1, last = -1, deflt = 0;
+
+        if (!con->con || !(con->flag & CON_DRIVER_FLAG_MODULE) ||
+            con_is_graphics(con->con, con->first, con->last))
+                goto err;
+
+        csw = con->con;
+
+        for (i = 0; i < MAX_NR_CON_DRIVER; i++) {
+                struct con_driver *con = &registered_con_driver[i];
+
+                if (con->con && !(con->flag & CON_DRIVER_FLAG_MODULE)) {
+                        defcsw = con->con;
+                        break;
+                }
+        }
+
+        if (!defcsw)
+                goto err;
+
+        while (more) {
+                more = 0;
+
+                for (i = con->first; i <= con->last; i++) {
+                        if (con_driver_map[i] == defcsw) {
+                                if (first == -1)
+                                        first = i;
+                                last = i;
+                                more = 1;
+                        } else if (first != -1)
+                                break;
+                }
+
+                if (first == 0 && last == MAX_NR_CONSOLES -1)
+                        deflt = 1;
+
+                if (first != -1)
+                        bind_con_driver(csw, first, last, deflt);
+
+                first = -1;
+                last = -1;
+                deflt = 0;
+        }
+
+err:
         return 0;
 }
 
-void give_up_console(const struct consw *csw)
+static int vt_unbind(struct con_driver *con)
+{
+        const struct consw *csw = NULL;
+        int i, more = 1, first = -1, last = -1, deflt = 0;
+
+        if (!con->con || !(con->flag & CON_DRIVER_FLAG_MODULE) ||
+            con_is_graphics(con->con, con->first, con->last))
+                goto err;
+
+        csw = con->con;
+
+        while (more) {
+                more = 0;
+
+                for (i = con->first; i <= con->last; i++) {
+                        if (con_driver_map[i] == csw) {
+                                if (first == -1)
+                                        first = i;
+                                last = i;
+                                more = 1;
+                        } else if (first != -1)
+                                break;
+                }
+
+                if (first == 0 && last == MAX_NR_CONSOLES -1)
+                        deflt = 1;
+
+                if (first != -1)
+                        unbind_con_driver(csw, first, last, deflt);
+
+                first = -1;
+                last = -1;
+                deflt = 0;
+        }
+
+err:
+        return 0;
+}
+#else
+static inline int vt_bind(struct con_driver *con)
+{
+        return 0;
+}
+static inline int vt_unbind(struct con_driver *con)
+{
+        return 0;
+}
+#endif /* CONFIG_VT_HW_CONSOLE_BINDING */
+
+static ssize_t store_bind(struct class_device *class_device,
+                          const char *buf, size_t count)
+{
+        struct con_driver *con = class_get_devdata(class_device);
+        int bind = simple_strtoul(buf, NULL, 0);
+
+        if (bind)
+                vt_bind(con);
+        else
+                vt_unbind(con);
+
+        return count;
+}
+
+static ssize_t show_bind(struct class_device *class_device, char *buf)
+{
+        struct con_driver *con = class_get_devdata(class_device);
+        int bind = con_is_bound(con->con);
+
+        return snprintf(buf, PAGE_SIZE, "%i\n", bind);
+}
+
+static ssize_t show_name(struct class_device *class_device, char *buf)
+{
+        struct con_driver *con = class_get_devdata(class_device);
+
+        return snprintf(buf, PAGE_SIZE, "%s %s\n",
+                        (con->flag & CON_DRIVER_FLAG_MODULE) ? "(M)" : "(S)",
+                         con->desc);
+
+}
+
+static struct class_device_attribute class_device_attrs[] = {
+        __ATTR(bind, S_IRUGO|S_IWUSR, show_bind, store_bind),
+        __ATTR(name, S_IRUGO, show_name, NULL),
+};
+
+static int vtconsole_init_class_device(struct con_driver *con)
+{
+        int i;
+
+        class_set_devdata(con->class_dev, con);
+        for (i = 0; i < ARRAY_SIZE(class_device_attrs); i++)
+                class_device_create_file(con->class_dev,
+                                         &class_device_attrs[i]);
+
+        return 0;
+}
+
+static void vtconsole_deinit_class_device(struct con_driver *con)
 {
         int i;
 
-        for(i = 0; i < MAX_NR_CONSOLES; i++)
+        for (i = 0; i < ARRAY_SIZE(class_device_attrs); i++)
+                class_device_remove_file(con->class_dev,
+                                         &class_device_attrs[i]);
+}
+
+/**
+ * con_is_bound - checks if driver is bound to the console
+ * @csw: console driver
+ *
+ * RETURNS: zero if unbound, nonzero if bound
+ *
+ * Drivers can call this and if zero, they should release
+ * all resources allocated on con_startup()
+ */
+int con_is_bound(const struct consw *csw)
+{
+        int i, bound = 0;
+
+        for (i = 0; i < MAX_NR_CONSOLES; i++) {
                 if (con_driver_map[i] == csw) {
-                        module_put(csw->owner);
-                        con_driver_map[i] = NULL;
+                        bound = 1;
+                        break;
+                }
+        }
+
+        return bound;
+}
+EXPORT_SYMBOL(con_is_bound);
+
+/**
+ * register_con_driver - register console driver to console layer
+ * @csw: console driver
+ * @first: the first console to take over, minimum value is 0
+ * @last: the last console to take over, maximum value is MAX_NR_CONSOLES -1
+ *
+ * DESCRIPTION: This function registers a console driver which can later
+ * bind to a range of consoles specified by @first and @last. It will
+ * also initialize the console driver by calling con_startup().
+ */
+int register_con_driver(const struct consw *csw, int first, int last)
+{
+        struct module *owner = csw->owner;
+        struct con_driver *con_driver;
+        const char *desc;
+        int i, retval = 0;
+
+        if (!try_module_get(owner))
+                return -ENODEV;
+
+        acquire_console_sem();
+
+        for (i = 0; i < MAX_NR_CON_DRIVER; i++) {
+                con_driver = &registered_con_driver[i];
+
+                /* already registered */
+                if (con_driver->con == csw)
+                        retval = -EINVAL;
+        }
+
+        if (retval)
+                goto err;
+
+        desc = csw->con_startup();
+
+        if (!desc)
+                goto err;
+
+        retval = -EINVAL;
+
+        for (i = 0; i < MAX_NR_CON_DRIVER; i++) {
+                con_driver = &registered_con_driver[i];
+
+                if (con_driver->con == NULL) {
+                        con_driver->con = csw;
+                        con_driver->desc = desc;
+                        con_driver->node = i;
+                        con_driver->flag = CON_DRIVER_FLAG_MODULE |
+                                           CON_DRIVER_FLAG_INIT;
+                        con_driver->first = first;
+                        con_driver->last = last;
+                        retval = 0;
+                        break;
+                }
+        }
+
+        if (retval)
+                goto err;
+
+        con_driver->class_dev = class_device_create(vtconsole_class, NULL,
+                                                    MKDEV(0, con_driver->node),
+                                                    NULL, "vtcon%i",
+                                                    con_driver->node);
+
+        if (IS_ERR(con_driver->class_dev)) {
+                printk(KERN_WARNING "Unable to create class_device for %s; "
+                       "errno = %ld\n", con_driver->desc,
+                       PTR_ERR(con_driver->class_dev));
+                con_driver->class_dev = NULL;
+        } else {
+                vtconsole_init_class_device(con_driver);
+        }
+err:
+        release_console_sem();
+        module_put(owner);
+        return retval;
+}
+EXPORT_SYMBOL(register_con_driver);
+
+/**
+ * unregister_con_driver - unregister console driver from console layer
+ * @csw: console driver
+ *
+ * DESCRIPTION: All drivers that registers to the console layer must
+ * call this function upon exit, or if the console driver is in a state
+ * where it won't be able to handle console services, such as the
+ * framebuffer console without loaded framebuffer drivers.
+ *
+ * The driver must unbind first prior to unregistration.
+ */
+int unregister_con_driver(const struct consw *csw)
+{
+        int i, retval = -ENODEV;
+
+        acquire_console_sem();
+
+        /* cannot unregister a bound driver */
+        if (con_is_bound(csw))
+                goto err;
+
+        for (i = 0; i < MAX_NR_CON_DRIVER; i++) {
+                struct con_driver *con_driver = &registered_con_driver[i];
+
+                if (con_driver->con == csw &&
+                    con_driver->flag & CON_DRIVER_FLAG_MODULE) {
+                        vtconsole_deinit_class_device(con_driver);
+                        class_device_destroy(vtconsole_class,
+                                             MKDEV(0, con_driver->node));
+                        con_driver->con = NULL;
+                        con_driver->desc = NULL;
+                        con_driver->class_dev = NULL;
+                        con_driver->node = 0;
+                        con_driver->flag = 0;
+                        con_driver->first = 0;
+                        con_driver->last = 0;
+                        retval = 0;
+                        break;
+                }
+        }
+err:
+        release_console_sem();
+        return retval;
+}
+EXPORT_SYMBOL(unregister_con_driver);
+
+/*
+ *      If we support more console drivers, this function is used
+ *      when a driver wants to take over some existing consoles
+ *      and become default driver for newly opened ones.
+ *
+ *      take_over_console is basically a register followed by unbind
+ */
+int take_over_console(const struct consw *csw, int first, int last, int deflt)
+{
+        int err;
+
+        err = register_con_driver(csw, first, last);
+
+        if (!err)
+                bind_con_driver(csw, first, last, deflt);
+
+        return err;
+}
+
+/*
+ * give_up_console is a wrapper to unregister_con_driver. It will only
+ * work if driver is fully unbound.
+ */
+void give_up_console(const struct consw *csw)
+{
+        unregister_con_driver(csw);
+}
+
+static int __init vtconsole_class_init(void)
+{
+        int i;
+
+        vtconsole_class = class_create(THIS_MODULE, "vtconsole");
+        if (IS_ERR(vtconsole_class)) {
+                printk(KERN_WARNING "Unable to create vt console class; "
+                       "errno = %ld\n", PTR_ERR(vtconsole_class));
+                vtconsole_class = NULL;
+        }
+
+        /* Add system drivers to sysfs */
+        for (i = 0; i < MAX_NR_CON_DRIVER; i++) {
+                struct con_driver *con = &registered_con_driver[i];
+
+                if (con->con && !con->class_dev) {
+                        con->class_dev =
+                                class_device_create(vtconsole_class, NULL,
+                                                    MKDEV(0, con->node), NULL,
+                                                    "vtcon%i", con->node);
+
+                        if (IS_ERR(con->class_dev)) {
+                                printk(KERN_WARNING "Unable to create "
+                                       "class_device for %s; errno = %ld\n",
+                                       con->desc, PTR_ERR(con->class_dev));
+                                con->class_dev = NULL;
+                        } else {
+                                vtconsole_init_class_device(con);
+                        }
                 }
+        }
+
+        return 0;
 }
+postcore_initcall(vtconsole_class_init);
 
 #endif
 
diff --git a/drivers/char/watchdog/at91_wdt.c b/drivers/char/watchdog/at91_wdt.c
index ac83bc4b019a..00080655533d 100644
--- a/drivers/char/watchdog/at91_wdt.c
+++ b/drivers/char/watchdog/at91_wdt.c
@@ -17,14 +17,15 @@
 #include <linux/miscdevice.h>
 #include <linux/module.h>
 #include <linux/moduleparam.h>
+#include <linux/platform_device.h>
 #include <linux/types.h>
 #include <linux/watchdog.h>
 #include <asm/bitops.h>
 #include <asm/uaccess.h>
 
 
-#define WDT_DEFAULT_TIME        5       /* 5 seconds */
-#define WDT_MAX_TIME            256     /* 256 seconds */
+#define WDT_DEFAULT_TIME        5       /* seconds */
+#define WDT_MAX_TIME            256     /* seconds */
 
 static int wdt_time = WDT_DEFAULT_TIME;
 static int nowayout = WATCHDOG_NOWAYOUT;
@@ -32,8 +33,10 @@ static int nowayout = WATCHDOG_NOWAYOUT;
 module_param(wdt_time, int, 0);
 MODULE_PARM_DESC(wdt_time, "Watchdog time in seconds. (default="__MODULE_STRING(WDT_DEFAULT_TIME) ")");
 
+#ifdef CONFIG_WATCHDOG_NOWAYOUT
 module_param(nowayout, int, 0);
 MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started (default=" __MODULE_STRING(WATCHDOG_NOWAYOUT) ")");
+#endif
 
 
 static unsigned long at91wdt_busy;
@@ -138,7 +141,7 @@ static int at91_wdt_ioctl(struct inode *inode, struct file *file,
                 case WDIOC_SETTIMEOUT:
                         if (get_user(new_value, p))
                                 return -EFAULT;
-                                
+
                         if (at91_wdt_settimeout(new_value))
                                 return -EINVAL;
 
@@ -196,27 +199,84 @@ static struct miscdevice at91wdt_miscdev = {
         .fops           = &at91wdt_fops,
 };
 
-static int __init at91_wdt_init(void)
+static int __init at91wdt_probe(struct platform_device *pdev)
 {
         int res;
 
-        /* Check that the heartbeat value is within range; if not reset to the default */
-        if (at91_wdt_settimeout(wdt_time)) {
-                at91_wdt_settimeout(WDT_DEFAULT_TIME);
-                printk(KERN_INFO "at91_wdt: wdt_time value must be 1 <= wdt_time <= 256, using %d\n", wdt_time);
-        }
+        if (at91wdt_miscdev.dev)
+                return -EBUSY;
+        at91wdt_miscdev.dev = &pdev->dev;
 
         res = misc_register(&at91wdt_miscdev);
         if (res)
                 return res;
 
-        printk("AT91 Watchdog Timer enabled (%d seconds, nowayout=%d)\n", wdt_time, nowayout);
+        printk("AT91 Watchdog Timer enabled (%d seconds%s)\n", wdt_time, nowayout ? ", nowayout" : "");
         return 0;
 }
 
+static int __exit at91wdt_remove(struct platform_device *pdev)
+{
+        int res;
+
+        res = misc_deregister(&at91wdt_miscdev);
+        if (!res)
+                at91wdt_miscdev.dev = NULL;
+
+        return res;
+}
+
+static void at91wdt_shutdown(struct platform_device *pdev)
+{
+        at91_wdt_stop();
+}
+
+#ifdef CONFIG_PM
+
+static int at91wdt_suspend(struct platform_device *pdev, pm_message_t message)
+{
+        at91_wdt_stop();
+        return 0;
+}
+
+static int at91wdt_resume(struct platform_device *pdev)
+{
+        if (at91wdt_busy)
+                at91_wdt_start();
+                return 0;
+}
+
+#else
+#define at91wdt_suspend NULL
+#define at91wdt_resume  NULL
+#endif
+
+static struct platform_driver at91wdt_driver = {
+        .probe          = at91wdt_probe,
+        .remove         = __exit_p(at91wdt_remove),
+        .shutdown       = at91wdt_shutdown,
+        .suspend        = at91wdt_suspend,
+        .resume         = at91wdt_resume,
+        .driver         = {
+                .name   = "at91_wdt",
+                .owner  = THIS_MODULE,
+        },
+};
+
+static int __init at91_wdt_init(void)
+{
+        /* Check that the heartbeat value is within range; if not reset to the default */
+        if (at91_wdt_settimeout(wdt_time)) {
+                at91_wdt_settimeout(WDT_DEFAULT_TIME);
+                pr_info("at91_wdt: wdt_time value must be 1 <= wdt_time <= 256, using %d\n", wdt_time);
+        }
+
+        return platform_driver_register(&at91wdt_driver);
+}
+
 static void __exit at91_wdt_exit(void)
 {
-        misc_deregister(&at91wdt_miscdev);
+        platform_driver_unregister(&at91wdt_driver);
 }
 
 module_init(at91_wdt_init);
diff --git a/drivers/char/watchdog/i8xx_tco.c b/drivers/char/watchdog/i8xx_tco.c
index fa2ba9ebe42a..bfbdbbf3c2f2 100644
--- a/drivers/char/watchdog/i8xx_tco.c
+++ b/drivers/char/watchdog/i8xx_tco.c
@@ -205,6 +205,23 @@ static int tco_timer_set_heartbeat (int t)
         return 0;
 }
 
+static int tco_timer_get_timeleft (int *time_left)
+{
+        unsigned char val;
+
+        spin_lock(&tco_lock);
+
+        /* read the TCO Timer */
+        val = inb (TCO1_RLD);
+        val &= 0x3f;
+
+        spin_unlock(&tco_lock);
+
+        *time_left = (int)((val * 6) / 10);
+
+        return 0;
+}
+
 /*
  *      /dev/watchdog handling
  */
@@ -272,6 +289,7 @@ static int i8xx_tco_ioctl (struct inode *inode, struct file *file,
 {
         int new_options, retval = -EINVAL;
         int new_heartbeat;
+        int time_left;
         void __user *argp = (void __user *)arg;
         int __user *p = argp;
         static struct watchdog_info ident = {
@@ -320,7 +338,7 @@ static int i8xx_tco_ioctl (struct inode *inode, struct file *file,
                                 return -EFAULT;
 
                         if (tco_timer_set_heartbeat(new_heartbeat))
-                            return -EINVAL;
+                                return -EINVAL;
 
                         tco_timer_keepalive ();
                         /* Fall */
@@ -329,6 +347,14 @@ static int i8xx_tco_ioctl (struct inode *inode, struct file *file,
                 case WDIOC_GETTIMEOUT:
                         return put_user(heartbeat, p);
 
+                case WDIOC_GETTIMELEFT:
+                {
+                        if (tco_timer_get_timeleft(&time_left))
+                                return -EINVAL;
+
+                        return put_user(time_left, p);
+                }
+
                 default:
                         return -ENOIOCTLCMD;
         }
diff --git a/drivers/char/watchdog/pcwd_pci.c b/drivers/char/watchdog/pcwd_pci.c
index 2451edbefece..1f40ecefbf72 100644
--- a/drivers/char/watchdog/pcwd_pci.c
+++ b/drivers/char/watchdog/pcwd_pci.c
@@ -21,7 +21,7 @@
  */
 
 /*
- *      A bells and whistles driver is available from: 
+ *      A bells and whistles driver is available from:
  *      http://www.kernel.org/pub/linux/kernel/people/wim/pcwd/pcwd_pci/
  *
  *      More info available at http://www.berkprod.com/ or http://www.pcwatchdog.com/
@@ -390,6 +390,24 @@ static int pcipcwd_get_temperature(int *temperature)
         return 0;
 }
 
+static int pcipcwd_get_timeleft(int *time_left)
+{
+        int msb;
+        int lsb;
+
+        /* Read the time that's left before rebooting */
+        /* Note: if the board is not yet armed then we will read 0xFFFF */
+        send_command(CMD_READ_WATCHDOG_TIMEOUT, &msb, &lsb);
+
+        *time_left = (msb << 8) + lsb;
+
+        if (debug >= VERBOSE)
+                printk(KERN_DEBUG PFX "Time left before next reboot: %d\n",
+                       *time_left);
+
+        return 0;
+}
+
 /*
  *      /dev/watchdog handling
  */
@@ -512,6 +530,16 @@ static int pcipcwd_ioctl(struct inode *inode, struct file *file,
                 case WDIOC_GETTIMEOUT:
                         return put_user(heartbeat, p);
 
+                case WDIOC_GETTIMELEFT:
+                {
+                        int time_left;
+
+                        if (pcipcwd_get_timeleft(&time_left))
+                                return -EFAULT;
+
+                        return put_user(time_left, p);
+                }
+
                 default:
                         return -ENOIOCTLCMD;
         }
diff --git a/drivers/char/watchdog/pcwd_usb.c b/drivers/char/watchdog/pcwd_usb.c
index 3fdfda9324fa..0d072bed501d 100644
--- a/drivers/char/watchdog/pcwd_usb.c
+++ b/drivers/char/watchdog/pcwd_usb.c
@@ -317,6 +317,19 @@ static int usb_pcwd_get_temperature(struct usb_pcwd_private *usb_pcwd, int *temp
         return 0;
 }
 
+static int usb_pcwd_get_timeleft(struct usb_pcwd_private *usb_pcwd, int *time_left)
+{
+        unsigned char msb, lsb;
+
+        /* Read the time that's left before rebooting */
+        /* Note: if the board is not yet armed then we will read 0xFFFF */
+        usb_pcwd_send_command(usb_pcwd, CMD_READ_WATCHDOG_TIMEOUT, &msb, &lsb);
+
+        *time_left = (msb << 8) + lsb;
+
+        return 0;
+}
+
 /*
  *      /dev/watchdog handling
  */
@@ -422,6 +435,16 @@ static int usb_pcwd_ioctl(struct inode *inode, struct file *file,
                 case WDIOC_GETTIMEOUT:
                         return put_user(heartbeat, p);
 
+                case WDIOC_GETTIMELEFT:
+                {
+                        int time_left;
+
+                        if (usb_pcwd_get_timeleft(usb_pcwd_device, &time_left))
+                                return -EFAULT;
+
+                        return put_user(time_left, p);
+                }
+
                 default:
                         return -ENOIOCTLCMD;
         }