1 files changed, 8 insertions, 6 deletions

diff --git a/drivers/char/mspec.c b/drivers/char/mspec.c
index ecb89d798e35..25d139c9dbed 100644
--- a/drivers/char/mspec.c
+++ b/drivers/char/mspec.c
@@ -271,14 +271,13 @@ mspec_mmap(struct file *file, struct vm_area_struct *vma,
         pages = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
         vdata_size = sizeof(struct vma_data) + pages * sizeof(long);
         if (vdata_size <= PAGE_SIZE)
-                vdata = kmalloc(vdata_size, GFP_KERNEL);
+                vdata = kzalloc(vdata_size, GFP_KERNEL);
         else {
-                vdata = vmalloc(vdata_size);
+                vdata = vzalloc(vdata_size);
                 flags = VMD_VMALLOCED;
         }
         if (!vdata)
                 return -ENOMEM;
-        memset(vdata, 0, vdata_size);
 
         vdata->vm_start = vma->vm_start;
         vdata->vm_end = vma->vm_end;
@@ -316,7 +315,8 @@ uncached_mmap(struct file *file, struct vm_area_struct *vma)
 
 static const struct file_operations fetchop_fops = {
         .owner = THIS_MODULE,
-        .mmap = fetchop_mmap
+        .mmap = fetchop_mmap,
+        .llseek = noop_llseek,
 };
 
 static struct miscdevice fetchop_miscdev = {
@@ -327,7 +327,8 @@ static struct miscdevice fetchop_miscdev = {
 
 static const struct file_operations cached_fops = {
         .owner = THIS_MODULE,
-        .mmap = cached_mmap
+        .mmap = cached_mmap,
+        .llseek = noop_llseek,
 };
 
 static struct miscdevice cached_miscdev = {
@@ -338,7 +339,8 @@ static struct miscdevice cached_miscdev = {
 
 static const struct file_operations uncached_fops = {
         .owner = THIS_MODULE,
-        .mmap = uncached_mmap
+        .mmap = uncached_mmap,
+        .llseek = noop_llseek,
 };
 
 static struct miscdevice uncached_miscdev = {