6 files changed, 263 insertions, 136 deletions

diff --git a/drivers/base/dma-buf.c b/drivers/base/dma-buf.c
index e38ad243b4bb..07cbbc6fddb4 100644
--- a/drivers/base/dma-buf.c
+++ b/drivers/base/dma-buf.c
@@ -71,7 +71,7 @@ static inline int is_dma_buf_file(struct file *file)
  * ops, or error in allocating struct dma_buf, will return negative error.
  *
  */
-struct dma_buf *dma_buf_export(void *priv, struct dma_buf_ops *ops,
+struct dma_buf *dma_buf_export(void *priv, const struct dma_buf_ops *ops,
                                 size_t size, int flags)
 {
         struct dma_buf *dmabuf;
@@ -80,7 +80,9 @@ struct dma_buf *dma_buf_export(void *priv, struct dma_buf_ops *ops,
         if (WARN_ON(!priv || !ops
                           || !ops->map_dma_buf
                           || !ops->unmap_dma_buf
-                          || !ops->release)) {
+                          || !ops->release
+                          || !ops->kmap_atomic
+                          || !ops->kmap)) {
                 return ERR_PTR(-EINVAL);
         }
 
@@ -107,17 +109,18 @@ EXPORT_SYMBOL_GPL(dma_buf_export);
 /**
  * dma_buf_fd - returns a file descriptor for the given dma_buf
  * @dmabuf:     [in]    pointer to dma_buf for which fd is required.
+ * @flags:      [in]    flags to give to fd
  *
  * On success, returns an associated 'fd'. Else, returns error.
  */
-int dma_buf_fd(struct dma_buf *dmabuf)
+int dma_buf_fd(struct dma_buf *dmabuf, int flags)
 {
         int error, fd;
 
         if (!dmabuf || !dmabuf->file)
                 return -EINVAL;
 
-        error = get_unused_fd();
+        error = get_unused_fd_flags(flags);
         if (error < 0)
                 return error;
         fd = error;
@@ -185,17 +188,18 @@ struct dma_buf_attachment *dma_buf_attach(struct dma_buf *dmabuf,
         struct dma_buf_attachment *attach;
         int ret;
 
-        if (WARN_ON(!dmabuf || !dev || !dmabuf->ops))
+        if (WARN_ON(!dmabuf || !dev))
                 return ERR_PTR(-EINVAL);
 
         attach = kzalloc(sizeof(struct dma_buf_attachment), GFP_KERNEL);
         if (attach == NULL)
-                goto err_alloc;
-
-        mutex_lock(&dmabuf->lock);
+                return ERR_PTR(-ENOMEM);
 
         attach->dev = dev;
         attach->dmabuf = dmabuf;
+
+        mutex_lock(&dmabuf->lock);
+
         if (dmabuf->ops->attach) {
                 ret = dmabuf->ops->attach(dmabuf, dev, attach);
                 if (ret)
@@ -206,8 +210,6 @@ struct dma_buf_attachment *dma_buf_attach(struct dma_buf *dmabuf,
         mutex_unlock(&dmabuf->lock);
         return attach;
 
-err_alloc:
-        return ERR_PTR(-ENOMEM);
 err_attach:
         kfree(attach);
         mutex_unlock(&dmabuf->lock);
@@ -224,7 +226,7 @@ EXPORT_SYMBOL_GPL(dma_buf_attach);
  */
 void dma_buf_detach(struct dma_buf *dmabuf, struct dma_buf_attachment *attach)
 {
-        if (WARN_ON(!dmabuf || !attach || !dmabuf->ops))
+        if (WARN_ON(!dmabuf || !attach))
                 return;
 
         mutex_lock(&dmabuf->lock);
@@ -255,13 +257,10 @@ struct sg_table *dma_buf_map_attachment(struct dma_buf_attachment *attach,
 
         might_sleep();
 
-        if (WARN_ON(!attach || !attach->dmabuf || !attach->dmabuf->ops))
+        if (WARN_ON(!attach || !attach->dmabuf))
                 return ERR_PTR(-EINVAL);
 
-        mutex_lock(&attach->dmabuf->lock);
-        if (attach->dmabuf->ops->map_dma_buf)
-                sg_table = attach->dmabuf->ops->map_dma_buf(attach, direction);
-        mutex_unlock(&attach->dmabuf->lock);
+        sg_table = attach->dmabuf->ops->map_dma_buf(attach, direction);
 
         return sg_table;
 }
@@ -273,19 +272,137 @@ EXPORT_SYMBOL_GPL(dma_buf_map_attachment);
  * dma_buf_ops.
  * @attach:     [in]    attachment to unmap buffer from
  * @sg_table:   [in]    scatterlist info of the buffer to unmap
+ * @direction:  [in]    direction of DMA transfer
  *
  */
 void dma_buf_unmap_attachment(struct dma_buf_attachment *attach,
-                                struct sg_table *sg_table)
+                                struct sg_table *sg_table,
+                                enum dma_data_direction direction)
 {
-        if (WARN_ON(!attach || !attach->dmabuf || !sg_table
-                            || !attach->dmabuf->ops))
+        if (WARN_ON(!attach || !attach->dmabuf || !sg_table))
                 return;
 
-        mutex_lock(&attach->dmabuf->lock);
-        if (attach->dmabuf->ops->unmap_dma_buf)
-                attach->dmabuf->ops->unmap_dma_buf(attach, sg_table);
-        mutex_unlock(&attach->dmabuf->lock);
-
+        attach->dmabuf->ops->unmap_dma_buf(attach, sg_table,
+                                                direction);
 }
 EXPORT_SYMBOL_GPL(dma_buf_unmap_attachment);
+
+
+/**
+ * dma_buf_begin_cpu_access - Must be called before accessing a dma_buf from the
+ * cpu in the kernel context. Calls begin_cpu_access to allow exporter-specific
+ * preparations. Coherency is only guaranteed in the specified range for the
+ * specified access direction.
+ * @dma_buf:    [in]    buffer to prepare cpu access for.
+ * @start:      [in]    start of range for cpu access.
+ * @len:        [in]    length of range for cpu access.
+ * @direction:  [in]    length of range for cpu access.
+ *
+ * Can return negative error values, returns 0 on success.
+ */
+int dma_buf_begin_cpu_access(struct dma_buf *dmabuf, size_t start, size_t len,
+                             enum dma_data_direction direction)
+{
+        int ret = 0;
+
+        if (WARN_ON(!dmabuf))
+                return -EINVAL;
+
+        if (dmabuf->ops->begin_cpu_access)
+                ret = dmabuf->ops->begin_cpu_access(dmabuf, start, len, direction);
+
+        return ret;
+}
+EXPORT_SYMBOL_GPL(dma_buf_begin_cpu_access);
+
+/**
+ * dma_buf_end_cpu_access - Must be called after accessing a dma_buf from the
+ * cpu in the kernel context. Calls end_cpu_access to allow exporter-specific
+ * actions. Coherency is only guaranteed in the specified range for the
+ * specified access direction.
+ * @dma_buf:    [in]    buffer to complete cpu access for.
+ * @start:      [in]    start of range for cpu access.
+ * @len:        [in]    length of range for cpu access.
+ * @direction:  [in]    length of range for cpu access.
+ *
+ * This call must always succeed.
+ */
+void dma_buf_end_cpu_access(struct dma_buf *dmabuf, size_t start, size_t len,
+                            enum dma_data_direction direction)
+{
+        WARN_ON(!dmabuf);
+
+        if (dmabuf->ops->end_cpu_access)
+                dmabuf->ops->end_cpu_access(dmabuf, start, len, direction);
+}
+EXPORT_SYMBOL_GPL(dma_buf_end_cpu_access);
+
+/**
+ * dma_buf_kmap_atomic - Map a page of the buffer object into kernel address
+ * space. The same restrictions as for kmap_atomic and friends apply.
+ * @dma_buf:    [in]    buffer to map page from.
+ * @page_num:   [in]    page in PAGE_SIZE units to map.
+ *
+ * This call must always succeed, any necessary preparations that might fail
+ * need to be done in begin_cpu_access.
+ */
+void *dma_buf_kmap_atomic(struct dma_buf *dmabuf, unsigned long page_num)
+{
+        WARN_ON(!dmabuf);
+
+        return dmabuf->ops->kmap_atomic(dmabuf, page_num);
+}
+EXPORT_SYMBOL_GPL(dma_buf_kmap_atomic);
+
+/**
+ * dma_buf_kunmap_atomic - Unmap a page obtained by dma_buf_kmap_atomic.
+ * @dma_buf:    [in]    buffer to unmap page from.
+ * @page_num:   [in]    page in PAGE_SIZE units to unmap.
+ * @vaddr:      [in]    kernel space pointer obtained from dma_buf_kmap_atomic.
+ *
+ * This call must always succeed.
+ */
+void dma_buf_kunmap_atomic(struct dma_buf *dmabuf, unsigned long page_num,
+                           void *vaddr)
+{
+        WARN_ON(!dmabuf);
+
+        if (dmabuf->ops->kunmap_atomic)
+                dmabuf->ops->kunmap_atomic(dmabuf, page_num, vaddr);
+}
+EXPORT_SYMBOL_GPL(dma_buf_kunmap_atomic);
+
+/**
+ * dma_buf_kmap - Map a page of the buffer object into kernel address space. The
+ * same restrictions as for kmap and friends apply.
+ * @dma_buf:    [in]    buffer to map page from.
+ * @page_num:   [in]    page in PAGE_SIZE units to map.
+ *
+ * This call must always succeed, any necessary preparations that might fail
+ * need to be done in begin_cpu_access.
+ */
+void *dma_buf_kmap(struct dma_buf *dmabuf, unsigned long page_num)
+{
+        WARN_ON(!dmabuf);
+
+        return dmabuf->ops->kmap(dmabuf, page_num);
+}
+EXPORT_SYMBOL_GPL(dma_buf_kmap);
+
+/**
+ * dma_buf_kunmap - Unmap a page obtained by dma_buf_kmap.
+ * @dma_buf:    [in]    buffer to unmap page from.
+ * @page_num:   [in]    page in PAGE_SIZE units to unmap.
+ * @vaddr:      [in]    kernel space pointer obtained from dma_buf_kmap.
+ *
+ * This call must always succeed.
+ */
+void dma_buf_kunmap(struct dma_buf *dmabuf, unsigned long page_num,
+                    void *vaddr)
+{
+        WARN_ON(!dmabuf);
+
+        if (dmabuf->ops->kunmap)
+                dmabuf->ops->kunmap(dmabuf, page_num, vaddr);
+}
+EXPORT_SYMBOL_GPL(dma_buf_kunmap);
diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
index 6c9387d646ec..5401814c874d 100644
--- a/drivers/base/firmware_class.c
+++ b/drivers/base/firmware_class.c
@@ -16,10 +16,11 @@
 #include <linux/interrupt.h>
 #include <linux/bitops.h>
 #include <linux/mutex.h>
-#include <linux/kthread.h>
+#include <linux/workqueue.h>
 #include <linux/highmem.h>
 #include <linux/firmware.h>
 #include <linux/slab.h>
+#include <linux/sched.h>
 
 #define to_dev(obj) container_of(obj, struct device, kobj)
 
@@ -81,6 +82,11 @@ enum {
 
 static int loading_timeout = 60;        /* In seconds */
 
+static inline long firmware_loading_timeout(void)
+{
+        return loading_timeout > 0 ? loading_timeout * HZ : MAX_SCHEDULE_TIMEOUT;
+}
+
 /* fw_lock could be moved to 'struct firmware_priv' but since it is just
  * guarding for corner cases a global lock should be OK */
 static DEFINE_MUTEX(fw_lock);
@@ -440,13 +446,11 @@ fw_create_instance(struct firmware *firmware, const char *fw_name,
 {
         struct firmware_priv *fw_priv;
         struct device *f_dev;
-        int error;
 
         fw_priv = kzalloc(sizeof(*fw_priv) + strlen(fw_name) + 1 , GFP_KERNEL);
         if (!fw_priv) {
                 dev_err(device, "%s: kmalloc failed\n", __func__);
-                error = -ENOMEM;
-                goto err_out;
+                return ERR_PTR(-ENOMEM);
         }
 
         fw_priv->fw = firmware;
@@ -463,98 +467,80 @@ fw_create_instance(struct firmware *firmware, const char *fw_name,
         f_dev->parent = device;
         f_dev->class = &firmware_class;
 
-        dev_set_uevent_suppress(f_dev, true);
-
-        /* Need to pin this module until class device is destroyed */
-        __module_get(THIS_MODULE);
-
-        error = device_add(f_dev);
-        if (error) {
-                dev_err(device, "%s: device_register failed\n", __func__);
-                goto err_put_dev;
-        }
-
-        error = device_create_bin_file(f_dev, &firmware_attr_data);
-        if (error) {
-                dev_err(device, "%s: sysfs_create_bin_file failed\n", __func__);
-                goto err_del_dev;
-        }
-
-        error = device_create_file(f_dev, &dev_attr_loading);
-        if (error) {
-                dev_err(device, "%s: device_create_file failed\n", __func__);
-                goto err_del_bin_attr;
-        }
-
-        if (uevent)
-                dev_set_uevent_suppress(f_dev, false);
-
         return fw_priv;
-
-err_del_bin_attr:
-        device_remove_bin_file(f_dev, &firmware_attr_data);
-err_del_dev:
-        device_del(f_dev);
-err_put_dev:
-        put_device(f_dev);
-err_out:
-        return ERR_PTR(error);
 }
 
-static void fw_destroy_instance(struct firmware_priv *fw_priv)
-{
-        struct device *f_dev = &fw_priv->dev;
-
-        device_remove_file(f_dev, &dev_attr_loading);
-        device_remove_bin_file(f_dev, &firmware_attr_data);
-        device_unregister(f_dev);
-}
-
-static int _request_firmware(const struct firmware **firmware_p,
-                             const char *name, struct device *device,
-                             bool uevent, bool nowait)
+static struct firmware_priv *
+_request_firmware_prepare(const struct firmware **firmware_p, const char *name,
+                          struct device *device, bool uevent, bool nowait)
 {
-        struct firmware_priv *fw_priv;
         struct firmware *firmware;
-        int retval = 0;
+        struct firmware_priv *fw_priv;
 
         if (!firmware_p)
-                return -EINVAL;
+                return ERR_PTR(-EINVAL);
 
         *firmware_p = firmware = kzalloc(sizeof(*firmware), GFP_KERNEL);
         if (!firmware) {
                 dev_err(device, "%s: kmalloc(struct firmware) failed\n",
                         __func__);
-                return -ENOMEM;
+                return ERR_PTR(-ENOMEM);
         }
 
         if (fw_get_builtin_firmware(firmware, name)) {
                 dev_dbg(device, "firmware: using built-in firmware %s\n", name);
-                return 0;
+                return NULL;
+        }
+
+        fw_priv = fw_create_instance(firmware, name, device, uevent, nowait);
+        if (IS_ERR(fw_priv)) {
+                release_firmware(firmware);
+                *firmware_p = NULL;
         }
+        return fw_priv;
+}
 
-        read_lock_usermodehelper();
+static void _request_firmware_cleanup(const struct firmware **firmware_p)
+{
+        release_firmware(*firmware_p);
+        *firmware_p = NULL;
+}
 
-        if (WARN_ON(usermodehelper_is_disabled())) {
-                dev_err(device, "firmware: %s will not be loaded\n", name);
-                retval = -EBUSY;
-                goto out;
+static int _request_firmware_load(struct firmware_priv *fw_priv, bool uevent,
+                                  long timeout)
+{
+        int retval = 0;
+        struct device *f_dev = &fw_priv->dev;
+
+        dev_set_uevent_suppress(f_dev, true);
+
+        /* Need to pin this module until class device is destroyed */
+        __module_get(THIS_MODULE);
+
+        retval = device_add(f_dev);
+        if (retval) {
+                dev_err(f_dev, "%s: device_register failed\n", __func__);
+                goto err_put_dev;
         }
 
-        if (uevent)
-                dev_dbg(device, "firmware: requesting %s\n", name);
+        retval = device_create_bin_file(f_dev, &firmware_attr_data);
+        if (retval) {
+                dev_err(f_dev, "%s: sysfs_create_bin_file failed\n", __func__);
+                goto err_del_dev;
+        }
 
-        fw_priv = fw_create_instance(firmware, name, device, uevent, nowait);
-        if (IS_ERR(fw_priv)) {
-                retval = PTR_ERR(fw_priv);
-                goto out;
+        retval = device_create_file(f_dev, &dev_attr_loading);
+        if (retval) {
+                dev_err(f_dev, "%s: device_create_file failed\n", __func__);
+                goto err_del_bin_attr;
         }
 
         if (uevent) {
-                if (loading_timeout > 0)
+                dev_set_uevent_suppress(f_dev, false);
+                dev_dbg(f_dev, "firmware: requesting %s\n", fw_priv->fw_id);
+                if (timeout != MAX_SCHEDULE_TIMEOUT)
                         mod_timer(&fw_priv->timeout,
-                                  round_jiffies_up(jiffies +
-                                                   loading_timeout * HZ));
+                                  round_jiffies_up(jiffies + timeout));
 
                 kobject_uevent(&fw_priv->dev.kobj, KOBJ_ADD);
         }
@@ -570,16 +556,13 @@ static int _request_firmware(const struct firmware **firmware_p,
         fw_priv->fw = NULL;
         mutex_unlock(&fw_lock);
 
-        fw_destroy_instance(fw_priv);
-
-out:
-        read_unlock_usermodehelper();
-
-        if (retval) {
-                release_firmware(firmware);
-                *firmware_p = NULL;
-        }
-
+        device_remove_file(f_dev, &dev_attr_loading);
+err_del_bin_attr:
+        device_remove_bin_file(f_dev, &firmware_attr_data);
+err_del_dev:
+        device_del(f_dev);
+err_put_dev:
+        put_device(f_dev);
         return retval;
 }
 
@@ -602,7 +585,26 @@ int
 request_firmware(const struct firmware **firmware_p, const char *name,
                  struct device *device)
 {
-        return _request_firmware(firmware_p, name, device, true, false);
+        struct firmware_priv *fw_priv;
+        int ret;
+
+        fw_priv = _request_firmware_prepare(firmware_p, name, device, true,
+                                            false);
+        if (IS_ERR_OR_NULL(fw_priv))
+                return PTR_RET(fw_priv);
+
+        ret = usermodehelper_read_trylock();
+        if (WARN_ON(ret)) {
+                dev_err(device, "firmware: %s will not be loaded\n", name);
+        } else {
+                ret = _request_firmware_load(fw_priv, true,
+                                        firmware_loading_timeout());
+                usermodehelper_read_unlock();
+        }
+        if (ret)
+                _request_firmware_cleanup(firmware_p);
+
+        return ret;
 }
 
 /**
@@ -629,25 +631,39 @@ struct firmware_work {
         bool uevent;
 };
 
-static int request_firmware_work_func(void *arg)
+static void request_firmware_work_func(struct work_struct *work)
 {
-        struct firmware_work *fw_work = arg;
+        struct firmware_work *fw_work;
         const struct firmware *fw;
+        struct firmware_priv *fw_priv;
+        long timeout;
         int ret;
 
-        if (!arg) {
-                WARN_ON(1);
-                return 0;
+        fw_work = container_of(work, struct firmware_work, work);
+        fw_priv = _request_firmware_prepare(&fw, fw_work->name, fw_work->device,
+                        fw_work->uevent, true);
+        if (IS_ERR_OR_NULL(fw_priv)) {
+                ret = PTR_RET(fw_priv);
+                goto out;
+        }
+
+        timeout = usermodehelper_read_lock_wait(firmware_loading_timeout());
+        if (timeout) {
+                ret = _request_firmware_load(fw_priv, fw_work->uevent, timeout);
+                usermodehelper_read_unlock();
+        } else {
+                dev_dbg(fw_work->device, "firmware: %s loading timed out\n",
+                        fw_work->name);
+                ret = -EAGAIN;
         }
+        if (ret)
+                _request_firmware_cleanup(&fw);
 
-        ret = _request_firmware(&fw, fw_work->name, fw_work->device,
-                                fw_work->uevent, true);
+ out:
         fw_work->cont(fw, fw_work->context);
 
         module_put(fw_work->module);
         kfree(fw_work);
-
-        return ret;
 }
 
 /**
@@ -673,7 +689,6 @@ request_firmware_nowait(
         const char *name, struct device *device, gfp_t gfp, void *context,
         void (*cont)(const struct firmware *fw, void *context))
 {
-        struct task_struct *task;
         struct firmware_work *fw_work;
 
         fw_work = kzalloc(sizeof (struct firmware_work), gfp);
@@ -692,15 +707,8 @@ request_firmware_nowait(
                 return -EFAULT;
         }
 
-        task = kthread_run(request_firmware_work_func, fw_work,
-                            "firmware/%s", name);
-        if (IS_ERR(task)) {
-                fw_work->cont(NULL, fw_work->context);
-                module_put(fw_work->module);
-                kfree(fw_work);
-                return PTR_ERR(task);
-        }
-
+        INIT_WORK(&fw_work->work, request_firmware_work_func);
+        schedule_work(&fw_work->work);
         return 0;
 }
 
diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c
index 541f821d4ea6..bd0f3949bcf9 100644
--- a/drivers/base/power/runtime.c
+++ b/drivers/base/power/runtime.c
@@ -532,6 +532,8 @@ static int rpm_suspend(struct device *dev, int rpmflags)
         dev->power.suspend_time = ktime_set(0, 0);
         dev->power.max_time_suspended_ns = -1;
         dev->power.deferred_resume = false;
+        wake_up_all(&dev->power.wait_queue);
+
         if (retval == -EAGAIN || retval == -EBUSY) {
                 dev->power.runtime_error = 0;
 
@@ -547,7 +549,6 @@ static int rpm_suspend(struct device *dev, int rpmflags)
         } else {
                 pm_runtime_cancel_pending(dev);
         }
-        wake_up_all(&dev->power.wait_queue);
         goto out;
 }
 
diff --git a/drivers/base/regmap/regcache-rbtree.c b/drivers/base/regmap/regcache-rbtree.c
index 5157fa04c2f0..92b779ee002b 100644
--- a/drivers/base/regmap/regcache-rbtree.c
+++ b/drivers/base/regmap/regcache-rbtree.c
@@ -138,6 +138,7 @@ static int rbtree_show(struct seq_file *s, void *ignored)
         unsigned int base, top;
         int nodes = 0;
         int registers = 0;
+        int average;
 
         mutex_lock(&map->lock);
 
@@ -152,8 +153,13 @@ static int rbtree_show(struct seq_file *s, void *ignored)
                 registers += top - base + 1;
         }
 
+        if (nodes)
+                average = registers / nodes;
+        else
+                average = 0;
+
         seq_printf(s, "%d nodes, %d registers, average %d registers\n",
-                   nodes, registers, registers / nodes);
+                   nodes, registers, average);
 
         mutex_unlock(&map->lock);
 
@@ -396,7 +402,7 @@ static int regcache_rbtree_sync(struct regmap *map, unsigned int min,
                                                            map->cache_word_size);
 
                         /* Is this the hardware default?  If so skip. */
-                        ret = regcache_lookup_reg(map, i);
+                        ret = regcache_lookup_reg(map, regtmp);
                         if (ret >= 0 && val == map->reg_defaults[ret].def)
                                 continue;
 
diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c
index 87f54dbf601b..74b69095def6 100644
--- a/drivers/base/regmap/regcache.c
+++ b/drivers/base/regmap/regcache.c
@@ -346,6 +346,7 @@ out:
 
         return ret;
 }
+EXPORT_SYMBOL_GPL(regcache_sync_region);
 
 /**
  * regcache_cache_only: Put a register map into cache only mode
diff --git a/drivers/base/regmap/regmap-debugfs.c b/drivers/base/regmap/regmap-debugfs.c
index 58517a5dac13..251eb70f83e7 100644
--- a/drivers/base/regmap/regmap-debugfs.c
+++ b/drivers/base/regmap/regmap-debugfs.c
@@ -27,12 +27,6 @@ static size_t regmap_calc_reg_len(int max_val, char *buf, size_t buf_size)
         return strlen(buf);
 }
 
-static int regmap_open_file(struct inode *inode, struct file *file)
-{
-        file->private_data = inode->i_private;
-        return 0;
-}
-
 static ssize_t regmap_name_read_file(struct file *file,
                                      char __user *user_buf, size_t count,
                                      loff_t *ppos)
@@ -57,7 +51,7 @@ static ssize_t regmap_name_read_file(struct file *file,
 }
 
 static const struct file_operations regmap_name_fops = {
-        .open = regmap_open_file,
+        .open = simple_open,
         .read = regmap_name_read_file,
         .llseek = default_llseek,
 };
@@ -174,7 +168,7 @@ static ssize_t regmap_map_write_file(struct file *file,
 #endif
 
 static const struct file_operations regmap_map_fops = {
-        .open = regmap_open_file,
+        .open = simple_open,
         .read = regmap_map_read_file,
         .write = regmap_map_write_file,
         .llseek = default_llseek,
@@ -243,7 +237,7 @@ out:
 }
 
 static const struct file_operations regmap_access_fops = {
-        .open = regmap_open_file,
+        .open = simple_open,
         .read = regmap_access_read_file,
         .llseek = default_llseek,
 };