4 files changed, 105 insertions, 60 deletions

diff --git a/drivers/acpi/tables/tbconvrt.c b/drivers/acpi/tables/tbconvrt.c
index 5155b27cf032..a913a927d321 100644
--- a/drivers/acpi/tables/tbconvrt.c
+++ b/drivers/acpi/tables/tbconvrt.c
@@ -54,12 +54,12 @@ acpi_tb_init_generic_address(struct acpi_generic_address *new_gas_struct,
                              acpi_physical_address address);
 
 static void
-acpi_tb_convert_fadt1(struct fadt_descriptor_rev2 *local_fadt,
+acpi_tb_convert_fadt1(struct fadt_descriptor *local_fadt,
                       struct fadt_descriptor_rev1 *original_fadt);
 
 static void
-acpi_tb_convert_fadt2(struct fadt_descriptor_rev2 *local_fadt,
-                      struct fadt_descriptor_rev2 *original_fadt);
+acpi_tb_convert_fadt2(struct fadt_descriptor *local_fadt,
+                      struct fadt_descriptor *original_fadt);
 
 u8 acpi_fadt_is_v1;
 ACPI_EXPORT_SYMBOL(acpi_fadt_is_v1)
@@ -120,7 +120,7 @@ acpi_status acpi_tb_convert_to_xsdt(struct acpi_table_desc *table_info)
 {
         acpi_size table_size;
         u32 i;
-        XSDT_DESCRIPTOR *new_table;
+        struct xsdt_descriptor *new_table;
 
         ACPI_FUNCTION_ENTRY();
 
@@ -151,12 +151,12 @@ acpi_status acpi_tb_convert_to_xsdt(struct acpi_table_desc *table_info)
                 if (acpi_gbl_root_table_type == ACPI_TABLE_TYPE_RSDT) {
                         ACPI_STORE_ADDRESS(new_table->table_offset_entry[i],
                                            (ACPI_CAST_PTR
-                                            (struct rsdt_descriptor_rev1,
+                                            (struct rsdt_descriptor,
                                              table_info->pointer))->
                                            table_offset_entry[i]);
                 } else {
                         new_table->table_offset_entry[i] =
-                            (ACPI_CAST_PTR(XSDT_DESCRIPTOR,
+                            (ACPI_CAST_PTR(struct xsdt_descriptor,
                                            table_info->pointer))->
                             table_offset_entry[i];
                 }
@@ -218,7 +218,7 @@ acpi_tb_init_generic_address(struct acpi_generic_address *new_gas_struct,
  ******************************************************************************/
 
 static void
-acpi_tb_convert_fadt1(struct fadt_descriptor_rev2 *local_fadt,
+acpi_tb_convert_fadt1(struct fadt_descriptor *local_fadt,
                       struct fadt_descriptor_rev1 *original_fadt)
 {
 
@@ -364,14 +364,13 @@ acpi_tb_convert_fadt1(struct fadt_descriptor_rev2 *local_fadt,
  ******************************************************************************/
 
 static void
-acpi_tb_convert_fadt2(struct fadt_descriptor_rev2 *local_fadt,
-                      struct fadt_descriptor_rev2 *original_fadt)
+acpi_tb_convert_fadt2(struct fadt_descriptor *local_fadt,
+                      struct fadt_descriptor *original_fadt)
 {
 
         /* We have an ACPI 2.0 FADT but we must copy it to our local buffer */
 
-        ACPI_MEMCPY(local_fadt, original_fadt,
-                    sizeof(struct fadt_descriptor_rev2));
+        ACPI_MEMCPY(local_fadt, original_fadt, sizeof(struct fadt_descriptor));
 
         /*
          * "X" fields are optional extensions to the original V1.0 fields, so
@@ -490,7 +489,7 @@ acpi_tb_convert_fadt2(struct fadt_descriptor_rev2 *local_fadt,
 
 acpi_status acpi_tb_convert_table_fadt(void)
 {
-        struct fadt_descriptor_rev2 *local_fadt;
+        struct fadt_descriptor *local_fadt;
         struct acpi_table_desc *table_desc;
 
         ACPI_FUNCTION_TRACE("tb_convert_table_fadt");
@@ -507,13 +506,13 @@ acpi_status acpi_tb_convert_table_fadt(void)
 
         /* Allocate buffer for the ACPI 2.0(+) FADT */
 
-        local_fadt = ACPI_ALLOCATE_ZEROED(sizeof(struct fadt_descriptor_rev2));
+        local_fadt = ACPI_ALLOCATE_ZEROED(sizeof(struct fadt_descriptor));
         if (!local_fadt) {
                 return_ACPI_STATUS(AE_NO_MEMORY);
         }
 
         if (acpi_gbl_FADT->revision >= FADT2_REVISION_ID) {
-                if (acpi_gbl_FADT->length < sizeof(struct fadt_descriptor_rev2)) {
+                if (acpi_gbl_FADT->length < sizeof(struct fadt_descriptor)) {
 
                         /* Length is too short to be a V2.0 table */
 
@@ -538,7 +537,7 @@ acpi_status acpi_tb_convert_table_fadt(void)
         /* Global FADT pointer will point to the new common V2.0 FADT */
 
         acpi_gbl_FADT = local_fadt;
-        acpi_gbl_FADT->length = sizeof(FADT_DESCRIPTOR);
+        acpi_gbl_FADT->length = sizeof(struct fadt_descriptor);
 
         /* Free the original table */
 
@@ -550,7 +549,7 @@ acpi_status acpi_tb_convert_table_fadt(void)
         table_desc->pointer =
             ACPI_CAST_PTR(struct acpi_table_header, acpi_gbl_FADT);
         table_desc->allocation = ACPI_MEM_ALLOCATED;
-        table_desc->length = sizeof(struct fadt_descriptor_rev2);
+        table_desc->length = sizeof(struct fadt_descriptor);
 
         /* Dump the entire FADT */
 
diff --git a/drivers/acpi/tables/tbrsdt.c b/drivers/acpi/tables/tbrsdt.c
index 946d2f2d611d..9e0ebe625ed9 100644
--- a/drivers/acpi/tables/tbrsdt.c
+++ b/drivers/acpi/tables/tbrsdt.c
@@ -280,7 +280,8 @@ acpi_status acpi_tb_get_table_rsdt(void)
                 return_ACPI_STATUS(status);
         }
 
-        acpi_gbl_XSDT = ACPI_CAST_PTR(XSDT_DESCRIPTOR, table_info.pointer);
+        acpi_gbl_XSDT =
+            ACPI_CAST_PTR(struct xsdt_descriptor, table_info.pointer);
 
         ACPI_DEBUG_PRINT((ACPI_DB_INFO, "XSDT located at %p\n", acpi_gbl_XSDT));
         return_ACPI_STATUS(status);
diff --git a/drivers/acpi/tables/tbutils.c b/drivers/acpi/tables/tbutils.c
index b463d4b88823..f8d28ae8811d 100644
--- a/drivers/acpi/tables/tbutils.c
+++ b/drivers/acpi/tables/tbutils.c
@@ -193,73 +193,119 @@ acpi_tb_validate_table_header(struct acpi_table_header *table_header)
 
 /*******************************************************************************
  *
- * FUNCTION:    acpi_tb_verify_table_checksum
+ * FUNCTION:    acpi_tb_sum_table
  *
- * PARAMETERS:  *table_header           - ACPI table to verify
+ * PARAMETERS:  Buffer              - Buffer to sum
+ *              Length              - Size of the buffer
  *
- * RETURN:      8 bit checksum of table
+ * RETURN:      8 bit sum of buffer
  *
- * DESCRIPTION: Does an 8 bit checksum of table and returns status.  A correct
- *              table should have a checksum of 0.
+ * DESCRIPTION: Computes an 8 bit sum of the buffer(length) and returns it.
  *
  ******************************************************************************/
 
-acpi_status
-acpi_tb_verify_table_checksum(struct acpi_table_header * table_header)
+u8 acpi_tb_sum_table(void *buffer, u32 length)
+{
+        acpi_native_uint i;
+        u8 sum = 0;
+
+        if (!buffer || !length) {
+                return (0);
+        }
+
+        for (i = 0; i < length; i++) {
+                sum = (u8) (sum + ((u8 *) buffer)[i]);
+        }
+        return (sum);
+}
+
+/*******************************************************************************
+ *
+ * FUNCTION:    acpi_tb_generate_checksum
+ *
+ * PARAMETERS:  Table               - Pointer to a valid ACPI table (with a
+ *                                    standard ACPI header)
+ *
+ * RETURN:      8 bit checksum of buffer
+ *
+ * DESCRIPTION: Computes an 8 bit checksum of the table.
+ *
+ ******************************************************************************/
+
+u8 acpi_tb_generate_checksum(struct acpi_table_header * table)
 {
         u8 checksum;
-        acpi_status status = AE_OK;
 
-        ACPI_FUNCTION_TRACE("tb_verify_table_checksum");
+        /* Sum the entire table as-is */
 
-        /* Compute the checksum on the table */
+        checksum = acpi_tb_sum_table(table, table->length);
 
-        checksum =
-            acpi_tb_generate_checksum(table_header, table_header->length);
+        /* Subtract off the existing checksum value in the table */
 
-        /* Return the appropriate exception */
+        checksum = (u8) (checksum - table->checksum);
 
-        if (checksum) {
-                ACPI_WARNING((AE_INFO,
-                              "Invalid checksum in table [%4.4s] (%02X, sum %02X is not zero)",
-                              table_header->signature,
-                              (u32) table_header->checksum, (u32) checksum));
+        /* Compute the final checksum */
 
-                status = AE_BAD_CHECKSUM;
-        }
-        return_ACPI_STATUS(status);
+        checksum = (u8) (0 - checksum);
+        return (checksum);
 }
 
 /*******************************************************************************
  *
- * FUNCTION:    acpi_tb_generate_checksum
+ * FUNCTION:    acpi_tb_set_checksum
  *
- * PARAMETERS:  Buffer              - Buffer to checksum
- *              Length              - Size of the buffer
+ * PARAMETERS:  Table               - Pointer to a valid ACPI table (with a
+ *                                    standard ACPI header)
  *
- * RETURN:      8 bit checksum of buffer
+ * RETURN:      None. Sets the table checksum field
  *
- * DESCRIPTION: Computes an 8 bit checksum of the buffer(length) and returns it.
+ * DESCRIPTION: Computes an 8 bit checksum of the table and inserts the
+ *              checksum into the table header.
  *
  ******************************************************************************/
 
-u8 acpi_tb_generate_checksum(void *buffer, u32 length)
+void acpi_tb_set_checksum(struct acpi_table_header *table)
 {
-        u8 *end_buffer;
-        u8 *rover;
-        u8 sum = 0;
 
-        if (buffer && length) {
+        table->checksum = acpi_tb_generate_checksum(table);
+}
+
+/*******************************************************************************
+ *
+ * FUNCTION:    acpi_tb_verify_table_checksum
+ *
+ * PARAMETERS:  *table_header           - ACPI table to verify
+ *
+ * RETURN:      8 bit checksum of table
+ *
+ * DESCRIPTION: Generates an 8 bit checksum of table and returns and compares
+ *              it to the existing checksum value.
+ *
+ ******************************************************************************/
+
+acpi_status
+acpi_tb_verify_table_checksum(struct acpi_table_header *table_header)
+{
+        u8 checksum;
+
+        ACPI_FUNCTION_TRACE("tb_verify_table_checksum");
+
+        /* Compute the checksum on the table */
 
-                /*  Buffer and Length are valid   */
+        checksum = acpi_tb_generate_checksum(table_header);
 
-                end_buffer = ACPI_ADD_PTR(u8, buffer, length);
+        /* Checksum ok? */
 
-                for (rover = buffer; rover < end_buffer; rover++) {
-                        sum = (u8) (sum + *rover);
-                }
+        if (checksum == table_header->checksum) {
+                return_ACPI_STATUS(AE_OK);
         }
-        return (sum);
+
+        ACPI_WARNING((AE_INFO,
+                      "Incorrect checksum in table [%4.4s] - is %2.2X, should be %2.2X",
+                      table_header->signature, table_header->checksum,
+                      checksum));
+
+        return_ACPI_STATUS(AE_BAD_CHECKSUM);
 }
 
 #ifdef ACPI_OBSOLETE_FUNCTIONS
@@ -278,7 +324,7 @@ u8 acpi_tb_generate_checksum(void *buffer, u32 length)
 
 acpi_status
 acpi_tb_handle_to_object(u16 table_id,
-                         struct acpi_table_desc ** return_table_desc)
+                         struct acpi_table_desc **return_table_desc)
 {
         u32 i;
         struct acpi_table_desc *table_desc;
diff --git a/drivers/acpi/tables/tbxfroot.c b/drivers/acpi/tables/tbxfroot.c
index 1b6d8c510e95..550284f5d1ed 100644
--- a/drivers/acpi/tables/tbxfroot.c
+++ b/drivers/acpi/tables/tbxfroot.c
@@ -81,15 +81,14 @@ acpi_status acpi_tb_validate_rsdp(struct rsdp_descriptor *rsdp)
 
         /* Check the standard checksum */
 
-        if (acpi_tb_generate_checksum(rsdp, ACPI_RSDP_CHECKSUM_LENGTH) != 0) {
+        if (acpi_tb_sum_table(rsdp, ACPI_RSDP_CHECKSUM_LENGTH) != 0) {
                 return (AE_BAD_CHECKSUM);
         }
 
         /* Check extended checksum if table version >= 2 */
 
         if ((rsdp->revision >= 2) &&
-            (acpi_tb_generate_checksum(rsdp, ACPI_RSDP_XCHECKSUM_LENGTH) !=
-             0)) {
+            (acpi_tb_sum_table(rsdp, ACPI_RSDP_XCHECKSUM_LENGTH) != 0)) {
                 return (AE_BAD_CHECKSUM);
         }
 
@@ -308,12 +307,12 @@ acpi_get_firmware_table(acpi_string signature,
                 if (acpi_gbl_root_table_type == ACPI_TABLE_TYPE_RSDT) {
                         address.pointer.value =
                             (ACPI_CAST_PTR
-                             (RSDT_DESCRIPTOR,
+                             (struct rsdt_descriptor,
                               rsdt_info->pointer))->table_offset_entry[i];
                 } else {
                         address.pointer.value =
                             (ACPI_CAST_PTR
-                             (XSDT_DESCRIPTOR,
+                             (struct xsdt_descriptor,
                               rsdt_info->pointer))->table_offset_entry[i];
                 }