diff options
Diffstat (limited to 'block/scsi_ioctl.c')
| -rw-r--r-- | block/scsi_ioctl.c | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/block/scsi_ioctl.c b/block/scsi_ioctl.c index abb2e65b24cc..b0c2a616c8f9 100644 --- a/block/scsi_ioctl.c +++ b/block/scsi_ioctl.c | |||
| @@ -458,7 +458,7 @@ int sg_scsi_ioctl(struct request_queue *q, struct gendisk *disk, fmode_t mode, | |||
| 458 | rq = blk_get_request(q, in_len ? WRITE : READ, __GFP_WAIT); | 458 | rq = blk_get_request(q, in_len ? WRITE : READ, __GFP_WAIT); |
| 459 | if (IS_ERR(rq)) { | 459 | if (IS_ERR(rq)) { |
| 460 | err = PTR_ERR(rq); | 460 | err = PTR_ERR(rq); |
| 461 | goto error; | 461 | goto error_free_buffer; |
| 462 | } | 462 | } |
| 463 | blk_rq_set_block_pc(rq); | 463 | blk_rq_set_block_pc(rq); |
| 464 | 464 | ||
| @@ -508,7 +508,7 @@ int sg_scsi_ioctl(struct request_queue *q, struct gendisk *disk, fmode_t mode, | |||
| 508 | 508 | ||
| 509 | if (bytes && blk_rq_map_kern(q, rq, buffer, bytes, __GFP_WAIT)) { | 509 | if (bytes && blk_rq_map_kern(q, rq, buffer, bytes, __GFP_WAIT)) { |
| 510 | err = DRIVER_ERROR << 24; | 510 | err = DRIVER_ERROR << 24; |
| 511 | goto out; | 511 | goto error; |
| 512 | } | 512 | } |
| 513 | 513 | ||
| 514 | memset(sense, 0, sizeof(sense)); | 514 | memset(sense, 0, sizeof(sense)); |
| @@ -517,7 +517,6 @@ int sg_scsi_ioctl(struct request_queue *q, struct gendisk *disk, fmode_t mode, | |||
| 517 | 517 | ||
| 518 | blk_execute_rq(q, disk, rq, 0); | 518 | blk_execute_rq(q, disk, rq, 0); |
| 519 | 519 | ||
| 520 | out: | ||
| 521 | err = rq->errors & 0xff; /* only 8 bit SCSI status */ | 520 | err = rq->errors & 0xff; /* only 8 bit SCSI status */ |
| 522 | if (err) { | 521 | if (err) { |
| 523 | if (rq->sense_len && rq->sense) { | 522 | if (rq->sense_len && rq->sense) { |
| @@ -532,9 +531,11 @@ out: | |||
| 532 | } | 531 | } |
| 533 | 532 | ||
| 534 | error: | 533 | error: |
| 534 | blk_put_request(rq); | ||
| 535 | |||
| 536 | error_free_buffer: | ||
| 535 | kfree(buffer); | 537 | kfree(buffer); |
| 536 | if (rq) | 538 | |
| 537 | blk_put_request(rq); | ||
| 538 | return err; | 539 | return err; |
| 539 | } | 540 | } |
| 540 | EXPORT_SYMBOL_GPL(sg_scsi_ioctl); | 541 | EXPORT_SYMBOL_GPL(sg_scsi_ioctl); |
