diff options
Diffstat (limited to 'arch/x86/kernel/smpboot.c')
-rw-r--r-- | arch/x86/kernel/smpboot.c | 38 |
1 files changed, 19 insertions, 19 deletions
diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c index 4e7ccb0e2a9b..9056f7e272c0 100644 --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c | |||
@@ -123,7 +123,6 @@ EXPORT_PER_CPU_SYMBOL(cpu_info); | |||
123 | 123 | ||
124 | static atomic_t init_deasserted; | 124 | static atomic_t init_deasserted; |
125 | 125 | ||
126 | static int boot_cpu_logical_apicid; | ||
127 | 126 | ||
128 | /* representing cpus for which sibling maps can be computed */ | 127 | /* representing cpus for which sibling maps can be computed */ |
129 | static cpumask_t cpu_sibling_setup_map; | 128 | static cpumask_t cpu_sibling_setup_map; |
@@ -165,6 +164,8 @@ static void unmap_cpu_to_node(int cpu) | |||
165 | #endif | 164 | #endif |
166 | 165 | ||
167 | #ifdef CONFIG_X86_32 | 166 | #ifdef CONFIG_X86_32 |
167 | static int boot_cpu_logical_apicid; | ||
168 | |||
168 | u8 cpu_2_logical_apicid[NR_CPUS] __read_mostly = | 169 | u8 cpu_2_logical_apicid[NR_CPUS] __read_mostly = |
169 | { [0 ... NR_CPUS-1] = BAD_APICID }; | 170 | { [0 ... NR_CPUS-1] = BAD_APICID }; |
170 | 171 | ||
@@ -210,7 +211,7 @@ static void __cpuinit smp_callin(void) | |||
210 | /* | 211 | /* |
211 | * (This works even if the APIC is not enabled.) | 212 | * (This works even if the APIC is not enabled.) |
212 | */ | 213 | */ |
213 | phys_id = GET_APIC_ID(read_apic_id()); | 214 | phys_id = read_apic_id(); |
214 | cpuid = smp_processor_id(); | 215 | cpuid = smp_processor_id(); |
215 | if (cpu_isset(cpuid, cpu_callin_map)) { | 216 | if (cpu_isset(cpuid, cpu_callin_map)) { |
216 | panic("%s: phys CPU#%d, CPU#%d already present??\n", __func__, | 217 | panic("%s: phys CPU#%d, CPU#%d already present??\n", __func__, |
@@ -551,8 +552,7 @@ static inline void __inquire_remote_apic(int apicid) | |||
551 | printk(KERN_CONT | 552 | printk(KERN_CONT |
552 | "a previous APIC delivery may have failed\n"); | 553 | "a previous APIC delivery may have failed\n"); |
553 | 554 | ||
554 | apic_write(APIC_ICR2, SET_APIC_DEST_FIELD(apicid)); | 555 | apic_icr_write(APIC_DM_REMRD | regs[i], apicid); |
555 | apic_write(APIC_ICR, APIC_DM_REMRD | regs[i]); | ||
556 | 556 | ||
557 | timeout = 0; | 557 | timeout = 0; |
558 | do { | 558 | do { |
@@ -584,11 +584,9 @@ wakeup_secondary_cpu(int logical_apicid, unsigned long start_eip) | |||
584 | int maxlvt; | 584 | int maxlvt; |
585 | 585 | ||
586 | /* Target chip */ | 586 | /* Target chip */ |
587 | apic_write(APIC_ICR2, SET_APIC_DEST_FIELD(logical_apicid)); | ||
588 | |||
589 | /* Boot on the stack */ | 587 | /* Boot on the stack */ |
590 | /* Kick the second */ | 588 | /* Kick the second */ |
591 | apic_write(APIC_ICR, APIC_DM_NMI | APIC_DEST_LOGICAL); | 589 | apic_icr_write(APIC_DM_NMI | APIC_DEST_LOGICAL, logical_apicid); |
592 | 590 | ||
593 | pr_debug("Waiting for send to finish...\n"); | 591 | pr_debug("Waiting for send to finish...\n"); |
594 | send_status = safe_apic_wait_icr_idle(); | 592 | send_status = safe_apic_wait_icr_idle(); |
@@ -641,13 +639,11 @@ wakeup_secondary_cpu(int phys_apicid, unsigned long start_eip) | |||
641 | /* | 639 | /* |
642 | * Turn INIT on target chip | 640 | * Turn INIT on target chip |
643 | */ | 641 | */ |
644 | apic_write(APIC_ICR2, SET_APIC_DEST_FIELD(phys_apicid)); | ||
645 | |||
646 | /* | 642 | /* |
647 | * Send IPI | 643 | * Send IPI |
648 | */ | 644 | */ |
649 | apic_write(APIC_ICR, | 645 | apic_icr_write(APIC_INT_LEVELTRIG | APIC_INT_ASSERT | APIC_DM_INIT, |
650 | APIC_INT_LEVELTRIG | APIC_INT_ASSERT | APIC_DM_INIT); | 646 | phys_apicid); |
651 | 647 | ||
652 | pr_debug("Waiting for send to finish...\n"); | 648 | pr_debug("Waiting for send to finish...\n"); |
653 | send_status = safe_apic_wait_icr_idle(); | 649 | send_status = safe_apic_wait_icr_idle(); |
@@ -657,10 +653,8 @@ wakeup_secondary_cpu(int phys_apicid, unsigned long start_eip) | |||
657 | pr_debug("Deasserting INIT.\n"); | 653 | pr_debug("Deasserting INIT.\n"); |
658 | 654 | ||
659 | /* Target chip */ | 655 | /* Target chip */ |
660 | apic_write(APIC_ICR2, SET_APIC_DEST_FIELD(phys_apicid)); | ||
661 | |||
662 | /* Send IPI */ | 656 | /* Send IPI */ |
663 | apic_write(APIC_ICR, APIC_INT_LEVELTRIG | APIC_DM_INIT); | 657 | apic_icr_write(APIC_INT_LEVELTRIG | APIC_DM_INIT, phys_apicid); |
664 | 658 | ||
665 | pr_debug("Waiting for send to finish...\n"); | 659 | pr_debug("Waiting for send to finish...\n"); |
666 | send_status = safe_apic_wait_icr_idle(); | 660 | send_status = safe_apic_wait_icr_idle(); |
@@ -703,11 +697,10 @@ wakeup_secondary_cpu(int phys_apicid, unsigned long start_eip) | |||
703 | */ | 697 | */ |
704 | 698 | ||
705 | /* Target chip */ | 699 | /* Target chip */ |
706 | apic_write(APIC_ICR2, SET_APIC_DEST_FIELD(phys_apicid)); | ||
707 | |||
708 | /* Boot on the stack */ | 700 | /* Boot on the stack */ |
709 | /* Kick the second */ | 701 | /* Kick the second */ |
710 | apic_write(APIC_ICR, APIC_DM_STARTUP | (start_eip >> 12)); | 702 | apic_icr_write(APIC_DM_STARTUP | (start_eip >> 12), |
703 | phys_apicid); | ||
711 | 704 | ||
712 | /* | 705 | /* |
713 | * Give the other CPU some time to accept the IPI. | 706 | * Give the other CPU some time to accept the IPI. |
@@ -1176,10 +1169,17 @@ void __init native_smp_prepare_cpus(unsigned int max_cpus) | |||
1176 | * Setup boot CPU information | 1169 | * Setup boot CPU information |
1177 | */ | 1170 | */ |
1178 | smp_store_cpu_info(0); /* Final full version of the data */ | 1171 | smp_store_cpu_info(0); /* Final full version of the data */ |
1172 | #ifdef CONFIG_X86_32 | ||
1179 | boot_cpu_logical_apicid = logical_smp_processor_id(); | 1173 | boot_cpu_logical_apicid = logical_smp_processor_id(); |
1174 | #endif | ||
1180 | current_thread_info()->cpu = 0; /* needed? */ | 1175 | current_thread_info()->cpu = 0; /* needed? */ |
1181 | set_cpu_sibling_map(0); | 1176 | set_cpu_sibling_map(0); |
1182 | 1177 | ||
1178 | #ifdef CONFIG_X86_64 | ||
1179 | enable_IR_x2apic(); | ||
1180 | setup_apic_routing(); | ||
1181 | #endif | ||
1182 | |||
1183 | if (smp_sanity_check(max_cpus) < 0) { | 1183 | if (smp_sanity_check(max_cpus) < 0) { |
1184 | printk(KERN_INFO "SMP disabled\n"); | 1184 | printk(KERN_INFO "SMP disabled\n"); |
1185 | disable_smp(); | 1185 | disable_smp(); |
@@ -1187,9 +1187,9 @@ void __init native_smp_prepare_cpus(unsigned int max_cpus) | |||
1187 | } | 1187 | } |
1188 | 1188 | ||
1189 | preempt_disable(); | 1189 | preempt_disable(); |
1190 | if (GET_APIC_ID(read_apic_id()) != boot_cpu_physical_apicid) { | 1190 | if (read_apic_id() != boot_cpu_physical_apicid) { |
1191 | panic("Boot APIC ID in local APIC unexpected (%d vs %d)", | 1191 | panic("Boot APIC ID in local APIC unexpected (%d vs %d)", |
1192 | GET_APIC_ID(read_apic_id()), boot_cpu_physical_apicid); | 1192 | read_apic_id(), boot_cpu_physical_apicid); |
1193 | /* Or can we switch back to PIC here? */ | 1193 | /* Or can we switch back to PIC here? */ |
1194 | } | 1194 | } |
1195 | preempt_enable(); | 1195 | preempt_enable(); |