7 files changed, 63 insertions, 78 deletions

diff --git a/arch/um/drivers/line.c b/arch/um/drivers/line.c
index cf8a97f34518..7a656bd8bd3c 100644
--- a/arch/um/drivers/line.c
+++ b/arch/um/drivers/line.c
@@ -6,6 +6,7 @@
 #include "linux/irqreturn.h"
 #include "linux/kd.h"
 #include "linux/sched.h"
+#include "linux/slab.h"
 #include "chan_kern.h"
 #include "irq_kern.h"
 #include "irq_user.h"
@@ -18,10 +19,10 @@ static irqreturn_t line_interrupt(int irq, void *data)
 {
         struct chan *chan = data;
         struct line *line = chan->line;
-        struct tty_struct *tty = line->tty;
+        struct tty_struct *tty;
 
         if (line)
-                chan_interrupt(&line->chan_list, &line->task, tty, irq);
+                chan_interrupt(&line->chan_list, &line->task, line->tty, irq);
         return IRQ_HANDLED;
 }
 
diff --git a/arch/um/drivers/mconsole_kern.c b/arch/um/drivers/mconsole_kern.c
index e14629c87de4..de317d0c3294 100644
--- a/arch/um/drivers/mconsole_kern.c
+++ b/arch/um/drivers/mconsole_kern.c
@@ -6,6 +6,7 @@
 
 #include <linux/console.h>
 #include <linux/ctype.h>
+#include <linux/string.h>
 #include <linux/interrupt.h>
 #include <linux/list.h>
 #include <linux/mm.h>
@@ -124,50 +125,36 @@ void mconsole_log(struct mc_request *req)
 void mconsole_proc(struct mc_request *req)
 {
         struct nameidata nd;
-        struct file_system_type *proc;
-        struct super_block *super;
+        struct vfsmount *mnt = current->nsproxy->pid_ns->proc_mnt;
         struct file *file;
         int n, err;
         char *ptr = req->request.data, *buf;
+        mm_segment_t old_fs = get_fs();
 
         ptr += strlen("proc");
-        while (isspace(*ptr)) ptr++;
+        ptr = skip_spaces(ptr);
 
-        proc = get_fs_type("proc");
-        if (proc == NULL) {
-                mconsole_reply(req, "procfs not registered", 1, 0);
+        err = vfs_path_lookup(mnt->mnt_root, mnt, ptr, LOOKUP_FOLLOW, &nd);
+        if (err) {
+                mconsole_reply(req, "Failed to look up file", 1, 0);
                 goto out;
         }
 
-        super = (*proc->get_sb)(proc, 0, NULL, NULL);
-        put_filesystem(proc);
-        if (super == NULL) {
-                mconsole_reply(req, "Failed to get procfs superblock", 1, 0);
+        err = may_open(&nd.path, MAY_READ, O_RDONLY);
+        if (result) {
+                mconsole_reply(req, "Failed to open file", 1, 0);
+                path_put(&nd.path);
                 goto out;
         }
-        up_write(&super->s_umount);
-
-        nd.path.dentry = super->s_root;
-        nd.path.mnt = NULL;
-        nd.flags = O_RDONLY + 1;
-        nd.last_type = LAST_ROOT;
-
-        /* START: it was experienced that the stability problems are closed
-         * if commenting out these two calls + the below read cycle. To
-         * make UML crash again, it was enough to readd either one.*/
-        err = link_path_walk(ptr, &nd);
-        if (err) {
-                mconsole_reply(req, "Failed to look up file", 1, 0);
-                goto out_kill;
-        }
 
         file = dentry_open(nd.path.dentry, nd.path.mnt, O_RDONLY,
                            current_cred());
+        err = PTR_ERR(file);
         if (IS_ERR(file)) {
                 mconsole_reply(req, "Failed to open file", 1, 0);
-                goto out_kill;
+                path_put(&nd.path);
+                goto out;
         }
-        /*END*/
 
         buf = kmalloc(PAGE_SIZE, GFP_KERNEL);
         if (buf == NULL) {
@@ -175,10 +162,13 @@ void mconsole_proc(struct mc_request *req)
                 goto out_fput;
         }
 
-        if ((file->f_op != NULL) && (file->f_op->read != NULL)) {
+        if (file->f_op->read) {
                 do {
-                        n = (*file->f_op->read)(file, buf, PAGE_SIZE - 1,
-                                                &file->f_pos);
+                        loff_t pos;
+                        set_fs(KERNEL_DS);
+                        n = vfs_read(file, buf, PAGE_SIZE - 1, &pos);
+                        file_pos_write(file, pos);
+                        set_fs(old_fs);
                         if (n >= 0) {
                                 buf[n] = '\0';
                                 mconsole_reply(req, buf, 0, (n > 0));
@@ -196,8 +186,6 @@ void mconsole_proc(struct mc_request *req)
         kfree(buf);
  out_fput:
         fput(file);
- out_kill:
-        deactivate_super(super);
  out: ;
 }
 #endif
@@ -212,8 +200,7 @@ void mconsole_proc(struct mc_request *req)
         char *ptr = req->request.data;
 
         ptr += strlen("proc");
-        while (isspace(*ptr))
-                ptr++;
+        ptr = skip_spaces(ptr);
         snprintf(path, sizeof(path), "/proc/%s", ptr);
 
         fd = sys_open(path, 0, 0);
@@ -560,8 +547,7 @@ void mconsole_config(struct mc_request *req)
         int err;
 
         ptr += strlen("config");
-        while (isspace(*ptr))
-                ptr++;
+        ptr = skip_spaces(ptr);
         dev = mconsole_find_dev(ptr);
         if (dev == NULL) {
                 mconsole_reply(req, "Bad configuration option", 1, 0);
@@ -588,7 +574,7 @@ void mconsole_remove(struct mc_request *req)
         int err, start, end, n;
 
         ptr += strlen("remove");
-        while (isspace(*ptr)) ptr++;
+        ptr = skip_spaces(ptr);
         dev = mconsole_find_dev(ptr);
         if (dev == NULL) {
                 mconsole_reply(req, "Bad remove option", 1, 0);
@@ -712,7 +698,7 @@ void mconsole_sysrq(struct mc_request *req)
         char *ptr = req->request.data;
 
         ptr += strlen("sysrq");
-        while (isspace(*ptr)) ptr++;
+        ptr = skip_spaces(ptr);
 
         /*
          * With 'b', the system will shut down without a chance to reply,
@@ -757,8 +743,7 @@ void mconsole_stack(struct mc_request *req)
          */
 
         ptr += strlen("stack");
-        while (isspace(*ptr))
-                ptr++;
+        ptr = skip_spaces(ptr);
 
         /*
          * Should really check for multiple pids or reject bad args here
@@ -833,8 +818,8 @@ static int __init mconsole_init(void)
 
 __initcall(mconsole_init);
 
-static int write_proc_mconsole(struct file *file, const char __user *buffer,
-                               unsigned long count, void *data)
+static ssize_t mconsole_proc_write(struct file *file,
+                const char __user *buffer, size_t count, loff_t *pos)
 {
         char *buf;
 
@@ -855,6 +840,11 @@ static int write_proc_mconsole(struct file *file, const char __user *buffer,
         return count;
 }
 
+static const struct file_operations mconsole_proc_fops = {
+        .owner          = THIS_MODULE,
+        .write          = mconsole_proc_write,
+};
+
 static int create_proc_mconsole(void)
 {
         struct proc_dir_entry *ent;
@@ -862,15 +852,12 @@ static int create_proc_mconsole(void)
         if (notify_socket == NULL)
                 return 0;
 
-        ent = create_proc_entry("mconsole", S_IFREG | 0200, NULL);
+        ent = proc_create("mconsole", 0200, NULL, &mconsole_proc_fops);
         if (ent == NULL) {
                 printk(KERN_INFO "create_proc_mconsole : create_proc_entry "
                        "failed\n");
                 return 0;
         }
-
-        ent->read_proc = NULL;
-        ent->write_proc = write_proc_mconsole;
         return 0;
 }
 
diff --git a/arch/um/drivers/mmapper_kern.c b/arch/um/drivers/mmapper_kern.c
index eb240323c40a..d22f9e5c0eac 100644
--- a/arch/um/drivers/mmapper_kern.c
+++ b/arch/um/drivers/mmapper_kern.c
@@ -16,7 +16,7 @@
 #include <linux/miscdevice.h>
 #include <linux/module.h>
 #include <linux/mm.h>
-#include <linux/smp_lock.h>
+
 #include <asm/uaccess.h>
 #include "mem_user.h"
 
@@ -78,7 +78,6 @@ out:
 
 static int mmapper_open(struct inode *inode, struct file *file)
 {
-        cycle_kernel_lock();
         return 0;
 }
 
@@ -115,18 +114,16 @@ static int __init mmapper_init(void)
         v_buf = (char *) find_iomem("mmapper", &mmapper_size);
         if (mmapper_size == 0) {
                 printk(KERN_ERR "mmapper_init - find_iomem failed\n");
-                goto out;
+                return -ENODEV;
         }
+        p_buf = __pa(v_buf);
 
         err = misc_register(&mmapper_dev);
         if (err) {
                 printk(KERN_ERR "mmapper - misc_register failed, err = %d\n",
                        err);
-                goto out;
+                return err;;
         }
-
-        p_buf = __pa(v_buf);
-out:
         return 0;
 }
 
diff --git a/arch/um/drivers/net_kern.c b/arch/um/drivers/net_kern.c
index a74245ae3a84..f05372694233 100644
--- a/arch/um/drivers/net_kern.c
+++ b/arch/um/drivers/net_kern.c
@@ -16,6 +16,7 @@
 #include <linux/platform_device.h>
 #include <linux/rtnetlink.h>
 #include <linux/skbuff.h>
+#include <linux/slab.h>
 #include <linux/spinlock.h>
 #include "init.h"
 #include "irq_kern.h"
diff --git a/arch/um/drivers/port_kern.c b/arch/um/drivers/port_kern.c
index 4ebc8a34738f..a11573be0961 100644
--- a/arch/um/drivers/port_kern.c
+++ b/arch/um/drivers/port_kern.c
@@ -7,6 +7,7 @@
 #include "linux/interrupt.h"
 #include "linux/list.h"
 #include "linux/mutex.h"
+#include "linux/slab.h"
 #include "linux/workqueue.h"
 #include "asm/atomic.h"
 #include "init.h"
diff --git a/arch/um/drivers/random.c b/arch/um/drivers/random.c
index 6eabb7022a2d..4949044773ba 100644
--- a/arch/um/drivers/random.c
+++ b/arch/um/drivers/random.c
@@ -7,7 +7,6 @@
  * of the GNU General Public License, incorporated herein by reference.
  */
 #include <linux/sched.h>
-#include <linux/smp_lock.h>
 #include <linux/module.h>
 #include <linux/fs.h>
 #include <linux/interrupt.h>
@@ -34,8 +33,6 @@ static DECLARE_WAIT_QUEUE_HEAD(host_read_wait);
 
 static int rng_dev_open (struct inode *inode, struct file *filp)
 {
-        cycle_kernel_lock();
-
         /* enforce read-only access to this chrdev */
         if ((filp->f_mode & FMODE_READ) == 0)
                 return -EINVAL;
diff --git a/arch/um/drivers/ubd_kern.c b/arch/um/drivers/ubd_kern.c
index 635d16d90a80..da992a3ad6b7 100644
--- a/arch/um/drivers/ubd_kern.c
+++ b/arch/um/drivers/ubd_kern.c
@@ -27,9 +27,11 @@
 #include "linux/init.h"
 #include "linux/cdrom.h"
 #include "linux/proc_fs.h"
+#include "linux/seq_file.h"
 #include "linux/ctype.h"
 #include "linux/capability.h"
 #include "linux/mm.h"
+#include "linux/slab.h"
 #include "linux/vmalloc.h"
 #include "linux/blkpg.h"
 #include "linux/genhd.h"
@@ -200,23 +202,25 @@ static void make_proc_ide(void)
         proc_ide = proc_mkdir("ide0", proc_ide_root);
 }
 
-static int proc_ide_read_media(char *page, char **start, off_t off, int count,
-                               int *eof, void *data)
+static int fake_ide_media_proc_show(struct seq_file *m, void *v)
 {
-        int len;
-
-        strcpy(page, "disk\n");
-        len = strlen("disk\n");
-        len -= off;
-        if (len < count){
-                *eof = 1;
-                if (len <= 0) return 0;
-        }
-        else len = count;
-        *start = page + off;
-        return len;
+        seq_puts(m, "disk\n");
+        return 0;
+}
+
+static int fake_ide_media_proc_open(struct inode *inode, struct file *file)
+{
+        return single_open(file, fake_ide_media_proc_show, NULL);
 }
 
+static const struct file_operations fake_ide_media_proc_fops = {
+        .owner          = THIS_MODULE,
+        .open           = fake_ide_media_proc_open,
+        .read           = seq_read,
+        .llseek         = seq_lseek,
+        .release        = single_release,
+};
+
 static void make_ide_entries(const char *dev_name)
 {
         struct proc_dir_entry *dir, *ent;
@@ -227,11 +231,8 @@ static void make_ide_entries(const char *dev_name)
         dir = proc_mkdir(dev_name, proc_ide);
         if(!dir) return;
 
-        ent = create_proc_entry("media", S_IFREG|S_IRUGO, dir);
+        ent = proc_create("media", S_IRUGO, dir, &fake_ide_media_proc_fops);
         if(!ent) return;
-        ent->data = NULL;
-        ent->read_proc = proc_ide_read_media;
-        ent->write_proc = NULL;
         snprintf(name, sizeof(name), "ide0/%s", dev_name);
         proc_symlink(dev_name, proc_ide_root, name);
 }
@@ -747,7 +748,7 @@ static int ubd_open_dev(struct ubd *ubd_dev)
         ubd_dev->fd = fd;
 
         if(ubd_dev->cow.file != NULL){
-                blk_queue_max_sectors(ubd_dev->queue, 8 * sizeof(long));
+                blk_queue_max_hw_sectors(ubd_dev->queue, 8 * sizeof(long));
 
                 err = -ENOMEM;
                 ubd_dev->cow.bitmap = vmalloc(ubd_dev->cow.bitmap_len);
@@ -849,7 +850,7 @@ static int ubd_add(int n, char **error_out)
         }
         ubd_dev->queue->queuedata = ubd_dev;
 
-        blk_queue_max_hw_segments(ubd_dev->queue, MAX_SG);
+        blk_queue_max_segments(ubd_dev->queue, MAX_SG);
         err = ubd_disk_register(UBD_MAJOR, ubd_dev->size, n, &ubd_gendisk[n]);
         if(err){
                 *error_out = "Failed to register device";