1 files changed, 9 insertions, 3 deletions

diff --git a/arch/mips/kernel/smp.c b/arch/mips/kernel/smp.c
index 48650c818040..1268392f1d27 100644
--- a/arch/mips/kernel/smp.c
+++ b/arch/mips/kernel/smp.c
@@ -122,13 +122,21 @@ asmlinkage __cpuinit void start_secondary(void)
 
         notify_cpu_starting(cpu);
 
-        mp_ops->smp_finish();
+        set_cpu_online(cpu, true);
+
         set_cpu_sibling_map(cpu);
 
         cpu_set(cpu, cpu_callin_map);
 
         synchronise_count_slave();
 
+        /*
+         * irq will be enabled in ->smp_finish(), enabling it too early
+         * is dangerous.
+         */
+        WARN_ON_ONCE(!irqs_disabled());
+        mp_ops->smp_finish();
+
         cpu_idle();
 }
 
@@ -196,8 +204,6 @@ int __cpuinit __cpu_up(unsigned int cpu, struct task_struct *tidle)
         while (!cpu_isset(cpu, cpu_callin_map))
                 udelay(100);
 
-        set_cpu_online(cpu, true);
-
         return 0;
 }