diff options
-rw-r--r-- | drivers/acpi/Kconfig | 2 | ||||
-rw-r--r-- | drivers/acpi/battery.c | 10 | ||||
-rw-r--r-- | drivers/acpi/processor_perflib.c | 30 | ||||
-rw-r--r-- | drivers/acpi/video.c | 33 | ||||
-rw-r--r-- | include/acpi/acpi_bus.h | 4 | ||||
-rw-r--r-- | tools/power/x86/turbostat/turbostat.c | 30 |
6 files changed, 87 insertions, 22 deletions
diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig index 47768ff87343..80998958cf45 100644 --- a/drivers/acpi/Kconfig +++ b/drivers/acpi/Kconfig | |||
@@ -208,7 +208,7 @@ config ACPI_IPMI | |||
208 | 208 | ||
209 | config ACPI_HOTPLUG_CPU | 209 | config ACPI_HOTPLUG_CPU |
210 | bool | 210 | bool |
211 | depends on ACPI_PROCESSOR && HOTPLUG_CPU | 211 | depends on EXPERIMENTAL && ACPI_PROCESSOR && HOTPLUG_CPU |
212 | select ACPI_CONTAINER | 212 | select ACPI_CONTAINER |
213 | default y | 213 | default y |
214 | 214 | ||
diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c index 86933ca8b472..7dd3f9fb9f3f 100644 --- a/drivers/acpi/battery.c +++ b/drivers/acpi/battery.c | |||
@@ -643,11 +643,19 @@ static int acpi_battery_update(struct acpi_battery *battery) | |||
643 | 643 | ||
644 | static void acpi_battery_refresh(struct acpi_battery *battery) | 644 | static void acpi_battery_refresh(struct acpi_battery *battery) |
645 | { | 645 | { |
646 | int power_unit; | ||
647 | |||
646 | if (!battery->bat.dev) | 648 | if (!battery->bat.dev) |
647 | return; | 649 | return; |
648 | 650 | ||
651 | power_unit = battery->power_unit; | ||
652 | |||
649 | acpi_battery_get_info(battery); | 653 | acpi_battery_get_info(battery); |
650 | /* The battery may have changed its reporting units. */ | 654 | |
655 | if (power_unit == battery->power_unit) | ||
656 | return; | ||
657 | |||
658 | /* The battery has changed its reporting units. */ | ||
651 | sysfs_remove_battery(battery); | 659 | sysfs_remove_battery(battery); |
652 | sysfs_add_battery(battery); | 660 | sysfs_add_battery(battery); |
653 | } | 661 | } |
diff --git a/drivers/acpi/processor_perflib.c b/drivers/acpi/processor_perflib.c index 0af48a8554cd..a093dc163a42 100644 --- a/drivers/acpi/processor_perflib.c +++ b/drivers/acpi/processor_perflib.c | |||
@@ -333,6 +333,7 @@ static int acpi_processor_get_performance_states(struct acpi_processor *pr) | |||
333 | struct acpi_buffer state = { 0, NULL }; | 333 | struct acpi_buffer state = { 0, NULL }; |
334 | union acpi_object *pss = NULL; | 334 | union acpi_object *pss = NULL; |
335 | int i; | 335 | int i; |
336 | int last_invalid = -1; | ||
336 | 337 | ||
337 | 338 | ||
338 | status = acpi_evaluate_object(pr->handle, "_PSS", NULL, &buffer); | 339 | status = acpi_evaluate_object(pr->handle, "_PSS", NULL, &buffer); |
@@ -394,14 +395,33 @@ static int acpi_processor_get_performance_states(struct acpi_processor *pr) | |||
394 | ((u32)(px->core_frequency * 1000) != | 395 | ((u32)(px->core_frequency * 1000) != |
395 | (px->core_frequency * 1000))) { | 396 | (px->core_frequency * 1000))) { |
396 | printk(KERN_ERR FW_BUG PREFIX | 397 | printk(KERN_ERR FW_BUG PREFIX |
397 | "Invalid BIOS _PSS frequency: 0x%llx MHz\n", | 398 | "Invalid BIOS _PSS frequency found for processor %d: 0x%llx MHz\n", |
398 | px->core_frequency); | 399 | pr->id, px->core_frequency); |
399 | result = -EFAULT; | 400 | if (last_invalid == -1) |
400 | kfree(pr->performance->states); | 401 | last_invalid = i; |
401 | goto end; | 402 | } else { |
403 | if (last_invalid != -1) { | ||
404 | /* | ||
405 | * Copy this valid entry over last_invalid entry | ||
406 | */ | ||
407 | memcpy(&(pr->performance->states[last_invalid]), | ||
408 | px, sizeof(struct acpi_processor_px)); | ||
409 | ++last_invalid; | ||
410 | } | ||
402 | } | 411 | } |
403 | } | 412 | } |
404 | 413 | ||
414 | if (last_invalid == 0) { | ||
415 | printk(KERN_ERR FW_BUG PREFIX | ||
416 | "No valid BIOS _PSS frequency found for processor %d\n", pr->id); | ||
417 | result = -EFAULT; | ||
418 | kfree(pr->performance->states); | ||
419 | pr->performance->states = NULL; | ||
420 | } | ||
421 | |||
422 | if (last_invalid > 0) | ||
423 | pr->performance->state_count = last_invalid; | ||
424 | |||
405 | end: | 425 | end: |
406 | kfree(buffer.pointer); | 426 | kfree(buffer.pointer); |
407 | 427 | ||
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c index 9577b6fa2650..a576575617d7 100644 --- a/drivers/acpi/video.c +++ b/drivers/acpi/video.c | |||
@@ -1687,10 +1687,6 @@ static int acpi_video_bus_add(struct acpi_device *device) | |||
1687 | set_bit(KEY_BRIGHTNESS_ZERO, input->keybit); | 1687 | set_bit(KEY_BRIGHTNESS_ZERO, input->keybit); |
1688 | set_bit(KEY_DISPLAY_OFF, input->keybit); | 1688 | set_bit(KEY_DISPLAY_OFF, input->keybit); |
1689 | 1689 | ||
1690 | error = input_register_device(input); | ||
1691 | if (error) | ||
1692 | goto err_stop_video; | ||
1693 | |||
1694 | printk(KERN_INFO PREFIX "%s [%s] (multi-head: %s rom: %s post: %s)\n", | 1690 | printk(KERN_INFO PREFIX "%s [%s] (multi-head: %s rom: %s post: %s)\n", |
1695 | ACPI_VIDEO_DEVICE_NAME, acpi_device_bid(device), | 1691 | ACPI_VIDEO_DEVICE_NAME, acpi_device_bid(device), |
1696 | video->flags.multihead ? "yes" : "no", | 1692 | video->flags.multihead ? "yes" : "no", |
@@ -1701,12 +1697,16 @@ static int acpi_video_bus_add(struct acpi_device *device) | |||
1701 | video->pm_nb.priority = 0; | 1697 | video->pm_nb.priority = 0; |
1702 | error = register_pm_notifier(&video->pm_nb); | 1698 | error = register_pm_notifier(&video->pm_nb); |
1703 | if (error) | 1699 | if (error) |
1704 | goto err_unregister_input_dev; | 1700 | goto err_stop_video; |
1701 | |||
1702 | error = input_register_device(input); | ||
1703 | if (error) | ||
1704 | goto err_unregister_pm_notifier; | ||
1705 | 1705 | ||
1706 | return 0; | 1706 | return 0; |
1707 | 1707 | ||
1708 | err_unregister_input_dev: | 1708 | err_unregister_pm_notifier: |
1709 | input_unregister_device(input); | 1709 | unregister_pm_notifier(&video->pm_nb); |
1710 | err_stop_video: | 1710 | err_stop_video: |
1711 | acpi_video_bus_stop_devices(video); | 1711 | acpi_video_bus_stop_devices(video); |
1712 | err_free_input_dev: | 1712 | err_free_input_dev: |
@@ -1743,9 +1743,18 @@ static int acpi_video_bus_remove(struct acpi_device *device, int type) | |||
1743 | return 0; | 1743 | return 0; |
1744 | } | 1744 | } |
1745 | 1745 | ||
1746 | static int __init is_i740(struct pci_dev *dev) | ||
1747 | { | ||
1748 | if (dev->device == 0x00D1) | ||
1749 | return 1; | ||
1750 | if (dev->device == 0x7000) | ||
1751 | return 1; | ||
1752 | return 0; | ||
1753 | } | ||
1754 | |||
1746 | static int __init intel_opregion_present(void) | 1755 | static int __init intel_opregion_present(void) |
1747 | { | 1756 | { |
1748 | #if defined(CONFIG_DRM_I915) || defined(CONFIG_DRM_I915_MODULE) | 1757 | int opregion = 0; |
1749 | struct pci_dev *dev = NULL; | 1758 | struct pci_dev *dev = NULL; |
1750 | u32 address; | 1759 | u32 address; |
1751 | 1760 | ||
@@ -1754,13 +1763,15 @@ static int __init intel_opregion_present(void) | |||
1754 | continue; | 1763 | continue; |
1755 | if (dev->vendor != PCI_VENDOR_ID_INTEL) | 1764 | if (dev->vendor != PCI_VENDOR_ID_INTEL) |
1756 | continue; | 1765 | continue; |
1766 | /* We don't want to poke around undefined i740 registers */ | ||
1767 | if (is_i740(dev)) | ||
1768 | continue; | ||
1757 | pci_read_config_dword(dev, 0xfc, &address); | 1769 | pci_read_config_dword(dev, 0xfc, &address); |
1758 | if (!address) | 1770 | if (!address) |
1759 | continue; | 1771 | continue; |
1760 | return 1; | 1772 | opregion = 1; |
1761 | } | 1773 | } |
1762 | #endif | 1774 | return opregion; |
1763 | return 0; | ||
1764 | } | 1775 | } |
1765 | 1776 | ||
1766 | int acpi_video_register(void) | 1777 | int acpi_video_register(void) |
diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h index b0d62820ada1..9e6e1c6eb60a 100644 --- a/include/acpi/acpi_bus.h +++ b/include/acpi/acpi_bus.h | |||
@@ -440,8 +440,8 @@ static inline int acpi_pm_device_sleep_wake(struct device *dev, bool enable) | |||
440 | 440 | ||
441 | #else /* CONFIG_ACPI */ | 441 | #else /* CONFIG_ACPI */ |
442 | 442 | ||
443 | static int register_acpi_bus_type(struct acpi_bus_type *bus) { return 0; } | 443 | static inline int register_acpi_bus_type(void *bus) { return 0; } |
444 | static int unregister_acpi_bus_type(struct acpi_bus_type *bus) { return 0; } | 444 | static inline int unregister_acpi_bus_type(void *bus) { return 0; } |
445 | 445 | ||
446 | #endif /* CONFIG_ACPI */ | 446 | #endif /* CONFIG_ACPI */ |
447 | 447 | ||
diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c index ab2f682fd44c..16de7ad4850f 100644 --- a/tools/power/x86/turbostat/turbostat.c +++ b/tools/power/x86/turbostat/turbostat.c | |||
@@ -73,8 +73,8 @@ int backwards_count; | |||
73 | char *progname; | 73 | char *progname; |
74 | 74 | ||
75 | int num_cpus; | 75 | int num_cpus; |
76 | cpu_set_t *cpu_mask; | 76 | cpu_set_t *cpu_present_set, *cpu_mask; |
77 | size_t cpu_mask_size; | 77 | size_t cpu_present_setsize, cpu_mask_size; |
78 | 78 | ||
79 | struct counters { | 79 | struct counters { |
80 | unsigned long long tsc; /* per thread */ | 80 | unsigned long long tsc; /* per thread */ |
@@ -103,6 +103,12 @@ struct timeval tv_even; | |||
103 | struct timeval tv_odd; | 103 | struct timeval tv_odd; |
104 | struct timeval tv_delta; | 104 | struct timeval tv_delta; |
105 | 105 | ||
106 | int mark_cpu_present(int pkg, int core, int cpu) | ||
107 | { | ||
108 | CPU_SET_S(cpu, cpu_present_setsize, cpu_present_set); | ||
109 | return 0; | ||
110 | } | ||
111 | |||
106 | /* | 112 | /* |
107 | * cpu_mask_init(ncpus) | 113 | * cpu_mask_init(ncpus) |
108 | * | 114 | * |
@@ -118,6 +124,18 @@ void cpu_mask_init(int ncpus) | |||
118 | } | 124 | } |
119 | cpu_mask_size = CPU_ALLOC_SIZE(ncpus); | 125 | cpu_mask_size = CPU_ALLOC_SIZE(ncpus); |
120 | CPU_ZERO_S(cpu_mask_size, cpu_mask); | 126 | CPU_ZERO_S(cpu_mask_size, cpu_mask); |
127 | |||
128 | /* | ||
129 | * Allocate and initialize cpu_present_set | ||
130 | */ | ||
131 | cpu_present_set = CPU_ALLOC(ncpus); | ||
132 | if (cpu_present_set == NULL) { | ||
133 | perror("CPU_ALLOC"); | ||
134 | exit(3); | ||
135 | } | ||
136 | cpu_present_setsize = CPU_ALLOC_SIZE(ncpus); | ||
137 | CPU_ZERO_S(cpu_present_setsize, cpu_present_set); | ||
138 | for_all_cpus(mark_cpu_present); | ||
121 | } | 139 | } |
122 | 140 | ||
123 | void cpu_mask_uninit() | 141 | void cpu_mask_uninit() |
@@ -125,6 +143,9 @@ void cpu_mask_uninit() | |||
125 | CPU_FREE(cpu_mask); | 143 | CPU_FREE(cpu_mask); |
126 | cpu_mask = NULL; | 144 | cpu_mask = NULL; |
127 | cpu_mask_size = 0; | 145 | cpu_mask_size = 0; |
146 | CPU_FREE(cpu_present_set); | ||
147 | cpu_present_set = NULL; | ||
148 | cpu_present_setsize = 0; | ||
128 | } | 149 | } |
129 | 150 | ||
130 | int cpu_migrate(int cpu) | 151 | int cpu_migrate(int cpu) |
@@ -912,6 +933,8 @@ int is_snb(unsigned int family, unsigned int model) | |||
912 | switch (model) { | 933 | switch (model) { |
913 | case 0x2A: | 934 | case 0x2A: |
914 | case 0x2D: | 935 | case 0x2D: |
936 | case 0x3A: /* IVB */ | ||
937 | case 0x3D: /* IVB Xeon */ | ||
915 | return 1; | 938 | return 1; |
916 | } | 939 | } |
917 | return 0; | 940 | return 0; |
@@ -1047,6 +1070,9 @@ int fork_it(char **argv) | |||
1047 | int retval; | 1070 | int retval; |
1048 | pid_t child_pid; | 1071 | pid_t child_pid; |
1049 | get_counters(cnt_even); | 1072 | get_counters(cnt_even); |
1073 | |||
1074 | /* clear affinity side-effect of get_counters() */ | ||
1075 | sched_setaffinity(0, cpu_present_setsize, cpu_present_set); | ||
1050 | gettimeofday(&tv_even, (struct timezone *)NULL); | 1076 | gettimeofday(&tv_even, (struct timezone *)NULL); |
1051 | 1077 | ||
1052 | child_pid = fork(); | 1078 | child_pid = fork(); |