1 files changed, 4 insertions, 5 deletions

diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
index e6ab307ce86e..b11ab23b328b 100644
--- a/security/smack/smack_lsm.c
+++ b/security/smack/smack_lsm.c
@@ -1122,13 +1122,12 @@ static int smack_inode_getsecurity(const struct inode *inode,
 static int smack_inode_listsecurity(struct inode *inode, char *buffer,
                                     size_t buffer_size)
 {
-        int len = strlen(XATTR_NAME_SMACK);
+        int len = sizeof(XATTR_NAME_SMACK);
 
-        if (buffer != NULL && len <= buffer_size) {
+        if (buffer != NULL && len <= buffer_size)
                 memcpy(buffer, XATTR_NAME_SMACK, len);
-                return len;
-        }
-        return -EINVAL;
+
+        return len;
 }
 
 /**