diff options
-rw-r--r-- | arch/x86/ia32/ia32_signal.c | 2 | ||||
-rw-r--r-- | arch/x86/include/asm/checksum_32.h | 22 | ||||
-rw-r--r-- | arch/x86/kernel/signal.c | 6 | ||||
-rw-r--r-- | arch/x86/lib/csum-wrappers_64.c | 12 | ||||
-rw-r--r-- | include/linux/compat.h | 7 | ||||
-rw-r--r-- | include/linux/signal.h | 8 |
6 files changed, 46 insertions, 11 deletions
diff --git a/arch/x86/ia32/ia32_signal.c b/arch/x86/ia32/ia32_signal.c index bccfca68430e..665a730307f2 100644 --- a/arch/x86/ia32/ia32_signal.c +++ b/arch/x86/ia32/ia32_signal.c | |||
@@ -457,7 +457,7 @@ int ia32_setup_rt_frame(int sig, struct ksignal *ksig, | |||
457 | else | 457 | else |
458 | put_user_ex(0, &frame->uc.uc_flags); | 458 | put_user_ex(0, &frame->uc.uc_flags); |
459 | put_user_ex(0, &frame->uc.uc_link); | 459 | put_user_ex(0, &frame->uc.uc_link); |
460 | err |= __compat_save_altstack(&frame->uc.uc_stack, regs->sp); | 460 | compat_save_altstack_ex(&frame->uc.uc_stack, regs->sp); |
461 | 461 | ||
462 | if (ksig->ka.sa.sa_flags & SA_RESTORER) | 462 | if (ksig->ka.sa.sa_flags & SA_RESTORER) |
463 | restorer = ksig->ka.sa.sa_restorer; | 463 | restorer = ksig->ka.sa.sa_restorer; |
diff --git a/arch/x86/include/asm/checksum_32.h b/arch/x86/include/asm/checksum_32.h index 46fc474fd819..f50de6951738 100644 --- a/arch/x86/include/asm/checksum_32.h +++ b/arch/x86/include/asm/checksum_32.h | |||
@@ -49,9 +49,15 @@ static inline __wsum csum_partial_copy_from_user(const void __user *src, | |||
49 | int len, __wsum sum, | 49 | int len, __wsum sum, |
50 | int *err_ptr) | 50 | int *err_ptr) |
51 | { | 51 | { |
52 | __wsum ret; | ||
53 | |||
52 | might_sleep(); | 54 | might_sleep(); |
53 | return csum_partial_copy_generic((__force void *)src, dst, | 55 | stac(); |
54 | len, sum, err_ptr, NULL); | 56 | ret = csum_partial_copy_generic((__force void *)src, dst, |
57 | len, sum, err_ptr, NULL); | ||
58 | clac(); | ||
59 | |||
60 | return ret; | ||
55 | } | 61 | } |
56 | 62 | ||
57 | /* | 63 | /* |
@@ -176,10 +182,16 @@ static inline __wsum csum_and_copy_to_user(const void *src, | |||
176 | int len, __wsum sum, | 182 | int len, __wsum sum, |
177 | int *err_ptr) | 183 | int *err_ptr) |
178 | { | 184 | { |
185 | __wsum ret; | ||
186 | |||
179 | might_sleep(); | 187 | might_sleep(); |
180 | if (access_ok(VERIFY_WRITE, dst, len)) | 188 | if (access_ok(VERIFY_WRITE, dst, len)) { |
181 | return csum_partial_copy_generic(src, (__force void *)dst, | 189 | stac(); |
182 | len, sum, NULL, err_ptr); | 190 | ret = csum_partial_copy_generic(src, (__force void *)dst, |
191 | len, sum, NULL, err_ptr); | ||
192 | clac(); | ||
193 | return ret; | ||
194 | } | ||
183 | 195 | ||
184 | if (len) | 196 | if (len) |
185 | *err_ptr = -EFAULT; | 197 | *err_ptr = -EFAULT; |
diff --git a/arch/x86/kernel/signal.c b/arch/x86/kernel/signal.c index 6a9acc667d20..9e5de6813e1f 100644 --- a/arch/x86/kernel/signal.c +++ b/arch/x86/kernel/signal.c | |||
@@ -358,7 +358,7 @@ static int __setup_rt_frame(int sig, struct ksignal *ksig, | |||
358 | else | 358 | else |
359 | put_user_ex(0, &frame->uc.uc_flags); | 359 | put_user_ex(0, &frame->uc.uc_flags); |
360 | put_user_ex(0, &frame->uc.uc_link); | 360 | put_user_ex(0, &frame->uc.uc_link); |
361 | err |= __save_altstack(&frame->uc.uc_stack, regs->sp); | 361 | save_altstack_ex(&frame->uc.uc_stack, regs->sp); |
362 | 362 | ||
363 | /* Set up to return from userspace. */ | 363 | /* Set up to return from userspace. */ |
364 | restorer = VDSO32_SYMBOL(current->mm->context.vdso, rt_sigreturn); | 364 | restorer = VDSO32_SYMBOL(current->mm->context.vdso, rt_sigreturn); |
@@ -423,7 +423,7 @@ static int __setup_rt_frame(int sig, struct ksignal *ksig, | |||
423 | else | 423 | else |
424 | put_user_ex(0, &frame->uc.uc_flags); | 424 | put_user_ex(0, &frame->uc.uc_flags); |
425 | put_user_ex(0, &frame->uc.uc_link); | 425 | put_user_ex(0, &frame->uc.uc_link); |
426 | err |= __save_altstack(&frame->uc.uc_stack, regs->sp); | 426 | save_altstack_ex(&frame->uc.uc_stack, regs->sp); |
427 | 427 | ||
428 | /* Set up to return from userspace. If provided, use a stub | 428 | /* Set up to return from userspace. If provided, use a stub |
429 | already in userspace. */ | 429 | already in userspace. */ |
@@ -490,7 +490,7 @@ static int x32_setup_rt_frame(struct ksignal *ksig, | |||
490 | else | 490 | else |
491 | put_user_ex(0, &frame->uc.uc_flags); | 491 | put_user_ex(0, &frame->uc.uc_flags); |
492 | put_user_ex(0, &frame->uc.uc_link); | 492 | put_user_ex(0, &frame->uc.uc_link); |
493 | err |= __compat_save_altstack(&frame->uc.uc_stack, regs->sp); | 493 | compat_save_altstack_ex(&frame->uc.uc_stack, regs->sp); |
494 | put_user_ex(0, &frame->uc.uc__pad0); | 494 | put_user_ex(0, &frame->uc.uc__pad0); |
495 | 495 | ||
496 | if (ksig->ka.sa.sa_flags & SA_RESTORER) { | 496 | if (ksig->ka.sa.sa_flags & SA_RESTORER) { |
diff --git a/arch/x86/lib/csum-wrappers_64.c b/arch/x86/lib/csum-wrappers_64.c index 25b7ae8d058a..7609e0e421ec 100644 --- a/arch/x86/lib/csum-wrappers_64.c +++ b/arch/x86/lib/csum-wrappers_64.c | |||
@@ -6,6 +6,7 @@ | |||
6 | */ | 6 | */ |
7 | #include <asm/checksum.h> | 7 | #include <asm/checksum.h> |
8 | #include <linux/module.h> | 8 | #include <linux/module.h> |
9 | #include <asm/smap.h> | ||
9 | 10 | ||
10 | /** | 11 | /** |
11 | * csum_partial_copy_from_user - Copy and checksum from user space. | 12 | * csum_partial_copy_from_user - Copy and checksum from user space. |
@@ -52,8 +53,10 @@ csum_partial_copy_from_user(const void __user *src, void *dst, | |||
52 | len -= 2; | 53 | len -= 2; |
53 | } | 54 | } |
54 | } | 55 | } |
56 | stac(); | ||
55 | isum = csum_partial_copy_generic((__force const void *)src, | 57 | isum = csum_partial_copy_generic((__force const void *)src, |
56 | dst, len, isum, errp, NULL); | 58 | dst, len, isum, errp, NULL); |
59 | clac(); | ||
57 | if (unlikely(*errp)) | 60 | if (unlikely(*errp)) |
58 | goto out_err; | 61 | goto out_err; |
59 | 62 | ||
@@ -82,6 +85,8 @@ __wsum | |||
82 | csum_partial_copy_to_user(const void *src, void __user *dst, | 85 | csum_partial_copy_to_user(const void *src, void __user *dst, |
83 | int len, __wsum isum, int *errp) | 86 | int len, __wsum isum, int *errp) |
84 | { | 87 | { |
88 | __wsum ret; | ||
89 | |||
85 | might_sleep(); | 90 | might_sleep(); |
86 | 91 | ||
87 | if (unlikely(!access_ok(VERIFY_WRITE, dst, len))) { | 92 | if (unlikely(!access_ok(VERIFY_WRITE, dst, len))) { |
@@ -105,8 +110,11 @@ csum_partial_copy_to_user(const void *src, void __user *dst, | |||
105 | } | 110 | } |
106 | 111 | ||
107 | *errp = 0; | 112 | *errp = 0; |
108 | return csum_partial_copy_generic(src, (void __force *)dst, | 113 | stac(); |
109 | len, isum, NULL, errp); | 114 | ret = csum_partial_copy_generic(src, (void __force *)dst, |
115 | len, isum, NULL, errp); | ||
116 | clac(); | ||
117 | return ret; | ||
110 | } | 118 | } |
111 | EXPORT_SYMBOL(csum_partial_copy_to_user); | 119 | EXPORT_SYMBOL(csum_partial_copy_to_user); |
112 | 120 | ||
diff --git a/include/linux/compat.h b/include/linux/compat.h index 7f0c1dd09079..ec1aee4aec9c 100644 --- a/include/linux/compat.h +++ b/include/linux/compat.h | |||
@@ -669,6 +669,13 @@ asmlinkage long compat_sys_sigaltstack(const compat_stack_t __user *uss_ptr, | |||
669 | 669 | ||
670 | int compat_restore_altstack(const compat_stack_t __user *uss); | 670 | int compat_restore_altstack(const compat_stack_t __user *uss); |
671 | int __compat_save_altstack(compat_stack_t __user *, unsigned long); | 671 | int __compat_save_altstack(compat_stack_t __user *, unsigned long); |
672 | #define compat_save_altstack_ex(uss, sp) do { \ | ||
673 | compat_stack_t __user *__uss = uss; \ | ||
674 | struct task_struct *t = current; \ | ||
675 | put_user_ex(ptr_to_compat((void __user *)t->sas_ss_sp), &__uss->ss_sp); \ | ||
676 | put_user_ex(sas_ss_flags(sp), &__uss->ss_flags); \ | ||
677 | put_user_ex(t->sas_ss_size, &__uss->ss_size); \ | ||
678 | } while (0); | ||
672 | 679 | ||
673 | asmlinkage long compat_sys_sched_rr_get_interval(compat_pid_t pid, | 680 | asmlinkage long compat_sys_sched_rr_get_interval(compat_pid_t pid, |
674 | struct compat_timespec __user *interval); | 681 | struct compat_timespec __user *interval); |
diff --git a/include/linux/signal.h b/include/linux/signal.h index d897484730c0..2ac423bdb676 100644 --- a/include/linux/signal.h +++ b/include/linux/signal.h | |||
@@ -434,6 +434,14 @@ void signals_init(void); | |||
434 | int restore_altstack(const stack_t __user *); | 434 | int restore_altstack(const stack_t __user *); |
435 | int __save_altstack(stack_t __user *, unsigned long); | 435 | int __save_altstack(stack_t __user *, unsigned long); |
436 | 436 | ||
437 | #define save_altstack_ex(uss, sp) do { \ | ||
438 | stack_t __user *__uss = uss; \ | ||
439 | struct task_struct *t = current; \ | ||
440 | put_user_ex((void __user *)t->sas_ss_sp, &__uss->ss_sp); \ | ||
441 | put_user_ex(sas_ss_flags(sp), &__uss->ss_flags); \ | ||
442 | put_user_ex(t->sas_ss_size, &__uss->ss_size); \ | ||
443 | } while (0); | ||
444 | |||
437 | #ifdef CONFIG_PROC_FS | 445 | #ifdef CONFIG_PROC_FS |
438 | struct seq_file; | 446 | struct seq_file; |
439 | extern void render_sigset_t(struct seq_file *, const char *, sigset_t *); | 447 | extern void render_sigset_t(struct seq_file *, const char *, sigset_t *); |