diff options
-rw-r--r-- | drivers/hwmon/ultra45_env.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/drivers/hwmon/ultra45_env.c b/drivers/hwmon/ultra45_env.c index fb3e69341c1b..7d4658636064 100644 --- a/drivers/hwmon/ultra45_env.c +++ b/drivers/hwmon/ultra45_env.c | |||
@@ -252,7 +252,7 @@ static const struct attribute_group env_group = { | |||
252 | 252 | ||
253 | static int env_probe(struct platform_device *op) | 253 | static int env_probe(struct platform_device *op) |
254 | { | 254 | { |
255 | struct env *p = kzalloc(sizeof(*p), GFP_KERNEL); | 255 | struct env *p = devm_kzalloc(&op->dev, sizeof(*p), GFP_KERNEL); |
256 | int err = -ENOMEM; | 256 | int err = -ENOMEM; |
257 | 257 | ||
258 | if (!p) | 258 | if (!p) |
@@ -262,7 +262,7 @@ static int env_probe(struct platform_device *op) | |||
262 | 262 | ||
263 | p->regs = of_ioremap(&op->resource[0], 0, REG_SIZE, "pic16f747"); | 263 | p->regs = of_ioremap(&op->resource[0], 0, REG_SIZE, "pic16f747"); |
264 | if (!p->regs) | 264 | if (!p->regs) |
265 | goto out_free; | 265 | goto out; |
266 | 266 | ||
267 | err = sysfs_create_group(&op->dev.kobj, &env_group); | 267 | err = sysfs_create_group(&op->dev.kobj, &env_group); |
268 | if (err) | 268 | if (err) |
@@ -286,8 +286,6 @@ out_sysfs_remove_group: | |||
286 | out_iounmap: | 286 | out_iounmap: |
287 | of_iounmap(&op->resource[0], p->regs, REG_SIZE); | 287 | of_iounmap(&op->resource[0], p->regs, REG_SIZE); |
288 | 288 | ||
289 | out_free: | ||
290 | kfree(p); | ||
291 | goto out; | 289 | goto out; |
292 | } | 290 | } |
293 | 291 | ||
@@ -299,7 +297,6 @@ static int env_remove(struct platform_device *op) | |||
299 | sysfs_remove_group(&op->dev.kobj, &env_group); | 297 | sysfs_remove_group(&op->dev.kobj, &env_group); |
300 | hwmon_device_unregister(p->hwmon_dev); | 298 | hwmon_device_unregister(p->hwmon_dev); |
301 | of_iounmap(&op->resource[0], p->regs, REG_SIZE); | 299 | of_iounmap(&op->resource[0], p->regs, REG_SIZE); |
302 | kfree(p); | ||
303 | } | 300 | } |
304 | 301 | ||
305 | return 0; | 302 | return 0; |