diff options
-rw-r--r-- | include/linux/sched.h | 1 | ||||
-rw-r--r-- | kernel/sched/fair.c | 16 | ||||
-rw-r--r-- | mm/memory.c | 7 |
3 files changed, 19 insertions, 5 deletions
diff --git a/include/linux/sched.h b/include/linux/sched.h index 1127a46ac3d2..59f953b2e413 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h | |||
@@ -1454,6 +1454,7 @@ struct task_struct { | |||
1454 | 1454 | ||
1455 | #define TNF_MIGRATED 0x01 | 1455 | #define TNF_MIGRATED 0x01 |
1456 | #define TNF_NO_GROUP 0x02 | 1456 | #define TNF_NO_GROUP 0x02 |
1457 | #define TNF_SHARED 0x04 | ||
1457 | 1458 | ||
1458 | #ifdef CONFIG_NUMA_BALANCING | 1459 | #ifdef CONFIG_NUMA_BALANCING |
1459 | extern void task_numa_fault(int last_node, int node, int pages, int flags); | 1460 | extern void task_numa_fault(int last_node, int node, int pages, int flags); |
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 5166b9b1af70..222c2d0b6ae2 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c | |||
@@ -1381,7 +1381,7 @@ static void double_lock(spinlock_t *l1, spinlock_t *l2) | |||
1381 | spin_lock_nested(l2, SINGLE_DEPTH_NESTING); | 1381 | spin_lock_nested(l2, SINGLE_DEPTH_NESTING); |
1382 | } | 1382 | } |
1383 | 1383 | ||
1384 | static void task_numa_group(struct task_struct *p, int cpupid) | 1384 | static void task_numa_group(struct task_struct *p, int cpupid, int flags) |
1385 | { | 1385 | { |
1386 | struct numa_group *grp, *my_grp; | 1386 | struct numa_group *grp, *my_grp; |
1387 | struct task_struct *tsk; | 1387 | struct task_struct *tsk; |
@@ -1439,10 +1439,16 @@ static void task_numa_group(struct task_struct *p, int cpupid) | |||
1439 | if (my_grp->nr_tasks == grp->nr_tasks && my_grp > grp) | 1439 | if (my_grp->nr_tasks == grp->nr_tasks && my_grp > grp) |
1440 | goto unlock; | 1440 | goto unlock; |
1441 | 1441 | ||
1442 | if (!get_numa_group(grp)) | 1442 | /* Always join threads in the same process. */ |
1443 | goto unlock; | 1443 | if (tsk->mm == current->mm) |
1444 | join = true; | ||
1445 | |||
1446 | /* Simple filter to avoid false positives due to PID collisions */ | ||
1447 | if (flags & TNF_SHARED) | ||
1448 | join = true; | ||
1444 | 1449 | ||
1445 | join = true; | 1450 | if (join && !get_numa_group(grp)) |
1451 | join = false; | ||
1446 | 1452 | ||
1447 | unlock: | 1453 | unlock: |
1448 | rcu_read_unlock(); | 1454 | rcu_read_unlock(); |
@@ -1539,7 +1545,7 @@ void task_numa_fault(int last_cpupid, int node, int pages, int flags) | |||
1539 | } else { | 1545 | } else { |
1540 | priv = cpupid_match_pid(p, last_cpupid); | 1546 | priv = cpupid_match_pid(p, last_cpupid); |
1541 | if (!priv && !(flags & TNF_NO_GROUP)) | 1547 | if (!priv && !(flags & TNF_NO_GROUP)) |
1542 | task_numa_group(p, last_cpupid); | 1548 | task_numa_group(p, last_cpupid, flags); |
1543 | } | 1549 | } |
1544 | 1550 | ||
1545 | /* | 1551 | /* |
diff --git a/mm/memory.c b/mm/memory.c index 9898eeb9a21c..823720c43ea9 100644 --- a/mm/memory.c +++ b/mm/memory.c | |||
@@ -3584,6 +3584,13 @@ int do_numa_page(struct mm_struct *mm, struct vm_area_struct *vma, | |||
3584 | if (!pte_write(pte)) | 3584 | if (!pte_write(pte)) |
3585 | flags |= TNF_NO_GROUP; | 3585 | flags |= TNF_NO_GROUP; |
3586 | 3586 | ||
3587 | /* | ||
3588 | * Flag if the page is shared between multiple address spaces. This | ||
3589 | * is later used when determining whether to group tasks together | ||
3590 | */ | ||
3591 | if (page_mapcount(page) > 1 && (vma->vm_flags & VM_SHARED)) | ||
3592 | flags |= TNF_SHARED; | ||
3593 | |||
3587 | last_cpupid = page_cpupid_last(page); | 3594 | last_cpupid = page_cpupid_last(page); |
3588 | page_nid = page_to_nid(page); | 3595 | page_nid = page_to_nid(page); |
3589 | target_nid = numa_migrate_prep(page, vma, addr, page_nid); | 3596 | target_nid = numa_migrate_prep(page, vma, addr, page_nid); |