diff options
-rw-r--r-- | drivers/i2c/busses/i2c-cros-ec-tunnel.c | 6 | ||||
-rw-r--r-- | include/linux/mfd/cros_ec_commands.h | 3 |
2 files changed, 4 insertions, 5 deletions
diff --git a/drivers/i2c/busses/i2c-cros-ec-tunnel.c b/drivers/i2c/busses/i2c-cros-ec-tunnel.c index 0403ec1dc3b5..fc89c13b1632 100644 --- a/drivers/i2c/busses/i2c-cros-ec-tunnel.c +++ b/drivers/i2c/busses/i2c-cros-ec-tunnel.c | |||
@@ -94,7 +94,7 @@ static int ec_i2c_construct_message(u8 *buf, const struct i2c_msg i2c_msgs[], | |||
94 | msg->addr_flags = i2c_msg->addr; | 94 | msg->addr_flags = i2c_msg->addr; |
95 | 95 | ||
96 | if (i2c_msg->flags & I2C_M_TEN) | 96 | if (i2c_msg->flags & I2C_M_TEN) |
97 | msg->addr_flags |= EC_I2C_FLAG_10BIT; | 97 | return -EINVAL; |
98 | 98 | ||
99 | if (i2c_msg->flags & I2C_M_RD) { | 99 | if (i2c_msg->flags & I2C_M_RD) { |
100 | msg->addr_flags |= EC_I2C_FLAG_READ; | 100 | msg->addr_flags |= EC_I2C_FLAG_READ; |
@@ -218,7 +218,9 @@ static int ec_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg i2c_msgs[], | |||
218 | } | 218 | } |
219 | } | 219 | } |
220 | 220 | ||
221 | ec_i2c_construct_message(request, i2c_msgs, num, bus_num); | 221 | result = ec_i2c_construct_message(request, i2c_msgs, num, bus_num); |
222 | if (result) | ||
223 | goto exit; | ||
222 | 224 | ||
223 | msg.version = 0; | 225 | msg.version = 0; |
224 | msg.command = EC_CMD_I2C_PASSTHRU; | 226 | msg.command = EC_CMD_I2C_PASSTHRU; |
diff --git a/include/linux/mfd/cros_ec_commands.h b/include/linux/mfd/cros_ec_commands.h index 7853a6410d14..a49cd41feea7 100644 --- a/include/linux/mfd/cros_ec_commands.h +++ b/include/linux/mfd/cros_ec_commands.h | |||
@@ -1928,9 +1928,6 @@ struct ec_response_power_info { | |||
1928 | 1928 | ||
1929 | #define EC_CMD_I2C_PASSTHRU 0x9e | 1929 | #define EC_CMD_I2C_PASSTHRU 0x9e |
1930 | 1930 | ||
1931 | /* Slave address is 10 (not 7) bit */ | ||
1932 | #define EC_I2C_FLAG_10BIT (1 << 16) | ||
1933 | |||
1934 | /* Read data; if not present, message is a write */ | 1931 | /* Read data; if not present, message is a write */ |
1935 | #define EC_I2C_FLAG_READ (1 << 15) | 1932 | #define EC_I2C_FLAG_READ (1 << 15) |
1936 | 1933 | ||