diff options
| -rw-r--r-- | drivers/i2c/i2c-core.c | 7 | ||||
| -rw-r--r-- | drivers/media/video/cx23885/cx23885-i2c.c | 15 | ||||
| -rw-r--r-- | drivers/media/video/cx88/cx88-i2c.c | 19 | ||||
| -rw-r--r-- | include/linux/i2c.h | 3 |
4 files changed, 18 insertions, 26 deletions
diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c index cf14ca063181..6e1c2f54d9cf 100644 --- a/drivers/i2c/i2c-core.c +++ b/drivers/i2c/i2c-core.c | |||
| @@ -1461,6 +1461,13 @@ static int i2c_detect(struct i2c_adapter *adapter, struct i2c_driver *driver) | |||
| 1461 | return err; | 1461 | return err; |
| 1462 | } | 1462 | } |
| 1463 | 1463 | ||
| 1464 | int i2c_probe_func_quick_read(struct i2c_adapter *adap, unsigned short addr) | ||
| 1465 | { | ||
| 1466 | return i2c_smbus_xfer(adap, addr, 0, I2C_SMBUS_READ, 0, | ||
| 1467 | I2C_SMBUS_QUICK, NULL) >= 0; | ||
| 1468 | } | ||
| 1469 | EXPORT_SYMBOL_GPL(i2c_probe_func_quick_read); | ||
| 1470 | |||
| 1464 | struct i2c_client * | 1471 | struct i2c_client * |
| 1465 | i2c_new_probed_device(struct i2c_adapter *adap, | 1472 | i2c_new_probed_device(struct i2c_adapter *adap, |
| 1466 | struct i2c_board_info *info, | 1473 | struct i2c_board_info *info, |
diff --git a/drivers/media/video/cx23885/cx23885-i2c.c b/drivers/media/video/cx23885/cx23885-i2c.c index 1a391486e551..ed3d8f55029b 100644 --- a/drivers/media/video/cx23885/cx23885-i2c.c +++ b/drivers/media/video/cx23885/cx23885-i2c.c | |||
| @@ -364,17 +364,10 @@ int cx23885_i2c_register(struct cx23885_i2c *bus) | |||
| 364 | 364 | ||
| 365 | memset(&info, 0, sizeof(struct i2c_board_info)); | 365 | memset(&info, 0, sizeof(struct i2c_board_info)); |
| 366 | strlcpy(info.type, "ir_video", I2C_NAME_SIZE); | 366 | strlcpy(info.type, "ir_video", I2C_NAME_SIZE); |
| 367 | /* | 367 | /* Use quick read command for probe, some IR chips don't |
| 368 | * We can't call i2c_new_probed_device() because it uses | 368 | * support writes */ |
| 369 | * quick writes for probing and the IR receiver device only | 369 | i2c_new_probed_device(&bus->i2c_adap, &info, addr_list, |
| 370 | * replies to reads. | 370 | i2c_probe_func_quick_read); |
| 371 | */ | ||
| 372 | if (i2c_smbus_xfer(&bus->i2c_adap, addr_list[0], 0, | ||
| 373 | I2C_SMBUS_READ, 0, I2C_SMBUS_QUICK, | ||
| 374 | NULL) >= 0) { | ||
| 375 | info.addr = addr_list[0]; | ||
| 376 | i2c_new_device(&bus->i2c_adap, &info); | ||
| 377 | } | ||
| 378 | } | 371 | } |
| 379 | 372 | ||
| 380 | return bus->i2c_rc; | 373 | return bus->i2c_rc; |
diff --git a/drivers/media/video/cx88/cx88-i2c.c b/drivers/media/video/cx88/cx88-i2c.c index 375ad53f7961..82db555b22dd 100644 --- a/drivers/media/video/cx88/cx88-i2c.c +++ b/drivers/media/video/cx88/cx88-i2c.c | |||
| @@ -193,24 +193,13 @@ void cx88_i2c_init_ir(struct cx88_core *core) | |||
| 193 | 0x18, 0x6b, 0x71, | 193 | 0x18, 0x6b, 0x71, |
| 194 | I2C_CLIENT_END | 194 | I2C_CLIENT_END |
| 195 | }; | 195 | }; |
| 196 | const unsigned short *addrp; | ||
| 197 | 196 | ||
| 198 | memset(&info, 0, sizeof(struct i2c_board_info)); | 197 | memset(&info, 0, sizeof(struct i2c_board_info)); |
| 199 | strlcpy(info.type, "ir_video", I2C_NAME_SIZE); | 198 | strlcpy(info.type, "ir_video", I2C_NAME_SIZE); |
| 200 | /* | 199 | /* Use quick read command for probe, some IR chips don't |
| 201 | * We can't call i2c_new_probed_device() because it uses | 200 | * support writes */ |
| 202 | * quick writes for probing and at least some R receiver | 201 | i2c_new_probed_device(&core->i2c_adap, &info, addr_list, |
| 203 | * devices only reply to reads. | 202 | i2c_probe_func_quick_read); |
| 204 | */ | ||
| 205 | for (addrp = addr_list; *addrp != I2C_CLIENT_END; addrp++) { | ||
| 206 | if (i2c_smbus_xfer(&core->i2c_adap, *addrp, 0, | ||
| 207 | I2C_SMBUS_READ, 0, | ||
| 208 | I2C_SMBUS_QUICK, NULL) >= 0) { | ||
| 209 | info.addr = *addrp; | ||
| 210 | i2c_new_device(&core->i2c_adap, &info); | ||
| 211 | break; | ||
| 212 | } | ||
| 213 | } | ||
| 214 | } | 203 | } |
| 215 | } | 204 | } |
| 216 | 205 | ||
diff --git a/include/linux/i2c.h b/include/linux/i2c.h index 59a9f3cdc0b5..c8627e453e97 100644 --- a/include/linux/i2c.h +++ b/include/linux/i2c.h | |||
| @@ -294,6 +294,9 @@ i2c_new_probed_device(struct i2c_adapter *adap, | |||
| 294 | unsigned short const *addr_list, | 294 | unsigned short const *addr_list, |
| 295 | int (*probe)(struct i2c_adapter *, unsigned short addr)); | 295 | int (*probe)(struct i2c_adapter *, unsigned short addr)); |
| 296 | 296 | ||
| 297 | /* Common custom probe functions */ | ||
| 298 | extern int i2c_probe_func_quick_read(struct i2c_adapter *, unsigned short addr); | ||
| 299 | |||
| 297 | /* For devices that use several addresses, use i2c_new_dummy() to make | 300 | /* For devices that use several addresses, use i2c_new_dummy() to make |
| 298 | * client handles for the extra addresses. | 301 | * client handles for the extra addresses. |
| 299 | */ | 302 | */ |
