diff options
-rw-r--r-- | drivers/hsi/clients/nokia-modem.c | 8 | ||||
-rw-r--r-- | drivers/hsi/controllers/omap_ssi_port.c | 3 |
2 files changed, 5 insertions, 6 deletions
diff --git a/drivers/hsi/clients/nokia-modem.c b/drivers/hsi/clients/nokia-modem.c index 363b780dacea..f0c21458962c 100644 --- a/drivers/hsi/clients/nokia-modem.c +++ b/drivers/hsi/clients/nokia-modem.c | |||
@@ -29,7 +29,7 @@ | |||
29 | #include <linux/of_gpio.h> | 29 | #include <linux/of_gpio.h> |
30 | #include <linux/hsi/ssi_protocol.h> | 30 | #include <linux/hsi/ssi_protocol.h> |
31 | 31 | ||
32 | static unsigned int pm; | 32 | static unsigned int pm = 1; |
33 | module_param(pm, int, 0400); | 33 | module_param(pm, int, 0400); |
34 | MODULE_PARM_DESC(pm, | 34 | MODULE_PARM_DESC(pm, |
35 | "Enable power management (0=disabled, 1=userland based [default])"); | 35 | "Enable power management (0=disabled, 1=userland based [default])"); |
@@ -164,9 +164,9 @@ static int nokia_modem_probe(struct device *dev) | |||
164 | dev_set_drvdata(dev, modem); | 164 | dev_set_drvdata(dev, modem); |
165 | 165 | ||
166 | irq = irq_of_parse_and_map(np, 0); | 166 | irq = irq_of_parse_and_map(np, 0); |
167 | if (irq < 0) { | 167 | if (!irq) { |
168 | dev_err(dev, "Invalid rst_ind interrupt (%d)\n", irq); | 168 | dev_err(dev, "Invalid rst_ind interrupt (%d)\n", irq); |
169 | return irq; | 169 | return -EINVAL; |
170 | } | 170 | } |
171 | modem->nokia_modem_rst_ind_irq = irq; | 171 | modem->nokia_modem_rst_ind_irq = irq; |
172 | pflags = irq_get_trigger_type(irq); | 172 | pflags = irq_get_trigger_type(irq); |
@@ -174,7 +174,7 @@ static int nokia_modem_probe(struct device *dev) | |||
174 | tasklet_init(&modem->nokia_modem_rst_ind_tasklet, | 174 | tasklet_init(&modem->nokia_modem_rst_ind_tasklet, |
175 | do_nokia_modem_rst_ind_tasklet, (unsigned long)modem); | 175 | do_nokia_modem_rst_ind_tasklet, (unsigned long)modem); |
176 | err = devm_request_irq(dev, irq, nokia_modem_rst_ind_isr, | 176 | err = devm_request_irq(dev, irq, nokia_modem_rst_ind_isr, |
177 | IRQF_DISABLED | pflags, "modem_rst_ind", modem); | 177 | pflags, "modem_rst_ind", modem); |
178 | if (err < 0) { | 178 | if (err < 0) { |
179 | dev_err(dev, "Request rst_ind irq(%d) failed (flags %d)\n", | 179 | dev_err(dev, "Request rst_ind irq(%d) failed (flags %d)\n", |
180 | irq, pflags); | 180 | irq, pflags); |
diff --git a/drivers/hsi/controllers/omap_ssi_port.c b/drivers/hsi/controllers/omap_ssi_port.c index 1314ab80164b..1f8652b3de06 100644 --- a/drivers/hsi/controllers/omap_ssi_port.c +++ b/drivers/hsi/controllers/omap_ssi_port.c | |||
@@ -1118,8 +1118,7 @@ static int __init ssi_port_probe(struct platform_device *pd) | |||
1118 | dev_dbg(&pd->dev, "init ssi port...\n"); | 1118 | dev_dbg(&pd->dev, "init ssi port...\n"); |
1119 | 1119 | ||
1120 | if (!try_module_get(ssi->owner)) { | 1120 | if (!try_module_get(ssi->owner)) { |
1121 | dev_err(&pd->dev, "could not increment parent module refcount (err=%d)\n", | 1121 | dev_err(&pd->dev, "could not increment parent module refcount\n"); |
1122 | err); | ||
1123 | return -ENODEV; | 1122 | return -ENODEV; |
1124 | } | 1123 | } |
1125 | 1124 | ||