diff options
| -rw-r--r-- | fs/xfs/xfs_log.h | 2 | ||||
| -rw-r--r-- | fs/xfs/xfs_log_cil.c | 8 | ||||
| -rw-r--r-- | fs/xfs/xfs_trans.c | 5 |
3 files changed, 3 insertions, 12 deletions
diff --git a/fs/xfs/xfs_log.h b/fs/xfs/xfs_log.h index 916eb7db14d9..3bd3291ef8d2 100644 --- a/fs/xfs/xfs_log.h +++ b/fs/xfs/xfs_log.h | |||
| @@ -191,7 +191,7 @@ void xfs_log_ticket_put(struct xlog_ticket *ticket); | |||
| 191 | 191 | ||
| 192 | xlog_tid_t xfs_log_get_trans_ident(struct xfs_trans *tp); | 192 | xlog_tid_t xfs_log_get_trans_ident(struct xfs_trans *tp); |
| 193 | 193 | ||
| 194 | int xfs_log_commit_cil(struct xfs_mount *mp, struct xfs_trans *tp, | 194 | void xfs_log_commit_cil(struct xfs_mount *mp, struct xfs_trans *tp, |
| 195 | struct xfs_log_vec *log_vector, | 195 | struct xfs_log_vec *log_vector, |
| 196 | xfs_lsn_t *commit_lsn, int flags); | 196 | xfs_lsn_t *commit_lsn, int flags); |
| 197 | bool xfs_log_item_in_current_chkpt(struct xfs_log_item *lip); | 197 | bool xfs_log_item_in_current_chkpt(struct xfs_log_item *lip); |
diff --git a/fs/xfs/xfs_log_cil.c b/fs/xfs/xfs_log_cil.c index c7eac5acbfea..9ca59be08977 100644 --- a/fs/xfs/xfs_log_cil.c +++ b/fs/xfs/xfs_log_cil.c | |||
| @@ -625,7 +625,7 @@ out_abort: | |||
| 625 | * background commit, returns without it held once background commits are | 625 | * background commit, returns without it held once background commits are |
| 626 | * allowed again. | 626 | * allowed again. |
| 627 | */ | 627 | */ |
| 628 | int | 628 | void |
| 629 | xfs_log_commit_cil( | 629 | xfs_log_commit_cil( |
| 630 | struct xfs_mount *mp, | 630 | struct xfs_mount *mp, |
| 631 | struct xfs_trans *tp, | 631 | struct xfs_trans *tp, |
| @@ -640,11 +640,6 @@ xfs_log_commit_cil( | |||
| 640 | if (flags & XFS_TRANS_RELEASE_LOG_RES) | 640 | if (flags & XFS_TRANS_RELEASE_LOG_RES) |
| 641 | log_flags = XFS_LOG_REL_PERM_RESERV; | 641 | log_flags = XFS_LOG_REL_PERM_RESERV; |
| 642 | 642 | ||
| 643 | if (XLOG_FORCED_SHUTDOWN(log)) { | ||
| 644 | xlog_cil_free_logvec(log_vector); | ||
| 645 | return XFS_ERROR(EIO); | ||
| 646 | } | ||
| 647 | |||
| 648 | /* | 643 | /* |
| 649 | * do all the hard work of formatting items (including memory | 644 | * do all the hard work of formatting items (including memory |
| 650 | * allocation) outside the CIL context lock. This prevents stalling CIL | 645 | * allocation) outside the CIL context lock. This prevents stalling CIL |
| @@ -704,7 +699,6 @@ xfs_log_commit_cil( | |||
| 704 | */ | 699 | */ |
| 705 | if (push) | 700 | if (push) |
| 706 | xlog_cil_push(log, 0); | 701 | xlog_cil_push(log, 0); |
| 707 | return 0; | ||
| 708 | } | 702 | } |
| 709 | 703 | ||
| 710 | /* | 704 | /* |
diff --git a/fs/xfs/xfs_trans.c b/fs/xfs/xfs_trans.c index 29f5e5424897..76922793f64f 100644 --- a/fs/xfs/xfs_trans.c +++ b/fs/xfs/xfs_trans.c | |||
| @@ -1755,7 +1755,6 @@ xfs_trans_commit_cil( | |||
| 1755 | int flags) | 1755 | int flags) |
| 1756 | { | 1756 | { |
| 1757 | struct xfs_log_vec *log_vector; | 1757 | struct xfs_log_vec *log_vector; |
| 1758 | int error; | ||
| 1759 | 1758 | ||
| 1760 | /* | 1759 | /* |
| 1761 | * Get each log item to allocate a vector structure for | 1760 | * Get each log item to allocate a vector structure for |
| @@ -1766,9 +1765,7 @@ xfs_trans_commit_cil( | |||
| 1766 | if (!log_vector) | 1765 | if (!log_vector) |
| 1767 | return ENOMEM; | 1766 | return ENOMEM; |
| 1768 | 1767 | ||
| 1769 | error = xfs_log_commit_cil(mp, tp, log_vector, commit_lsn, flags); | 1768 | xfs_log_commit_cil(mp, tp, log_vector, commit_lsn, flags); |
| 1770 | if (error) | ||
| 1771 | return error; | ||
| 1772 | 1769 | ||
| 1773 | current_restore_flags_nested(&tp->t_pflags, PF_FSTRANS); | 1770 | current_restore_flags_nested(&tp->t_pflags, PF_FSTRANS); |
| 1774 | xfs_trans_free(tp); | 1771 | xfs_trans_free(tp); |
