aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--drivers/gpu/drm/vmwgfx/vmwgfx_kms.c12
1 files changed, 3 insertions, 9 deletions
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
index 00ec61921f2f..8b14dfd513a1 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
@@ -353,7 +353,6 @@ void vmw_framebuffer_surface_destroy(struct drm_framebuffer *framebuffer)
353static int do_surface_dirty_sou(struct vmw_private *dev_priv, 353static int do_surface_dirty_sou(struct vmw_private *dev_priv,
354 struct drm_file *file_priv, 354 struct drm_file *file_priv,
355 struct vmw_framebuffer *framebuffer, 355 struct vmw_framebuffer *framebuffer,
356 struct vmw_surface *surf,
357 unsigned flags, unsigned color, 356 unsigned flags, unsigned color,
358 struct drm_clip_rect *clips, 357 struct drm_clip_rect *clips,
359 unsigned num_clips, int inc) 358 unsigned num_clips, int inc)
@@ -381,7 +380,6 @@ static int do_surface_dirty_sou(struct vmw_private *dev_priv,
381 units[num_units++] = vmw_crtc_to_du(crtc); 380 units[num_units++] = vmw_crtc_to_du(crtc);
382 } 381 }
383 382
384 BUG_ON(surf == NULL);
385 BUG_ON(!clips || !num_clips); 383 BUG_ON(!clips || !num_clips);
386 384
387 fifo_size = sizeof(*cmd) + sizeof(SVGASignedRect) * num_clips; 385 fifo_size = sizeof(*cmd) + sizeof(SVGASignedRect) * num_clips;
@@ -476,7 +474,6 @@ int vmw_framebuffer_surface_dirty(struct drm_framebuffer *framebuffer,
476 struct vmw_master *vmaster = vmw_master(file_priv->master); 474 struct vmw_master *vmaster = vmw_master(file_priv->master);
477 struct vmw_framebuffer_surface *vfbs = 475 struct vmw_framebuffer_surface *vfbs =
478 vmw_framebuffer_to_vfbs(framebuffer); 476 vmw_framebuffer_to_vfbs(framebuffer);
479 struct vmw_surface *surf = vfbs->surface;
480 struct drm_clip_rect norect; 477 struct drm_clip_rect norect;
481 int ret, inc = 1; 478 int ret, inc = 1;
482 479
@@ -502,7 +499,7 @@ int vmw_framebuffer_surface_dirty(struct drm_framebuffer *framebuffer,
502 inc = 2; /* skip source rects */ 499 inc = 2; /* skip source rects */
503 } 500 }
504 501
505 ret = do_surface_dirty_sou(dev_priv, file_priv, &vfbs->base, surf, 502 ret = do_surface_dirty_sou(dev_priv, file_priv, &vfbs->base,
506 flags, color, 503 flags, color,
507 clips, num_clips, inc); 504 clips, num_clips, inc);
508 505
@@ -642,7 +639,6 @@ void vmw_framebuffer_dmabuf_destroy(struct drm_framebuffer *framebuffer)
642 639
643static int do_dmabuf_dirty_ldu(struct vmw_private *dev_priv, 640static int do_dmabuf_dirty_ldu(struct vmw_private *dev_priv,
644 struct vmw_framebuffer *framebuffer, 641 struct vmw_framebuffer *framebuffer,
645 struct vmw_dma_buffer *buffer,
646 unsigned flags, unsigned color, 642 unsigned flags, unsigned color,
647 struct drm_clip_rect *clips, 643 struct drm_clip_rect *clips,
648 unsigned num_clips, int increment) 644 unsigned num_clips, int increment)
@@ -722,7 +718,6 @@ static int do_dmabuf_define_gmrfb(struct drm_file *file_priv,
722static int do_dmabuf_dirty_sou(struct drm_file *file_priv, 718static int do_dmabuf_dirty_sou(struct drm_file *file_priv,
723 struct vmw_private *dev_priv, 719 struct vmw_private *dev_priv,
724 struct vmw_framebuffer *framebuffer, 720 struct vmw_framebuffer *framebuffer,
725 struct vmw_dma_buffer *buffer,
726 unsigned flags, unsigned color, 721 unsigned flags, unsigned color,
727 struct drm_clip_rect *clips, 722 struct drm_clip_rect *clips,
728 unsigned num_clips, int increment) 723 unsigned num_clips, int increment)
@@ -811,7 +806,6 @@ int vmw_framebuffer_dmabuf_dirty(struct drm_framebuffer *framebuffer,
811 struct vmw_master *vmaster = vmw_master(file_priv->master); 806 struct vmw_master *vmaster = vmw_master(file_priv->master);
812 struct vmw_framebuffer_dmabuf *vfbd = 807 struct vmw_framebuffer_dmabuf *vfbd =
813 vmw_framebuffer_to_vfbd(framebuffer); 808 vmw_framebuffer_to_vfbd(framebuffer);
814 struct vmw_dma_buffer *dmabuf = vfbd->buffer;
815 struct drm_clip_rect norect; 809 struct drm_clip_rect norect;
816 int ret, increment = 1; 810 int ret, increment = 1;
817 811
@@ -831,12 +825,12 @@ int vmw_framebuffer_dmabuf_dirty(struct drm_framebuffer *framebuffer,
831 } 825 }
832 826
833 if (dev_priv->ldu_priv) { 827 if (dev_priv->ldu_priv) {
834 ret = do_dmabuf_dirty_ldu(dev_priv, &vfbd->base, dmabuf, 828 ret = do_dmabuf_dirty_ldu(dev_priv, &vfbd->base,
835 flags, color, 829 flags, color,
836 clips, num_clips, increment); 830 clips, num_clips, increment);
837 } else { 831 } else {
838 ret = do_dmabuf_dirty_sou(file_priv, dev_priv, &vfbd->base, 832 ret = do_dmabuf_dirty_sou(file_priv, dev_priv, &vfbd->base,
839 dmabuf, flags, color, 833 flags, color,
840 clips, num_clips, increment); 834 clips, num_clips, increment);
841 } 835 }
842 836