diff options
-rw-r--r-- | Documentation/devicetree/bindings/pci/designware-pcie.txt | 2 | ||||
-rw-r--r-- | drivers/pci/host/pci-imx6.c | 27 |
2 files changed, 15 insertions, 14 deletions
diff --git a/Documentation/devicetree/bindings/pci/designware-pcie.txt b/Documentation/devicetree/bindings/pci/designware-pcie.txt index d5d26d443693..d6fae13ff062 100644 --- a/Documentation/devicetree/bindings/pci/designware-pcie.txt +++ b/Documentation/devicetree/bindings/pci/designware-pcie.txt | |||
@@ -19,6 +19,8 @@ Required properties: | |||
19 | to define the mapping of the PCIe interface to interrupt | 19 | to define the mapping of the PCIe interface to interrupt |
20 | numbers. | 20 | numbers. |
21 | - num-lanes: number of lanes to use | 21 | - num-lanes: number of lanes to use |
22 | |||
23 | Optional properties: | ||
22 | - reset-gpio: gpio pin number of power good signal | 24 | - reset-gpio: gpio pin number of power good signal |
23 | 25 | ||
24 | Optional properties for fsl,imx6q-pcie | 26 | Optional properties for fsl,imx6q-pcie |
diff --git a/drivers/pci/host/pci-imx6.c b/drivers/pci/host/pci-imx6.c index 9fc1cb66c64e..1176bddee1cc 100644 --- a/drivers/pci/host/pci-imx6.c +++ b/drivers/pci/host/pci-imx6.c | |||
@@ -214,9 +214,12 @@ static int imx6_pcie_assert_core_reset(struct pcie_port *pp) | |||
214 | regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR1, | 214 | regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR1, |
215 | IMX6Q_GPR1_PCIE_REF_CLK_EN, 0 << 16); | 215 | IMX6Q_GPR1_PCIE_REF_CLK_EN, 0 << 16); |
216 | 216 | ||
217 | gpio_set_value(imx6_pcie->reset_gpio, 0); | 217 | /* Some boards don't have PCIe reset GPIO. */ |
218 | msleep(100); | 218 | if (gpio_is_valid(imx6_pcie->reset_gpio)) { |
219 | gpio_set_value(imx6_pcie->reset_gpio, 1); | 219 | gpio_set_value(imx6_pcie->reset_gpio, 0); |
220 | msleep(100); | ||
221 | gpio_set_value(imx6_pcie->reset_gpio, 1); | ||
222 | } | ||
220 | 223 | ||
221 | return 0; | 224 | return 0; |
222 | } | 225 | } |
@@ -432,17 +435,13 @@ static int __init imx6_pcie_probe(struct platform_device *pdev) | |||
432 | 435 | ||
433 | /* Fetch GPIOs */ | 436 | /* Fetch GPIOs */ |
434 | imx6_pcie->reset_gpio = of_get_named_gpio(np, "reset-gpio", 0); | 437 | imx6_pcie->reset_gpio = of_get_named_gpio(np, "reset-gpio", 0); |
435 | if (!gpio_is_valid(imx6_pcie->reset_gpio)) { | 438 | if (gpio_is_valid(imx6_pcie->reset_gpio)) { |
436 | dev_err(&pdev->dev, "no reset-gpio defined\n"); | 439 | ret = devm_gpio_request_one(&pdev->dev, imx6_pcie->reset_gpio, |
437 | ret = -ENODEV; | 440 | GPIOF_OUT_INIT_LOW, "PCIe reset"); |
438 | } | 441 | if (ret) { |
439 | ret = devm_gpio_request_one(&pdev->dev, | 442 | dev_err(&pdev->dev, "unable to get reset gpio\n"); |
440 | imx6_pcie->reset_gpio, | 443 | return ret; |
441 | GPIOF_OUT_INIT_LOW, | 444 | } |
442 | "PCIe reset"); | ||
443 | if (ret) { | ||
444 | dev_err(&pdev->dev, "unable to get reset gpio\n"); | ||
445 | return ret; | ||
446 | } | 445 | } |
447 | 446 | ||
448 | imx6_pcie->power_on_gpio = of_get_named_gpio(np, "power-on-gpio", 0); | 447 | imx6_pcie->power_on_gpio = of_get_named_gpio(np, "power-on-gpio", 0); |