aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--drivers/gpu/drm/msm/Makefile1
-rw-r--r--drivers/gpu/drm/msm/hdmi/hdmi.c8
-rw-r--r--drivers/gpu/drm/msm/hdmi/hdmi.h25
-rw-r--r--drivers/gpu/drm/msm/hdmi/hdmi_audio.c273
-rw-r--r--drivers/gpu/drm/msm/hdmi/hdmi_bridge.c26
5 files changed, 317 insertions, 16 deletions
diff --git a/drivers/gpu/drm/msm/Makefile b/drivers/gpu/drm/msm/Makefile
index 4f977a593bea..5e1e6b0cd8ac 100644
--- a/drivers/gpu/drm/msm/Makefile
+++ b/drivers/gpu/drm/msm/Makefile
@@ -7,6 +7,7 @@ msm-y := \
7 adreno/adreno_gpu.o \ 7 adreno/adreno_gpu.o \
8 adreno/a3xx_gpu.o \ 8 adreno/a3xx_gpu.o \
9 hdmi/hdmi.o \ 9 hdmi/hdmi.o \
10 hdmi/hdmi_audio.o \
10 hdmi/hdmi_bridge.o \ 11 hdmi/hdmi_bridge.o \
11 hdmi/hdmi_connector.o \ 12 hdmi/hdmi_connector.o \
12 hdmi/hdmi_i2c.o \ 13 hdmi/hdmi_i2c.o \
diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c
index 6f1588aa9071..6048b6b2a8c7 100644
--- a/drivers/gpu/drm/msm/hdmi/hdmi.c
+++ b/drivers/gpu/drm/msm/hdmi/hdmi.c
@@ -67,6 +67,8 @@ void hdmi_destroy(struct kref *kref)
67 if (hdmi->i2c) 67 if (hdmi->i2c)
68 hdmi_i2c_destroy(hdmi->i2c); 68 hdmi_i2c_destroy(hdmi->i2c);
69 69
70 platform_set_drvdata(hdmi->pdev, NULL);
71
70 put_device(&hdmi->pdev->dev); 72 put_device(&hdmi->pdev->dev);
71} 73}
72 74
@@ -102,6 +104,8 @@ struct hdmi *hdmi_init(struct drm_device *dev, struct drm_encoder *encoder)
102 hdmi->config = config; 104 hdmi->config = config;
103 hdmi->encoder = encoder; 105 hdmi->encoder = encoder;
104 106
107 hdmi_audio_infoframe_init(&hdmi->audio.infoframe);
108
105 /* not sure about which phy maps to which msm.. probably I miss some */ 109 /* not sure about which phy maps to which msm.. probably I miss some */
106 if (config->phy_init) 110 if (config->phy_init)
107 hdmi->phy = config->phy_init(hdmi); 111 hdmi->phy = config->phy_init(hdmi);
@@ -228,6 +232,8 @@ struct hdmi *hdmi_init(struct drm_device *dev, struct drm_encoder *encoder)
228 priv->bridges[priv->num_bridges++] = hdmi->bridge; 232 priv->bridges[priv->num_bridges++] = hdmi->bridge;
229 priv->connectors[priv->num_connectors++] = hdmi->connector; 233 priv->connectors[priv->num_connectors++] = hdmi->connector;
230 234
235 platform_set_drvdata(pdev, hdmi);
236
231 return hdmi; 237 return hdmi;
232 238
233fail: 239fail:
@@ -305,7 +311,7 @@ static int hdmi_dev_probe(struct platform_device *pdev)
305 config.ddc_data_gpio = 71; 311 config.ddc_data_gpio = 71;
306 config.hpd_gpio = 72; 312 config.hpd_gpio = 72;
307 config.mux_en_gpio = -1; 313 config.mux_en_gpio = -1;
308 config.mux_sel_gpio = 13 + NR_GPIO_IRQS; 314 config.mux_sel_gpio = -1;
309 } else if (cpu_is_msm8960() || cpu_is_msm8960ab()) { 315 } else if (cpu_is_msm8960() || cpu_is_msm8960ab()) {
310 static const char *hpd_reg_names[] = {"8921_hdmi_mvs"}; 316 static const char *hpd_reg_names[] = {"8921_hdmi_mvs"};
311 config.phy_init = hdmi_phy_8960_init; 317 config.phy_init = hdmi_phy_8960_init;
diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.h b/drivers/gpu/drm/msm/hdmi/hdmi.h
index 41b29add70b1..9fafee6a3e43 100644
--- a/drivers/gpu/drm/msm/hdmi/hdmi.h
+++ b/drivers/gpu/drm/msm/hdmi/hdmi.h
@@ -22,6 +22,7 @@
22#include <linux/clk.h> 22#include <linux/clk.h>
23#include <linux/platform_device.h> 23#include <linux/platform_device.h>
24#include <linux/regulator/consumer.h> 24#include <linux/regulator/consumer.h>
25#include <linux/hdmi.h>
25 26
26#include "msm_drv.h" 27#include "msm_drv.h"
27#include "hdmi.xml.h" 28#include "hdmi.xml.h"
@@ -30,6 +31,12 @@
30struct hdmi_phy; 31struct hdmi_phy;
31struct hdmi_platform_config; 32struct hdmi_platform_config;
32 33
34struct hdmi_audio {
35 bool enabled;
36 struct hdmi_audio_infoframe infoframe;
37 int rate;
38};
39
33struct hdmi { 40struct hdmi {
34 struct kref refcount; 41 struct kref refcount;
35 42
@@ -38,6 +45,13 @@ struct hdmi {
38 45
39 const struct hdmi_platform_config *config; 46 const struct hdmi_platform_config *config;
40 47
48 /* audio state: */
49 struct hdmi_audio audio;
50
51 /* video state: */
52 bool power_on;
53 unsigned long int pixclock;
54
41 void __iomem *mmio; 55 void __iomem *mmio;
42 56
43 struct regulator *hpd_regs[2]; 57 struct regulator *hpd_regs[2];
@@ -132,6 +146,17 @@ struct hdmi_phy *hdmi_phy_8x60_init(struct hdmi *hdmi);
132struct hdmi_phy *hdmi_phy_8x74_init(struct hdmi *hdmi); 146struct hdmi_phy *hdmi_phy_8x74_init(struct hdmi *hdmi);
133 147
134/* 148/*
149 * audio:
150 */
151
152int hdmi_audio_update(struct hdmi *hdmi);
153int hdmi_audio_info_setup(struct hdmi *hdmi, bool enabled,
154 uint32_t num_of_channels, uint32_t channel_allocation,
155 uint32_t level_shift, bool down_mix);
156void hdmi_audio_set_sample_rate(struct hdmi *hdmi, int rate);
157
158
159/*
135 * hdmi bridge: 160 * hdmi bridge:
136 */ 161 */
137 162
diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_audio.c b/drivers/gpu/drm/msm/hdmi/hdmi_audio.c
new file mode 100644
index 000000000000..872485f60134
--- /dev/null
+++ b/drivers/gpu/drm/msm/hdmi/hdmi_audio.c
@@ -0,0 +1,273 @@
1/*
2 * Copyright (C) 2013 Red Hat
3 * Author: Rob Clark <robdclark@gmail.com>
4 *
5 * This program is free software; you can redistribute it and/or modify it
6 * under the terms of the GNU General Public License version 2 as published by
7 * the Free Software Foundation.
8 *
9 * This program is distributed in the hope that it will be useful, but WITHOUT
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
12 * more details.
13 *
14 * You should have received a copy of the GNU General Public License along with
15 * this program. If not, see <http://www.gnu.org/licenses/>.
16 */
17
18#include <linux/hdmi.h>
19#include "hdmi.h"
20
21
22/* Supported HDMI Audio channels */
23#define MSM_HDMI_AUDIO_CHANNEL_2 0
24#define MSM_HDMI_AUDIO_CHANNEL_4 1
25#define MSM_HDMI_AUDIO_CHANNEL_6 2
26#define MSM_HDMI_AUDIO_CHANNEL_8 3
27
28/* maps MSM_HDMI_AUDIO_CHANNEL_n consts used by audio driver to # of channels: */
29static int nchannels[] = { 2, 4, 6, 8 };
30
31/* Supported HDMI Audio sample rates */
32#define MSM_HDMI_SAMPLE_RATE_32KHZ 0
33#define MSM_HDMI_SAMPLE_RATE_44_1KHZ 1
34#define MSM_HDMI_SAMPLE_RATE_48KHZ 2
35#define MSM_HDMI_SAMPLE_RATE_88_2KHZ 3
36#define MSM_HDMI_SAMPLE_RATE_96KHZ 4
37#define MSM_HDMI_SAMPLE_RATE_176_4KHZ 5
38#define MSM_HDMI_SAMPLE_RATE_192KHZ 6
39#define MSM_HDMI_SAMPLE_RATE_MAX 7
40
41
42struct hdmi_msm_audio_acr {
43 uint32_t n; /* N parameter for clock regeneration */
44 uint32_t cts; /* CTS parameter for clock regeneration */
45};
46
47struct hdmi_msm_audio_arcs {
48 unsigned long int pixclock;
49 struct hdmi_msm_audio_acr lut[MSM_HDMI_SAMPLE_RATE_MAX];
50};
51
52#define HDMI_MSM_AUDIO_ARCS(pclk, ...) { (1000 * (pclk)), __VA_ARGS__ }
53
54/* Audio constants lookup table for hdmi_msm_audio_acr_setup */
55/* Valid Pixel-Clock rates: 25.2MHz, 27MHz, 27.03MHz, 74.25MHz, 148.5MHz */
56static const struct hdmi_msm_audio_arcs acr_lut[] = {
57 /* 25.200MHz */
58 HDMI_MSM_AUDIO_ARCS(25200, {
59 {4096, 25200}, {6272, 28000}, {6144, 25200}, {12544, 28000},
60 {12288, 25200}, {25088, 28000}, {24576, 25200} }),
61 /* 27.000MHz */
62 HDMI_MSM_AUDIO_ARCS(27000, {
63 {4096, 27000}, {6272, 30000}, {6144, 27000}, {12544, 30000},
64 {12288, 27000}, {25088, 30000}, {24576, 27000} }),
65 /* 27.027MHz */
66 HDMI_MSM_AUDIO_ARCS(27030, {
67 {4096, 27027}, {6272, 30030}, {6144, 27027}, {12544, 30030},
68 {12288, 27027}, {25088, 30030}, {24576, 27027} }),
69 /* 74.250MHz */
70 HDMI_MSM_AUDIO_ARCS(74250, {
71 {4096, 74250}, {6272, 82500}, {6144, 74250}, {12544, 82500},
72 {12288, 74250}, {25088, 82500}, {24576, 74250} }),
73 /* 148.500MHz */
74 HDMI_MSM_AUDIO_ARCS(148500, {
75 {4096, 148500}, {6272, 165000}, {6144, 148500}, {12544, 165000},
76 {12288, 148500}, {25088, 165000}, {24576, 148500} }),
77};
78
79static const struct hdmi_msm_audio_arcs *get_arcs(unsigned long int pixclock)
80{
81 int i;
82
83 for (i = 0; i < ARRAY_SIZE(acr_lut); i++) {
84 const struct hdmi_msm_audio_arcs *arcs = &acr_lut[i];
85 if (arcs->pixclock == pixclock)
86 return arcs;
87 }
88
89 return NULL;
90}
91
92int hdmi_audio_update(struct hdmi *hdmi)
93{
94 struct hdmi_audio *audio = &hdmi->audio;
95 struct hdmi_audio_infoframe *info = &audio->infoframe;
96 const struct hdmi_msm_audio_arcs *arcs = NULL;
97 bool enabled = audio->enabled;
98 uint32_t acr_pkt_ctrl, vbi_pkt_ctrl, aud_pkt_ctrl;
99 uint32_t infofrm_ctrl, audio_config;
100
101 DBG("audio: enabled=%d, channels=%d, channel_allocation=0x%x, "
102 "level_shift_value=%d, downmix_inhibit=%d, rate=%d",
103 audio->enabled, info->channels, info->channel_allocation,
104 info->level_shift_value, info->downmix_inhibit, audio->rate);
105 DBG("video: power_on=%d, pixclock=%lu", hdmi->power_on, hdmi->pixclock);
106
107 if (enabled && !(hdmi->power_on && hdmi->pixclock)) {
108 DBG("disabling audio: no video");
109 enabled = false;
110 }
111
112 if (enabled) {
113 arcs = get_arcs(hdmi->pixclock);
114 if (!arcs) {
115 DBG("disabling audio: unsupported pixclock: %lu",
116 hdmi->pixclock);
117 enabled = false;
118 }
119 }
120
121 /* Read first before writing */
122 acr_pkt_ctrl = hdmi_read(hdmi, REG_HDMI_ACR_PKT_CTRL);
123 vbi_pkt_ctrl = hdmi_read(hdmi, REG_HDMI_VBI_PKT_CTRL);
124 aud_pkt_ctrl = hdmi_read(hdmi, REG_HDMI_AUDIO_PKT_CTRL1);
125 infofrm_ctrl = hdmi_read(hdmi, REG_HDMI_INFOFRAME_CTRL0);
126 audio_config = hdmi_read(hdmi, REG_HDMI_AUDIO_CFG);
127
128 /* Clear N/CTS selection bits */
129 acr_pkt_ctrl &= ~HDMI_ACR_PKT_CTRL_SELECT__MASK;
130
131 if (enabled) {
132 uint32_t n, cts, multiplier;
133 enum hdmi_acr_cts select;
134 uint8_t buf[14];
135
136 n = arcs->lut[audio->rate].n;
137 cts = arcs->lut[audio->rate].cts;
138
139 if ((MSM_HDMI_SAMPLE_RATE_192KHZ == audio->rate) ||
140 (MSM_HDMI_SAMPLE_RATE_176_4KHZ == audio->rate)) {
141 multiplier = 4;
142 n >>= 2; /* divide N by 4 and use multiplier */
143 } else if ((MSM_HDMI_SAMPLE_RATE_96KHZ == audio->rate) ||
144 (MSM_HDMI_SAMPLE_RATE_88_2KHZ == audio->rate)) {
145 multiplier = 2;
146 n >>= 1; /* divide N by 2 and use multiplier */
147 } else {
148 multiplier = 1;
149 }
150
151 DBG("n=%u, cts=%u, multiplier=%u", n, cts, multiplier);
152
153 acr_pkt_ctrl |= HDMI_ACR_PKT_CTRL_SOURCE;
154 acr_pkt_ctrl |= HDMI_ACR_PKT_CTRL_AUDIO_PRIORITY;
155 acr_pkt_ctrl |= HDMI_ACR_PKT_CTRL_N_MULTIPLIER(multiplier);
156
157 if ((MSM_HDMI_SAMPLE_RATE_48KHZ == audio->rate) ||
158 (MSM_HDMI_SAMPLE_RATE_96KHZ == audio->rate) ||
159 (MSM_HDMI_SAMPLE_RATE_192KHZ == audio->rate))
160 select = ACR_48;
161 else if ((MSM_HDMI_SAMPLE_RATE_44_1KHZ == audio->rate) ||
162 (MSM_HDMI_SAMPLE_RATE_88_2KHZ == audio->rate) ||
163 (MSM_HDMI_SAMPLE_RATE_176_4KHZ == audio->rate))
164 select = ACR_44;
165 else /* default to 32k */
166 select = ACR_32;
167
168 acr_pkt_ctrl |= HDMI_ACR_PKT_CTRL_SELECT(select);
169
170 hdmi_write(hdmi, REG_HDMI_ACR_0(select - 1),
171 HDMI_ACR_0_CTS(cts));
172 hdmi_write(hdmi, REG_HDMI_ACR_1(select - 1),
173 HDMI_ACR_1_N(n));
174
175 hdmi_write(hdmi, REG_HDMI_AUDIO_PKT_CTRL2,
176 COND(info->channels != 2, HDMI_AUDIO_PKT_CTRL2_LAYOUT) |
177 HDMI_AUDIO_PKT_CTRL2_OVERRIDE);
178
179 acr_pkt_ctrl |= HDMI_ACR_PKT_CTRL_CONT;
180 acr_pkt_ctrl |= HDMI_ACR_PKT_CTRL_SEND;
181
182 /* configure infoframe: */
183 hdmi_audio_infoframe_pack(info, buf, sizeof(buf));
184 hdmi_write(hdmi, REG_HDMI_AUDIO_INFO0,
185 (buf[3] << 0) || (buf[4] << 8) ||
186 (buf[5] << 16) || (buf[6] << 24));
187 hdmi_write(hdmi, REG_HDMI_AUDIO_INFO1,
188 (buf[7] << 0) || (buf[8] << 8));
189
190 hdmi_write(hdmi, REG_HDMI_GC, 0);
191
192 vbi_pkt_ctrl |= HDMI_VBI_PKT_CTRL_GC_ENABLE;
193 vbi_pkt_ctrl |= HDMI_VBI_PKT_CTRL_GC_EVERY_FRAME;
194
195 aud_pkt_ctrl |= HDMI_AUDIO_PKT_CTRL1_AUDIO_SAMPLE_SEND;
196
197 infofrm_ctrl |= HDMI_INFOFRAME_CTRL0_AUDIO_INFO_SEND;
198 infofrm_ctrl |= HDMI_INFOFRAME_CTRL0_AUDIO_INFO_CONT;
199 infofrm_ctrl |= HDMI_INFOFRAME_CTRL0_AUDIO_INFO_SOURCE;
200 infofrm_ctrl |= HDMI_INFOFRAME_CTRL0_AUDIO_INFO_UPDATE;
201
202 audio_config &= ~HDMI_AUDIO_CFG_FIFO_WATERMARK__MASK;
203 audio_config |= HDMI_AUDIO_CFG_FIFO_WATERMARK(4);
204 audio_config |= HDMI_AUDIO_CFG_ENGINE_ENABLE;
205 } else {
206 hdmi_write(hdmi, REG_HDMI_GC, HDMI_GC_MUTE);
207 acr_pkt_ctrl &= ~HDMI_ACR_PKT_CTRL_CONT;
208 acr_pkt_ctrl &= ~HDMI_ACR_PKT_CTRL_SEND;
209 vbi_pkt_ctrl &= ~HDMI_VBI_PKT_CTRL_GC_ENABLE;
210 vbi_pkt_ctrl &= ~HDMI_VBI_PKT_CTRL_GC_EVERY_FRAME;
211 aud_pkt_ctrl &= ~HDMI_AUDIO_PKT_CTRL1_AUDIO_SAMPLE_SEND;
212 infofrm_ctrl &= ~HDMI_INFOFRAME_CTRL0_AUDIO_INFO_SEND;
213 infofrm_ctrl &= ~HDMI_INFOFRAME_CTRL0_AUDIO_INFO_CONT;
214 infofrm_ctrl &= ~HDMI_INFOFRAME_CTRL0_AUDIO_INFO_SOURCE;
215 infofrm_ctrl &= ~HDMI_INFOFRAME_CTRL0_AUDIO_INFO_UPDATE;
216 audio_config &= ~HDMI_AUDIO_CFG_ENGINE_ENABLE;
217 }
218
219 hdmi_write(hdmi, REG_HDMI_ACR_PKT_CTRL, acr_pkt_ctrl);
220 hdmi_write(hdmi, REG_HDMI_VBI_PKT_CTRL, vbi_pkt_ctrl);
221 hdmi_write(hdmi, REG_HDMI_AUDIO_PKT_CTRL1, aud_pkt_ctrl);
222 hdmi_write(hdmi, REG_HDMI_INFOFRAME_CTRL0, infofrm_ctrl);
223
224 hdmi_write(hdmi, REG_HDMI_AUD_INT,
225 COND(enabled, HDMI_AUD_INT_AUD_FIFO_URUN_INT) |
226 COND(enabled, HDMI_AUD_INT_AUD_SAM_DROP_INT));
227
228 hdmi_write(hdmi, REG_HDMI_AUDIO_CFG, audio_config);
229
230
231 DBG("audio %sabled", enabled ? "en" : "dis");
232
233 return 0;
234}
235
236int hdmi_audio_info_setup(struct hdmi *hdmi, bool enabled,
237 uint32_t num_of_channels, uint32_t channel_allocation,
238 uint32_t level_shift, bool down_mix)
239{
240 struct hdmi_audio *audio;
241
242 if (!hdmi)
243 return -ENXIO;
244
245 audio = &hdmi->audio;
246
247 if (num_of_channels >= ARRAY_SIZE(nchannels))
248 return -EINVAL;
249
250 audio->enabled = enabled;
251 audio->infoframe.channels = nchannels[num_of_channels];
252 audio->infoframe.channel_allocation = channel_allocation;
253 audio->infoframe.level_shift_value = level_shift;
254 audio->infoframe.downmix_inhibit = down_mix;
255
256 return hdmi_audio_update(hdmi);
257}
258
259void hdmi_audio_set_sample_rate(struct hdmi *hdmi, int rate)
260{
261 struct hdmi_audio *audio;
262
263 if (!hdmi)
264 return;
265
266 audio = &hdmi->audio;
267
268 if ((rate < 0) || (rate >= MSM_HDMI_SAMPLE_RATE_MAX))
269 return;
270
271 audio->rate = rate;
272 hdmi_audio_update(hdmi);
273}
diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c b/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c
index 7d10e55403c6..f6cf745c249e 100644
--- a/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c
+++ b/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c
@@ -19,11 +19,7 @@
19 19
20struct hdmi_bridge { 20struct hdmi_bridge {
21 struct drm_bridge base; 21 struct drm_bridge base;
22
23 struct hdmi *hdmi; 22 struct hdmi *hdmi;
24 bool power_on;
25
26 unsigned long int pixclock;
27}; 23};
28#define to_hdmi_bridge(x) container_of(x, struct hdmi_bridge, base) 24#define to_hdmi_bridge(x) container_of(x, struct hdmi_bridge, base)
29 25
@@ -52,8 +48,8 @@ static void power_on(struct drm_bridge *bridge)
52 } 48 }
53 49
54 if (config->pwr_clk_cnt > 0) { 50 if (config->pwr_clk_cnt > 0) {
55 DBG("pixclock: %lu", hdmi_bridge->pixclock); 51 DBG("pixclock: %lu", hdmi->pixclock);
56 ret = clk_set_rate(hdmi->pwr_clks[0], hdmi_bridge->pixclock); 52 ret = clk_set_rate(hdmi->pwr_clks[0], hdmi->pixclock);
57 if (ret) { 53 if (ret) {
58 dev_err(dev->dev, "failed to set pixel clk: %s (%d)\n", 54 dev_err(dev->dev, "failed to set pixel clk: %s (%d)\n",
59 config->pwr_clk_names[0], ret); 55 config->pwr_clk_names[0], ret);
@@ -102,12 +98,13 @@ static void hdmi_bridge_pre_enable(struct drm_bridge *bridge)
102 98
103 DBG("power up"); 99 DBG("power up");
104 100
105 if (!hdmi_bridge->power_on) { 101 if (!hdmi->power_on) {
106 power_on(bridge); 102 power_on(bridge);
107 hdmi_bridge->power_on = true; 103 hdmi->power_on = true;
104 hdmi_audio_update(hdmi);
108 } 105 }
109 106
110 phy->funcs->powerup(phy, hdmi_bridge->pixclock); 107 phy->funcs->powerup(phy, hdmi->pixclock);
111 hdmi_set_mode(hdmi, true); 108 hdmi_set_mode(hdmi, true);
112} 109}
113 110
@@ -129,9 +126,10 @@ static void hdmi_bridge_post_disable(struct drm_bridge *bridge)
129 hdmi_set_mode(hdmi, false); 126 hdmi_set_mode(hdmi, false);
130 phy->funcs->powerdown(phy); 127 phy->funcs->powerdown(phy);
131 128
132 if (hdmi_bridge->power_on) { 129 if (hdmi->power_on) {
133 power_off(bridge); 130 power_off(bridge);
134 hdmi_bridge->power_on = false; 131 hdmi->power_on = false;
132 hdmi_audio_update(hdmi);
135 } 133 }
136} 134}
137 135
@@ -146,7 +144,7 @@ static void hdmi_bridge_mode_set(struct drm_bridge *bridge,
146 144
147 mode = adjusted_mode; 145 mode = adjusted_mode;
148 146
149 hdmi_bridge->pixclock = mode->clock * 1000; 147 hdmi->pixclock = mode->clock * 1000;
150 148
151 hdmi->hdmi_mode = drm_match_cea_mode(mode) > 1; 149 hdmi->hdmi_mode = drm_match_cea_mode(mode) > 1;
152 150
@@ -194,9 +192,7 @@ static void hdmi_bridge_mode_set(struct drm_bridge *bridge,
194 DBG("frame_ctrl=%08x", frame_ctrl); 192 DBG("frame_ctrl=%08x", frame_ctrl);
195 hdmi_write(hdmi, REG_HDMI_FRAME_CTRL, frame_ctrl); 193 hdmi_write(hdmi, REG_HDMI_FRAME_CTRL, frame_ctrl);
196 194
197 // TODO until we have audio, this might be safest: 195 hdmi_audio_update(hdmi);
198 if (hdmi->hdmi_mode)
199 hdmi_write(hdmi, REG_HDMI_GC, HDMI_GC_MUTE);
200} 196}
201 197
202static const struct drm_bridge_funcs hdmi_bridge_funcs = { 198static const struct drm_bridge_funcs hdmi_bridge_funcs = {