diff options
| -rw-r--r-- | fs/xfs/xfs_vnodeops.c | 14 |
1 files changed, 10 insertions, 4 deletions
diff --git a/fs/xfs/xfs_vnodeops.c b/fs/xfs/xfs_vnodeops.c index 4ecf2a549060..ce9268a2f56b 100644 --- a/fs/xfs/xfs_vnodeops.c +++ b/fs/xfs/xfs_vnodeops.c | |||
| @@ -112,7 +112,7 @@ xfs_readlink( | |||
| 112 | char *link) | 112 | char *link) |
| 113 | { | 113 | { |
| 114 | xfs_mount_t *mp = ip->i_mount; | 114 | xfs_mount_t *mp = ip->i_mount; |
| 115 | int pathlen; | 115 | xfs_fsize_t pathlen; |
| 116 | int error = 0; | 116 | int error = 0; |
| 117 | 117 | ||
| 118 | trace_xfs_readlink(ip); | 118 | trace_xfs_readlink(ip); |
| @@ -122,13 +122,19 @@ xfs_readlink( | |||
| 122 | 122 | ||
| 123 | xfs_ilock(ip, XFS_ILOCK_SHARED); | 123 | xfs_ilock(ip, XFS_ILOCK_SHARED); |
| 124 | 124 | ||
| 125 | ASSERT(S_ISLNK(ip->i_d.di_mode)); | ||
| 126 | ASSERT(ip->i_d.di_size <= MAXPATHLEN); | ||
| 127 | |||
| 128 | pathlen = ip->i_d.di_size; | 125 | pathlen = ip->i_d.di_size; |
| 129 | if (!pathlen) | 126 | if (!pathlen) |
| 130 | goto out; | 127 | goto out; |
| 131 | 128 | ||
| 129 | if (pathlen < 0 || pathlen > MAXPATHLEN) { | ||
| 130 | xfs_alert(mp, "%s: inode (%llu) bad symlink length (%lld)", | ||
| 131 | __func__, (unsigned long long) ip->i_ino, | ||
| 132 | (long long) pathlen); | ||
| 133 | ASSERT(0); | ||
| 134 | return XFS_ERROR(EFSCORRUPTED); | ||
| 135 | } | ||
| 136 | |||
| 137 | |||
| 132 | if (ip->i_df.if_flags & XFS_IFINLINE) { | 138 | if (ip->i_df.if_flags & XFS_IFINLINE) { |
| 133 | memcpy(link, ip->i_df.if_u1.if_data, pathlen); | 139 | memcpy(link, ip->i_df.if_u1.if_data, pathlen); |
| 134 | link[pathlen] = '\0'; | 140 | link[pathlen] = '\0'; |
