diff options
| -rw-r--r-- | fs/proc/generic.c | 8 | ||||
| -rw-r--r-- | fs/proc/inode.c | 3 | ||||
| -rw-r--r-- | fs/proc/proc_net.c | 2 | ||||
| -rw-r--r-- | fs/proc/root.c | 8 |
4 files changed, 4 insertions, 17 deletions
diff --git a/fs/proc/generic.c b/fs/proc/generic.c index 60a359b35582..db7fa5cab988 100644 --- a/fs/proc/generic.c +++ b/fs/proc/generic.c | |||
| @@ -14,7 +14,6 @@ | |||
| 14 | #include <linux/stat.h> | 14 | #include <linux/stat.h> |
| 15 | #include <linux/module.h> | 15 | #include <linux/module.h> |
| 16 | #include <linux/mount.h> | 16 | #include <linux/mount.h> |
| 17 | #include <linux/smp_lock.h> | ||
| 18 | #include <linux/init.h> | 17 | #include <linux/init.h> |
| 19 | #include <linux/idr.h> | 18 | #include <linux/idr.h> |
| 20 | #include <linux/namei.h> | 19 | #include <linux/namei.h> |
| @@ -379,7 +378,6 @@ struct dentry *proc_lookup_de(struct proc_dir_entry *de, struct inode *dir, | |||
| 379 | struct inode *inode = NULL; | 378 | struct inode *inode = NULL; |
| 380 | int error = -ENOENT; | 379 | int error = -ENOENT; |
| 381 | 380 | ||
| 382 | lock_kernel(); | ||
| 383 | spin_lock(&proc_subdir_lock); | 381 | spin_lock(&proc_subdir_lock); |
| 384 | for (de = de->subdir; de ; de = de->next) { | 382 | for (de = de->subdir; de ; de = de->next) { |
| 385 | if (de->namelen != dentry->d_name.len) | 383 | if (de->namelen != dentry->d_name.len) |
| @@ -397,7 +395,6 @@ struct dentry *proc_lookup_de(struct proc_dir_entry *de, struct inode *dir, | |||
| 397 | } | 395 | } |
| 398 | spin_unlock(&proc_subdir_lock); | 396 | spin_unlock(&proc_subdir_lock); |
| 399 | out_unlock: | 397 | out_unlock: |
| 400 | unlock_kernel(); | ||
| 401 | 398 | ||
| 402 | if (inode) { | 399 | if (inode) { |
| 403 | dentry->d_op = &proc_dentry_operations; | 400 | dentry->d_op = &proc_dentry_operations; |
| @@ -432,8 +429,6 @@ int proc_readdir_de(struct proc_dir_entry *de, struct file *filp, void *dirent, | |||
| 432 | struct inode *inode = filp->f_path.dentry->d_inode; | 429 | struct inode *inode = filp->f_path.dentry->d_inode; |
| 433 | int ret = 0; | 430 | int ret = 0; |
| 434 | 431 | ||
| 435 | lock_kernel(); | ||
| 436 | |||
| 437 | ino = inode->i_ino; | 432 | ino = inode->i_ino; |
| 438 | i = filp->f_pos; | 433 | i = filp->f_pos; |
| 439 | switch (i) { | 434 | switch (i) { |
| @@ -487,7 +482,7 @@ int proc_readdir_de(struct proc_dir_entry *de, struct file *filp, void *dirent, | |||
| 487 | spin_unlock(&proc_subdir_lock); | 482 | spin_unlock(&proc_subdir_lock); |
| 488 | } | 483 | } |
| 489 | ret = 1; | 484 | ret = 1; |
| 490 | out: unlock_kernel(); | 485 | out: |
| 491 | return ret; | 486 | return ret; |
| 492 | } | 487 | } |
| 493 | 488 | ||
| @@ -504,6 +499,7 @@ int proc_readdir(struct file *filp, void *dirent, filldir_t filldir) | |||
| 504 | * the /proc directory. | 499 | * the /proc directory. |
| 505 | */ | 500 | */ |
| 506 | static const struct file_operations proc_dir_operations = { | 501 | static const struct file_operations proc_dir_operations = { |
| 502 | .llseek = generic_file_llseek, | ||
| 507 | .read = generic_read_dir, | 503 | .read = generic_read_dir, |
| 508 | .readdir = proc_readdir, | 504 | .readdir = proc_readdir, |
| 509 | }; | 505 | }; |
diff --git a/fs/proc/inode.c b/fs/proc/inode.c index 2543fd00c658..3e76bb9b3ad6 100644 --- a/fs/proc/inode.c +++ b/fs/proc/inode.c | |||
| @@ -35,16 +35,13 @@ struct proc_dir_entry *de_get(struct proc_dir_entry *de) | |||
| 35 | */ | 35 | */ |
| 36 | void de_put(struct proc_dir_entry *de) | 36 | void de_put(struct proc_dir_entry *de) |
| 37 | { | 37 | { |
| 38 | lock_kernel(); | ||
| 39 | if (!atomic_read(&de->count)) { | 38 | if (!atomic_read(&de->count)) { |
| 40 | printk("de_put: entry %s already free!\n", de->name); | 39 | printk("de_put: entry %s already free!\n", de->name); |
| 41 | unlock_kernel(); | ||
| 42 | return; | 40 | return; |
| 43 | } | 41 | } |
| 44 | 42 | ||
| 45 | if (atomic_dec_and_test(&de->count)) | 43 | if (atomic_dec_and_test(&de->count)) |
| 46 | free_proc_entry(de); | 44 | free_proc_entry(de); |
| 47 | unlock_kernel(); | ||
| 48 | } | 45 | } |
| 49 | 46 | ||
| 50 | /* | 47 | /* |
diff --git a/fs/proc/proc_net.c b/fs/proc/proc_net.c index 7bc296f424ae..04d1270f1c38 100644 --- a/fs/proc/proc_net.c +++ b/fs/proc/proc_net.c | |||
| @@ -18,7 +18,6 @@ | |||
| 18 | #include <linux/sched.h> | 18 | #include <linux/sched.h> |
| 19 | #include <linux/module.h> | 19 | #include <linux/module.h> |
| 20 | #include <linux/bitops.h> | 20 | #include <linux/bitops.h> |
| 21 | #include <linux/smp_lock.h> | ||
| 22 | #include <linux/mount.h> | 21 | #include <linux/mount.h> |
| 23 | #include <linux/nsproxy.h> | 22 | #include <linux/nsproxy.h> |
| 24 | #include <net/net_namespace.h> | 23 | #include <net/net_namespace.h> |
| @@ -172,6 +171,7 @@ static int proc_tgid_net_readdir(struct file *filp, void *dirent, | |||
| 172 | } | 171 | } |
| 173 | 172 | ||
| 174 | const struct file_operations proc_net_operations = { | 173 | const struct file_operations proc_net_operations = { |
| 174 | .llseek = generic_file_llseek, | ||
| 175 | .read = generic_read_dir, | 175 | .read = generic_read_dir, |
| 176 | .readdir = proc_tgid_net_readdir, | 176 | .readdir = proc_tgid_net_readdir, |
| 177 | }; | 177 | }; |
diff --git a/fs/proc/root.c b/fs/proc/root.c index 7761602af9de..f6299a25594e 100644 --- a/fs/proc/root.c +++ b/fs/proc/root.c | |||
| @@ -16,7 +16,6 @@ | |||
| 16 | #include <linux/sched.h> | 16 | #include <linux/sched.h> |
| 17 | #include <linux/module.h> | 17 | #include <linux/module.h> |
| 18 | #include <linux/bitops.h> | 18 | #include <linux/bitops.h> |
| 19 | #include <linux/smp_lock.h> | ||
| 20 | #include <linux/mount.h> | 19 | #include <linux/mount.h> |
| 21 | #include <linux/pid_namespace.h> | 20 | #include <linux/pid_namespace.h> |
| 22 | 21 | ||
| @@ -162,17 +161,12 @@ static int proc_root_readdir(struct file * filp, | |||
| 162 | unsigned int nr = filp->f_pos; | 161 | unsigned int nr = filp->f_pos; |
| 163 | int ret; | 162 | int ret; |
| 164 | 163 | ||
| 165 | lock_kernel(); | ||
| 166 | |||
| 167 | if (nr < FIRST_PROCESS_ENTRY) { | 164 | if (nr < FIRST_PROCESS_ENTRY) { |
| 168 | int error = proc_readdir(filp, dirent, filldir); | 165 | int error = proc_readdir(filp, dirent, filldir); |
| 169 | if (error <= 0) { | 166 | if (error <= 0) |
| 170 | unlock_kernel(); | ||
| 171 | return error; | 167 | return error; |
| 172 | } | ||
| 173 | filp->f_pos = FIRST_PROCESS_ENTRY; | 168 | filp->f_pos = FIRST_PROCESS_ENTRY; |
| 174 | } | 169 | } |
| 175 | unlock_kernel(); | ||
| 176 | 170 | ||
| 177 | ret = proc_pid_readdir(filp, dirent, filldir); | 171 | ret = proc_pid_readdir(filp, dirent, filldir); |
| 178 | return ret; | 172 | return ret; |
