diff options
| -rw-r--r-- | net/caif/caif_dev.c | 22 | ||||
| -rw-r--r-- | net/caif/caif_socket.c | 19 | ||||
| -rw-r--r-- | net/caif/cfcnfg.c | 49 | ||||
| -rw-r--r-- | net/caif/cfctrl.c | 59 | ||||
| -rw-r--r-- | net/caif/cfdbgl.c | 4 | ||||
| -rw-r--r-- | net/caif/cfdgml.c | 11 | ||||
| -rw-r--r-- | net/caif/cffrml.c | 14 | ||||
| -rw-r--r-- | net/caif/cfmuxl.c | 14 | ||||
| -rw-r--r-- | net/caif/cfpkt_skbuff.c | 48 | ||||
| -rw-r--r-- | net/caif/cfrfml.c | 12 | ||||
| -rw-r--r-- | net/caif/cfserl.c | 4 | ||||
| -rw-r--r-- | net/caif/cfsrvl.c | 17 | ||||
| -rw-r--r-- | net/caif/cfutill.c | 12 | ||||
| -rw-r--r-- | net/caif/cfveil.c | 11 | ||||
| -rw-r--r-- | net/caif/cfvidl.c | 6 | ||||
| -rw-r--r-- | net/caif/chnl_net.c | 46 |
16 files changed, 167 insertions, 181 deletions
diff --git a/net/caif/caif_dev.c b/net/caif/caif_dev.c index 0b586e9d1378..1fdfe70392dc 100644 --- a/net/caif/caif_dev.c +++ b/net/caif/caif_dev.c | |||
| @@ -9,6 +9,8 @@ | |||
| 9 | * and Sakari Ailus <sakari.ailus@nokia.com> | 9 | * and Sakari Ailus <sakari.ailus@nokia.com> |
| 10 | */ | 10 | */ |
| 11 | 11 | ||
| 12 | #define pr_fmt(fmt) KBUILD_MODNAME ":%s(): " fmt, __func__ | ||
| 13 | |||
| 12 | #include <linux/version.h> | 14 | #include <linux/version.h> |
| 13 | #include <linux/module.h> | 15 | #include <linux/module.h> |
| 14 | #include <linux/kernel.h> | 16 | #include <linux/kernel.h> |
| @@ -214,7 +216,7 @@ static int caif_device_notify(struct notifier_block *me, unsigned long what, | |||
| 214 | 216 | ||
| 215 | switch (what) { | 217 | switch (what) { |
| 216 | case NETDEV_REGISTER: | 218 | case NETDEV_REGISTER: |
| 217 | pr_info("CAIF: %s():register %s\n", __func__, dev->name); | 219 | pr_info("register %s\n", dev->name); |
| 218 | caifd = caif_device_alloc(dev); | 220 | caifd = caif_device_alloc(dev); |
| 219 | if (caifd == NULL) | 221 | if (caifd == NULL) |
| 220 | break; | 222 | break; |
| @@ -225,14 +227,13 @@ static int caif_device_notify(struct notifier_block *me, unsigned long what, | |||
| 225 | break; | 227 | break; |
| 226 | 228 | ||
| 227 | case NETDEV_UP: | 229 | case NETDEV_UP: |
| 228 | pr_info("CAIF: %s(): up %s\n", __func__, dev->name); | 230 | pr_info("up %s\n", dev->name); |
| 229 | caifd = caif_get(dev); | 231 | caifd = caif_get(dev); |
| 230 | if (caifd == NULL) | 232 | if (caifd == NULL) |
| 231 | break; | 233 | break; |
| 232 | caifdev = netdev_priv(dev); | 234 | caifdev = netdev_priv(dev); |
| 233 | if (atomic_read(&caifd->state) == NETDEV_UP) { | 235 | if (atomic_read(&caifd->state) == NETDEV_UP) { |
| 234 | pr_info("CAIF: %s():%s already up\n", | 236 | pr_info("%s already up\n", dev->name); |
| 235 | __func__, dev->name); | ||
| 236 | break; | 237 | break; |
| 237 | } | 238 | } |
| 238 | atomic_set(&caifd->state, what); | 239 | atomic_set(&caifd->state, what); |
| @@ -273,7 +274,7 @@ static int caif_device_notify(struct notifier_block *me, unsigned long what, | |||
| 273 | caifd = caif_get(dev); | 274 | caifd = caif_get(dev); |
| 274 | if (caifd == NULL) | 275 | if (caifd == NULL) |
| 275 | break; | 276 | break; |
| 276 | pr_info("CAIF: %s():going down %s\n", __func__, dev->name); | 277 | pr_info("going down %s\n", dev->name); |
| 277 | 278 | ||
| 278 | if (atomic_read(&caifd->state) == NETDEV_GOING_DOWN || | 279 | if (atomic_read(&caifd->state) == NETDEV_GOING_DOWN || |
| 279 | atomic_read(&caifd->state) == NETDEV_DOWN) | 280 | atomic_read(&caifd->state) == NETDEV_DOWN) |
| @@ -295,11 +296,10 @@ static int caif_device_notify(struct notifier_block *me, unsigned long what, | |||
| 295 | caifd = caif_get(dev); | 296 | caifd = caif_get(dev); |
| 296 | if (caifd == NULL) | 297 | if (caifd == NULL) |
| 297 | break; | 298 | break; |
| 298 | pr_info("CAIF: %s(): down %s\n", __func__, dev->name); | 299 | pr_info("down %s\n", dev->name); |
| 299 | if (atomic_read(&caifd->in_use)) | 300 | if (atomic_read(&caifd->in_use)) |
| 300 | pr_warning("CAIF: %s(): " | 301 | pr_warn("Unregistering an active CAIF device: %s\n", |
| 301 | "Unregistering an active CAIF device: %s\n", | 302 | dev->name); |
| 302 | __func__, dev->name); | ||
| 303 | cfcnfg_del_phy_layer(get_caif_conf(), &caifd->layer); | 303 | cfcnfg_del_phy_layer(get_caif_conf(), &caifd->layer); |
| 304 | dev_put(dev); | 304 | dev_put(dev); |
| 305 | atomic_set(&caifd->state, what); | 305 | atomic_set(&caifd->state, what); |
| @@ -307,7 +307,7 @@ static int caif_device_notify(struct notifier_block *me, unsigned long what, | |||
| 307 | 307 | ||
| 308 | case NETDEV_UNREGISTER: | 308 | case NETDEV_UNREGISTER: |
| 309 | caifd = caif_get(dev); | 309 | caifd = caif_get(dev); |
| 310 | pr_info("CAIF: %s(): unregister %s\n", __func__, dev->name); | 310 | pr_info("unregister %s\n", dev->name); |
| 311 | atomic_set(&caifd->state, what); | 311 | atomic_set(&caifd->state, what); |
| 312 | caif_device_destroy(dev); | 312 | caif_device_destroy(dev); |
| 313 | break; | 313 | break; |
| @@ -391,7 +391,7 @@ static int __init caif_device_init(void) | |||
| 391 | int result; | 391 | int result; |
| 392 | cfg = cfcnfg_create(); | 392 | cfg = cfcnfg_create(); |
| 393 | if (!cfg) { | 393 | if (!cfg) { |
| 394 | pr_warning("CAIF: %s(): can't create cfcnfg.\n", __func__); | 394 | pr_warn("can't create cfcnfg\n"); |
| 395 | goto err_cfcnfg_create_failed; | 395 | goto err_cfcnfg_create_failed; |
| 396 | } | 396 | } |
| 397 | result = register_pernet_device(&caif_net_ops); | 397 | result = register_pernet_device(&caif_net_ops); |
diff --git a/net/caif/caif_socket.c b/net/caif/caif_socket.c index 8ce904786116..fd1f5df0827c 100644 --- a/net/caif/caif_socket.c +++ b/net/caif/caif_socket.c | |||
| @@ -4,6 +4,8 @@ | |||
| 4 | * License terms: GNU General Public License (GPL) version 2 | 4 | * License terms: GNU General Public License (GPL) version 2 |
| 5 | */ | 5 | */ |
| 6 | 6 | ||
| 7 | #define pr_fmt(fmt) KBUILD_MODNAME ":%s(): " fmt, __func__ | ||
| 8 | |||
| 7 | #include <linux/fs.h> | 9 | #include <linux/fs.h> |
| 8 | #include <linux/init.h> | 10 | #include <linux/init.h> |
| 9 | #include <linux/module.h> | 11 | #include <linux/module.h> |
| @@ -157,8 +159,8 @@ static int caif_queue_rcv_skb(struct sock *sk, struct sk_buff *skb) | |||
| 157 | 159 | ||
| 158 | if (atomic_read(&sk->sk_rmem_alloc) + skb->truesize >= | 160 | if (atomic_read(&sk->sk_rmem_alloc) + skb->truesize >= |
| 159 | (unsigned)sk->sk_rcvbuf && rx_flow_is_on(cf_sk)) { | 161 | (unsigned)sk->sk_rcvbuf && rx_flow_is_on(cf_sk)) { |
| 160 | trace_printk("CAIF: %s():" | 162 | trace_printk("CAIF: %s(): " |
| 161 | " sending flow OFF (queue len = %d %d)\n", | 163 | "sending flow OFF (queue len = %d %d)\n", |
| 162 | __func__, | 164 | __func__, |
| 163 | atomic_read(&cf_sk->sk.sk_rmem_alloc), | 165 | atomic_read(&cf_sk->sk.sk_rmem_alloc), |
| 164 | sk_rcvbuf_lowwater(cf_sk)); | 166 | sk_rcvbuf_lowwater(cf_sk)); |
| @@ -172,8 +174,8 @@ static int caif_queue_rcv_skb(struct sock *sk, struct sk_buff *skb) | |||
| 172 | return err; | 174 | return err; |
| 173 | if (!sk_rmem_schedule(sk, skb->truesize) && rx_flow_is_on(cf_sk)) { | 175 | if (!sk_rmem_schedule(sk, skb->truesize) && rx_flow_is_on(cf_sk)) { |
| 174 | set_rx_flow_off(cf_sk); | 176 | set_rx_flow_off(cf_sk); |
| 175 | trace_printk("CAIF: %s():" | 177 | trace_printk("CAIF: %s(): " |
| 176 | " sending flow OFF due to rmem_schedule\n", | 178 | "sending flow OFF due to rmem_schedule\n", |
| 177 | __func__); | 179 | __func__); |
| 178 | dbfs_atomic_inc(&cnt.num_rx_flow_off); | 180 | dbfs_atomic_inc(&cnt.num_rx_flow_off); |
| 179 | caif_flow_ctrl(sk, CAIF_MODEMCMD_FLOW_OFF_REQ); | 181 | caif_flow_ctrl(sk, CAIF_MODEMCMD_FLOW_OFF_REQ); |
| @@ -275,8 +277,7 @@ static void caif_ctrl_cb(struct cflayer *layr, | |||
| 275 | break; | 277 | break; |
| 276 | 278 | ||
| 277 | default: | 279 | default: |
| 278 | pr_debug("CAIF: %s(): Unexpected flow command %d\n", | 280 | pr_debug("Unexpected flow command %d\n", flow); |
| 279 | __func__, flow); | ||
| 280 | } | 281 | } |
| 281 | } | 282 | } |
| 282 | 283 | ||
| @@ -536,8 +537,7 @@ static int transmit_skb(struct sk_buff *skb, struct caifsock *cf_sk, | |||
| 536 | 537 | ||
| 537 | /* Slight paranoia, probably not needed. */ | 538 | /* Slight paranoia, probably not needed. */ |
| 538 | if (unlikely(loopcnt++ > 1000)) { | 539 | if (unlikely(loopcnt++ > 1000)) { |
| 539 | pr_warning("CAIF: %s(): transmit retries failed," | 540 | pr_warn("transmit retries failed, error = %d\n", ret); |
| 540 | " error = %d\n", __func__, ret); | ||
| 541 | break; | 541 | break; |
| 542 | } | 542 | } |
| 543 | 543 | ||
| @@ -902,8 +902,7 @@ static int caif_connect(struct socket *sock, struct sockaddr *uaddr, | |||
| 902 | cf_sk->maxframe = dev->mtu - (headroom + tailroom); | 902 | cf_sk->maxframe = dev->mtu - (headroom + tailroom); |
| 903 | dev_put(dev); | 903 | dev_put(dev); |
| 904 | if (cf_sk->maxframe < 1) { | 904 | if (cf_sk->maxframe < 1) { |
| 905 | pr_warning("CAIF: %s(): CAIF Interface MTU too small (%d)\n", | 905 | pr_warn("CAIF Interface MTU too small (%d)\n", dev->mtu); |
| 906 | __func__, dev->mtu); | ||
| 907 | err = -ENODEV; | 906 | err = -ENODEV; |
| 908 | goto out; | 907 | goto out; |
| 909 | } | 908 | } |
diff --git a/net/caif/cfcnfg.c b/net/caif/cfcnfg.c index 1c29189b344d..ef93a131310b 100644 --- a/net/caif/cfcnfg.c +++ b/net/caif/cfcnfg.c | |||
| @@ -3,6 +3,9 @@ | |||
| 3 | * Author: Sjur Brendeland/sjur.brandeland@stericsson.com | < | |
