diff options
| -rw-r--r-- | drivers/nfc/microread/mei.c | 38 | ||||
| -rw-r--r-- | net/nfc/llcp/llcp.c | 8 | ||||
| -rw-r--r-- | net/nfc/llcp/sock.c | 6 |
3 files changed, 20 insertions, 32 deletions
diff --git a/drivers/nfc/microread/mei.c b/drivers/nfc/microread/mei.c index eef38cfd812e..ca33ae193935 100644 --- a/drivers/nfc/microread/mei.c +++ b/drivers/nfc/microread/mei.c | |||
| @@ -22,7 +22,7 @@ | |||
| 22 | #include <linux/slab.h> | 22 | #include <linux/slab.h> |
| 23 | #include <linux/interrupt.h> | 23 | #include <linux/interrupt.h> |
| 24 | #include <linux/gpio.h> | 24 | #include <linux/gpio.h> |
| 25 | #include <linux/mei_bus.h> | 25 | #include <linux/mei_cl_bus.h> |
| 26 | 26 | ||
| 27 | #include <linux/nfc.h> | 27 | #include <linux/nfc.h> |
| 28 | #include <net/nfc/hci.h> | 28 | #include <net/nfc/hci.h> |
| @@ -32,9 +32,6 @@ | |||
| 32 | 32 | ||
| 33 | #define MICROREAD_DRIVER_NAME "microread" | 33 | #define MICROREAD_DRIVER_NAME "microread" |
| 34 | 34 | ||
| 35 | #define MICROREAD_UUID UUID_LE(0x0bb17a78, 0x2a8e, 0x4c50, 0x94, \ | ||
| 36 | 0xd4, 0x50, 0x26, 0x67, 0x23, 0x77, 0x5c) | ||
| 37 | |||
| 38 | struct mei_nfc_hdr { | 35 | struct mei_nfc_hdr { |
| 39 | u8 cmd; | 36 | u8 cmd; |
| 40 | u8 status; | 37 | u8 status; |
| @@ -48,7 +45,7 @@ struct mei_nfc_hdr { | |||
| 48 | #define MEI_NFC_MAX_READ (MEI_NFC_HEADER_SIZE + MEI_NFC_MAX_HCI_PAYLOAD) | 45 | #define MEI_NFC_MAX_READ (MEI_NFC_HEADER_SIZE + MEI_NFC_MAX_HCI_PAYLOAD) |
| 49 | 46 | ||
| 50 | struct microread_mei_phy { | 47 | struct microread_mei_phy { |
| 51 | struct mei_device *mei_device; | 48 | struct mei_cl_device *device; |
| 52 | struct nfc_hci_dev *hdev; | 49 | struct nfc_hci_dev *hdev; |
| 53 | 50 | ||
| 54 | int powered; | 51 | int powered; |
| @@ -105,14 +102,14 @@ static int microread_mei_write(void *phy_id, struct sk_buff *skb) | |||
| 105 | 102 | ||
| 106 | MEI_DUMP_SKB_OUT("mei frame sent", skb); | 103 | MEI_DUMP_SKB_OUT("mei frame sent", skb); |
| 107 | 104 | ||
| 108 | r = mei_send(phy->device, skb->data, skb->len); | 105 | r = mei_cl_send(phy->device, skb->data, skb->len); |
| 109 | if (r > 0) | 106 | if (r > 0) |
| 110 | r = 0; | 107 | r = 0; |
| 111 | 108 | ||
| 112 | return r; | 109 | return r; |
| 113 | } | 110 | } |
| 114 | 111 | ||
| 115 | static void microread_event_cb(struct mei_device *device, u32 events, | 112 | static void microread_event_cb(struct mei_cl_device *device, u32 events, |
| 116 | void *context) | 113 | void *context) |
| 117 | { | 114 | { |
| 118 | struct microread_mei_phy *phy = context; | 115 | struct microread_mei_phy *phy = context; |
| @@ -120,7 +117,7 @@ static void microread_event_cb(struct mei_device *device, u32 events, | |||
| 120 | if (phy->hard_fault != 0) | 117 | if (phy->hard_fault != 0) |
| 121 | return; | 118 | return; |
| 122 | 119 | ||
| 123 | if (events & BIT(MEI_EVENT_RX)) { | 120 | if (events & BIT(MEI_CL_EVENT_RX)) { |
| 124 | struct sk_buff *skb; | 121 | struct sk_buff *skb; |
| 125 | int reply_size; | 122 | int reply_size; |
| 126 | 123 | ||
| @@ -128,7 +125,7 @@ static void microread_event_cb(struct mei_device *device, u32 events, | |||
| 128 | if (!skb) | 125 | if (!skb) |
| 129 | return; | 126 | return; |
| 130 | 127 | ||
| 131 | reply_size = mei_recv(device, skb->data, MEI_NFC_MAX_READ); | 128 | reply_size = mei_cl_recv(device, skb->data, MEI_NFC_MAX_READ); |
| 132 | if (reply_size < MEI_NFC_HEADER_SIZE) { | 129 | if (reply_size < MEI_NFC_HEADER_SIZE) { |
| 133 | kfree(skb); | 130 | kfree(skb); |
| 134 | return; | 131 | return; |
| @@ -149,8 +146,8 @@ static struct nfc_phy_ops mei_phy_ops = { | |||
| 149 | .disable = microread_mei_disable, | 146 | .disable = microread_mei_disable, |
| 150 | }; | 147 | }; |
| 151 | 148 | ||
| 152 | static int microread_mei_probe(struct mei_device *device, | 149 | static int microread_mei_probe(struct mei_cl_device *device, |
| 153 | const struct mei_id *id) | 150 | const struct mei_cl_device_id *id) |
| 154 | { | 151 | { |
| 155 | struct microread_mei_phy *phy; | 152 | struct microread_mei_phy *phy; |
| 156 | int r; | 153 | int r; |
| @@ -164,9 +161,9 @@ static int microread_mei_probe(struct mei_device *device, | |||
| 164 | } | 161 | } |
| 165 | 162 | ||
| 166 | phy->device = device; | 163 | phy->device = device; |
| 167 | mei_set_clientdata(device, phy); | 164 | mei_cl_set_drvdata(device, phy); |
| 168 | 165 | ||
| 169 | r = mei_register_event_cb(device, microread_event_cb, phy); | 166 | r = mei_cl_register_event_cb(device, microread_event_cb, phy); |
| 170 | if (r) { | 167 | if (r) { |
| 171 | pr_err(MICROREAD_DRIVER_NAME ": event cb registration failed\n"); | 168 | pr_err(MICROREAD_DRIVER_NAME ": event cb registration failed\n"); |
| 172 | goto err_out; | 169 | goto err_out; |
| @@ -186,9 +183,9 @@ err_out: | |||
| 186 | return r; | 183 | return r; |
| 187 | } | 184 | } |
| 188 | 185 | ||
| 189 | static int microread_mei_remove(struct mei_device *device) | 186 | static int microread_mei_remove(struct mei_cl_device *device) |
| 190 | { | 187 | { |
| 191 | struct microread_mei_phy *phy = mei_get_clientdata(device); | 188 | struct microread_mei_phy *phy = mei_cl_get_drvdata(device); |
| 192 | 189 | ||
| 193 | pr_info("Removing microread\n"); | 190 | pr_info("Removing microread\n"); |
| 194 | 191 | ||
| @@ -202,16 +199,15 @@ static int microread_mei_remove(struct mei_device *device) | |||
| 202 | return 0; | 199 | return 0; |
| 203 | } | 200 | } |
| 204 | 201 | ||
| 205 | static struct mei_id microread_mei_tbl[] = { | 202 | static struct mei_cl_device_id microread_mei_tbl[] = { |
| 206 | { MICROREAD_DRIVER_NAME, MICROREAD_UUID }, | 203 | { MICROREAD_DRIVER_NAME }, |
| 207 | 204 | ||
| 208 | /* required last entry */ | 205 | /* required last entry */ |
| 209 | { } | 206 | { } |
| 210 | }; | 207 | }; |
| 211 | |||
| 212 | MODULE_DEVICE_TABLE(mei, microread_mei_tbl); | 208 | MODULE_DEVICE_TABLE(mei, microread_mei_tbl); |
| 213 | 209 | ||
| 214 | static struct mei_driver microread_driver = { | 210 | static struct mei_cl_driver microread_driver = { |
| 215 | .id_table = microread_mei_tbl, | 211 | .id_table = microread_mei_tbl, |
| 216 | .name = MICROREAD_DRIVER_NAME, | 212 | .name = MICROREAD_DRIVER_NAME, |
| 217 | 213 | ||
| @@ -225,7 +221,7 @@ static int microread_mei_init(void) | |||
| 225 | 221 | ||
| 226 | pr_debug(DRIVER_DESC ": %s\n", __func__); | 222 | pr_debug(DRIVER_DESC ": %s\n", __func__); |
| 227 | 223 | ||
| 228 | r = mei_driver_register(µread_driver); | 224 | r = mei_cl_driver_register(µread_driver); |
| 229 | if (r) { | 225 | if (r) { |
| 230 | pr_err(MICROREAD_DRIVER_NAME ": driver registration failed\n"); | 226 | pr_err(MICROREAD_DRIVER_NAME ": driver registration failed\n"); |
| 231 | return r; | 227 | return r; |
| @@ -236,7 +232,7 @@ static int microread_mei_init(void) | |||
| 236 | 232 | ||
| 237 | static void microread_mei_exit(void) | 233 | static void microread_mei_exit(void) |
| 238 | { | 234 | { |
| 239 | mei_driver_unregister(µread_driver); | 235 | mei_cl_driver_unregister(µread_driver); |
| 240 | } | 236 | } |
| 241 | 237 | ||
| 242 | module_init(microread_mei_init); | 238 | module_init(microread_mei_init); |
diff --git a/net/nfc/llcp/llcp.c b/net/nfc/llcp/llcp.c index b530afadd76c..ee25f25f0cd6 100644 --- a/net/nfc/llcp/llcp.c +++ b/net/nfc/llcp/llcp.c | |||
| @@ -107,8 +107,6 @@ static void nfc_llcp_socket_release(struct nfc_llcp_local *local, bool listen, | |||
| 107 | accept_sk->sk_state_change(sk); | 107 | accept_sk->sk_state_change(sk); |
| 108 | 108 | ||
| 109 | bh_unlock_sock(accept_sk); | 109 | bh_unlock_sock(accept_sk); |
| 110 | |||
| 111 | sock_orphan(accept_sk); | ||
| 112 | } | 110 | } |
| 113 | 111 | ||
| 114 | if (listen == true) { | 112 | if (listen == true) { |
| @@ -134,8 +132,6 @@ static void nfc_llcp_socket_release(struct nfc_llcp_local *local, bool listen, | |||
| 134 | 132 | ||
| 135 | bh_unlock_sock(sk); | 133 | bh_unlock_sock(sk); |
| 136 | 134 | ||
| 137 | sock_orphan(sk); | ||
| 138 | |||
| 139 | sk_del_node_init(sk); | 135 | sk_del_node_init(sk); |
| 140 | } | 136 | } |
| 141 | 137 | ||
| @@ -164,8 +160,6 @@ static void nfc_llcp_socket_release(struct nfc_llcp_local *local, bool listen, | |||
| 164 | 160 | ||
| 165 | bh_unlock_sock(sk); | 161 | bh_unlock_sock(sk); |
| 166 | 162 | ||
| 167 | sock_orphan(sk); | ||
| 168 | |||
| 169 | sk_del_node_init(sk); | 163 | sk_del_node_init(sk); |
| 170 | } | 164 | } |
| 171 | 165 | ||
| @@ -827,7 +821,6 @@ static void nfc_llcp_recv_ui(struct nfc_llcp_local *local, | |||
| 827 | skb_get(skb); | 821 | skb_get(skb); |
| 828 | } else { | 822 | } else { |
| 829 | pr_err("Receive queue is full\n"); | 823 | pr_err("Receive queue is full\n"); |
| 830 | kfree_skb(skb); | ||
| 831 | } | 824 | } |
| 832 | 825 | ||
| 833 | nfc_llcp_sock_put(llcp_sock); | 826 | nfc_llcp_sock_put(llcp_sock); |
| @@ -1028,7 +1021,6 @@ static void nfc_llcp_recv_hdlc(struct nfc_llcp_local *local, | |||
| 1028 | skb_get(skb); | 1021 | skb_get(skb); |
| 1029 | } else { | 1022 | } else { |
| 1030 | pr_err("Receive queue is full\n"); | 1023 | pr_err("Receive queue is full\n"); |
| 1031 | kfree_skb(skb); | ||
| 1032 | } | 1024 | } |
| 1033 | } | 1025 | } |
| 1034 | 1026 | ||
diff --git a/net/nfc/llcp/sock.c b/net/nfc/llcp/sock.c index 5c7cdf3f2a83..8f025746f337 100644 --- a/net/nfc/llcp/sock.c +++ b/net/nfc/llcp/sock.c | |||
| @@ -270,7 +270,9 @@ struct sock *nfc_llcp_accept_dequeue(struct sock *parent, | |||
| 270 | } | 270 | } |
| 271 | 271 | ||
| 272 | if (sk->sk_state == LLCP_CONNECTED || !newsock) { | 272 | if (sk->sk_state == LLCP_CONNECTED || !newsock) { |
| 273 | nfc_llcp_accept_unlink(sk); | 273 | list_del_init(&lsk->accept_queue); |
| 274 | sock_put(sk); | ||
| 275 | |||
| 274 | if (newsock) | 276 | if (newsock) |
| 275 | sock_graft(sk, newsock); | 277 | sock_graft(sk, newsock); |
| 276 | 278 | ||
| @@ -464,8 +466,6 @@ static int llcp_sock_release(struct socket *sock) | |||
| 464 | nfc_llcp_accept_unlink(accept_sk); | 466 | nfc_llcp_accept_unlink(accept_sk); |
| 465 | 467 | ||
| 466 | release_sock(accept_sk); | 468 | release_sock(accept_sk); |
| 467 | |||
| 468 | sock_orphan(accept_sk); | ||
| 469 | } | 469 | } |
| 470 | } | 470 | } |
| 471 | 471 | ||
