diff options
| -rw-r--r-- | drivers/net/usb/cdc_ether.c | 18 | ||||
| -rw-r--r-- | drivers/net/usb/net1080.c | 96 | ||||
| -rw-r--r-- | drivers/net/usb/pegasus.c | 170 | ||||
| -rw-r--r-- | drivers/net/usb/rndis_host.c | 14 | ||||
| -rw-r--r-- | drivers/net/usb/smsc95xx.c | 99 | ||||
| -rw-r--r-- | drivers/net/usb/usbnet.c | 208 |
6 files changed, 264 insertions, 341 deletions
diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c index 7e5a75269cc5..3486e8ca039a 100644 --- a/drivers/net/usb/cdc_ether.c +++ b/drivers/net/usb/cdc_ether.c | |||
| @@ -339,10 +339,10 @@ EXPORT_SYMBOL_GPL(usbnet_cdc_unbind); | |||
| 339 | 339 | ||
| 340 | static void dumpspeed(struct usbnet *dev, __le32 *speeds) | 340 | static void dumpspeed(struct usbnet *dev, __le32 *speeds) |
| 341 | { | 341 | { |
| 342 | if (netif_msg_timer(dev)) | 342 | netif_info(dev, timer, dev->net, |
| 343 | netdev_info(dev->net, "link speeds: %u kbps up, %u kbps down\n", | 343 | "link speeds: %u kbps up, %u kbps down\n", |
| 344 | __le32_to_cpu(speeds[0]) / 1000, | 344 | __le32_to_cpu(speeds[0]) / 1000, |
| 345 | __le32_to_cpu(speeds[1]) / 1000); | 345 | __le32_to_cpu(speeds[1]) / 1000); |
| 346 | } | 346 | } |
| 347 | 347 | ||
| 348 | static void cdc_status(struct usbnet *dev, struct urb *urb) | 348 | static void cdc_status(struct usbnet *dev, struct urb *urb) |
| @@ -361,18 +361,16 @@ static void cdc_status(struct usbnet *dev, struct urb *urb) | |||
| 361 | event = urb->transfer_buffer; | 361 | event = urb->transfer_buffer; |
| 362 | switch (event->bNotificationType) { | 362 | switch (event->bNotificationType) { |
| 363 | case USB_CDC_NOTIFY_NETWORK_CONNECTION: | 363 | case USB_CDC_NOTIFY_NETWORK_CONNECTION: |
| 364 | if (netif_msg_timer(dev)) | 364 | netif_dbg(dev, timer, dev->net, "CDC: carrier %s\n", |
| 365 | netdev_dbg(dev->net, "CDC: carrier %s\n", | 365 | event->wValue ? "on" : "off"); |
| 366 | event->wValue ? "on" : "off"); | ||
| 367 | if (event->wValue) | 366 | if (event->wValue) |
| 368 | netif_carrier_on(dev->net); | 367 | netif_carrier_on(dev->net); |
| 369 | else | 368 | else |
| 370 | netif_carrier_off(dev->net); | 369 | netif_carrier_off(dev->net); |
| 371 | break; | 370 | break; |
| 372 | case USB_CDC_NOTIFY_SPEED_CHANGE: /* tx/rx rates */ | 371 | case USB_CDC_NOTIFY_SPEED_CHANGE: /* tx/rx rates */ |
| 373 | if (netif_msg_timer(dev)) | 372 | netif_dbg(dev, timer, dev->net, "CDC: speed change (len %d)\n", |
| 374 | netdev_dbg(dev->net, "CDC: speed change (len %d)\n", | 373 | urb->actual_length); |
| 375 | urb->actual_length); | ||
| 376 | if (urb->actual_length != (sizeof *event + 8)) | 374 | if (urb->actual_length != (sizeof *event + 8)) |
| 377 | set_bit(EVENT_STS_SPLIT, &dev->flags); | 375 | set_bit(EVENT_STS_SPLIT, &dev->flags); |
| 378 | else | 376 | else |
diff --git a/drivers/net/usb/net1080.c b/drivers/net/usb/net1080.c index f6994053c101..bdcad45954a3 100644 --- a/drivers/net/usb/net1080.c +++ b/drivers/net/usb/net1080.c | |||
| @@ -203,26 +203,23 @@ static void nc_dump_registers(struct usbnet *dev) | |||
| 203 | 203 | ||
| 204 | static inline void nc_dump_usbctl(struct usbnet *dev, u16 usbctl) | 204 | static inline void nc_dump_usbctl(struct usbnet *dev, u16 usbctl) |
| 205 | { | 205 | { |
| 206 | if (!netif_msg_link(dev)) | 206 | netif_dbg(dev, link, dev->net, |
| 207 | return; | 207 | "net1080 %s-%s usbctl 0x%x:%s%s%s%s%s; this%s%s; other%s%s; r/o 0x%x\n", |
| 208 | netdev_dbg(dev->net, "net1080 %s-%s usbctl 0x%x:%s%s%s%s%s;" | 208 | dev->udev->bus->bus_name, dev->udev->devpath, |
| 209 | " this%s%s;" | 209 | usbctl, |
| 210 | " other%s%s; r/o 0x%x\n", | 210 | (usbctl & USBCTL_ENABLE_LANG) ? " lang" : "", |
| 211 | dev->udev->bus->bus_name, dev->udev->devpath, | 211 | (usbctl & USBCTL_ENABLE_MFGR) ? " mfgr" : "", |
| 212 | usbctl, | 212 | (usbctl & USBCTL_ENABLE_PROD) ? " prod" : "", |
| 213 | (usbctl & USBCTL_ENABLE_LANG) ? " lang" : "", | 213 | (usbctl & USBCTL_ENABLE_SERIAL) ? " serial" : "", |
| 214 | (usbctl & USBCTL_ENABLE_MFGR) ? " mfgr" : "", | 214 | (usbctl & USBCTL_ENABLE_DEFAULTS) ? " defaults" : "", |
| 215 | (usbctl & USBCTL_ENABLE_PROD) ? " prod" : "", | 215 | |
| 216 | (usbctl & USBCTL_ENABLE_SERIAL) ? " serial" : "", | 216 | (usbctl & USBCTL_FLUSH_THIS) ? " FLUSH" : "", |
| 217 | (usbctl & USBCTL_ENABLE_DEFAULTS) ? " defaults" : "", | 217 | (usbctl & USBCTL_DISCONN_THIS) ? " DIS" : "", |
| 218 | 218 | ||
| 219 | (usbctl & USBCTL_FLUSH_THIS) ? " FLUSH" : "", | 219 | (usbctl & USBCTL_FLUSH_OTHER) ? " FLUSH" : "", |
| 220 | (usbctl & USBCTL_DISCONN_THIS) ? " DIS" : "", | 220 | (usbctl & USBCTL_DISCONN_OTHER) ? " DIS" : "", |
| 221 | 221 | ||
| 222 | (usbctl & USBCTL_FLUSH_OTHER) ? " FLUSH" : "", | 222 | usbctl & ~USBCTL_WRITABLE_MASK); |
| 223 | (usbctl & USBCTL_DISCONN_OTHER) ? " DIS" : "", | ||
| 224 | |||
| 225 | usbctl & ~USBCTL_WRITABLE_MASK); | ||
| 226 | } | 223 | } |
| 227 | 224 | ||
| 228 | /*-------------------------------------------------------------------------*/ | 225 | /*-------------------------------------------------------------------------*/ |
| @@ -249,27 +246,26 @@ static inline void nc_dump_usbctl(struct usbnet *dev, u16 usbctl) | |||
| 249 | 246 | ||
| 250 | static inline void nc_dump_status(struct usbnet *dev, u16 status) | 247 | static inline void nc_dump_status(struct usbnet *dev, u16 status) |
| 251 | { | 248 | { |
| 252 | if (!netif_msg_link(dev)) | 249 | netif_dbg(dev, link, dev->net, |
| 253 | return; | 250 | "net1080 %s-%s status 0x%x: this (%c) PKT=%d%s%s%s; other PKT=%d%s%s%s; unspec 0x%x\n", |
| 254 | netdev_dbg(dev->net, "net1080 %s-%s status 0x%x: this (%c) PKT=%d%s%s%s; other PKT=%d%s%s%s; unspec 0x%x\n", | 251 | dev->udev->bus->bus_name, dev->udev->devpath, |
| 255 | dev->udev->bus->bus_name, dev->udev->devpath, | 252 | status, |
| 256 | status, | 253 | |
| 257 | 254 | // XXX the packet counts don't seem right | |
| 258 | // XXX the packet counts don't seem right | 255 | // (1 at reset, not 0); maybe UNSPEC too |
| 259 | // (1 at reset, not 0); maybe UNSPEC too | 256 | |
| 260 | 257 | (status & STATUS_PORT_A) ? 'A' : 'B', | |
| 261 | (status & STATUS_PORT_A) ? 'A' : 'B', | 258 | STATUS_PACKETS_THIS(status), |
| 262 | STATUS_PACKETS_THIS(status), | 259 | (status & STATUS_CONN_THIS) ? " CON" : "", |
| 263 | (status & STATUS_CONN_THIS) ? " CON" : "", | 260 | (status & STATUS_SUSPEND_THIS) ? " SUS" : "", |
| 264 | (status & STATUS_SUSPEND_THIS) ? " SUS" : "", | 261 | (status & STATUS_MAILBOX_THIS) ? " MBOX" : "", |
| 265 | (status & STATUS_MAILBOX_THIS) ? " MBOX" : "", | 262 | |
| 266 | 263 | STATUS_PACKETS_OTHER(status), | |
| 267 | STATUS_PACKETS_OTHER(status), | 264 | (status & STATUS_CONN_OTHER) ? " CON" : "", |
| 268 | (status & STATUS_CONN_OTHER) ? " CON" : "", | 265 | (status & STATUS_SUSPEND_OTHER) ? " SUS" : "", |
| 269 | (status & STATUS_SUSPEND_OTHER) ? " SUS" : "", | 266 | (status & STATUS_MAILBOX_OTHER) ? " MBOX" : "", |
| 270 | (status & STATUS_MAILBOX_OTHER) ? " MBOX" : "", | 267 | |
| 271 | 268 | status & STATUS_UNSPEC_MASK); | |
| 272 | status & STATUS_UNSPEC_MASK); | ||
| 273 | } | 269 | } |
| 274 | 270 | ||
| 275 | /*-------------------------------------------------------------------------*/ | 271 | /*-------------------------------------------------------------------------*/ |
| @@ -284,10 +280,9 @@ static inline void nc_dump_status(struct usbnet *dev, u16 status) | |||
| 284 | 280 | ||
| 285 | static inline void nc_dump_ttl(struct usbnet *dev, u16 ttl) | 281 | static inline void nc_dump_ttl(struct usbnet *dev, u16 ttl) |
| 286 | { | 282 | { |
| 287 | if (netif_msg_link(dev)) | 283 | netif_dbg(dev, link, dev->net, "net1080 %s-%s ttl 0x%x this = %d, other = %d\n", |
| 288 | netdev_dbg(dev->net, "net1080 %s-%s ttl 0x%x this = %d, other = %d\n", | 284 | dev->udev->bus->bus_name, dev->udev->devpath, |
| 289 | dev->udev->bus->bus_name, dev->udev->devpath, | 285 | ttl, TTL_THIS(ttl), TTL_OTHER(ttl)); |
| 290 | ttl, TTL_THIS(ttl), TTL_OTHER(ttl)); | ||
| 291 | } | 286 | } |
| 292 | 287 | ||
| 293 | /*-------------------------------------------------------------------------*/ | 288 | /*-------------------------------------------------------------------------*/ |
| @@ -332,10 +327,9 @@ static int net1080_reset(struct usbnet *dev) | |||
| 332 | MK_TTL(NC_READ_TTL_MS, TTL_OTHER(ttl)) ); | 327 | MK_TTL(NC_READ_TTL_MS, TTL_OTHER(ttl)) ); |
| 333 | dbg("%s: assigned TTL, %d ms", dev->net->name, NC_READ_TTL_MS); | 328 | dbg("%s: assigned TTL, %d ms", dev->net->name, NC_READ_TTL_MS); |
| 334 | 329 | ||
| 335 | if (netif_msg_link(dev)) | 330 | netif_info(dev, link, dev->net, "port %c, peer %sconnected\n", |
| 336 | netdev_info(dev->net, "port %c, peer %sconnected\n", | 331 | (status & STATUS_PORT_A) ? 'A' : 'B', |
| 337 | (status & STATUS_PORT_A) ? 'A' : 'B', | 332 | (status & STATUS_CONN_OTHER) ? "" : "dis"); |
| 338 | (status & STATUS_CONN_OTHER) ? "" : "dis"); | ||
| 339 | retval = 0; | 333 | retval = 0; |
| 340 | 334 | ||
| 341 | done: | 335 | done: |
| @@ -412,8 +406,8 @@ static void nc_ensure_sync(struct usbnet *dev) | |||
| 412 | return; | 406 | return; |
| 413 | } | 407 | } |
| 414 | 408 | ||
| 415 | if (netif_msg_rx_err(dev)) | 409 | netif_dbg(dev, rx_err, dev->net, |
| 416 | netdev_dbg(dev->net, "flush net1080; too many framing errors\n"); | 410 | "flush net1080; too many framing errors\n"); |
| 417 | dev->frame_errors = 0; | 411 | dev->frame_errors = 0; |
| 418 | } | 412 | } |
| 419 | } | 413 | } |
diff --git a/drivers/net/usb/pegasus.c b/drivers/net/usb/pegasus.c index 44ae8f6d3135..41838773b568 100644 --- a/drivers/net/usb/pegasus.c +++ b/drivers/net/usb/pegasus.c | |||
| @@ -132,9 +132,10 @@ static void ctrl_callback(struct urb *urb) | |||
| 132 | case -ENOENT: | 132 | case -ENOENT: |
| 133 | break; | 133 | break; |
| 134 | default: | 134 | default: |
| 135 | if (netif_msg_drv(pegasus) && printk_ratelimit()) | 135 | if (net_ratelimit()) |
| 136 | dev_dbg(&pegasus->intf->dev, "%s, status %d\n", | 136 | netif_dbg(pegasus, drv, pegasus->net, |
