diff options
| -rw-r--r-- | drivers/isdn/gigaset/interface.c | 19 |
1 files changed, 7 insertions, 12 deletions
diff --git a/drivers/isdn/gigaset/interface.c b/drivers/isdn/gigaset/interface.c index 8ff7e35c7069..f33ac27de643 100644 --- a/drivers/isdn/gigaset/interface.c +++ b/drivers/isdn/gigaset/interface.c | |||
| @@ -408,33 +408,28 @@ static int if_write_room(struct tty_struct *tty) | |||
| 408 | return retval; | 408 | return retval; |
| 409 | } | 409 | } |
| 410 | 410 | ||
| 411 | /* FIXME: This function does not have error returns */ | ||
| 412 | |||
| 413 | static int if_chars_in_buffer(struct tty_struct *tty) | 411 | static int if_chars_in_buffer(struct tty_struct *tty) |
| 414 | { | 412 | { |
| 415 | struct cardstate *cs; | 413 | struct cardstate *cs; |
| 416 | int retval = -ENODEV; | 414 | int retval = 0; |
| 417 | 415 | ||
| 418 | cs = (struct cardstate *) tty->driver_data; | 416 | cs = (struct cardstate *) tty->driver_data; |
| 419 | if (!cs) { | 417 | if (!cs) { |
| 420 | pr_err("%s: no cardstate\n", __func__); | 418 | pr_err("%s: no cardstate\n", __func__); |
| 421 | return -ENODEV; | 419 | return 0; |
| 422 | } | 420 | } |
| 423 | 421 | ||
| 424 | gig_dbg(DEBUG_IF, "%u: %s()", cs->minor_index, __func__); | 422 | gig_dbg(DEBUG_IF, "%u: %s()", cs->minor_index, __func__); |
| 425 | 423 | ||
| 426 | if (mutex_lock_interruptible(&cs->mutex)) | 424 | mutex_lock(&cs->mutex); |
| 427 | return -ERESTARTSYS; // FIXME -EINTR? | ||
| 428 | 425 | ||
| 429 | if (!cs->connected) { | 426 | if (!cs->connected) |
| 430 | gig_dbg(DEBUG_IF, "not connected"); | 427 | gig_dbg(DEBUG_IF, "not connected"); |
| 431 | retval = -ENODEV; | 428 | else if (!cs->open_count) |
| 432 | } else if (!cs->open_count) | ||
| 433 | dev_warn(cs->dev, "%s: device not opened\n", __func__); | 429 | dev_warn(cs->dev, "%s: device not opened\n", __func__); |
| 434 | else if (cs->mstate != MS_LOCKED) { | 430 | else if (cs->mstate != MS_LOCKED) |
| 435 | dev_warn(cs->dev, "can't write to unlocked device\n"); | 431 | dev_warn(cs->dev, "can't write to unlocked device\n"); |
| 436 | retval = -EBUSY; | 432 | else |
| 437 | } else | ||
| 438 | retval = cs->ops->chars_in_buffer(cs); | 433 | retval = cs->ops->chars_in_buffer(cs); |
| 439 | 434 | ||
| 440 | mutex_unlock(&cs->mutex); | 435 | mutex_unlock(&cs->mutex); |
