diff options
| -rw-r--r-- | drivers/media/rc/redrat3.c | 39 |
1 files changed, 2 insertions, 37 deletions
diff --git a/drivers/media/rc/redrat3.c b/drivers/media/rc/redrat3.c index 47cd373e2295..610c15ef4ae6 100644 --- a/drivers/media/rc/redrat3.c +++ b/drivers/media/rc/redrat3.c | |||
| @@ -76,12 +76,6 @@ static int debug; | |||
| 76 | dev_info(dev, fmt, ## __VA_ARGS__); \ | 76 | dev_info(dev, fmt, ## __VA_ARGS__); \ |
| 77 | } while (0) | 77 | } while (0) |
| 78 | 78 | ||
| 79 | #define rr3_ftr(dev, fmt, ...) \ | ||
| 80 | do { \ | ||
| 81 | if (debug & RR3_DEBUG_FUNCTION_TRACE) \ | ||
| 82 | dev_info(dev, fmt, ## __VA_ARGS__); \ | ||
| 83 | } while (0) | ||
| 84 | |||
| 85 | /* bulk data transfer types */ | 79 | /* bulk data transfer types */ |
| 86 | #define RR3_ERROR 0x01 | 80 | #define RR3_ERROR 0x01 |
| 87 | #define RR3_MOD_SIGNAL_IN 0x20 | 81 | #define RR3_MOD_SIGNAL_IN 0x20 |
| @@ -237,8 +231,6 @@ static void redrat3_issue_async(struct redrat3_dev *rr3) | |||
| 237 | { | 231 | { |
| 238 | int res; | 232 | int res; |
| 239 | 233 | ||
| 240 | rr3_ftr(rr3->dev, "Entering %s\n", __func__); | ||
| 241 | |||
| 242 | res = usb_submit_urb(rr3->read_urb, GFP_ATOMIC); | 234 | res = usb_submit_urb(rr3->read_urb, GFP_ATOMIC); |
| 243 | if (res) | 235 | if (res) |
| 244 | rr3_dbg(rr3->dev, "%s: receive request FAILED! " | 236 | rr3_dbg(rr3->dev, "%s: receive request FAILED! " |
| @@ -377,8 +369,6 @@ static void redrat3_process_ir_data(struct redrat3_dev *rr3) | |||
| 377 | return; | 369 | return; |
| 378 | } | 370 | } |
| 379 | 371 | ||
| 380 | rr3_ftr(rr3->dev, "Entered %s\n", __func__); | ||
| 381 | |||
| 382 | dev = rr3->dev; | 372 | dev = rr3->dev; |
| 383 | 373 | ||
| 384 | /* Make sure we reset the IR kfifo after a bit of inactivity */ | 374 | /* Make sure we reset the IR kfifo after a bit of inactivity */ |
| @@ -464,8 +454,6 @@ static int redrat3_enable_detector(struct redrat3_dev *rr3) | |||
| 464 | struct device *dev = rr3->dev; | 454 | struct device *dev = rr3->dev; |
| 465 | u8 ret; | 455 | u8 ret; |
| 466 | 456 | ||
| 467 | rr3_ftr(dev, "Entering %s\n", __func__); | ||
| 468 | |||
| 469 | ret = redrat3_send_cmd(RR3_RC_DET_ENABLE, rr3); | 457 | ret = redrat3_send_cmd(RR3_RC_DET_ENABLE, rr3); |
| 470 | if (ret != 0) | 458 | if (ret != 0) |
| 471 | dev_dbg(dev, "%s: unexpected ret of %d\n", | 459 | dev_dbg(dev, "%s: unexpected ret of %d\n", |
| @@ -486,7 +474,6 @@ static int redrat3_enable_detector(struct redrat3_dev *rr3) | |||
| 486 | static inline void redrat3_delete(struct redrat3_dev *rr3, | 474 | static inline void redrat3_delete(struct redrat3_dev *rr3, |
| 487 | struct usb_device *udev) | 475 | struct usb_device *udev) |
| 488 | { | 476 | { |
| 489 | rr3_ftr(rr3->dev, "%s cleaning up\n", __func__); | ||
| 490 | usb_kill_urb(rr3->read_urb); | 477 | usb_kill_urb(rr3->read_urb); |
| 491 | usb_kill_urb(rr3->flash_urb); | 478 | usb_kill_urb(rr3->flash_urb); |
| 492 | usb_free_urb(rr3->read_urb); | 479 | usb_free_urb(rr3->read_urb); |
| @@ -535,8 +522,6 @@ static void redrat3_reset(struct redrat3_dev *rr3) | |||
| 535 | u8 *val; | 522 | u8 *val; |
| 536 | int len = sizeof(u8); | 523 | int len = sizeof(u8); |
| 537 | 524 | ||
| 538 | rr3_ftr(dev, "Entering %s\n", __func__); | ||
| 539 | |||
| 540 | rxpipe = usb_rcvctrlpipe(udev, 0); | 525 | rxpipe = usb_rcvctrlpipe(udev, 0); |
| 541 | txpipe = usb_sndctrlpipe(udev, 0); | 526 | txpipe = usb_sndctrlpipe(udev, 0); |
| 542 | 527 | ||
| @@ -572,8 +557,6 @@ static void redrat3_get_firmware_rev(struct redrat3_dev *rr3) | |||
| 572 | int rc = 0; | 557 | int rc = 0; |
| 573 | char *buffer; | 558 | char *buffer; |
| 574 | 559 | ||
| 575 | rr3_ftr(rr3->dev, "Entering %s\n", __func__); | ||
| 576 | |||
| 577 | buffer = kzalloc(sizeof(char) * (RR3_FW_VERSION_LEN + 1), GFP_KERNEL); | 560 | buffer = kzalloc(sizeof(char) * (RR3_FW_VERSION_LEN + 1), GFP_KERNEL); |
| 578 | if (!buffer) { | 561 | if (!buffer) { |
| 579 | dev_err(rr3->dev, "Memory allocation failure\n"); | 562 | dev_err(rr3->dev, "Memory allocation failure\n"); |
| @@ -591,7 +574,6 @@ static void redrat3_get_firmware_rev(struct redrat3_dev *rr3) | |||
| 591 | dev_err(rr3->dev, "Problem fetching firmware ID\n"); | 574 | dev_err(rr3->dev, "Problem fetching firmware ID\n"); |
| 592 | 575 | ||
| 593 | kfree(buffer); | 576 | kfree(buffer); |
| 594 | rr3_ftr(rr3->dev, "Exiting %s\n", __func__); | ||
| 595 | } | 577 | } |
| 596 | 578 | ||
| 597 | static void redrat3_read_packet_start(struct redrat3_dev *rr3, unsigned len) | 579 | static void redrat3_read_packet_start(struct redrat3_dev *rr3, unsigned len) |
| @@ -599,8 +581,6 @@ static void redrat3_read_packet_start(struct redrat3_dev *rr3, unsigned len) | |||
| 599 | struct redrat3_header *header = rr3->bulk_in_buf; | 581 | struct redrat3_header *header = rr3->bulk_in_buf; |
| 600 | unsigned pktlen, pkttype; | 582 | unsigned pktlen, pkttype; |
| 601 | 583 | ||
| 602 | rr3_ftr(rr3->dev, "Entering %s\n", __func__); | ||
| 603 | |||
| 604 | /* grab the Length and type of transfer */ | 584 | /* grab the Length and type of transfer */ |
| 605 | pktlen = be16_to_cpu(header->length); | 585 | pktlen = be16_to_cpu(header->length); |
| 606 | pkttype = be16_to_cpu(header->transfer_type); | 586 | pkttype = be16_to_cpu(header->transfer_type); |
| @@ -637,8 +617,6 @@ static void redrat3_read_packet_continue(struct redrat3_dev *rr3, unsigned len) | |||
| 637 | { | 617 | { |
| 638 | void *irdata = &rr3->irdata; | 618 | void *irdata = &rr3->irdata; |
| 639 | 619 | ||
| 640 | rr3_ftr(rr3->dev, "Entering %s\n", __func__); | ||
| 641 | |||
| 642 | if (len + rr3->bytes_read > sizeof(rr3->irdata)) { | 620 | if (len + rr3->bytes_read > sizeof(rr3->irdata)) { |
| 643 | dev_warn(rr3->dev, "too much data for packet\n"); | 621 | dev_warn(rr3->dev, "too much data for packet\n"); |
| 644 | rr3->bytes_read = 0; | 622 | rr3->bytes_read = 0; |
| @@ -659,8 +637,6 @@ static int redrat3_get_ir_data(struct redrat3_dev *rr3, unsigned len) | |||
| 659 | unsigned pkttype; | 637 | unsigned pkttype; |
| 660 | int ret = 0; | 638 | int ret = 0; |
| 661 | 639 | ||
| 662 | rr3_ftr(dev, "Entering %s\n", __func__); | ||
| 663 | |||
| 664 | if (rr3->bytes_read == 0 && len >= sizeof(struct redrat3_header)) { | 640 | if (rr3->bytes_read == 0 && len >= sizeof(struct redrat3_header)) { |
| 665 | redrat3_read_packet_start(rr3, len); | 641 | redrat3_read_packet_start(rr3, len); |
| 666 | } else if (rr3->bytes_read != 0) { | 642 | } else if (rr3->bytes_read != 0) { |
| @@ -705,8 +681,6 @@ static void redrat3_handle_async(struct urb *urb) | |||
| 705 | return; | 681 | return; |
| 706 | } | 682 | } |
| 707 | 683 | ||
| 708 | rr3_ftr(rr3->dev, "Entering %s\n", __func__); | ||
| 709 | |||
| 710 | switch (urb->status) { | 684 | switch (urb->status) { |
| 711 | case 0: | 685 | case 0: |
| 712 | ret = redrat3_get_ir_data(rr3, urb->actual_length); | 686 | ret = redrat3_get_ir_data(rr3, urb->actual_length); |
| @@ -764,8 +738,6 @@ static int redrat3_transmit_ir(struct rc_dev *rcdev, unsigned *txbuf, | |||
| 764 | u8 curlencheck = 0; | 738 | u8 curlencheck = 0; |
| 765 | unsigned i, sendbuf_len; | 739 | unsigned i, sendbuf_len; |
| 766 | 740 | ||
| 767 | rr3_ftr(dev, "Entering %s\n", __func__); | ||
| 768 | |||
| 769 | if (rr3->transmitting) { | 741 | if (rr3->transmitting) { |
| 770 | dev_warn(dev, "%s: transmitter already in use\n", __func__); | 742 | dev_warn(dev, "%s: transmitter already in use\n", __func__); |
| 771 | return -EAGAIN; | 743 | return -EAGAIN; |
| @@ -957,8 +929,6 @@ static int redrat3_dev_probe(struct usb_interface *intf, | |||
| 957 | int pipe, i; | 929 | int pipe, i; |
| 958 | int retval = -ENOMEM; | 930 | int retval = -ENOMEM; |
| 959 | 931 | ||
| 960 | rr3_ftr(dev, "%s called\n", __func__); | ||
| 961 | |||
| 962 | uhi = intf->cur_altsetting; | 932 | uhi = intf->cur_altsetting; |
| 963 | 933 | ||
| 964 | /* find our bulk-in and bulk-out endpoints */ | 934 | /* find our bulk-in and bulk-out endpoints */ |
| @@ -1074,7 +1044,6 @@ static int redrat3_dev_probe(struct usb_interface *intf, | |||
| 1074 | /* we can register the device now, as it is ready */ | 1044 | /* we can register the device now, as it is ready */ |
| 1075 | usb_set_intfdata(intf, rr3); | 1045 | usb_set_intfdata(intf, rr3); |
| 1076 | 1046 | ||
| 1077 | rr3_ftr(dev, "Exiting %s\n", __func__); | ||
| 1078 | return 0; | 1047 | return 0; |
| 1079 | 1048 | ||
| 1080 | led_free_error: | 1049 | led_free_error: |
| @@ -1093,8 +1062,6 @@ static void redrat3_dev_disconnect(struct usb_interface *intf) | |||
| 1093 | struct usb_device *udev = interface_to_usbdev(intf); | 1062 | struct usb_device *udev = interface_to_usbdev(intf); |
| 1094 | struct redrat3_dev *rr3 = usb_get_intfdata(intf); | 1063 | struct redrat3_dev *rr3 = usb_get_intfdata(intf); |
| 1095 | 1064 | ||
| 1096 | rr3_ftr(&intf->dev, "Entering %s\n", __func__); | ||
| 1097 | |||
| 1098 | if (!rr3) | 1065 | if (!rr3) |
| 1099 | return; | 1066 | return; |
| 1100 | 1067 | ||
| @@ -1103,14 +1070,12 @@ static void redrat3_dev_disconnect(struct usb_interface *intf) | |||
| 1103 | led_classdev_unregister(&rr3->led); | 1070 | led_classdev_unregister(&rr3->led); |
| 1104 | del_timer_sync(&rr3->rx_timeout); | 1071 | del_timer_sync(&rr3->rx_timeout); |
| 1105 | redrat3_delete(rr3, udev); | 1072 | redrat3_delete(rr3, udev); |
| 1106 | |||
| 1107 | rr3_ftr(&intf->dev, "RedRat3 IR Transceiver now disconnected\n"); | ||
| 1108 | } | 1073 | } |
| 1109 | 1074 | ||
| 1110 | static int redrat3_dev_suspend(struct usb_interface *intf, pm_message_t message) | 1075 | static int redrat3_dev_suspend(struct usb_interface *intf, pm_message_t message) |
| 1111 | { | ||
