diff options
-rw-r--r-- | block/blk-mq.c | 11 | ||||
-rw-r--r-- | include/linux/percpu-refcount.h | 1 | ||||
-rw-r--r-- | lib/percpu-refcount.c | 16 |
3 files changed, 1 insertions, 27 deletions
diff --git a/block/blk-mq.c b/block/blk-mq.c index 255d79c14dc1..44a78ae3f899 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c | |||
@@ -119,16 +119,7 @@ void blk_mq_freeze_queue(struct request_queue *q) | |||
119 | spin_unlock_irq(q->queue_lock); | 119 | spin_unlock_irq(q->queue_lock); |
120 | 120 | ||
121 | if (freeze) { | 121 | if (freeze) { |
122 | /* | 122 | percpu_ref_kill(&q->mq_usage_counter); |
123 | * XXX: Temporary kludge to work around SCSI blk-mq stall. | ||
124 | * SCSI synchronously creates and destroys many queues | ||
125 | * back-to-back during probe leading to lengthy stalls. | ||
126 | * This will be fixed by keeping ->mq_usage_counter in | ||
127 | * atomic mode until genhd registration, but, for now, | ||
128 | * let's work around using expedited synchronization. | ||
129 | */ | ||
130 | __percpu_ref_kill_expedited(&q->mq_usage_counter); | ||
131 | |||
132 | blk_mq_run_queues(q, false); | 123 | blk_mq_run_queues(q, false); |
133 | } | 124 | } |
134 | wait_event(q->mq_freeze_wq, percpu_ref_is_zero(&q->mq_usage_counter)); | 125 | wait_event(q->mq_freeze_wq, percpu_ref_is_zero(&q->mq_usage_counter)); |
diff --git a/include/linux/percpu-refcount.h b/include/linux/percpu-refcount.h index 11b38ceca7e2..5df6784bd9d2 100644 --- a/include/linux/percpu-refcount.h +++ b/include/linux/percpu-refcount.h | |||
@@ -72,7 +72,6 @@ void percpu_ref_reinit(struct percpu_ref *ref); | |||
72 | void percpu_ref_exit(struct percpu_ref *ref); | 72 | void percpu_ref_exit(struct percpu_ref *ref); |
73 | void percpu_ref_kill_and_confirm(struct percpu_ref *ref, | 73 | void percpu_ref_kill_and_confirm(struct percpu_ref *ref, |
74 | percpu_ref_func_t *confirm_kill); | 74 | percpu_ref_func_t *confirm_kill); |
75 | void __percpu_ref_kill_expedited(struct percpu_ref *ref); | ||
76 | 75 | ||
77 | /** | 76 | /** |
78 | * percpu_ref_kill - drop the initial ref | 77 | * percpu_ref_kill - drop the initial ref |
diff --git a/lib/percpu-refcount.c b/lib/percpu-refcount.c index c6c31e2829b1..559ee0b20318 100644 --- a/lib/percpu-refcount.c +++ b/lib/percpu-refcount.c | |||
@@ -189,19 +189,3 @@ void percpu_ref_kill_and_confirm(struct percpu_ref *ref, | |||
189 | call_rcu_sched(&ref->rcu, percpu_ref_kill_rcu); | 189 | call_rcu_sched(&ref->rcu, percpu_ref_kill_rcu); |
190 | } | 190 | } |
191 | EXPORT_SYMBOL_GPL(percpu_ref_kill_and_confirm); | 191 | EXPORT_SYMBOL_GPL(percpu_ref_kill_and_confirm); |
192 | |||
193 | /* | ||
194 | * XXX: Temporary kludge to work around SCSI blk-mq stall. Used only by | ||
195 | * block/blk-mq.c::blk_mq_freeze_queue(). Will be removed during v3.18 | ||
196 | * devel cycle. Do not use anywhere else. | ||
197 | */ | ||
198 | void __percpu_ref_kill_expedited(struct percpu_ref *ref) | ||
199 | { | ||
200 | WARN_ONCE(ref->pcpu_count_ptr & PCPU_REF_DEAD, | ||
201 | "percpu_ref_kill() called more than once on %pf!", | ||
202 | ref->release); | ||
203 | |||
204 | ref->pcpu_count_ptr |= PCPU_REF_DEAD; | ||
205 | synchronize_sched_expedited(); | ||
206 | percpu_ref_kill_rcu(&ref->rcu); | ||
207 | } | ||