aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--fs/nfs/file.c26
-rw-r--r--fs/nfs/write.c2
2 files changed, 18 insertions, 10 deletions
diff --git a/fs/nfs/file.c b/fs/nfs/file.c
index 23e5f0ea5c83..325df0aeab05 100644
--- a/fs/nfs/file.c
+++ b/fs/nfs/file.c
@@ -475,17 +475,23 @@ static int nfs_release_page(struct page *page, gfp_t gfp)
475 475
476 dfprintk(PAGECACHE, "NFS: release_page(%p)\n", page); 476 dfprintk(PAGECACHE, "NFS: release_page(%p)\n", page);
477 477
478 /* Only do I/O if gfp is a superset of GFP_KERNEL, and we're not 478 /* Always try to initiate a 'commit' if relevant, but only
479 * doing this memory reclaim for a fs-related allocation. 479 * wait for it if __GFP_WAIT is set and the calling process is
480 * allowed to block. Even then, only wait 1 second.
481 * Waiting indefinitely can cause deadlocks when the NFS
482 * server is on this machine, and there is no particular need
483 * to wait extensively here. A short wait has the benefit
484 * that someone else can worry about the freezer.
480 */ 485 */
481 if (mapping && (gfp & GFP_KERNEL) == GFP_KERNEL && 486 if (mapping) {
482 !(current->flags & PF_FSTRANS)) { 487 struct nfs_server *nfss = NFS_SERVER(mapping->host);
483 int how = FLUSH_SYNC; 488 nfs_commit_inode(mapping->host, 0);
484 489 if ((gfp & __GFP_WAIT) &&
485 /* Don't let kswapd deadlock waiting for OOM RPC calls */ 490 !current_is_kswapd() &&
486 if (current_is_kswapd()) 491 !(current->flags & PF_FSTRANS)) {
487 how = 0; 492 wait_on_page_bit_killable_timeout(page, PG_private,
488 nfs_commit_inode(mapping->host, how); 493 HZ);
494 }
489 } 495 }
490 /* If PagePrivate() is set, then the page is not freeable */ 496 /* If PagePrivate() is set, then the page is not freeable */
491 if (PagePrivate(page)) 497 if (PagePrivate(page))
diff --git a/fs/nfs/write.c b/fs/nfs/write.c
index a623b00530c3..c063a4e70354 100644
--- a/fs/nfs/write.c
+++ b/fs/nfs/write.c
@@ -705,6 +705,8 @@ static void nfs_inode_remove_request(struct nfs_page *req)
705 if (likely(!PageSwapCache(head->wb_page))) { 705 if (likely(!PageSwapCache(head->wb_page))) {
706 set_page_private(head->wb_page, 0); 706 set_page_private(head->wb_page, 0);
707 ClearPagePrivate(head->wb_page); 707 ClearPagePrivate(head->wb_page);
708 smp_mb__after_atomic();
709 wake_up_page(head->wb_page, PG_private);
708 clear_bit(PG_MAPPED, &head->wb_flags); 710 clear_bit(PG_MAPPED, &head->wb_flags);
709 } 711 }
710 nfsi->npages--; 712 nfsi->npages--;