diff options
-rw-r--r-- | arch/x86/ia32/ia32_signal.c | 17 | ||||
-rw-r--r-- | arch/x86/include/asm/sighandling.h | 4 | ||||
-rw-r--r-- | arch/x86/kernel/signal.c | 22 |
3 files changed, 15 insertions, 28 deletions
diff --git a/arch/x86/ia32/ia32_signal.c b/arch/x86/ia32/ia32_signal.c index 1f5e2b0e09ff..c81d35e6c7f1 100644 --- a/arch/x86/ia32/ia32_signal.c +++ b/arch/x86/ia32/ia32_signal.c | |||
@@ -161,8 +161,7 @@ int copy_siginfo_from_user32(siginfo_t *to, compat_siginfo_t __user *from) | |||
161 | } | 161 | } |
162 | 162 | ||
163 | static int ia32_restore_sigcontext(struct pt_regs *regs, | 163 | static int ia32_restore_sigcontext(struct pt_regs *regs, |
164 | struct sigcontext_ia32 __user *sc, | 164 | struct sigcontext_ia32 __user *sc) |
165 | unsigned int *pax) | ||
166 | { | 165 | { |
167 | unsigned int tmpflags, err = 0; | 166 | unsigned int tmpflags, err = 0; |
168 | void __user *buf; | 167 | void __user *buf; |
@@ -184,7 +183,7 @@ static int ia32_restore_sigcontext(struct pt_regs *regs, | |||
184 | RELOAD_SEG(es); | 183 | RELOAD_SEG(es); |
185 | 184 | ||
186 | COPY(di); COPY(si); COPY(bp); COPY(sp); COPY(bx); | 185 | COPY(di); COPY(si); COPY(bp); COPY(sp); COPY(bx); |
187 | COPY(dx); COPY(cx); COPY(ip); | 186 | COPY(dx); COPY(cx); COPY(ip); COPY(ax); |
188 | /* Don't touch extended registers */ | 187 | /* Don't touch extended registers */ |
189 | 188 | ||
190 | COPY_SEG_CPL3(cs); | 189 | COPY_SEG_CPL3(cs); |
@@ -197,8 +196,6 @@ static int ia32_restore_sigcontext(struct pt_regs *regs, | |||
197 | 196 | ||
198 | get_user_ex(tmp, &sc->fpstate); | 197 | get_user_ex(tmp, &sc->fpstate); |
199 | buf = compat_ptr(tmp); | 198 | buf = compat_ptr(tmp); |
200 | |||
201 | get_user_ex(*pax, &sc->ax); | ||
202 | } get_user_catch(err); | 199 | } get_user_catch(err); |
203 | 200 | ||
204 | err |= restore_xstate_sig(buf, 1); | 201 | err |= restore_xstate_sig(buf, 1); |
@@ -213,7 +210,6 @@ asmlinkage long sys32_sigreturn(void) | |||
213 | struct pt_regs *regs = current_pt_regs(); | 210 | struct pt_regs *regs = current_pt_regs(); |
214 | struct sigframe_ia32 __user *frame = (struct sigframe_ia32 __user *)(regs->sp-8); | 211 | struct sigframe_ia32 __user *frame = (struct sigframe_ia32 __user *)(regs->sp-8); |
215 | sigset_t set; | 212 | sigset_t set; |
216 | unsigned int ax; | ||
217 | 213 | ||
218 | if (!access_ok(VERIFY_READ, frame, sizeof(*frame))) | 214 | if (!access_ok(VERIFY_READ, frame, sizeof(*frame))) |
219 | goto badframe; | 215 | goto badframe; |
@@ -226,9 +222,9 @@ asmlinkage long sys32_sigreturn(void) | |||
226 | 222 | ||
227 | set_current_blocked(&set); | 223 | set_current_blocked(&set); |
228 | 224 | ||
229 | if (ia32_restore_sigcontext(regs, &frame->sc, &ax)) | 225 | if (ia32_restore_sigcontext(regs, &frame->sc)) |
230 | goto badframe; | 226 | goto badframe; |
231 | return ax; | 227 | return regs->ax; |
232 | 228 | ||
233 | badframe: | 229 | badframe: |
234 | signal_fault(regs, frame, "32bit sigreturn"); | 230 | signal_fault(regs, frame, "32bit sigreturn"); |
@@ -240,7 +236,6 @@ asmlinkage long sys32_rt_sigreturn(void) | |||
240 | struct pt_regs *regs = current_pt_regs(); | 236 | struct pt_regs *regs = current_pt_regs(); |
241 | struct rt_sigframe_ia32 __user *frame; | 237 | struct rt_sigframe_ia32 __user *frame; |
242 | sigset_t set; | 238 | sigset_t set; |
243 | unsigned int ax; | ||
244 | 239 | ||
245 | frame = (struct rt_sigframe_ia32 __user *)(regs->sp - 4); | 240 | frame = (struct rt_sigframe_ia32 __user *)(regs->sp - 4); |
246 | 241 | ||
@@ -251,13 +246,13 @@ asmlinkage long sys32_rt_sigreturn(void) | |||
251 | 246 | ||
252 | set_current_blocked(&set); | 247 | set_current_blocked(&set); |
253 | 248 | ||
254 | if (ia32_restore_sigcontext(regs, &frame->uc.uc_mcontext, &ax)) | 249 | if (ia32_restore_sigcontext(regs, &frame->uc.uc_mcontext)) |
255 | goto badframe; | 250 | goto badframe; |
256 | 251 | ||
257 | if (compat_restore_altstack(&frame->uc.uc_stack)) | 252 | if (compat_restore_altstack(&frame->uc.uc_stack)) |
258 | goto badframe; | 253 | goto badframe; |
259 | 254 | ||
260 | return ax; | 255 | return regs->ax; |
261 | 256 | ||
262 | badframe: | 257 | badframe: |
263 | signal_fault(regs, frame, "32bit rt sigreturn"); | 258 | signal_fault(regs, frame, "32bit rt sigreturn"); |
diff --git a/arch/x86/include/asm/sighandling.h b/arch/x86/include/asm/sighandling.h index 7a958164088c..89db46752a8f 100644 --- a/arch/x86/include/asm/sighandling.h +++ b/arch/x86/include/asm/sighandling.h | |||
@@ -13,9 +13,7 @@ | |||
13 | X86_EFLAGS_CF | X86_EFLAGS_RF) | 13 | X86_EFLAGS_CF | X86_EFLAGS_RF) |
14 | 14 | ||
15 | void signal_fault(struct pt_regs *regs, void __user *frame, char *where); | 15 | void signal_fault(struct pt_regs *regs, void __user *frame, char *where); |
16 | 16 | int restore_sigcontext(struct pt_regs *regs, struct sigcontext __user *sc); | |
17 | int restore_sigcontext(struct pt_regs *regs, struct sigcontext __user *sc, | ||
18 | unsigned long *pax); | ||
19 | int setup_sigcontext(struct sigcontext __user *sc, void __user *fpstate, | 17 | int setup_sigcontext(struct sigcontext __user *sc, void __user *fpstate, |
20 | struct pt_regs *regs, unsigned long mask); | 18 | struct pt_regs *regs, unsigned long mask); |
21 | 19 | ||
diff --git a/arch/x86/kernel/signal.c b/arch/x86/kernel/signal.c index eaa2c5e3f2cd..53cc4085c3d7 100644 --- a/arch/x86/kernel/signal.c +++ b/arch/x86/kernel/signal.c | |||
@@ -61,8 +61,7 @@ | |||
61 | regs->seg = GET_SEG(seg) | 3; \ | 61 | regs->seg = GET_SEG(seg) | 3; \ |
62 | } while (0) | 62 | } while (0) |
63 | 63 | ||
64 | int restore_sigcontext(struct pt_regs *regs, struct sigcontext __user *sc, | 64 | int restore_sigcontext(struct pt_regs *regs, struct sigcontext __user *sc) |
65 | unsigned long *pax) | ||
66 | { | 65 | { |
67 | void __user *buf; | 66 | void __user *buf; |
68 | unsigned int tmpflags; | 67 | unsigned int tmpflags; |
@@ -81,7 +80,7 @@ int restore_sigcontext(struct pt_regs *regs, struct sigcontext __user *sc, | |||
81 | #endif /* CONFIG_X86_32 */ | 80 | #endif /* CONFIG_X86_32 */ |
82 | 81 | ||
83 | COPY(di); COPY(si); COPY(bp); COPY(sp); COPY(bx); | 82 | COPY(di); COPY(si); COPY(bp); COPY(sp); COPY(bx); |
84 | COPY(dx); COPY(cx); COPY(ip); | 83 | COPY(dx); COPY(cx); COPY(ip); COPY(ax); |
85 | 84 | ||
86 | #ifdef CONFIG_X86_64 | 85 | #ifdef CONFIG_X86_64 |
87 | COPY(r8); | 86 | COPY(r8); |
@@ -102,8 +101,6 @@ int restore_sigcontext(struct pt_regs *regs, struct sigcontext __user *sc, | |||
102 | regs->orig_ax = -1; /* disable syscall checks */ | 101 | regs->orig_ax = -1; /* disable syscall checks */ |
103 | 102 | ||
104 | get_user_ex(buf, &sc->fpstate); | 103 | get_user_ex(buf, &sc->fpstate); |
105 | |||
106 | get_user_ex(*pax, &sc->ax); | ||
107 | } get_user_catch(err); | 104 | } get_user_catch(err); |
108 | 105 | ||
109 | err |= restore_xstate_sig(buf, config_enabled(CONFIG_X86_32)); | 106 | err |= restore_xstate_sig(buf, config_enabled(CONFIG_X86_32)); |
@@ -545,7 +542,6 @@ asmlinkage unsigned long sys_sigreturn(void) | |||
545 | { | 542 | { |
546 | struct pt_regs *regs = current_pt_regs(); | 543 | struct pt_regs *regs = current_pt_regs(); |
547 | struct sigframe __user *frame; | 544 | struct sigframe __user *frame; |
548 | unsigned long ax; | ||
549 | sigset_t set; | 545 | sigset_t set; |
550 | 546 | ||
551 | frame = (struct sigframe __user *)(regs->sp - 8); | 547 | frame = (struct sigframe __user *)(regs->sp - 8); |
@@ -559,9 +555,9 @@ asmlinkage unsigned long sys_sigreturn(void) | |||
559 | 555 | ||
560 | set_current_blocked(&set); | 556 | set_current_blocked(&set); |
561 | 557 | ||
562 | if (restore_sigcontext(regs, &frame->sc, &ax)) | 558 | if (restore_sigcontext(regs, &frame->sc)) |
563 | goto badframe; | 559 | goto badframe; |
564 | return ax; | 560 | return regs->ax; |
565 | 561 | ||
566 | badframe: | 562 | badframe: |
567 | signal_fault(regs, frame, "sigreturn"); | 563 | signal_fault(regs, frame, "sigreturn"); |
@@ -574,7 +570,6 @@ asmlinkage long sys_rt_sigreturn(void) | |||
574 | { | 570 | { |
575 | struct pt_regs *regs = current_pt_regs(); | 571 | struct pt_regs *regs = current_pt_regs(); |
576 | struct rt_sigframe __user *frame; | 572 | struct rt_sigframe __user *frame; |
577 | unsigned long ax; | ||
578 | sigset_t set; | 573 | sigset_t set; |
579 | 574 | ||
580 | frame = (struct rt_sigframe __user *)(regs->sp - sizeof(long)); | 575 | frame = (struct rt_sigframe __user *)(regs->sp - sizeof(long)); |
@@ -585,13 +580,13 @@ asmlinkage long sys_rt_sigreturn(void) | |||
585 | 580 | ||
586 | set_current_blocked(&set); | 581 | set_current_blocked(&set); |
587 | 582 | ||
588 | if (restore_sigcontext(regs, &frame->uc.uc_mcontext, &ax)) | 583 | if (restore_sigcontext(regs, &frame->uc.uc_mcontext)) |
589 | goto badframe; | 584 | goto badframe; |
590 | 585 | ||
591 | if (restore_altstack(&frame->uc.uc_stack)) | 586 | if (restore_altstack(&frame->uc.uc_stack)) |
592 | goto badframe; | 587 | goto badframe; |
593 | 588 | ||
594 | return ax; | 589 | return regs->ax; |
595 | 590 | ||
596 | badframe: | 591 | badframe: |
597 | signal_fault(regs, frame, "rt_sigreturn"); | 592 | signal_fault(regs, frame, "rt_sigreturn"); |
@@ -786,7 +781,6 @@ asmlinkage long sys32_x32_rt_sigreturn(void) | |||
786 | struct pt_regs *regs = current_pt_regs(); | 781 | struct pt_regs *regs = current_pt_regs(); |
787 | struct rt_sigframe_x32 __user *frame; | 782 | struct rt_sigframe_x32 __user *frame; |
788 | sigset_t set; | 783 | sigset_t set; |
789 | unsigned long ax; | ||
790 | 784 | ||
791 | frame = (struct rt_sigframe_x32 __user *)(regs->sp - 8); | 785 | frame = (struct rt_sigframe_x32 __user *)(regs->sp - 8); |
792 | 786 | ||
@@ -797,13 +791,13 @@ asmlinkage long sys32_x32_rt_sigreturn(void) | |||
797 | 791 | ||
798 | set_current_blocked(&set); | 792 | set_current_blocked(&set); |
799 | 793 | ||
800 | if (restore_sigcontext(regs, &frame->uc.uc_mcontext, &ax)) | 794 | if (restore_sigcontext(regs, &frame->uc.uc_mcontext)) |
801 | goto badframe; | 795 | goto badframe; |
802 | 796 | ||
803 | if (compat_restore_altstack(&frame->uc.uc_stack)) | 797 | if (compat_restore_altstack(&frame->uc.uc_stack)) |
804 | goto badframe; | 798 | goto badframe; |
805 | 799 | ||
806 | return ax; | 800 | return regs->ax; |
807 | 801 | ||
808 | badframe: | 802 | badframe: |
809 | signal_fault(regs, frame, "x32 rt_sigreturn"); | 803 | signal_fault(regs, frame, "x32 rt_sigreturn"); |