10 files changed, 295 insertions, 505 deletions

diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
index e61e7b8a2eaf..afe6f9a919c1 100644
--- a/drivers/acpi/bus.c
+++ b/drivers/acpi/bus.c
@@ -400,7 +400,7 @@ static void acpi_bus_notify(acpi_handle handle, u32 type, void *data)
         case ACPI_NOTIFY_BUS_CHECK:
         case ACPI_NOTIFY_DEVICE_CHECK:
         case ACPI_NOTIFY_EJECT_REQUEST:
-                status = acpi_hotplug_execute(acpi_device_hotplug, adev, type);
+                status = acpi_hotplug_schedule(adev, type);
                 if (ACPI_SUCCESS(status))
                         return;
         default:
diff --git a/drivers/acpi/container.c b/drivers/acpi/container.c
index 368f9ddb8480..a55cccbc7356 100644
--- a/drivers/acpi/container.c
+++ b/drivers/acpi/container.c
@@ -68,6 +68,9 @@ static int container_device_attach(struct acpi_device *adev,
         struct device *dev;
         int ret;
 
+        if (adev->flags.is_dock_station)
+                return 0;
+
         cdev = kzalloc(sizeof(*cdev), GFP_KERNEL);
         if (!cdev)
                 return -ENOMEM;
diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c
index 5bfd769fc91f..a7bd3002dbbc 100644
--- a/drivers/acpi/dock.c
+++ b/drivers/acpi/dock.c
@@ -1,7 +1,9 @@
 /*
  *  dock.c - ACPI dock station driver
  *
- *  Copyright (C) 2006 Kristen Carlson Accardi <kristen.c.accardi@intel.com>
+ *  Copyright (C) 2006, 2014, Intel Corp.
+ *  Author: Kristen Carlson Accardi <kristen.c.accardi@intel.com>
+ *          Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  *
  * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  *
@@ -68,15 +70,10 @@ struct dock_station {
 };
 static LIST_HEAD(dock_stations);
 static int dock_station_count;
-static DEFINE_MUTEX(hotplug_lock);
 
 struct dock_dependent_device {
         struct list_head list;
-        acpi_handle handle;
-        const struct acpi_dock_ops *hp_ops;
-        void *hp_context;
-        unsigned int hp_refcount;
-        void (*hp_release)(void *);
+        struct acpi_device *adev;
 };
 
 #define DOCK_DOCKING    0x00000001
@@ -98,13 +95,13 @@ enum dock_callback_type {
  *****************************************************************************/
 /**
  * add_dock_dependent_device - associate a device with the dock station
- * @ds: The dock station
- * @handle: handle of the dependent device
+ * @ds: Dock station.
+ * @adev: Dependent ACPI device object.
  *
  * Add the dependent device to the dock's dependent device list.
  */
-static int __init
-add_dock_dependent_device(struct dock_station *ds, acpi_handle handle)
+static int add_dock_dependent_device(struct dock_station *ds,
+                                     struct acpi_device *adev)
 {
         struct dock_dependent_device *dd;
 
@@ -112,180 +109,120 @@ add_dock_dependent_device(struct dock_station *ds, acpi_handle handle)
         if (!dd)
                 return -ENOMEM;
 
-        dd->handle = handle;
+        dd->adev = adev;
         INIT_LIST_HEAD(&dd->list);
         list_add_tail(&dd->list, &ds->dependent_devices);
 
         return 0;
 }
 
-static void remove_dock_dependent_devices(struct dock_station *ds)
+static void dock_hotplug_event(struct dock_dependent_device *dd, u32 event,
+                               enum dock_callback_type cb_type)
 {
-        struct dock_dependent_device *dd, *aux;
+        struct acpi_device *adev = dd->adev;
 
-        list_for_each_entry_safe(dd, aux, &ds->dependent_devices, list) {
-                list_del(&dd->list);
-                kfree(dd);
-        }
-}
+        acpi_lock_hp_context();
 
-/**
- * dock_init_hotplug - Initialize a hotplug device on a docking station.
- * @dd: Dock-dependent device.
- * @ops: Dock operations to attach to the dependent device.
- * @context: Data to pass to the @ops callbacks and @release.
- * @init: Optional initialization routine to run after setting up context.
- * @release: Optional release routine to run on removal.
- */
-static int dock_init_hotplug(struct dock_dependent_device *dd,
-                             const struct acpi_dock_ops *ops, void *context,
-                             void (*init)(void *), void (*release)(void *))
-{
-        int ret = 0;
+        if (!adev->hp)
+                goto out;
 
-        mutex_lock(&hotplug_lock);
-        if (WARN_ON(dd->hp_context)) {
-                ret = -EEXIST;
-        } else {
-                dd->hp_refcount = 1;
-                dd->hp_ops = ops;
-                dd->hp_context = context;
-                dd->hp_release = release;
-                if (init)
-                        init(context);
-        }
-        mutex_unlock(&hotplug_lock);
-        return ret;
-}
+        if (cb_type == DOCK_CALL_FIXUP) {
+                void (*fixup)(struct acpi_device *);
 
-/**
- * dock_release_hotplug - Decrement hotplug reference counter of dock device.
- * @dd: Dock-dependent device.
- *
- * Decrement the reference counter of @dd and if 0, detach its hotplug
- * operations from it, reset its context pointer and run the optional release
- * routine if present.
- */
-static void dock_release_hotplug(struct dock_dependent_device *dd)
-{
-        mutex_lock(&hotplug_lock);
-        if (dd->hp_context && !--dd->hp_refcount) {
-                void (*release)(void *) = dd->hp_release;
-                void *context = dd->hp_context;
-
-                dd->hp_ops = NULL;
-                dd->hp_context = NULL;
-                dd->hp_release = NULL;
-                if (release)
-                        release(context);
-        }
-        mutex_unlock(&hotplug_lock);
-}
+                fixup = adev->hp->fixup;
+                if (fixup) {
+                        acpi_unlock_hp_context();
+                        fixup(adev);
+                        return;
+                }
+        } else if (cb_type == DOCK_CALL_UEVENT) {
+                void (*uevent)(struct acpi_device *, u32);
+
+                uevent = adev->hp->uevent;
+                if (uevent) {
+                        acpi_unlock_hp_context();
+                        uevent(adev, event);
+                        return;
+                }
+        } else {
+                int (*notify)(struct acpi_device *, u32);
 
-static void dock_hotplug_event(struct dock_dependent_device *dd, u32 event,
-                               enum dock_callback_type cb_type)
-{
-        acpi_notify_handler cb = NULL;
+                notify = adev->hp->notify;
+                if (notify) {
+                        acpi_unlock_hp_context();
+                        notify(adev, event);