diff options
| -rw-r--r-- | net/can/raw.c | 3 | ||||
| -rw-r--r-- | net/dccp/probe.c | 2 | ||||
| -rw-r--r-- | net/tipc/socket.c | 4 |
3 files changed, 5 insertions, 4 deletions
diff --git a/net/can/raw.c b/net/can/raw.c index ead50c7c0d40..201cbfc6b9ec 100644 --- a/net/can/raw.c +++ b/net/can/raw.c | |||
| @@ -573,7 +573,8 @@ static int raw_getsockopt(struct socket *sock, int level, int optname, | |||
| 573 | int fsize = ro->count * sizeof(struct can_filter); | 573 | int fsize = ro->count * sizeof(struct can_filter); |
| 574 | if (len > fsize) | 574 | if (len > fsize) |
| 575 | len = fsize; | 575 | len = fsize; |
| 576 | err = copy_to_user(optval, ro->filter, len); | 576 | if (copy_to_user(optval, ro->filter, len)) |
| 577 | err = -EFAULT; | ||
| 577 | } else | 578 | } else |
| 578 | len = 0; | 579 | len = 0; |
| 579 | release_sock(sk); | 580 | release_sock(sk); |
diff --git a/net/dccp/probe.c b/net/dccp/probe.c index 6e1df62bd7c9..0bcdc9250279 100644 --- a/net/dccp/probe.c +++ b/net/dccp/probe.c | |||
| @@ -140,7 +140,7 @@ static ssize_t dccpprobe_read(struct file *file, char __user *buf, | |||
| 140 | goto out_free; | 140 | goto out_free; |
| 141 | 141 | ||
| 142 | cnt = kfifo_get(dccpw.fifo, tbuf, len); | 142 | cnt = kfifo_get(dccpw.fifo, tbuf, len); |
| 143 | error = copy_to_user(buf, tbuf, cnt); | 143 | error = copy_to_user(buf, tbuf, cnt) ? -EFAULT : 0; |
| 144 | 144 | ||
| 145 | out_free: | 145 | out_free: |
| 146 | vfree(tbuf); | 146 | vfree(tbuf); |
diff --git a/net/tipc/socket.c b/net/tipc/socket.c index 05853159536a..230f9ca2ad6b 100644 --- a/net/tipc/socket.c +++ b/net/tipc/socket.c | |||
| @@ -1756,8 +1756,8 @@ static int getsockopt(struct socket *sock, | |||
| 1756 | else if (len < sizeof(value)) { | 1756 | else if (len < sizeof(value)) { |
| 1757 | res = -EINVAL; | 1757 | res = -EINVAL; |
| 1758 | } | 1758 | } |
| 1759 | else if ((res = copy_to_user(ov, &value, sizeof(value)))) { | 1759 | else if (copy_to_user(ov, &value, sizeof(value))) { |
| 1760 | /* couldn't return value */ | 1760 | res = -EFAULT; |
| 1761 | } | 1761 | } |
| 1762 | else { | 1762 | else { |
| 1763 | res = put_user(sizeof(value), ol); | 1763 | res = put_user(sizeof(value), ol); |
