diff options
| -rw-r--r-- | drivers/net/usb/r8152.c | 23 |
1 files changed, 13 insertions, 10 deletions
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 881475f48459..bf7d549ab511 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/usb/r8152.c | |||
| @@ -966,10 +966,12 @@ static void read_bulk_callback(struct urb *urb) | |||
| 966 | case -ENOENT: | 966 | case -ENOENT: |
| 967 | return; /* the urb is in unlink state */ | 967 | return; /* the urb is in unlink state */ |
| 968 | case -ETIME: | 968 | case -ETIME: |
| 969 | pr_warn_ratelimited("may be reset is needed?..\n"); | 969 | if (net_ratelimit()) |
| 970 | netdev_warn(netdev, "maybe reset is needed?\n"); | ||
| 970 | break; | 971 | break; |
| 971 | default: | 972 | default: |
| 972 | pr_warn_ratelimited("Rx status %d\n", status); | 973 | if (net_ratelimit()) |
| 974 | netdev_warn(netdev, "Rx status %d\n", status); | ||
| 973 | break; | 975 | break; |
| 974 | } | 976 | } |
| 975 | 977 | ||
| @@ -1002,7 +1004,8 @@ static void write_bulk_callback(struct urb *urb) | |||
| 1002 | 1004 | ||
| 1003 | stats = rtl8152_get_stats(tp->netdev); | 1005 | stats = rtl8152_get_stats(tp->netdev); |
| 1004 | if (status) { | 1006 | if (status) { |
| 1005 | pr_warn_ratelimited("Tx status %d\n", status); | 1007 | if (net_ratelimit()) |
| 1008 | netdev_warn(tp->netdev, "Tx status %d\n", status); | ||
| 1006 | stats->tx_errors += agg->skb_num; | 1009 | stats->tx_errors += agg->skb_num; |
| 1007 | } else { | 1010 | } else { |
| 1008 | stats->tx_packets += agg->skb_num; | 1011 | stats->tx_packets += agg->skb_num; |
| @@ -1079,7 +1082,7 @@ resubmit: | |||
| 1079 | netif_device_detach(tp->netdev); | 1082 | netif_device_detach(tp->netdev); |
| 1080 | else if (res) | 1083 | else if (res) |
| 1081 | netif_err(tp, intr, tp->netdev, | 1084 | netif_err(tp, intr, tp->netdev, |
| 1082 | "can't resubmit intr, status %d\n", res); | 1085 | "can't resubmit intr, status %d\n", res); |
| 1083 | } | 1086 | } |
| 1084 | 1087 | ||
| 1085 | static inline void *rx_agg_align(void *data) | 1088 | static inline void *rx_agg_align(void *data) |
| @@ -1490,7 +1493,7 @@ static void rtl8152_tx_timeout(struct net_device *netdev) | |||
| 1490 | struct r8152 *tp = netdev_priv(netdev); | 1493 | struct r8152 *tp = netdev_priv(netdev); |
| 1491 | int i; | 1494 | int i; |
| 1492 | 1495 | ||
| 1493 | netif_warn(tp, tx_err, netdev, "Tx timeout.\n"); | 1496 | netif_warn(tp, tx_err, netdev, "Tx timeout\n"); |
| 1494 | for (i = 0; i < RTL8152_MAX_TX; i++) | 1497 | for (i = 0; i < RTL8152_MAX_TX; i++) |
| 1495 | usb_unlink_urb(tp->tx_info[i].urb); | 1498 | usb_unlink_urb(tp->tx_info[i].urb); |
| 1496 | } | 1499 | } |
| @@ -2284,8 +2287,8 @@ static int rtl8152_open(struct net_device *netdev) | |||
| 2284 | if (res) { | 2287 | if (res) { |
| 2285 | if (res == -ENODEV) | 2288 | if (res == -ENODEV) |
| 2286 | netif_device_detach(tp->netdev); | 2289 | netif_device_detach(tp->netdev); |
| 2287 | netif_warn(tp, ifup, netdev, | 2290 | netif_warn(tp, ifup, netdev, "intr_urb submit failed: %d\n", |
| 2288 | "intr_urb submit failed: %d\n", res); | 2291 | res); |
| 2289 | return res; | 2292 | return res; |
| 2290 | } | 2293 | } |
| 2291 | 2294 | ||
| @@ -2754,7 +2757,7 @@ static int rtl8152_probe(struct usb_interface *intf, | |||
| 2754 | 2757 | ||
| 2755 | netdev = alloc_etherdev(sizeof(struct r8152)); | 2758 | netdev = alloc_etherdev(sizeof(struct r8152)); |
| 2756 | if (!netdev) { | 2759 | if (!netdev) { |
| 2757 | dev_err(&intf->dev, "Out of memory"); | 2760 | dev_err(&intf->dev, "Out of memory\n"); |
| 2758 | return -ENOMEM; | 2761 | return -ENOMEM; |
| 2759 | } | 2762 | } |
| 2760 | 2763 | ||
| @@ -2800,11 +2803,11 @@ static int rtl8152_probe(struct usb_interface *intf, | |||
| 2800 | 2803 | ||
| 2801 | ret = register_netdev(netdev); | 2804 | ret = register_netdev(netdev); |
| 2802 | if (ret != 0) { | 2805 | if (ret != 0) { |
| 2803 | netif_err(tp, probe, netdev, "couldn't register the device"); | 2806 | netif_err(tp, probe, netdev, "couldn't register the device\n"); |
| 2804 | goto out1; | 2807 | goto out1; |
| 2805 | } | 2808 | } |
| 2806 | 2809 | ||
| 2807 | netif_info(tp, probe, netdev, "%s", DRIVER_VERSION); | 2810 | netif_info(tp, probe, netdev, "%s\n", DRIVER_VERSION); |
| 2808 | 2811 | ||
| 2809 | return 0; | 2812 | return 0; |
| 2810 | 2813 | ||
