diff options
| -rw-r--r-- | fs/jfs/jfs_inode.c | 29 | ||||
| -rw-r--r-- | fs/jfs/namei.c | 24 |
2 files changed, 37 insertions, 16 deletions
diff --git a/fs/jfs/jfs_inode.c b/fs/jfs/jfs_inode.c index 70022fd1c539..d4d142c2edd4 100644 --- a/fs/jfs/jfs_inode.c +++ b/fs/jfs/jfs_inode.c | |||
| @@ -79,7 +79,8 @@ struct inode *ialloc(struct inode *parent, umode_t mode) | |||
| 79 | inode = new_inode(sb); | 79 | inode = new_inode(sb); |
| 80 | if (!inode) { | 80 | if (!inode) { |
| 81 | jfs_warn("ialloc: new_inode returned NULL!"); | 81 | jfs_warn("ialloc: new_inode returned NULL!"); |
| 82 | return ERR_PTR(-ENOMEM); | 82 | rc = -ENOMEM; |
| 83 | goto fail; | ||
| 83 | } | 84 | } |
| 84 | 85 | ||
| 85 | jfs_inode = JFS_IP(inode); | 86 | jfs_inode = JFS_IP(inode); |
| @@ -89,8 +90,12 @@ struct inode *ialloc(struct inode *parent, umode_t mode) | |||
| 89 | jfs_warn("ialloc: diAlloc returned %d!", rc); | 90 | jfs_warn("ialloc: diAlloc returned %d!", rc); |
| 90 | if (rc == -EIO) | 91 | if (rc == -EIO) |
| 91 | make_bad_inode(inode); | 92 | make_bad_inode(inode); |
| 92 | iput(inode); | 93 | goto fail_put; |
| 93 | return ERR_PTR(rc); | 94 | } |
| 95 | |||
| 96 | if (insert_inode_locked(inode) < 0) { | ||
| 97 | rc = -EINVAL; | ||
| 98 | goto fail_unlock; | ||
| 94 | } | 99 | } |
| 95 | 100 | ||
| 96 | inode->i_uid = current_fsuid(); | 101 | inode->i_uid = current_fsuid(); |
| @@ -112,11 +117,8 @@ struct inode *ialloc(struct inode *parent, umode_t mode) | |||
| 112 | * Allocate inode to quota. | 117 | * Allocate inode to quota. |
| 113 | */ | 118 | */ |
| 114 | if (DQUOT_ALLOC_INODE(inode)) { | 119 | if (DQUOT_ALLOC_INODE(inode)) { |
| 115 | DQUOT_DROP(inode); | 120 | rc = -EDQUOT; |
| 116 | inode->i_flags |= S_NOQUOTA; | 121 | goto fail_drop; |
| 117 | inode->i_nlink = 0; | ||
| 118 | iput(inode); | ||
| 119 | return ERR_PTR(-EDQUOT); | ||
| 120 | } | 122 | } |
| 121 | 123 | ||
| 122 | inode->i_mode = mode; | 124 | inode->i_mode = mode; |
| @@ -158,4 +160,15 @@ struct inode *ialloc(struct inode *parent, umode_t mode) | |||
| 158 | jfs_info("ialloc returns inode = 0x%p\n", inode); | 160 | jfs_info("ialloc returns inode = 0x%p\n", inode); |
| 159 | 161 | ||
| 160 | return inode; | 162 | return inode; |
| 163 | |||
| 164 | fail_drop: | ||
| 165 | DQUOT_DROP(inode); | ||
| 166 | inode->i_flags |= S_NOQUOTA; | ||
| 167 | fail_unlock: | ||
| 168 | inode->i_nlink = 0; | ||
| 169 | unlock_new_inode(inode); | ||
| 170 | fail_put: | ||
| 171 | iput(inode); | ||
| 172 | fail: | ||
| 173 | return ERR_PTR(rc); | ||
| 161 | } | 174 | } |
diff --git a/fs/jfs/namei.c b/fs/jfs/namei.c index cc3cedffbfa1..b4de56b851e4 100644 --- a/fs/jfs/namei.c +++ b/fs/jfs/namei.c | |||
| @@ -155,7 +155,6 @@ static int jfs_create(struct inode *dip, struct dentry *dentry, int mode, | |||
| 155 | ip->i_fop = &jfs_file_operations; | 155 | ip->i_fop = &jfs_file_operations; |
| 156 | ip->i_mapping->a_ops = &jfs_aops; | 156 | ip->i_mapping->a_ops = &jfs_aops; |
| 157 | 157 | ||
| 158 | insert_inode_hash(ip); | ||
| 159 | mark_inode_dirty(ip); | 158 | mark_inode_dirty(ip); |
| 160 | 159 | ||
| 161 | dip->i_ctime = dip->i_mtime = CURRENT_TIME; | 160 | dip->i_ctime = dip->i_mtime = CURRENT_TIME; |
| @@ -171,9 +170,12 @@ static int jfs_create(struct inode *dip, struct dentry *dentry, int mode, | |||
| 171 | if (rc) { | 170 | if (rc) { |
| 172 | free_ea_wmap(ip); | 171 | free_ea_wmap(ip); |
| 173 | ip->i_nlink = 0; | 172 | ip->i_nlink = 0; |
| 173 | unlock_new_inode(ip); | ||
| 174 | iput(ip); | 174 | iput(ip); |
| 175 | } else | 175 | } else { |
| 176 | d_instantiate(dentry, ip); | 176 | d_instantiate(dentry, ip); |
| 177 | unlock_new_inode(ip); | ||
| 178 | } | ||
| 177 | 179 | ||
| 178 | out2: | 180 | out2: |
| 179 | free_UCSname(&dname); | 181 | free_UCSname(&dname); |
| @@ -289,7 +291,6 @@ static int jfs_mkdir(struct inode *dip, struct dentry *dentry, int mode) | |||
| 289 | ip->i_op = &jfs_dir_inode_operations; | 291 | ip->i_op = &jfs_dir_inode_operations; |
| 290 | ip->i_fop = &jfs_dir_operations; | 292 | ip->i_fop = &jfs_dir_operations; |
| 291 | 293 | ||
| 292 | insert_inode_hash(ip); | ||
| 293 | mark_inode_dirty(ip); | 294 | mark_inode_dirty(ip); |
| 294 | 295 | ||
| 295 | /* update parent directory inode */ | 296 | /* update parent directory inode */ |
| @@ -306,9 +307,12 @@ static int jfs_mkdir(struct inode *dip, struct dentry *dentry, int mode) | |||
| 306 | if (rc) { | 307 | if (rc) { |
| 307 | free_ea_wmap(ip); | 308 | free_ea_wmap(ip); |
| 308 | ip->i_nlink = 0; | 309 | ip->i_nlink = 0; |
| 310 | unlock_new_inode(ip); | ||
| 309 | iput(ip); | 311 | iput(ip); |
| 310 | } else | 312 | } else { |
| 311 | d_instantiate(dentry, ip); | 313 | d_instantiate(dentry, ip); |
| 314 | unlock_new_inode(ip); | ||
| 315 | } | ||
| 312 | 316 | ||
| 313 | out2: | 317 | out2: |
| 314 | free_UCSname(&dname); | 318 | free_UCSname(&dname); |
| @@ -1019,7 +1023,6 @@ static int jfs_symlink(struct inode *dip, struct dentry *dentry, | |||
| 1019 | goto out3; | 1023 | goto out3; |
| 1020 | } | 1024 | } |
| 1021 | 1025 | ||
| 1022 | insert_inode_hash(ip); | ||
| 1023 | mark_inode_dirty(ip); | 1026 | mark_inode_dirty(ip); |
| 1024 | 1027 | ||
| 1025 | dip->i_ctime = dip->i_mtime = CURRENT_TIME; | 1028 | dip->i_ctime = dip->i_mtime = CURRENT_TIME; |
| @@ -1039,9 +1042,12 @@ static int jfs_symlink(struct inode *dip, struct dentry *dentry, | |||
| 1039 | if (rc) { | 1042 | if (rc) { |
| 1040 | free_ea_wmap(ip); | 1043 | free_ea_wmap(ip); |
| 1041 | ip->i_nlink = 0; | 1044 | ip->i_nlink = 0; |
| 1045 | unlock_new_inode(ip); | ||
| 1042 | iput(ip); | 1046 | iput(ip); |
| 1043 | } else | 1047 | } else { |
| 1044 | d_instantiate(dentry, ip); | 1048 | d_instantiate(dentry, ip); |
| 1049 | unlock_new_inode(ip); | ||
| 1050 | } | ||
| 1045 | 1051 | ||
| 1046 | out2: | 1052 | out2: |
| 1047 | free_UCSname(&dname); | 1053 | free_UCSname(&dname); |
| @@ -1399,7 +1405,6 @@ static int jfs_mknod(struct inode *dir, struct dentry *dentry, | |||
| 1399 | jfs_ip->dev = new_encode_dev(rdev); | 1405 | jfs_ip->dev = new_encode_dev(rdev); |
| 1400 | init_special_inode(ip, ip->i_mode, rdev); | 1406 | init_special_inode(ip, ip->i_mode, rdev); |
| 1401 | 1407 | ||
| 1402 | insert_inode_hash(ip); | ||
| 1403 | mark_inode_dirty(ip); | 1408 | mark_inode_dirty(ip); |
| 1404 | 1409 | ||
| 1405 | dir->i_ctime = dir->i_mtime = CURRENT_TIME; | 1410 | dir->i_ctime = dir->i_mtime = CURRENT_TIME; |
| @@ -1417,9 +1422,12 @@ static int jfs_mknod(struct inode *dir, struct dentry *dentry, | |||
| 1417 | if (rc) { | 1422 | if (rc) { |
| 1418 | free_ea_wmap(ip); | 1423 | free_ea_wmap(ip); |
| 1419 | ip->i_nlink = 0; | 1424 | ip->i_nlink = 0; |
| 1425 | unlock_new_inode(ip); | ||
| 1420 | iput(ip); | 1426 | iput(ip); |
| 1421 | } else | 1427 | } else { |
| 1422 | d_instantiate(dentry, ip); | 1428 | d_instantiate(dentry, ip); |
| 1429 | unlock_new_inode(ip); | ||
| 1430 | } | ||
| 1423 | 1431 | ||
| 1424 | out1: | 1432 | out1: |
| 1425 | free_UCSname(&dname); | 1433 | free_UCSname(&dname); |
