diff options
| -rw-r--r-- | drivers/net/vxlan.c | 29 |
1 files changed, 19 insertions, 10 deletions
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index cfb892b265e8..fa9dc45b75a6 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net/vxlan.c | |||
| @@ -275,13 +275,15 @@ static inline struct vxlan_rdst *first_remote_rtnl(struct vxlan_fdb *fdb) | |||
| 275 | return list_first_entry(&fdb->remotes, struct vxlan_rdst, list); | 275 | return list_first_entry(&fdb->remotes, struct vxlan_rdst, list); |
| 276 | } | 276 | } |
| 277 | 277 | ||
| 278 | /* Find VXLAN socket based on network namespace and UDP port */ | 278 | /* Find VXLAN socket based on network namespace, address family and UDP port */ |
| 279 | static struct vxlan_sock *vxlan_find_sock(struct net *net, __be16 port) | 279 | static struct vxlan_sock *vxlan_find_sock(struct net *net, |
| 280 | sa_family_t family, __be16 port) | ||
| 280 | { | 281 | { |
| 281 | struct vxlan_sock *vs; | 282 | struct vxlan_sock *vs; |
| 282 | 283 | ||
| 283 | hlist_for_each_entry_rcu(vs, vs_head(net, port), hlist) { | 284 | hlist_for_each_entry_rcu(vs, vs_head(net, port), hlist) { |
| 284 | if (inet_sk(vs->sock->sk)->inet_sport == port) | 285 | if (inet_sk(vs->sock->sk)->inet_sport == port && |
| 286 | inet_sk(vs->sock->sk)->sk.sk_family == family) | ||
| 285 | return vs; | 287 | return vs; |
| 286 | } | 288 | } |
| 287 | return NULL; | 289 | return NULL; |
| @@ -300,11 +302,12 @@ static struct vxlan_dev *vxlan_vs_find_vni(struct vxlan_sock *vs, u32 id) | |||
| 300 | } | 302 | } |
| 301 | 303 | ||
| 302 | /* Look up VNI in a per net namespace table */ | 304 | /* Look up VNI in a per net namespace table */ |
| 303 | static struct vxlan_dev *vxlan_find_vni(struct net *net, u32 id, __be16 port) | 305 | static struct vxlan_dev *vxlan_find_vni(struct net *net, u32 id, |
| 306 | sa_family_t family, __be16 port) | ||
| 304 | { | 307 | { |
| 305 | struct vxlan_sock *vs; | 308 | struct vxlan_sock *vs; |
| 306 | 309 | ||
| 307 | vs = vxlan_find_sock(net, port); | 310 | vs = vxlan_find_sock(net, family, port); |
| 308 | if (!vs) | 311 | if (!vs) |
| 309 | return NULL; | 312 | return NULL; |
| 310 | 313 | ||
| @@ -1773,7 +1776,8 @@ static void vxlan_xmit_one(struct sk_buff *skb, struct net_device *dev, | |||
| 1773 | struct vxlan_dev *dst_vxlan; | 1776 | struct vxlan_dev *dst_vxlan; |
| 1774 | 1777 | ||
| 1775 | ip_rt_put(rt); | 1778 | ip_rt_put(rt); |
| 1776 | dst_vxlan = vxlan_find_vni(vxlan->net, vni, dst_port); | 1779 | dst_vxlan = vxlan_find_vni(vxlan->net, vni, |
| 1780 | dst->sa.sa_family, dst_port); | ||
| 1777 | if (!dst_vxlan) | 1781 | if (!dst_vxlan) |
| 1778 | goto tx_error; | 1782 | goto tx_error; |
| 1779 | vxlan_encap_bypass(skb, vxlan, dst_vxlan); | 1783 | vxlan_encap_bypass(skb, vxlan, dst_vxlan); |
| @@ -1827,7 +1831,8 @@ static void vxlan_xmit_one(struct sk_buff *skb, struct net_device *dev, | |||
| 1827 | struct vxlan_dev *dst_vxlan; | 1831 | struct vxlan_dev *dst_vxlan; |
| 1828 | 1832 | ||
| 1829 | dst_release(ndst); | 1833 | dst_release(ndst); |
| 1830 | dst_vxlan = vxlan_find_vni(vxlan->net, vni, dst_port); | 1834 | dst_vxlan = vxlan_find_vni(vxlan->net, vni, |
| 1835 | dst->sa.sa_family, dst_port); | ||
| 1831 | if (!dst_vxlan) | 1836 | if (!dst_vxlan) |
| 1832 | goto tx_error; | 1837 | goto tx_error; |
| 1833 | vxlan_encap_bypass(skb, vxlan, dst_vxlan); | 1838 | vxlan_encap_bypass(skb, vxlan, dst_vxlan); |
| @@ -1987,13 +1992,15 @@ static int vxlan_init(struct net_device *dev) | |||
| 1987 | struct vxlan_dev *vxlan = netdev_priv(dev); | 1992 | struct vxlan_dev *vxlan = netdev_priv(dev); |
| 1988 | struct vxlan_net *vn = net_generic(vxlan->net, vxlan_net_id); | 1993 | struct vxlan_net *vn = net_generic(vxlan->net, vxlan_net_id); |
| 1989 | struct vxlan_sock *vs; | 1994 | struct vxlan_sock *vs; |
| 1995 | bool ipv6 = vxlan->flags & VXLAN_F_IPV6; | ||
| 1990 | 1996 | ||
| 1991 | dev->tstats = netdev_alloc_pcpu_stats(struct pcpu_sw_netstats); | 1997 | dev->tstats = netdev_alloc_pcpu_stats(struct pcpu_sw_netstats); |
| 1992 | if (!dev->tstats) | 1998 | if (!dev->tstats) |
| 1993 | return -ENOMEM; | 1999 | return -ENOMEM; |
| 1994 | 2000 | ||
| 1995 | spin_lock(&vn->sock_lock); | 2001 | spin_lock(&vn->sock_lock); |
| 1996 | vs = vxlan_find_sock(vxlan->net, vxlan->dst_port); | 2002 | vs = vxlan_find_sock(vxlan->net, ipv6 ? AF_INET6 : AF_INET, |
| 2003 | vxlan->dst_port); | ||
| 1997 | if (vs) { | 2004 | if (vs) { |
| 1998 | /* If we have a socket with same port already, reuse it */ | 2005 | /* If we have a socket with same port already, reuse it */ |
| 1999 | atomic_inc(&vs->refcnt); | 2006 | atomic_inc(&vs->refcnt); |
| @@ -2384,6 +2391,7 @@ struct vxlan_sock *vxlan_sock_add(struct net *net, __be16 port, | |||
| 2384 | { | 2391 | { |
| 2385 | struct vxlan_net *vn = net_generic(net, vxlan_net_id); | 2392 | struct vxlan_net *vn = net_generic(net, vxlan_net_id); |
| 2386 | struct vxlan_sock *vs; | 2393 | struct vxlan_sock *vs; |
| 2394 | bool ipv6 = flags & VXLAN_F_IPV6; | ||
| 2387 | 2395 | ||
| 2388 | vs = vxlan_socket_create(net, port, rcv, data, flags); | 2396 | vs = vxlan_socket_create(net, port, rcv, data, flags); |
| 2389 | if (!IS_ERR(vs)) | 2397 | if (!IS_ERR(vs)) |
| @@ -2393,7 +2401,7 @@ struct vxlan_sock *vxlan_sock_add(struct net *net, __be16 port, | |||
| 2393 | return vs; | 2401 | return vs; |
| 2394 | 2402 | ||
| 2395 | spin_lock(&vn->sock_lock); | 2403 | spin_lock(&vn->sock_lock); |
| 2396 | vs = vxlan_find_sock(net, port); | 2404 | vs = vxlan_find_sock(net, ipv6 ? AF_INET6 : AF_INET, port); |
| 2397 | if (vs) { | 2405 | if (vs) { |
| 2398 | if (vs->rcv == rcv) | 2406 | if (vs->rcv == rcv) |
| 2399 | atomic_inc(&vs->refcnt); | 2407 | atomic_inc(&vs->refcnt); |
| @@ -2552,7 +2560,8 @@ static int vxlan_newlink(struct net *net, struct net_device *dev, | |||
| 2552 | nla_get_u8(data[IFLA_VXLAN_UDP_ZERO_CSUM6_RX])) | 2560 | nla_get_u8(data[IFLA_VXLAN_UDP_ZERO_CSUM6_RX])) |
| 2553 | vxlan->flags |= VXLAN_F_UDP_ZERO_CSUM6_RX; | 2561 | vxlan->flags |= VXLAN_F_UDP_ZERO_CSUM6_RX; |
| 2554 | 2562 | ||
| 2555 | if (vxlan_find_vni(net, vni, vxlan->dst_port)) { | 2563 | if (vxlan_find_vni(net, vni, use_ipv6 ? AF_INET6 : AF_INET, |
| 2564 | vxlan->dst_port)) { | ||
| 2556 | pr_info("duplicate VNI %u\n", vni); | 2565 | pr_info("duplicate VNI %u\n", vni); |
| 2557 | return -EEXIST; | 2566 | return -EEXIST; |
| 2558 | } | 2567 | } |
