diff options
-rw-r--r-- | net/mac80211/rx.c | 24 |
1 files changed, 24 insertions, 0 deletions
diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c index b67221def584..902b03ee8f60 100644 --- a/net/mac80211/rx.c +++ b/net/mac80211/rx.c | |||
@@ -622,6 +622,26 @@ static void ieee80211_sta_reorder_release(struct ieee80211_hw *hw, | |||
622 | tid_agg_rx->buf_size; | 622 | tid_agg_rx->buf_size; |
623 | } | 623 | } |
624 | 624 | ||
625 | /* | ||
626 | * Disable the reorder release timer for now. | ||
627 | * | ||
628 | * The current implementation lacks a proper locking scheme | ||
629 | * which would protect vital statistic and debug counters | ||
630 | * from being updated by two different but concurrent BHs. | ||
631 | * | ||
632 | * More information about the topic is available from: | ||
633 | * - thread: http://marc.info/?t=128635927000001 | ||
634 | * | ||
635 | * What was wrong: | ||
636 | * => http://marc.info/?l=linux-wireless&m=128636170811964 | ||
637 | * "Basically the thing is that until your patch, the data | ||
638 | * in the struct didn't actually need locking because it | ||
639 | * was accessed by the RX path only which is not concurrent." | ||
640 | * | ||
641 | * List of what needs to be fixed: | ||
642 | * => http://marc.info/?l=linux-wireless&m=128656352920957 | ||
643 | * | ||
644 | |||
625 | if (tid_agg_rx->stored_mpdu_num) { | 645 | if (tid_agg_rx->stored_mpdu_num) { |
626 | j = index = seq_sub(tid_agg_rx->head_seq_num, | 646 | j = index = seq_sub(tid_agg_rx->head_seq_num, |
627 | tid_agg_rx->ssn) % tid_agg_rx->buf_size; | 647 | tid_agg_rx->ssn) % tid_agg_rx->buf_size; |
@@ -640,6 +660,10 @@ static void ieee80211_sta_reorder_release(struct ieee80211_hw *hw, | |||
640 | } else { | 660 | } else { |
641 | del_timer(&tid_agg_rx->reorder_timer); | 661 | del_timer(&tid_agg_rx->reorder_timer); |
642 | } | 662 | } |
663 | */ | ||
664 | |||
665 | set_release_timer: | ||
666 | return; | ||
643 | } | 667 | } |
644 | 668 | ||
645 | /* | 669 | /* |