aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--net/ceph/osdmap.c14
1 files changed, 8 insertions, 6 deletions
diff --git a/net/ceph/osdmap.c b/net/ceph/osdmap.c
index 11649101a4a8..39938d79756c 100644
--- a/net/ceph/osdmap.c
+++ b/net/ceph/osdmap.c
@@ -506,7 +506,7 @@ static void __remove_pg_pool(struct rb_root *root, struct ceph_pg_pool_info *pi)
506 kfree(pi); 506 kfree(pi);
507} 507}
508 508
509static int __decode_pool(void **p, void *end, struct ceph_pg_pool_info *pi) 509static int decode_pool(void **p, void *end, struct ceph_pg_pool_info *pi)
510{ 510{
511 u8 ev, cv; 511 u8 ev, cv;
512 unsigned len, num; 512 unsigned len, num;
@@ -587,7 +587,7 @@ bad:
587 return -EINVAL; 587 return -EINVAL;
588} 588}
589 589
590static int __decode_pool_names(void **p, void *end, struct ceph_osdmap *map) 590static int decode_pool_names(void **p, void *end, struct ceph_osdmap *map)
591{ 591{
592 struct ceph_pg_pool_info *pi; 592 struct ceph_pg_pool_info *pi;
593 u32 num, len; 593 u32 num, len;
@@ -723,7 +723,7 @@ static int osdmap_decode(void **p, void *end, struct ceph_osdmap *map)
723 goto bad; 723 goto bad;
724 } 724 }
725 pi->id = ceph_decode_64(p); 725 pi->id = ceph_decode_64(p);
726 err = __decode_pool(p, end, pi); 726 err = decode_pool(p, end, pi);
727 if (err < 0) { 727 if (err < 0) {
728 kfree(pi); 728 kfree(pi);
729 goto bad; 729 goto bad;
@@ -731,7 +731,8 @@ static int osdmap_decode(void **p, void *end, struct ceph_osdmap *map)
731 __insert_pg_pool(&map->pg_pools, pi); 731 __insert_pg_pool(&map->pg_pools, pi);
732 } 732 }
733 733
734 err = __decode_pool_names(p, end, map); 734 /* pool_name */
735 err = decode_pool_names(p, end, map);
735 if (err) 736 if (err)
736 goto bad; 737 goto bad;
737 738
@@ -949,12 +950,13 @@ struct ceph_osdmap *osdmap_apply_incremental(void **p, void *end,
949 pi->id = pool; 950 pi->id = pool;
950 __insert_pg_pool(&map->pg_pools, pi); 951 __insert_pg_pool(&map->pg_pools, pi);
951 } 952 }
952 err = __decode_pool(p, end, pi); 953 err = decode_pool(p, end, pi);
953 if (err < 0) 954 if (err < 0)
954 goto bad; 955 goto bad;
955 } 956 }
956 957
957 err = __decode_pool_names(p, end, map); 958 /* new_pool_names */
959 err = decode_pool_names(p, end, map);
958 if (err) 960 if (err)
959 goto bad; 961 goto bad;
960 962