diff options
| -rw-r--r-- | drivers/infiniband/core/cm.c | 23 | ||||
| -rw-r--r-- | drivers/infiniband/core/cm_msgs.h | 4 | ||||
| -rw-r--r-- | include/rdma/ib_cm.h | 7 |
3 files changed, 17 insertions, 17 deletions
diff --git a/drivers/infiniband/core/cm.c b/drivers/infiniband/core/cm.c index e28a494e2a3a..0c1419105ff0 100644 --- a/drivers/infiniband/core/cm.c +++ b/drivers/infiniband/core/cm.c | |||
| @@ -437,39 +437,38 @@ static struct cm_id_private * cm_acquire_id(__be32 local_id, __be32 remote_id) | |||
| 437 | return cm_id_priv; | 437 | return cm_id_priv; |
| 438 | } | 438 | } |
| 439 | 439 | ||
| 440 | static void cm_mask_copy(u8 *dst, u8 *src, u8 *mask) | 440 | static void cm_mask_copy(u32 *dst, const u32 *src, const u32 *mask) |
| 441 | { | 441 | { |
| 442 | int i; | 442 | int i; |
| 443 | 443 | ||
| 444 | for (i = 0; i < IB_CM_COMPARE_SIZE / sizeof(unsigned long); i++) | 444 | for (i = 0; i < IB_CM_COMPARE_SIZE; i++) |
| 445 | ((unsigned long *) dst)[i] = ((unsigned long *) src)[i] & | 445 | dst[i] = src[i] & mask[i]; |
| 446 | ((unsigned long *) mask)[i]; | ||
| 447 | } | 446 | } |
| 448 | 447 | ||
| 449 | static int cm_compare_data(struct ib_cm_compare_data *src_data, | 448 | static int cm_compare_data(struct ib_cm_compare_data *src_data, |
| 450 | struct ib_cm_compare_data *dst_data) | 449 | struct ib_cm_compare_data *dst_data) |
| 451 | { | 450 | { |
| 452 | u8 src[IB_CM_COMPARE_SIZE]; | 451 | u32 src[IB_CM_COMPARE_SIZE]; |
| 453 | u8 dst[IB_CM_COMPARE_SIZE]; | 452 | u32 dst[IB_CM_COMPARE_SIZE]; |
| 454 | 453 | ||
| 455 | if (!src_data || !dst_data) | 454 | if (!src_data || !dst_data) |
| 456 | return 0; | 455 | return 0; |
| 457 | 456 | ||
| 458 | cm_mask_copy(src, src_data->data, dst_data->mask); | 457 | cm_mask_copy(src, src_data->data, dst_data->mask); |
| 459 | cm_mask_copy(dst, dst_data->data, src_data->mask); | 458 | cm_mask_copy(dst, dst_data->data, src_data->mask); |
| 460 | return memcmp(src, dst, IB_CM_COMPARE_SIZE); | 459 | return memcmp(src, dst, sizeof(src)); |
| 461 | } | 460 | } |
| 462 | 461 | ||
| 463 | static int cm_compare_private_data(u8 *private_data, | 462 | static int cm_compare_private_data(u32 *private_data, |
| 464 | struct ib_cm_compare_data *dst_data) | 463 | struct ib_cm_compare_data *dst_data) |
| 465 | { | 464 | { |
| 466 | u8 src[IB_CM_COMPARE_SIZE]; | 465 | u32 src[IB_CM_COMPARE_SIZE]; |
| 467 | 466 | ||
| 468 | if (!dst_data) | 467 | if (!dst_data) |
| 469 | return 0; | 468 | return 0; |
| 470 | 469 | ||
| 471 | cm_mask_copy(src, private_data, dst_data->mask); | 470 | cm_mask_copy(src, private_data, dst_data->mask); |
| 472 | return memcmp(src, dst_data->data, IB_CM_COMPARE_SIZE); | 471 | return memcmp(src, dst_data->data, sizeof(src)); |
| 473 | } | 472 | } |
| 474 | 473 | ||
| 475 | /* | 474 | /* |
| @@ -538,7 +537,7 @@ static struct cm_id_private * cm_insert_listen(struct cm_id_private *cm_id_priv) | |||
| 538 | 537 | ||
| 539 | static struct cm_id_private * cm_find_listen(struct ib_device *device, | 538 | static struct cm_id_private * cm_find_listen(struct ib_device *device, |
| 540 | __be64 service_id, | 539 | __be64 service_id, |
| 541 | u8 *private_data) | 540 | u32 *private_data) |
| 542 | { | 541 | { |
| 543 | struct rb_node *node = cm.listen_service_table.rb_node; | 542 | struct rb_node *node = cm.listen_service_table.rb_node; |
| 544 | struct cm_id_private *cm_id_priv; | 543 | struct cm_id_private *cm_id_priv; |
| @@ -953,7 +952,7 @@ int ib_cm_listen(struct ib_cm_id *cm_id, __be64 service_id, __be64 service_mask, | |||
| 953 | cm_mask_copy(cm_id_priv->compare_data->data, | 952 | cm_mask_copy(cm_id_priv->compare_data->data, |
| 954 | compare_data->data, compare_data->mask); | 953 | compare_data->data, compare_data->mask); |
| 955 | memcpy(cm_id_priv->compare_data->mask, compare_data->mask, | 954 | memcpy(cm_id_priv->compare_data->mask, compare_data->mask, |
| 956 | IB_CM_COMPARE_SIZE); | 955 | sizeof(compare_data->mask)); |
| 957 | } | 956 | } |
| 958 | 957 | ||
| 959 | cm_id->state = IB_CM_LISTEN; | 958 | cm_id->state = IB_CM_LISTEN; |
diff --git a/drivers/infiniband/core/cm_msgs.h b/drivers/infiniband/core/cm_msgs.h index be068f47e47e..8b76f0ef965e 100644 --- a/drivers/infiniband/core/cm_msgs.h +++ b/drivers/infiniband/core/cm_msgs.h | |||
| @@ -103,7 +103,7 @@ struct cm_req_msg { | |||
| 103 | /* local ACK timeout:5, rsvd:3 */ | 103 | /* local ACK timeout:5, rsvd:3 */ |
| 104 | u8 alt_offset139; | 104 | u8 alt_offset139; |
| 105 | 105 | ||
| 106 | u8 private_data[IB_CM_REQ_PRIVATE_DATA_SIZE]; | 106 | u32 private_data[IB_CM_REQ_PRIVATE_DATA_SIZE / sizeof(u32)]; |
| 107 | 107 | ||
| 108 | } __attribute__ ((packed)); | 108 | } __attribute__ ((packed)); |
| 109 | 109 | ||
| @@ -801,7 +801,7 @@ struct cm_sidr_req_msg { | |||
| 801 | __be16 rsvd; | 801 | __be16 rsvd; |
| 802 | __be64 service_id; | 802 | __be64 service_id; |
| 803 | 803 | ||
| 804 | u8 private_data[IB_CM_SIDR_REQ_PRIVATE_DATA_SIZE]; | 804 | u32 private_data[IB_CM_SIDR_REQ_PRIVATE_DATA_SIZE / sizeof(u32)]; |
| 805 | } __attribute__ ((packed)); | 805 | } __attribute__ ((packed)); |
| 806 | 806 | ||
| 807 | struct cm_sidr_rep_msg { | 807 | struct cm_sidr_rep_msg { |
diff --git a/include/rdma/ib_cm.h b/include/rdma/ib_cm.h index 0e3ff30647d5..39ed2d2fbd51 100644 --- a/include/rdma/ib_cm.h +++ b/include/rdma/ib_cm.h | |||
| @@ -105,7 +105,8 @@ enum ib_cm_data_size { | |||
| 105 | IB_CM_SIDR_REQ_PRIVATE_DATA_SIZE = 216, | 105 | IB_CM_SIDR_REQ_PRIVATE_DATA_SIZE = 216, |
| 106 | IB_CM_SIDR_REP_PRIVATE_DATA_SIZE = 136, | 106 | IB_CM_SIDR_REP_PRIVATE_DATA_SIZE = 136, |
| 107 | IB_CM_SIDR_REP_INFO_LENGTH = 72, | 107 | IB_CM_SIDR_REP_INFO_LENGTH = 72, |
| 108 | IB_CM_COMPARE_SIZE = 64 | 108 | /* compare done u32 at a time */ |
| 109 | IB_CM_COMPARE_SIZE = (64 / sizeof(u32)) | ||
| 109 | }; | 110 | }; |
| 110 | 111 | ||
| 111 | struct ib_cm_id; | 112 | struct ib_cm_id; |
| @@ -337,8 +338,8 @@ void ib_destroy_cm_id(struct ib_cm_id *cm_id); | |||
| 337 | #define IB_SDP_SERVICE_ID_MASK cpu_to_be64(0xFFFFFFFFFFFF0000ULL) | 338 | #define IB_SDP_SERVICE_ID_MASK cpu_to_be64(0xFFFFFFFFFFFF0000ULL) |
| 338 | 339 | ||
| 339 | struct ib_cm_compare_data { | 340 | struct ib_cm_compare_data { |
| 340 | u8 data[IB_CM_COMPARE_SIZE]; | 341 | u32 data[IB_CM_COMPARE_SIZE]; |
| 341 | u8 mask[IB_CM_COMPARE_SIZE]; | 342 | u32 mask[IB_CM_COMPARE_SIZE]; |
| 342 | }; | 343 | }; |
| 343 | 344 | ||
| 344 | /** | 345 | /** |
