6 files changed, 28 insertions, 17 deletions

diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
index f7d71190aad5..6adee4c2afc0 100644
--- a/drivers/gpu/drm/drm_gem.c
+++ b/drivers/gpu/drm/drm_gem.c
@@ -441,18 +441,31 @@ EXPORT_SYMBOL(drm_gem_create_mmap_offset);
  * drm_gem_get_pages - helper to allocate backing pages for a GEM object
  * from shmem
  * @obj: obj in question
- * @gfpmask: gfp mask of requested pages
+ *
+ * This reads the page-array of the shmem-backing storage of the given gem
+ * object. An array of pages is returned. If a page is not allocated or
+ * swapped-out, this will allocate/swap-in the required pages. Note that the
+ * whole object is covered by the page-array and pinned in memory.
+ *
+ * Use drm_gem_put_pages() to release the array and unpin all pages.
+ *
+ * This uses the GFP-mask set on the shmem-mapping (see mapping_set_gfp_mask()).
+ * If you require other GFP-masks, you have to do those allocations yourself.
+ *
+ * Note that you are not allowed to change gfp-zones during runtime. That is,
+ * shmem_read_mapping_page_gfp() must be called with the same gfp_zone(gfp) as
+ * set during initialization. If you have special zone constraints, set them
+ * after drm_gem_init_object() via mapping_set_gfp_mask(). shmem-core takes care
+ * to keep pages in the required zone during swap-in.
  */
-struct page **drm_gem_get_pages(struct drm_gem_object *obj, gfp_t gfpmask)
+struct page **drm_gem_get_pages(struct drm_gem_object *obj)
 {
-        struct inode *inode;
         struct address_space *mapping;
         struct page *p, **pages;
         int i, npages;
 
         /* This is the shared memory object that backs the GEM resource */
-        inode = file_inode(obj->filp);
-        mapping = inode->i_mapping;
+        mapping = file_inode(obj->filp)->i_mapping;
 
         /* We already BUG_ON() for non-page-aligned sizes in
          * drm_gem_object_init(), so we should never hit this unless
@@ -466,10 +479,8 @@ struct page **drm_gem_get_pages(struct drm_gem_object *obj, gfp_t gfpmask)
         if (pages == NULL)
                 return ERR_PTR(-ENOMEM);
 
-        gfpmask |= mapping_gfp_mask(mapping);
-
         for (i = 0; i < npages; i++) {
-                p = shmem_read_mapping_page_gfp(mapping, i, gfpmask);
+                p = shmem_read_mapping_page(mapping, i);
                 if (IS_ERR(p))
                         goto fail;
                 pages[i] = p;
@@ -479,7 +490,7 @@ struct page **drm_gem_get_pages(struct drm_gem_object *obj, gfp_t gfpmask)
                  * __GFP_DMA32 to be set in mapping_gfp_mask(inode->i_mapping)
                  * so shmem can relocate pages during swapin if required.
                  */
-                BUG_ON((gfpmask & __GFP_DMA32) &&
+                BUG_ON((mapping_gfp_mask(mapping) & __GFP_DMA32) &&
                                 (page_to_pfn(p) >= 0x00100000UL));
         }
 
diff --git a/drivers/gpu/drm/gma500/gtt.c b/drivers/gpu/drm/gma500/gtt.c
index 592d205a0089..ce015db59dc6 100644
--- a/drivers/gpu/drm/gma500/gtt.c
+++ b/drivers/gpu/drm/gma500/gtt.c
@@ -206,7 +206,7 @@ static int psb_gtt_attach_pages(struct gtt_range *gt)
 
         WARN_ON(gt->pages);
 
-        pages = drm_gem_get_pages(&gt->gem, 0);
+        pages = drm_gem_get_pages(&gt->gem);
         if (IS_ERR(pages))
                 return PTR_ERR(pages);
 
diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c
index bb8026daebc9..6866879efa3b 100644
--- a/drivers/gpu/drm/msm/msm_gem.c
+++ b/drivers/gpu/drm/msm/msm_gem.c
@@ -73,7 +73,7 @@ static struct page **get_pages(struct drm_gem_object *obj)
                 int npages = obj->size >> PAGE_SHIFT;
 
                 if (iommu_present(&platform_bus_type))
-                        p = drm_gem_get_pages(obj, 0);
+                        p = drm_gem_get_pages(obj);
                 else
                         p = get_pages_vram(obj, npages);
 
diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm/omap_gem.c
index 1331fd538398..7c68c8a18939 100644
--- a/drivers/gpu/drm/omapdrm/omap_gem.c
+++ b/drivers/gpu/drm/omapdrm/omap_gem.c
@@ -233,7 +233,7 @@ static int omap_gem_attach_pages(struct drm_gem_object *obj)
 
         WARN_ON(omap_obj->pages);
 
-        pages = drm_gem_get_pages(obj, GFP_KERNEL);
+        pages = drm_gem_get_pages(obj);
         if (IS_ERR(pages)) {
                 dev_err(obj->dev->dev, "could not get pages: %ld\n", PTR_ERR(pages));
                 return PTR_ERR(pages);
diff --git a/drivers/gpu/drm/udl/udl_gem.c b/drivers/gpu/drm/udl/udl_gem.c
index c041cd73f399..8044f5fb7c49 100644
--- a/drivers/gpu/drm/udl/udl_gem.c
+++ b/drivers/gpu/drm/udl/udl_gem.c
@@ -107,14 +107,14 @@ int udl_gem_fault(struct vm_area_struct *vma, struct vm_fault *vmf)
         }
 }
 
-static int udl_gem_get_pages(struct udl_gem_object *obj, gfp_t gfpmask)
+static int udl_gem_get_pages(struct udl_gem_object *obj)
 {
         struct page **pages;
 
         if (obj->pages)
                 return 0;
 
-        pages = drm_gem_get_pages(&obj->base, gfpmask);
+        pages = drm_gem_get_pages(&obj->base);
         if (IS_ERR(pages))
                 return PTR_ERR(pages);
 
@@ -147,7 +147,7 @@ int udl_gem_vmap(struct udl_gem_object *obj)
                 return 0;
         }
                 
-        ret = udl_gem_get_pages(obj, GFP_KERNEL);
+        ret = udl_gem_get_pages(obj);
         if (ret)
                 return ret;
 
@@ -205,7 +205,7 @@ int udl_gem_mmap(struct drm_file *file, struct drm_device *dev,
         }
         gobj = to_udl_bo(obj);
 
-        ret = udl_gem_get_pages(gobj, GFP_KERNEL);
+        ret = udl_gem_get_pages(gobj);
         if (ret)
                 goto out;
         ret = drm_gem_create_mmap_offset(obj);
diff --git a/include/drm/drmP.h b/include/drm/drmP.h
index 8af71a8e2c00..57c07cd89a6a 100644
--- a/include/drm/drmP.h
+++ b/include/drm/drmP.h
@@ -1574,7 +1574,7 @@ void drm_gem_free_mmap_offset(struct drm_gem_object *obj);
 int drm_gem_create_mmap_offset(struct drm_gem_object *obj);
 int drm_gem_create_mmap_offset_size(struct drm_gem_object *obj, size_t size);
 
-struct page **drm_gem_get_pages(struct drm_gem_object *obj, gfp_t gfpmask);
+struct page **drm_gem_get_pages(struct drm_gem_object *obj);
 void drm_gem_put_pages(struct drm_gem_object *obj, struct page **pages,
                 bool dirty, bool accessed);