diff options
| -rw-r--r-- | net/netfilter/nf_tables_api.c | 21 |
1 files changed, 12 insertions, 9 deletions
diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c index 199fd0f27b0e..a8c94620f20e 100644 --- a/net/netfilter/nf_tables_api.c +++ b/net/netfilter/nf_tables_api.c | |||
| @@ -3612,12 +3612,11 @@ static int nf_tables_commit(struct sk_buff *skb) | |||
| 3612 | &te->elem, | 3612 | &te->elem, |
| 3613 | NFT_MSG_DELSETELEM, 0); | 3613 | NFT_MSG_DELSETELEM, 0); |
| 3614 | te->set->ops->get(te->set, &te->elem); | 3614 | te->set->ops->get(te->set, &te->elem); |
| 3615 | te->set->ops->remove(te->set, &te->elem); | ||
| 3616 | nft_data_uninit(&te->elem.key, NFT_DATA_VALUE); | 3615 | nft_data_uninit(&te->elem.key, NFT_DATA_VALUE); |
| 3617 | if (te->elem.flags & NFT_SET_MAP) { | 3616 | if (te->set->flags & NFT_SET_MAP && |
| 3618 | nft_data_uninit(&te->elem.data, | 3617 | !(te->elem.flags & NFT_SET_ELEM_INTERVAL_END)) |
| 3619 | te->set->dtype); | 3618 | nft_data_uninit(&te->elem.data, te->set->dtype); |
| 3620 | } | 3619 | te->set->ops->remove(te->set, &te->elem); |
| 3621 | nft_trans_destroy(trans); | 3620 | nft_trans_destroy(trans); |
| 3622 | break; | 3621 | break; |
| 3623 | } | 3622 | } |
| @@ -3658,7 +3657,7 @@ static int nf_tables_abort(struct sk_buff *skb) | |||
| 3658 | { | 3657 | { |
| 3659 | struct net *net = sock_net(skb->sk); | 3658 | struct net *net = sock_net(skb->sk); |
| 3660 | struct nft_trans *trans, *next; | 3659 | struct nft_trans *trans, *next; |
| 3661 | struct nft_set *set; | 3660 | struct nft_trans_elem *te; |
| 3662 | 3661 | ||
| 3663 | list_for_each_entry_safe(trans, next, &net->nft.commit_list, list) { | 3662 | list_for_each_entry_safe(trans, next, &net->nft.commit_list, list) { |
| 3664 | switch (trans->msg_type) { | 3663 | switch (trans->msg_type) { |
| @@ -3719,9 +3718,13 @@ static int nf_tables_abort(struct sk_buff *skb) | |||
| 3719 | break; | 3718 | break; |
| 3720 | case NFT_MSG_NEWSETELEM: | 3719 | case NFT_MSG_NEWSETELEM: |
| 3721 | nft_trans_elem_set(trans)->nelems--; | 3720 | nft_trans_elem_set(trans)->nelems--; |
| 3722 | set = nft_trans_elem_set(trans); | 3721 | te = (struct nft_trans_elem *)trans->data; |
| 3723 | set->ops->get(set, &nft_trans_elem(trans)); | 3722 | te->set->ops->get(te->set, &te->elem); |
| 3724 | set->ops->remove(set, &nft_trans_elem(trans)); | 3723 | nft_data_uninit(&te->elem.key, NFT_DATA_VALUE); |
| 3724 | if (te->set->flags & NFT_SET_MAP && | ||
| 3725 | !(te->elem.flags & NFT_SET_ELEM_INTERVAL_END)) | ||
| 3726 | nft_data_uninit(&te->elem.data, te->set->dtype); | ||
| 3727 | te->set->ops->remove(te->set, &te->elem); | ||
| 3725 | nft_trans_destroy(trans); | 3728 | nft_trans_destroy(trans); |
| 3726 | break; | 3729 | break; |
| 3727 | case NFT_MSG_DELSETELEM: | 3730 | case NFT_MSG_DELSETELEM: |
